Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either.

2011-04-29 Thread Blue Swirl
On Sat, Apr 30, 2011 at 1:39 AM, Richard Henderson wrote: > On 04/29/2011 01:53 PM, Blue Swirl wrote: >>> +                                               CPU_INTERRUPT_TIMER | >> >> Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, >> only cleared or checked. How >> about removi

Re: [Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-04-29 Thread Blue Swirl
On Sat, Apr 30, 2011 at 1:40 AM, Luiz Capitulino wrote: > This series introduces the inject-nmi command for QMP, which sends an > NMI to _all_ guest's CPUs. > > Also note that this series changes the human monitor nmi command to use > the QMP implementation, which means that it now has a DIFFERENT

Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either.

2011-04-29 Thread Richard Henderson
On 04/29/2011 01:53 PM, Blue Swirl wrote: >> + CPU_INTERRUPT_TIMER | > > Grepping for CPU_INTERRUPT_TIMER shows that the flag isn't ever set, > only cleared or checked. How > about removing the flag instead? Certainly Sparc and MIPS shouldn't check it

Re: [Qemu-devel] [PATCH 1/2] Support for MIPS64 user mode emulation

2011-04-29 Thread Khansa Butt
Please see comments highlighted in green. On Fri, Apr 29, 2011 at 2:01 PM, Aurelien Jarno wrote: > On Mon, Apr 25, 2011 at 04:54:19PM +0500, Khansa Butt wrote: > > please see inline comments highlighted in red color. > > > > On Wed, Apr 13, 2011 at 2:32 AM, Aurelien Jarno >wrote: > > > > > [I do

[Qemu-devel] xtensa: new target architecture for qemu

2011-04-29 Thread Max Filippov
Hello. I'm developing support for new qemu target architecture: xtensa [1], primarily because AFAIK there's no free/open simulator for this architecture. Essential ISA parts (like core opcodes, special registers, windowed registers, exceptions and interrupts) are implemented, other (like TLB, MMU

Re: [Qemu-devel] [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 02:09:54PM +0200, Gerd Hoffmann wrote: > On 04/28/11 10:29, Alon Levy wrote: > >With this you can output the command log and/or the guest debug (driver) > >output to a chardev instead of stderr: > > > >-global qxl-vga.cmdlog_chardev=qxl_cmdlog_chardev > >-global qxl-vga.debu

[Qemu-devel] [PATCH] vfio: Fix free in dma mapping error path

2011-04-29 Thread Alex Williamson
This is allocated via vmalloc, so needs vfree, not kfree. Signed-off-by: Alex Williamson --- drivers/vfio/vfio_dma.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/vfio/vfio_dma.c b/drivers/vfio/vfio_dma.c index cee1a25..4a488b6 100644 --- a/drivers/vfio/vfio_

[Qemu-devel] [PATCH v2] monitor: add PPC BookE SPRs

2011-04-29 Thread Scott Wood
Read them via KVM_GET_SREGS in kvm_arch_get_registers(), and display them in "info registers". Also get CR and PID from the existing KVM_GET_REGS. Signed-off-by: Scott Wood --- v2: fix a couple style oversights, and cache kvm caps as requested This version depends on http://patchwork.ozlabs.org

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-29 Thread Brad Hards
On Thursday 28 April 2011 20:46:25 Gerd Hoffmann wrote: > I think it would be much better to keep track of the mouse position (and > button state while being at it) in input.c instead of monitor.c. > > Once this is in place it should be easy to add kbd_mouse_* functions > which update position or

[Qemu-devel] [PATCH 1/3] QMP: QError: New QERR_UNSUPPORTED

2011-04-29 Thread Luiz Capitulino
From: Lai Jiangshan New QERR_UNSUPPORTED for unsupported commands or requests. Signed-off-by: Luiz Capitulino --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index 4855604..4f3b7ca 100644 --- a/qerror.c +++ b/qer

[Qemu-devel] [PATCH 0/3]: QMP: Introduce inject-nmi command

2011-04-29 Thread Luiz Capitulino
This series introduces the inject-nmi command for QMP, which sends an NMI to _all_ guest's CPUs. Also note that this series changes the human monitor nmi command to use the QMP implementation, which means that it now has a DIFFERENT behavior. Please, check patch 3/3 for details.

[Qemu-devel] [PATCH 3/3] HMP: Use QMP inject nmi implementation

2011-04-29 Thread Luiz Capitulino
This **CHANGES** the human monitor "nmi" command behavior. Currently it accepts an CPU argument which, when provided, will send the NMI to the specified CPU. This feature is of discussable value though and HMP shouldn't have more features than QMP, so let's use QMP's instead (it's also simpler).

[Qemu-devel] [PATCH 2/3] QMP: add inject-nmi qmp command

2011-04-29 Thread Luiz Capitulino
From: Lai Jiangshan inject-nmi command injects an NMI on all CPUs of guest. It is only supported for x86 guest currently, it will returns "Unsupported" error for non-x86 guest. Signed-off-by: Luiz Capitulino --- monitor.c | 17 + qmp-commands.hx | 27 +

Re: [Qemu-devel] [PATCH 0/4] spice: fix locking

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 02:20:09PM +0300, Alon Levy wrote: > On Fri, Apr 29, 2011 at 11:38:28AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > This patch series moves a bunch of work spice has to do from spice > > server thread context to iothread context, which in turn allows to > > drop the curre

Re: [Qemu-devel] [PATCH 0/2 V9] hmp,qmp: add inject-nmi

2011-04-29 Thread Luiz Capitulino
On Thu, 28 Apr 2011 11:35:20 +0800 Lai Jiangshan wrote: > > > Adds new QERR_UNSUPPORTED, converts "nmi" to "inject-nmi" and > make it supports qmp. Lai, unfortunately this series still have some issues (like changing the HMP command name). I think V7 was the best submission so far, so I decide

Re: [Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 02:01:57PM +0200, Gerd Hoffmann wrote: > On 04/28/11 10:29, Alon Levy wrote: > >--- > > hw/qxl.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > >diff --git a/hw/qxl.c b/hw/qxl.c > >index 63e295b..ccd820c 100644 > >--- a/hw/qxl.c > >+++ b/hw/qxl.c > >@

Re: [Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 02:01:16PM +0200, Gerd Hoffmann wrote: > >+static const char *qxl_mode_to_string(int mode) > >+{ > >+switch (mode) { > >+case QXL_MODE_COMPAT: > >+return "compat"; > >+case QXL_MODE_NATIVE: > >+return "native"; > >+case QXL_MODE_UNDEFINED: > >

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-29 Thread Blue Swirl
On Fri, Apr 29, 2011 at 12:45 PM, Ulrich Obergfell wrote: > >> On 2011-04-28 20:51, Blue Swirl wrote: >>> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote: 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_

Re: [Qemu-devel] QEMU testing methodology & results

2011-04-29 Thread Blue Swirl
On Fri, Apr 29, 2011 at 11:33 AM, Paolo Bonzini wrote: > On 04/29/2011 02:17 AM, Peter Maydell wrote: >> >> The theoretical aim there as far >> as I'm concerned is architectural correctness -- in other words we >> should be a valid implementation of the architecture, > > That's not even the case f

Re: [Qemu-devel] [PULL] qemu-timer: Add and use new function qemu_timer_expired_ns and other patches

2011-04-29 Thread Blue Swirl
On Thu, Apr 28, 2011 at 3:18 PM, Stefan Weil wrote: > Am 20.04.2011 16:26, schrieb Stefan Weil: >> >> Hello, >> >> the four qemu-timer related patches which I sent to qemu-devel can now be >> pulled. >> Maybe this makes the commit to git master easier. >> >> There was no feedback for the first thr

Re: [Qemu-devel] [PATCH 02/33] gdbserver: Don't deliver TIMER interrupts when SSTEP_NOIRQ either.

2011-04-29 Thread Blue Swirl
On Thu, Apr 28, 2011 at 11:50 PM, Richard Henderson wrote: > This would affect Sparc as well. > > Signed-off-by: Richard Henderson > Cc: Blue Swirl > --- >  cpu-exec.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/cpu-exec.c b/cpu-exec.c > index 395cd8c..e1b85d6 1

Re: [Qemu-devel] [RFC PATCH 0/2] Multiqueue support for qemu(virtio-net)

2011-04-29 Thread Anthony Liguori
On 04/20/2011 10:33 PM, Jason Wang wrote: Krishna Kumar2 writes: > Thanks Jason! > > So I can use my virtio-net guest driver and test with this patch? > Please provide the script you use to start MQ guest. > Yes and thanks. Following is a simple script may help you start macvtap mq

Re: [Qemu-devel] [RFC PATCH 1/2] net: Add multiqueue support

2011-04-29 Thread Anthony Liguori
On 04/20/2011 03:33 AM, Jason Wang wrote: This patch adds the multiqueues support for emulated nics. Each VLANClientState pairs are now abstract as a queue instead of a nic, and multiple VLANClientState pointers were stored in the NICState and treated as the multiple queues of a single nic. The n

Re: [Qemu-devel] [RESEND][PATCH 1/9] pxa2xx_pcmcia: qdevify

2011-04-29 Thread Dmitry Eremin-Solenikov
Hello, Any chance to get any response for this patches serie? On 4/25/11, Dmitry Eremin-Solenikov wrote: > Use qdev insfrastructure for managing PXA PCMCIA devices. PCMCIA bus > itself isn't converted to QBus (yet). pxa2xx_pcmcia_init() function is > moved to pcmcia.h as it will be used by other

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-04-29 Thread Devin J. Pohly
I just compiled from git and the problem persists. I will reiterate that the issue appears to be with the word size of the types used, not with endianness; see comment 4. I have not dug any further into the QEMU code to see if I find a more "correct-looking" solution than the quick patch I have a

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2011-04-29 Thread Shahar Havivi
Fine with me On Apr 29, 2011, at 19:24, Dmitry Zhurikhin wrote: > On 05/11/2010 12:18 AM, Anthony Liguori wrote: >> On 04/18/2010 02:21 PM, Shahar Havivi wrote: >>> Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the >>> structure handled >>> by qemu tail queue. >>> Adding

[Qemu-devel] [PATCH] CPUPhysMemoryClient: Batch contiguous addresses when playing catchup

2011-04-29 Thread Alex Williamson
When a phys memory client registers and we play catchup by walking the page tables, we can make a huge improvement in the number of times the set_memory callback is called by batching contiguous pages together. With a 4G guest, this reduces the number of callbacks at registration from 1048866 to 2

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 09:38 -0600, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > > >> When we're trying to get a newly registered phys memory c

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 18:20, Alex Williamson wrote: > On Fri, 2011-04-29 at 18:07 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:55, Alex Williamson wrote: >>> On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: On 2011-04-29 17:38, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Ki

Re: [Qemu-devel] [PATCH 1/2 v4] Support for multiple keyboard devices

2011-04-29 Thread Dmitry Zhurikhin
On 05/11/2010 12:18 AM, Anthony Liguori wrote: On 04/18/2010 02:21 PM, Shahar Havivi wrote: Patch add QEMUPutKbdEntry structure - handling each keyboard entry, the structure handled by qemu tail queue. Adding a new keyboard add to the list and select it, removing keyboard select the previous

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 18:07 +0200, Jan Kiszka wrote: > On 2011-04-29 17:55, Alex Williamson wrote: > > On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: > >> On 2011-04-29 17:38, Alex Williamson wrote: > >>> On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:55, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:38, Alex Williamson wrote: >>> On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: On 2011-04-29 17:06, Michael S. Tsirkin wrote: > On Thu, Apr 28, 2011 at 09:15:23PM -06

[Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

2011-04-29 Thread Marc-Antoine Perennou
pulse/simple.h does not include stdlib.h We cannot use NULL since it may not be defined Use 0 instead Signed-off-by: Marc-Antoine Perennou --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index ea8b676..d67c3ce 100755 --- a/configure +

Re: [Qemu-devel] [PULL] Request for Pull

2011-04-29 Thread Aneesh Kumar K.V
On Fri, 29 Apr 2011 14:10:43 +0530, "Aneesh Kumar K.V" wrote: > On Thu, 28 Apr 2011 12:39:45 -0500, Anthony Liguori > wrote: > > On 04/28/2011 12:21 PM, Stefan Weil wrote: > > > Am 28.04.2011 15:56, schrieb Anthony Liguori: > > >> On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: > > >>> T

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 17:45 +0200, Jan Kiszka wrote: > On 2011-04-29 17:38, Alex Williamson wrote: > > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > >> On 2011-04-29 17:06, Michael S. Tsirkin wrote: > >>> On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > When we're tr

Re: [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs

2011-04-29 Thread Scott Wood
On Fri, 29 Apr 2011 14:05:23 +0200 Jan Kiszka wrote: > On 2011-04-28 23:01, Scott Wood wrote: > > +#ifdef KVM_CAP_PPC_BOOKE_SREGS > > +if (kvm_check_extension(env->kvm_state, KVM_CAP_PPC_BOOKE_SREGS)) { > > You probably want to cache the result of this syscall during init and > check that he

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:38, Alex Williamson wrote: > On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: >> On 2011-04-29 17:06, Michael S. Tsirkin wrote: >>> On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: When we're trying to get a newly registered phys memory client updated

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 18:34 +0300, Michael S. Tsirkin wrote: > On Fri, Apr 29, 2011 at 05:29:06PM +0200, Jan Kiszka wrote: > > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > > >> When we're trying to get a newly registered phy

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Alex Williamson
On Fri, 2011-04-29 at 17:29 +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > >> When we're trying to get a newly registered phys memory client updated > >> with the current page mappings, we end up passi

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Michael S. Tsirkin
On Fri, Apr 29, 2011 at 05:29:06PM +0200, Jan Kiszka wrote: > On 2011-04-29 17:06, Michael S. Tsirkin wrote: > > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > >> When we're trying to get a newly registered phys memory client updated > >> with the current page mappings, we end u

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Jan Kiszka
On 2011-04-29 17:06, Michael S. Tsirkin wrote: > On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: >> When we're trying to get a newly registered phys memory client updated >> with the current page mappings, we end up passing the region offset >> (a ram_addr_t) as the start address r

[Qemu-devel] [PATCH 7/9] qapi: test schema for test-visiter unit tests

2011-04-29 Thread Michael Roth
Signed-off-by: Michael Roth --- qapi-schema-test.json | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) create mode 100644 qapi-schema-test.json diff --git a/qapi-schema-test.json b/qapi-schema-test.json new file mode 100644 index 000..4717dee --- /dev/null +++ b/qapi-s

[Qemu-devel] [PATCH 9/9] qapi: test-visiter, pull in gen code, tests for nested structures

2011-04-29 Thread Michael Roth
Pull into test files generated from qapi-schema-test.json by visiter/types generators so we can do unit tests against the generated code. Also, add test cases for handling of nested structs/qobjects. Note: optional members are implemented yet so test case is slightly gimped. Signed-off-by: Michae

[Qemu-devel] [PATCH 5/9] qapi: add --prefix option to type generator

2011-04-29 Thread Michael Roth
This is mainly so we can generate a header file with the filename {prefix}qapi-types.h by passing in a test schema for use with unit tests. Signed-off-by: Michael Roth --- scripts/qapi-types.py | 30 -- 1 files changed, 24 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH 6/9] qapi: add --prefix option for visiter generator

2011-04-29 Thread Michael Roth
Generated code assumes the required types header was generated using the same prefix. Signed-off-by: Michael Roth --- scripts/qapi-visit.py | 41 - 1 files changed, 32 insertions(+), 9 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit

[Qemu-devel] [PATCH 4/9] qapi: some basename/guardname py utility functions

2011-04-29 Thread Michael Roth
Some utility functions to get basename/guardname from a filename/filepath. These will be used to allow arbitrarilly named test files to be generated by code generators for use in unit tests. Signed-off-by: Michael Roth --- scripts/qapi.py |5 + 1 files changed, 5 insertions(+), 0 deletio

[Qemu-devel] [PATCH 8/9] qapi: Makefile, build test-visiter with generated test code

2011-04-29 Thread Michael Roth
This pulls in test-qapi-visit.c/.h and test-qapi-types.h, which are generated from qapi-schema-test.json using the --prefix arguments for the various code generators. Useful for targetted testing of the schema parser/code generators. Signed-off-by: Michael Roth --- Makefile | 15 --

[Qemu-devel] [PATCH 1/9] qapi: Fix type generator for structured type members

2011-04-29 Thread Michael Roth
This generalizes the generate_struct() function to support generating structs for top-level named structs as well anonymous nested structs. generate_struct() now calls itself recursively to support arbitrary nesting by checking if a fields "type" is actually an OrderedDict. Signed-off-by: Michael

[Qemu-devel] [PATCH 3/9] qapi: Fix visiter generator for nested structs/qobjects

2011-04-29 Thread Michael Roth
Recursively handle structured types as identified by the schema parser. Generated code Uses visiter stack's push/pop logic to traverse the structure's tree. Signed-off-by: Michael Roth --- scripts/qapi-visit.py | 55 +--- 1 files changed, 38 insertio

[Qemu-devel] [PATCH 2/9] qapi: input visiter, don't always allocate memory for structs

2011-04-29 Thread Michael Roth
Sometimes we have anonymous nested structs rather than references. In these cases we call visit_start_struct() primarilly to push the nested qobject onto the stack, and specify a NULL obj value to avoid doing any memory allocation. So add a simple check for this NULL value. Signed-off-by: Michael

[Qemu-devel] [PULL] QAPI code generator fix-ups

2011-04-29 Thread Michael Roth
The following changes since commit 4e277a7c641698faf8f01599043b622f80237b42: Anthony Liguori (1): Add input marshaller are available in the git repository at: git://repo.or.cz/qemu/mdroth.git qapi-for-anthony Michael Roth (9): qapi: Fix type generator for structured type member

Re: [Qemu-devel] [PATCH] Fix phys memory client - pass guest physical address not region offset

2011-04-29 Thread Michael S. Tsirkin
On Thu, Apr 28, 2011 at 09:15:23PM -0600, Alex Williamson wrote: > When we're trying to get a newly registered phys memory client updated > with the current page mappings, we end up passing the region offset > (a ram_addr_t) as the start address rather than the actual guest > physical memory addres

Re: [Qemu-devel] Supporting emulation of IOMMUs

2011-04-29 Thread Richard Henderson
On 04/28/2011 02:57 PM, Richard Henderson wrote: > I've had a read through the patches posted in January. It all does > seem relatively sane. At least, I can readily see how I would apply > these interfaces to my Alpha port without trouble. I take that back, I see one rather annoying problem: th

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-29 Thread Anthony Liguori
On 04/29/2011 08:38 AM, Jes Sorensen wrote: On 04/28/11 17:10, Anthony Liguori wrote: No, the command does too many things and as such, makes it impossible for a management tool to gracefully recover. It is exactly the same for the management tool: - Creation of the new image either succeeds o

Re: [Qemu-devel] [PATCH v2 1/1] Add QMP bits for blockdev-snapshot-sync.

2011-04-29 Thread Jes Sorensen
On 04/28/11 17:10, Anthony Liguori wrote: > On 04/28/2011 09:57 AM, Jes Sorensen wrote: >> On 04/28/11 16:46, Anthony Liguori wrote: >> Sorry this is inherently broken. The management tool should not be >> keeping state in this process. I agree an async interface would be nice, >> but the above pro

Re: [Qemu-devel] [PATCH 29/33] target-alpha: Add custom PALcode image for CLIPPER emulation.

2011-04-29 Thread Richard Henderson
On 04/29/2011 02:13 AM, Peter Maydell wrote: > 2011/4/28 Richard Henderson : >> +[submodule "roms/qemu-palcode"] >> + path = roms/qemu-palcode >> + url = git://repo.or.cz/qemu-palcode.git > > What's the license on this binary blob? There isn't > a COPYING file in the qemu-palcode git r

Re: [Qemu-devel] [PATCHv3] virtio-serial-bus: use bh for unthrottling

2011-04-29 Thread Amit Shah
On (Fri) 29 Apr 2011 [14:25:06], Alon Levy wrote: > Instead of calling flush_queued_data when unthrottling, schedule > a bh. That way we can return immediately to the caller, and the > flush uses the same call path as a have_data for callbackee. > > No migration change is required because bh are c

Re: [Qemu-devel] [PATCH 6/8] blockdev: Allow image files to auto-enable streaming

2011-04-29 Thread Kevin Wolf
Am 27.04.2011 15:27, schrieb Stefan Hajnoczi: > Image files that having streaming enabled will automatically begin > streaming when opened. > > Signed-off-by: Stefan Hajnoczi Hm... I wasn't really happy about images that do copy on read even if I didn't tell qemu so on the command line. Now they

[Qemu-devel] [Bug 458521] Re: kvm crash when using virtio for network, hardy guest

2011-04-29 Thread Jamie Strandboge
** Changed in: linux (Ubuntu Hardy) Status: Incomplete => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/458521 Title: kvm crash when using virtio for network, hardy guest Status

Re: [Qemu-devel] [PATCH 3/8] qed: add support for Copy-on-Read

2011-04-29 Thread Kevin Wolf
Am 27.04.2011 15:27, schrieb Stefan Hajnoczi: > From: Anthony Liguori > > When creating an image using qemu-img, just pass '-o copy_on_read' and then > whenever QED reads from a backing file, it will write the block to the QED > file after the read completes ensuring that you only fetch from the

Re: [Qemu-devel] [PATCHv2 3/4] qxl: add debug_cs and cmdlog_cs

2011-04-29 Thread Gerd Hoffmann
On 04/28/11 10:29, Alon Levy wrote: With this you can output the command log and/or the guest debug (driver) output to a chardev instead of stderr: -global qxl-vga.cmdlog_chardev=qxl_cmdlog_chardev -global qxl-vga.debug_chardev=qxl_debug_chardev useful for debugging. if no chardev is specified

Re: [Qemu-devel] [PATCH 2/8] qmp: Add QMP support for stream commands

2011-04-29 Thread Kevin Wolf
Am 27.04.2011 15:27, schrieb Stefan Hajnoczi: > From: Anthony Liguori > > For leaf images with copy on read semantics, the stream commands allow the > user > to populate local blocks by manually streaming them from the backing image. > Once all blocks have been streamed, the dependency on the or

Re: [Qemu-devel] [PATCH] monitor: add PPC BookE SPRs

2011-04-29 Thread Jan Kiszka
On 2011-04-28 23:01, Scott Wood wrote: > Read them via KVM_GET_SREGS in kvm_arch_get_registers(), > and display them in "info registers". > > Also get CR and PID from the existing KVM_GET_REGS. > > Signed-off-by: Scott Wood > --- > hw/ppc.c | 12 + > monitor.c |

Re: [Qemu-devel] [PATCHv2 2/4] qxl: add mode to debugprint on destroy primary

2011-04-29 Thread Gerd Hoffmann
On 04/28/11 10:29, Alon Levy wrote: --- hw/qxl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 63e295b..ccd820c 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1009,7 +1009,7 @@ static void ioport_write(void *opaque, uint32_t addr, uint32_t val)

Re: [Qemu-devel] [PATCHv2 1/4] qxl: interface_get_command: fix reported mode

2011-04-29 Thread Gerd Hoffmann
+static const char *qxl_mode_to_string(int mode) +{ +switch (mode) { +case QXL_MODE_COMPAT: +return "compat"; +case QXL_MODE_NATIVE: +return "native"; +case QXL_MODE_UNDEFINED: +return "undefined"; +case QXL_MODE_VGA: +return "vga"; +} +r

Re: [Qemu-devel] [PATCH 2/4] spice: don't create updates in spice server context.

2011-04-29 Thread Gerd Hoffmann
Hi, -static int debug = 0; +static int debug = 1; Accident? Oops. That one wasn't intentional, will fix for the pull request. cheers, Gerd

Re: [Qemu-devel] [PATCH 1/8] block: add bdrv_aio_stream

2011-04-29 Thread Kevin Wolf
Am 27.04.2011 15:27, schrieb Stefan Hajnoczi: > From: Anthony Liguori > > Signed-off-by: Anthony Liguori > --- > block.c | 32 > block.h |2 ++ > block_int.h |3 +++ > 3 files changed, 37 insertions(+), 0 deletions(-) > > diff --git a/block.c

[Qemu-devel] [PATCH] doc: Add explanation that -alt-grab and -ctrl-grab affect special keys

2011-04-29 Thread Brad Hards
Phillip Merensky reported that the special keys (e.g. Ctrl-Alt-f for full screen) did not work correctly if -alt-grab is used. BUG: 696530 Review of ui/sdl.c:sdl_refresh indicates that this is the intended behaviour, so we should update the documentation to match the actual behaviour, as suggeste

Re: [Qemu-devel] [PATCHv3] virtio-serial-bus: use bh for unthrottling

2011-04-29 Thread Amit Shah
On (Fri) 29 Apr 2011 [14:25:06], Alon Levy wrote: > Instead of calling flush_queued_data when unthrottling, schedule > a bh. That way we can return immediately to the caller, and the > flush uses the same call path as a have_data for callbackee. > > No migration change is required because bh are c

[Qemu-devel] [PATCHv3] virtio-serial-bus: use bh for unthrottling

2011-04-29 Thread Alon Levy
Instead of calling flush_queued_data when unthrottling, schedule a bh. That way we can return immediately to the caller, and the flush uses the same call path as a have_data for callbackee. No migration change is required because bh are called from vm_stop. --- hw/virtio-serial-bus.c | 12 +

Re: [Qemu-devel] [PATCH 0/4] spice: fix locking

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 11:38:28AM +0200, Gerd Hoffmann wrote: > Hi, > > This patch series moves a bunch of work spice has to do from spice > server thread context to iothread context, which in turn allows to > drop the current locking mess as we don't touch qemu internals from > spice server th

Re: [Qemu-devel] [PATCH v2] qemu-progress.c: printf isn't signal safe

2011-04-29 Thread Kevin Wolf
Am 28.04.2011 13:58, schrieb jes.soren...@redhat.com: > From: Jes Sorensen > > Change the signal handling to indicate a signal is pending, rather > then printing directly from the signal handler. > > In addition make the signal prints go to stderr, rather than stdout. > > Signed-off-by: Jes Sor

Re: [Qemu-devel] [PATCH 2/4] spice: don't create updates in spice server context.

2011-04-29 Thread Alon Levy
On Fri, Apr 29, 2011 at 11:38:30AM +0200, Gerd Hoffmann wrote: > This patch moves the creation of spice screen updates from the spice > server context to qemu iothread context (display refresh timer to be > exact). This way we avoid accessing qemu internals (display surface) > from spice thread co

Re: [Qemu-devel] [PATCHv2] ide/atapi: fix set but unused

2011-04-29 Thread Kevin Wolf
Am 28.04.2011 15:34, schrieb Alon Levy: > Signed-off-by: Alon Levy > --- > hw/ide/atapi.c |4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH 1/2] atapi: Move comment to proper place

2011-04-29 Thread Kevin Wolf
Am 28.04.2011 16:34, schrieb Amit Shah: > Move misplaced comment for media_is_dvd() > > Signed-off-by: Amit Shah Thanks, applied both to the block branch. Kevin

Re: [Qemu-devel] [PATCH] Make qemu-img convert properly consider backing file contents when used with -o backing_file

2011-04-29 Thread Kevin Wolf
Am 29.04.2011 03:42, schrieb Brad Campbell: > G'day all, > > This patch makes qemu-img properly consider the contents of the output > backing file when performing a convert operation. All things considered > it would also perform similar to rebase, where you could specify a > completely differe

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-29 Thread Jan Kiszka
On 2011-04-29 11:45, Ulrich Obergfell wrote: > >> On 2011-04-28 20:51, Blue Swirl wrote: >>> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote: 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain entry addresses of functions that are utilized by update_irq() to

[Qemu-devel] [Bug 754591] Re: NIC doesn't work when it had been used before

2011-04-29 Thread Yongjie Ren
I can reproduce it stably. I use igb driver for my NIC. And Alex Williamson is on the way to fix it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/754591 Title: NIC doesn't work when it had been us

Re: [Qemu-devel] [PATCH v3 1/5] hpet 'driftfix': add hooks required to detect coalesced interrupts (x86 apic only)

2011-04-29 Thread Ulrich Obergfell
> On 2011-04-28 20:51, Blue Swirl wrote: >> On Thu, Apr 28, 2011 at 5:24 PM, Ulrich Obergfell wrote: >>> 'target_get_irq_delivered' and 'target_reset_irq_delivered' contain >>> entry addresses of functions that are utilized by update_irq() to >>> detect coalesced interrupts. apic code loads these

[Qemu-devel] [PATCH 4/4] spice: drop obsolete iothread locking

2011-04-29 Thread Gerd Hoffmann
We don't use qemu internals from spice server context any more. Thus we don't also need to grab the iothread mutex from spice server context. And we don't have to temporarely release the lock to avoid deadlocks. Drop all the calls. Signed-off-by: Gerd Hoffmann --- hw/qxl.c |8 ---

[Qemu-devel] [PATCH 3/4] spice: don't call displaystate callbacks from spice server context.

2011-04-29 Thread Gerd Hoffmann
This patch moves the displaystate callback calls for setting the cursor and the mouse pointer from spice server to qemu (iothread) context. This allows us to simplify locking. Signed-off-by: Gerd Hoffmann --- hw/qxl-render.c| 25 - hw/qxl.c |2 ++ ui/s

[Qemu-devel] [PATCH 2/4] spice: don't create updates in spice server context.

2011-04-29 Thread Gerd Hoffmann
This patch moves the creation of spice screen updates from the spice server context to qemu iothread context (display refresh timer to be exact). This way we avoid accessing qemu internals (display surface) from spice thread context which in turn allows us to simplify locking. Signed-off-by: Gerd

[Qemu-devel] [PATCH 0/4] spice: fix locking

2011-04-29 Thread Gerd Hoffmann
Hi, This patch series moves a bunch of work spice has to do from spice server thread context to iothread context, which in turn allows to drop the current locking mess as we don't touch qemu internals from spice server thread any more. A long-standing warning fix from Jes is included too. chee

[Qemu-devel] [PATCH 1/4] Make spice dummy functions inline to fix calls not checking return values

2011-04-29 Thread Gerd Hoffmann
From: Jes Sorensen qemu_spice_set_passwd() and qemu_spice_set_pw_expire() dummy functions needs to be inline, in order to handle the case where they are called without checking the return value. Signed-off-by: Jes Sorensen Signed-off-by: Gerd Hoffmann --- ui/qemu-spice.h | 12 ++--

Re: [Qemu-devel] [PATCH 29/33] target-alpha: Add custom PALcode image for CLIPPER emulation.

2011-04-29 Thread Peter Maydell
2011/4/28 Richard Henderson : > +[submodule "roms/qemu-palcode"] > +       path = roms/qemu-palcode > +       url = git://repo.or.cz/qemu-palcode.git What's the license on this binary blob? There isn't a COPYING file in the qemu-palcode git repo and most of the source files seem to be missing copy

[Qemu-devel] [PATCH] qemu-img resize: Fix option parsing

2011-04-29 Thread Kevin Wolf
For shrinking images, you're supposed to use a negative size. However, the leading minus makes getopt think that it's an option and so you get the help text if you don't use -- like in 'qemu-img resize test.img -- -1G'. This patch handles the size first and removes it from the argument list so tha

Re: [Qemu-devel] [PATCH 1/2] Support for MIPS64 user mode emulation

2011-04-29 Thread Aurelien Jarno
On Mon, Apr 25, 2011 at 04:54:19PM +0500, Khansa Butt wrote: > please see inline comments highlighted in red color. > > On Wed, Apr 13, 2011 at 2:32 AM, Aurelien Jarno wrote: > > > [I don't know very well linux-user, it would be nice to Cc: Riku Voipio, > > the linux-user maintainer for the next

Re: [Qemu-devel] [PULL] Request for Pull

2011-04-29 Thread Aneesh Kumar K.V
On Thu, 28 Apr 2011 12:39:45 -0500, Anthony Liguori wrote: > On 04/28/2011 12:21 PM, Stefan Weil wrote: > > Am 28.04.2011 15:56, schrieb Anthony Liguori: > >> On 04/27/2011 11:16 AM, Venkateswararao Jujjuri wrote: > >>> The following changes since commit > >>> 661bfc80e876d32da8befe53ba0234d87fc0

[Qemu-devel] [Bug 754591] Re: NIC doesn't work when it had been used before

2011-04-29 Thread flypen
I found this problem, too. A VM used a NIC with PCI-passthrough mode. Then I shutdown the VM, and tried to give the NIC back to the host. But I found I couldn't assign the NIC to the host again. This problem didn't occur each time. If I did this steps for ten times, I could see it at least once.

Re: [Qemu-devel] [PATCH 00/33] Alpha system emulation, v3

2011-04-29 Thread Paolo Bonzini
On 04/28/2011 10:50 PM, Richard Henderson wrote: * I still don't think I know how git submodules really work. When I updated the one patch containing the PALcode blob, I couldn't figure out how to change the submodule revision hash number to HEAD. cd roms/palcode git pull origin #

Re: [Qemu-devel] QEMU testing methodology & results

2011-04-29 Thread Paolo Bonzini
On 04/29/2011 02:17 AM, Peter Maydell wrote: The theoretical aim there as far as I'm concerned is architectural correctness -- in other words we should be a valid implementation of the architecture, That's not even the case for x86. It should be a goal, however, that with mainstream kernels u