[Qemu-devel] [PATCH 6/7] usb-uvc: Fix a couple of typos

2011-06-02 Thread Brad Hards
Signed-off-by: Brad Hards br...@frogmouth.net --- hw/usb-uvc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 661eb1a..1e3d339 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -893,7 +893,7 @@ static int usb_uvc_initfn(USBDevice *dev)

[Qemu-devel] [PATCH 5/7] usb-uvc: Add spaces around

2011-06-02 Thread Brad Hards
As requested by Blue Swirl (2010-06-10 17:46:16) Signed-off-by: Brad Hards br...@frogmouth.net --- hw/usb-uvc.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 5437a13..661eb1a 100644 --- a/hw/usb-uvc.c +++

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Zhi Yong Wu
On Wed, Jun 01, 2011 at 09:32:32AM -0400, Vivek Goyal wrote: Date: Wed, 1 Jun 2011 09:32:32 -0400 From: Vivek Goyal vgo...@redhat.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: kw...@redhat.com, stefa...@linux.vnet.ibm.com, k...@vger.kernel.org, guijianf...@cn.fujitsu.com,

[Qemu-devel] [PATCH 7/7] usb-uvc: Use qemu_malloc()

2011-06-02 Thread Brad Hards
As requested by Blue Swirl (2010-06-10) Signed-off-by: Brad Hards br...@frogmouth.net --- hw/usb-uvc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 1e3d339..d1e71f8 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -1025,7 +1025,7 @@

Re: [Qemu-devel] [PATCH V2 2/3] Cocoa: avoid displaying window when command-line contains '-h' or '-help'

2011-06-02 Thread Peter Maydell
On 2 June 2011 00:05, Andreas Färber andreas.faer...@web.de wrote: Am 30.05.2011 um 00:32 schrieb Peter Maydell: (1) presumably this doesn't work if you disable the display with -display none ? I don't see how that would not work. It's just not handled specially here, so it will likely

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Sasha Levin
Hi, On Mon, 2011-05-30 at 13:09 +0800, Zhi Yong Wu wrote: Hello, all, I have prepared to work on a feature called Disk I/O limits for qemu-kvm projeect. This feature will enable the user to cap disk I/O amount performed by a VM.It is important for some storage resources to be

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Zhi Yong Wu
On Thu, Jun 02, 2011 at 09:17:06AM +0300, Sasha Levin wrote: Date: Thu, 02 Jun 2011 09:17:06 +0300 From: Sasha Levin levinsasha...@gmail.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, k...@vger.kernel.org, kw...@redhat.com, aligu...@us.ibm.com,

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Sasha Levin
On Thu, 2011-06-02 at 14:29 +0800, Zhi Yong Wu wrote: On Thu, Jun 02, 2011 at 09:17:06AM +0300, Sasha Levin wrote: Date: Thu, 02 Jun 2011 09:17:06 +0300 From: Sasha Levin levinsasha...@gmail.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, k...@vger.kernel.org,

Re: [Qemu-devel] [PATCH V2 3/3] Remove warning in printf due to type mismatch

2011-06-02 Thread Stefan Weil
Am 30.05.2011 00:22, schrieb Alexandre Raymond: 8 qemu/target-lm32/translate.c: In function ‘gen_intermediate_code_internal’: qemu/target-lm32/translate.c:1135: warning: format ‘%zd’ expects type ‘signed size_t’, but argument 4 has type ‘int’ 8 Both gen_opc_ptr and

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

[Qemu-devel] qemu-mipsel problem GC_INIT()

2011-06-02 Thread Dragoslav Sicarov
Hi, I'm using qemu-mipsel user-mod, and i have a problem with GC_INIT(); I wrote this simple program #includegc.h int main () { GC_INIT(); } and I compiled for mipsel. When I start executable file I got segmentation fault in qemu user-mode. Same executable file work on qemu system

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Zhi Yong Wu
On Thu, Jun 02, 2011 at 10:15:02AM +0300, Sasha Levin wrote: Date: Thu, 02 Jun 2011 10:15:02 +0300 From: Sasha Levin levinsasha...@gmail.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: kw...@redhat.com, aligu...@us.ibm.com, herb...@gondor.apana.org.au, k...@vger.kernel.org,

Re: [Qemu-devel] [PATCH 5/5] QMP: add server mode to QEMUMonitorProtocol

2011-06-02 Thread Daniel P. Berrange
On Thu, Jun 02, 2011 at 12:19:22PM +1000, Brad Hards wrote: On Thu, 2 Jun 2011 01:54:05 AM Luiz Capitulino wrote: QEMU supports socket chardevs that establish connections like a server or a client. Is this protocol documented anywhere? There are docs for the QMP monitor in the QMP/

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Daniel P. Berrange
On Wed, Jun 01, 2011 at 04:35:03PM -0500, Anthony Liguori wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage and when a no space error is triggered, more space is

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC]QEMU disk I/O limits

2011-06-02 Thread Michal Suchanek
On 1 June 2011 05:12, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: On Tue, May 31, 2011 at 03:55:49PM -0400, Vivek Goyal wrote: Date: Tue, 31 May 2011 15:55:49 -0400 From: Vivek Goyal vgo...@redhat.com To: Zhi Yong Wu wu...@linux.vnet.ibm.com Cc: kw...@redhat.com, aligu...@us.ibm.com,

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-02 Thread David Gibson
On Wed, Jun 01, 2011 at 08:45:56AM -0700, Richard Henderson wrote: On 06/01/2011 08:35 AM, Eduard - Gabriel Munteanu wrote: Maybe it's not nice, but you're missing the fact upcasting gives you some type safety. With opaques you have none. Lol. Do you understand what container_of does?

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

2011-06-02 Thread Andreas Färber
Am 02.06.2011 um 04:21 schrieb Alexandre Raymond: Fix the following warning by including signal.h directly in qemu- common.h 8 iohandler.c: In function ‘qemu_init_child_watch’: iohandler.c:172: warning: implicit declaration of function ‘sigaction’ iohandler.c:172: warning: nested

Re: [Qemu-devel] [PATCH] target-arm: Fix compilation failure for 64 bit hosts

2011-06-02 Thread Peter Maydell
Ping? thanks -- PMM On 26 May 2011 18:57, Stefan Weil w...@mail.berlios.de wrote: Am 26.05.2011 13:03, schrieb Peter Maydell: Use the correct _ptr aliases for manipulating the pointer to the fp_status; this fixes a compilation failure on 64 bit hosts. Signed-off-by: Peter

Re: [Qemu-devel] [RFC PATCH 01/13] Generic DMA memory access interface

2011-06-02 Thread David Gibson
On Wed, Jun 01, 2011 at 08:16:44AM -0700, Richard Henderson wrote: On 06/01/2011 07:29 AM, Avi Kivity wrote: On 06/01/2011 05:01 PM, Richard Henderson wrote: +err = dev-mmu-translate(dev, addr,paddr,plen, is_write); I see you didn't take my suggestion for using an opaque

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Michael S. Tsirkin
On Wed, Jun 01, 2011 at 05:51:54PM +0300, Avi Kivity wrote: On 06/01/2011 05:36 PM, Michael S. Tsirkin wrote: So, if I am going to give this liberty with buffers to the driver, I _have_ to keep the size information. Otherwise, I agree that it is redundant and I will remove it. What

Re: [Qemu-devel] [PATCH] cocoa: Provide central qemu_main() prototype

2011-06-02 Thread Andreas Färber
Am 30.05.2011 um 01:53 schrieb Alexandre Raymond: Just thinking out loud here : wouldn't it make more sense to put the main() of each gui framework directly in its corresponding file and select the right one in the makefile using the configure options? so you'd have -no gui -

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Michael S. Tsirkin
BTW, I think Cc the virtio mailing list in the next version is a good idea. On Wed, Jun 01, 2011 at 05:59:28PM +0200, Paolo Bonzini wrote: On 06/01/2011 04:36 PM, Michael S. Tsirkin wrote: Ah, I think I understand now. Both sense and data have in fields that might only be used partially? In

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Avi Kivity
On 06/02/2011 01:42 PM, Michael S. Tsirkin wrote: On Wed, Jun 01, 2011 at 05:51:54PM +0300, Avi Kivity wrote: On 06/01/2011 05:36 PM, Michael S. Tsirkin wrote: So, if I am going to give this liberty with buffers to the driver, I _have_ to keep the size information. Otherwise, I

[Qemu-devel] [PATCH 01/14] kvm: remove fop write only variable

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-i386/kvm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index faedc6c..58a70bc 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.c @@ -970,7 +970,7 @@ static int

[Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes

2011-06-02 Thread Juan Quintela
Hi This series fixes compilation of plain: ./configure with gcc-4.6.0 on Fedora 15. Notes: - linuxload.c: why it define id_change if it never test its value? git log shows that it has been this way forever - linux-user/syscall.c: do we want to return an error in the default case? my guess

[Qemu-devel] [PATCH 02/14] tcg: define and set call_type only when it is used

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- tcg/tcg.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index fad92f9..2d180a5 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -585,9 +585,6 @@ void tcg_register_helper(void *func, const char

[Qemu-devel] [PATCH 04/14] xen: pentry is not used in this function

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- xen-mapcache.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/xen-mapcache.c b/xen-mapcache.c index 349cc62..a2419dc 100644 --- a/xen-mapcache.c +++ b/xen-mapcache.c @@ -198,7 +198,7 @@ uint8_t

[Qemu-devel] [PATCH 06/14] flatload: end_code was only used in a debug message

2011-06-02 Thread Juan Quintela
Just unfold its definition in only use. Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/flatload.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/linux-user/flatload.c b/linux-user/flatload.c index 580bc21..8dad5df 100644 --- a/linux-user/flatload.c

[Qemu-devel] [PATCH 08/14] syscall: really return ret code

2011-06-02 Thread Juan Quintela
We assign ret with the error code, but then return 0 unconditionally. Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/syscall.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5cb27c7..f3d03b0

[Qemu-devel] [PATCH 12/14] linux-user: syscall should use sanitized arg1

2011-06-02 Thread Juan Quintela
Looking at the other architectures, we should be using how not arg1. Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/syscall.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index f3d03b0..c90fcc2 100644 ---

[Qemu-devel] [PATCH 03/14] flatload: memp was a write-only variable

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/flatload.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/linux-user/flatload.c b/linux-user/flatload.c index cd7af7c..580bc21 100644 --- a/linux-user/flatload.c +++ b/linux-user/flatload.c @@ -379,7

[Qemu-devel] [PATCH 05/14] linuxload: id_change was a write only variable

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/linuxload.c | 25 + 1 files changed, 1 insertions(+), 24 deletions(-) diff --git a/linux-user/linuxload.c b/linux-user/linuxload.c index ac8c486..62ebc7e 100644 --- a/linux-user/linuxload.c +++

[Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- hw/lsi53c895a.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index 83084b6..90c6cbc 100644 --- a/hw/lsi53c895a.c +++ b/hw/lsi53c895a.c @@ -889,7 +889,6 @@ static void

[Qemu-devel] [PATCH 07/14] alpha: fn2 was a write only variable

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-alpha/translate.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 456ba51..5c11cf2 100644 --- a/target-alpha/translate.c +++ b/target-alpha/translate.c

[Qemu-devel] [PATCH 13/14] alpha: disp12 is not used for USER emulation

2011-06-02 Thread Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com --- target-alpha/translate.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index 5c11cf2..fd286d8 100644 --- a/target-alpha/translate.c +++

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Paolo Bonzini
On 06/02/2011 01:41 PM, Michael S. Tsirkin wrote: Now to our problem: As far as I can tell there are two input buffers in each request: sense and data. Right? If sense is fixed length, we can simply put it first, have device write sense then data. This does not seem too limiting, if you want a

[Qemu-devel] [PATCH 09/14] exec: last_first_tb was only used in !ONLY_USER case

2011-06-02 Thread Juan Quintela
Once there, use a better variable name. Signed-off-by: Juan Quintela quint...@redhat.com --- exec.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/exec.c b/exec.c index 8529390..4b1afec 100644 --- a/exec.c +++ b/exec.c @@ -1208,12 +1208,16 @@ static inline void

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Michael S. Tsirkin
On Thu, Jun 02, 2011 at 02:42:51PM +0300, Avi Kivity wrote: On 06/02/2011 01:42 PM, Michael S. Tsirkin wrote: On Wed, Jun 01, 2011 at 05:51:54PM +0300, Avi Kivity wrote: On 06/01/2011 05:36 PM, Michael S. Tsirkin wrote: So, if I am going to give this liberty with buffers to the

[Qemu-devel] [PATCH 10/14] mips: we really need the extra arguments

2011-06-02 Thread Juan Quintela
I have no clue how/why syscalls with 7 parameters work on mips. Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 088def3..d13affa 100644 ---

[Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Juan Quintela
It is only read to set the error code? Signed-off-by: Juan Quintela quint...@redhat.com --- linux-user/signal.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index c7a375f..edf4cdb 100644 --- a/linux-user/signal.c +++

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Michael S. Tsirkin
On Thu, Jun 02, 2011 at 02:02:52PM +0200, Paolo Bonzini wrote: On 06/02/2011 01:41 PM, Michael S. Tsirkin wrote: Now to our problem: As far as I can tell there are two input buffers in each request: sense and data. Right? If sense is fixed length, we can simply put it first, have device

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] [RFC PATCH] Darwin: Fix compilation warning regarding the deprecated daemon() function

2011-06-02 Thread Andreas Färber
Am 02.06.2011 um 04:45 schrieb Alexandre Raymond: On OSX 10.5, daemon() is deprecated, resulting int he following warning: = 10.5 http://developer.apple.com/library/mac/#documentation/Darwin/Reference/ ManPages/man3/daemon.3.html 8 qemu-nbd.c: In function ‘main’:

Re: [Qemu-devel] [PATCH 00/14] More gcc 4.6 warnings fixes

2011-06-02 Thread Christophe Fergeau
Hi, On Thu, Jun 02, 2011 at 01:53:35PM +0200, Juan Quintela wrote: Juan Quintela (14): kvm: remove fop write only variable tcg: define and set call_type only when it is used These were already sent in this thread: http://thread.gmane.org/gmane.comp.emulators.qemu/101411 linuxload:

[Qemu-devel] Hello Would You Like To Earn

2011-06-02 Thread Sharon . Burns
Hello qemu-devel Would you like to earn an extra $200 everyday?, for just 45 minutes work? You could quit your job and make double the money at home working for yourself. visit-http:tinyurl.com/3brnlpx Regards, Sharon Burns Survey Human Resources Dept.

Re: [Qemu-devel] virtio scsi host draft specification, v2

2011-06-02 Thread Avi Kivity
On 06/02/2011 02:56 PM, Michael S. Tsirkin wrote: Right. If there are two buffers of variable length there should be two add_buf calls. No. The guest should be free to use one large continuous buffer of size N, of N buffers of size 1. That's exactly what I was saying. I'm really

Re: [Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used

2011-06-02 Thread Andreas Färber
Am 02.06.2011 um 13:53 schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com See http://patchwork.ozlabs.org/patch/98182/ - ack'ed by Paolo. Andreas --- hw/lsi53c895a.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/hw/lsi53c895a.c

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: On Wed, Jun 01, 2011 at 04:35:03PM -0500, Anthony Liguori wrote: timestamp: { seconds: 1265044230, microseconds: 450486 } } Valid error reasons could be: enospc, eio, etc. No etc :-) Error reasons should we be well known and well

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Jiri Denemark
On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B. query-stop-reason I also have a simple solution for item 2. The vm_stop() accepts a reason argument, so we could store it somewhere and return it as a

Re: [Qemu-devel] [PATCH 14/14] lsi53c895a: current_dev is not used

2011-06-02 Thread Juan Quintela
Andreas Färber andreas.faer...@web.de wrote: Am 02.06.2011 um 13:53 schrieb Juan Quintela: Signed-off-by: Juan Quintela quint...@redhat.com See http://patchwork.ozlabs.org/patch/98182/ - ack'ed by Paolo. Andreas oops, yeap. This makes everything compiles (not that I care which one gets

Re: [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Peter Maydell
On 2 June 2011 12:53, Juan Quintela quint...@redhat.com wrote: It is only read to set the error code?         err |= __get_user(fpu_save_addr, sf-fpu_save); - +        (void)fpu_save_addr; In linux-user __get_user can never generate an error: faults are always caught by the

Re: [Qemu-devel] [PATCH v1][ 21/21] qapi: add QAPI code generation documentation

2011-06-02 Thread Lluís
Here go some minor text corrections. Michael Roth writes: Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- docs/qapi-code-gen.txt | 315 1 files changed, 315 insertions(+), 0 deletions(-) create mode 100644

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B. query-stop-reason I also have a simple solution for item 2. The vm_stop() accepts a reason argument, so we

Re: [Qemu-devel] [PATCH] Fix compilation warning due to missing header for sigaction

2011-06-02 Thread Alexandre Raymond
On Thu, Jun 2, 2011 at 6:13 AM, Andreas Färber andreas.faer...@web.de wrote: Am 02.06.2011 um 04:21 schrieb Alexandre Raymond: Fix the following warning by including signal.h directly in qemu-common.h 8 iohandler.c: In function ‘qemu_init_child_watch’: iohandler.c:172: warning:

Re: [Qemu-devel] [RFC PATCH] Darwin: Fix compilation warning regarding the deprecated daemon() function

2011-06-02 Thread Peter Maydell
On 2 June 2011 03:45, Alexandre Raymond cerb...@gmail.com wrote: The following trick, used in mDNSResponder, takes care of this warning: http://www.opensource.apple.com/source/mDNSResponder/mDNSResponder-258.18/mDNSPosix/PosixDaemon.c If we do decide to borrow this trick from there, can we

Re: [Qemu-devel] [RFC PATCH] Darwin: Fix compilation warning regarding the deprecated daemon() function

2011-06-02 Thread Alexandre Raymond
Hi Andreas, On Thu, Jun 2, 2011 at 8:09 AM, Andreas Färber andreas.faer...@web.de wrote: Am 02.06.2011 um 04:45 schrieb Alexandre Raymond: On OSX 10.5, daemon() is deprecated, resulting int he following warning: = 10.5

Re: [Qemu-devel] [PULL v5 00/25] SCSI subsystem improvements

2011-06-02 Thread Andreas Färber
Am 31.05.2011 um 15:38 schrieb Anthony Liguori: On 05/26/2011 05:56 AM, Paolo Bonzini wrote: The following changes since commit aa29141d84d58171c2d219f0a4b599bd76fb2e37: Merge remote-tracking branch 'kraxel/CVE-2011-1751' into staging (2011-05-25 07:04:13 -0500) are available in the

Re: [Qemu-devel] [PULL 00/26] Alpha system emulation, v5

2011-06-02 Thread Richard Henderson
Ping^2. r~ On 05/27/2011 12:55 PM, Richard Henderson wrote: Ping? r~ On 05/23/2011 01:28 PM, Richard Henderson wrote: Changes from v4 - v5 * Claim official ownership of the Alpha port, rather than leave it as unmaintained. * Drop all the patches in hw/ for now. While

Re: [Qemu-devel] [PATCH] Fix build on FreeBSD

2011-06-02 Thread Andreas Färber
Am 31.05.2011 um 16:57 schrieb Nathan Whitehorn: Add some includes required to build qemu on FreeBSD. Missing Sob. --- bsd-user/syscall.c |2 ++ iohandler.c|1 + os-posix.c |4 3 files changed, 7 insertions(+), 0 deletions(-) [...] diff --git a/iohandler.c

Re: [Qemu-devel] [PATCH 11/14] linux-user: fpu_save_addr is not used

2011-06-02 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 2 June 2011 12:53, Juan Quintela quint...@redhat.com wrote: It is only read to set the error code?         err |= __get_user(fpu_save_addr, sf-fpu_save); - +        (void)fpu_save_addr; In linux-user __get_user can never generate an error:

[Qemu-devel] [PATCH 14/14] Make spapr tces use generic dma layer

2011-06-02 Thread David Gibson
--- Makefile.target |4 +- hw/spapr.c |3 + hw/spapr.h | 14 +++- hw/spapr_iommu.c | 236 hw/spapr_llan.c | 70 -- hw/spapr_vio.c | 289 +++-- hw/spapr_vio.h |

[Qemu-devel] Yet another take on a generic dma/iommu layer

2011-06-02 Thread David Gibson
Here is my variant on Eduard - Gabriel Munteanu's patches to add a DMA/IOMMU layer, this one is expanded to allow it to support the PAPR TCE mechanism. At present, we implement PAPR TCEs directly in the PAPR virtual IO bus layer, the last patch of this series reworks the code to implement it

[Qemu-devel] [PATCH 02/14] pci: add IOMMU support via the generic DMA layer

2011-06-02 Thread David Gibson
IOMMUs can now be hooked onto the PCI bus. This makes use of the generic DMA layer. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/pci.c |9 + hw/pci.h |5 +

[Qemu-devel] [PATCH 10/14] lsi53c895a: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/lsi53c895a.c | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c index

[Qemu-devel] [PATCH 04/14] ide: use the DMA memory access interface for PCI IDE controllers

2011-06-02 Thread David Gibson
Emulated PCI IDE controllers now use the memory access interface. This also allows an emulated IOMMU to translate and check accesses. Map invalidation results in cancelling DMA transfers. Since the guest OS can't properly recover the DMA results in case the mapping is changed, this is a fairly

[Qemu-devel] [PATCH 13/14] usb-ohci: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/usb-ohci.c | 43 --- 1 files changed, 28 insertions(+), 15 deletions(-) diff --git a/hw/usb-ohci.c

[Qemu-devel] [RESEND][PATCH v3][ 5/7] guest agent: add guest agent RPCs/commands

2011-06-02 Thread Michael Roth
This adds the initial set of QMP/QAPI commands provided by the guest agent: guest-sync guest-ping guest-info guest-file-open guest-file-read guest-file-write guest-file-seek guest-file-close guest-fsfreeze-freeze guest-fsfreeze-thaw guest-fsfreeze-status The input/output specification for these

[Qemu-devel] [PATCH 05/14] rtl8139: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/rtl8139.c | 104 - 1 files changed, 58 insertions(+), 46 deletions(-) diff --git a/hw/rtl8139.c

[Qemu-devel] [PATCH 09/14] e1000: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/e1000.c | 27 +++ 1 files changed, 15 insertions(+), 12 deletions(-) diff --git a/hw/e1000.c b/hw/e1000.c index f160bfc..b10c6d6

[Qemu-devel] [PATCH 01/14] Generic DMA memory access interface

2011-06-02 Thread David Gibson
This introduces replacements for memory access functions like cpu_physical_memory_read(). The new interface can handle address translation and access checking through an IOMMU. David Gibson: I have made several bugfixes and cleanups to Eduard's original patch. * dma_memory_rw() was incorrectly

[Qemu-devel] [PATCH 03/14] AMD IOMMU emulation

2011-06-02 Thread David Gibson
This introduces emulation for the AMD IOMMU, described in AMD I/O Virtualization Technology (IOMMU) Specification. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- Makefile.target |1 + hw/amd_iommu.c | 701 +++

[Qemu-devel] [PATCH 08/14] es1370: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/es1370.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c index 40cb48c..8880746 100644 ---

[Qemu-devel] [PATCH 12/14] usb-uhci: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/usb-uhci.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index

[Qemu-devel] [RESEND][PATCH v3][ 6/7] guest agent: add guest agent commands schema file

2011-06-02 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qapi-schema-guest.json | 198 1 files changed, 198 insertions(+), 0 deletions(-) create mode 100644 qapi-schema-guest.json diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json

[Qemu-devel] [PATCH 07/14] ac97: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/ac97.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ac97.c b/hw/ac97.c index a946c1a..a947afc 100644 --- a/hw/ac97.c +++

[Qemu-devel] [PATCH 06/14] eepro100: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David Gibson d...@au1.ibm.com --- hw/eepro100.c | 107 +++-- 1 files changed, 58 insertions(+),

[Qemu-devel] [PATCH 11/14] pcnet: use the DMA memory access interface

2011-06-02 Thread David Gibson
This allows the device to work properly with an emulated IOMMU. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro --- hw/pcnet-pci.c | 17 + 1 files changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c index 9415a1e..9e962a3

Re: [Qemu-devel] [PATCH 01/14] Generic DMA memory access interface

2011-06-02 Thread Richard Henderson
On 06/02/2011 08:12 AM, David Gibson wrote: +err = iommu-translate(dev, addr, paddr, plen, is_write); +if (err) { +return NULL; +} + +/* + * If this is true, the virtual region is contiguous, + * but the translated physical region isn't. We just + *

Re: [Qemu-devel] [PATCH 02/14] pci: add IOMMU support via the generic DMA layer

2011-06-02 Thread Richard Henderson
On 06/02/2011 08:12 AM, David Gibson wrote: --- a/hw/pci_internals.h +++ b/hw/pci_internals.h @@ -14,8 +14,15 @@ extern struct BusInfo pci_bus_info; +typedef DMAMmu *(*pci_iommu_new_device_fn)(PCIBus *); + +struct PCIBusIOMMU { +pci_iommu_new_device_fn new_device; +}; +

Re: [Qemu-devel] [PATCH 01/14] Generic DMA memory access interface

2011-06-02 Thread Eduard - Gabriel Munteanu
On Thu, Jun 02, 2011 at 09:43:32AM -0700, Richard Henderson wrote: On 06/02/2011 08:12 AM, David Gibson wrote: +err = iommu-translate(dev, addr, paddr, plen, is_write); +if (err) { +return NULL; +} + +/* + * If this is true, the virtual region is

[Qemu-devel] [PATCH v3] Introduce format string for pid_t

2011-06-02 Thread Andreas Färber
BeOS and Haiku on i386 use long for 32-bit types, including pid_t. Using %d with pid_t therefore results in a warning. Unfortunately POSIX:2008 does not define a PRId* string for pid_t. In some places pid_t was previously casted to long and %ld hardcoded. The predecessor of this patch added

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B. query-stop-reason I

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage and when a no space error is triggered,

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people who want to use QMP for thin provisioning. That's, the VM is started with a small storage

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/01/2011 04:12 PM, Luiz Capitulino wrote: Hi there, There are people

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 01:01 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35 -0500, Anthony Liguori wrote: On 06/02/2011 04:06 AM, Daniel P. Berrange wrote: B.

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Anthony Liguori
On 06/02/2011 01:09 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 13:00:04 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/02/2011 12:57 PM, Luiz Capitulino wrote: On Wed, 01 Jun 2011 16:35:03 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/01/2011 04:12 PM, Luiz

Re: [Qemu-devel] QMP: RFC: I/O error info query-stop-reason

2011-06-02 Thread Luiz Capitulino
On Thu, 02 Jun 2011 13:32:25 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 06/02/2011 01:01 PM, Luiz Capitulino wrote: On Thu, 02 Jun 2011 09:02:30 -0500 Anthony Liguorianth...@codemonkey.ws wrote: On 06/02/2011 08:24 AM, Jiri Denemark wrote: On Thu, Jun 02, 2011 at 08:08:35

[Qemu-devel] [PATCH] cocoa: Revert dependency on VNC

2011-06-02 Thread Andreas Färber
In 821601ea5b02a68ada479731a4d3d07a9876632a (Make VNC support optional) cocoa.o was moved from ui-obj-$(CONFIG_COCOA) to vnc-obj-$(CONFIG_COCOA), adding a dependency on $(CONFIG_VNC). That must've been unintentional. Cc: Jes Sorensen jes.soren...@redhat.com Cc: Anthony Liguori aligu...@us.ibm.com

[Qemu-devel] [RHEL6 qemu-kvm PATCH 02/11] Allow an optional qemu_early_init_vcpu()

2011-06-02 Thread Eduardo Habkost
From: john cooper john.coo...@redhat.com Allow an optional qemu_early_init_vcpu() such that kvm_arch_get_supported_cpuid() can be used from cpu_x86_register(). Without this minimal setup kvm_arch_get_supported_cpuid() gags kvm_ioctl() via passing a NULL initialized KVMState *. [ehabkost: made

[Qemu-devel] [RHEL6 qemu-kvm PATCH 05/11] cpu defs: use Intel flag names for Intel models

2011-06-02 Thread Eduardo Habkost
Use 'i64' instead of 'lm' and 'xd' instead of 'nx' on Intel models. The flags have different names on Intel docs, so use those names for clarity. This is based on a previous patch from John Cooper where this was introduced with many other changes at the same time. Original John's patch

[Qemu-devel] [RHEL6 qemu-kvm PATCH 07/11] cpu defs: uncomment empty extfeatures_ecx definition for Opteron_G1

2011-06-02 Thread Eduardo Habkost
This should have no visible effect, but it should just clean up the config file a bit. This is based on a previous patch from John Cooper where this was introduced with many other changes at the same time. Original John's patch submission is at Message-ID: 4ddad5e7.2020...@redhat.com,

[Qemu-devel] [RHEL6 qemu-kvm PATCH 04/11] Support -readconfig ? to debug config file loading

2011-06-02 Thread Eduardo Habkost
From: john cooper john.coo...@redhat.com Failure by qemu to open a default config file isn't cause to error exit -- it just quietly continues on. After puzzling issues with otherwise opaque config file locations and startup handling numerous times, some help from qemu seemed justified. In the

  1   2   >