Re: [Qemu-devel] virtio scsi host draft specification, v3

2011-06-30 Thread Paolo Bonzini
On 06/29/2011 11:39 AM, Stefan Hajnoczi wrote: > > Of course, when doing so we would be lose the ability to freely remap > > LUNs. But then remapping LUNs doesn't gain you much imho. > > Plus you could always use qemu block backend here if you want > > to hide the details. > > And you could

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Paolo Bonzini
On 06/30/2011 08:11 PM, Michael S. Tsirkin wrote: > Signed-off-by: Paolo Bonzini Should not machine describe guest behaviour? It seems that a flag to the migrate/save command to control format would be better - this way the same machine can migrate to different formats. I thought about it, bu

Re: [Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support

2011-06-30 Thread Stefan Hajnoczi
On Fri, Jul 1, 2011 at 5:55 AM, Fam Zheng wrote: > Changes from v5: >    01/12: add vmdk_free_extents >    05/12: parameter order fix in calling vmdk_add_extent in vmdk_opem_vmdk4 >    09/12: add bdrv_delete, bs->open_flags >    12/12: change commit message tag. remove duplicated count of > monol

[Qemu-devel] [PATCH v6 11/12] VMDK: fix coding style

2011-06-30 Thread Fam Zheng
Conform coding style in vmdk.c to pass scripts/checkpatch.pl checks. Signed-off-by: Fam Zheng --- block/vmdk.c | 79 +++-- 1 files changed, 48 insertions(+), 31 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 2ea9a7f..6bf242c 100

Re: [Qemu-devel] [PATCH v6 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-30 Thread Stefan Hajnoczi
On Fri, Jul 1, 2011 at 5:55 AM, Fam Zheng wrote: > +        /* save to extents array */ > +        if (!strcmp(type, "FLAT")) { > +            /* FLAT extent */ > +            char extent_path[PATH_MAX]; > +            BlockDriverState *extent_file; > +            BlockDriver *drv; > +            

[Qemu-devel] [PATCH v6 10/12] VMDK: create different subformats

2011-06-30 Thread Fam Zheng
Add create option 'format', with enums: monolithicSparse monolithicFlat twoGbMaxExtentSparse twoGbMaxExtentFlat Each creates a subformat image file. The default is monolithiSparse. Signed-off-by: Fam Zheng --- block/vmdk.c | 559 ++

[Qemu-devel] [PATCH v6 12/12] block: add bdrv_get_allocated_file_size() operation

2011-06-30 Thread Fam Zheng
qemu-img.c wants to count allocated file size of image. Previously it counts a single bs->file by 'stat' or Window API. As VMDK introduces multiple file support, the operation becomes format specific with platform specific meanwhile. The functions are moved to block/raw-{posix,win32}.c and qemu-im

[Qemu-devel] [PATCH v6 04/12] VMDK: separate vmdk_open by format version

2011-06-30 Thread Fam Zheng
Separate vmdk_open by subformats to: * vmdk_open_vmdk3 * vmdk_open_vmdk4 Signed-off-by: Fam Zheng --- block/vmdk.c | 197 ++--- 1 files changed, 131 insertions(+), 66 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 4684670..03248f

[Qemu-devel] [PATCH v6 09/12] VMDK: open/read/write for monolithicFlat image

2011-06-30 Thread Fam Zheng
Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng --- block/vmdk.c | 184 +- 1 files changed, 170 insertions(+), 14 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 40e4464

[Qemu-devel] [PATCH v6 08/12] VMDK: change get_cluster_offset return type

2011-06-30 Thread Fam Zheng
The return type of get_cluster_offset was an offset that use 0 to denote 'not allocated', this will be no longer true for flat extents, as we see flat extent file as a single huge cluster whose offset is 0 and length is the whole file length. So now we use int return value, 0 means success and othe

[Qemu-devel] [PATCH v6 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster

2011-06-30 Thread Fam Zheng
In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng --- block/vmdk.c |8 +--- 1 files changed, 5 insertions(+), 3

[Qemu-devel] [PATCH v6 07/12] VMDK: move 'static' cid_update flag to bs field

2011-06-30 Thread Fam Zheng
Cid_update is the flag for updating CID on first write after opening the image. This should be per image open rather than per program life cycle, so change it from static var of vmdk_write to a field in BDRVVmdkState. Signed-off-by: Fam Zheng --- block/vmdk.c |6 +++--- 1 files changed, 3 in

[Qemu-devel] [PATCH v6 05/12] VMDK: add field BDRVVmdkState.desc_offset

2011-06-30 Thread Fam Zheng
There are several occurrence of magic number 0x200 as the descriptor offset within mono sparse image file. This is not the case for images with separate descriptor file. So a field is added to BDRVVmdkState to hold the correct value. Signed-off-by: Fam Zheng --- block/vmdk.c | 26 +

[Qemu-devel] [PATCH v6 06/12] VMDK: flush multiple extents

2011-06-30 Thread Fam Zheng
Flush all the file that referenced by the image. Signed-off-by: Fam Zheng --- block/vmdk.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 9393ff9..0a09890 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1092,7 +1092,17 @@ s

[Qemu-devel] [PATCH v6 01/12] VMDK: introduce VmdkExtent

2011-06-30 Thread Fam Zheng
Introduced VmdkExtent array into BDRVVmdkState, enable holding multiple image extents for multiple file image support. Signed-off-by: Fam Zheng --- block/vmdk.c | 355 +- 1 files changed, 252 insertions(+), 103 deletions(-) diff --git a/b

[Qemu-devel] [PATCH v6 03/12] VMDK: probe for monolithicFlat images

2011-06-30 Thread Fam Zheng
Probe as the same behavior as VMware does. Recognize image as monolithicFlat descriptor file when the file is text and the first effective line (not '#' leaded comment or space line) is either 'version=1' or 'version=2'. No space or upper case charactors accepted. Signed-off-by: Fam Zheng --- bl

[Qemu-devel] [PATCH v6 00/12] Adding VMDK monolithic flat support

2011-06-30 Thread Fam Zheng
Changes from v5: 01/12: add vmdk_free_extents 05/12: parameter order fix in calling vmdk_add_extent in vmdk_opem_vmdk4 09/12: add bdrv_delete, bs->open_flags 12/12: change commit message tag. remove duplicated count of monolithicSparse Fam Zheng (12): VMDK: introduce VmdkExtent

[Qemu-devel] [Bug 802588] Re: Latest GIT version fails to compile on Linux - setjmp.h problem

2011-06-30 Thread Yongjie Ren
I found this issue is also exist in latest qemu-kvm.git commit d58931037dbb4fbc2fbb33858629d3fabfd1b0d4 Merge: bcd4f22... f8121c4... Author: Avi Kivity Date: Tue Jun 28 15:11:13 2011 +0300 Git log shows it has merged commit 2fb0c09f4f*, but the bug is not fixed. -- You received this bug notif

[Qemu-devel] buildbot failure in qemu on xen_x86_64_debian_5_0

2011-06-30 Thread qemu
The Buildbot has detected a new failure on builder xen_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_x86_64_debian_5_0/builds/20 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on xen_i386_debian_5_0

2011-06-30 Thread qemu
The Buildbot has detected a new failure on builder xen_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_i386_debian_5_0/builds/20 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

Re: [Qemu-devel] [PATCH V3] Support logging xen-guest console

2011-06-30 Thread Chun Yan Liu
On Thursday, June 30, 2011 07:18:54 PM you wrote: > On 06/30/2011 11:39 AM, Chun Yan Liu wrote: > > On Thursday, June 30, 2011 03:58:57 PM Alexander Graf wrote: > >> On 30.06.2011, at 09:08, Chunyan Liu wrote: > >>> Add code to support logging xen-domU console, as what xenconsoled does. > >>> To en

Re: [Qemu-devel] "cpu-exec.c: avoid AREG0 use" breaks x86 emulation on x86-64

2011-06-30 Thread TeLeMan
On Fri, Jul 1, 2011 at 00:47, Jan Kiszka wrote: > Hi Blue, > > commit cea5f9a28f breaks here, just starting qemu without any > parameters: > > Starting program: qemu-system-x86_64 > [Thread debugging using libthread_db enabled] > > Program received signal SIGSEGV, Segmentation fault. > 0x7

Re: [Qemu-devel] device assignment for embedded Power

2011-06-30 Thread Benjamin Herrenschmidt
On Thu, 2011-06-30 at 15:59 +, Yoder Stuart-B08248 wrote: > One feature we need for QEMU/KVM on embedded Power Architecture is the > ability to do passthru assignment of SoC I/O devices and memory. An > important use case in embedded is creating static partitions-- > taking physical memory

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Alexander Graf
On 01.07.2011, at 00:23, Scott Wood wrote: > On Fri, 1 Jul 2011 00:18:22 +0200 > Alexander Graf wrote: > >> >> On 01.07.2011, at 00:11, Scott Wood wrote: >> >>> Almost, but what if we have write permission but not read? >> >> How would you write back data from a cache line when you haven't r

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Fri, 1 Jul 2011 00:18:22 +0200 Alexander Graf wrote: > > On 01.07.2011, at 00:11, Scott Wood wrote: > > > Almost, but what if we have write permission but not read? > > How would you write back data from a cache line when you haven't read it > earlier? The CPU can read it. The program ca

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Fri, 1 Jul 2011 00:28:19 +0200 Alexander Graf wrote: > > On 01.07.2011, at 00:23, Scott Wood wrote: > > > On Fri, 1 Jul 2011 00:18:22 +0200 > > Alexander Graf wrote: > > > >> > >> On 01.07.2011, at 00:11, Scott Wood wrote: > >> > >>> Almost, but what if we have write permission but not r

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Alexander Graf
On 01.07.2011, at 00:32, Scott Wood wrote: > On Fri, 1 Jul 2011 00:28:19 +0200 > Alexander Graf wrote: > >> >> On 01.07.2011, at 00:23, Scott Wood wrote: >> >>> On Fri, 1 Jul 2011 00:18:22 +0200 >>> Alexander Graf wrote: >>> On 01.07.2011, at 00:11, Scott Wood wrote: >

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Alexander Graf
On 01.07.2011, at 00:11, Scott Wood wrote: > On Thu, 30 Jun 2011 23:56:17 +0200 > Alexander Graf wrote: > >> >> On 30.06.2011, at 23:46, Scott Wood wrote: >> >>> On Thu, 30 Jun 2011 23:34:37 +0200 >>> Alexander Graf wrote: >>> We could just keep an internal counter that memorizes how m

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 23:56:17 +0200 Alexander Graf wrote: > > On 30.06.2011, at 23:46, Scott Wood wrote: > > > On Thu, 30 Jun 2011 23:34:37 +0200 > > Alexander Graf wrote: > > > >> We could just keep an internal counter that memorizes how much memory is > >> locked and sets the bit after exce

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 23:34:37 +0200 Alexander Graf wrote: > We could just keep an internal counter that memorizes how much memory is > locked and sets the bit after exceeding the fake cache size. And keep track of unlocks, decrementing the counter only if the address was already locked... seems

[Qemu-devel] [PATCH V3] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. This patch fixes some weird behavior that I see when I use e1000 with QEMU/Xen, the guest memory can be corrupted by this NIC because i

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 23:46, Scott Wood wrote: > On Thu, 30 Jun 2011 23:34:37 +0200 > Alexander Graf wrote: > >> We could just keep an internal counter that memorizes how much memory is >> locked and sets the bit after exceeding the fake cache size. > > And keep track of unlocks, decrementing the

Re: [Qemu-devel] [PATCH V2] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
On Thu, Jun 30, 2011 at 22:09, Peter Maydell wrote: > On 30 June 2011 20:28, Anthony PERARD wrote: >> @@ -202,6 +201,11 @@ rxbufsize(uint32_t v) >>  static void >>  set_ctrl(E1000State *s, int index, uint32_t val) >>  { >> +    DBGOUT(IO, "set ctrl = %08x\n", val); >> +    if (val & E1000_CTRL_RS

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Alexander Graf
On 30.06.2011, at 18:17, Scott Wood wrote: > On Thu, 30 Jun 2011 10:25:31 +0200 > Fabien Chouteau wrote: > >> On 28/06/2011 18:20, Scott Wood wrote: >>> On Tue, 28 Jun 2011 10:17:39 +0200 >>> Fabien Chouteau wrote: >>> Why do you want to set this bit? Can't we consider that the instructi

Re: [Qemu-devel] "cpu-exec.c: avoid AREG0 use" breaks x86 emulation on x86-64

2011-06-30 Thread Stefan Weil
Am 30.06.2011 18:47, schrieb Jan Kiszka: Hi Blue, commit cea5f9a28f breaks here, just starting qemu without any parameters: Starting program: qemu-system-x86_64 [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0x739ac770 in __sigsetjmp

[Qemu-devel] [sparc64] Miscomputed minimum of a group of numbers in sparc64 emulation

2011-06-30 Thread Jakub Jermar
Hi, we have been observing a problem with HelenOS running on the latest git Qemu/sparc64. The gist of the problem is that the following computation of minimum of 64 and 512 surprisingly gives 512: bytes = min(len, BPS(bs) - pos % BPS(bs)); bytes = min(bytes, nodep->size - pos); On input, `len`

Re: [Qemu-devel] [PATCH V2] e1000: Handle IO Port.

2011-06-30 Thread Peter Maydell
On 30 June 2011 20:28, Anthony PERARD wrote: > @@ -202,6 +201,11 @@ rxbufsize(uint32_t v) >  static void >  set_ctrl(E1000State *s, int index, uint32_t val) >  { > +    DBGOUT(IO, "set ctrl = %08x\n", val); > +    if (val & E1000_CTRL_RST) { > +        s->mac_reg[CTRL] = val; > +        e1000_rese

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
On Tue, Jun 28, 2011 at 06:49, Paolo Bonzini wrote: > On 06/27/2011 08:07 PM, Peter Maydell wrote: >> >> >  +    int ioport_base; >> >  +    uint32_t ioport_reg[2]; >> >> I think ioport_reg[] needs to go in the VMStateDescription as well. >> I don't know enough about the PCI subsystem to know whet

[Qemu-devel] [PATCH V2] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
This patch introduces the two IOPorts on e1000, IOADDR and IODATA. The IOADDR is used to specify which register we want to access when we read or write on IODATA. This patch fixes some weird behavior that I see when I use e1000 with QEMU/Xen, the guest memory can be corrupted by this NIC because i

Re: [Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation

2011-06-30 Thread Stefan Weil
Am 30.06.2011 20:33, schrieb Luiz Capitulino: Some constructions in that function have broken indentation. Fix them. Signed-off-by: Luiz Capitulino --- blockdev.c | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) Hi, the new indenta

Re: [Qemu-devel] [PATCH] e1000: Handle IO Port.

2011-06-30 Thread Anthony PERARD
On Mon, Jun 27, 2011 at 19:07, Peter Maydell wrote: > On 27 June 2011 17:34, Anthony PERARD wrote: >> @@ -83,6 +86,8 @@ typedef struct E1000State_st { >>     NICState *nic; >>     NICConf conf; >>     int mmio_index; >> +    int ioport_base; >> +    uint32_t ioport_reg[2]; > > I think ioport_reg[

[Qemu-devel] [PATCH 3/3] block: drive_init(): Improve CHS setting error message

2011-06-30 Thread Luiz Capitulino
The current media doesn't clearly say the error cause. Signed-off-by: Luiz Capitulino --- blockdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index 0a90ae8..2dbdd1b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -311,7 +311,7 @@ DriveInfo *dr

[Qemu-devel] [PATCH 1/3] block: drive_init(): Fix indentation

2011-06-30 Thread Luiz Capitulino
Some constructions in that function have broken indentation. Fix them. Signed-off-by: Luiz Capitulino --- blockdev.c | 52 ++-- 1 files changed, 26 insertions(+), 26 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7d579d6..27bf68a 100644

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2011 at 06:27:13PM +0100, Peter Maydell wrote: > On 30 June 2011 16:57, Michael S. Tsirkin wrote: > > diff --git a/configure b/configure > > index 856b41e..6f7dd74 100755 > > --- a/configure > > +++ b/configure > > @@ -822,7 +822,6 @@ esac > > > >  [ -z "$guest_base" ] && guest_bas

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/30/2011 04:11 PM, Stefano Stabellini wrote: > > On Thu, 30 Jun 2011, Alexander Graf wrote: > >> On 06/30/2011 12:21 PM, Stefano Stabellini wrote: > >>> On Thu, 30 Jun 2011, Wei Liu wrote: > On Thu, Jun 30, 2011 at 4:31 PM, Alexander Graf wro

Re: [Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 17:51:10 +0200 Fabien Chouteau wrote: > On 28/06/2011 19:49, Scott Wood wrote: > > On Tue, 28 Jun 2011 15:35:00 +0200 > > Fabien Chouteau wrote: > > > >> On 27/06/2011 22:28, Scott Wood wrote: > >>> On Mon, 27 Jun 2011 18:14:06 +0200 > >>> Fabien Chouteau wrote: > >>> > >>>

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Peter Maydell
On 30 June 2011 16:57, Michael S. Tsirkin wrote: > diff --git a/configure b/configure > index 856b41e..6f7dd74 100755 > --- a/configure > +++ b/configure > @@ -822,7 +822,6 @@ esac > >  [ -z "$guest_base" ] && guest_base="$host_guest_base" > > - >  default_target_list="" > >  # these targets are p

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 04:52:00PM +0200, Kevin Wolf wrote: > Am 30.06.2011 16:36, schrieb Marcelo Tosatti: > >> 4. Live block copy API and high-level control - the main code that > >> adds the live block copy feature. Existing patches by Marcelo, can be > >> restructured to use common core by Mar

[Qemu-devel] [PATCH 2/3] block: drive_init(): Simplify interface type setting

2011-06-30 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- blockdev.c | 11 --- 1 files changed, 4 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index 27bf68a..0a90ae8 100644 --- a/blockdev.c +++ b/blockdev.c @@ -241,13 +241,6 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)

[Qemu-devel] [PATCH v5] xen_console: support the new extended xenstore protocol

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under xen-unstable.hg. >From the Qemu poin

[Qemu-devel] [PATCH 0/3]: block: Small drive_init() improvements

2011-06-30 Thread Luiz Capitulino
Please, see individual patches for details. blockdev.c | 65 --- 1 files changed, 31 insertions(+), 34 deletions(-)

[Qemu-devel] "cpu-exec.c: avoid AREG0 use" breaks x86 emulation on x86-64

2011-06-30 Thread Jan Kiszka
Hi Blue, commit cea5f9a28f breaks here, just starting qemu without any parameters: Starting program: qemu-system-x86_64 [Thread debugging using libthread_db enabled] Program received signal SIGSEGV, Segmentation fault. 0x739ac770 in __sigsetjmp () from /lib64/libc.so.6 (gdb) bt #0 0x00

[Qemu-devel] [PATCH v4] xen_console: support the new extended xenstore protocol

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document docs/misc/console.txt under xen-unstable.hg. >From the Qemu poin

[Qemu-devel] device assignment for embedded Power

2011-06-30 Thread Yoder Stuart-B08248
One feature we need for QEMU/KVM on embedded Power Architecture is the ability to do passthru assignment of SoC I/O devices and memory. An important use case in embedded is creating static partitions-- taking physical memory and I/O devices (non-PCI) and partitioning them between the host Linux

Re: [Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Michael S. Tsirkin
On Thu, Jun 30, 2011 at 05:46:14PM +0200, Paolo Bonzini wrote: > We need to provide a new migration format, and not break migration > in old machine models. So add a migration_format field to QEMUMachine. > > Signed-off-by: Paolo Bonzini Should not machine describe guest behaviour? It seems tha

Re: [Qemu-devel] [PATCH] Add e500 instructions dcblc, dcbtls and dcbtstl as no-op

2011-06-30 Thread Scott Wood
On Thu, 30 Jun 2011 10:25:31 +0200 Fabien Chouteau wrote: > On 28/06/2011 18:20, Scott Wood wrote: > > On Tue, 28 Jun 2011 10:17:39 +0200 > > Fabien Chouteau wrote: > > > >> Why do you want to set this bit? Can't we consider that the instruction is > >> always effective? > > > > But it's not.

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: > > From: Stefano Stabellini > > > > Since CS 21994 on xen-unstable.hg and CS > > 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few > > changes have been introduced to t

Re: [Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Paolo Bonzini
On 06/30/2011 05:57 PM, Michael S. Tsirkin wrote: Support build on rhel 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in qemu-kvm.git). Signed-off-by: Michael S. Tsirkin --- Changes from v1: checkpatch

[Qemu-devel] [PATCHv2] Add compat eventfd header

2011-06-30 Thread Michael S. Tsirkin
Support build on rhel 5.X where we have syscall for eventfd but not userspace wrapper. (cherry-picked from commit 9e3269181e9bc56feb43bcd4e8ce0b82cd543e65 in qemu-kvm.git). Signed-off-by: Michael S. Tsirkin --- Changes from v1: checkpatch fix address comments by agraf verify we are on li

Re: [Qemu-devel] [PATCH] [PowerPC][RFC] booke timers

2011-06-30 Thread Fabien Chouteau
On 28/06/2011 19:49, Scott Wood wrote: > On Tue, 28 Jun 2011 15:35:00 +0200 > Fabien Chouteau wrote: > >> On 27/06/2011 22:28, Scott Wood wrote: >>> On Mon, 27 Jun 2011 18:14:06 +0200 >>> Fabien Chouteau wrote: >>> While working on the emulation of the freescale p2010 (e500v2) I realized >

[Qemu-devel] [RFC PATCH 3/4] savevm: define new unambiguous migration format

2011-06-30 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix corrup

[Qemu-devel] [RFC PATCH 1/4] add support for machine models to specify their migration format

2011-06-30 Thread Paolo Bonzini
We need to provide a new migration format, and not break migration in old machine models. So add a migration_format field to QEMUMachine. Signed-off-by: Paolo Bonzini --- cpu-common.h |3 --- hw/boards.h |1 + qemu-common.h |3 +++ savevm.c |7 +-- 4 files changed, 9

[Qemu-devel] [PATCH V2] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

2011-06-30 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/piix_pci.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 26ce904..71528f4 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = { .no_ho

[Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-06-30 Thread Paolo Bonzini
With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In the past QEMU assumed it was always a part of a subsection; after commit eb60260 (savevm: fix corrup

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 16:36, schrieb Marcelo Tosatti: >> 4. Live block copy API and high-level control - the main code that >> adds the live block copy feature. Existing patches by Marcelo, can be >> restructured to use common core by Marcelo. > > Can use your proposed block_stream interface, with a "blo

[Qemu-devel] [RFC PATCH 4/4] Partially revert "savevm: fix corruption in vmstate_subsection_load()."

2011-06-30 Thread Paolo Bonzini
This reverts the additional check in commit eb60260d (but not the assertions). The new format does not require the check, and with the old format it traded one kind of bogus failure for a different kind of silent failure. Signed-off-by: Paolo Bonzini --- savevm.c |4 1 files changed, 0

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fix MinGW compilation when --enable-vnc-jpeg is specified

2011-06-30 Thread Paolo Bonzini
On 06/27/2011 07:22 PM, Stefan Weil wrote: > Am 27.06.2011 07:56, schrieb Roy Tam: >> 2011/6/27 Stefan Weil: >>> Am 27.06.2011 04:37, schrieb TeLeMan: This patch breaks the compilation with --enable-vnc-png: CC ui/vnc-enc-tight.o In file included from /usr/include/png.h:518, >>>

[Qemu-devel] [RFC PATCH 2/4] add pc-0.14 machine

2011-06-30 Thread Paolo Bonzini
The new pc-0.15 machine will have a different migration format, so define the compatibility one right now. Signed-off-by: Paolo Bonzini --- hw/pc_piix.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index c5c16b4..18cc942 100644 ---

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_state_handler shared between xen_pv and xen_hvm machines to record the VM state to xenstore. Sign

Re: [Qemu-devel] [PATCH] xen_console: fix memory leak

2011-06-30 Thread Alexander Graf
On 06/24/2011 05:59 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini con_init leaks the string "type", fix it. Thanks, applied to xen-next branch. Alex

Re: [Qemu-devel] [PATCH v3] xen_disk: cope with missing xenstore "params" node

2011-06-30 Thread Alexander Graf
On 06/27/2011 05:10 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini When disk is a cdrom and the drive is empty the "params" node in xenstore might be missing completely: cope with it instead of segfaulting. Updated in v2: - actually removed the strchr(blkdev->params, ':'

Re: [Qemu-devel] [PATCH 1/2] xen: enable console and disk backend in HVM mode

2011-06-30 Thread Alexander Graf
On 06/24/2011 04:54 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Initialize the Xen console backend and the Xen disk backend even when running in HVM mode so that PV on HVM drivers can connect to them. Thanks, applied to xen-next branch. Alex Signed-off-by: Stefano S

Re: [Qemu-devel] [PATCH v2 2/2] xen: add vkbd support for PV on HVM guests

2011-06-30 Thread Alexander Graf
On 06/24/2011 06:36 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Register the vkbd backend even when running as device emulator for HVM guests: it is useful because it doesn't need a frequent timer like usb. Check whether the XenInput DisplayState has been set in the ini

[Qemu-devel] [PATCH v2] xen_disk: treat "aio" as "raw"

2011-06-30 Thread stefano.stabellini
From: Stefano Stabellini Sometimes the toolstack uses "aio" without an additional format identifier, in such cases use "raw". Updated in v2: - fix code style. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/xen

Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/30/2011 04:20 PM, Stefano Stabellini wrote: > > On Thu, 30 Jun 2011, Alexander Graf wrote: > >> On 06/30/2011 02:47 PM, Kevin Wolf wrote: > >>> Am 30.06.2011 13:47, schrieb Alexander Graf: > On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix

Re: [Qemu-devel] [PATCH v2] qemu_ram_ptr_length: take ram_addr_t as arguments

2011-06-30 Thread Alexander Graf
On 06/27/2011 07:26 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini qemu_ram_ptr_length should take ram_addr_t as argument rather than target_phys_addr_t because is doing comparisons with RAMBlock addresses. cpu_physical_memory_map should create a ram_addr_t address to pass

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: > > From: Anthony PERARD > > > > Remove the call to xenstore_record_dm_state from xen_main_loop_prepare > > that is HVM specific. > > Add a new vm_change_state_handler shared between xen_pv

Re: [Qemu-devel] [PATCH v2 0/3] Xen cleanups

2011-06-30 Thread Alexander Graf
On 06/21/2011 10:59 PM, Jan Kiszka wrote: Changes to v1: - rebase over xen-next which includes - dropping of xen_unmap_block uninlining (as it's gone) Thanks, applied to the xen-next branch. PS: Alex, there must be some patch(es) with style issues in your queue. Please avoid accepting an

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:11 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 12:21 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Wei Liu wrote: On Thu, Jun 30, 2011 at 4:31 PM, Alexander Graf wrote: On 29.06.2011, at 15:59, Wei Liu wrote: Hi, QEMU folk

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Marcelo Tosatti
On Thu, Jun 30, 2011 at 01:54:09PM +0100, Stefan Hajnoczi wrote: > On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti wrote: > > On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote: > >>  This can be used to merge data from an intermediate image without > >> merging the base image.  When

Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:20 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Sometimes the toolstack

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Alexander Graf
On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Since CS 21994 on xen-unstable.hg and CS 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few changes have been introduced to the PV console xenstore protocol, as described by the document

Re: [Qemu-devel] [PATCH] xen: introduce xen_change_state_handler

2011-06-30 Thread Alexander Graf
On 06/30/2011 04:37 PM, Stefano Stabellini wrote: On Thu, 30 Jun 2011, Alexander Graf wrote: On 06/29/2011 01:16 PM, stefano.stabell...@eu.citrix.com wrote: From: Anthony PERARD Remove the call to xenstore_record_dm_state from xen_main_loop_prepare that is HVM specific. Add a new vm_change_sta

Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/30/2011 02:47 PM, Kevin Wolf wrote: > > Am 30.06.2011 13:47, schrieb Alexander Graf: > >> On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: > >>> From: Stefano Stabellini > >>> > >>> Sometimes the toolstack uses "aio" without an addit

Re: [Qemu-devel] [PATCH v3] xen_console: support the new extended xenstore protocol

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/29/2011 01:12 PM, stefano.stabell...@eu.citrix.com wrote: > > From: Stefano Stabellini > > > > Since CS 21994 on xen-unstable.hg and CS > > 466608f3a32e1f9808acdf832a5843af37e5fcec on qemu-xen-unstable.git, few > > changes have been introduced to t

Re: [Qemu-devel] [PATCH v3] xen: implement unplug protocol in xen_platform

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Kevin Wolf wrote: > > +static int pci_piix3_xen_ide_unplug(DeviceState *dev) > > +{ > > +PCIDevice *pci_dev; > > +PCIIDEState *pci_ide; > > +DriveInfo *di; > > +int i = 0; > > + > > +pci_dev = DO_UPCAST(PCIDevice, qdev, dev); > > +pci_ide = DO_UPCAST(PCI

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Anthony Liguori
On 06/28/2011 08:48 AM, Avi Kivity wrote: On 06/28/2011 04:43 PM, Anthony Liguori wrote: FYI, I'm in an all-day meeting so I can't attend. Did you do something really bad? I named some variables with a leading underscore and now have to be re-educated. Regards, Anthony Liguori

Re: [Qemu-devel] Questions on DeviceState and Virtio infrastructure

2011-06-30 Thread Stefano Stabellini
On Thu, 30 Jun 2011, Alexander Graf wrote: > On 06/30/2011 12:21 PM, Stefano Stabellini wrote: > > On Thu, 30 Jun 2011, Wei Liu wrote: > >> On Thu, Jun 30, 2011 at 4:31 PM, Alexander Graf wrote: > >>> On 29.06.2011, at 15:59, Wei Liu wrote: > >>> > Hi, QEMU folks > > I know that I

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-30 Thread Gerd Hoffmann
Hi, Yes. Backward compatibility. So at least deprecate it to be dropped later? I don't like that the code just gets bigger and bigger. Deprecate them is fine. I was thinking of a different solution - one in which the same "READY" messages are written, but read from a different place.

Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-30 Thread Alexander Graf
On 06/30/2011 02:47 PM, Kevin Wolf wrote: Am 30.06.2011 13:47, schrieb Alexander Graf: On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: From: Stefano Stabellini Sometimes the toolstack uses "aio" without an additional format identifier, in such cases use "raw". Shouldn't this r

Re: [Qemu-devel] [PATCH] checkpatch: don't error out on },{ lines

2011-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 7:09 AM, Alexander Graf wrote: > When having code like this: > >    static PCIDeviceInfo piix_ide_info[] = { >        { >            .qdev.name    = "piix3-ide", >            .qdev.size    = sizeof(PCIIDEState), >            .qdev.no_user = 1, >            .no_hotplug   = 1

Re: [Qemu-devel] [PATCH] xen_disk: treat "aio" as "raw"

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 13:47, schrieb Alexander Graf: > On 06/24/2011 04:50 PM, stefano.stabell...@eu.citrix.com wrote: >> From: Stefano Stabellini >> >> Sometimes the toolstack uses "aio" without an additional format >> identifier, in such cases use "raw". > > Shouldn't this rather be a patch to the tools

Re: [Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_UPDATE_MEM for guest S3&S4 support

2011-06-30 Thread Alon Levy
On Thu, Jun 30, 2011 at 02:12:52PM +0200, Gerd Hoffmann wrote: > Hi, > > >My thoughts exactly. Any reason to support the old non async messages if we > >do this? > > Yes. Backward compatibility. So at least deprecate it to be dropped later? I don't like that the code just gets bigger and big

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Edgar E. Iglesias
On Thu, Jun 30, 2011 at 06:30:04PM +0530, Suzuki Poulose wrote: > On 06/30/11 18:02, Edgar E. Iglesias wrote: > > On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: > >> Hi, > >> > >> I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, > >> I would like to use t

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Suzuki Poulose
On 06/30/11 18:02, Edgar E. Iglesias wrote: On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The only available PPC440 support in Qemu is for the ppc-virtex. (Thanks for

Re: [Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Edgar E. Iglesias
On Thu, Jun 30, 2011 at 05:45:23PM +0530, Suzuki Poulose wrote: > Hi, > > I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, > I would like to use the Qemu. The only available PPC440 support in Qemu is > for the ppc-virtex. (Thanks for adding the support). > > I was tryin

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Stefan Hajnoczi
On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti wrote: > On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote: >>  This can be used to merge data from an intermediate image without >> merging the base image.  When streaming completes the backing file >> will be set to the base image.  

[Qemu-devel] [PATCH] checkpatch: don't error out on },{ lines

2011-06-30 Thread Alexander Graf
When having code like this: static PCIDeviceInfo piix_ide_info[] = { { .qdev.name= "piix3-ide", .qdev.size= sizeof(PCIIDEState), .qdev.no_user = 1, .no_hotplug = 1, .init = pci_piix_ide_initfn, .v

Re: [Qemu-devel] KVM call agenda for June 28

2011-06-30 Thread Kevin Wolf
Am 30.06.2011 13:48, schrieb Stefan Hajnoczi: > On Wed, Jun 29, 2011 at 4:41 PM, Marcelo Tosatti wrote: >> On Wed, Jun 29, 2011 at 11:08:23AM +0100, Stefan Hajnoczi wrote: >>> In the future we could add a 'base' argument to block_stream. If base >>> is specified then data contained in the base im

[Qemu-devel] Setting up PPC440 Virtex Image for Qemu

2011-06-30 Thread Suzuki Poulose
Hi, I am working on enabling the KEXEC on PPC440 chipsets. To debug my patches, I would like to use the Qemu. The only available PPC440 support in Qemu is for the ppc-virtex. (Thanks for adding the support). I was trying to use the default image provided at http://wiki.qemu.org/download/ppc-vir

  1   2   >