Re: [Qemu-devel] [PATCH v5 00/10] trace-state: make the behaviour of disable consistent across all backends

2011-07-12 Thread Stefan Hajnoczi
On Tue, Jun 28, 2011 at 5:52 PM, Lluís xscr...@gmx.net wrote: This patch defines the disable trace event state to always use the nop backend. Apologies for not reviewing sooner. I have begun and will send feedback tomorrow. Stefan

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Richard Henderson
On 07/12/2011 09:43 AM, Alexander Graf wrote: For now, just force the mapping to somewhere mappable :) Unfortunately, I can tell you that there is no such place. The text segment is mapped by default at 0x4000 and the data segment is by default mapped at 0x6000. If you

Re: [Qemu-devel] [PATCH v5] Add support for Zipit Z2 machine

2011-07-12 Thread Peter Maydell
On 6 July 2011 14:52, Vasily Khoruzhick anars...@gmail.com wrote: Zipit Z2 is small PXA270 based handheld. Signed-off-by: Vasily Khoruzhick anars...@gmail.com --- v2: codestyle fixes, added VMStateDescription for LCD device and AER915,    traces clean up. v3: no changes v4: no changes v5:

[Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h is overkill. Besides, qemu-common.h is bloated

[Qemu-devel] [PATCH v2 0/2]: Fix build issue with error.h

2011-07-12 Thread Luiz Capitulino
A .c file including error.h and not including qemu-common.h will break the build, because error.h uses a macro defined in qemu-common.h. The simple and obvious fix would be to change error.h to include qemu-common.h. But this is overkill, so this series does some splitting in qemu-common.h and

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Peter Maydell
On 12 July 2011 17:43, Alexander Graf ag...@suse.de wrote: I guess the long-term solution here really is to use the softmmu for linux-user as well - unless we're running 32-on-64. Even for 32-on-64 we need to control the guest's address space properly (so we don't do things like gratuitously

Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Chris Wright
* Chris Wright (chr...@sous-sol.org) wrote: * Stefan Hajnoczi (stefa...@linux.vnet.ibm.com) wrote: @@ -199,6 +200,11 @@ static void change_process_uid(void) fprintf(stderr, Failed to setgid(%d)\n, user_pwd-pw_gid); exit(1); } +if

[Qemu-devel] [PATCH 2/2] Error: Fix build when qemu-common.h is not included

2011-07-12 Thread Luiz Capitulino
From: Luiz Capitulino lcapitul...@gmail.com Commit e4ea5e2d0e0e4c5188ab45b66f3195062ae059dc added the use of the macro GCC_FMT_ATTR to error.h, however compiler.h is not included by error.h This will cause a build error when files including error.h don't include qemu-common.h (or compiler.h).

Re: [Qemu-devel] [PATCH v2 1/9] exec: add endian specific phys ld/st functions

2011-07-12 Thread Blue Swirl
Thanks, applied all. On Tue, Jul 12, 2011 at 10:52 AM, Alexander Graf ag...@suse.de wrote: Am 06.07.2011 um 09:09 schrieb Alexander Graf ag...@suse.de: Device code some times needs to access physical memory and does that through the ld./st._phys functions. However, these are the exact same

[Qemu-devel] [PATCH] linux-user/signal.c: Rename s390 target_ucontext fields to fix ia64

2011-07-12 Thread Peter Maydell
The ia64 sys/ucontext.h defines macros 'uc_link', 'uc_sigmask' and 'uc_stack'. Rename the s390 target_ucontext struct members to tuc_*, bringing them into line with the other targets and fixing a compile failure on ia64 hosts caused by this clash. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 1/2] qemu-options.hx: Document missing -drive options

2011-07-12 Thread Luiz Capitulino
They are 'werror', 'rerror' and 'readonly'. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-options.hx |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index e6d7adc..64114dd 100644 --- a/qemu-options.hx +++

[Qemu-devel] [PATCH v2 0/2]: block: Document -drive options

2011-07-12 Thread Luiz Capitulino
Please, see individual patches for details. v2 o Correct man-page text o Document -drive options in qemu-config.c qemu-config.c |6 ++ qemu-options.hx |8 2 files changed, 14 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread malc
On Tue, 12 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple header files that depend only on the compiler macros, so including qemu-common.h

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) malc av1...@comtv.ru wrote: On Tue, 12 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h. The reason for this change is that there are simple

Re: [Qemu-devel] [PATCH 6/9] pl080: use specific endian ld/st_phys

2011-07-12 Thread Peter Maydell
On 5 July 2011 17:28, Alexander Graf ag...@suse.de wrote: --- a/hw/pl080.c +++ b/hw/pl080.c @@ -199,10 +199,10 @@ again:             if (size == 0) {                 /* Transfer complete.  */                 if (ch-lli) { -                    ch-src = ldl_phys(ch-lli); -                    

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread malc
On Tue, 12 Jul 2011, Luiz Capitulino wrote: On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) malc av1...@comtv.ru wrote: On Tue, 12 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com This moves compiler related macros from qemu-common.h to compiler.h.

Re: [Qemu-devel] [PATCH] tcg: Reload local variables after return from longjmp

2011-07-12 Thread Blue Swirl
Thanks, applied. On Sat, Jul 2, 2011 at 10:50 AM, Jan Kiszka jan.kis...@web.de wrote: From: Jan Kiszka jan.kis...@siemens.com Recent compilers look deep into cpu_exec, find longjmp as a noreturn function and decide to smash some stack variables as they won't be used again. This may lead to

Re: [Qemu-devel] [PATCH] exec.c: Fix calculation of code_gen_buffer_max_size

2011-07-12 Thread Blue Swirl
Thanks, applied. On Wed, Jul 6, 2011 at 2:07 PM, Peter Maydell peter.mayd...@linaro.org wrote: Ping? On 22 June 2011 11:58, Peter Maydell peter.mayd...@linaro.org wrote: When calculating the point at which we should not try to put another TB into the code gen buffer, we have to allow not

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
Yes, exactly what happened when loading a non-trivial binary. :-( Oh well. On Wed, Jul 13, 2011 at 12:04 AM, Richard Henderson r...@twiddle.net wrote: On 07/12/2011 09:43 AM, Alexander Graf wrote: For now, just force the mapping to somewhere mappable :) Unfortunately, I can tell you that

Re: [Qemu-devel] [PATCH] exec-all.h: Make MAX_OP_PER_INSTR large enough for target-arm's uses

2011-07-12 Thread Blue Swirl
Thanks, applied. On Wed, Jul 6, 2011 at 2:15 PM, Peter Maydell peter.mayd...@linaro.org wrote: Ping? On 22 June 2011 15:16, Peter Maydell peter.mayd...@linaro.org wrote: The target-arm frontend's worst-case TCG ops per instr is 194 (and in general many of the load multiple registers ARM

Re: [Qemu-devel] [PATCH] target-alpha, target-ppc: Remove unnecessary setjmp.h include

2011-07-12 Thread Blue Swirl
Thanks, applied. On Tue, Jul 5, 2011 at 12:02 AM, Peter Maydell peter.mayd...@linaro.org wrote: Remove the include of setjmp.h from the cpu.h of target-alpha and target-ppc. This is unnecessary because cpu-defs.h already includes this header; this change brings these two targets into line

Re: [Qemu-devel] [PATCH 1/2] Introduce compiler.h header file

2011-07-12 Thread Luiz Capitulino
On Wed, 13 Jul 2011 00:43:42 +0400 (MSD) malc av1...@comtv.ru wrote: On Tue, 12 Jul 2011, Luiz Capitulino wrote: On Wed, 13 Jul 2011 00:31:56 +0400 (MSD) malc av1...@comtv.ru wrote: On Tue, 12 Jul 2011, Luiz Capitulino wrote: From: Luiz Capitulino lcapitul...@gmail.com

Re: [Qemu-devel] [PATCH v2] Remove unneeded setjmp.h (fix compilation on Debian lenny)

2011-07-12 Thread Blue Swirl
Thanks, applied. On Mon, Jul 4, 2011 at 9:52 PM, Stefan Weil w...@mail.berlios.de wrote: Some versions of png.h cannot be included after setjmp.h, even when PNG_SKIP_SETJMP_CHECK was defined. setjmp.h was included from qemu-common.h and is not needed there. Removing the include statement

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Richard Henderson
On 07/12/2011 01:58 PM, Prashant Vaibhav wrote: Yes, exactly what happened when loading a non-trivial binary. :-( Oh well. If you've got an ia64 cross-compiler, you could still make progress on qemu by building your own binaries and linking them somewhere convenient in the low 64 TB. r~

Re: [Qemu-devel] [PATCH v2] esp: cancel current request only if some request is in flight

2011-07-12 Thread Blue Swirl
Thanks, applied. 2011/7/9 Hervé Poussineau hpous...@reactos.org: This bug was introduced in 94d3f98a3f3caddd7875f9a11776daeb84962a7b: scsi_cancel_io was checking if some request was pending before trying to cancel it, while scsi_req_cancel always cancels the request. This may lead to a crash

Re: [Qemu-devel] [PATCH] os-posix: set groups properly for -runas

2011-07-12 Thread Blue Swirl
Thanks, applied. On Sat, Jul 9, 2011 at 12:22 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Andrew Griffiths reports that -runas does not set supplementary group IDs.  This means that gid 0 (root) is not dropped when switching to an unprivileged user. Add an initgroups(3) call to

Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-12 Thread Alex Williamson
On Sun, 2011-07-10 at 21:14 +0300, Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com --- hw/rtl8139.c | 172 +- 1 files changed, 51 insertions(+), 121 deletions(-) diff --git a/hw/rtl8139.c b/hw/rtl8139.c index

Re: [Qemu-devel] [RFC v3 30/56] rtl8139: convert to memory API

2011-07-12 Thread Alex Williamson
On Tue, 2011-07-12 at 16:41 -0600, Alex Williamson wrote: On Sun, 2011-07-10 at 21:14 +0300, Avi Kivity wrote: Signed-off-by: Avi Kivity a...@redhat.com --- hw/rtl8139.c | 172 +- 1 files changed, 51 insertions(+), 121

[Qemu-devel] [PATCH v6 01/18] Add hard build dependency on glib

2011-07-12 Thread Michael Roth
From: Anthony Liguori aligu...@us.ibm.com GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented programming infrastructure.

[Qemu-devel] [PATCH v6 03/18] qapi: add module init types for qapi

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- module.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/module.h b/module.h index 9263f1c..ef66730 100644 --- a/module.h +++ b/module.h @@ -24,12 +24,14 @@ typedef enum { MODULE_INIT_BLOCK,

[Qemu-devel] [PATCH v6 07/18] qapi: add QAPI dealloc visitor

2011-07-12 Thread Michael Roth
Type of Visitor class that can be passed into a qapi-generated C type's visitor function to free() any heap-allocated data types. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile.objs |2 +- qapi/qapi-dealloc-visitor.c | 147

[Qemu-devel] [PATCH v6 02/18] qlist: add qlist_first()/qlist_next()

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qlist.h | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/qlist.h b/qlist.h index dbe7b92..d426bd4 100644 --- a/qlist.h +++ b/qlist.h @@ -16,6 +16,7 @@ #include qobject.h #include qemu-queue.h #include

[Qemu-devel] [PATCH v6 04/18] qapi: add QAPI visitor core

2011-07-12 Thread Michael Roth
Base definitions/includes for Visiter interface used by generated visiter/marshalling code. Includes a GenericList type. Our lists require an embedded element. Since these types are generated, if you want to use them in a different type of data structure, there's no easy way to add another

[Qemu-devel] [PATCH v6 05/18] qapi: add QMP input visitor

2011-07-12 Thread Michael Roth
A type of Visiter class that is used to walk a qobject's structure and assign each entry to the corresponding native C type. Command marshaling function will use this to pull out QMP command parameters recieved over the wire and pass them as native arguments to the corresponding C functions.

[Qemu-devel] [PATCH v6 13/18] qapi: add qapi-visit.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi visiter functions used to marshal/unmarshal/dealloc qapi types. It generates the following 2 files: $(prefix)qapi-visit.c: visiter function for a particular c type, used to automagically convert qobjects into the

[Qemu-devel] [QAPI+QGA 2/3] QAPI code generation infrastructure v6

2011-07-12 Thread Michael Roth
This is Set 2/3 of the QAPI+QGA patchsets. These patches apply on top of master (set1 merged), and can also be obtained from: git://repo.or.cz/qemu/mdroth.git qapi-backport-set2-v6 (Set1+2 are a backport of some of the QAPI-related work from Anthony's glib tree. The main goal is to get the basic

[Qemu-devel] [PATCH v6 15/18] qapi: test schema used for unit tests

2011-07-12 Thread Michael Roth
This is how QMP commands/parameters/types would be defined. We use a subset of that functionality here to implement functions/types for unit testing. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qapi-schema-test.json | 22 ++ 1 files changed, 22 insertions(+),

[Qemu-devel] [PATCH v6 09/18] qapi: add QMP dispatch functions

2011-07-12 Thread Michael Roth
Given an object recieved via QMP, this code uses the dispatch table provided by qmp_registry.c to call the corresponding marshalling/dispatch function and format return values/errors for delivery to the QMP. Currently only synchronous QMP functions are supported, but this will also be used for

[Qemu-devel] [PATCH v6 12/18] qapi: add qapi-types.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi types. It will generation the following files: $(prefix)qapi-types.h - C types corresponding to types defined in the schema you pass in $(prefix)qapi-types.c - Cleanup functions for the above C types The $(prefix) is used to as a

[Qemu-devel] [PATCH v6 16/18] qapi: add test-visitor, tests for gen. visitor code

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile | 18 +++- test-visitor.c | 306 2 files changed, 322 insertions(+), 2 deletions(-) create mode 100644 test-visitor.c diff --git a/Makefile b/Makefile index

[Qemu-devel] [PATCH v6 11/18] qapi: add qapi.py helper libraries

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/qapi.py | 203 +++ 1 files changed, 203 insertions(+), 0 deletions(-) create mode 100644 scripts/qapi.py diff --git a/scripts/qapi.py b/scripts/qapi.py new file mode 100644

[Qemu-devel] [PATCH v6 14/18] qapi: add qapi-commands.py code generator

2011-07-12 Thread Michael Roth
This is the code generator for qapi command marshaling/dispatch. Currently only generators for synchronous qapi/qmp functions are supported. This script generates the following files: $(prefix)qmp-marshal.c: command marshal/dispatch functions for each QMP command

[Qemu-devel] [PATCH v6 17/18] qapi: add test-qmp-commands, tests for gen. marshalling/dispatch code

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile|8 +++- test-qmp-commands.c | 113 +++ 2 files changed, 120 insertions(+), 1 deletions(-) create mode 100644 test-qmp-commands.c diff --git a/Makefile b/Makefile

[Qemu-devel] [PATCH v6 18/18] qapi: add QAPI code generation documentation

2011-07-12 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- docs/qapi-code-gen.txt | 316 1 files changed, 316 insertions(+), 0 deletions(-) create mode 100644 docs/qapi-code-gen.txt diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt

Re: [Qemu-devel] Loading ELF binaries with very high base addresses

2011-07-12 Thread Prashant Vaibhav
That is what I am doing except that my binaries also don't have any data section and don't link against any libraries. The text section does start at 0x4000 but they get mapped at 0x1000 or similar location. I can also build binaries with low base addresses. When these basic ones are

[Qemu-devel] buildbot failure in qemu on qmp_i386_debian_5_0

2011-07-12 Thread qemu
The Buildbot has detected a new failure on builder qmp_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/qmp_i386_debian_5_0/builds/32 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

Re: [Qemu-devel] PCI with Xilinx virtex-ml507 board

2011-07-12 Thread Lê Đức Tài
On Jul 11, 2011 15:31, Edgar E. Iglesias edgar.igles...@gmail.com wrote: Hi, The emulated board and fpga config doesnt have pci. It does have a xilinx ll-temac ethernet mac though. I have patches for that, its on my todo list to post them. Right now im on the road with little access to

[Qemu-devel] [PATCH 0/4] SPARC64: Implement sparcv9 ldfa/stfa instructions

2011-07-12 Thread Tsuneo Saito
Hi, This patch series implements sparcv9 stfa/ldfa instructions with non block-transfer ASIs that implementations seem to be left unfinished. This patch also adds fp_disabled exception checks on stfa/ldfa as they are FP instructions. target-sparc/op_helper.c | 31

[Qemu-devel] [PATCH 2/4] SPARC64: fp_disabled checks on ldfa/lddfa/ldqfa

2011-07-12 Thread Tsuneo Saito
ldfa/lddfa/ldqfa instructions should raise fp_disabled exceptions if %pstate.PEF==0 or %fprs.FEF==0. Signed-off-by: Tsuneo Saito tsnsa...@gmail.com --- target-sparc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-sparc/translate.c

[Qemu-devel] [PATCH 1/4] SPARC64: Implement ldfa/lddfa/ldqfa instructions properly

2011-07-12 Thread Tsuneo Saito
This patch implements sparcv9 ldfa/lddfa/ldqfa instructions with non block-load ASIs. Signed-off-by: Tsuneo Saito tsnsa...@gmail.com --- target-sparc/op_helper.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/target-sparc/op_helper.c

[Qemu-devel] [PATCH 3/4] SPARC64: Implement stfa/stdfa/stqfa instrcutions properly

2011-07-12 Thread Tsuneo Saito
This patch implements sparcv9 stfa/stdfa/stqfa instructions with non block-store ASIs. Signed-off-by: Tsuneo Saito tsnsa...@gmail.com --- target-sparc/op_helper.c | 15 +++ target-sparc/translate.c |2 -- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 4/4] SPARC64: fp_disabled checks on stfa/stdfa/stqfa

2011-07-12 Thread Tsuneo Saito
stfa/stdfa/stqfa instructions should raise fp_disabled exceptions if %pstate.PEF==0 or %fprs.FEF==0. Signed-off-by: Tsuneo Saito tsnsa...@gmail.com --- target-sparc/translate.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-sparc/translate.c

Re: [Qemu-devel] Fwd: [PATCH] Introduce info migrate-times monitor command

2011-07-12 Thread Markus Armbruster
Michal Novotny minov...@redhat.com writes: This accidentally didn't go to the list although it's been sent there (using git send-email)... Please resend cleanly, so that git-am commits with a reasonable commit message, not some crap like this: commit 1f5de40943d4ce9c18d7f9d8b0070a755d7babb5

<    1   2