Re: [Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-25 Thread Markus Armbruster
Alexandre Raymond writes: > At the moment, "make distclean" relies on the TARGET_DIRS variable, set by > configure. The problem is that this variable does not always contain all > possible targets. > > For example, the following will leave build data in the tree: > > ./configure && make && ./conf

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Hannes Reinecke
On 07/26/2011 08:38 AM, Markus Armbruster wrote: Hannes Reinecke writes: On 07/25/2011 05:59 PM, Markus Armbruster wrote: Hannes Reinecke writes: Instead of using its own definitions scsi-disk should be using the device type of the parent device. Signed-off-by: Hannes Reinecke --- hw/

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > On 07/25/2011 05:59 PM, Markus Armbruster wrote: >> Hannes Reinecke writes: >> >>> Instead of using its own definitions scsi-disk should >>> be using the device type of the parent device. >>> >>> Signed-off-by: Hannes Reinecke >>> --- >>> hw/scsi-defs.h |6 +-

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Hannes Reinecke
On 07/25/2011 05:59 PM, Markus Armbruster wrote: Hannes Reinecke writes: Instead of using its own definitions scsi-disk should be using the device type of the parent device. Signed-off-by: Hannes Reinecke --- hw/scsi-defs.h |6 +- hw/scsi-disk.c | 48 -

Re: [Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-25 Thread Hannes Reinecke
On 07/25/2011 06:04 PM, Markus Armbruster wrote: Hannes Reinecke writes: Markus Armbruster pointed out that not every SCSI command is supported for a given device type. Based on his patch and suggestiongs this series cleans up the SCSI device type and adds a check for supported commands. I l

Re: [Qemu-devel] idea: non-ethernet paravirtual network device

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 4:53 PM, Sassan Panahinejad wrote: > Here's a thought, could we improve network performance by creating a > paravirtual network device which doesn't emulate ethernet? It shouldn't be > too hard to just whack IP packets pretty much directly over a virtio link. > This should

Re: [Qemu-devel] [PATCH] CODING_STYLE: explicitly allow braceless 'else if'

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 6:00 PM, Blue Swirl wrote: > On Mon, Jul 25, 2011 at 6:55 PM, Avi Kivity wrote: >> It's already allowed by the example; there are about 1800 instances in the >> tree; and disallowing it would lead to >> >>    if (a) { >>        ... >>    } else { >>        if (b) { >>    

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command "block_set" for dynamic block params change

2011-07-25 Thread Supriya Kannery
On 07/25/2011 07:04 PM, Kevin Wolf wrote: Am 25.07.2011 14:50, schrieb Stefan Hajnoczi: On Mon, Jul 25, 2011 at 1:52 PM, Supriya Kannery wrote: On 07/25/2011 12:00 PM, Stefan Hajnoczi wrote: On Wed, Jul 13, 2011 at 06:37:05PM +0530, Supriya Kannery wrote: +if (bdrv_is_inserted(bs)) { +

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes

2011-07-25 Thread Amit Shah
On (Mon) 25 Jul 2011 [17:33:12], Markus Armbruster wrote: > Amit Shah writes: > > > On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: > >> This patch series looks bigger than it is. All the patches are small > >> and hopefully easy to review. > >> > >> Objectives: > >> > >> * Push Bloc

Re: [Qemu-devel] qemu crashes on Mac OS X

2011-07-25 Thread Alexandre Raymond
Hi Damjan, I've been able to reproduce the crash you're describing. Could you try the following patch, to see if it solves it? Alexandre On Tue, Jul 5, 2011 at 3:03 PM, Alexandre Raymond wrote: > Hi again Damjan, > > On Mon, Jul 4, 2011 at 6:35 PM, Damjan Marion wrote: >> >> On Jul 4, 2011, a

[Qemu-devel] buildbot failure in qemu on xen_x86_64_debian_5_0

2011-07-25 Thread qemu
The Buildbot has detected a new failure on builder xen_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_x86_64_debian_5_0/builds/45 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on xen_i386_debian_5_0

2011-07-25 Thread qemu
The Buildbot has detected a new failure on builder xen_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/xen_i386_debian_5_0/builds/45 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Reason:

[Qemu-devel] [PATCH 2/2] Makefile: delete config.log in distclean

2011-07-25 Thread Alexandre Raymond
Distclean should remove anything created by the configure script. Signed-off-by: Alexandre Raymond --- Makefile |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index 878402e..9f65d86 100644 --- a/Makefile +++ b/Makefile @@ -224,6 +224,7 @@ distclean:

[Qemu-devel] [PATCH 1/2] Makefile: distclean should clean all possible targets

2011-07-25 Thread Alexandre Raymond
At the moment, "make distclean" relies on the TARGET_DIRS variable, set by configure. The problem is that this variable does not always contain all possible targets. For example, the following will leave build data in the tree: ./configure && make && ./configure --target-list=i386-softmmu \ && ma

[Qemu-devel] [PATCH 0/2] Minor makefile fixes

2011-07-25 Thread Alexandre Raymond
Two simple patches for "make distclean" Alexandre Raymond (2): Makefile: distclean should clean all possible targets Makefile: delete config.log in distclean Makefile |3 ++- configure |1 + 2 files changed, 3 insertions(+), 1 deletions(-) -- 1.7.5

Re: [Qemu-devel] [PATCH] Bugfixes for interrupt numbering in XICS code

2011-07-25 Thread David Gibson
On Tue, Jul 26, 2011 at 10:19:36AM +1000, David Gibson wrote: > The implementation of the XICS interrupt controller contains several > (difficult to trigger) bugs due to the fact that we were not 100% > consistent with which irq numbering we used. In most places, global > numbers were used as hand

Re: [Qemu-devel] [PATCH] console: Don't expose the the ui module's functions when the module is not available.

2011-07-25 Thread TeLeMan
On Tue, Jul 26, 2011 at 10:32, Anthony Liguori wrote: > On 07/25/2011 09:24 PM, TeLeMan wrote: >> >> If there is no sdl support, the implement of sdl_display_init() is missing >> and its declaration should not be exposed. >> vnc, cocoa, curses and other ui modules are the same as sdl. >> >> Signed

Re: [Qemu-devel] [PATCH] console: Don't expose the the ui module's functions when the module is not available.

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:24 PM, TeLeMan wrote: If there is no sdl support, the implement of sdl_display_init() is missing and its declaration should not be exposed. vnc, cocoa, curses and other ui modules are the same as sdl. Signed-off-by: TeLeMan Nack. There's no harm in exposing these and it avoi

[Qemu-devel] [PATCH] console: Don't expose the the ui module's functions when the module is not available.

2011-07-25 Thread TeLeMan
If there is no sdl support, the implement of sdl_display_init() is missing and its declaration should not be exposed. vnc, cocoa, curses and other ui modules are the same as sdl. Signed-off-by: TeLeMan --- console.h |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] buildbot failure in qemu on block_i386_debian_5_0

2011-07-25 Thread qemu
The Buildbot has detected a new failure on builder block_i386_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_i386_debian_5_0/builds/45 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build Rea

[Qemu-devel] buildbot failure in qemu on block_x86_64_debian_5_0

2011-07-25 Thread qemu
The Buildbot has detected a new failure on builder block_x86_64_debian_5_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_x86_64_debian_5_0/builds/45 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Build

Re: [Qemu-devel] Boot order problem

2011-07-25 Thread Minoru Usui
On Mon, 25 Jul 2011 12:06:19 +0300 Gleb Natapov wrote: > On Mon, Jul 25, 2011 at 04:07:12PM +0900, Minoru Usui wrote: > > Hi, Gleb > > > > Thank you for your reply. > > > > On Sun, 24 Jul 2011 09:30:49 +0300 > > Gleb Natapov wrote: > > > > > On Fri, Jul 22, 2011 at 09:51:16AM +0900, Minoru Us

Re: [Qemu-devel] Boot order problem

2011-07-25 Thread Minoru Usui
On Mon, 25 Jul 2011 12:09:31 +0300 Gleb Natapov wrote: > On Mon, Jul 25, 2011 at 04:44:58PM +0900, Minoru Usui wrote: > > On Sun, 24 Jul 2011 09:30:49 +0300 > > Gleb Natapov wrote: > > > [skip] > > > I tested another one about case on RHEL6.1, and I also faced > > another problem. > > > > V

[Qemu-devel] [PATCH] Bugfixes for interrupt numbering in XICS code

2011-07-25 Thread David Gibson
The implementation of the XICS interrupt controller contains several (difficult to trigger) bugs due to the fact that we were not 100% consistent with which irq numbering we used. In most places, global numbers were used as handled by the presentation layer, however a few functions took "local" nu

[Qemu-devel] [PATCH 1/7] sd: do not add one sector to the disk size

2011-07-25 Thread Vincent Palatin
This leads to random off-by-one error. When the size of the SD is exactly 1GB, the emulation was returning a wrong SDHC CSD descriptor. Signed-off-by: Vincent Palatin --- hw/sd.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index cedfb20..f48d589

[Qemu-devel] [PATCH 5/7] sd: add PCI ids for SDHCI controller

2011-07-25 Thread Vincent Palatin
Signed-off-by: Vincent Palatin --- hw/pci.h |1 + hw/pci_ids.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/pci.h b/hw/pci.h index c220745..e0bfbfb 100644 --- a/hw/pci.h +++ b/hw/pci.h @@ -51,6 +51,7 @@ /* QEMU/Bochs VGA (0x1234) */ #define PCI_VENDOR_ID_Q

[Qemu-devel] [PATCH 4/7] sd: add eMMC support

2011-07-25 Thread Vincent Palatin
The parameters mimick a real 4GB eMMC, but it can be set to various sizes. Signed-off-by: Vincent Palatin --- hw/sd.c | 155 +++ 1 files changed, 136 insertions(+), 19 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index de477fe..0db8d78

[Qemu-devel] [PATCH 2/7] sd: fix card size checking on R/W accesses

2011-07-25 Thread Vincent Palatin
We need to check that we are not crossing the boundaries of the card for the current access not for the next one which might not happen. Signed-off-by: Vincent Palatin --- hw/sd.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/sd.c b/hw/sd.c in

[Qemu-devel] [PATCH 6/7] sd: add SD Host Controller (SDHCI) emulation

2011-07-25 Thread Vincent Palatin
Try to be compliant with "SD Specifications Part A2 SD Host Controller Simplified Specification Version 3.00", but not every feature is implemented. Signed-off-by: Vincent Palatin --- hw/sdhci.c | 670 1 files changed, 670 insertions(

[Qemu-devel] Votre annonce.

2011-07-25 Thread annoncezvous
Salut, Votre annonce sur: http://www.annoncez-vous.biz Merci.

Re: [Qemu-devel] KVM call agenda for July 26

2011-07-25 Thread Anthony Liguori
On 07/25/2011 06:30 PM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. 1) Live migration; see http://wiki.qemu.org/Features/Migration/Next or ML thread 2) QEMU Object Model 3) 1.0 planning Regards, Anthony Liguori Later, Juan. -- To unsubscri

[Qemu-devel] KVM call agenda for July 26

2011-07-25 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Later, Juan.

[Qemu-devel] [PATCH 7/7] sd: compile SDHCI on PCI platforms

2011-07-25 Thread Vincent Palatin
Signed-off-by: Vincent Palatin --- Makefile.objs |4 +++- default-configs/pci.mak |1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index cea15e4..5676de7 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -244,6 +244,9 @@ hw-obj-$

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-25 Thread Anthony Liguori
On 07/25/2011 04:10 PM, Paolo Bonzini wrote: On Thu, Jun 30, 2011 at 17:46, Paolo Bonzini wrote: With the current migration format, VMS_STRUCTs with subsections are ambiguous. The protocol cannot tell whether a 0x5 byte after the VMS_STRUCT is a subsection or part of the parent data stream. In

[Qemu-devel] [PATCH 3/7] block: add eMMC block device type

2011-07-25 Thread Vincent Palatin
Signed-off-by: Vincent Palatin --- blockdev.c |2 ++ blockdev.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7d579d6..c836311 100644 --- a/blockdev.c +++ b/blockdev.c @@ -29,6 +29,7 @@ static const char *const if_name[IF_COUNT] = {

[Qemu-devel] sd: add SDHCI and eMMC support

2011-07-25 Thread Vincent Palatin
Dear Qemu developers, This patchset adds the support for eMMC as found soldered on many embedded board in addition to current support for SD/SDHC cards. It also adds a standard SDHCI controller emulation. The first patches are a couple of fixes to the current SD code found while implementing these

Re: [Qemu-devel] [RFC] ppc: qdev-ify CPU creation

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 23:17, Andreas Färber wrote: > Am 25.07.2011 um 12:09 schrieb Alexander Graf: > >> On 24.07.2011, at 21:08, Hervé Poussineau wrote: > > +CPUPPCState *cpu_ppc_init(const char *cpu_model) > +{ > +CPUPPCState *env; > + > +env = qemu_mallocz(sizeof(CPUP

[Qemu-devel] [PATCH 2/2] pc: Support system flash memory with pflash

2011-07-25 Thread Jordan Justen
If a pflash image is found, then it is used for the system firmware image. If a pflash image is not initially found, then a read-only pflash device is created using the -bios filename. Signed-off-by: Jordan Justen Cc: Anthony Liguori Cc: Aurelien Jarno --- Makefile.target|

[Qemu-devel] [PATCH 1/2] pflash: Support read-only mode

2011-07-25 Thread Jordan Justen
Read-only mode is indicated by bdrv_is_read_only When read-only mode is enabled, no changes will be made to the flash image in memory, and no bdrv_write calls will be made. Signed-off-by: Jordan Justen Cc: Jan Kiszka Cc: Aurelien Jarno Cc: Anthony Liguori --- blockdev.c|3 +- hw/

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Eric Northup
On Wed, Jul 20, 2011 at 9:50 AM, Avi Kivity wrote: [...] > @@ -130,7 +137,13 @@ static void pc_init1(MemoryRegion *system_memory, > >     if (pci_enabled) { >         pci_bus = i440fx_init(&i440fx_state, &piix3_devfn, isa_irq, > -                              system_memory, system_io, ram_size); >

Re: [Qemu-devel] [RFC] ppc: qdev-ify CPU creation

2011-07-25 Thread Andreas Färber
Am 25.07.2011 um 12:09 schrieb Alexander Graf: On 24.07.2011, at 21:08, Hervé Poussineau wrote: Alexander Graf a écrit : On 21.12.2010, at 21:01, Andreas Färber wrote: From: Hervé Poussineau v1: * Coding style fixes. Signed-off-by: Hervé Poussineau Cc: Alexander Graf Signed-off-by: And

Re: [Qemu-devel] [RFC PATCH 0/4] Fix subsection ambiguity in the migration format

2011-07-25 Thread Paolo Bonzini
On Thu, Jun 30, 2011 at 17:46, Paolo Bonzini wrote: > With the current migration format, VMS_STRUCTs with subsections > are ambiguous.  The protocol cannot tell whether a 0x5 byte after > the VMS_STRUCT is a subsection or part of the parent data stream. > In the past QEMU assumed it was always a p

Re: [Qemu-devel] [PATCH 21/28] PPC: E500: Add PV spinning code

2011-07-25 Thread Scott Wood
On Sat, 23 Jul 2011 12:50:05 +0200 Alexander Graf wrote: > +typedef struct spin_info { > +uint64_t addr; > +uint64_t r3; > +uint32_t resv; > +uint32_t pir; > +uint64_t r6; > +} __attribute__ ((packed)) SpinInfo; Note that r6 isn't part of the ePAPR spin table -- I think it ma

Re: [Qemu-devel] [PATCH v7 2/4] coroutine: implement coroutines using gthread

2011-07-25 Thread Anthony Liguori
On 07/25/2011 03:04 PM, Stefan Hajnoczi wrote: From: "Aneesh Kumar K.V" On platforms that don't support makecontext(3) use gthread based coroutine implementation. Darwin has makecontext(3) but getcontext(3) is stubbed out to return ENOTSUP. Andreas Färber debugged this and contributed the ./c

Re: [Qemu-devel] [PATCH 00/23] Memory API, batch 1

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: This patchset contains the core of the memory API, with one device (usb-ohci) coverted for reference. The API is currently implemented on top of the old ram_addr_t/cpu_register_physical_memory() API, but the plan is to make it standalone later. The goal

Re: [Qemu-devel] [PATCH 23/23] usb-ohci: convert to MemoryRegion

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:03 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/usb-ohci.c | 42 +- 1 files changed, 17 insertions(+), 25 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c i

Re: [Qemu-devel] [PATCH 22/23] sysbus: add MemoryRegion based memory management API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:03 AM, Avi Kivity wrote: Allow registering sysbus device memory using a MemoryRegion. Once all users are converted, sysbus_init_mmio() and sysbus_init_mmio_cb() will be removed. Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/sysb

Re: [Qemu-devel] [PATCH 21/23] pci: add MemoryRegion based BAR management API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:03 AM, Avi Kivity wrote: Allow registering a BAR using a MemoryRegion. Once all users are converted, pci_register_bar() and pci_register_bar_simple() will be removed. Signed-off-by: Avi Kivity diff --git a/hw/pci.h b/hw/pci.h index cfeb042..c51156d 100644 --- a/hw/pci.h +++

[Qemu-devel] [PATCH v7 1/4] coroutine: introduce coroutines

2011-07-25 Thread Stefan Hajnoczi
From: Kevin Wolf Asynchronous code is becoming very complex. At the same time synchronous code is growing because it is convenient to write. Sometimes duplicate code paths are even added, one synchronous and the other asynchronous. This patch introduces coroutines which allow code that looks sy

[Qemu-devel] [PATCH v7 4/4] coroutine: add test-coroutine --benchmark-lifecycle

2011-07-25 Thread Stefan Hajnoczi
Add a microbenchmark for coroutine create, enter, and return (aka lifecycle). This is a useful benchmark because users are expected to create many coroutines, one per I/O request for example, and we therefore need to provide good performance in that scenario. To run: make test-coroutine ./te

[Qemu-devel] [PATCH v7 3/4] coroutine: add test-coroutine automated tests

2011-07-25 Thread Stefan Hajnoczi
To run automated tests for coroutines: make test-coroutine ./test-coroutine On success the program terminates with exit status 0. On failure an error message is written to stderr and the program exits with exit status 1. Signed-off-by: Stefan Hajnoczi --- .gitignore |1 + Makefi

[Qemu-devel] [PATCH v7 0/4] Coroutines for better asynchronous programming

2011-07-25 Thread Stefan Hajnoczi
Here is the latest version of the coroutines series which both virtfs and the block layer are now building on. QEMU is event-driven and suffers when blocking operations are performed because VM execution may be stopped until the operation completes. Therefore many operations that could block are

[Qemu-devel] [PATCH v7 2/4] coroutine: implement coroutines using gthread

2011-07-25 Thread Stefan Hajnoczi
From: "Aneesh Kumar K.V" On platforms that don't support makecontext(3) use gthread based coroutine implementation. Darwin has makecontext(3) but getcontext(3) is stubbed out to return ENOTSUP. Andreas Färber debugged this and contributed the ./configure test which solves the issue for Darwin/

Re: [Qemu-devel] [PATCH 20/23] pci: pass address space to pci bus when created

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:03 AM, Avi Kivity wrote: This is now done sloppily, via get_system_memory(). Eventually callers will be converted to stop using that. Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/apb_pci.c |2 ++ hw/bonito.c|

Re: [Qemu-devel] [PATCH 19/23] pc: move global memory map out of pc_init1() and into its callers

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:03 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity What's the rationale here? Regards, Anthony Liguori --- hw/pc_piix.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index d83854c..f2d0476 100644 --- a/

Re: [Qemu-devel] [PATCH 18/23] pc: convert pc_memory_init() to memory API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- hw/pc.c | 59 --- hw/pc.h |1 + 2 files changed, 41 insertions(+), 19 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH 17/23] pc: grab system_memory

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: While eventually this should come from the machine initialization function, take a short cut to avoid converting all machines now. Signed-off-by: Avi Kivity I think it should happen in the i440fx actually. We should treat RAM as just another device a

Re: [Qemu-devel] [PATCH 16/23] ioport: register ranges by byte aligned addresses always

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: The I/O port space is byte addressable, even for word and long accesses. An example is the VMware svga card, which has long ports on offsets 0, 1, and 2. Signed-off-by: Avi Kivity I've always thought this was odd but didn't know of a specific circums

Re: [Qemu-devel] [PATCH 15/23] exec.c: initialize memory map

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Allocate the root memory region and initialize it. Signed-off-by: Avi Kivity --- exec.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index 2160ded..d51502f 100644 --- a/exec.c +++ b/exec.c

Re: [Qemu-devel] [PATCH 14/23] memory: transaction API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Allow changes to the memory hierarchy to be accumulated and made visible all at once. This reduces computational effort, especially when an accelerator (e.g. kvm) is involved. Useful when a single register update causes multiple changes to an address sp

Re: [Qemu-devel] [PATCH 13/23] memory: document the memory API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity --- docs/memory.txt | 172 +++ 1 files changed, 172 insertions(+), 0 deletions(-) create mode 100644 docs/memory.txt diff --git a/docs/memory.txt b/docs/memory.txt new fi

Re: [Qemu-devel] [PATCH 12/23] memory: separate building the final memory map into two steps

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Instead of adding and deleting regions in one pass, do a delete pass followed by an add pass. This fixes the following case: from: 0x-0x0fff ram (a1) 0x1000-0x1fff mmio (a2) 0x2000-0x2fff ram (a3) to: 0x-0x2fff ram (b1) The sing

[Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-25 Thread Serge E. Hallyn
VHD files technically can be up to 2Tb, but virtual pc is limited to 127G. Currently qemu-img refused to create vpc files > 127G, but it is failing to return error when converting from a non-vpc VHD file which is >127G. It returns success, but creates a truncated converted image. Also, qemu-img

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: As with the rest of the memory API, the caller associates an eventfd with an address, and the memory API takes care of registering or unregistering when the address is made visible or invisible to the guest. Signed-off-by: Avi Kivity --- memory.c | 23

Re: [Qemu-devel] [PATCH 10/23] memory: add backward compatibility for old mmio registration

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: This eases the transition to the new API. Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- memory.c | 10 ++ memory.h | 10 ++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 09/23] memory: add backward compatibility for old portio registration

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- memory.c | 32 memory.h | 17 + 2 files changed, 49 insertions(+), 0 deletions(-) diff --git a/memory.c b/

Re: [Qemu-devel] [PATCH 08/23] memory: I/O address space support

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Allow registering I/O ports via the same mechanism as mmio ranges. Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Regards, Anthony Liguori --- exec-memory.h |3 ++ memory.c | 60 +++

Re: [Qemu-devel] [PATCH 06/23] memory: rename MemoryRegion::has_ram_addr to ::terminates

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: I/O regions will not have ram_addrs, so this is a better name. Signed-off-by: Avi Kivity Reviewed-by: Anthony Liguori Although it seems squashable. Regards, Anthony Liguori --- memory.c | 18 +- memory.h |2 +- 2 files c

Re: [Qemu-devel] [PATCH 05/23] memory: abstract address space operations

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Prepare for multiple address space support by abstracting away the details of registering a memory range with qemu's flat representation into an AddressSpace object. Note operations which are memory specific are not abstracted, since they will never be c

Re: [Qemu-devel] [PATCH 04/23] Internal interfaces for memory API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: get_system_memory() provides the root of the memory hierarchy. This interface is intended to be private between memory.c and exec.c. If this file is included elsewhere, it should be regarded as a bug (or TODO item). However, it will be temporarily neede

Re: [Qemu-devel] [PATCH 03/23] memory: merge adjacent segments of a single memory region

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Simple implementations of memory routers, for example the Cirrus VGA memory banks or the 440FX PAM registers can generate adjacent memory regions which are contiguous. Detect these and merge them; this saves kvm memory slots and shortens lookup times.

Re: [Qemu-devel] [PATCH 02/23] memory: implement dirty tracking

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: Currently dirty tracking is implemented by passing through all calls to the underlying cpu_physical_memory_*() calls. Signed-off-by: Avi Kivity Ah, I see, you're fixing FIXMEs in updated patches before anything uses it. Reviewed-by: Anthony Liguori

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-07-25 Thread Serge Hallyn
** Changed in: qemu-kvm (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/814222 Title: kvm cannot use vhd files over 127GB Status in QEMU: New Status in

Re: [Qemu-devel] [PATCH 01/23] Hierarchical memory region API

2011-07-25 Thread Anthony Liguori
On 07/25/2011 09:02 AM, Avi Kivity wrote: The memory API separates the attributes of a memory region (its size, how reads or writes are handled, dirty logging, and coalescing) from where it is mapped and whether it is enabled. This allows a device to configure a memory region once, then hand it

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-07-25 Thread Serge Hallyn
** Patch added: "proposed fix for upstream qemu" https://bugs.launchpad.net/qemu/+bug/814222/+attachment/2231766/+files/0001-block-vpc.c-Detect-too-large-vpc-file.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

[Qemu-devel] [PATCH] fix disabling interrupts in sun4u

2011-07-25 Thread Artyom Tarasenko
clear interrupt request if the interrupt priority < CPU pil clear hardware interrupt request if interrupts are disabled Signed-off-by: Artyom Tarasenko --- hw/sun4u.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index d7dcaf0..7f95aeb 1006

Re: [Qemu-devel] [PATCH 10/55] ide: Update command code definitions as per ACS-2 Table B.2

2011-07-25 Thread Markus Armbruster
Christoph Hellwig writes: > On Wed, Jul 20, 2011 at 06:23:44PM +0200, Markus Armbruster wrote: >> Drop WIN_SRST, it has same value as WIN_DEVICE_RESET. >> >> CFA_IDLEIMMEDIATE isn't specific to CFATA. ACS-2 shows it as a >> defined command in ATA-1, -2 and -3. Rename to WIN_IDLEIMMEDIATE2. >>

Re: [Qemu-devel] Need to find OS running in VMs

2011-07-25 Thread Mulyadi Santosa
On Mon, Jul 25, 2011 at 21:52, bharath pb wrote: > Hi, > >   how to find which OS running in my VMs..? just check the SDL graphic output? its console or window? -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogspot.com training: mulyaditraining.blogspot.

Re: [Qemu-devel] [PATCH] CODING_STYLE: explicitly allow braceless 'else if'

2011-07-25 Thread Blue Swirl
On Mon, Jul 25, 2011 at 6:55 PM, Avi Kivity wrote: > It's already allowed by the example; there are about 1800 instances in the > tree; and disallowing it would lead to > >    if (a) { >        ... >    } else { >        if (b) { >            ... >        } else { >            if (c) { >          

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-07-25 Thread Serge Hallyn
@Matthew thanks for the attachments. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/814222 Title: kvm cannot use vhd files over 127GB Status in QEMU: New Status in “qemu-kvm” package in Ubuntu:

Re: [Qemu-devel] [PATCH v2 1/2] qapi: check for python, allow path to be specified

2011-07-25 Thread Blue Swirl
On Mon, Jul 25, 2011 at 5:55 PM, Michael Roth wrote: > On 07/25/2011 09:36 AM, Blue Swirl wrote: >> >> On Sun, Jul 24, 2011 at 9:36 PM, Michael Roth >>  wrote: >>> >>> QAPI requires python to generate code. Check for python during >>> configuration and allow python to be specified manually. >> >>

[Qemu-devel] [Bug 814222] Re: kvm cannot use vhd files over 127GB

2011-07-25 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New ** Changed in: qemu-kvm (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/814222 Title: kvm c

Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 18:21, Richard W.M. Jones wrote: > On Mon, Jul 25, 2011 at 06:11:20PM +0200, Jan Kiszka wrote: >> I was incorrectly pointing the core, the problem is solvable at the >> level where we parse -machine: >> >> ---8< >> >> This allows to specify -machine options without

Re: [Qemu-devel] [PATCH] Allow to leave type on default in -machine

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 06:11:20PM +0200, Jan Kiszka wrote: > I was incorrectly pointing the core, the problem is solvable at the > level where we parse -machine: > > ---8< > > This allows to specify -machine options without setting an explicit > machine type. We will pick the default

[Qemu-devel] [PATCH] Allow to leave type on default in -machine

2011-07-25 Thread Jan Kiszka
On 2011-07-25 13:48, Jan Kiszka wrote: > On 2011-07-25 13:39, Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> On 2011-07-25 12:45, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: > On 2011-07-25 11:41, Richard W.M. Jones wrote: >> On Sat, Ju

Re: [Qemu-devel] [PATCH 0/6][v2] Check for supported SCSI commands

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > Markus Armbruster pointed out that not every SCSI command is supported > for a given device type. Based on his patch and suggestiongs this series > cleans up the SCSI device type and adds a check for supported commands. I like this series. It conflicts with mine. I ca

Re: [Qemu-devel] [PATCH 5/6] scsi-disk: Remove 'drive_kind'

2011-07-25 Thread Markus Armbruster
Hannes Reinecke writes: > Instead of using its own definitions scsi-disk should > be using the device type of the parent device. > > Signed-off-by: Hannes Reinecke > --- > hw/scsi-defs.h |6 +- > hw/scsi-disk.c | 48 > 2 files changed,

[Qemu-devel] [PATCH] CODING_STYLE: explicitly allow braceless 'else if'

2011-07-25 Thread Avi Kivity
It's already allowed by the example; there are about 1800 instances in the tree; and disallowing it would lead to if (a) { ... } else { if (b) { ... } else { if (c) { ... } else { if (d) {

Re: [Qemu-devel] [RFC PATCH 0/2] Signal fixes for OSX

2011-07-25 Thread Alexandre Raymond
Please ignore this patch series. It is most definitely wrong. Alexandre On Wed, Jul 20, 2011 at 1:01 AM, Alexandre Raymond wrote: > This series fixes a race condition that occurs under OS X. > > It also reworks the signal initialization to make it simpler for later > maintenance/additions. > > N

[Qemu-devel] idea: non-ethernet paravirtual network device

2011-07-25 Thread Sassan Panahinejad
Hi all, Here's a thought, could we improve network performance by creating a paravirtual network device which doesn't emulate ethernet? It shouldn't be too hard to just whack IP packets pretty much directly over a virtio link. This should improve performance when using a "user" host connection and

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

2011-07-25 Thread Alexandre Raymond
Hi guys, Thank you for investigating this problem. I finally found out why this problem occured in the first place. It is a combination of the bug you just described and the fact that "make distclean" only deletes the build directories of the targets specified *in the last call to configure*. e.

Re: [Qemu-devel] [PATCH 0/7] balloon: cleanups, fix segfault

2011-07-25 Thread Amit Shah
On (Mon) 25 Jul 2011 [16:13:33], Markus Armbruster wrote: > Amit Shah writes: > > > 'balloon 0' in the monitor causes a segfault. This happens because > > the function that handles change in balloon values is also tasked with > > handling stats retrieval from the guest, and it does the retrieval

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:38 PM, malc wrote: On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > >+} > > > > >+if (a.fd > > > >+return true; > > > > >+} else { > > if (a.fd>b.

Re: [Qemu-devel] qemu 0.12 monitor command syntax and interface

2011-07-25 Thread Markus Armbruster
Vinay Venkataraghavan writes: > Hi all, > > I am implementing a generic interface that supports qemu versions 0.9 to > 0.12. > > > As a result I have been trying to get the syntax for the monitor commands for > various qemu versions. I have scrounged all over but have not been able to > find

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Avi Kivity wrote: > On 07/25/2011 06:22 PM, malc wrote: > > > > > +} > > > > > +if (a.fd< b.fd) { > > > > > +return true; > > > > > +} else { > > if (a.fd> b.fd) { > > > > > +return false; > > > > >

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:28 PM, Jes Sorensen wrote: > > I guess type safety doesn't matter to you. In my experience it's one of the lesser problems in the code. It's a big issue to someone making widespread changes in the code (like me now). -- error compiling committee.c: too many arguments to f

Re: [Qemu-devel] [PATCH 00/55] Block layer cleanup & fixes

2011-07-25 Thread Markus Armbruster
Amit Shah writes: > On (Wed) 20 Jul 2011 [18:23:34], Markus Armbruster wrote: >> This patch series looks bigger than it is. All the patches are small >> and hopefully easy to review. >> >> Objectives: >> >> * Push BlockDriverState members locked, tray_open, media_changed into >> device model

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Jes Sorensen
On 07/25/11 17:24, Avi Kivity wrote: > On 07/25/2011 06:21 PM, Jes Sorensen wrote: >> On 07/25/11 17:20, Avi Kivity wrote: >> > On 07/25/2011 06:17 PM, Jes Sorensen wrote: >> >> Using the commands consistently does have an impact, and at least >> with >> >> qemu_malloc() it is obvious what they

Re: [Qemu-devel] [PATCH 11/23] memory: add ioeventfd support

2011-07-25 Thread Avi Kivity
On 07/25/2011 06:22 PM, malc wrote: > > > +} > > > +if (a.fd< b.fd) { > > > +return true; > > > +} else { if (a.fd> b.fd) { > > > +return false; > > > +} } CODING_STYLE permits braceless else if.

[Qemu-devel] [PATCH 23/23] usb-ohci: convert to MemoryRegion

2011-07-25 Thread Avi Kivity
Signed-off-by: Avi Kivity --- hw/usb-ohci.c | 42 +- 1 files changed, 17 insertions(+), 25 deletions(-) diff --git a/hw/usb-ohci.c b/hw/usb-ohci.c index 8491d59..337b250 100644 --- a/hw/usb-ohci.c +++ b/hw/usb-ohci.c @@ -62,7 +62,7 @@ typedef struct OHCI

  1   2   3   >