Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command block_set for dynamic block params change

2011-07-25 Thread Stefan Hajnoczi
On Wed, Jul 13, 2011 at 06:37:05PM +0530, Supriya Kannery wrote: Index: qemu/block.c === --- qemu.orig/block.c +++ qemu/block.c @@ -651,6 +651,40 @@ unlink_and_fail: return ret; } +int bdrv_reopen(BlockDriverState *bs,

Re: [Qemu-devel] [PATCH v1 1/1] Submit the codes for QEMU disk I/O limits.

2011-07-25 Thread Zhi Yong Wu
On Mon, Jul 25, 2011 at 1:40 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jul 25, 2011 at 5:25 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Fri, Jul 22, 2011 at 6:54 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Jul 22, 2011 at 10:20 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v1 1/1] Submit the codes for QEMU disk I/O limits.

2011-07-25 Thread Zhi Yong Wu
On Fri, Jul 22, 2011 at 6:54 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Jul 22, 2011 at 10:20 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: +static void bdrv_block_timer(void *opaque) +{ +    BlockDriverState *bs = opaque; +    BlockQueue *queue = bs-block_queue; +    uint64_t

Re: [Qemu-devel] SeaBIOS image is lacking CONFIG_AHCI

2011-07-25 Thread Jan Kiszka
On 2011-05-09 08:03, Jan Kiszka wrote: Hi Anthony, please rebuild SeaBIOS after enabling AHCI. QEMU's current version is still not able to boot from such controllers. This unfortunately still applies to 0.15-rc0. Please fix. Jan signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] Boot order problem

2011-07-25 Thread Minoru Usui
On Sun, 24 Jul 2011 09:30:49 +0300 Gleb Natapov g...@redhat.com wrote: On Fri, Jul 22, 2011 at 09:51:16AM +0900, Minoru Usui wrote: Hi, everyone I'm in trouble about boot order of VM. If anyone know cause of this problem, please let me know. The cause of the problem is the design.

Re: [Qemu-devel] [RFC PATCH 0/5] qcow: coroutines cleanup

2011-07-25 Thread Kevin Wolf
Am 22.07.2011 22:09, schrieb Frediano Ziglio: Il giorno ven, 22/07/2011 alle 12.10 +0200, Kevin Wolf ha scritto: Am 22.07.2011 11:26, schrieb Frediano Ziglio: 2011/7/22 Kevin Wolf kw...@redhat.com: Am 20.07.2011 15:56, schrieb Frediano Ziglio: These patches mostly cleanup some AIO code using

[Qemu-devel] [PATCH] qemu-char: fix the commit qemu-char: Print strerror message on failure

2011-07-25 Thread TeLeMan
The commit 6e1db57b2ac9025c2443c665a0d9e78748637b26 missed patching qemu_chr_open_win_file(). Signed-off-by: TeLeMan gele...@gmail.com --- qemu-char.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index dcf7065..ea7abfe 100644 ---

Re: [Qemu-devel] [V11 00/15] virtio-9p: Use chroot to safely access files in passthrough security model

2011-07-25 Thread Stefan Hajnoczi
On Fri, Jun 24, 2011 at 01:52:09PM +0530, M. Mohan Kumar wrote: In passthrough security model, following symbolic links in the server side could result in TOCTTOU vulnerabilities. (http://en.wikipedia.org/wiki/Time-of-check-to-time-of-use) This patchset resolves this issue by creating a

Re: [Qemu-devel] [PATCH 1/3] Fix chrdev return value conversion

2011-07-25 Thread Kevin Wolf
Am 23.07.2011 23:24, schrieb Blue Swirl: 6e1db57b2ac9025c2443c665a0d9e78748637b26 didn't convert brlapi or win32 chrdevs, breaking build for those. Fix by converting the chrdevs. Signed-off-by: Blue Swirl blauwir...@gmail.com Sorry, I should have run a mingw build after touching this

Re: [Qemu-devel] [PATCH] qemu-char: fix the commit qemu-char: Print strerror message on failure

2011-07-25 Thread TeLeMan
Oh, Blue Swirl did it, please ignore this. -- SUN OF A BEACH On Mon, Jul 25, 2011 at 16:16, TeLeMan gele...@gmail.com wrote: The commit 6e1db57b2ac9025c2443c665a0d9e78748637b26 missed patching qemu_chr_open_win_file(). Signed-off-by: TeLeMan gele...@gmail.com ---  qemu-char.c |    8

[Qemu-devel] [PATCH] monitor: fix build breakage with --disable-vnc

2011-07-25 Thread TeLeMan
The breakage was introduced by the commit 13661089810d3e59931f3e80d7cb541b99af7071 Signed-off-by: TeLeMan gele...@gmail.com --- monitor.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index 92cdd05..52ae5f2 100644 --- a/monitor.c +++ b/monitor.c

Re: [Qemu-devel] [PATCH] user: Restore debug usage message for '-d ?' in user mode emulation

2011-07-25 Thread Peter Maydell
Ping? Since this is a regression in our command line handling I think it should also go into 0.15... thanks -- PMM On 18 July 2011 11:44, Peter Maydell peter.mayd...@linaro.org wrote: The code which prints the debug usage message on '-d ?' for *-user has to come before the check for not

Re: [Qemu-devel] [PATCH 05/28] PPC: Set MPIC IDE for IPI to 0

2011-07-25 Thread Elie Richa
On 07/23/2011 12:49 PM, Alexander Graf wrote: @@ -1304,6 +1304,10 @@ static void mpic_reset (void *opaque) mpp-src[i].ipvp = 0x8080; mpp-src[i].ide = 0x0001; } +/* Set IDE for IPIs to 0 so we don't get spurious interrupts */ +for (i = mpp-irq_ipi0; i

Re: [Qemu-devel] [PATCH 05/28] PPC: Set MPIC IDE for IPI to 0

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 10:46, Elie Richa wrote: On 07/23/2011 12:49 PM, Alexander Graf wrote: @@ -1304,6 +1304,10 @@ static void mpic_reset (void *opaque) mpp-src[i].ipvp = 0x8080; mpp-src[i].ide = 0x0001; } +/* Set IDE for IPIs to 0 so we don't get

[Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Signed-off-by: Avi Kivity a...@redhat.com --- This is part of my memory API patchset, but doesn't really belong there. qemu-common.h |3 +++ 1 files changed, 3

Re: [Qemu-devel] coroutines and block I/O considerations

2011-07-25 Thread Paolo Bonzini
On 07/19/2011 12:57 PM, Stefan Hajnoczi wrote: From what I understand committed on Windows means that physical pages have been allocated and pagefile space has been set aside: http://msdn.microsoft.com/en-us/library/ms810627.aspx Yes, memory that is reserved on Windows is just a contiguous

Re: [Qemu-devel] [PATCH] fix network interface tap backend

2011-07-25 Thread Christoph Egger
On 07/23/11 18:17, Anthony Liguori wrote: On 06/17/2011 03:56 AM, Christoph Egger wrote: Fix network interface tap backend work on NetBSD. It uses an ioctl to get the tap name. From Manuel Bouyerbou...@netbsd.org Signed-off-by: Christoph Eggerchristoph.eg...@amd.com diff --git

Re: [Qemu-devel] [PATCH] use mmap to allocate execute memory

2011-07-25 Thread Christoph Egger
On 07/23/11 18:17, Anthony Liguori wrote: On 06/17/2011 05:11 AM, Christoph Egger wrote: Use mmap to allocate executable memory on NetBSD as well. From: Tobias Nygrent...@netbsd.org Signed-off-by: Christoph Eggerchristoph.eg...@amd.com diff --git a/exec.c b/exec.c index 09928a3..1954a1c

Re: [Qemu-devel] Boot order problem

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 04:07:12PM +0900, Minoru Usui wrote: Hi, Gleb Thank you for your reply. On Sun, 24 Jul 2011 09:30:49 +0300 Gleb Natapov g...@redhat.com wrote: On Fri, Jul 22, 2011 at 09:51:16AM +0900, Minoru Usui wrote: Hi, everyone I'm in trouble about boot order of

Re: [Qemu-devel] Boot order problem

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 04:44:58PM +0900, Minoru Usui wrote: On Sun, 24 Jul 2011 09:30:49 +0300 Gleb Natapov g...@redhat.com wrote: [skip] I tested another one about boot order case on RHEL6.1, and I also faced another problem. VM has two virtio HDD. HDD1 is installed RHEL6.1, HDD2 is

Re: [Qemu-devel] [PATCH] report serial devices created with -device in the PIIX4 config space

2011-07-25 Thread Paolo Bonzini
+static void piix4_pm_machine_ready(struct Notifier* n) +{ + PIIX4PMState *s = container_of(n, PIIX4PMState, machine_ready); DO_UPCAST()? I assume we have it for a reason. NIH is the reason we have it. DO_UPCAST checks that the offset of the field is zero: #ifdef __GNUC__ #define

[Qemu-devel] ci-joint votre offre pour

2011-07-25 Thread offreprodecoeplus
La pose de panneaux photovoltaïques vous permet de devenir producteur d’énergie pour votre consommation personnelle et de revendre votre sur plus d’électricité à EDF* pendant 20 ans vous possédez une maison, un entrepôt, un hangar, un bâtiment industriel avec une toiture en pente. Aucune

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. What does this buy you over type *x = qemu_malloc(sizeof(type)); ? I find the non-C++ version easier to read even.

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Sasha Levin
On Mon, 2011-07-25 at 11:32 +0200, Alexander Graf wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. What does this buy you over type *x =

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com -machine somehow suggests that it selects the machine, but it doesn't. Fix that before this command is set in stone. Actually, -machine should supersede -M and allow to introduce arbitrary

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 11:37, Sasha Levin wrote: On Mon, 2011-07-25 at 11:32 +0200, Alexander Graf wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. What does

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Peter Maydell
On 25 July 2011 10:32, Alexander Graf ag...@suse.de wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer.  Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. What does this buy you over type *x =

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 12:43 PM, Alexander Graf wrote: Hm - is there any way to get this without adding upper case C++'ish macros? Switch to C++. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 12:48 PM, Peter Maydell wrote: On 25 July 2011 10:32, Alexander Grafag...@suse.de wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. What does

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 11:52, Avi Kivity wrote: On 07/25/2011 12:48 PM, Peter Maydell wrote: On 25 July 2011 10:32, Alexander Grafag...@suse.de wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and

Re: [Qemu-devel] coroutines and block I/O considerations

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 9:56 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 07/19/2011 12:57 PM, Stefan Hajnoczi wrote:  From what I understand committed on Windows means that physical pages have been allocated and pagefile space has been set aside:

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used to it in time. The question is, is the new interface better or not. I agree that it keeps you from accidently malloc'ing a struct of pointer size. But couldn't we also just add

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used to it in time. The question is, is the new interface better or not. I agree that it keeps you from accidently malloc'ing a struct

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 9:51 AM, Avi Kivity a...@redhat.com wrote: qemu_malloc() is type-unsafe as it returns a void pointer.  Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Signed-off-by: Avi Kivity a...@redhat.com --- This is part of my memory API patchset, but

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 01:04 PM, Alexander Graf wrote: On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used to it in time. The question is, is the new interface better or not. I agree that

Re: [Qemu-devel] [RFC] ppc: qdev-ify CPU creation

2011-07-25 Thread Alexander Graf
On 24.07.2011, at 21:08, Hervé Poussineau wrote: Alexander Graf a écrit : On 21.12.2010, at 21:01, Andreas Färber wrote: From: Hervé Poussineau hpous...@reactos.org v1: * Coding style fixes. Signed-off-by: Hervé Poussineau hpous...@reactos.org Cc: Alexander Graf ag...@suse.de

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 01:06 PM, Stefan Hajnoczi wrote: char *qemu_strndup(const char *str, size_t size); +#define QEMU_NEW(type) ((type *)(qemu_malloc(sizeof(type +#define QEMU_NEWZ(type) ((type *)(qemu_mallocz(sizeof(type Does this mean we need to duplicate the type name for each

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

2011-07-25 Thread Stefan Hajnoczi
On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymond cerb...@gmail.com wrote: This patch fixes a minor bugs which prevented QEMU from being built out of tree. Signed-off-by: Alexandre Raymond cerb...@gmail.com ---  Makefile |    2 +-  1 files changed, 1 insertions(+), 1 deletions(-) I don't

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vhost build fix for i386

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 11, 2011 at 02:57:43PM +0200, Wolfgang Mauerer wrote: vhost.c uses __sync_fetch_and_and(), which is only available for -march=i486 and above (see https://bugzilla.redhat.com/show_bug.cgi?id=624279). Signed-off-by: Wolfgang Mauerer wolfgang.maue...@siemens.com --- configure |

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 12:09, Avi Kivity wrote: On 07/25/2011 01:04 PM, Alexander Graf wrote: On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used to it in time. The question is,

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sh4: Fix potential crash in debug code

2011-07-25 Thread Stefan Hajnoczi
On Wed, Jul 20, 2011 at 08:56:35PM +0200, Stefan Weil wrote: cppcheck reports this error: qemu/hw/sh_intc.c:390: error: Possible null pointer dereference: s - otherwise it is redundant to check if s is null at line 385 If s were NULL, the printf() statement would crash. Setting braces

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Kevin Wolf
Am 25.07.2011 12:06, schrieb Stefan Hajnoczi: On Mon, Jul 25, 2011 at 9:51 AM, Avi Kivity a...@redhat.com wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Signed-off-by: Avi Kivity a...@redhat.com ---

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] Makefile: Minor cscope fixups

2011-07-25 Thread Stefan Hajnoczi
On Wed, Jul 20, 2011 at 11:12:15PM -0400, Alexandre Raymond wrote: Changes since v1: -Use SRC_PATH instead of PWD -Create cscope symbols for assembly files in addition to .c/.h files. -Create cscope database with full path instead of relative path so cscope can be used with CSCOPE_DB in

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Jan Kiszka
On 2011-07-25 11:41, Richard W.M. Jones wrote: On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com -machine somehow suggests that it selects the machine, but it doesn't. Fix that before this command is set in stone. Actually, -machine should

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 11:25 AM, Kevin Wolf kw...@redhat.com wrote: Am 25.07.2011 12:06, schrieb Stefan Hajnoczi: On Mon, Jul 25, 2011 at 9:51 AM, Avi Kivity a...@redhat.com wrote: qemu_malloc() is type-unsafe as it returns a void pointer.  Introduce QEMU_NEW() (and QEMU_NEWZ()), which return

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: On 2011-07-25 11:41, Richard W.M. Jones wrote: On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com -machine somehow suggests that it selects the machine, but it doesn't. Fix that

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread malc
On Mon, 25 Jul 2011, Alexander Graf wrote: On 25.07.2011, at 12:09, Avi Kivity wrote: On 07/25/2011 01:04 PM, Alexander Graf wrote: On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change.

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Markus Armbruster
Avi Kivity a...@redhat.com writes: On 07/25/2011 01:04 PM, Alexander Graf wrote: On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used to it in time. The question is, is the new

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Jan Kiszka
On 2011-07-25 12:45, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: On 2011-07-25 11:41, Richard W.M. Jones wrote: On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: From: Jan Kiszka jan.kis...@siemens.com -machine somehow suggests that it

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 25.07.2011 12:06, schrieb Stefan Hajnoczi: On Mon, Jul 25, 2011 at 9:51 AM, Avi Kivity a...@redhat.com wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type.

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 12:59, Markus Armbruster wrote: Avi Kivity a...@redhat.com writes: On 07/25/2011 01:04 PM, Alexander Graf wrote: On 25.07.2011, at 12:02, Avi Kivity wrote: On 07/25/2011 12:56 PM, Alexander Graf wrote: That argument can be used to block any change. You'll get used

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-25 Thread Kevin Wolf
Am 25.07.2011 03:44, schrieb Anthony Liguori: Hi, This series is the rough beginnings of the QEMU Object Model. This is basically qdev generalized on steroids. This series includes the core infrastructure, a strawman Device type, and the beginnings of the conversion of CharDriverState.

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: On 2011-07-25 12:45, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: On 2011-07-25 11:41, Richard W.M. Jones wrote: On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan Kiszka wrote: From: Jan Kiszka

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Peter Maydell
On 25 July 2011 11:45, Richard W.M. Jones rjo...@redhat.com wrote: So what you're saying is we have to parse qemu -machine \? output by looking for the string '(default)'?  eg: $ ./arm-softmmu/qemu-system-arm -machine \?|fgrep '(default)' integratorcp ARM Integrator/CP (ARM926EJ-S) (default)

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Jan Kiszka
On 2011-07-25 13:39, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: On 2011-07-25 12:45, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 12:33:01PM +0200, Jan Kiszka wrote: On 2011-07-25 11:41, Richard W.M. Jones wrote: On Sat, Jul 23, 2011 at 12:38:37PM +0200, Jan

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Peter Maydell
On 25 July 2011 12:48, Peter Maydell peter.mayd...@linaro.org wrote: For ARM you absolutely should not be relying on the default machine type (not least because it's an incredibly ancient dev board which nobody uses any more). An ARM kernel is generally fairly specific to the hardware platform

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Anthony Liguori
On 07/25/2011 03:51 AM, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Just use g_new() and g_new0() Regards, Anthony Liguori Signed-off-by: Avi Kivitya...@redhat.com --- This is part of

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Jan Kiszka
On 2011-07-25 14:05, Peter Maydell wrote: On 25 July 2011 12:48, Peter Maydell peter.mayd...@linaro.org wrote: For ARM you absolutely should not be relying on the default machine type (not least because it's an incredibly ancient dev board which nobody uses any more). An ARM kernel is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

2011-07-25 Thread Michael Roth
On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote: On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymondcerb...@gmail.com wrote: This patch fixes a minor bugs which prevented QEMU from being built out of tree. Signed-off-by: Alexandre Raymondcerb...@gmail.com --- Makefile |2 +- 1 files

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 03:11 PM, Anthony Liguori wrote: On 07/25/2011 03:51 AM, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Just use g_new() and g_new0() These bypass qemu_malloc(). Are we okay

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Anthony Liguori
On 07/25/2011 06:11 AM, Alexander Graf wrote: #define QEMU_NEW_MULTI(type, len) ((type *)(qemu_mallocz(sizeof(type) * len))) char *arr = QEMU_NEW_MULTI(char, 1024); Still not covered: allocating a struct with a variable-size array as final member. I guess a solution for that can be found if

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Anthony Liguori
On 07/25/2011 07:18 AM, Avi Kivity wrote: On 07/25/2011 03:11 PM, Anthony Liguori wrote: On 07/25/2011 03:51 AM, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the correct type. Just use g_new() and g_new0()

[Qemu-devel] [PATCH] Fix last sector write on sd card

2011-07-25 Thread Dr. David Alan Gilbert
When writing the last sector of an SD card using WRITE_MULTIPLE_BLOCK QEmu throws an error saying that we've run off the end, and leaves itself in the wrong state. Tested on ARM Vexpress model. Signed-off-by: Dr. David Alan Gilbert david.gilb...@linaro.org --- Don't throw address error

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Peter Maydell
On 25 July 2011 13:18, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-07-25 14:05, Peter Maydell wrote: In fact having thought about it a bit I'm going to go further and say that the whole idea of a default machine is a rather x86-centric idea -- most architectures don't really have a

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Anthony Liguori
On 07/25/2011 05:59 AM, Jan Kiszka wrote: On 2011-07-25 12:45, Richard W.M. Jones wrote: That's an excuse, not a practical solution. We have to be able to work with any qemu. eg. the qemu in current Fedora Rawhide which supports only -machine accel=, or qemu in other distros which are also

Re: [Qemu-devel] [PATCH v1 1/1] Submit the codes for QEMU disk I/O limits.

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 8:08 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Fri, Jul 22, 2011 at 6:54 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Jul 22, 2011 at 10:20 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote: +    elapsed_time  = (real_time - bs-slice_start[is_write]) /

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Jan Kiszka
On 2011-07-25 14:22, Peter Maydell wrote: On 25 July 2011 13:18, Jan Kiszka jan.kis...@siemens.com wrote: On 2011-07-25 14:05, Peter Maydell wrote: In fact having thought about it a bit I'm going to go further and say that the whole idea of a default machine is a rather x86-centric idea --

Re: [Qemu-devel] [PATCH 01/55] blockdev: Make eject fail for non-removable drives even with -f

2011-07-25 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 02/55] block: Reset device model callbacks on detach

2011-07-25 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:36PM +0200, Markus Armbruster wrote: BlockDriverState members change_cb and change_opaque are initially null. The device model may set them, with bdrv_set_change_cb(). If the device model gets detached (hot unplug), they're left dangling. Only safe because

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Anthony Liguori
On 07/25/2011 04:52 AM, Avi Kivity wrote: On 07/25/2011 12:48 PM, Peter Maydell wrote: On 25 July 2011 10:32, Alexander Grafag...@suse.de wrote: On 25.07.2011, at 10:51, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which

Re: [Qemu-devel] [PATCH 04/55] block: Generalize change_cb() to BlockDevOps

2011-07-25 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:38PM +0200, Markus Armbruster wrote: So we can more easily add device model callbacks. Signed-off-by: Markus Armbruster arm...@redhat.com Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 05/55] block: Split change_cb() into change_media_cb(), resize_cb()

2011-07-25 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:39PM +0200, Markus Armbruster wrote: Multiplexing callbacks complicates matters needlessly. Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [PATCH 06/55] block/raw-win32: Drop disabled code for removable host devices

2011-07-25 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:40PM +0200, Markus Armbruster wrote: It's been disabled since the start (commit 19cb3738, Aug 2006), and has been untouched except for spelling fixes and such. I don't feel like dragging it along any further. Signed-off-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH 10/55] ide: Update command code definitions as per ACS-2 Table B.2

2011-07-25 Thread Christoph Hellwig
On Wed, Jul 20, 2011 at 06:23:44PM +0200, Markus Armbruster wrote: Drop WIN_SRST, it has same value as WIN_DEVICE_RESET. CFA_IDLEIMMEDIATE isn't specific to CFATA. ACS-2 shows it as a defined command in ATA-1, -2 and -3. Rename to WIN_IDLEIMMEDIATE2. Turn unused macros into comments. I

Re: [Qemu-devel] [PATCH 11/55] ide: Clean up case label indentation in ide_exec_cmd()

2011-07-25 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig h...@lst.de

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command block_set for dynamic block params change

2011-07-25 Thread Supriya Kannery
On 07/25/2011 12:00 PM, Stefan Hajnoczi wrote: On Wed, Jul 13, 2011 at 06:37:05PM +0530, Supriya Kannery wrote: +ret = bdrv_open(bs, bs-filename, bdrv_flags, drv); +if (ret 0) { +/* Reopen failed. Try to open with original flags */ +error_report(Opening file with

Re: [Qemu-devel] [PATCH] Introduce QEMU_NEW()

2011-07-25 Thread Avi Kivity
On 07/25/2011 03:21 PM, Anthony Liguori wrote: On 07/25/2011 07:18 AM, Avi Kivity wrote: On 07/25/2011 03:11 PM, Anthony Liguori wrote: On 07/25/2011 03:51 AM, Avi Kivity wrote: qemu_malloc() is type-unsafe as it returns a void pointer. Introduce QEMU_NEW() (and QEMU_NEWZ()), which return the

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 1:16 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote: On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymondcerb...@gmail.com  wrote: This patch fixes a minor bugs which prevented QEMU from being built out of tree.

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 14:05, Peter Maydell wrote: On 25 July 2011 12:48, Peter Maydell peter.mayd...@linaro.org wrote: For ARM you absolutely should not be relying on the default machine type (not least because it's an incredibly ancient dev board which nobody uses any more). An ARM kernel is

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-25 Thread Anthony Liguori
On 07/25/2011 06:21 AM, Kevin Wolf wrote: Am 25.07.2011 03:44, schrieb Anthony Liguori: Hi, This series is the rough beginnings of the QEMU Object Model. This is basically qdev generalized on steroids. This series includes the core infrastructure, a strawman Device type, and the beginnings

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Anthony Liguori
On 07/25/2011 07:44 AM, Alexander Graf wrote: On 25.07.2011, at 14:05, Peter Maydell wrote: On 25 July 2011 12:48, Peter Maydellpeter.mayd...@linaro.org wrote: For ARM you absolutely should not be relying on the default machine type (not least because it's an incredibly ancient dev board

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Richard W.M. Jones
On Mon, Jul 25, 2011 at 07:47:51AM -0500, Anthony Liguori wrote: On 07/25/2011 07:44 AM, Alexander Graf wrote: On 25.07.2011, at 14:05, Peter Maydell wrote: On 25 July 2011 12:48, Peter Maydellpeter.mayd...@linaro.org wrote: For ARM you absolutely should not be relying on the default

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command block_set for dynamic block params change

2011-07-25 Thread Stefan Hajnoczi
On Mon, Jul 25, 2011 at 1:52 PM, Supriya Kannery supri...@in.ibm.com wrote: On 07/25/2011 12:00 PM, Stefan Hajnoczi wrote: On Wed, Jul 13, 2011 at 06:37:05PM +0530, Supriya Kannery wrote: +    if (bdrv_is_inserted(bs)) { +        /* Reopen file with changed set of flags */ +        return

Re: [Qemu-devel] [RESEND][PATCH v3] Generalize -machine command line option

2011-07-25 Thread Alexander Graf
On 25.07.2011, at 14:49, Richard W.M. Jones wrote: On Mon, Jul 25, 2011 at 07:47:51AM -0500, Anthony Liguori wrote: On 07/25/2011 07:44 AM, Alexander Graf wrote: On 25.07.2011, at 14:05, Peter Maydell wrote: On 25 July 2011 12:48, Peter Maydellpeter.mayd...@linaro.org wrote: For ARM

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-25 Thread Kevin Wolf
Am 25.07.2011 14:45, schrieb Anthony Liguori: On 07/25/2011 06:21 AM, Kevin Wolf wrote: Am 25.07.2011 03:44, schrieb Anthony Liguori: Hi, This series is the rough beginnings of the QEMU Object Model. This is basically qdev generalized on steroids. This series includes the core

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Anthony Liguori
On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is broken in several ways: - PCI BARs are not restricted to the PCI hole (a BAR may hide memory) Technically, a BAR can be mapped to any non-RAM memory location. - PCI devices do not respect

Re: [Qemu-devel] [RFC][PATCH 0/21] QEMU Object Model

2011-07-25 Thread Anthony Liguori
On 07/25/2011 08:08 AM, Kevin Wolf wrote: Am 25.07.2011 14:45, schrieb Anthony Liguori: Okay, if it isn't possible with reasonable effort, I guess we'll have to bite the bullet and give it a very careful manual review immediately before the merge. By the way, I see that you create new

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Avi Kivity
On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is broken in several ways: - PCI BARs are not restricted to the PCI hole (a BAR may hide memory) Technically, a BAR can be mapped to any non-RAM

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is broken in several ways: - PCI BARs are not restricted to the PCI hole (a BAR may

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Avi Kivity
On 07/25/2011 04:17 PM, Gleb Natapov wrote: On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is broken in several ways: - PCI

Re: [Qemu-devel] [V4 Patch 3/4 - Updated]Qemu: Command block_set for dynamic block params change

2011-07-25 Thread Kevin Wolf
Am 25.07.2011 14:50, schrieb Stefan Hajnoczi: On Mon, Jul 25, 2011 at 1:52 PM, Supriya Kannery supri...@in.ibm.com wrote: On 07/25/2011 12:00 PM, Stefan Hajnoczi wrote: On Wed, Jul 13, 2011 at 06:37:05PM +0530, Supriya Kannery wrote: +if (bdrv_is_inserted(bs)) { +/* Reopen file

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 04:28:12PM +0300, Avi Kivity wrote: On 07/25/2011 04:17 PM, Gleb Natapov wrote: On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Avi Kivity
On 07/25/2011 04:28 PM, Avi Kivity wrote: On 07/25/2011 04:17 PM, Gleb Natapov wrote: On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Anthony Liguori
On 07/25/2011 08:28 AM, Avi Kivity wrote: On 07/25/2011 04:17 PM, Gleb Natapov wrote: On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity wrote: The current implementation of PAM and the PCI holes is

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 04:31:27PM +0300, Avi Kivity wrote: On 07/25/2011 04:28 PM, Avi Kivity wrote: On 07/25/2011 04:17 PM, Gleb Natapov wrote: On Mon, Jul 25, 2011 at 04:14:45PM +0300, Avi Kivity wrote: On 07/25/2011 04:07 PM, Anthony Liguori wrote: On 07/20/2011 11:50 AM, Avi Kivity

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Avi Kivity
On 07/25/2011 04:35 PM, Gleb Natapov wrote: That's the ISA TOM (15MB hole and friends). Correct. What about: 3.2.19.DRB[0:7] DRAM ROW BOUNDARY REGISTERS from 440fx spec? Maybe. But we can't use that, since it ignores address line 31. (440fx supports only 1GB RAM, and we're

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Anthony Liguori
On 07/25/2011 08:38 AM, Avi Kivity wrote: On 07/25/2011 04:35 PM, Gleb Natapov wrote: That's the ISA TOM (15MB hole and friends). Correct. What about: 3.2.19. DRB[0:7] DRAM ROW BOUNDARY REGISTERS from 440fx spec? Maybe. But we can't use that, since it ignores address line 31. (440fx

Re: [Qemu-devel] [RFC v5 86/86] 440fx: fix PAM, PCI holes

2011-07-25 Thread Gleb Natapov
On Mon, Jul 25, 2011 at 08:47:31AM -0500, Anthony Liguori wrote: On 07/25/2011 08:38 AM, Avi Kivity wrote: On 07/25/2011 04:35 PM, Gleb Natapov wrote: That's the ISA TOM (15MB hole and friends). Correct. What about: 3.2.19. DRB[0:7] DRAM ROW BOUNDARY REGISTERS from 440fx spec?

[Qemu-devel] 垃圾邮件通知信

2011-07-25 Thread quarantinenotify
Title: Spam Quarantine Notification Spam Quarantine Notification 下列邮件已被您的管理员作为可疑垃圾邮件阻止。 自您上一次收到垃圾邮件隔离区通知以来,您的电子邮件隔离区内已有 1 封新邮件。如果下列邮件是垃圾邮件,您不需要采取任何措施。邮件将于 7 天后自动从隔离区中移除。 如果下列任何邮件不是垃圾邮件,请单击“放行”链接以将其发送到您的收件箱。要查看所有隔离邮件,请查看 您的电子邮件隔离区。

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: fix out-of-tree builds

2011-07-25 Thread Michael Roth
On 07/25/2011 07:43 AM, Stefan Hajnoczi wrote: On Mon, Jul 25, 2011 at 1:16 PM, Michael Rothmdr...@linux.vnet.ibm.com wrote: On 07/25/2011 05:15 AM, Stefan Hajnoczi wrote: On Thu, Jul 21, 2011 at 5:41 AM, Alexandre Raymondcerb...@gmail.com wrote: This patch fixes a minor bugs which

  1   2   3   >