Re: [Qemu-devel] [PATCH 3/7] QemuState: Add additional states

2011-08-08 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 04 Aug 2011 11:02:06 +0200 Markus Armbruster arm...@redhat.com wrote: Luiz Capitulino lcapitul...@redhat.com writes: Currently, only vm_start() and vm_stop() change the VM state. That's, the state is only changed when starting or

Re: [Qemu-devel] [PATCH] Permit -mem-path without sync mmu

2011-08-08 Thread David Gibson
On Fri, Aug 05, 2011 at 12:30:53PM -0300, Marcelo Tosatti wrote: On Fri, Aug 05, 2011 at 08:16:42AM +0200, Jan Kiszka wrote: On 2011-08-05 06:02, David Gibson wrote: At present, an explicit test disallows use of -mem-path when kvm is enabled but KVM_CAP_SYNC_MMU is not set. In

Re: [Qemu-devel] Compilation error of coroutine-win32.c with gcc version 3.4.5 (mingw-vista special r3)

2011-08-08 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 1:30 AM, Roy Tam roy...@gmail.com wrote: Hi all, I checked out latest git and tried to compile QEMU but I got this message: qemu$ make V=1 gcc -m32 -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501 -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64

Re: [Qemu-devel] [PATCH] monitor: HMP: fix consecutive integer expression parsing

2011-08-08 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Fri, Aug 5, 2011 at 9:08 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 08/05/2011 03:39 PM, Blue Swirl wrote: On Fri, Aug 5, 2011 at 4:51 PM, Anthony Liguorianth...@codemonkey.ws  wrote: On 08/03/2011 06:57 AM, Alon Levy wrote: Currently a

Re: [Qemu-devel] Compilation error of coroutine-win32.c with gcc version 3.4.5 (mingw-vista special r3)

2011-08-08 Thread Roy Tam
2011/8/8 Stefan Hajnoczi stefa...@gmail.com: On Mon, Aug 8, 2011 at 1:30 AM, Roy Tam roy...@gmail.com wrote: Hi all, I checked out latest git and tried to compile QEMU but I got this message: qemu$ make V=1 gcc -m32 -D__USE_MINGW_ANSI_STDIO=1 -DWIN32_LEAN_AND_MEAN -DWINVER=0x501

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-08 Thread Supriya Kannery
On 08/05/2011 09:19 PM, Anthony Liguori wrote: On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwigh...@lst.de wrote: On Fri, Aug 05, 2011 at 02:12:48PM +0100, Daniel P. Berrange wrote: Because you cannot

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Hans de Goede
Hi, On 08/07/2011 11:30 PM, Anthony Liguori wrote: On 08/07/2011 12:41 PM, Hans de Goede wrote: Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving data. This is necessary with the spicevmc

Re: [Qemu-devel] Build broken

2011-08-08 Thread Kevin Wolf
Am 05.08.2011 18:49, schrieb malc: On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: On Fri, Aug 5, 2011 at 7:22 AM, malc av1...@comtv.ru wrote: /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c: In function 'coroutine_new': /home/malc/x/rcs/git/qemuorg/coroutine-ucontext.c:160:16: error:

Re: [Qemu-devel] Safely reopening image files by stashing fds

2011-08-08 Thread Kevin Wolf
Am 08.08.2011 09:02, schrieb Supriya Kannery: On 08/05/2011 09:19 PM, Anthony Liguori wrote: On 08/05/2011 10:43 AM, Kevin Wolf wrote: Am 05.08.2011 17:24, schrieb Stefan Hajnoczi: On Fri, Aug 5, 2011 at 3:28 PM, Christoph Hellwigh...@lst.de wrote: On Fri, Aug 05, 2011 at 02:12:48PM +0100,

Re: [Qemu-devel] [PATCH] Permit -mem-path without sync mmu

2011-08-08 Thread Avi Kivity
On 08/08/2011 09:03 AM, David Gibson wrote: Second, if userspace qemu passing hugepages to kvm can cause (host) kernel memory corruption, that is clearly a host kernel bug. So am I correct in thinking this is basically just a safety feature if qemu is run on a buggy kernel. Seems so, yes.

Re: [Qemu-devel] kvm PCI assignment VFIO ramblings

2011-08-08 Thread Avi Kivity
On 08/03/2011 05:04 AM, David Gibson wrote: I still don't understand the distinction you're making. We're saying the group is owned by a given user or guest in the sense that no-one else may use anything in the group (including host drivers). At that point none, some or all of the devices in

Re: [Qemu-devel] [PATCH 13/16] usb-hid: add hid_has_events()

2011-08-08 Thread TeLeMan
On Thu, Aug 4, 2011 at 23:10, Gerd Hoffmann kra...@redhat.com wrote: Add hid_has_events function, use it to figure whenever there are pending events instead of checking and updating USBHIDState-changed. Setting -changed to 1 on init is removed, that should have absolutely no effect as the

Re: [Qemu-devel] [PATCH v3] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Shribman, Aidan
-Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Tuesday, August 02, 2011 9:06 PM To: Shribman, Aidan Cc: qemu-devel@nongnu.org; Anthony Liguori Subject: Re: [PATCH v3] XBZRLE delta for live migration of large memory apps On Tue, Aug 02, 2011 at

[Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Shribman, Aidan
Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribman aidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory write intensive workloads typical of large

Re: [Qemu-devel] [PATCH 2/3] Introduce a 'client_add' monitor command accepting an open FD

2011-08-08 Thread Daniel P. Berrange
On Sat, Aug 06, 2011 at 09:38:03AM -0500, Anthony Liguori wrote: On 06/23/2011 07:31 AM, Daniel P. Berrange wrote: Allow client connections for VNC and socket based character devices to be passed in over the monitor using SCM_RIGHTS. One intended usage scenario is to start QEMU with VNC on a

[Qemu-devel] build failure with coroutine-gthread

2011-08-08 Thread Aneesh Kumar K.V
LINK qemu-ga coroutine-gthread.o: In function `coroutine_init': /home/opensource/sources/qemu/qemu-upstream/coroutine-gthread.c:39: undefined reference to `g_thread_init' collect2: ld returned 1 exit status The below patch fix the failure. I also added the patch in the VirtFS pull request.

[Qemu-devel] [PULL] VirtFS coroutine changes

2011-08-08 Thread Aneesh Kumar K.V
The following changes since commit 23ddf2bb1e4bfe2b72a726fe5e828807b65941ad: Fix forcing multicast msgs to loopback on OpenBSD. (2011-08-07 11:06:43 +) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-upstream-1 Aneesh Kumar K.V (32): hw/9pfs: Add yield

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Dor Laor
On 08/08/2011 06:24 AM, Isaku Yamahata wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. The purpose of this mail is to letting developers know it in advance so that we can get better feedback on its design/implementation approach

Re: [Qemu-devel] build failure with coroutine-gthread

2011-08-08 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 10:01 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote:  LINK  qemu-ga coroutine-gthread.o: In function `coroutine_init': /home/opensource/sources/qemu/qemu-upstream/coroutine-gthread.c:39: undefined reference to `g_thread_init' collect2: ld returned 1 exit

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 4:24 AM, Isaku Yamahata yamah...@valinux.co.jp wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. I'm curious if this approach is compatible with asynchronous page faults? The idea there was to tell the guest

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Yaniv Kaul
On 08/08/2011 12:20, Dor Laor wrote: On 08/08/2011 06:24 AM, Isaku Yamahata wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. The purpose of this mail is to letting developers know it in advance so that we can get better feedback on

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Isaku Yamahata
On Mon, Aug 08, 2011 at 10:38:35AM +0100, Stefan Hajnoczi wrote: On Mon, Aug 8, 2011 at 4:24 AM, Isaku Yamahata yamah...@valinux.co.jp wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. I'm curious if this approach is compatible

Re: [Qemu-devel] [PULL 0/7] ARM patch queue (for master)

2011-08-08 Thread Peter Maydell
Ping? On 27 July 2011 14:26, Peter Maydell peter.mayd...@linaro.org wrote: This is a pull request for various outstanding ARM related patches; they've been on the list for a week or so. Some of these are bug fixes which I want to get into 0.15; I'm going to do a parallel pullreq for the 0.15

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Michael S. Tsirkin
On Fri, Aug 05, 2011 at 08:52:25AM -0500, Anthony Liguori wrote: On 08/04/2011 08:05 AM, Avi Kivity wrote: From: Michael S. Tsirkinm...@redhat.com We originally did get config on map, so that following write accesses are done on an updated config. New memory API doesn't give us a callback

Re: [Qemu-devel] Build broken

2011-08-08 Thread malc
On Mon, 8 Aug 2011, Kevin Wolf wrote: Am 05.08.2011 18:49, schrieb malc: On Fri, 5 Aug 2011, Stefan Hajnoczi wrote: [..snip..] Feel free to push it. (Original code was by Anthony, then heavily modified by me, and after that modified again by Stefan) Acked-by: Kevin Wolf

Re: [Qemu-devel] build failure with coroutine-gthread

2011-08-08 Thread Aneesh Kumar K.V
On Mon, 8 Aug 2011 10:29:04 +0100, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Aug 8, 2011 at 10:01 AM, Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com wrote:  LINK  qemu-ga coroutine-gthread.o: In function `coroutine_init':

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Nadav Har'El
* What's is postcopy livemigration It is is yet another live migration mechanism for Qemu/KVM, which implements the migration technique known as postcopy or lazy migration. Just after the migrate command is invoked, the execution host of a VM is instantaneously switched to a destination host.

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Avi Kivity
On 08/04/2011 01:17 PM, Jan Kiszka wrote: Why QemuState? In general, qemu can be inferred from the fact that we're in qemu.git. Suggest RunState. Second, these states can coexist. A user may pause the VM simultaneously with the watchdog firing or entering premigrate state. In

[Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Avi Kivity
In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio threads to compete for one cpu. - we can create up to max_threads (64) aio threads in one

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Dor Laor
On 08/08/2011 01:59 PM, Nadav Har'El wrote: * What's is postcopy livemigration It is is yet another live migration mechanism for Qemu/KVM, which implements the migration technique known as postcopy or lazy migration. Just after the migrate command is invoked, the execution host of a VM is

[Qemu-devel] [PATCH] qemu-img: Use qemu_blockalign

2011-08-08 Thread Kevin Wolf
Now that you can use cache=none for the output file in qemu-img, we should properly align our buffers so that raw-posix doesn't have to use its (smaller) bounce buffer. Signed-off-by: Kevin Wolf kw...@redhat.com --- qemu-img.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-)

Re: [Qemu-devel] [PATCH] qcow2: fix typo in documentation for qcow2_get_cluster_offset()

2011-08-08 Thread Kevin Wolf
Am 08.08.2011 01:47, schrieb Devin Nakamura: Documentation states the num is measured in clusters, but its actually measured in sectors Signed-off-by: Devin Nakamura devin...@gmail.com Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Anthony Liguori
On 08/08/2011 06:37 AM, Avi Kivity wrote: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio threads to compete for one cpu. - we can

Re: [Qemu-devel] [PULL] VirtFS coroutine changes

2011-08-08 Thread Anthony Liguori
On 08/08/2011 04:03 AM, Aneesh Kumar K.V wrote: The following changes since commit 23ddf2bb1e4bfe2b72a726fe5e828807b65941ad: Fix forcing multicast msgs to loopback on OpenBSD. (2011-08-07 11:06:43 +) This need to be sent to the list first as patches for review before you can do a

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Avi Kivity
On 08/08/2011 06:24 AM, Isaku Yamahata wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. The purpose of this mail is to letting developers know it in advance so that we can get better feedback on its design/implementation approach

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Avi Kivity
On 08/08/2011 03:34 PM, Anthony Liguori wrote: On 08/08/2011 06:37 AM, Avi Kivity wrote: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio

Re: [Qemu-devel] [RFC] postcopy livemigration proposal

2011-08-08 Thread Anthony Liguori
On 08/08/2011 04:20 AM, Dor Laor wrote: On 08/08/2011 06:24 AM, Isaku Yamahata wrote: This mail is on Yabusame: Postcopy Live Migration for Qemu/KVM on which we'll give a talk at KVM-forum. The purpose of this mail is to letting developers know it in advance so that we can get better feedback

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Anthony Liguori
On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote: Thinking more closely, I don't think this right. Updating on map ensured that the config was refreshed after each time the bar was mapped. In the very least, the config needs to be refreshed during reset because the guest may write to the guest

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Avi Kivity
On 08/08/2011 03:45 PM, Anthony Liguori wrote: Actually, you never need to call config_get() AFAICT. It's called in every read/write access. So I think the code you changed is extraneous now. Ok; I'll drop this patch and report (and just remove the code in virtio_map()). -- error

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Frediano Ziglio
2011/8/8 Avi Kivity a...@redhat.com: In certain circumstances, posix-aio-compat can incur a lot of latency:  - threads are created by vcpu threads, so if vcpu affinity is set,   aio threads inherit vcpu affinity.  This can cause many aio threads   to compete for one cpu.  - we can create up

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Anthony Liguori
On 08/08/2011 03:01 AM, Hans de Goede wrote: Hi, On 08/07/2011 11:30 PM, Anthony Liguori wrote: On 08/07/2011 12:41 PM, Hans de Goede wrote: Hi, On 08/07/2011 05:52 PM, Anthony Liguori wrote: On 08/07/2011 08:21 AM, Hans de Goede wrote: To let the chardev now we're ready start receiving

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Avi Kivity
On 08/08/2011 03:49 PM, Frediano Ziglio wrote: 2011/8/8 Avi Kivitya...@redhat.com: In certain circumstances, posix-aio-compat can incur a lot of latency: - threads are created by vcpu threads, so if vcpu affinity is set, aio threads inherit vcpu affinity. This can cause many aio

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Michael S. Tsirkin
On Mon, Aug 08, 2011 at 07:45:19AM -0500, Anthony Liguori wrote: On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote: Thinking more closely, I don't think this right. Updating on map ensured that the config was refreshed after each time the bar was mapped. In the very least, the config needs

[Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Avi Kivity
QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for uint64_t. Signed-off-by: Avi Kivity a...@redhat.com --- qemu-common.h |9 + 1 files changed, 9

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Anthony Liguori
On 08/08/2011 07:56 AM, Avi Kivity wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for uint64_t. Except Linux uses lower case letters. I personally

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Hans de Goede
Hi, On 08/08/2011 02:52 PM, Anthony Liguori wrote: On 08/08/2011 03:01 AM, Hans de Goede wrote: snip So after my char-flow changes, you won't be allowed to set handlers unless you've called open. Why not do it the other way around? So don't allow open until the handlers are set. My

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Anthony Liguori
On 08/08/2011 07:56 AM, Michael S. Tsirkin wrote: On Mon, Aug 08, 2011 at 07:45:19AM -0500, Anthony Liguori wrote: On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote: Thinking more closely, I don't think this right. Updating on map ensured that the config was refreshed after each time the bar

Re: [Qemu-devel] [PATCH 2/3] usb-redir: Call qemu_chr_guest_open/close

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:03 AM, Hans de Goede wrote: Hi, On 08/08/2011 02:52 PM, Anthony Liguori wrote: On 08/08/2011 03:01 AM, Hans de Goede wrote: snip So after my char-flow changes, you won't be allowed to set handlers unless you've called open. Why not do it the other way around? So don't

[Qemu-devel] [PATCH v4 01/39] memory: rename PORTIO_END to PORTIO_END_OF_LIST

2011-08-08 Thread Avi Kivity
For consistency with other _END_OF_LIST macros. Signed-off-by: Avi Kivity a...@redhat.com --- memory.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/memory.h b/memory.h index 4e518b2..da00a3b 100644 --- a/memory.h +++ b/memory.h @@ -133,7 +133,7 @@ struct

[Qemu-devel] [PATCH v4 19/39] ivshmem: convert to memory API

2011-08-08 Thread Avi Kivity
excluding msix. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/ivshmem.c | 148 -- 1 files changed, 50 insertions(+), 98 deletions(-) diff

[Qemu-devel] [PATCH v4 23/39] lsi53c895a: convert to memory API

2011-08-08 Thread Avi Kivity
An optimization that fast-pathed DMA reads from the SCRIPTS memory was removed int the process. Likely it breaks with iommus anyway. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/lsi53c895a.c |

[Qemu-devel] [PATCH v4 14/39] ac97: convert to memory API

2011-08-08 Thread Avi Kivity
fixes BAR sizing as well. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/ac97.c | 89 +++- 1 files changed, 52 insertions(+), 37

[Qemu-devel] [PATCH v4 18/39] ide: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/ide/cmd646.c | 208 +++ hw/ide/pci.c| 25 --- hw/ide/pci.h| 19 -

[Qemu-devel] [PATCH v4 25/39] ne2000: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/ne2000-isa.c | 13 ++--- hw/ne2000.c | 77 +- hw/ne2000.h |8 + 3 files changed, 58 insertions(+), 40 deletions(-) diff

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:00 PM, Anthony Liguori wrote: On 08/08/2011 07:56 AM, Avi Kivity wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for uint64_t. Except

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Michael S. Tsirkin
On Mon, Aug 08, 2011 at 08:02:08AM -0500, Anthony Liguori wrote: On 08/08/2011 07:56 AM, Michael S. Tsirkin wrote: On Mon, Aug 08, 2011 at 07:45:19AM -0500, Anthony Liguori wrote: On 08/08/2011 05:36 AM, Michael S. Tsirkin wrote: Thinking more closely, I don't think this right. Updating on

Re: [Qemu-devel] [PATCH v3 01/39] virtio-pci: get config on init

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:14 AM, Michael S. Tsirkin wrote: Probably not noticeable because guests don't do the RMW in practice. We also send the config over on migration. That's probably a bug as well ... It's probably unnecessary, but I don't think it's a bug.. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:12 AM, Avi Kivity wrote: On 08/08/2011 04:00 PM, Anthony Liguori wrote: On 08/08/2011 07:56 AM, Avi Kivity wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Peter Maydell
On 8 August 2011 13:56, Avi Kivity a...@redhat.com wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for uint64_t. Strongly disagree. uint64_t c are

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:17 PM, Anthony Liguori wrote: This is one of the few areas that we're actually consistent with today. Introducing a new set of types will just create inconsistency. Most importantly, these are standard types. Every modern library and C program should be using them. TBH,

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Frediano Ziglio
2011/8/8 Avi Kivity a...@redhat.com: On 08/08/2011 03:49 PM, Frediano Ziglio wrote: 2011/8/8 Avi Kivitya...@redhat.com:  In certain circumstances, posix-aio-compat can incur a lot of latency:    - threads are created by vcpu threads, so if vcpu affinity is set,     aio threads inherit

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Luiz Capitulino
On Mon, 08 Aug 2011 14:22:14 +0300 Avi Kivity a...@redhat.com wrote: On 08/04/2011 01:17 PM, Jan Kiszka wrote: Why QemuState? In general, qemu can be inferred from the fact that we're in qemu.git. Suggest RunState. Second, these states can coexist. A user may pause the VM

Re: [Qemu-devel] [PATCH] posix-aio-compat: fix latency issues

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:21 PM, Frediano Ziglio wrote: The entire qemu process may be affined to a subset of the host cpus; we don't want to break that. For example: taskset 0xf0 qemu (qemu) info cpus pin individual vcpu threads to host cpus Just call sched_getaffinity at

Re: [Qemu-devel] RFC: moving fsfreeze support from the userland guest agent to the guest kernel

2011-08-08 Thread Luiz Capitulino
On Sun, 07 Aug 2011 21:28:17 +0300 Ronen Hod r...@redhat.com wrote: Well, we want to support Microsoft's VSS, and that requires a guest agent that communicates with all the writers (applications), waiting for them to flush their app data in order to generate a consistent app-level

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:25 PM, Luiz Capitulino wrote: I'm worried about the following race: stop (qemu stopped for internal reason) stop comment processed resume The (qemu stopped for internal reason) part is lost. If the stop you're referring to happens through vm_stop(),

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Luiz Capitulino
On Mon, 08 Aug 2011 16:27:05 +0300 Avi Kivity a...@redhat.com wrote: On 08/08/2011 04:25 PM, Luiz Capitulino wrote: I'm worried about the following race: stop (qemu stopped for internal reason) stop comment processed resume The (qemu stopped for

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM downtime and total live-migration time of VMs running memory

[Qemu-devel] [PATCH v4 03/39] vmsvga: don't remember pci BAR address in callback any more

2011-08-08 Thread Avi Kivity
We're going to remove the callback, so we can't use it to save the address. Use the pci API instead. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/vmware_vga.c | 12 ++-- 1 files

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:28 PM, Luiz Capitulino wrote: On Mon, 08 Aug 2011 16:27:05 +0300 Avi Kivitya...@redhat.com wrote: On 08/08/2011 04:25 PM, Luiz Capitulino wrote: I'm worried about the following race: stop (qemu stopped for internal reason) stop

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Alexander Graf
On 08.08.2011, at 15:29, Anthony Liguori wrote: On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can reduce VM

[Qemu-devel] [PATCH v4 16/39] eepro100: convert to memory API

2011-08-08 Thread Avi Kivity
Note: the existing code aliases the flash BAR into the MMIO bar. This is probably a bug. This patch does not correct the problem. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/eepro100.c | 182

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:41 AM, Alexander Graf wrote: On 08.08.2011, at 15:29, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. I think workload aware migration compression is possible for a lot

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Luiz Capitulino
On Mon, 08 Aug 2011 16:40:17 +0300 Avi Kivity a...@redhat.com wrote: On 08/08/2011 04:28 PM, Luiz Capitulino wrote: On Mon, 08 Aug 2011 16:27:05 +0300 Avi Kivitya...@redhat.com wrote: On 08/08/2011 04:25 PM, Luiz Capitulino wrote: I'm worried about the following race:

Re: [Qemu-devel] [PATCH] qemu-img: Use qemu_blockalign

2011-08-08 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 1:14 PM, Kevin Wolf kw...@redhat.com wrote: Now that you can use cache=none for the output file in qemu-img, we should properly align our buffers so that raw-posix doesn't have to use its (smaller) bounce buffer. Signed-off-by: Kevin Wolf kw...@redhat.com ---  

[Qemu-devel] [PATCH v4 26/39] pcnet: convert to memory API

2011-08-08 Thread Avi Kivity
Also related chips. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/lance.c | 31 ++- hw/pcnet-pci.c | 74 +--

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:41 PM, Alexander Graf wrote: In general, I believe it's a good idea to keep looking at libvirt as a vm management layer and only a vm management layer. Very much yes. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:29 PM, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. Poking bytes at random places in memory is fairly generic. If you have a lot of small objects, and modify a subset

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Avi Kivity
On 08/08/2011 04:47 PM, Luiz Capitulino wrote: Well, then, the user won't know something happened and will happily resume the guest, like I outlined above. I think it makes sense to return an error in the monitor if the user tries to stop qemu when it's already stopped. Not sure if it will

[Qemu-devel] [PATCH v4 13/39] rtl8139: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/rtl8139.c | 72 ++--- 1 files changed, 38 insertions(+), 34 deletions(-) diff --git

Re: [Qemu-devel] support for Freescale MPC8xx (850/860) processors/platforms

2011-08-08 Thread Alexander Graf
On 08.08.2011, at 03:36, Brendan Simon (eTRIX) wrote: Hi, Anyone working on Freescale MPC8xx (embedded PowerPC) processors ?? I'm trying to ascertain if the MPC8xx (MPC850) processors are supported, and if not, how much effort would be required to get it working. I'm not aware of

[Qemu-devel] [PATCH v4 05/39] cirrus: simplify mmio BAR access functions

2011-08-08 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. Reviewed-by: Richard Henderson r...@twiddle.net Signed-off-by: Avi Kivity a...@redhat.com --- hw/cirrus_vga.c | 78 +- 1 files changed, 8

Re: [Qemu-devel] [PATCH v3] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Stefan Hajnoczi
On Mon, Aug 8, 2011 at 9:42 AM, Shribman, Aidan aidan.shrib...@sap.com wrote: -Original Message- From: Stefan Hajnoczi [mailto:stefa...@gmail.com] Sent: Tuesday, August 02, 2011 9:06 PM To: Shribman, Aidan Cc: qemu-devel@nongnu.org; Anthony Liguori Subject: Re: [PATCH v3] XBZRLE

[Qemu-devel] [PATCH v4 37/39] pci: fold BAR mapping function into its caller

2011-08-08 Thread Avi Kivity
There is only one function, so no need for a function pointer. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 25 + hw/pci.h |1 - 2 files changed, 9

Re: [Qemu-devel] [libvirt] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Daniel P. Berrange
On Mon, Aug 08, 2011 at 08:29:51AM -0500, Anthony Liguori wrote: On 08/08/2011 03:42 AM, Shribman, Aidan wrote: Subject: [PATCH v4] XBZRLE delta for live migration of large memory apps From: Aidan Shribmanaidan.shrib...@sap.com By using XBZRLE (Xor Binary Zero Run-Length-Encoding) we can

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Luiz Capitulino
On Mon, 08 Aug 2011 16:54:16 +0300 Avi Kivity a...@redhat.com wrote: On 08/08/2011 04:47 PM, Luiz Capitulino wrote: Well, then, the user won't know something happened and will happily resume the guest, like I outlined above. I think it makes sense to return an error in the monitor

Re: [Qemu-devel] support for Freescale MPC8xx (850/860) processors/platforms

2011-08-08 Thread Benjamin Herrenschmidt
On Mon, 2011-08-08 at 15:57 +0200, Alexander Graf wrote: Hi, Anyone working on Freescale MPC8xx (embedded PowerPC) processors ?? I'm trying to ascertain if the MPC8xx (MPC850) processors are supported, and if not, how much effort would be required to get it working. I'm not

Re: [Qemu-devel] [PATCH] Introduce short names for fixed width integer types

2011-08-08 Thread Kevin Wolf
Am 08.08.2011 15:00, schrieb Anthony Liguori: On 08/08/2011 07:56 AM, Avi Kivity wrote: QEMU deals with a lot of fixed width integer types; their names (uint64_t etc) are clumsy to use and take up a lot of space. Following Linux, introduce shorter names, for example U64 for uint64_t.

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Anthony Liguori
On 08/08/2011 08:51 AM, Avi Kivity wrote: On 08/08/2011 04:29 PM, Anthony Liguori wrote: One thing that strikes me about this algorithm is that it's very good for a particular type of workload--shockingly good really. Poking bytes at random places in memory is fairly generic. If you have a

[Qemu-devel] [PATCH v4 17/39] es1370: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/es1370.c | 43 +-- 1 files changed, 25 insertions(+), 18 deletions(-) diff --git a/hw/es1370.c b/hw/es1370.c

[Qemu-devel] [PATCH v4 35/39] pci: convert pci rom to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 20 +++- hw/pci.h |3 ++- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index

[Qemu-devel] [PATCH v4 04/39] vga: convert vga and its derivatives to the memory API

2011-08-08 Thread Avi Kivity
Convert all vga memory to the memory API. Note we need to fall back to get_system_memory(), since the various buses don't pass the vga window as a memory region. We no longer need to sync the dirty bitmap of the cirrus mapped memory banks, since the memory API takes care of that for us. [jan:

[Qemu-devel] [PATCH v4 24/39] ppc: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/cuda.c |6 ++- hw/escc.c | 42 +-- hw/escc.h |2 +- hw/heathrow_pic.c | 29

[Qemu-devel] [PATCH v4 36/39] pci: remove pci_register_bar()

2011-08-08 Thread Avi Kivity
Superceded by pci_register_bar_region(). The implementations are folded together. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 42 +- hw/pci.h |

Re: [Qemu-devel] [PATCH v4] XBZRLE delta for live migration of large memory apps

2011-08-08 Thread Avi Kivity
On 08/08/2011 05:15 PM, Anthony Liguori wrote: I think workload aware migration compression is possible for a lot of different types of workloads. That makes me a bit wary of QEMU growing quite a lot of compression mechanisms. It makes me think that this logic may really belong at a higher

[Qemu-devel] [PATCH v4 00/39] Memory API, batch 2: PCI devices

2011-08-08 Thread Avi Kivity
This is a mostly mindless conversion of all QEMU PCI devices to the memory API. After this patchset is applied, it is no longer possible to create a PCI device using the old API. An immediate benefit is that PCI BARs that overlap each other are now handled correctly: currently, the sequence

[Qemu-devel] [PATCH v4 22/39] intel-hda: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/intel-hda.c | 35 +++ 1 files changed, 19 insertions(+), 16 deletions(-) diff --git a/hw/intel-hda.c

[Qemu-devel] [PATCH v4 08/39] vga: simplify vga window mmio access functions

2011-08-08 Thread Avi Kivity
Make use of the memory API's ability to satisfy multi-byte accesses via multiple single-byte accesses. We have to keep vga_mem_{read,write}b() since they're used by cirrus. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity

[Qemu-devel] [PATCH v4 33/39] msix: convert to memory API

2011-08-08 Thread Avi Kivity
The msix table is defined as a subregion, to allow for a BAR that mixes device specific regions with the msix table. Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/ivshmem.c| 11 +

Re: [Qemu-devel] [PATCH 2/7] Replace VMSTOP macros with a proper QemuState type

2011-08-08 Thread Avi Kivity
On 08/08/2011 05:06 PM, Luiz Capitulino wrote: This is why I suggested a reference count. In this case, we can always stop the guest twice, because we don't lost information when we resume. I could give it a try in the near future, as I really think it's independent from this series, but

[Qemu-devel] [PATCH v4 31/39] uhci: convert to memory API

2011-08-08 Thread Avi Kivity
Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/usb-uhci.c | 42 -- 1 files changed, 28 insertions(+), 14 deletions(-) diff --git a/hw/usb-uhci.c

  1   2   3   >