Re: [Qemu-devel] [PATCH v2 1/2] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949

2011-09-03 Thread Yonit Halperin
On 09/01/2011 10:36 PM, Michael S. Tsirkin wrote: On Wed, Aug 31, 2011 at 03:37:33PM +0300, Yonit Halperin wrote: if qxl_send_events was called from spice server context, and then migration had completed before a call to pipe_read, the target guest qxl driver didn't get the interrupt. This is

Re: [Qemu-devel] TCG sar UB (fwd)

2011-09-03 Thread malc
On Sun, 4 Sep 2011, Richard Henderson wrote: > On 09/03/2011 03:47 PM, malc wrote: > > Doesn't make much sense to me, guest clearly asked for 0 and not -1, > > besides -1 violates TCG's sar constraints and PPC obliges by emiting > > illegal instruction in this case. > > The shift that the guest a

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-03 Thread David Gibson
On Fri, Sep 02, 2011 at 06:45:50PM +0300, Michael S. Tsirkin wrote: > On Thu, Sep 01, 2011 at 04:31:09PM -0400, Paolo Bonzini wrote: > > > > > Why not limit the change to ppc then? > > > > > > > > Because the bug is masked by the x86 memory model, but it is still > > > > there even there conceptual

Re: [Qemu-devel] TCG sar UB (fwd)

2011-09-03 Thread Richard Henderson
On 09/03/2011 03:47 PM, malc wrote: > Doesn't make much sense to me, guest clearly asked for 0 and not -1, > besides -1 violates TCG's sar constraints and PPC obliges by emiting > illegal instruction in this case. The shift that the guest asked for was completely folded away. The -1 comes from ge

[Qemu-devel] [Bug 840686] [NEW] No such list qemu-users

2011-09-03 Thread Ottavio Caruso
Public bug reported: The mailing list "qemu-users", described on the project page: http://savannah.nongnu.org/mail/?group=qemu as "QEMU users mailing list", is not available. The link: http://lists.nongnu.org/mailman/listinfo/qemu-users results in error: "No such list qemu-users". Further refer

Re: [Qemu-devel] Single 64bit memory transaction instead of two 32bit memory transaction

2011-09-03 Thread Adnan Khaleel
Is there a patch for the new MemoryRegion API? At least for now, I need to be able to issue a single 64, 128 or 256bit transaction to a particular IO device. Is there a way I can do this now as a temp solution? I don't mind coalescing the bytes as they are issued by Qemu but I have no way to

[Qemu-devel] [PATCH v2] rbd: fix leak in qemu_rbd_open failure paths

2011-09-03 Thread Sage Weil
Fix leak of s->snap in failure path. Simplify error paths for the whole function. Reported-by: Stefan Hajnoczi Signed-off-by: Sage Weil --- v2: fixes all error paths, not just the first one. block/rbd.c | 28 +--- 1 files changed, 13 insertions(+), 15 deletions(-)

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Anthony Liguori
On 09/03/2011 04:10 PM, Blue Swirl wrote: On Sat, Sep 3, 2011 at 8:07 PM, Anthony Liguori wrote: On 09/01/2011 12:58 AM, Avi Kivity wrote: On 08/31/2011 07:59 PM, Blue Swirl wrote: That makes it impossible to migrate level-triggered irq lines. Or at least, the receiver has to remember t

[Qemu-devel] [PATCH 2/2] PCI: delete unused mem_base and pci_to_cpu_addr

2011-09-03 Thread Blue Swirl
Signed-off-by: Blue Swirl --- hw/pci.c | 14 +- hw/pci.h |2 -- 2 files changed, 1 insertions(+), 15 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 57ff7b1..af74003 100644 --- a/hw/pci.c +++ b/hw/pci.c @@ -312,11 +312,6 @@ void pci_bus_hotplug(PCIBus *bus, pci_hotplug_fn h

[Qemu-devel] [PATCH 1/2] apb_pci: convert PCI space to memory API

2011-09-03 Thread Blue Swirl
Add a new memory space for PCI instead of using system memory. This also fixes a bug where VGA region vga.chain4 is accidentally mapped to 0xa instead of 0x1ff000a. Signed-off-by: Blue Swirl --- hw/apb_pci.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --

Re: [Qemu-devel] [PATCH 2/2] softfloat: Use uint32 consistently

2011-09-03 Thread Blue Swirl
Thanks, applied. On Sun, Aug 28, 2011 at 6:24 PM, Andreas Färber wrote: > Prepares for uint32 replacement. > > Signed-off-by: Andreas Färber > --- >  fpu/softfloat.c |   20 ++-- >  fpu/softfloat.h |    4 ++-- >  2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/

Re: [Qemu-devel] [PATCH 1/2] softfloat: Use uint16 consistently

2011-09-03 Thread Blue Swirl
Thanks, applied. On Sun, Aug 28, 2011 at 6:24 PM, Andreas Färber wrote: > Prepares for uint16 replacement. > > Signed-off-by: Andreas Färber > --- >  fpu/softfloat.c |    8 >  fpu/softfloat.h |    4 ++-- >  2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fpu/softfloat.

Re: [Qemu-devel] [PATCH] Allow overriding the location of Samba's smbd.

2011-09-03 Thread Blue Swirl
Thanks, applied. On Fri, Sep 2, 2011 at 8:53 PM, Brad wrote: > Allow overriding the location of Samba's smbd. > > Pretty much every OS I look at has some means of > changing this path (patching) so lets just make > it easier for OS developers creating packages > and/or end users to override the l

Re: [Qemu-devel] [PATCH 0/2] Fix packing for MinGW with new macro QEMU_PACKED

2011-09-03 Thread Blue Swirl
On Wed, Aug 31, 2011 at 10:37 AM, Stefan Weil wrote: > The new series adds macro QEMU_PACKED and converts most > code locations mechanically (script) to use this macro. > > See log message of patch 2/2 for the few exceptions. > > [PATCH 1/2] Add new macro QEMU_PACKED for packed C structures > [PAT

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Blue Swirl
On Sat, Sep 3, 2011 at 8:07 PM, Anthony Liguori wrote: > On 09/01/2011 12:58 AM, Avi Kivity wrote: >> >> On 08/31/2011 07:59 PM, Blue Swirl wrote: >>> >>> > >>> > That makes it impossible to migrate level-triggered irq lines. Or at >>> least, >>> > the receiver has to remember the state, instead o

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Blue Swirl
On Sat, Sep 3, 2011 at 7:53 PM, Anthony Liguori wrote: > On 08/31/2011 11:59 AM, Blue Swirl wrote: >> >> On Wed, Aug 31, 2011 at 8:28 AM, Avi Kivity  wrote: >>> >>> On 08/30/2011 10:19 PM, Blue Swirl wrote: > >  We need some kind of two phase restore. In the first phase all state

Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386

2011-09-03 Thread Anthony Liguori
On 09/03/2011 08:44 AM, Andreas Färber wrote: Am 02.09.2011 um 17:40 schrieb Anthony Liguori: On 08/29/2011 09:55 AM, Anthony Liguori wrote: This has been discussed before in the past. The special casing really makes no sense anymore. This seems like a good change to make for 1.0. Signed-off-

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Anthony Liguori
On 09/01/2011 12:58 AM, Avi Kivity wrote: On 08/31/2011 07:59 PM, Blue Swirl wrote: > > That makes it impossible to migrate level-triggered irq lines. Or at least, > the receiver has to remember the state, instead of (or in addition to) the > sender. Both ends probably need to remember the stat

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Anthony Liguori
On 08/31/2011 05:53 AM, Jan Kiszka wrote: On 2011-08-31 10:25, Peter Maydell wrote: On 30 August 2011 20:28, Jan Kiszka wrote: Yes, that's the current state. Once we have bidirectional IRQ links in place (pushing downward, querying upward - required to skip IRQ routers for fast, lockless deliv

Re: [Qemu-devel] [PATCH] pc: Clean up PIC-to-APIC IRQ path

2011-09-03 Thread Anthony Liguori
On 08/31/2011 11:59 AM, Blue Swirl wrote: On Wed, Aug 31, 2011 at 8:28 AM, Avi Kivity wrote: On 08/30/2011 10:19 PM, Blue Swirl wrote: We need some kind of two phase restore. In the first phase all state is restored; since some of that state drivers outputs that are input to other dev

[Qemu-devel] [PATCH] pc_init: Fail on bad kernel

2011-09-03 Thread Sasha Levin
When providing QEMU with a bad '-kernel' parameter, such as a file which is not really a kernel, QEMU will attempt to allocate a huge amount of memory and fail either with "Failed to allocate memory: Cannot allocate memory" or a GLib error: "GLib-ERROR **: gmem.c:170: failed to allocate 18446744073

Re: [Qemu-devel] [PATCH v2] pc: Fix and clean up PIC-to-APIC IRQ path

2011-09-03 Thread Jan Kiszka
On 2011-09-03 13:37, Blue Swirl wrote: > On Sat, Sep 3, 2011 at 11:17 AM, Jan Kiszka wrote: >> On 2011-09-03 10:58, Blue Swirl wrote: >>> On Thu, Sep 1, 2011 at 9:08 AM, Jan Kiszka wrote: The master PIC is connected to the LINTIN0 of the APICs. As the APIC currently does not track the s

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-03 Thread Paolo Bonzini
On 09/02/2011 05:45 PM, Michael S. Tsirkin wrote: Well, can you describe an issue in virtio that lfence/sfence help solve in terms of a memory model please? Pls note that guest uses smp_ variants for barriers. /* Make sure buffer is written before we update index. */ wmb(); Without it,

Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386

2011-09-03 Thread Paolo Bonzini
On 09/03/2011 03:44 PM, Andreas Färber wrote: This will leave an old qemu executable from a previous `make install` behind. We should check for it and, unless it's a symlink to qemu-system-i386, remove it in the install target. No, "make install" should never remove anything. Paolo

[Qemu-devel] [PATCH] ehci: avoid string arguments in trace events

2011-09-03 Thread Stefan Hajnoczi
String arguments are not supported by all trace backends. This patch replaces existing string arguments in hw/usb-ehci.c either with individual trace events that remain human-friendly or by printing raw addresses when there is no alternative or downside to that. States and usbsts bits remain huma

Re: [Qemu-devel] softfloat breaks cocoa.m

2011-09-03 Thread Peter Maydell
On 2 September 2011 19:18, Andreas Färber wrote: > What about my preparatory patches? Can you ack them? Sorry, yeah, I'd missed those; that cleanup is worth doing whatever we decide to do here. Now reviewed. -- PMM

Re: [Qemu-devel] [PATCH 2/2] softfloat: Use uint32 consistently

2011-09-03 Thread Peter Maydell
On 28 August 2011 19:24, Andreas Färber wrote: > Prepares for uint32 replacement. > > Signed-off-by: Andreas Färber Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 1/2] softfloat: Use uint16 consistently

2011-09-03 Thread Peter Maydell
On 28 August 2011 19:24, Andreas Färber wrote: > Prepares for uint16 replacement. > > Signed-off-by: Andreas Färber Reviewed-by: Peter Maydell

[Qemu-devel] Where to log xen_platform_log data

2011-09-03 Thread Stefan Hajnoczi
Hi Steven, The Xen platform PCI device has a logging feature that is currently implemented using trace_xen_platform_log(s->log_buffer). String arguments may not be supported by all trace backends so they should be avoided. For example, the simple trace backend logs 8-byte arguments and therefore

Re: [Qemu-devel] [PATCH] Allow overriding the location of Samba's smbd.

2011-09-03 Thread Stefan Hajnoczi
On Fri, Sep 2, 2011 at 9:53 PM, Brad wrote: > Allow overriding the location of Samba's smbd. > > Pretty much every OS I look at has some means of > changing this path (patching) so lets just make > it easier for OS developers creating packages > and/or end users to override the location. > > Signe

Re: [Qemu-devel] [PATCH v2] Display logical disk size in 'info block' output

2011-09-03 Thread Stefan Hajnoczi
On Fri, Sep 2, 2011 at 5:38 PM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > To aid in knowing whether a 'block_resize' was succesful, display > the logical disk size in bytes, in the 'info block' output > > In v2: >  - Replace sectors with bytes > > Signed-off-by: Daniel P. Berrang

[Qemu-devel] [PATCH] hw/qxl: Fix format string errors

2011-09-03 Thread Peter Maydell
Fix format string errors causing compile failure on 32 bit hosts when spice is enabled. Signed-off-by: Peter Maydell --- This fixes the easy parts of the 32 bit compile failures with spice enabled. It leaves the following two warnings: hw/qxl.c: In function 'interface_release_resource': hw/qxl.

Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386

2011-09-03 Thread Andreas Färber
Am 02.09.2011 um 17:40 schrieb Anthony Liguori: On 08/29/2011 09:55 AM, Anthony Liguori wrote: This has been discussed before in the past. The special casing really makes no sense anymore. This seems like a good change to make for 1.0. Signed-off-by: Anthony Liguori Applied. Regards, A

Re: [Qemu-devel] target_phys_addr_t vs ram_addr_t

2011-09-03 Thread Peter Maydell
On 3 September 2011 12:26, Blue Swirl wrote: > On Fri, Sep 2, 2011 at 6:08 AM, Sinha, Ani wrote: >> First off, what is the difference between target_phys_addr_t and >> ram_addr_t? I believe the former is a virtual address within the guest but >> what is the later? The comment says "address in ram

Re: [Qemu-devel] [RFC PATCH 0/5] Add configure flag to disable TCG

2011-09-03 Thread Alexander Graf
On 03.09.2011, at 13:58, Blue Swirl wrote: > On Fri, Sep 2, 2011 at 9:47 PM, Anthony Liguori wrote: >> Hi, >> >> There have been a few attempts in the past to allow TCG to be disabled >> at build time. Recently, Alex made the suggestion that we could do it by >> using >> the same trick that w

Re: [Qemu-devel] [PATCH 01/10] Add stub functions for PCI device models to do PCI DMA

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 8:35 AM, Avi Kivity wrote: > On 09/01/2011 07:32 PM, Anthony Liguori wrote: >>> >>> True. But I still think it's the right thing. >>> >>> We can't really pass a MemoryRegion as the source address, since there >>> is no per-device MemoryRegion. >> >> >> Couldn't the PCI bus e

Re: [Qemu-devel] [PATCH 4/5] tcg: don't build tcg/tcg.o, tcg/optimize.o, or translate-all.o when TCG disabled

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 9:48 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- >  Makefile.target         |    6 +++--- >  exec.c                  |   44 +--- >  target-i386/op_helper.c |    2 +- >  translate-all.c         |   12 +++-

Re: [Qemu-devel] [PATCH 5/5] tcg: don't build cpu-exec.o, op_helper.o, or fpu/softloat.o when TCG disabled

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 9:48 PM, Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- >  Makefile.target         |    8 +--- >  cpu-exec.c              |   19 --- >  cpus.c                  |   11 ++- >  exec.c                  |   29 ++

Re: [Qemu-devel] [RFC PATCH 0/5] Add configure flag to disable TCG

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 9:47 PM, Anthony Liguori wrote: > Hi, > > There have been a few attempts in the past to allow TCG to be disabled > at build time.  Recently, Alex made the suggestion that we could do it by > using > the same trick that we used to introduce kvm support.  That involves > int

Re: [Qemu-devel] [PATCH] virtio: Make memory barriers be memory barriers

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 6:49 AM, Paolo Bonzini wrote: > On 09/02/2011 02:08 AM, David Gibson wrote: >>> >>> > >  >Signed-off-by: Alexey Kardashevskiy >  >Signed-off-by: David Gibson >>> >>> > >>> >  It will most definitely break OpenBSD, but anyway: >> >> Uh, why? > > They use an anc

Re: [Qemu-devel] [PATCH] Rename qemu -> qemu-system-i386

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 3:39 PM, Anthony Liguori wrote: > On 08/30/2011 02:24 PM, Blue Swirl wrote: >> >> On Mon, Aug 29, 2011 at 2:55 PM, Anthony Liguori >>  wrote: >>> >>> This has been discussed before in the past.  The special casing really >>> makes no >>> sense anymore.  This seems like a goo

Re: [Qemu-devel] [PATCH v2] pc: Fix and clean up PIC-to-APIC IRQ path

2011-09-03 Thread Blue Swirl
On Sat, Sep 3, 2011 at 11:17 AM, Jan Kiszka wrote: > On 2011-09-03 10:58, Blue Swirl wrote: >> On Thu, Sep 1, 2011 at 9:08 AM, Jan Kiszka wrote: >>> The master PIC is connected to the LINTIN0 of the APICs. As the APIC >>> currently does not track the state of that line, we have to ask the PIC >>>

Re: [Qemu-devel] target_phys_addr_t vs ram_addr_t

2011-09-03 Thread Blue Swirl
On Fri, Sep 2, 2011 at 6:08 AM, Sinha, Ani wrote: > Hi Folks : > > I am trying to write a virtio driver and towards this end I am looking at > the qemu code. I am a little confused about a few things. Unfortunately, > the few comments in the code does not make it clear for me. So I am > wondering

Re: [Qemu-devel] [PATCH v2] pc: Fix and clean up PIC-to-APIC IRQ path

2011-09-03 Thread Jan Kiszka
On 2011-09-03 10:58, Blue Swirl wrote: > On Thu, Sep 1, 2011 at 9:08 AM, Jan Kiszka wrote: >> The master PIC is connected to the LINTIN0 of the APICs. As the APIC >> currently does not track the state of that line, we have to ask the PIC >> to reinject its IRQ after the CPU picked up an event from

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-09-03 Thread Blue Swirl
On Sat, Sep 3, 2011 at 9:26 AM, Dhaval Giani wrote: > On Sat, Sep 3, 2011 at 1:53 AM, Blue Swirl wrote: >> On Wed, Aug 31, 2011 at 6:00 PM, Dhaval Giani wrote: >>> On Wed, Aug 31, 2011 at 10:58 AM, Blue Swirl wrote: On Wed, Aug 31, 2011 at 8:38 AM, Avi Kivity wrote: > On 08/26/2011 10

Re: [Qemu-devel] [PATCH] Add support for r6040 NIC

2011-09-03 Thread Blue Swirl
On Thu, Sep 1, 2011 at 9:49 PM, Anthony Liguori wrote: > On 09/01/2011 02:39 AM, Markus Armbruster wrote: >> >> Blue Swirl  writes: >> >>> On Wed, Aug 31, 2011 at 4:06 PM, Anthony Liguori >>>  wrote: On 08/31/2011 09:35 AM, malc wrote: > > On Wed, 31 Aug 2011, Anthony Liguori wro

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-09-03 Thread Dhaval Giani
On Sat, Sep 3, 2011 at 1:53 AM, Blue Swirl wrote: > On Wed, Aug 31, 2011 at 6:00 PM, Dhaval Giani wrote: >> On Wed, Aug 31, 2011 at 10:58 AM, Blue Swirl wrote: >>> On Wed, Aug 31, 2011 at 8:38 AM, Avi Kivity wrote: On 08/26/2011 10:06 PM, Blue Swirl wrote: > > Let guests inject tra

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-03 Thread Blue Swirl
On Thu, Sep 1, 2011 at 2:17 PM, Fabien Chouteau wrote: > Gdb expects all registers windows to be flushed in ram, which is not the case > in Qemu. Therefore the back-trace generation doesn't work. This patch adds a > function to handle reads/writes in stack frames as if windows were flushed. > > Si

Re: [Qemu-devel] [PATCH v2] pc: Fix and clean up PIC-to-APIC IRQ path

2011-09-03 Thread Blue Swirl
On Thu, Sep 1, 2011 at 9:08 AM, Jan Kiszka wrote: > The master PIC is connected to the LINTIN0 of the APICs. As the APIC > currently does not track the state of that line, we have to ask the PIC > to reinject its IRQ after the CPU picked up an event from the APIC. > > This introduces pic_get_outpu

Re: [Qemu-devel] [PATCH, RFC] trace: implement guest tracepoint passthrough

2011-09-03 Thread Blue Swirl
On Wed, Aug 31, 2011 at 6:00 PM, Dhaval Giani wrote: > On Wed, Aug 31, 2011 at 10:58 AM, Blue Swirl wrote: >> On Wed, Aug 31, 2011 at 8:38 AM, Avi Kivity wrote: >>> On 08/26/2011 10:06 PM, Blue Swirl wrote: Let guests inject tracepoint data via fw_cfg device. >>> >>> At least