Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Wen Congyang
At 09/07/2011 07:52 PM, Michael S. Tsirkin Write: On Wed, Sep 07, 2011 at 12:39:09PM +0800, Wen Congyang wrote: At 09/06/2011 03:45 PM, Avi Kivity Write: On 09/06/2011 06:06 AM, Wen Congyang wrote: Use the uio driver - http://docs.blackfin.uclinux.org/kernel/generated/uio-howto/. You just

Re: [Qemu-devel] [PATCH v3 02/27] ide: Use a table to declare which drive kinds accept each command

2011-09-08 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 06.09.2011 18:58, schrieb Markus Armbruster: No functional change. It would be nice to have handler functions in the table, like commit e1a064f9 did for ATAPI. Left for another day. Signed-off-by: Markus Armbruster arm...@redhat.com ---

Re: [Qemu-devel] [PATCH v3 14/27] block: Rename bdrv_set_locked() to bdrv_lock_medium()

2011-09-08 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 06.09.2011 18:58, schrieb Markus Armbruster: While there, make the locked parameter bool. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c |8 block.h |2 +- block/raw-posix.c |8

Re: [Qemu-devel] [PATCH] linux-user: Implement new ARM 64 bit cmpxchg kernel helper

2011-09-08 Thread Peter Maydell
On 31 August 2011 17:24, Dr. David Alan Gilbert david.gilb...@linaro.org wrote: linux-user: Implement new ARM 64 bit cmpxchg kernel helper Linux 3.1 will have a new kernel-page helper for ARM implementing 64 bit cmpxchg. Implement this helper in QEMU linux-user mode:  * Provide kernel helper

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Wen Congyang
At 09/08/2011 02:15 PM, Wen Congyang Write: At 09/07/2011 07:52 PM, Michael S. Tsirkin Write: On Wed, Sep 07, 2011 at 12:39:09PM +0800, Wen Congyang wrote: At 09/06/2011 03:45 PM, Avi Kivity Write: On 09/06/2011 06:06 AM, Wen Congyang wrote: Use the uio driver -

Re: [Qemu-devel] [PATCH] ahci: add port I/O index-data pair

2011-09-08 Thread Daniel Verkamp
(Sorry for the slow response, was on vacation) On Thu, Sep 1, 2011 at 7:58 AM, Alexander Graf ag...@suse.de wrote: On 08/30/2011 05:07 AM, Daniel Verkamp wrote: On Sun, Aug 28, 2011 at 11:48 AM, Alexander Grafag...@suse.de  wrote: On 27.08.2011, at 04:12, Daniel Verkamp wrote: Implement an

Re: [Qemu-devel] [PATCH 11/31] block/raw: Fix to forward method bdrv_media_changed()

2011-09-08 Thread Kevin Wolf
Am 07.09.2011 21:25, schrieb Blue Swirl: On Tue, Sep 6, 2011 at 3:39 PM, Kevin Wolf kw...@redhat.com wrote: From: Markus Armbruster arm...@redhat.com Block driver raw forwards most methods to the underlying block driver. However, it doesn't implement method bdrv_media_changed(). Makes

Re: [Qemu-devel] [RFC PATCH 4/5] VFIO: Add PCI device support

2011-09-08 Thread Avi Kivity
On 09/07/2011 09:55 PM, Konrad Rzeszutek Wilk wrote: If you don't know what to do here, say N. + +menuconfig VFIO_PCI + bool VFIO support for PCI devices + depends on VFIO PCI + default y if X86 Hahah.. And Linus is going to tear your behind for that. Default should be 'n' It

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-08 Thread Stefan Hajnoczi
On Wed, Sep 07, 2011 at 04:06:51PM -0700, Yehuda Sadeh wrote: The following set of patches improve the qemu-img conversion process performance. When using a higher latency backend, small writes have a severe impact on the time it takes to do image conversion. We switch to using async writes,

Re: [Qemu-devel] Suspicious code in qcow2.

2011-09-08 Thread Kevin Wolf
Am 07.09.2011 18:42, schrieb Frediano Ziglio: Actually it does not cause problems but this code order seems a bit wrong to me (block/qcow2-cluster.c) QLIST_INSERT_HEAD(s-cluster_allocs, m, next_in_flight); /* allocate a new cluster */ cluster_offset =

Re: [Qemu-devel] [PATCH 3/5] tcg/s390: Only one call output register needed for 64 bit hosts

2011-09-08 Thread Richard Henderson
On 09/07/2011 12:32 PM, Alexander Graf wrote: On 05.09.2011, at 11:07, Stefan Weil wrote: The second register is only needed for 32 bit hosts. Looks sane to me. Richard, mind to ack? Alex Cc: Alexander Graf ag...@suse.de Signed-off-by: Stefan Weil w...@mail.berlios.de Acked-by:

[Qemu-devel] [PATCH] target-i386: Compute all flag data inside %cl != 0 test.

2011-09-08 Thread Richard Henderson
The (x (cl - 1)) quantity is only used if CL != 0. Move the computation of that quantity nearer its use. This avoids the creation of undefined TCG operations when the constant propagation optimization proves that CL == 0, and thus CL-1 is outside the range [0-wordsize). Signed-off-by: Richard

Re: [Qemu-devel] [PATCH] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-08 Thread Fabien Chouteau
On 07/09/2011 21:02, Blue Swirl wrote: On Tue, Sep 6, 2011 at 10:38 AM, Fabien Chouteau chout...@adacore.com wrote: On 05/09/2011 21:22, Blue Swirl wrote: On Mon, Sep 5, 2011 at 9:33 AM, Fabien Chouteau chout...@adacore.com wrote: On 03/09/2011 11:25, Blue Swirl wrote: On Thu, Sep 1, 2011

[Qemu-devel] CFQ I/O starvation problem triggered by RHEL6.0 KVM guests

2011-09-08 Thread Takuya Yoshikawa
This is a report of strange cfq behaviour which seems to be triggered by QEMU posix aio threads. Host environment: OS: RHEL6.0 KVM/qemu-kvm (with no patch applied) IO scheduler: cfq (with the default parameters) On the host, we were running 3 linux guests to see if I/O from these guests

Re: [Qemu-devel] [PATCH 1/2] build: fix missing trace dep on GENERATED_HEADERS

2011-09-08 Thread Stefan Hajnoczi
On Thu, Sep 8, 2011 at 12:40 AM, Michael Roth mdr...@linux.vnet.ibm.com wrote: fc764105 added an include for qemu-common.h to trace/control.h, which made all users of this header file dependent on GENERATED_HEADERS. Since it's used by pretty much all the trace backends now, make trace-obj-y

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Gerd Hoffmann
Hi, I modify the code like this, and the PCI_INTERRUPT_LINE register is set, and I can bind it to uio_pci_generic: --- a/src/pciinit.c +++ b/src/pciinit.c @@ -575,6 +575,8 @@ static int pci_bios_init_root_regions(u32 start, u32 end) pci_bios_init_bus_bases(busses[0]); -

Re: [Qemu-devel] [PATCH 1/3] rbd: allow client id to be specified in config string

2011-09-08 Thread Stefan Hajnoczi
On Wed, Sep 7, 2011 at 5:28 PM, Sage Weil s...@newdream.net wrote: Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as.  Currently they are stuck with the default ('admin').  This is necessary for anyone using authentication in

Re: [Qemu-devel] [PATCH 2/3] rbd: clean up, fix style

2011-09-08 Thread Stefan Hajnoczi
On Wed, Sep 7, 2011 at 5:28 PM, Sage Weil s...@newdream.net wrote: No assignment in condition.  Remove duplicate ret 0 check. Signed-off-by: Sage Weil s...@newdream.net ---  block/rbd.c |   17 -  1 files changed, 8 insertions(+), 9 deletions(-) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 3/3] rbd: fix leak in qemu_rbd_open failure paths

2011-09-08 Thread Stefan Hajnoczi
On Wed, Sep 7, 2011 at 5:28 PM, Sage Weil s...@newdream.net wrote: Fix leak of s-snap in failure path.  Simplify error paths for the whole function. Reported-by: Stefan Hajnoczi stefa...@gmail.com Signed-off-by: Sage Weil s...@newdream.net ---  block/rbd.c |   28

[Qemu-devel] Consistent crasher on reboot / shutdown

2011-09-08 Thread Avi Kivity
#0 0x7f0f5da502c4 in malloc_consolidate.part.3 () from /lib64/libc.so.6 #1 0x7f0f5da51274 in _int_malloc () from /lib64/libc.so.6 #2 0x7f0f5da53b00 in malloc () from /lib64/libc.so.6 #3 0x0066cfec in malloc_and_trace (n_bytes=4120) at

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Wen Congyang
At 09/08/2011 05:43 PM, Gerd Hoffmann Write: Hi, I modify the code like this, and the PCI_INTERRUPT_LINE register is set, and I can bind it to uio_pci_generic: --- a/src/pciinit.c +++ b/src/pciinit.c @@ -575,6 +575,8 @@ static int pci_bios_init_root_regions(u32 start, u32 end)

Re: [Qemu-devel] [PATCH 1/3] rbd: allow client id to be specified in config string

2011-09-08 Thread Kevin Wolf
Am 07.09.2011 18:28, schrieb Sage Weil: Allow the client id to be specified in the config string via 'id=' so that users can control who they authenticate as. Currently they are stuck with the default ('admin'). This is necessary for anyone using authentication in their environment.

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Avi Kivity
On 09/07/2011 09:44 PM, Anthony Liguori wrote: I think this is a bit more complicated than is really needed. Here's what I came up with which also fixes another bug where the io channel could be freed twice. I stumbled across this via a very strange failure scenario. Avi, it might be

[Qemu-devel] [PATCH v8 0/4] The intro of QEMU block I/O throttling

2011-09-08 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue

[Qemu-devel] [PATCH v8 2/4] block: add the command line support

2011-09-08 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- block.c | 59 +++ block.h |5 block_int.h |3 ++ blockdev.c | 29 +++ qemu-config.c | 24 ++

[Qemu-devel] [PATCH v8 1/4] block: add the block queue support

2011-09-08 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- Makefile.objs |2 +- block/blk-queue.c | 201 + block/blk-queue.h | 59 block_int.h | 27 +++ 4 files changed, 288 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

2011-09-08 Thread Zhi Yong Wu
Note: 1.) When bps/iops limits are specified to a small value such as 511 bytes/s, this VM will hang up. We are considering how to handle this senario. 2.) When dd command is issued in guest, if its option bs is set to a large value such as bs=1024K, the result speed will slightly

[Qemu-devel] [PATCH v8 4/4] qmp/hmp: add block_set_io_throttle

2011-09-08 Thread Zhi Yong Wu
The patch introduce one new command block_set_io_throttle; For its usage syntax, if you have better idea, pls let me know. Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- block.c | 26 +++- blockdev.c | 69

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Kevin Wolf
Am 08.09.2011 12:07, schrieb Avi Kivity: On 09/07/2011 09:44 PM, Anthony Liguori wrote: I think this is a bit more complicated than is really needed. Here's what I came up with which also fixes another bug where the io channel could be freed twice. I stumbled across this via a very

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An additional 'layer' for reading and writing the blobs to the underlying block storage is added. This layer encrypts

Re: [Qemu-devel] [PATCH V8 08/14] Introduce file lock for the block layer

2011-09-08 Thread Michael S. Tsirkin
On Wed, Sep 07, 2011 at 08:31:45PM -0400, Stefan Berger wrote: On 09/07/2011 02:49 PM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 12:08:22PM -0400, Stefan Berger wrote: On 09/07/2011 11:16 AM, Michael S. Tsirkin wrote: So it's a bug in the code then? From what I saw, yes.

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2011 at 05:58:12PM +0800, Wen Congyang wrote: At 09/08/2011 05:43 PM, Gerd Hoffmann Write: Hi, I modify the code like this, and the PCI_INTERRUPT_LINE register is set, and I can bind it to uio_pci_generic: --- a/src/pciinit.c +++ b/src/pciinit.c @@ -575,6

[Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability

2011-09-08 Thread Jan Kiszka
eepro100 was the last user. Now pci_add_capability is powerful enough. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- hw/pci.c |6 -- hw/pci.h |2 -- 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 57ff7b1..63c346d 100644 --- a/hw/pci.c

[Qemu-devel] [PATCH V2] [SPARC] Gdbstub: Fix back-trace on SPARC32

2011-09-08 Thread Fabien Chouteau
Gdb expects all registers windows to be flushed in ram, which is not the case in Qemu. Therefore the back-trace generation doesn't work. This patch adds a function to handle reads (and only read) in stack frames as if windows were flushed. Signed-off-by: Fabien Chouteau chout...@adacore.com ---

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Wen Congyang
At 09/08/2011 06:42 PM, Michael S. Tsirkin Write: On Thu, Sep 08, 2011 at 05:58:12PM +0800, Wen Congyang wrote: At 09/08/2011 05:43 PM, Gerd Hoffmann Write: Hi, I modify the code like this, and the PCI_INTERRUPT_LINE register is set, and I can bind it to uio_pci_generic: ---

Re: [Qemu-devel] [PATCH] pci: add standard bridge device

2011-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2011 at 07:03:10PM +0800, Wen Congyang wrote: At 09/08/2011 06:42 PM, Michael S. Tsirkin Write: On Thu, Sep 08, 2011 at 05:58:12PM +0800, Wen Congyang wrote: At 09/08/2011 05:43 PM, Gerd Hoffmann Write: Hi, I modify the code like this, and the PCI_INTERRUPT_LINE

Re: [Qemu-devel] [PATCH v3 00/27] Block layer cleanup fixes

2011-09-08 Thread Kevin Wolf
Am 06.09.2011 18:58, schrieb Markus Armbruster: This patch series looks bigger than it is. All the patches are small and hopefully easy to review. Objectives: * Push BlockDriverState members locked, tray_open, media_changed into device models, where they belong. Kevin picked the

[Qemu-devel] [PATCH] qcow2: initialize metadata before inserting in cluster_allocs

2011-09-08 Thread Frediano Ziglio
QCow2Meta structure was inserted into list before many fields are initialized. Currently is not a problem cause all occur in a lock but if qcow2_alloc_clusters would in a future unlock this lock some issues could arise. Initializing fields before inserting fix the problem. Signed-off-by: Frediano

Re: [Qemu-devel] [PATCH] qcow2: initialize metadata before inserting in cluster_allocs

2011-09-08 Thread Kevin Wolf
Am 08.09.2011 13:38, schrieb Frediano Ziglio: QCow2Meta structure was inserted into list before many fields are initialized. Currently is not a problem cause all occur in a lock but if qcow2_alloc_clusters would in a future unlock this lock some issues could arise. Initializing fields before

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Stefan Berger
On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An additional 'layer' for reading and writing the blobs to the

Re: [Qemu-devel] [PATCH -V2] iohandler: update qemu_fd_set_handler to work with null call back arg

2011-09-08 Thread Anthony Liguori
On 09/08/2011 05:07 AM, Avi Kivity wrote: On 09/07/2011 09:44 PM, Anthony Liguori wrote: I think this is a bit more complicated than is really needed. Here's what I came up with which also fixes another bug where the io channel could be freed twice. I stumbled across this via a very strange

Re: [Qemu-devel] [PULL 0/3] Trivial patches for Auguest 25 to September 2 2011

2011-09-08 Thread Stefan Hajnoczi
On Fri, Sep 2, 2011 at 11:12 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: The following changes since commit 625f9e1f54cd78ee98ac22030da527c9a1cc9d2b:  Merge remote-tracking branch 'stefanha/trivial-patches' into staging (2011-09-01 13:57:19 -0500) are available in the git

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2011 at 08:11:00AM -0400, Stefan Berger wrote: On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01, 2011 at 10:23:51PM -0400, Stefan Berger wrote: An

Re: [Qemu-devel] CFQ I/O starvation problem triggered by RHEL6.0 KVM guests

2011-09-08 Thread Vivek Goyal
On Thu, Sep 08, 2011 at 06:13:53PM +0900, Takuya Yoshikawa wrote: This is a report of strange cfq behaviour which seems to be triggered by QEMU posix aio threads. Host environment: OS: RHEL6.0 KVM/qemu-kvm (with no patch applied) IO scheduler: cfq (with the default parameters) So you

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-08 Thread Kevin Wolf
Am 08.09.2011 01:06, schrieb Yehuda Sadeh: The following set of patches improve the qemu-img conversion process performance. When using a higher latency backend, small writes have a severe impact on the time it takes to do image conversion. We switch to using async writes, and we avoid

Re: [Qemu-devel] [PATCH] target-i386: Compute all flag data inside %cl != 0 test.

2011-09-08 Thread malc
On Thu, 8 Sep 2011, Richard Henderson wrote: The (x (cl - 1)) quantity is only used if CL != 0. Move the computation of that quantity nearer its use. This avoids the creation of undefined TCG operations when the constant propagation optimization proves that CL == 0, and thus CL-1 is

Re: [Qemu-devel] [PULL] File descriptor reclaim patchset for VirtFS

2011-09-08 Thread Anthony Liguori
On 09/01/2011 12:25 PM, Aneesh Kumar K.V wrote: The following changes since commit 56a7a874e962e28522857fbf72eaefb1a07e2001: Merge remote-tracking branch 'stefanha/trivial-patches' into staging (2011-08-25 07:50:07 -0500) are available in the git repository at:

Re: [Qemu-devel] [PULL] usb patch queue

2011-09-08 Thread Anthony Liguori
On 09/02/2011 04:56 AM, Gerd Hoffmann wrote: Hi, This is the current use patch queue with the following changes: * musb improvements (qdev windup) * fix ehci emulation for FreeBSD guests. * a bunch if usb-host fixes. * misc minir tweaks. please pull, Gerd Pulled. Thanks.

Re: [Qemu-devel] [PULL] Memory API batch 5, v2

2011-09-08 Thread Anthony Liguori
On 09/04/2011 10:28 AM, Avi Kivity wrote: Please pull from git://github.com/avikivity/qemu.git memory/batch v2: just a rebase to make sure bisects see the rom_device fix. Pulled. Thanks. Regards, Anthony Liguori Avi Kivity (22): mips_fulong2e: convert to memory API stellaris_enet:

Re: [Qemu-devel] [PULL 00/31] Block patches

2011-09-08 Thread Anthony Liguori
On 09/06/2011 10:39 AM, Kevin Wolf wrote: The following changes since commit f69539b14bdba7a5cd22e1f4bed439b476b17286: apb_pci: convert PCI space to memory API (2011-09-04 09:28:04 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled.

Re: [Qemu-devel] [PULL] spice patch queue

2011-09-08 Thread Anthony Liguori
On 09/07/2011 02:38 AM, Gerd Hoffmann wrote: Hi, Here is the spice patch queue with a collection of bugfixes. A workaround for the much discussed spice-calls-us-from-wrong-thread issue is included because it turned out to be not *that* easily fixable in spice so it will probably take some

Re: [Qemu-devel] [PULL 0/2]: QMP queue

2011-09-08 Thread Anthony Liguori
On 09/06/2011 11:44 AM, Luiz Capitulino wrote: Anthony, The following patches have been sent to the list and look good to me. I've also tested them. Pulled. Thanks. Regards, Anthony Liguori The changes (since 344eecf6995f4a0ad1d887cec922f6806f91a3f8) are available in the following

Re: [Qemu-devel] [PULL 0/3] Trivial patches for Auguest 25 to September 2 2011

2011-09-08 Thread Anthony Liguori
On 09/02/2011 05:12 AM, Stefan Hajnoczi wrote: The following changes since commit 625f9e1f54cd78ee98ac22030da527c9a1cc9d2b: Merge remote-tracking branch 'stefanha/trivial-patches' into staging (2011-09-01 13:57:19 -0500) are available in the git repository at:

Re: [Qemu-devel] [PATCH] s390: remove boot image detection to fix boot with newer kernels

2011-09-08 Thread Christian Borntraeger
On 07/09/11 14:34, Alexander Graf wrote: No, in theory it could change arbitrarily. The vmlinux case is unfortunate but in the end its shoot yourself in the foot, we just have to make sure that we allow a graceful exit from a looping qemu guest. That's not the answer I'd like to hear. Can't

[Qemu-devel] [PATCH] Flexible array should be last in struct mbuf

2011-09-08 Thread Elie Richa
The flexible array member should remain the last member in the structure as this assumption is based upon in the code. Signed-off-by: Elie Richa ri...@adacore.com --- slirp/mbuf.h |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/slirp/mbuf.h b/slirp/mbuf.h index

[Qemu-devel] [PATCH 00/12] nbd improvements

2011-09-08 Thread Paolo Bonzini
I find nbd quite useful to test migration, but it is limited: it can only do synchronous operation, it is not safe because it does not support flush, and it has no discard either. qemu-nbd is also limited to 1MB requests, and the nbd block driver does not take this into account. Luckily,

[Qemu-devel] [PATCH 06/12] nbd: support NBD_CMD_TRIM in the server

2011-09-08 Thread Paolo Bonzini
Map it to bdrv_discard. The server can now expose NBD_FLAG_SEND_TRIM. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c | 31 +++ nbd.c |9 - 2 files changed, 39 insertions(+), 1 deletions(-) diff --git a/block/nbd.c b/block/nbd.c

[Qemu-devel] [PATCH 12/12] nbd: split requests

2011-09-08 Thread Paolo Bonzini
qemu-nbd has a limit of slightly less than 1M per request. Work around this in the nbd block driver. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c | 52 ++-- 1 files changed, 46 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 11/12] nbd: switch to asynchronous operation

2011-09-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c | 167 ++ nbd.c |8 +++ 2 files changed, 117 insertions(+), 58 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 964caa8..5a75263 100644 --- a/block/nbd.c

Re: [Qemu-devel] [PATCH V8 10/14] Encrypt state blobs using AES CBC encryption

2011-09-08 Thread Stefan Berger
On 09/08/2011 09:16 AM, Michael S. Tsirkin wrote: On Thu, Sep 08, 2011 at 08:11:00AM -0400, Stefan Berger wrote: On 09/08/2011 06:32 AM, Michael S. Tsirkin wrote: On Wed, Sep 07, 2011 at 08:16:27PM -0400, Stefan Berger wrote: On 09/07/2011 02:55 PM, Michael S. Tsirkin wrote: On Thu, Sep 01,

[Qemu-devel] [PATCH 09/12] sheepdog: move coroutine send/recv function to generic code

2011-09-08 Thread Paolo Bonzini
Outside coroutines, avoid busy waiting on EAGAIN by temporarily making the socket blocking. The API of qemu_recvv/qemu_sendv is slightly different from do_readv/do_writev because they do not handle coroutines. It returns the number of bytes written before encountering an EAGAIN. The specificity

[Qemu-devel] [PATCH 10/12] block: add bdrv_co_flush support

2011-09-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 53 ++--- block_int.h |1 + 2 files changed, 43 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index 43742b7..3f32f75 100644 --- a/block.c +++ b/block.c @@

[Qemu-devel] [PATCH 07/12] sheepdog: add coroutine_fn markers

2011-09-08 Thread Paolo Bonzini
This makes the following patch easier to review. Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/sheepdog.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

[Qemu-devel] [PATCH 04/12] nbd: add support for NBD_CMD_FLUSH

2011-09-08 Thread Paolo Bonzini
Note for the brace police: the style in this commit and the following is consistent with the rest of the file. It is then fixed together with the introduction of coroutines. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c | 31 +++ nbd.c |

[Qemu-devel] [PATCH 05/12] nbd: add support for NBD_CMD_FLAG_FUA

2011-09-08 Thread Paolo Bonzini
The server can use it to issue a flush automatically after a write. The client can also use it to mimic a write-through cache. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c |8 nbd.c | 13 +++-- 2 files changed, 19 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 03/12] nbd: support NBD_SET_FLAGS ioctl

2011-09-08 Thread Paolo Bonzini
The nbd kernel module cannot enable DISCARD requests unless it is informed about it. The flags field in the header is used for this, and this patch adds support for it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- nbd.c |8 1 files changed, 8 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH 01/12] nbd: support feature negotiation

2011-09-08 Thread Paolo Bonzini
nbd supports writing flags in bytes 24...27 of the header, and uses that for the read-only flag. Add support for it in qemu-nbd. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block/nbd.c |4 ++-- nbd.c | 32 +--- nbd.h |9 ++---

[Qemu-devel] [PATCH 08/12] add socket_set_block

2011-09-08 Thread Paolo Bonzini
Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- oslib-posix.c |7 +++ oslib-win32.c |6 ++ qemu_socket.h |1 + 3 files changed, 14 insertions(+), 0 deletions(-) diff --git a/oslib-posix.c b/oslib-posix.c index

[Qemu-devel] [PATCH] Fix include statements for qemu-common.h

2011-09-08 Thread Stefan Weil
* qemu-common.h is not a system include file, so it should be included with instead of . Otherwise incremental builds might fail because only local include files are checked for changes. * linux-user/syscall.c included the file twice. Cc: Kevin Wolf kw...@redhat.com Cc: Riku Voipio

Re: [Qemu-devel] [PATCH] virtio-9p: Fix syntax error in debug code

2011-09-08 Thread Stefan Weil
Am 20.07.2011 11:44, schrieb Aneesh Kumar K.V: On Wed, 20 Jul 2011 08:27:28 +0200, Stefan Weil w...@mail.berlios.de wrote: This error was reported by cppcheck: qemu/hw/9pfs/virtio-9p-debug.c:342: error: Invalid number of character ({) when these macros are defined: 'DEBUG_DATA'. Cc: Aneesh

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-08 Thread Sage Weil
On Thu, 8 Sep 2011, Kevin Wolf wrote: Am 08.09.2011 01:06, schrieb Yehuda Sadeh: The following set of patches improve the qemu-img conversion process performance. When using a higher latency backend, small writes have a severe impact on the time it takes to do image conversion. We switch

Re: [Qemu-devel] [PATCH v4 24/39] ppc: convert to memory API

2011-09-08 Thread Alexander Graf
[dropping kvm@vger because my mail server refuses to send mails there] On 08.08.2011, at 15:09, Avi Kivity wrote: Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/cuda.c |6 ++-

Re: [Qemu-devel] [PATCH v4 24/39] ppc: convert to memory API

2011-09-08 Thread Alexander Graf
On 08.08.2011, at 15:09, Avi Kivity wrote: Reviewed-by: Richard Henderson r...@twiddle.net Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/cuda.c |6 ++- hw/escc.c | 42 +-- hw/escc.h |

[Qemu-devel] [PATCH] PPC: Fix via-cuda memory registration

2011-09-08 Thread Alexander Graf
Commit 23c5e4ca (convert to memory API) broke the VIA Cuda emulation layer by not registering the IO structs. This patch registers them properly and thus makes -M g3beige and -M mac99 work again. Signed-off-by: Alexander Graf ag...@suse.de --- PS: Please test your patches. This one could have

Re: [Qemu-devel] [PATCH v2] Fix X86 CPU topology in KVM mode

2011-09-08 Thread Jan Kiszka
On 2011-09-08 07:33, bharata@gmail.com wrote: From: Bharata B Rao bharata@gmail.com apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State-cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken

[Qemu-devel] unable to access the serial port on the Vm

2011-09-08 Thread bala suru
Hi, I'm running one VM on the Qemu hypervisor. I'm tried too access the /dev/ttyS0 from the VM, but I cant access that ,. it shows input out error . i.e when I do $cat /dev/ttyS0 - it gives input output error . what may be the problem .. pls help

Re: [Qemu-devel] [PATCH] KVM: emulate lapic tsc deadline timer for hvm

2011-09-08 Thread Liu, Jinsong
--- a/arch/x86/include/asm/msr-index.h +++ b/arch/x86/include/asm/msr-index.h @@ -229,6 +229,8 @@ #define MSR_IA32_APICBASE_ENABLE (111) #define MSR_IA32_APICBASE_BASE (0xf12) +#define MSR_IA32_TSCDEADLINE 0x06e0 + #define MSR_IA32_UCODE_WRITE

[Qemu-devel] [PATCH] ahci: Remove unused struct member

2011-09-08 Thread Stefan Weil
Member variable is_read is written, but never read (contrary to its name). Remove it. Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/ide/ahci.c |2 -- hw/ide/ahci.h |1 - 2 files changed, 0 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c

Re: [Qemu-devel] [RFC PATCH 4/5] VFIO: Add PCI device support

2011-09-08 Thread Alex Williamson
On Thu, 2011-09-08 at 10:52 +0300, Avi Kivity wrote: On 09/07/2011 09:55 PM, Konrad Rzeszutek Wilk wrote: If you don't know what to do here, say N. + +menuconfig VFIO_PCI +bool VFIO support for PCI devices +depends on VFIO PCI +default y

Re: [Qemu-devel] [RFC PATCH 0/5] VFIO-NG group/device/iommu framework

2011-09-08 Thread Alex Williamson
On Wed, 2011-09-07 at 13:58 +0200, Alexander Graf wrote: On 01.09.2011, at 21:50, Alex Williamson wrote: Trying to move beyond talking about how VFIO should work to re-writing the code. This is pre-alpha, known broken, will probably crash your system but it illustrates some of how I

[Qemu-devel] [PATCH] ARM7TDMI: Enable ARMv4T features

2011-09-08 Thread Marek Vasut
Signed-off-by: Marek Vasut marek.va...@gmail.com --- target-arm/helper.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 58cd99f..2f3e937 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -53,6 +53,7 @@ static

[Qemu-devel] DEMANDE DE DEVIS POUR

2011-09-08 Thread VOTRE
Nous sommes là pour vous faire bénéficier d’une étude GRATUITE et sans engagement de votre part pour l’installation de: • Climatisation réversible, • solaire sur toiture • solaire pour chauffer une piscine etc… • Isolation thermique des combles • Adoucisseur d’eau • L’énergie

[Qemu-devel] [Bug 824650] Re: Latest GIT assert error in arp_table.c

2011-09-08 Thread Nigel Horne
No - that's not relevant. The latest git (07ff2c4475df77e38a31d50ee7f3932631806c15) still crashes after just a couple of minutes with just about any guest on a Linux host. These are the args for my FreeBSD guest: qemu-system-i386 -drive file=freebsd8.1-i386,index=0,media=disk,cache=unsafe

[Qemu-devel] [PATCH] SPARC: Trivial patch to clean up npc monitor output

2011-09-08 Thread Nathan Kunkee
This patch fixes the spacing of the PC and NPC output from 'info cpus' for SPARC. Signed-off-by: Nathan Kunkee nkunke...@hotmail.com diff --git a/monitor.c b/monitor.c index 1b8ba2c..16cd4c5 100644 --- a/monitor.c +++ b/monitor.c @@ -884,9 +884,9 @@ static void print_cpu_iter(QObject *obj,

Re: [Qemu-devel] [PATCH 0/2] improve qemu-img conversion performance

2011-09-08 Thread Sage Weil
On Thu, 8 Sep 2011, Stefan Hajnoczi wrote: On Wed, Sep 07, 2011 at 04:06:51PM -0700, Yehuda Sadeh wrote: The following set of patches improve the qemu-img conversion process performance. When using a higher latency backend, small writes have a severe impact on the time it takes to do image

Re: [Qemu-devel] [PATCH 09/12] sheepdog: move coroutine send/recv function to generic code

2011-09-08 Thread MORITA Kazutaka
At Thu, 8 Sep 2011 17:25:02 +0200, Paolo Bonzini wrote: Outside coroutines, avoid busy waiting on EAGAIN by temporarily making the socket blocking. The API of qemu_recvv/qemu_sendv is slightly different from do_readv/do_writev because they do not handle coroutines. It returns the number

Re: [Qemu-devel] [PATCH] pci: Remove unused pci_reserve_capability

2011-09-08 Thread Michael S. Tsirkin
On Thu, Sep 08, 2011 at 12:44:47PM +0200, Jan Kiszka wrote: eepro100 was the last user. Now pci_add_capability is powerful enough. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Applied, thanks. --- hw/pci.c |6 -- hw/pci.h |2 -- 2 files changed, 0 insertions(+), 8

[Qemu-devel] [PATCH] support add-cow file format

2011-09-08 Thread Dong Xu Wang
As raw file format does not support backing_file and copy on write feature, so I add COW to it to support backing_file option. I store dirty bitmap in an add-cow file. When executed, it looks like this: qemu-img create -f add-cow -o backing_file=ubuntu.img,image_file=test.img test.add-cow qemu

[Qemu-devel] [PATCH] tcg/ppc64: Fix zero extension code generation bug for ppc64 host

2011-09-08 Thread David Gibson
From: Thomas Huth th...@de.ibm.com The ppc64 code generation backend uses an rldicr (Rotate Left Double Immediate and Clear Right) instruction to implement zero extension of a 32 bit quantity to a 64 bit quantity (INDEX_op_ext32u_i64). However this is wrong - this instruction clears specified