[Qemu-devel] [PATCH 1/1 V4] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
On 10/14/2011 01:53 PM, Jan Kiszka wrote: On 2011-10-14 02:53, Lai Jiangshan wrote: As explained in some other mail, we could then emulate the missing kernel feature by reading out the current in-kernel APIC state, testing if LINT1 is unmasked, and then delivering the NMI directly. Only

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-14 Thread David Gibson
On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: On 14.10.2011, at 07:19, David Gibson wrote: In __cpu_ppc_store_decr(), we set up a regular timer used to trigger decrementer interrupts. This is necessary to implement the decrementer properly under TCG, but is

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-14 Thread Alexander Graf
On 14.10.2011, at 08:36, David Gibson wrote: On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: On 14.10.2011, at 07:19, David Gibson wrote: In __cpu_ppc_store_decr(), we set up a regular timer used to trigger decrementer interrupts. This is necessary to implement the

Re: [Qemu-devel] [PATCH v2 1/2] Introduce QLIST_INSERT_HEAD_RCU and dummy RCU wrappers.

2011-10-14 Thread Paolo Bonzini
On 10/13/2011 10:35 PM, Harsh Prateek Bora wrote: +#define QLIST_INSERT_HEAD_RCU(head, elm, field) do {\ +(elm)-field.le_prev =(head)-lh_first; \ +smp_wmb(); \ +if

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-14 Thread David Gibson
On Fri, Oct 14, 2011 at 08:44:06AM +0200, Alexander Graf wrote: On 14.10.2011, at 08:36, David Gibson wrote: On Fri, Oct 14, 2011 at 07:30:09AM +0200, Alexander Graf wrote: On 14.10.2011, at 07:19, David Gibson wrote: In __cpu_ppc_store_decr(), we set up a regular timer used to

Re: [Qemu-devel] [PATCH 1/1 V4] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 08:36, Lai Jiangshan wrote: On 10/14/2011 01:53 PM, Jan Kiszka wrote: On 2011-10-14 02:53, Lai Jiangshan wrote: As explained in some other mail, we could then emulate the missing kernel feature by reading out the current in-kernel APIC state, testing if LINT1 is unmasked, and

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Paolo Bonzini
On 10/13/2011 10:26 PM, Luiz Capitulino wrote: I'm going to take my word back on this one, I've found the real cause of the problem. Will post the patch right now. Are you keeping the vl.c hunks though? Paolo

[Qemu-devel] [PATCH] correct spelling

2011-10-14 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index c1f6e07..ae857e2 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -66,7 +66,7 @@ * 20 - 31 (12

Re: [Qemu-devel] [PATCH 1/1 V4] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
On 10/14/2011 02:49 PM, Jan Kiszka wrote: On 2011-10-14 08:36, Lai Jiangshan wrote: On 10/14/2011 01:53 PM, Jan Kiszka wrote: On 2011-10-14 02:53, Lai Jiangshan wrote: As explained in some other mail, we could then emulate the missing kernel feature by reading out the current in-kernel APIC

Re: [Qemu-devel] [PATCH] linux-aio: Allow reads beyond the end of growable images

2011-10-14 Thread Christoph Hellwig
On Thu, Oct 13, 2011 at 03:49:39PM +0200, Kevin Wolf wrote: This is the linux-aio version of commits 22afa7b5 (raw-posix, synchronous) and ba1d1afd (posix-aio-compat). Reads now produce zeros after the end of file instead of failing or resulting in short reads, making linux-aio compatible with

Re: [Qemu-devel] [PATCH 1/1 V4] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 09:43, Lai Jiangshan wrote: On 10/14/2011 02:49 PM, Jan Kiszka wrote: On 2011-10-14 08:36, Lai Jiangshan wrote: On 10/14/2011 01:53 PM, Jan Kiszka wrote: On 2011-10-14 02:53, Lai Jiangshan wrote: As explained in some other mail, we could then emulate the missing kernel

[Qemu-devel] [PATCH 0/4] coroutinization of flush and discard (split out of NBD series)

2011-10-14 Thread Paolo Bonzini
Thanks to Stefan's series from today, I managed to understand what the coroutinization was all about. So I split this part out of the NBD series. Applies on top of block branch + the other five patches. Paolo Bonzini (3): block: rename bdrv_co_rw_bh block: unify flush implementations

[Qemu-devel] [PATCH 1/4] block: rename bdrv_co_rw_bh

2011-10-14 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 9873b57..7184a0f 100644 --- a/block.c +++ b/block.c @@ -2735,7 +2735,7 @@ static AIOPool bdrv_em_co_aio_pool = { .cancel

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-14 Thread Kevin Wolf
Am 13.10.2011 22:27, schrieb Luiz Capitulino: qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM

[Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Paolo Bonzini
Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplified to always go through a coroutine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- block.c | 160 ++-

[Qemu-devel] [PATCH 1/2 V5] qemu-kvm: Synchronize kernel headers

2011-10-14 Thread Lai Jiangshan
Synchronize newest kernel headers which have KVM_CAP_SET_LINT1 and KVM_SET_LINT1 by ./scripts/update-linux-headers.sh Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- linux-headers/asm-powerpc/kvm.h | 19 +-- linux-headers/asm-x86/kvm.h |1 +

[Qemu-devel] [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is masked in LVT. For example, this causes the problem that

[Qemu-devel] [PATCH 2/2 V5] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is masked in LVT. For example, this causes the problem that

[Qemu-devel] [PATCH 3/4] block: drop redundant bdrv_flush implementation

2011-10-14 Thread Paolo Bonzini
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Block drivers now only need to provide either of .bdrv_co_flush, .bdrv_aio_flush() or for legacy drivers .bdrv_flush(). Remove the redundant .bdrv_flush() and, for the raw driver, replace the asynchronous operation with the coroutine-based one.

[Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-14 Thread Paolo Bonzini
This similarly adds support for coroutine and asynchronous discard. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- I was not sure if qcow2 could be changed to co_discard, though I suspected yes. block.c | 72 +-

Re: [Qemu-devel] [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 11:03, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is masked in

Re: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd

2011-10-14 Thread Stefan Hajnoczi
On Thu, Oct 13, 2011 at 06:45:37PM +0100, Peter Maydell wrote: Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- compatfd.c | 12 ++-- 1 files

[Qemu-devel] [0/12] Preliminary work for IOMMU emulation support (v2)

2011-10-14 Thread David Gibson
A while back, Eduard - Gabriel Munteanu send a series of patches implementing support for emulating the AMD IOMMU in conjunction with qemu emulated PCI devices. A revised patch series added support for the Intel IOMMU, and I also send a revised version of this series which added support for the

[Qemu-devel] [PATCH 06/12] e1000: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the e1000 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

[Qemu-devel] [PATCH 05/12] es1370: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the es1370 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

[Qemu-devel] [PATCH 07/12] lsi53c895a: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the lsi53c895a device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

Re: [Qemu-devel] [0/12] Preliminary work for IOMMU emulation support (v2)

2011-10-14 Thread David Gibson
On Fri, Oct 14, 2011 at 08:20:51PM +1100, David Gibson wrote: A while back, Eduard - Gabriel Munteanu send a series of patches implementing support for emulating the AMD IOMMU in conjunction with qemu emulated PCI devices. A revised patch series added support for the Intel IOMMU, and I also

Re: [Qemu-devel] [PATCH] correct spelling

2011-10-14 Thread Andreas Färber
[cc'ing qemu-trivial] A one-line summary here and a topic like sheepdog: in the subject would've been nice but given it's just a typo fix... :) Am 14.10.2011 09:41, schrieb Dong Xu Wang: Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block/sheepdog.c |2 +- 1 files changed,

Re: [Qemu-devel] [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
On 10/14/2011 05:07 PM, Jan Kiszka wrote: On 2011-10-14 11:03, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to

Re: [Qemu-devel] [PATCH 2/2 V5] qemu-kvm: fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 11:03, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is masked in

Re: [Qemu-devel] [PATCH 1/1 V5] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 11:27, Lai Jiangshan wrote: On 10/14/2011 05:07 PM, Jan Kiszka wrote: On 2011-10-14 11:03, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers

[Qemu-devel] [PATCH] usb-hub: wakeup on attach

2011-10-14 Thread Gerd Hoffmann
When attaching a new device we must send a wakeup request to the root hub, otherwise the guest will not notice the new device in case the usb hub is suspended. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-hub.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 11/12] usb-ehci: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
This updates the usb-ehci device emulation to use the explicit PCI DMA wrapper to initialize its scatter/gathjer structure. This means this driver should not need further changes when the sglist interface is extended to support IOMMUs. Signed-off-by: David Gibson da...@gibson.dropbear.id.au ---

[Qemu-devel] [PATCH 01/12] Add stub functions for PCI device models to do PCI DMA

2011-10-14 Thread David Gibson
From: Alexey Kardashevskiy a...@ozlabs.ru This patch adds functions to pci.[ch] to perform PCI DMA operations. At present, these are just stubs which perform directly cpu physical memory accesses. Stubs are included which are analogous to cpu_physical_memory_{read,write}(), the stX_phys() and

Re: [Qemu-devel] [PATCH v3 03/15] add qemu_send_full and qemu_recv_full

2011-10-14 Thread Kevin Wolf
Am 05.10.2011 09:17, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- osdep.c | 67 + qemu-common.h |4 +++ 2 files changed, 71 insertions(+), 0 deletions(-) diff --git a/osdep.c b/osdep.c

[Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Lai Jiangshan
Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1 is masked in LVT. For example, this causes the problem that

[Qemu-devel] [PATCH 1/2 V5 tuning] qemu-kvm: Synchronize kernel headers

2011-10-14 Thread Lai Jiangshan
Synchronize newest kernel headers which have KVM_CAP_SET_LINT1 and KVM_SET_LINT1 by ./scripts/update-linux-headers.sh Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- linux-headers/asm-powerpc/kvm.h | 19 +-- linux-headers/asm-x86/kvm_para.h | 14

Re: [Qemu-devel] balloon driver on winxp guest start failed

2011-10-14 Thread hkran
On 10/14/2011 04:55 AM, Vadim Rozenfeld wrote: On Thu, 2011-10-13 at 15:47 +0100, Stefan Hajnoczi wrote: On Thu, Oct 13, 2011 at 5:00 AM, hkranhk...@vnet.linux.ibm.com wrote: On 10/12/2011 07:09 PM, hkran wrote: I used balloon driver for windows virtio-win-0.1-15.iso (from

Re: [Qemu-devel] [PATCH 0/5] block: remove unused emulation and synchronous functions

2011-10-14 Thread Kevin Wolf
Am 13.10.2011 22:09, schrieb Stefan Hajnoczi: Now that the block layer processes requests in coroutine context, some of the emulation wrappers and duplicate code paths can be dropped. Paraphrasing a wise man, Arnold Schwarzenegger, I will go to the block layer and I will clean house :).

[Qemu-devel] [PATCH 09/12] intel-hda: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
This updates the intel-hda device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: David Gibson da...@gibson.dropbear.id.au Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/intel-hda.c | 14 +++--- 1

[Qemu-devel] [PATCH 03/12] eepro100: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

[Qemu-devel] [PATCH 04/12] ac97: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the ac97 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David Gibson

[Qemu-devel] [PATCH 12/12] usb-uhci: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
This updates the usb-uhci device emulation to use the explicit PCI DMA wrapper to initialize its scatter/gathjer structure. This means this driver should not need further changes when the sglist interface is extended to support IOMMUs. Signed-off-by: David Gibson da...@gibson.dropbear.id.au ---

[Qemu-devel] [PATCH 02/12] rtl8139: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the rtl8139 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

Re: [Qemu-devel] [PATCH v3 03/15] add qemu_send_full and qemu_recv_full

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 11:52 AM, Kevin Wolf wrote: Am 05.10.2011 09:17, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- osdep.c | 67 + qemu-common.h |4 +++ 2 files changed, 71 insertions(+), 0

[Qemu-devel] [PATCH 08/12] pcnet-pci: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro This updates the pcnet-pci device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro Signed-off-by: David

[Qemu-devel] [PATCH 10/12] PCI IDE: Use PCI DMA stub functions

2011-10-14 Thread David Gibson
This updates the PCI IDE device emulation to use the explicit PCI DMA wrapper to initialize its scatter/gathjer structure. This means this driver should not need further changes when the sglist interface is extended to support IOMMUs. Signed-off-by: David Gibson da...@gibson.dropbear.id.au ---

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-14 Thread Alexey Starikovskiy
** Patch added: fix for the problem https://bugs.launchpad.net/bugs/874038/+attachment/2542719/+files/fix_carry_in_thumb2 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/874038 Title: ARM thumb2

[Qemu-devel] [Bug 874038] [NEW] ARM thumb2 does not propogate carry flag properly

2011-10-14 Thread Alexey Starikovskiy
Public bug reported: information on carry flag is lost if gen_set_CF_bit31(t1) is called after logic operation. ** Affects: qemu Importance: Undecided Status: New ** Tags: arm flags -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [v7 Patch 1/5]Qemu: Enhance info block to display host cache setting

2011-10-14 Thread Supriya Kannery
On 10/12/2011 07:47 PM, Kevin Wolf wrote: Am 11.10.2011 05:10, schrieb Supriya Kannery: Enhance info block to display hostcache setting for each block device. +if (qdict_haskey(bs_dict, open_flags)) { +int open_flags = qdict_get_int(bs_dict, open_flags); +if (open_flags

[Qemu-devel] [PATCH] rtl8139: check the buffer availiability

2011-10-14 Thread Jason Wang
Reduce spurious packet drops on RX ring empty when in c+ mode by verifying that we have at least 1 buffer ahead of the time. Signed-off-by: Jason Wang jasow...@redhat.com --- hw/rtl8139.c | 43 +-- 1 files changed, 29 insertions(+), 14 deletions(-) diff

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplified to always go through a coroutine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com To make the implementation more

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

2011-10-14 Thread Stefan Hajnoczi
On Tue, Oct 11, 2011 at 08:41:59AM +0530, Supriya Kannery wrote: Index: qemu/block.c === --- qemu.orig/block.c +++ qemu/block.c @@ -706,6 +706,7 @@ int bdrv_reopen(BlockDriverState *bs, in { BlockDriver *drv = bs-drv;

[Qemu-devel] website

2011-10-14 Thread ronnie sahlberg
http://wiki.qemu.org/Main_Page Someone may want to have a look over the website, the links in the Contribute section in the column on the left. All pages seem to primarily discuss the quality of Pandora jewelry and how beneficial it would be to purchase such.

Re: [Qemu-devel] [v7 Patch 4/5]Qemu: Add commandline -drive option 'hostcache'

2011-10-14 Thread Supriya Kannery
On 10/12/2011 08:00 PM, Kevin Wolf wrote: Am 11.10.2011 05:11, schrieb Supriya Kannery: qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache usage for block data access. Simultaneous use of

Re: [Qemu-devel] [v7 Patch 4/5]Qemu: Add commandline -drive option 'hostcache'

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 13:19, schrieb Supriya Kannery: On 10/12/2011 08:00 PM, Kevin Wolf wrote: Am 11.10.2011 05:11, schrieb Supriya Kannery: qemu command option 'hostcache' added to -drive for block devices. While starting a VM from qemu commandline, this option can be used for setting host cache

Re: [Qemu-devel] [PATCH] savevm: qemu_savevm_state(): Drop stop VM logic

2011-10-14 Thread Juan Quintela
Luiz Capitulino lcapitul...@redhat.com wrote: qemu_savevm_state() has some logic to stop the VM and to (or not to) resume it. But this seems to be a big noop, as qemu_savevm_state() is only called by do_savevm() when the VM is already stopped. So, let's drop qemu_savevm_state()'s stop VM

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplified to always go through a coroutine. Signed-off-by: Paolo Bonzinipbonz...@redhat.com

Re: [Qemu-devel] website

2011-10-14 Thread 陳韋任
http://wiki.qemu.org/Main_Page Someone may want to have a look over the website, the links in the Contribute section in the column on the left. All pages seem to primarily discuss the quality of Pandora jewelry and how beneficial it would be to purchase such. Jcmvbkbc and I have reverted

Re: [Qemu-devel] [PATCH 2/2] hda: do not mix output and input stream states, RHBZ #740493

2011-10-14 Thread Gerd Hoffmann
Hi, a) My understanding of this patch is that we move from an array of 16 bools representing anything to one array where the 1st 16 represent if there are input and the 2nd 16's reprosenting if there are output for that channel. Correct. So, what we should do if we migrate from one old

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 13:30, schrieb Paolo Bonzini: On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is simplified to always go through a coroutine.

Re: [Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Sasha Levin
On Fri, 2011-10-14 at 17:51 +0800, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is sent to the processor even when LINT1

[Qemu-devel] [PATCH] hw/9pfs: Handle Security model parsing

2011-10-14 Thread M. Mohan Kumar
Except local fs driver other fs drivers (handle) don't need security model. Update fsdev parameter parsing accordingly. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- fsdev/qemu-fsdev.c | 26 +- qemu-options.hx| 12 vl.c |6

Re: [Qemu-devel] [PATCH 1/1 V5 tuning] kernel/kvm: introduce KVM_SET_LINT1 and fix improper nmi emulation

2011-10-14 Thread Jan Kiszka
On 2011-10-14 13:59, Sasha Levin wrote: On Fri, 2011-10-14 at 17:51 +0800, Lai Jiangshan wrote: Currently, NMI interrupt is blindly sent to all the vCPUs when NMI button event happens. This doesn't properly emulate real hardware on which NMI button event triggers LINT1. Because of this, NMI is

Re: [Qemu-devel] [PATCH 0/6] trace: Add support for trace events grouping

2011-10-14 Thread Stefan Hajnoczi
On Thu, Oct 13, 2011 at 04:10:56PM +0800, Mark Wu wrote: On 10/13/2011 01:14 AM, Mark Wu wrote: This series add support for trace events grouping. The state of a given group of trace events can be queried or changed in bulk by the following monitor commands: * info trace-groups View

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2011-10-14 Thread Peter Maydell
On 13 October 2011 23:23, Andreas Färber andreas.faer...@web.de wrote: Am 13.10.2011 16:26, schrieb Andreas Färber: Am 12.10.2011 18:21, schrieb Peter Maydell: Improve the configure test for presence of ucontext functions by making linker warnings fatal; this allows us to detect when we are

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 01:54 PM, Kevin Wolf wrote: Am 14.10.2011 13:30, schrieb Paolo Bonzini: On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already do for read/write. bdrv_aio_flush is

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 02:30 PM, Peter Maydell wrote: I've also just discovered that it's no use on Oneiric, where the linker warning has gone away but the syscall still always returns ENOSYS. I think we should just always use the gthread implementation rather than preferring a

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 02:47 PM, Paolo Bonzini wrote: A user-space longjmp will always be slower than a mutex+condvar+context switch. Gah, I obviously meant faster. :) Paolo

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

2011-10-14 Thread Peter Maydell
The existing code looks OK to me -- there's no need to call gen_set_CF_bit31() early because the inputs t0 and t1 to gen_thumb2_data_op() should always be distinct TCG values, and so gen_thumb2_data_op() will never trash t1. (There was a bug in this area involving ORN, but that was fixed in rev

Re: [Qemu-devel] [PATCH 0/2] spice migration interface (RHBZ 737921)

2011-10-14 Thread Gerd Hoffmann
Hi, Yonit Halperin (2): spice: turn client_migrate_info to async spice: support the new migration interface (spice 0.8.3) Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] qxl: create slots on post_load in any state (fix RHBZ 740547)

2011-10-14 Thread Gerd Hoffmann
On 09/22/11 14:33, Alon Levy wrote: If we migrate when the device is not in a native state the guest still believes the slots are created, and will cause operations that reference the slots, causing a panic: virtual address out of range on the first of them. Easy to see by migrating in vga mode

Re: [Qemu-devel] [PATCH] configure: Detect when glibc implements makecontext() to always fail

2011-10-14 Thread Peter Maydell
On 14 October 2011 13:55, Paolo Bonzini pbonz...@redhat.com wrote: On 10/14/2011 02:47 PM, Paolo Bonzini wrote: A user-space longjmp will always be slower than a mutex+condvar+context switch. Gah, I obviously meant faster. :) Ah, I hadn't actually looked at the coroutine-gthread.c code, and

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Stefan Hajnoczi
On Fri, Oct 14, 2011 at 01:54:42PM +0200, Kevin Wolf wrote: Am 14.10.2011 13:30, schrieb Paolo Bonzini: On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Let me show how this might go. Right now you have bdrv_read/write -

Re: [Qemu-devel] [PATCH] ui/spice-core: fix segfault in monitor

2011-10-14 Thread Gerd Hoffmann
On 10/04/11 13:25, Alon Levy wrote: Fix segfault if a qxl device is present but no spice command line argument is given. RHBZ 743251. Added to spice patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Luiz Capitulino
On Fri, 14 Oct 2011 08:56:57 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/13/2011 10:26 PM, Luiz Capitulino wrote: I'm going to take my word back on this one, I've found the real cause of the problem. Will post the patch right now. Are you keeping the vl.c hunks though? I'm

[Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Dmitry Koshelev
Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index 8286a28..ba05131 100644 ---

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 03:23 PM, Luiz Capitulino wrote: I'm not, because I'm assuming that allowing a transition from 'paused' to 'postmigrate' plus this fix: http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg01430.html I think POST_MIGRATE - FINISH_MIGRATE should be still allowed in case you

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

2011-10-14 Thread Supriya Kannery
On 10/12/2011 08:25 PM, Kevin Wolf wrote: Am 11.10.2011 05:11, schrieb Supriya Kannery: Struct BDRVReopenState introduced for handling reopen state of images. This can be extended by each of the block drivers to reopen respective image files. Implementation for raw-posix is done here.

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

2011-10-14 Thread Supriya Kannery
On 10/14/2011 04:43 PM, Stefan Hajnoczi wrote: On Tue, Oct 11, 2011 at 08:41:59AM +0530, Supriya Kannery wrote: Index: qemu/block.c === --- qemu.orig/block.c +++ qemu/block.c @@ -706,6 +706,7 @@ int bdrv_reopen(BlockDriverState

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 03:20 PM, Stefan Hajnoczi wrote: It's just too tempting to call these functions in contexts where it is not okay to do so. The bdrv_co_*() functions are all tagged as coroutine_fn and make it clear that they can yield. Yes, I agree. We already have an event loop in qemu-img

Re: [Qemu-devel] [v7 Patch 5/5]Qemu: New struct 'BDRVReopenState' for image files reopen

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 15:42, schrieb Supriya Kannery: +/* Use driver specific reopen() if available */ +if (drv-bdrv_reopen_prepare) { +ret = drv-bdrv_reopen_prepare(bs,rs, bdrv_flags); if (ret 0) { -/* Reopen failed with orig and modified flags */ -

Re: [Qemu-devel] [PATCH] ARM GIC and CPU state saving/loading fix

2011-10-14 Thread Stefan Hajnoczi
On Fri, Oct 14, 2011 at 05:25:29PM +0400, Dmitry Koshelev wrote: Fixes two trivial indices errors. Signed-off-by: Dmitry Koshelev karaghio...@gmail.com --- hw/arm_gic.c | 12 ++-- target-arm/machine.c |4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) Not

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 14:42, schrieb Paolo Bonzini: On 10/14/2011 01:54 PM, Kevin Wolf wrote: Am 14.10.2011 13:30, schrieb Paolo Bonzini: On 10/14/2011 01:08 PM, Kevin Wolf wrote: Am 14.10.2011 10:41, schrieb Paolo Bonzini: Add coroutine support for flush and apply the same emulation that we already

Re: [Qemu-devel] [PATCH 2/4] block: unify flush implementations

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 04:02 PM, Kevin Wolf wrote: It would still host the checks on BDRV_O_NO_FLUSH and bs-drv-*_flush. It would be the same as bdrv_flush_co_entry is now, minus the marshalling in/out of the RwCo. Right. By the way, I like how you handle all three backends in the same

[Qemu-devel] [PATCH 6/7] sheepdog: correct spelling

2011-10-14 Thread Stefan Hajnoczi
From: Dong Xu Wang wdon...@linux.vnet.ibm.com Reviewed-by: Andreas Färber afaer...@suse.de Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH 3/7] arm_pic: Fix typo

2011-10-14 Thread Stefan Hajnoczi
From: Andreas Färber andreas.faer...@web.de interrput - interrupt Cc: Paul Brook p...@codesourcery.com Signed-off-by: Andreas Färber andreas.faer...@web.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/arm_pic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] [PULL 0/7] Trivial patches for October 6 to 14 2011

2011-10-14 Thread Stefan Hajnoczi
The following changes since commit ebffe2afceb1a17b5d134b5debf553955fe5ea1a: Merge remote-tracking branch 'qmp/queue/qmp' into staging (2011-10-10 08:21:46 -0500) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git trivial-patches Andreas Färber (1):

[Qemu-devel] [PATCH 5/7] tcg: Fix spelling in comment (varables - variables)

2011-10-14 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- tcg/tcg.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index de8a1d5..015f88a 100644 --- a/tcg/tcg.h

[Qemu-devel] [PATCH 4/7] remove hpet.h

2011-10-14 Thread Stefan Hajnoczi
From: Paolo Bonzini pbonz...@redhat.com It is unused since the HPET and RTC timers were removed (commit 25f3151, 2011-05-31). Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hpet.h | 22 -- 1 files changed, 0

[Qemu-devel] [PATCH 7/7] block/qcow: Fix use of free() instead of g_free()

2011-10-14 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de cppcheck reported this error: qemu/block/qcow.c:599: error: Mismatching allocation and deallocation: cluster_data Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block/qcow.c |2 +- 1 files

[Qemu-devel] [PATCH 1/7] qemu-options: avoid #if in spicevmc texi help

2011-10-14 Thread Stefan Hajnoczi
Preprocessor directives cannot be used in STEXI/ETEXI sections since they are not passed through the preprocessor. The spicevmc chardev option help currently uses #if, which is included verbatim in the man page output. Fix this by simply stating that spicevmc chardevs are available only in

[Qemu-devel] [PATCH 2/7] qemu-char: Fix use of free() instead of g_free()

2011-10-14 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de cppcheck reported these errors: qemu-char.c:1667: error: Mismatching allocation and deallocation: s qemu-char.c:1668: error: Mismatching allocation and deallocation: chr qemu-char.c:1769: error: Mismatching allocation and deallocation: s qemu-char.c:1770:

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 10:41, schrieb Paolo Bonzini: This similarly adds support for coroutine and asynchronous discard. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes sense to have a bdrv_aio_discard() in block.h

Re: [Qemu-devel] [PATCH 1/2] spice: turn client_migrate_info to async

2011-10-14 Thread Gerd Hoffmann
On 09/21/11 17:50, Yonit Halperin wrote: RHBZ 737921 Spice client is required to connect to the migration target before/as migration starts. Since after migration starts, the target qemu is blocked and cannot accept new spice client we trigger the connection to the target upon

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Luiz Capitulino
On Fri, 14 Oct 2011 15:37:29 +0200 Paolo Bonzini pbonz...@redhat.com wrote: On 10/14/2011 03:23 PM, Luiz Capitulino wrote: I'm not, because I'm assuming that allowing a transition from 'paused' to 'postmigrate' plus this fix:

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 04:23 PM, Kevin Wolf wrote: This similarly adds support for coroutine and asynchronous discard. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes sense to have a bdrv_aio_discard() in block.h

Re: [Qemu-devel] [PATCH v2] runstate: add more valid transitions

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 04:24 PM, Luiz Capitulino wrote: Yes, you're right. But there's another problem there: the VM is stopped when the migration process finishes. So, if you migrate again, there won't be a POST_MIGRATE - FINISH_MIGRATE transition, as vm_stop() will just return. Acked-by: Paolo

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-14 Thread Kevin Wolf
Am 14.10.2011 16:24, schrieb Paolo Bonzini: On 10/14/2011 04:23 PM, Kevin Wolf wrote: This similarly adds support for coroutine and asynchronous discard. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Do we really need bdrv_discard and bdrv_aio_discard in the backends? I think it makes

Re: [Qemu-devel] [PATCH 4/4] block: add bdrv_co_discard and bdrv_aio_discard support

2011-10-14 Thread Paolo Bonzini
On 10/14/2011 04:32 PM, Kevin Wolf wrote: I can certainly drop aio_discard from the backends, but I'm not sure how heavy can fallocate be (with FALLOC_FL_PUNCH_HOLE). Probably not much, but I think there's no guarantee of O(1) behavior especially with filesystems like ecryptfs. So you

  1   2   >