Re: [Qemu-devel] [PATCH 09/35] atapi/scsi-disk: make mode page values coherent between the two

Am 13.10.2011 13:03, schrieb Paolo Bonzini: This patch adds to scsi-disk the missing mode page 0x01 for both disk and CD-ROM drives, and mode page 0x0e for CD drives only. A few offsets were wrong in atapi.c. Also change the 2Ah mode page to expose DVD media read capabilities in the IDE

[Qemu-devel] [PATCH 11/18] spapr: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/spapr.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/spapr.c b/hw/spapr.c index b118975..63e5d33 100644 --- a/hw/spapr.c +++ b/hw/spapr.c @@ -41,6 +41,8 @@ #include kvm.h #include kvm_ppc.h +#include

Re: [Qemu-devel] [PATCH 09/35] atapi/scsi-disk: make mode page values coherent between the two

On 10/17/2011 05:05 PM, Kevin Wolf wrote: If I understand correctly what the internet says (I don't have a copy of MMC-3 and MMC-5 doesn't describe it any more), this is still part of the volume. I'm not sure why we should provide exactly two different volume levels, but if you think this makes

Re: [Qemu-devel] [PATCH 04/35] atapi: fill in AUDIO_CTL page correctly

On 10/17/2011 04:05 PM, Kevin Wolf wrote: diff --git a/hw/ide/atapi.c b/hw/ide/atapi.c index 347c38d..10f161f 100644 --- a/hw/ide/atapi.c +++ b/hw/ide/atapi.c @@ -731,6 +731,8 @@ static void cmd_mode_sense(IDEState *s, uint8_t *buf) buf[7] = 0; /* Fill

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

Anthony Liguori anth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

Hi, We only need to migrate the state when it is different of the default one (0). Er, isn't it going to be different from the default in like 99% of circumstances? Why? caps lock and scroll lock are off usually. numlock depends on what the user prefers. In case he cares in the first

Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

Am 13.10.2011 13:03, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-disk.c | 50 ++ 1 files changed, 42 insertions(+), 8 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 837747f..1786c37

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is exactly the case where they don't care, we are just freeing the state from previous failed

Re: [Qemu-devel] [PATCH 25/36] migration: Our release callback was just free

On 10/17/2011 10:12 AM, Juan Quintela wrote: Anthony Liguorianth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: We called it from a single place, and always with state != MIG_STATE_ACTIVE. Just remove the whole callback. For users of the notifier, notice that this is

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

Gerd Hoffmann kra...@redhat.com wrote: Hi, We only need to migrate the state when it is different of the default one (0). Er, isn't it going to be different from the default in like 99% of circumstances? Why? caps lock and scroll lock are off usually. numlock depends on what the

[Qemu-devel] [PATCH 14/18] sun4m: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/sun4m.c | 49 - 1 files changed, 32 insertions(+), 17 deletions(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index 71bf648..314edc4 100644 --- a/hw/sun4m.c +++ b/hw/sun4m.c @@ -593,19 +593,25 @@ static

[Qemu-devel] [PATCH 08/18] realview: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/realview.c | 54 ++ 1 files changed, 26 insertions(+), 28 deletions(-) diff --git a/hw/realview.c b/hw/realview.c index 11ffb8a..14281b0 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -18,17

[Qemu-devel] [PATCH 05/18] pci: simplify memory region registration

The two code paths (for ADDRESS_SPACE_IO and ADDRESS_SPACE_MEM) are identical. Unify them. Signed-off-by: Avi Kivity a...@redhat.com --- hw/pci.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff --git a/hw/pci.c b/hw/pci.c index 749e8d8..e8cc1b0 100644 ---

Re: [Qemu-devel] [PATCH v4] ps2: migrate ledstate

On 10/17/2011 10:15 AM, Gerd Hoffmann wrote: Hi, We only need to migrate the state when it is different of the default one (0). Er, isn't it going to be different from the default in like 99% of circumstances? Why? caps lock and scroll lock are off usually. numlock depends on what the user

[Qemu-devel] [PATCH 06/18] ppcr500_mpc8544ds: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/ppce500_mpc8544ds.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c index 5bf8eab..51b6abd 100644 --- a/hw/ppce500_mpc8544ds.c +++ b/hw/ppce500_mpc8544ds.c @@ -229,6

Re: [Qemu-devel] [PATCH 10/35] scsi-disk: support DVD profile in GET CONFIGURATION

On 10/17/2011 05:20 PM, Kevin Wolf wrote: +current = media_is_dvd(s) ? MMC_PROFILE_DVD_ROM : MMC_PROFILE_CD_ROM; +memset(outbuf, 0, 40); Is the memset required at all? I seem to remember that the output buffer was zeroed in generic code. No, it isn't. +stl_be_p(outbuf[0],

[Qemu-devel] [PATCH 3/4] qapi-types.py: Fail gracefully if out dir is not specified

Otherwise we get: Traceback (most recent call last): File ./scripts/qapi-types.py, line 183, in module os.makedirs(output_dir) File /usr/lib64/python2.7/os.py, line 157, in makedirs mkdir(name, mode) OSError: [Errno 2] No such file or directory: ''

Re: [Qemu-devel] [PATCH 22/36] migration: Introduce MIG_STATE_SETUP

On 10/11/2011 05:00 AM, Juan Quintela wrote: Use MIG_STATE_ACTIVE only when migration has really started. Use this new state to setup migration parameters. Signed-off-by: Juan Quintelaquint...@redhat.com --- migration.c |6 +- migration.h | 11 +++ 2 files changed, 12

[Qemu-devel] [PATCH 1/4] qapi-types.py: Add a main() like function

Makes it easier to read the code. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py | 230 1 files changed, 115 insertions(+), 115 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index

[Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand

Use os.path.join() instead. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 986ff1e..8df4b72 100644 --- a/scripts/qapi-types.py +++

[Qemu-devel] [PATCH 4/4] qapi-types.py: Drop unused variable

Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py index 4a2ddc4..28d7f01 100644 --- a/scripts/qapi-types.py +++ b/scripts/qapi-types.py @@ -65,7

Re: [Qemu-devel] [RFC][PATCH 12/45] msi: Introduce MSIRoutingCache

On Mon, Oct 17, 2011 at 01:19:56PM +0200, Jan Kiszka wrote: On 2011-10-17 13:06, Avi Kivity wrote: On 10/17/2011 11:27 AM, Jan Kiszka wrote: This cache will help us implementing KVM in-kernel irqchip support without spreading hooks all over the place. KVM requires us to register it

[Qemu-devel] [PATCH v1 0/4]: QAPI: Small fixes for qapi-types.py

Details in the patches. scripts/qapi-types.py | 233 + 1 files changed, 118 insertions(+), 115 deletions(-)

[Qemu-devel] [PATCH v2 21/35] scsi-disk: bump SCSIRequest reference count until aio completion runs

In some cases a request may be canceled before the completion callback runs. Keep a reference to the request between starting an AIO operation, and let scsi_*_complete remove it. Since scsi_handle_rw_error returns whether something else has to be done for the request by the caller, it makes

[Qemu-devel] [PATCH 0/7] V2. Finish to convert integratorcp and stellaris to memory API

Theses patches finish to convert integratorcp.c and stellaris.c to the new memory API. They apply on git://github.com/avikivity/qemu.git memory/master. Benoît Canet (7): integratorcp: convert core to memory API integratorcp: convert icp pic to memory API integratorcp: convert control to

[Qemu-devel] [PATCH 1/7] integratorcp: convert core to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- hw/integratorcp.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 9a289b4..0dc84c4 100644

Re: [Qemu-devel] [RFC][PATCH 12/45] msi: Introduce MSIRoutingCache

On Mon, Oct 17, 2011 at 11:27:46AM +0200, Jan Kiszka wrote: This cache will help us implementing KVM in-kernel irqchip support without spreading hooks all over the place. KVM requires us to register it first and then deliver it by raising a pseudo IRQ line returned on registration. While

[Qemu-devel] [RFC 3/6] block: wait for overlapping requests

When copy-on-read is enabled it is necessary to wait for overlapping requests before issuing new requests. This prevents races between the copy-on-read and a write request. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 39 +++ 1

[Qemu-devel] [RFC 5/6] block: core copy-on-read logic

Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 69 ++ trace-events |1 + 2 files changed, 70 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 0c22741..2aec6b4 100644 --- a/block.c +++

[Qemu-devel] [RFC 6/6] block: add -drive copy-on-read=on|off

This patch adds the -drive copy-on-read=on|off command-line option: copy-on-read=on|off copy-on-read is on or off and enables whether to copy read backing file sectors into the image file. Copy-on-read avoids accessing the same backing file sectors repeatedly and is useful when the

Re: [Qemu-devel] [RFC][PATCH 28/45] qemu-kvm: msix: Drop tracking of used vectors

On Mon, Oct 17, 2011 at 11:28:02AM +0200, Jan Kiszka wrote: This optimization was only required to keep KVM route usage low. Now that we solve that problem via lazy updates, we can drop the field. We still need interfaces to clear pending vectors, though (and we have to make use of them more

Re: [Qemu-devel] [PATCH v8 3/4] block: add block timer and throttling algorithm

On Mon, Oct 17, 2011 at 11:26 AM, Kevin Wolf kw...@redhat.com wrote: Am 26.09.2011 09:24, schrieb Zhi Yong Wu: On Sat, Sep 24, 2011 at 12:19 AM, Kevin Wolf kw...@redhat.com wrote: Am 08.09.2011 12:11, schrieb Zhi Yong Wu: Note:      1.) When bps/iops limits are specified to a small value such

[Qemu-devel] [PATCH 7/7] stellaris: convert gptm to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- hw/stellaris.c | 29 - 1 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 533d9c1..2ab7ec7 100644 ---

Re: [Qemu-devel] [RFC][PATCH 00/45] qemu-kvm: MSI layer rework for in-kernel irqchip support

On Mon, Oct 17, 2011 at 11:27:34AM +0200, Jan Kiszka wrote: As previously indicated, I was working for quite a while on a major refactoring of the MSI additions we have in qemu-kvm to support in-kernel irqchip, vhost and device assignment. This is now the outcome. I'm quite happy with it,

[Qemu-devel] [PATCH 1/1 V6] qemu-kvm: fix improper nmi emulation

On 10/17/2011 05:49 PM, Avi Kivity wrote: On 10/17/2011 11:40 AM, Lai Jiangshan wrote: LINT1 may have been programmed as a level -triggered interrupt instead of edge triggered (NMI or interrupt). We can use the ioctl argument for the level (and pressing the NMI button needs to pulse the

[Qemu-devel] [RFC 0/6] block: generic copy-on-read

The new -drive copy-on-read=on|off feature populates the image file with data from the backing file on read. This is useful when accessing images backed over a slow medium (e.g. http over internet). All read data will be stored in the local image file so it does not need to be fetched again in

[Qemu-devel] [PATCH 2/7] integratorcp: convert icp pic to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com --- hw/integratorcp.c | 27 ++- 1 files changed, 10 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index 0dc84c4..c7d6596 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@

[Qemu-devel] [PATCH 3/7] integratorcp: convert control to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com --- hw/integratorcp.c | 31 ++- 1 files changed, 14 insertions(+), 17 deletions(-) diff --git a/hw/integratorcp.c b/hw/integratorcp.c index c7d6596..7f79560 100644 --- a/hw/integratorcp.c +++ b/hw/integratorcp.c @@

[Qemu-devel] [RFC 1/6] block: add request tracking

The block layer does not know about pending requests. This information is necessary for copy-on-read since overlapping requests must be serialized to prevent races that corrupt the image. Add a simple mechanism to enable/disable request tracking. By default request tracking is disabled. The

[Qemu-devel] [PATCH 6/7] stellaris: convert adc to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com --- hw/stellaris.c | 30 -- 1 files changed, 12 insertions(+), 18 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index f55b1f3..533d9c1 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -892,6 +892,7 @@

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 16:17, schrieb Anthony Liguori: On 10/17/2011 07:50 AM, Paolo Bonzini wrote: On 10/17/2011 02:38 PM, Anthony Liguori wrote: Could we please draft some policy on this? This is not a GDB issue, it's very general. Whether we like it or not, there is GPLv3-licensed code and there

[Qemu-devel] [RFC 4/6] block: request overlap detection

Detect overlapping requests and remember to align to cluster boundaries if the image format uses them. This assumes that allocating I/O is performed in cluster granularity - which is true for qcow2, qed, etc. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 39

[Qemu-devel] [PATCH 5/7] stellaris: convert i2c to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org --- hw/stellaris.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 6f9146a..f55b1f3 100644 ---

[Qemu-devel] [PATCH 4/7] stellaris: convert sys to memory API

Signed-off-by: Benoit Canet benoit.ca...@gmail.com --- hw/stellaris.c | 28 +++- 1 files changed, 11 insertions(+), 17 deletions(-) diff --git a/hw/stellaris.c b/hw/stellaris.c index 2bf1c23..6f9146a 100644 --- a/hw/stellaris.c +++ b/hw/stellaris.c @@ -327,6 +327,7 @@

[Qemu-devel] [PATCH 15/18] sun4u: convert to memory API

Signed-off-by: Avi Kivity a...@redhat.com --- hw/sun4u.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index 96fc3d0..eaaefe3 100644 --- a/hw/sun4u.c +++ b/hw/sun4u.c @@ -574,6 +574,11 @@ static void pci_ebus_register(void)

[Qemu-devel] [RFC 2/6] block: add bdrv_set_copy_on_read()

The bdrv_set_copy_on_read() function can be used to programmatically enable or disable copy-on-read for a block device. Later patches add the actual copy-on-read logic. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 17 + block.h |3 +++

[Qemu-devel] [PATCH 03/18] pxa2xx: convert to memory API (part I)

Signed-off-by: Avi Kivity a...@redhat.com --- hw/pxa.h|1 + hw/pxa2xx.c | 116 -- 2 files changed, 49 insertions(+), 68 deletions(-) diff --git a/hw/pxa.h b/hw/pxa.h index 1204165..3fb070f 100644 --- a/hw/pxa.h +++ b/hw/pxa.h @@

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: v2 only: aio.c block-migration.c buffered_file.c compatfd.c error.c iov.c kvm-all.c memory.c migration.c migration-exec.c migration-fd.c migration-tcp.c

Re: [Qemu-devel] GPLv3 troubles

On 17 October 2011 17:39, Andreas Färber afaer...@suse.de wrote: Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: Your rune needs tweaking -- it isn't looking inside any subdirectories. -- PMM

Re: [Qemu-devel] GPLv3 troubles

On 10/17/2011 11:47 AM, Peter Maydell wrote: On 17 October 2011 17:39, Andreas Färberafaer...@suse.de wrote: Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: Your rune needs tweaking -- it isn't

Re: [Qemu-devel] [PATCH 06/36] migration: If there is one error, it makes no sense to continue

Anthony Liguori anth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: Signed-off-by: Juan Quintelaquint...@redhat.com The original intention of returning zero was to force a quick finish of the migration. I think this code makes things more brittle because now if you're

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 18:47, schrieb Peter Maydell: On 17 October 2011 17:39, Andreas Färber afaer...@suse.de wrote: Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though. grep -r version *.c comes up with these: Your rune needs tweaking -- it isn't

Re: [Qemu-devel] [PATCH 09/36] migration: don't write when migration is not active

Anthony Liguori anth...@codemonkey.ws wrote: On 10/11/2011 05:00 AM, Juan Quintela wrote: If migration is not active, just ignore writes. Signed-off-by: Juan Quintelaquint...@redhat.com --- migration.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

On 10/17/2011 07:09 AM, Bob Breuer wrote: I don't think this is a free/g_free issue. If I use the following patch, then I at least get the openbios messages: diff --git a/cpu-exec.c b/cpu-exec.c index a9fa608..dfbd6ea 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -180,6 +180,7 @@ static

Re: [Qemu-devel] [SeaBIOS] [PATCH 0/5] More pci init simplifications

On Mon, Oct 17, 2011 at 11:57:09AM +0200, Gerd Hoffmann wrote: On 10/15/11 18:25, Kevin O'Connor wrote: This main patch in this series is patch 2 - replacement of the recursive scan with a linear scan. The other patches are just cosmetic changes. Looks sane at a quick glance. Gerd - can

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

MVNS with immediate fails in attached test program at 0x82c0 location. My patch fixes that. ** Attachment added: failed test for MVNS.IMM opcode https://bugs.launchpad.net/qemu/+bug/874038/+attachment/2554573/+files/mvns_imm.exe -- You received this bug notification because you are a member

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 18:47, schrieb Anthony Liguori: On 10/17/2011 11:30 AM, Andreas Färber wrote: Am 17.10.2011 16:17, schrieb Anthony Liguori: On 10/17/2011 07:50 AM, Paolo Bonzini wrote: On 10/17/2011 02:38 PM, Anthony Liguori wrote: Could we please draft some policy on this? This is not a GDB

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 18:47, schrieb Anthony Liguori: It's not something that any one person can really change. It would require a very large effort. To give you an idea of the scope, I ran the following command: $ grep GPL *.c hw/*.c | grep -v 'or later' | cut -f1 -d: | sort -u | while read i;

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassembler? Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff

Re: [Qemu-devel] GPLv3 troubles

On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassembler? Sure. This is only used in the monitor

Re: [Qemu-devel] GPLv3 troubles

On 17 October 2011 19:16, Anthony Liguori anth...@codemonkey.ws wrote: On 10/17/2011 12:58 PM, Andreas Färber wrote: Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external disassembler? Sure.  This is only used in the monitor for interactive

Re: [Qemu-devel] GPLv3 troubles

Am 17.10.2011 20:16, schrieb Anthony Liguori: On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe machine code from QEMU into an external

[Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

Current git master works for me on that test program without your patch: cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe cam-vm-266:maverick:qemu$ echo $? 0 (I tested on qemu-0.14 just to confirm that I'm running the test program correctly, and that indeed fails as I

Re: [Qemu-devel] GPLv3 troubles

On 10/17/2011 01:20 PM, Stefan Weil wrote: Am 17.10.2011 20:16, schrieb Anthony Liguori: On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is just a bad idea. Do you see a real alternative? Would it be possible to pipe

Re: [Qemu-devel] GPLv3 troubles

On 17 October 2011 19:29, Anthony Liguori anth...@codemonkey.ws wrote: Likewise, we could add tracing to translate.c to achieve the same affect as in_asm. Having the code you're trying to debug be also doing the printing out of the disassembly seems like a recipe for confusing yourself (because

Re: [Qemu-devel] GPLv3 troubles

On 10/17/2011 01:34 PM, Peter Maydell wrote: On 17 October 2011 19:29, Anthony Liguorianth...@codemonkey.ws wrote: Likewise, we could add tracing to translate.c to achieve the same affect as in_asm. Having the code you're trying to debug be also doing the printing out of the disassembly

Re: [Qemu-devel] [PATCH v3 1/4] vga: make PCI devices optional

On Mon, Oct 17, 2011 at 7:17 AM, Jan Kiszka jan.kis...@web.de wrote: On 2011-10-16 23:21, Blue Swirl wrote: Improve VGA selection logic, push check for device availabilty to vl.c. Make PCI VGA devices optional. Signed-off-by: Blue Swirl blauwir...@gmail.com ---  hw/cirrus_vga.c |    5 -

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

On Mon, Oct 17, 2011 at 2:02 PM, Avi Kivity a...@redhat.com wrote: Signed-off-by: Avi Kivity a...@redhat.com ---  hw/tcx.c |  152 ++---  1 files changed, 85 insertions(+), 67 deletions(-) diff --git a/hw/tcx.c b/hw/tcx.c index

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

On Mon, Oct 17, 2011 at 5:22 PM, Richard Henderson r...@twiddle.net wrote: On 10/17/2011 07:09 AM, Bob Breuer wrote: I don't think this is a free/g_free issue.  If I use the following patch, then I at least get the openbios messages: diff --git a/cpu-exec.c b/cpu-exec.c index

[Qemu-devel] [PATCH 1/4] pflash: Support read-only mode

Read-only mode is indicated by bdrv_is_read_only When read-only mode is enabled, no changes will be made to the flash image in memory, and no bdrv_write calls will be made. For pflash_cfi01 (Intel), if the flash is in read-only mode then the status register will signal block erase error or

[Qemu-devel] [PATCH 2/4] pc: Support system flash memory with pflash

If a pflash image is found, then it is used for the system firmware image. If a pflash image is not initially found, then a read-only pflash device is created using the -bios filename. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com Cc: Anthony Liguori aligu...@us.ibm.com ---

[Qemu-devel] [PATCH 3/4] loader: Add rom_add_file_buf for adding roms from a buffer

rom_add_file_buf is similar to rom_add_file, except the rom's contents are provided in a buffer. rom_add_file is modified to call rom_add_file_buf after reading the rom's contents from the file. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/loader.c | 71

[Qemu-devel] [PATCH 4/4] pcflash: Add pc flash to qemu roms

The pflash image is added to the roms using the memory region buffer and rom_add_file_buf_fixed. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pcflash.c | 16 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/pcflash.c b/hw/pcflash.c index

[Qemu-devel] [PATCH] hw/9pfs: Fix missing parentheses

cppcheck report: hw/9pfs/virtio-9p.c:2385: style: Boolean result is used in bitwise operation. Clarify expression with parentheses hw/9pfs/virtio-9p.c:2531: style: Boolean result is used in bitwise operation. Clarify expression with parentheses Cc: Aneesh Kumar K.V

Re: [Qemu-devel] [PATCH 2/4] pc: Support system flash memory with pflash

On Mon, Oct 17, 2011 at 12:16, Jordan Justen jordan.l.jus...@intel.com wrote: If a pflash image is found, then it is used for the system firmware image. If a pflash image is not initially found, then a read-only pflash device is created using the -bios filename. Signed-off-by: Jordan Justen

Re: [Qemu-devel] GPLv3 troubles

On Mon, Oct 17, 2011 at 5:46 PM, Stefan Weil s...@weilnetz.de wrote: Am 17.10.2011 18:47, schrieb Anthony Liguori: On 10/17/2011 11:30 AM, Andreas Färber wrote: Am 17.10.2011 16:17, schrieb Anthony Liguori: On 10/17/2011 07:50 AM, Paolo Bonzini wrote: On 10/17/2011 02:38 PM, Anthony

Re: [Qemu-devel] GPLv3 troubles

On Mon, Oct 17, 2011 at 6:29 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/17/2011 01:20 PM, Stefan Weil wrote: Am 17.10.2011 20:16, schrieb Anthony Liguori: On 10/17/2011 12:58 PM, Andreas Färber wrote: Am 17.10.2011 18:51, schrieb Anthony Liguori: Including binutils code is

Re: [Qemu-devel] [RFC][PATCH 06/45] msix: Prevent bogus mask updates on MMIO accesses

On Mon, Oct 17, 2011 at 09:11:29PM +0200, Jan Kiszka wrote: On 2011-10-17 14:50, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 02:07:10PM +0200, Jan Kiszka wrote: On 2011-10-17 13:57, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 01:23:46PM +0200, Jan Kiszka wrote: On 2011-10-17

Re: [Qemu-devel] GPLv3 troubles

On Mon, Oct 17, 2011 at 4:51 PM, Anthony Liguori anth...@codemonkey.ws wrote: On 10/17/2011 11:47 AM, Peter Maydell wrote: On 17 October 2011 17:39, Andreas Färberafaer...@suse.de  wrote: Am 17.10.2011 13:10, schrieb Paolo Bonzini: Making a list of GPLv2 files would be a start, though.

Re: [Qemu-devel] [PATCH 01/13] remove unused function

On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- hw/mac_dbdma.c |5 - hw/mac_dbdma.h |1 - 2 files changed, 0 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 02/13] qemu-timer: remove active_timers array

On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Embed the list in the QEMUClock instead. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- qemu-timer.c | 59

Re: [Qemu-devel] [PATCH 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

On 10/11/2011 06:35 AM, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- qemu-timer.c | 129 -- 1 files changed, 53 insertions(+),

Re: [Qemu-devel] [PATCH 04/13] qemu-timer: more clock functions

On 10/11/2011 06:35 AM, Paolo Bonzini wrote: These will be used when moving icount accounting to cpus.c. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Regards, Anthony Liguori --- qemu-timer.c | 25 +

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

On 10/11/2011 06:35 AM, Paolo Bonzini wrote: This patch series makes the QEMU main loop usable out of the executable, and especially in tools and possibly unit tests. The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to

[Qemu-devel] [PATCH] gdbstub: Fix memory leak

cppcheck report: gdbstub.c:1781: error: Memory leak: s Rearranging of the code avoids the leak. The patch also slightly cleans the g_malloc0 statement which was touched by that change (no type cast, easier code review). Signed-off-by: Stefan Weil s...@weilnetz.de --- gdbstub.c | 14

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

On 10/17/2011 09:56 PM, Anthony Liguori wrote: The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to qemu-nbd in this series. Leftover from RFC. Right now, this is just a chainsaw cleanup. However, Kevin has plans to use the

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

On 10/17/2011 03:09 PM, Paolo Bonzini wrote: On 10/17/2011 09:56 PM, Anthony Liguori wrote: The series already starts using the refactored main loop in qemu-nbd. What patch does this? I don't see any changes to qemu-nbd in this series. Leftover from RFC. Right now, this is just a chainsaw

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

On 10/17/2011 12:14 PM, Blue Swirl wrote: IIRC buggy versions of alloca() could also fail without a frame pointer. (1) GCC always uses a frame pointer for alloca, (2) Unless you do -fno-builtin-alloca, we always implement it inline. r~

[Qemu-devel] [PATCH] device_tree: Fix potential memory leak

cppcheck error report: device_tree.c:156: error: Memory leak: dupname Signed-off-by: Stefan Weil s...@weilnetz.de --- device_tree.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/device_tree.c b/device_tree.c index dc69232..86a694c 100644 --- a/device_tree.c +++

Re: [Qemu-devel] [Bug 874038] Re: ARM thumb2 does not propogate carry flag properly

0.15.0 fails for me. On Mon, Oct 17, 2011 at 10:06 PM, Peter Maydell peter.mayd...@linaro.org wrote: Current git master works for me on that test program without your patch: cam-vm-266:maverick:qemu$ ./arm-linux-user/qemu-arm ~/Desktop/mvns_imm.exe cam-vm-266:maverick:qemu$ echo $? 0 (I

Re: [Qemu-devel] [PATCH v2 00/13] allow tools to use the QEMU main loop

On 10/17/2011 10:11 PM, Anthony Liguori wrote: Leftover from RFC. Right now, this is just a chainsaw cleanup. However, Kevin has plans to use the main loop everywhere (making qemu-io and qemu-img one huge coroutine). Can you add something to docs that explains how to use the new main loop?

Re: [Qemu-devel] GPLv3 troubles

On 10/17/2011 07:46 PM, Stefan Weil wrote: So let's start. For any of my contributions, I agree to GPL v2 or later. Later generations should have the possibility to replace GPL v2 by something which matches future requirements. I expect Red Hat contributions can be relicensed to v2+ as well.

Re: [Qemu-devel] [PATCH 18/18] tcx: convert to memory API

On 10/17/2011 09:13 PM, Blue Swirl wrote: -ret = cpu_physical_memory_get_dirty(page, VGA_DIRTY_FLAG); +ret = memory_region_get_dirty(s-vram_mem, page, DIRTY_MEMORY_VGA); for (off = 0; off TARGET_PAGE_SIZE * 4; off += TARGET_PAGE_SIZE) { -ret |=

Re: [Qemu-devel] [RFC][PATCH 23/45] qemu-kvm: Rework MSI-X mask notifier to generic MSI config notifiers

On 2011-10-17 14:39, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 01:45:04PM +0200, Jan Kiszka wrote: On 2011-10-17 13:40, Michael S. Tsirkin wrote: On Mon, Oct 17, 2011 at 11:27:57AM +0200, Jan Kiszka wrote: MSI config notifiers are supposed to be triggered on every relevant

Re: [Qemu-devel] [PATCH 1/4] qapi-types.py: Add a main() like function

Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com On Mon, 17 Oct 2011 13:29:34 -0200, Luiz Capitulino lcapitul...@redhat.com wrote: Makes it easier to read the code. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py | 230

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

Richard Henderson wrote: On 10/17/2011 07:09 AM, Bob Breuer wrote: I don't think this is a free/g_free issue. If I use the following patch, then I at least get the openbios messages: diff --git a/cpu-exec.c b/cpu-exec.c index a9fa608..dfbd6ea 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@

Re: [Qemu-devel] [PATCH 2/4] qapi-types.py: Don't build paths by hand

Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com On Mon, 17 Oct 2011 13:29:35 -0200, Luiz Capitulino lcapitul...@redhat.com wrote: Use os.path.join() instead. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py |6 +++--- 1 files changed, 3

Re: [Qemu-devel] [PATCH 3/4] qapi-types.py: Fail gracefully if out dir is not specified

On Mon, 17 Oct 2011 13:29:36 -0200, Luiz Capitulino lcapitul...@redhat.com wrote: Otherwise we get: Traceback (most recent call last): File ./scripts/qapi-types.py, line 183, in module os.makedirs(output_dir) File /usr/lib64/python2.7/os.py, line 157, in makedirs

Re: [Qemu-devel] [PATCH 4/4] qapi-types.py: Drop unused variable

Reviewed-by: Michael Roth mdr...@linux.vnet.ibm.com On Mon, 17 Oct 2011 13:29:37 -0200, Luiz Capitulino lcapitul...@redhat.com wrote: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- scripts/qapi-types.py |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] gcc auto-omit-frame-pointer vs msvc longjmp

2011/10/17 Bob Breuer breu...@mc.net: Richard Henderson wrote: On 10/17/2011 07:09 AM, Bob Breuer wrote: I don't think this is a free/g_free issue.  If I use the following patch, then I at least get the openbios messages: diff --git a/cpu-exec.c b/cpu-exec.c index a9fa608..dfbd6ea 100644

<    1   2   3   4   >