Re: [Qemu-devel] Assigning a new virtio block device (-drive)

2011-10-28 Thread Markus Armbruster
"Leib, David" writes: > Hi, > I am trying to assign a new virtio block device in addition to a normal > virtio block device who are accessing exactly the same cdrom drive > ("/dev/sr0") because I additionaly want to access the block device in my way > by manually calling the virtqueue_pop and

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppcr: Avoid decrementer related kvm exits

2011-10-28 Thread Alexander Graf
On 25.10.2011, at 21:38, Scott Wood wrote: > On 10/14/2011 01:44 AM, Alexander Graf wrote: >> Wouldn't a simple >> >> if (kvm_enabled()) { >>return; >> } >> >> in the beginning of the function make more sense? There's no code connecting >> the in-qemu and the in-kvm decrementors atm, so an

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-28 Thread Markus Armbruster
Andreas Färber writes: > Am 27.10.2011 13:37, schrieb Peter Maydell: >> Add an abstraction layer for defining and using thread-local >> variables. For the moment this is implemented only for Linux, >> which means they can only be used in restricted circumstances. >> The abstraction layer allows u

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >> For compilations with -DNDEBUG, the default case did not return >> a value which caused a compiler warning. >> >> Signed-off-by: Stefan Weil >> --- >> hw/ppce500_spin.c | 11 --- >> 1 files chan

Re: [Qemu-devel] [PATCH v2 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-28 Thread Peter Maydell
On 28 October 2011 08:27, Markus Armbruster wrote: > Andreas Färber writes: > >> Am 27.10.2011 13:37, schrieb Peter Maydell: >>> + * Copyright (c) 2011 Red Hat, Inc, Linaro Limited >> >> The concatenation looks kind of funny. ;) > > I'd split into > >  * Copyright (c) 2011 Red Hat, Inc >  * Copyr

Re: [Qemu-devel] [RFC] Introduce qemu_abort?

2011-10-28 Thread Markus Armbruster
Peter Maydell writes: > On 26 October 2011 19:34, Stefan Weil wrote: >> Adding the infrastructure (macros / implementation) could be done >> faster. I suggest these interfaces in qemu-common.h: >> >> qemu_abort() - abort QEMU with a message containing function name, >> file name and line (macro,

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-28 Thread Kevin Wolf
Am 27.10.2011 18:12, schrieb Stefan Weil: > Am 27.10.2011 10:53, schrieb Kevin Wolf: >> Am 26.10.2011 21:51, schrieb Eric Sunshine: >>> An entry in the VDI block map will hold an offset to the actual block if >>> the block is allocated, or one of two specially-interpreted values if >>> not allocate

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-28 Thread Eric Sunshine
On Oct 28, 2011, at 4:00 AM, Kevin Wolf wrote: Am 27.10.2011 18:12, schrieb Stefan Weil: Am 27.10.2011 10:53, schrieb Kevin Wolf: Am 26.10.2011 21:51, schrieb Eric Sunshine: An entry in the VDI block map will hold an offset to the actual block if the block is allocated, or one of two specia

[Qemu-devel] [Bug 498107] Re: www.qemu.org and www.nongnu.org/qemu have a lot of bugs

2011-10-28 Thread Klaus Rennecke
What is this report supposed to tell me in the context of the QEMU software? I believe this entry borders on mobbing the maintainer, and looks suspiciously like a plug for the book co-authored by the OP. As a user, it's just clutter in the search results on launchpad. ** Changed in: qemu St

Re: [Qemu-devel] [PATCH] net: tap-linux: Fix unhelpful error message

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 14, 2011 at 03:05:10PM -0300, Luiz Capitulino wrote: > I'm getting: > > could not configure /dev/net/tun (tap%d): Operation not permitted > > When the ioctl() fails, ifr.ifr_name will most likely not be overwritten. > So we better only use it when ifname contains a string. > > Si

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >>> For compilations with -DNDEBUG, the default case did not return >>> a value which caused a compiler warning. >>> >>> Signed-off-by: Stefan Weil

[Qemu-devel] [PATCH 2/2] hw/9pfs: Supply missing va_end()

2011-10-28 Thread Markus Armbruster
C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster --- hw/9pfs/virtio-9p.c |

[Qemu-devel] [PATCH 1/2] sysbus: Supply missing va_end()

2011-10-28 Thread Markus Armbruster
C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster --- hw/sysbus.c |2 ++

[Qemu-devel] [PATCH 0/2] Trivial portability fix: missing va_end()

2011-10-28 Thread Markus Armbruster
Markus Armbruster (2): sysbus: Supply missing va_end() hw/9pfs: Supply missing va_end() hw/9pfs/virtio-9p.c |4 hw/sysbus.c |2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) -- 1.7.6.4

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: For compilations with -DNDEBUG, the default case did not return a value which caused a compiler warning. >

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: >>> Stefan Hajnoczi writes: >>> On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: > For compilations with -DNDEBUG, the default

[Qemu-devel] [Bug 611142] Re: seabios should have native scsi support

2011-10-28 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: seabios (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/611142 Title: se

[Qemu-devel] [PATCH 0/0] Manpage. Fix typo and add Sheepdog description

2011-10-28 Thread Ronnie Sahlberg
These patches 1, fixes a typo in a previous patch NDB -> NBD 2, adds description of sheepdog URL syntax to the manpage

[Qemu-devel] [PATCH 1/2] Documentation: Fix typo in manpage. NDB -> NBD

2011-10-28 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index bf2ebb3..c55080c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1761,10 +1761,10 @@ compiled and linked against libiscsi.

[Qemu-devel] [PATCH 2/2] Documentation: Add syntax for using sheepdog devices

2011-10-28 Thread Ronnie Sahlberg
Signed-off-by: Ronnie Sahlberg --- qemu-options.hx | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index c55080c..38d0f57 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1778,6 +1778,33 @@ Example for Un

Re: [Qemu-devel] [PATCH] net: Only flush queue or call sent callback on successful delivery

2011-10-28 Thread Stefan Hajnoczi
On Thu, Oct 27, 2011 at 10:02 AM, Mark Wu wrote: > Now queue flushing and sent callback could be invoked even on delivery > failure. We add a checking of receiver's return value to avoid this > case. > > Signed-off-by: Mark Wu > --- >  net/queue.c |   12 +++- >  1 files changed, 7 inserti

Re: [Qemu-devel] [PATCH 2/2] Documentation: Add syntax for using sheepdog devices

2011-10-28 Thread Eric Sunshine
On Oct 28, 2011, at 5:13 AM, Ronnie Sahlberg wrote: Signed-off-by: Ronnie Sahlberg --- qemu-options.hx | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index c55080c..38d0f57 100644 --- a/qemu-options.hx +++ b/qe

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-28 Thread Stefan Hajnoczi
Rich: Thanks for the ESXi 4.1.0 and vSphere Client 4.1.0 version info. Fam: Do you have any suggestions how to debug the "Error uploading file path/to/image.vmdk to server. Not a supported disk format (sparse VMDK version too old)" issue? Ideally qemu-img would create images that work with curre

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 10:15, schrieb Eric Sunshine: > > On Oct 28, 2011, at 4:00 AM, Kevin Wolf wrote: > >> Am 27.10.2011 18:12, schrieb Stefan Weil: >>> Am 27.10.2011 10:53, schrieb Kevin Wolf: Am 26.10.2011 21:51, schrieb Eric Sunshine: > An entry in the VDI block map will hold an offset to th

Re: [Qemu-devel] [PATCH 1/2] Documentation: Fix typo in manpage. NDB -> NBD

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 11:13, schrieb Ronnie Sahlberg: > Signed-off-by: Ronnie Sahlberg > --- > qemu-options.hx |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-options.hx b/qemu-options.hx > index bf2ebb3..c55080c 100644 > --- a/qemu-options.hx > +++ b/qemu-options.h

Re: [Qemu-devel] [PATCH 2/2] Documentation: Add syntax for using sheepdog devices

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 11:13, schrieb Eric Sunshine: > On Oct 28, 2011, at 5:13 AM, Ronnie Sahlberg wrote: >> Signed-off-by: Ronnie Sahlberg >> --- >> qemu-options.hx | 27 +++ >> 1 files changed, 27 insertions(+), 0 deletions(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx

Re: [Qemu-devel] [PATCH] Add wildcard trace event support

2011-10-28 Thread Stefan Hajnoczi
On Thu, Oct 20, 2011 at 10:38 AM, Mark Wu wrote: >  The "tracetool" script automates tedious trace event code generation and also > diff --git a/trace/simple.c b/trace/simple.c > index b639dda..869e315 100644 > --- a/trace/simple.c > +++ b/trace/simple.c > @@ -324,14 +324,29 @@ void trace_print_ev

[Qemu-devel] [PATCH v3 3/3] Make cpu_single_env thread-local

2011-10-28 Thread Peter Maydell
From: Paolo Bonzini Make cpu_single_env thread-local. This fixes a regression in handling of multi-threaded programs in linux-user mode (bug 823902). Signed-off-by: Paolo Bonzini [Peter Maydell: rename tls_cpu_single_env to cpu_single_env] Signed-off-by: Peter Maydell Reviewed-by: Andreas Färb

[Qemu-devel] [PATCH v3 1/3] qemu-tls.h: Add abstraction layer for TLS variables

2011-10-28 Thread Peter Maydell
Add an abstraction layer for defining and using thread-local variables. For the moment this is implemented only for Linux, which means they can only be used in restricted circumstances. The abstraction layer allows us to add POSIX and Win32 support later. Signed-off-by: Paolo Bonzini Signed-off-b

[Qemu-devel] [PATCH v3 0/3] TLS abstraction layer for thread-local cpu_single_env on Linux

2011-10-28 Thread Peter Maydell
These patches add enough of the TLS abstraction layer to allow us to make cpu_single_env thread-local on Linux systems. This fixes the regression described in bug 823902 for the 1.0 release; we can add the Win32 and POSIX implementations later. I haven't included Paolo's "Prepare Windows port for

[Qemu-devel] [PATCH v3 2/3] darwin-user/main.c: Drop unused cpu_single_env definition

2011-10-28 Thread Peter Maydell
From: Paolo Bonzini Drop the cpu_single_env definition as it is unused. Signed-off-by: Paolo Bonzini --- darwin-user/main.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/darwin-user/main.c b/darwin-user/main.c index 1a881a0..c0f14f8 100644 --- a/darwin-user/main.c +

[Qemu-devel] [PATCH v6 2/2] hw/vexpress.c, hw/realview.c: Add PL041 to VExpress, Realview boards

2011-10-28 Thread Peter Maydell
Instantiate the PL041 audio on the Versatile Express and Realview board models. Signed-off-by: Peter Maydell --- hw/realview.c |8 +++- hw/vexpress.c |7 ++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/realview.c b/hw/realview.c index 14281b0..9a8e63c 10064

[Qemu-devel] [PATCH v6 0/2] Add AACI audio playback support to ARM devboards

2011-10-28 Thread Peter Maydell
This is Mathieu's v5 patch, except that I have corrected the one-liner minor error spotted by Andrzej Zaborowski, tested, rebased and thrown in my patch adding the PL041 to the other devboards. I hope this is OK to apply now; I'm hoping to get it in before the freeze for 1.0... Thanks to Mathieu

[Qemu-devel] [PATCH v6 1/2] Add AACI audio playback support to the ARM Versatile/PB platform

2011-10-28 Thread Peter Maydell
From: Mathieu Sonet This driver emulates the ARM AACI interface (PL041) connected to a LM4549 codec. It enables audio playback for the Versatile/PB platform. Limitations: - Supports only a playback on one channel (Versatile/Vexpress) - Supports only one TX FIFO in compact-mode or non-compact mod

[Qemu-devel] [Bug 882997] [NEW] 64-bit linux guests fail to start on oneiric running 3.0 kernel

2011-10-28 Thread Klaus Rennecke
Public bug reported: Host: Ubuntu 11.10 kernel vmlinuz-3.0.0-12-generic or vmlinuz-3.0.0-12-server on AMD Athlon(tm) II P360 Dual-Core Guests: SLES 10 or 11, all 64 bit 32 bit windows guest starts fine. All 64 bit linux guests loop during boot, when GRUB is starting. VMs are managed using libvir

[Qemu-devel] [PATCH v9 0/4] The intro of QEMU block I/O throttling

2011-10-28 Thread Zhi Yong Wu
The main goal of the patch is to effectively cap the disk I/O speed or counts of one single VM.It is only one draft, so it unavoidably has some drawbacks, if you catch them, please let me know. The patch will mainly introduce one block I/O throttling algorithm, one timer and one block queue for

[Qemu-devel] [PATCH v9 1/4] block: add the block queue support

2011-10-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- Makefile.objs |2 +- block.c | 71 +-- block.h | 20 + block/blk-queue.c | 201 + block/blk-queue.h | 63 + block_int.h | 23 ++ 6

Re: [Qemu-devel] [PATCH] net: Only flush queue or call sent callback on successful delivery

2011-10-28 Thread Mark Wu
On 10/28/2011 05:13 PM, Stefan Hajnoczi wrote: On Thu, Oct 27, 2011 at 10:02 AM, Mark Wu wrote: Now queue flushing and sent callback could be invoked even on delivery failure. We add a checking of receiver's return value to avoid this case. Signed-off-by: Mark Wu --- net/queue.c | 12 +

[Qemu-devel] [PATCH v9 3/4] block: add the block throttling algorithm

2011-10-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- block.c | 360 -- 1 files changed, 348 insertions(+), 12 deletions(-) diff --git a/block.c b/block.c index 8f92950..2d85b64 100644 --- a/block.c +++ b/block.c @@ -63,9 +63,11 @@ static int coroutine_fn bd

[Qemu-devel] [PATCH v9 4/4] qmp/hmp: add block_set_io_throttle

2011-10-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- block.c | 27 --- blockdev.c | 51 +++ blockdev.h |2 ++ hmp-commands.hx | 15 +++ qerror.c|4 qerror.h|3 +++ qmp-commands.h

[Qemu-devel] [PATCH v9 2/4] block: add the command line support

2011-10-28 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu --- block.c | 85 +++ block.h |4 ++ block_int.h | 22 ++ blockdev.c | 32 qemu-config.c | 24 +++ qemu-options.hx |1 + 6 files c

Re: [Qemu-devel] [PATCH] net: Only flush queue or call sent callback on successful delivery

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 11:02 AM, Mark Wu wrote: > On 10/28/2011 05:13 PM, Stefan Hajnoczi wrote: >> >> On Thu, Oct 27, 2011 at 10:02 AM, Mark Wu >>  wrote: >>> >>> Now queue flushing and sent callback could be invoked even on delivery >>> failure. We add a checking of receiver's return value to a

[Qemu-devel] [PATCH 1/4] qemu-nbd: exit if the child exits before a socket connection is established

2011-10-28 Thread Paolo Bonzini
In -c mode qemu-nbd forks with the parent running the in-kernel NBD client and the child running the server. The next patch will introduce a case in which the child fails after forking. Detect this situation and exit the parent. Signed-off-by: Paolo Bonzini --- qemu-nbd.c |5 - 1 files

[Qemu-devel] [PATCH 0/4] fix qemu-nbd -c

2011-10-28 Thread Paolo Bonzini
qemu-nbd -c is another casualty of removing raw_read/raw_write. This series fixes it. Unfortunately, as a side effect of this qemu-nbd will have to daemonize before detecting all possible errors. For this reason patches 2 and 3 make qemu-nbd write errors to syslog when daemonized. Paolo Bonzini

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-28 Thread Zhi Yong Wu
On Fri, Oct 28, 2011 at 10:20 AM, Lucas Meneghel Rodrigues wrote: > On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote: >> >> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues >>  wrote: >>> >>> On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote: On Wed, Oct 26, 2011 at 03:19:17P

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-28 Thread Zhi Yong Wu
On Fri, Oct 28, 2011 at 6:24 PM, Zhi Yong Wu wrote: > On Fri, Oct 28, 2011 at 10:20 AM, Lucas Meneghel Rodrigues > wrote: >> On Thu 27 Oct 2011 11:17:48 PM BRST, Zhi Yong Wu wrote: >>> >>> On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues >>>  wrote: On 10/27/2011 05:17 AM, Ste

[Qemu-devel] [PATCH 3/4] qemu-nbd: report errors to syslog when daemonized

2011-10-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 573bf3d..5031158 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -30,6 +30,7 @@ #include #include #include +#include #include

[Qemu-devel] [PATCH 2/4] qemu-nbd: include our own err/errx implementation

2011-10-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- qemu-nbd.c | 30 +- 1 files changed, 29 insertions(+), 1 deletions(-) diff --git a/qemu-nbd.c b/qemu-nbd.c index 972524d..573bf3d 100644 --- a/qemu-nbd.c +++ b/qemu-nbd.c @@ -23,7 +23,6 @@ #include #include #include -#include

Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

2011-10-28 Thread Zhi Yong Wu
On Wed, Sep 21, 2011 at 5:37 PM, Ronnie Sahlberg wrote: > This provides built-in support for iSCSI to QEMU. > This has the advantage that the iSCSI devices need not be made visible to the > host, which is useful if you have very many virtual machines and very many > iscsi devices. > It also has

Re: [Qemu-devel] qemu-img vmdk converted from iso not accepted by vSphere

2011-10-28 Thread Richard Wellum
I see one other report of the same thing on the vmware forums: http://communities.vmware.com/message/1839303 Thanks, ||Rich On Oct 28, 2011, at 5:17 AM, Stefan Hajnoczi wrote: > Rich: Thanks for the ESXi 4.1.0 and vSphere Client 4.1.0 version info. > > Fam: Do you have any suggestions how to

[Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-10-28 Thread Paolo Bonzini
Forking and threading do not behave very well together. With qemu-nbd in -c mode it could happen that the thread pool is started in the parent, and the children (the one actually doing the I/O) is left without working I/O. Fix this by only running bdrv_init in the child process. Reported-by: Pier

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster >>> wrote: Stefan Hajnoczi writes: > On Mon, Oct 24, 2011 at 10:18:43PM +0200, Stefan Weil wrote: >> For

[Qemu-devel] [ANNOUNCE] Xvisor: eXtensible Versatile hypervISOR

2011-10-28 Thread Chauhan, Himanshu
We are pleased to announcing Xvisor v0.1.0, a new open source bare-metal hypervisor, which aims towards providing virtualization solution, which is light-weight, portable, and flexible with small memory foot print and less virtualization overhead. It is distributed under GNU Public License (GPLv2).

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 27.10.2011 16:32, schrieb Kevin Wolf: > Am 27.10.2011 16:15, schrieb Kevin Wolf: >> Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: >>> On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: Am 19.09.2011 16:37, schrieb Frediano Ziglio: > Now that iothread is always compiled sending

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 13:33, schrieb Kevin Wolf: > Am 27.10.2011 16:32, schrieb Kevin Wolf: >> Am 27.10.2011 16:15, schrieb Kevin Wolf: >>> Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: > Am 19.09.2011 16:37, schrieb Frediano Ziglio:

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-28 Thread Lucas Meneghel Rodrigues
On 10/27/2011 11:17 PM, Zhi Yong Wu wrote: On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues wrote: On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote: On Wed, Oct 26, 2011 at 03:19:17PM -0200, Lucas Meneghel Rodrigues wrote: On 10/26/2011 01:47 PM, Kevin Wolf wrote: Am 26.10.2011 16:

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 01:33 PM, Kevin Wolf wrote: I'm afraid that we can only avoid things like this reliably if we convert all devices to be direct users of AIO/coroutines. The current block layer infrastructure doesn't emulate the behaviour of bdrv_read accurately as bottom halves can be run in the nes

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-10-28 Thread Pierre Riteau
Thanks a lot Paolo, I confirm this patchset fixes the bug! -- Pierre Riteau -- PhD student, Myriads team, IRISA, Rennes, France http://perso.univ-rennes1.fr/pierre.riteau/ On 28 oct. 2011, at 12:17, Paolo Bonzini wrote: > Forking and threading do not behave very well together. With qemu-nbd in

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 01:56 PM, Pierre Riteau wrote: Thanks a lot Paolo, I confirm this patchset fixes the bug! Do you believe the limitation on error reporting to be too strong? Paolo

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Kenji Kaneshige
Avi, Jan, Could you comment on these patches? Inject-NMI doesn't work on Windows guest without these patches. Windows seems to setup LVT based on ACPI NMI structure information which is missing in current seabios. LVT LINT1 are never unmasked by Windows guest without the patches. Those patches w

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-10-28 Thread Gleb Natapov
On Fri, Oct 28, 2011 at 09:46:33AM -0200, Lucas Meneghel Rodrigues wrote: > On 10/27/2011 11:17 PM, Zhi Yong Wu wrote: > >On Fri, Oct 28, 2011 at 2:57 AM, Lucas Meneghel Rodrigues > > wrote: > >>On 10/27/2011 05:17 AM, Stefan Hajnoczi wrote: > >>> > >>>On Wed, Oct 26, 2011 at 03:19:17PM -0200, Luc

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-10-28 Thread Pierre Riteau
On 28 oct. 2011, at 13:57, Paolo Bonzini wrote: > On 10/28/2011 01:56 PM, Pierre Riteau wrote: >> Thanks a lot Paolo, I confirm this patchset fixes the bug! > > Do you believe the limitation on error reporting to be too strong? > > Paolo Yes, it would be better if we could have error output on

Re: [Qemu-devel] [PATCH 4/4] qemu-nbd: do not start the block layer in the parent

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 02:16 PM, Pierre Riteau wrote: Yes, it would be better if we could have error output on stderr. Now, "simple" errors such as a missing image file (or wrong path to the image) are reported to syslog instead. It could be the source of some headaches... Is there a way we could have th

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Gleb Natapov
On Fri, Oct 28, 2011 at 09:08:18PM +0900, Kenji Kaneshige wrote: > Avi, Jan, > > Could you comment on these patches? > > Inject-NMI doesn't work on Windows guest without these patches. Windows seems > to setup LVT based on ACPI NMI structure information which is missing in > current > seabios. L

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Cleber Rosa
On 10/28/2011 08:33 AM, Kevin Wolf wrote: Am 27.10.2011 16:32, schrieb Kevin Wolf: Am 27.10.2011 16:15, schrieb Kevin Wolf: Am 27.10.2011 15:57, schrieb Stefan Hajnoczi: On Thu, Oct 27, 2011 at 03:26:23PM +0200, Kevin Wolf wrote: Am 19.09.2011 16:37, schrieb Frediano Ziglio: Now that iothrea

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Kevin Wolf
Am 28.10.2011 13:50, schrieb Paolo Bonzini: > On 10/28/2011 01:33 PM, Kevin Wolf wrote: >> I'm afraid that we can only avoid things like this reliably if we >> convert all devices to be direct users of AIO/coroutines. The current >> block layer infrastructure doesn't emulate the behaviour of bdrv_r

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 1:29 PM, Kevin Wolf wrote: > Am 28.10.2011 13:50, schrieb Paolo Bonzini: >> On 10/28/2011 01:33 PM, Kevin Wolf wrote: >>> I'm afraid that we can only avoid things like this reliably if we >>> convert all devices to be direct users of AIO/coroutines. The current >>> block la

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Stefan Hajnoczi
On Fri, Oct 28, 2011 at 12:07 PM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster wrote: >>> Stefan Hajnoczi writes: >>> On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> O

Re: [Qemu-devel] [PATCH 1/2] seabios: Add Local APIC NMI Structure to ACPI MADT

2011-10-28 Thread Jun Koi
2011/10/28 Kenji Kaneshige : > Avi, Jan, > > Could you comment on these patches? > > Inject-NMI doesn't work on Windows guest without these patches. sorry but i am really curious here: why Windows still works well even if it desnt see the inject-NMI? or there are still invisible side-effects that

[Qemu-devel] ARM hosts: code_gen_alloc() maps code buffer on top of libc heap

2011-10-28 Thread Peter Maydell
I've been tracking down a bug where qemu run on ARM hosts will (about half of the time) abort early in execution with: qemu-system-i386: malloc.c:3096: sYSMALLOc: Assertion `(old_top == (((mbinptr) (((char *) &((av)->bins[((1) - 1) * 2])) - __builtin_offsetof (struct malloc_chunk, fd && old_si

Re: [Qemu-devel] [PATCH] Teach block/vdi about "discarded" (no longer allocated) blocks

2011-10-28 Thread Stefan Weil
Am 28.10.2011 11:22, schrieb Kevin Wolf: Am 28.10.2011 10:15, schrieb Eric Sunshine: On Oct 28, 2011, at 4:00 AM, Kevin Wolf wrote: Am 27.10.2011 18:12, schrieb Stefan Weil: Am 27.10.2011 10:53, schrieb Kevin Wolf: Am 26.10.2011 21:51, schrieb Eric Sunshine: An entry in the VDI block map wi

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 12:07 PM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Fri, Oct 28, 2011 at 9:59 AM, Markus Armbruster >>> wrote: Stefan Hajnoczi writes: > On Fri, Oct 28, 2011 at 8:40 AM, Markus Armbruster > wrote: >

[Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers

2011-10-28 Thread Kevin Wolf
With the conversion of the block layer to coroutines, bdrv_read/write have changed to run a nested event loop that calls qemu_bh_poll. Consequently a scheduled BH can be called while a DMA transfer handler runs and this means that DMA_run becomes reentrant. Devices haven't been designed to cope wi

[Qemu-devel] [PATCH] Fix segfault after migration completes

2011-10-28 Thread Luiz Capitulino
To reproduce: 1. Start the source VM with: # qemu [...] -S 2. Start the destination VM with: # qemu -incoming tcp:0: 3. In the source VM: (qemu) migrate -d tcp:0: 3. The source VM will segfault as soon as migration completes (might not happen in the first try) Here's the bac

[Qemu-devel] [PATCH] qapi: fix typos in documentation JSON examples

2011-10-28 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/qapi-code-gen.txt |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index f345866..c0a9325 100644 --- a/docs/qapi-code-gen.txt +++ b/docs/qapi-code-gen.txt @@ -41,7 +41,7 @@ dictionar

[Qemu-devel] [PATCH] acl: Fix use after free in qemu_acl_reset()

2011-10-28 Thread Markus Armbruster
Reproducer: $ MALLOC_PERTURB_=234 qemu-system-x86_64 -vnc :0,acl,sasl [...] QEMU 0.15.50 monitor - type 'help' for more information (qemu) acl_add vnc.username fred allow acl: added rule at position 1 (qemu) acl_reset vnc.username Segmentation fault (core dumped) Spotted b

[Qemu-devel] [PATCH V3 00/10] Xen PCI Passthrough

2011-10-28 Thread Anthony PERARD
Hi all, This patch series introduces the PCI passthrough for Xen. First, we have HostPCIDevice that help to access one PCI device of the host. Then, there is an additions in the QEMU code, pci_check_bar_overlap. There are also several change in pci_ids and pci_regs. Last part, but not least, t

[Qemu-devel] [PATCH V3 01/10] configure: Introduce --enable-xen-pci-passthrough.

2011-10-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |2 ++ configure | 25 + 2 files changed, 27 insertions(+), 0 deletions(-) diff --git a/Makefile.target b/Makefile.target index fe5f6f7..867d687 100644 --- a/Makefile.target +++ b/Makefile.target @@ -215,6 +215

[Qemu-devel] [PATCH V3 10/10] Introduce Xen PCI Passthrough, MSI (3/3)

2011-10-28 Thread Anthony PERARD
From: Jiang Yunhong Signed-off-by: Jiang Yunhong Signed-off-by: Shan Haitao Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/apic-msidef.h |2 + hw/xen_pci_passthrough.c | 27 ++- hw/xen_pci_passthrough.h |

Re: [Qemu-devel] [PATCH] Fix segfault after migration completes

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 04:58 PM, Luiz Capitulino wrote: To reproduce: 1. Start the source VM with: # qemu [...] -S 2. Start the destination VM with: # qemu -incoming tcp:0: 3. In the source VM: (qemu) migrate -d tcp:0: 3. The source VM will segfault as soon as migration completes (m

[Qemu-devel] [PATCH V3 05/10] pci_regs: Fix value of PCI_EXP_TYPE_RC_EC.

2011-10-28 Thread Anthony PERARD
Value check in PCI Express Base Specification rev 1.1 Signed-off-by: Anthony PERARD --- hw/pci_regs.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index e8357c3..6b42515 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -393,7 +393,7 @@

[Qemu-devel] [PATCH V3 07/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-10-28 Thread Anthony PERARD
From: Allen Kay Signed-off-by: Allen Kay Signed-off-by: Guy Zana Signed-off-by: Anthony PERARD --- Makefile.target |2 + hw/xen_pci_passthrough.c | 838 ++ hw/xen_pci_passthrough.h | 223 ++ hw/xen_pci_passthro

Re: [Qemu-devel] [PATCH] Fix segfault after migration completes

2011-10-28 Thread Eduardo Habkost
On Fri, Oct 28, 2011 at 12:58:04PM -0200, Luiz Capitulino wrote: [...] > > So, 's->file' is NULL in migrate_fd_put_notify(). The interesting thing > is that it's valid in the qemu_file_put_notify() call, which makes me > think that either: there's a race somewhere or qemu_file_put_notify() is > it

[Qemu-devel] [PATCH V3 09/10] Introduce apic-msidef.h

2011-10-28 Thread Anthony PERARD
This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. Signed-off-by: Anthony PERARD --- hw/apic-msidef.h | 28 hw/apic.c| 11 +-- 2 files changed, 29 insertions(+), 10 deletions(-) create mode

[Qemu-devel] [PATCH V3 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-10-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- Makefile.target |1 + hw/host-pci-device.c | 252 ++ hw/host-pci-device.h | 75 +++ 3 files changed, 328 insertions(+), 0 deletions(-) create mode 100644 hw/host-pci-device.c create mode 10

Re: [Qemu-devel] [PATCH v2] block: avoid SIGUSR2

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 02:31 PM, Stefan Hajnoczi wrote: Zhi Yong: We were just talking about converting devices to aio. If you have time to do that for fdc, sd, or any other synchronous API users in hw/ that would be helpful. Please let us know which device you are refactoring so we don't duplicate work

[Qemu-devel] [PATCH V3 04/10] pci_ids: Add INTEL_82599_VF id.

2011-10-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_ids.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 83f3893..2ea5ec2 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -117,6 +117,7 @@ #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939 #define PCI

[Qemu-devel] [PATCH] xen_disk: remove dead code

2011-10-28 Thread Paolo Bonzini
Xen_disk.c has support for using synchronous I/O instead of asynchronous, but it is compiled out by default. Remove it. Signed-off-by: Paolo Bonzini --- hw/xen_disk.c | 86 +--- 1 files changed, 2 insertions(+), 84 deletions(-) diff --git a

[Qemu-devel] [PATCH V3 03/10] pci.c: Add pci_check_bar_overlap

2011-10-28 Thread Anthony PERARD
From: Yuji Shimada This function help Xen PCI Passthrough device to check for overlap. Signed-off-by: Yuji Shimada Signed-off-by: Anthony PERARD --- hw/pci.c | 47 +++ hw/pci.h |3 +++ 2 files changed, 50 insertions(+), 0 deletions(-) diff --

[Qemu-devel] [PATCH V3 06/10] pci_regs: Add PCI_EXP_TYPE_PCIE_BRIDGE

2011-10-28 Thread Anthony PERARD
Signed-off-by: Anthony PERARD --- hw/pci_regs.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/pci_regs.h b/hw/pci_regs.h index 6b42515..56a404b 100644 --- a/hw/pci_regs.h +++ b/hw/pci_regs.h @@ -392,6 +392,7 @@ #define PCI_EXP_TYPE_UPSTREAM 0x5 /* Upstream Port

Re: [Qemu-devel] ARM hosts: code_gen_alloc() maps code buffer on top of libc heap

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 04:32 PM, Peter Maydell wrote: I suspect we need to drop the MAP_FIXED requirement and fix the TCG code to cope with emitting code for longer-range branches for calls to host fns etc (calls/branches within the generated code should be ok to keep using the short-range branch insn I

Re: [Qemu-devel] ARM hosts: code_gen_alloc() maps code buffer on top of libc heap

2011-10-28 Thread Peter Maydell
On 28 October 2011 17:14, Paolo Bonzini wrote: > On 10/28/2011 04:32 PM, Peter Maydell wrote: >> >> I suspect we need to drop the MAP_FIXED requirement and >> fix the TCG code to cope with emitting code for longer-range >> branches for calls to host fns etc (calls/branches within the >> generated

Re: [Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 04:18 PM, Kevin Wolf wrote: With the conversion of the block layer to coroutines, bdrv_read/write have changed to run a nested event loop that calls qemu_bh_poll. Consequently a scheduled BH can be called while a DMA transfer handler runs and this means that DMA_run becomes reentran

Re: [Qemu-devel] [PATCH] Fix compiler warning (always return a value)

2011-10-28 Thread Paolo Bonzini
On 10/28/2011 04:39 PM, Markus Armbruster wrote: > > I'm tempted to continue the thread but at the end of the day we just > need to make the function compile with -NDEBUG. Using abort(3) or Do we? Anyone crazy^Wadventurous enough to compile with -DNDEBUG should be capable of configure --disa

[Qemu-devel] [PATCH v2] Fix segfault on migration completion

2011-10-28 Thread Luiz Capitulino
A simple migration reproduces it: 1. Start the source VM with: # qemu [...] -S 2. Start the destination VM with: # qemu -incoming tcp:0: 3. In the source VM: (qemu) migrate -d tcp:0: 4. The source VM will segfault as soon as migration completes (might not happen in the f

Re: [Qemu-devel] [PATCH 5/8] scsi-disk: add scsi-block for device passthrough

2011-10-28 Thread Kevin Wolf
Am 25.10.2011 12:53, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > hw/scsi-disk.c | 118 > > 1 files changed, 118 insertions(+), 0 deletions(-) This has lost its commit message since the last version. I'll pick it from th

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-10-28 Thread Kevin Wolf
Am 25.10.2011 12:53, schrieb Paolo Bonzini: > Signed-off-by: Paolo Bonzini > --- > block.c|7 +++ > block.h|7 +++ > blockdev.c |8 +--- > 3 files changed, 19 insertions(+), 3 deletions(-) > > diff --git a/block.c b/block.c > index 9873b57..53e21ba 100644 > --- a/

Re: [Qemu-devel] [PATCH 00/11] isa: preliminary work for multiple buses

2011-10-28 Thread Hervé Poussineau
Ping. Hervé Poussineau a écrit : Current patches are a rework of my patches already available at [1]. They don't provide full support for multiple ISA buses (yet), but add a ISABus or ISADevice argument to all ISA functions. They are mostly mechanically touching every instanciation of ISA device

[Qemu-devel] [PATCH] arm_gic: handle banked enable bits for per-cpu interrupts

2011-10-28 Thread Rabin Vincent
The first enable set/clear register (which controls the PPIs and SGIs) is supposed to be banked for each processor. Currently it is just handled globally and this prevents recent SMP Linux kernels from booting, because CPU0 stops receiving localtimer interrupts when CPU1 disables them locally. To

[Qemu-devel] [PATCH 1/2] Allow 1366x768 as a valid VGA resolution

2011-10-28 Thread John Baboval
760p TV panels have a 1366x768 resolution, and have been popular recently as low-cost monitors. The 1366 resolution doesn't pass the (xres & 7) == 0 test. Signed-off-by: John V. Baboval --- hw/vga.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/vga.c b/hw/vga.c in

  1   2   >