Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2011 at 05:06:49PM +1100, David Gibson wrote: > From: Eduard - Gabriel Munteanu > > This updates the eepro100 device emulation to use the explicit PCI DMA > functions, instead of directly calling physical memory access functions. > > Signed-off-by: Eduard - Gabriel Munteanu > Si

Re: [Qemu-devel] [PATCH 03/14] Add stub functions for PCI device models to do PCI DMA

2011-11-02 Thread Michael S. Tsirkin
On Mon, Oct 31, 2011 at 05:06:47PM +1100, David Gibson wrote: > This patch adds functions to pci.[ch] to perform PCI DMA operations. > At present, these are just stubs which perform directly cpu physical > memory accesses. Stubs are included which are analogous to > cpu_physical_memory_{read,write

Re: [Qemu-devel] [PATCH V2] Introduce a new bus "ICC" to connect APIC

2011-11-02 Thread Jan Kiszka
On 2011-11-02 02:40, liu ping fan wrote: > On Tue, Nov 01, 2011 at 02:47:58PM +0100, Jan Kiszka wrote: >> On 2011-11-01 08:41, pingf...@linux.vnet.ibm.com wrote: >>> From: Liu Ping Fan >>> >>> Introduce a new structure CPUS as the controller of ICC (INTERRUPT >>> CONTROLLER COMMUNICATIONS), and ne

Re: [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set

2011-11-02 Thread Paolo Bonzini
On 11/01/2011 08:20 PM, Eduardo Habkost wrote: +/** Calls close function and set last_error if needed + * + * Internal function. qemu_fflush() must be called before this. + * + * Returns f->close() return value, or 0 if close function is not set. + */ +static int qemu_close(QEMUFile *f) {

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > On 10/31/2011 11:45 AM, Stefan Weil wrote: > >Am 31.10.2011 07:06, schrieb David Gibson: > >>From: Eduard - Gabriel Munteanu > >> > >>This updates the eepro100 device emulation to use the explicit PCI DMA > >>functions, instead of d

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Paolo Bonzini
On 11/01/2011 06:11 AM, Jun Koi wrote: This patch removes unused function argument xfds from qemu_iohandler_poll() and qemu_iohandler_fill() I don't think the patch us particularly useful; the arguments are designed to match select. The fact that iohandlers do not support xfds (unlike e.g. g

Re: [Qemu-devel] qemu/qemu-kvm floppy regression brought by 212ec7baa28cc9d819234fed1541fc1423cfe3d8

2011-11-02 Thread Zhi Yong Wu
On Wed, Oct 26, 2011 at 10:41 PM, Lucas Meneghel Rodrigues wrote: > Hi folks: > > We've captured a regression with floppy disk on recent qemu (and qemu-kvm, > after a code merge). We bisected it to be caused by: > > commit 212ec7baa28cc9d819234fed1541fc1423cfe3d8 > Author: Richard Henderson > Dat

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Jun Koi
On Wed, Nov 2, 2011 at 3:40 PM, Paolo Bonzini wrote: > On 11/01/2011 06:11 AM, Jun Koi wrote: >> >> This patch removes unused function argument xfds from >> qemu_iohandler_poll() and qemu_iohandler_fill() > > I don't think the patch us particularly useful; the arguments are designed > to match sel

Re: [Qemu-devel] We have now entered 1.0 hard freeze

2011-11-02 Thread Alon Levy
On Tue, Nov 01, 2011 at 07:43:53PM -0500, Anthony Liguori wrote: > Hi, > > I've just pushed the VERSION update so we are officially in hard freeze. > > I've cleared out my patch and pull request queues and processed > everything I intend on processing for 1.0. > > If you're a contributor and hav

Re: [Qemu-devel] [PATCH v4 4/4] Add support for net bridge

2011-11-02 Thread Mark Wu
On 11/02/2011 01:13 AM, Corey Bryant wrote: static int net_tap_init(QemuOpts *opts, int *vnet_hdr) { int fd, vnet_hdr_required; @@ -433,8 +570,11 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan if (qemu_opt_get(opts, "ifname") ||

[Qemu-devel] CDROM: why can it not be changed to PIO mode?

2011-11-02 Thread Zhi Yong Wu
HI, guys, I managed to change one cdrom on guest from DMA mode to PIO mode, but failed. Did anyone also met this same issue before? If you have some experience to solve this, Can you share with me? /dev/cdrom: Model=QEMU, FwRev=0.15.90, SerialNo=QM3 Config={ Fixed Removeable DTR<=5Mbs DTR>

[Qemu-devel] [PATCH 2/2] block:use g_free instead of free in cloop.c

2011-11-02 Thread Dong Xu Wang
From: Dong Xu Wang Fix mismatching allocation and deallocation: g_free should be used to pair with g_malloc. v3: Split to 2 patches: one for fixing coding style, one for replacing free with g_free. And correct other 2 places with coding style problem. v2: Fix spelling: gfree->g_free. v1: Us

[Qemu-devel] [PATCH 1/2] block:fix cloop.c coding style

2011-11-02 Thread Dong Xu Wang
From: Dong Xu Wang Fix coding style in block/cloop.c. v3: Split to 2 patches: one for fixing coding style, one for replacing free with g_free. And correct other 2 places with coding style problem. v2: Fix spelling: gfree->g_free. v1: Use gfree, to pair with g_malloc. Also fix coding style.

[Qemu-devel] [PATCH v3] Fix X86 CPU topology in KVM mode

2011-11-02 Thread bharata . rao
From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest. Fix this by setting cpuid_apic_id before cpuid info

Re: [Qemu-devel] [PATCH v3] Fix X86 CPU topology in KVM mode

2011-11-02 Thread Jan Kiszka
On 2011-11-02 09:46, bharata@gmail.com wrote: > From: Bharata B Rao > > apic id returned to guest kernel in ebx for cpuid(function=1) depends on > CPUX86State->cpuid_apic_id which gets populated after the cpuid information > is cached in the host kernel. This results in broken CPU topology in

Re: [Qemu-devel] [libvirt] RFC decoupling VM NIC provisioning fromVM NIC connection to backend networks

2011-11-02 Thread Markus Armbruster
"Christian Benvenuti (benve)" writes: >> -Original Message- >> From: qemu-devel-bounces+benve=cisco@nongnu.org > [mailto:qemu-devel- >> bounces+benve=cisco@nongnu.org] On Behalf Of Markus Armbruster >> Sent: Monday, October 31, 2011 7:05 AM >> To: Daniel P. Berrange >> Cc: libvir-

[Qemu-devel] [Bug 855633] Re: guest boots up too slowly

2011-11-02 Thread Yongjie Ren
This is because kvm is not enabled when starting guest by default even if I add KVM support when configuring qemu. Now it got fixed by the following commit. author Marcelo Tosatti Thu, 27 Oct 2011 20:34:42 +0800 (10:34 -0200) committer Marcelo Tosatti Thu, 27 Oct 2011 20:34:42 +0800 (10:34 -020

[Qemu-devel] [Bug 855664] Re: 64-bit windows guest cannot boot up

2011-11-02 Thread Yongjie Ren
same reason as this bug: https://bugs.launchpad.net/qemu/+bug/882358 This is because kvm is not enabled when starting guest by default even if I add KVM support when configuring qemu. Now it got fixed by the following commit. author Marcelo Tosatti Thu, 27 Oct 2011 20:34:42 +0800 (10:34 -0200)

[Qemu-devel] [Bug 855633] Re: guest boots up too slowly

2011-11-02 Thread Yongjie Ren
It's the same reason as the following bug. https://bugs.launchpad.net/qemu/+bug/882358 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/855633 Title: guest boots up too slowly Status in QEMU: F

[Qemu-devel] [RFC] block: convert block_stream command to QAPI

2011-11-02 Thread Stefan Hajnoczi
Move from plain HMP/QMP command implementation to QAPI. The block_stream command takes arguments, returns nothing, may raise errors, and will raise a QMP event when the operation completes. --- Hi Luiz, I converted block_stream to QAPI. The in-tree examples are quite simple so far so I hope I've

Re: [Qemu-devel] [PATCH 1/3] usb-hub: wakeup on attach

2011-11-02 Thread hkran
On 11/01/2011 10:56 PM, Gerd Hoffmann wrote: When attaching a new device we must send a wakeup request to the root hub, otherwise the guest will not notice the new device in case the usb hub is suspended. Signed-off-by: Gerd Hoffmann --- hw/usb-hub.c |1 + 1 files changed, 1 insertions(+)

Re: [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes

2011-11-02 Thread Juan Quintela
Eduardo Habkost wrote: > Summary of the problem: > > - qemu_fclose() calls qemu_fflush() > - Writes done by qemu_fflush() can fail > - Those errors are lost after qemu_fclose() returns > > So, this series change qemu_fclose() to return last_error. But to do that we > need to make sure all involve

Re: [Qemu-devel] [PULL 0/3] 128-bit support for the memory API

2011-11-02 Thread Avi Kivity
On 11/01/2011 08:08 PM, Anthony Liguori wrote: > On 10/30/2011 09:02 AM, Avi Kivity wrote: >> This somewhat controversial patchset converts internal arithmetic in the >> memory API to 128 bits. >> >> It has been argued that with careful coding we can make 64-bit work as >> well. I don't think this

Re: [Qemu-devel] [PULL 0/3] 128-bit support for the memory API

2011-11-02 Thread Avi Kivity
On 11/01/2011 03:48 PM, Andreas Färber wrote: > > > > Since it's just internal, I'll just pull this series and if we want to > > change it post 1.0, we can. > > FWIW I must say I don't like where this is heading... iiuc just because > of a zero-or-full-64-bits issue with start+end It's not just

[Qemu-devel] [PULL] Virtfs update

2011-11-02 Thread Aneesh Kumar K.V
The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-upstream-8 Aneesh Kumar K.V (1): hw/9pfs: Move opt validation to FsDriver callbac

Re: [Qemu-devel] [patch] remove unused function arg in qemu_iohandler_poll() and qemu_iohandler_fill()

2011-11-02 Thread Stefan Hajnoczi
On Wed, Nov 2, 2011 at 1:46 AM, Jun Koi wrote: > On Tue, Nov 1, 2011 at 11:05 PM, Anthony Liguori > wrote: >> On 11/01/2011 12:11 AM, Jun Koi wrote: >>> >>> This patch removes unused function argument xfds from >>> qemu_iohandler_poll() and qemu_iohandler_fill() >>> >>> Signed-off-by: Jun Koi >>

Re: [Qemu-devel] [Bug 884942] [NEW] hw/usb.c:336: usb_packet_complete: Assertion `p->owner != ((void *)0)' failed.

2011-11-02 Thread Stefan Hajnoczi
On Tue, Nov 1, 2011 at 9:31 PM, Alon Bar-Lev wrote: > Public bug reported: > > qemu-system-x86_64 -no-quit -drive file=disk1.img -net nic -net > tap,ifname=vm0,script=/bin/true,vhost=on -m 512 -monitor > tcp:127.0.0.1:4445,server,nowait -localtime -usb -usbdevice > host:054C:0268 This assertion f

Re: [Qemu-devel] [PATCH v4 1/4] Add basic version of bridge helper

2011-11-02 Thread Stefan Hajnoczi
On Tue, Nov 1, 2011 at 5:13 PM, Corey Bryant wrote: > +static bool has_vnet_hdr(int fd) > +{ > +    unsigned int features = 0; > +    struct ifreq ifreq; > + > +    if (ioctl(fd, TUNGETFEATURES, &features) == -1) { > +        return false; > +    } > + > +    if (!(features & IFF_VNET_HDR)) { > +

Re: [Qemu-devel] [PATCH 0/8] block: generic image streaming

2011-11-02 Thread Stefan Hajnoczi
On Tue, Nov 1, 2011 at 4:46 PM, Marcelo Tosatti wrote: > On Thu, Oct 27, 2011 at 04:22:47PM +0100, Stefan Hajnoczi wrote: >> This series adds the 'block_stream' command which copies the contents of a >> backing file into the image file while the VM is running.  The series builds >> on >> copy-on-

Re: [Qemu-devel] [patch] add auto-generated files into .gitignore

2011-11-02 Thread Stefan Hajnoczi
On Wed, Nov 2, 2011 at 1:39 AM, Jun Koi wrote: > This patch adds some auto-generated files into .gitignore > > Signed-off-by: Jun Koi An equivalent patch by David Gibson has already been merged, see 4f39d27fe4e8109ba9eb2983b27675f2ca6d3ecb. Stefan

Re: [Qemu-devel] [PATCH v2] qed: adjust the way to get nb_sectors

2011-11-02 Thread Kevin Wolf
Am 01.11.2011 09:04, schrieb Zhi Yong Wu: > This patch is only to refactor some lines of codes to get better and more > robust codes. > > As you have seen, in qed_read_table_cb() it's nice to > use qiov->size because that function doesn't obviously use a single > struct iovec. > > In other two f

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Stefan Hajnoczi
On Tue, Nov 1, 2011 at 9:03 PM, Thomas Schmitt wrote: > Hi, > > Stefan Hajnoczi wrote: >> In the future I think it's appropriate to CC qemu-devel since others >> in the community may be interested in virtio-scsi discussions too. > > Ok. I'll forward my original mail and this reply to qemu-devel. >

Re: [Qemu-devel] [PATCH v11 1/4] block: add the blockio limits command line support

2011-11-02 Thread Kevin Wolf
Am 02.11.2011 07:01, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > Signed-off-by: Stefan Hajnoczi > --- > block.c | 40 > block.h |4 > block_int.h | 29 + > blockdev.c | 44 +++

Re: [Qemu-devel] [PATCH v11 2/4] block: add I/O throttling algorithm

2011-11-02 Thread Kevin Wolf
Am 02.11.2011 07:01, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > Signed-off-by: Stefan Hajnoczi > --- > block.c | 233 > +++-- > block.h |1 + > block_int.h |1 + > qemu-coroutine-lock.c |8 ++

Re: [Qemu-devel] [PATCH 03/14] Add stub functions for PCI device models to do PCI DMA

2011-11-02 Thread David Gibson
On Wed, Nov 02, 2011 at 09:17:37AM +0200, Michael S. Tsirkin wrote: > On Mon, Oct 31, 2011 at 05:06:47PM +1100, David Gibson wrote: > > This patch adds functions to pci.[ch] to perform PCI DMA operations. > > At present, these are just stubs which perform directly cpu physical > > memory accesses.

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Michael S. Tsirkin
On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > >Hi, > > > >the patch looks reasonable. I only suggest a formal change: > > > >There are lots of unnecessary type casts in several of your patches. > >I marked them here, but they should be removed anywhere. > > Agreed. However, I

[Qemu-devel] [PATCH] intel-hda: fix stream search

2011-11-02 Thread Gerd Hoffmann
commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug: The stream-not-found case doesn't error out any more, instead the code silently uses the first stream. Fix it. Signed-off-by: Gerd Hoffmann --- hw/intel-hda.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --gi

Re: [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set

2011-11-02 Thread Eduardo Habkost
On Wed, Nov 02, 2011 at 08:33:05AM +0100, Paolo Bonzini wrote: > On 11/01/2011 08:20 PM, Eduardo Habkost wrote: > >+/** Calls close function and set last_error if needed > >+ * > >+ * Internal function. qemu_fflush() must be called before this. > >+ * > >+ * Returns f->close() return value, or 0 if

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 12:25 PM, Stefan Hajnoczi wrote: Now i have two drives by one option. xorriso -devices reports 0 -dev '/dev/sr0' rwrw-- : 'TSSTcorp' 'CDDVDW SH-S223B' 1 -dev '/dev/sr1' rwrw-- : 'QEMU' 'QEMU DVD-ROM' with /dev/sr1 being an empty drive. (Is this a known bug ?) Off the t

[Qemu-devel] [PATCH] hw/9pfs: Move opt validation to FsDriver callback

2011-11-02 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" This remove all conditional code from common code path and make opt validation a FSDriver callback. Signed-off-by: Aneesh Kumar K.V --- fsdev/file-op-9p.h | 15 +-- fsdev/qemu-fsdev.c | 44 ++-- fs

Re: [Qemu-devel] [PATCH] intel-hda: fix stream search

2011-11-02 Thread Markus Armbruster
Gerd Hoffmann writes: > commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug: > The stream-not-found case doesn't error out any more, instead the > code silently uses the first stream. Fix it. > > Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 12:56 PM, Eduardo Habkost wrote: No, if it's positive it won't be set on last_error, so we have to save it somewhere other than last_error (that's what the qemu_close() return value is used for). Ok, I was confused by your patch 6, which basically removes the only case when qemu_

Re: [Qemu-devel] [PATCH] intel-hda: fix stream search

2011-11-02 Thread Andreas Färber
Am 02.11.2011 12:56, schrieb Gerd Hoffmann: > commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug: > The stream-not-found case doesn't error out any more, instead the > code silently uses the first stream. Fix it. > > Signed-off-by: Gerd Hoffmann > --- > hw/intel-hda.c |2 +- >

[Qemu-devel] [PATCH 1.0] virtio-blk: pass full status to the guest

2011-11-02 Thread Paolo Bonzini
When SCSI passthrough is being used by the guest with virtio-blk, the guest is not able to detect disk failures. This is because the status field is expected by the guest driver to include also the msg_status, host_status and driver_status fields, but the device is only passing down the SCSI statu

Re: [Qemu-devel] [PATCH] intel-hda: fix stream search

2011-11-02 Thread Kevin Wolf
Am 02.11.2011 13:18, schrieb Andreas Färber: > Am 02.11.2011 12:56, schrieb Gerd Hoffmann: >> commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug: >> The stream-not-found case doesn't error out any more, instead the >> code silently uses the first stream. Fix it. >> >> Signed-off-by:

Re: [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set

2011-11-02 Thread Eduardo Habkost
On Wed, Nov 02, 2011 at 01:15:46PM +0100, Paolo Bonzini wrote: > On 11/02/2011 12:56 PM, Eduardo Habkost wrote: > >No, if it's positive it won't be set on last_error, so we have to save > >it somewhere other than last_error (that's what the qemu_close() return > >value is used for). > > Ok, I was

Re: [Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error

2011-11-02 Thread Eduardo Habkost
On Tue, Nov 01, 2011 at 05:20:25PM -0200, Eduardo Habkost wrote: > This is what qemu_fclose() expects. > > Signed-off-by: Eduardo Habkost > --- > savevm.c |5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 3c746a6..63dd719 100644 > ---

Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR

2011-11-02 Thread Anthony Liguori
On 11/01/2011 10:22 PM, Rusty Russell wrote: On Tue, 01 Nov 2011 17:20:06 -0500, Anthony Liguori wrote: On 09/30/2011 12:26 AM, David Gibson wrote: Currently, virtio devices are usually presented to the guest as an emulated PCI device, virtio_pci. Although the actual IO operations are done th

Re: [Qemu-devel] [PULL] Virtfs update

2011-11-02 Thread Anthony Liguori
On 11/02/2011 05:22 AM, Aneesh Kumar K.V wrote: The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) are available in the git repository at: git://repo.or.cz/qemu/v9fs.git for-upstream-8 Aneesh Kumar K.V (1):

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Anthony Liguori
On 11/02/2011 02:40 AM, Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: On 10/31/2011 11:45 AM, Stefan Weil wrote: Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation to use the explic

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Paolo Bonzini
On 10/31/2011 06:13 PM, Stefan Weil wrote: They can't be more broken: I noticed today that QEMU on W32 aborts with the default timer (mmtimer) very quickly. Is there any reason why mmtimer2 is not the default (or indeed why mmtimer and win32 exist)? Paolo

Re: [Qemu-devel] [PATCH] intel-hda: fix stream search

2011-11-02 Thread Anthony Liguori
On 11/02/2011 06:56 AM, Gerd Hoffmann wrote: commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug: The stream-not-found case doesn't error out any more, instead the code silently uses the first stream. Fix it. Signed-off-by: Gerd Hoffmann Applied. Thanks. Regards, Anthony Liguo

Re: [Qemu-devel] [PATCH 1.0] virtio-blk: pass full status to the guest

2011-11-02 Thread Anthony Liguori
On 11/02/2011 07:19 AM, Paolo Bonzini wrote: When SCSI passthrough is being used by the guest with virtio-blk, the guest is not able to detect disk failures. This is because the status field is expected by the guest driver to include also the msg_status, host_status and driver_status fields, but

Re: [Qemu-devel] [PATCH 1/3] usb-hub: wakeup on attach

2011-11-02 Thread Gerd Hoffmann
Hi, >> static void usb_hub_detach(USBPort *port1) > pulled, In what cases, the usb hub will be suspended? and how to tell it > happened? thanks. The guest enables the remote-wakeup feature. 'lspci -v' (within the guest) shows it. cheers, Gerd

Re: [Qemu-devel] [PATCH v3] Fix X86 CPU topology in KVM mode

2011-11-02 Thread Anthony Liguori
On 11/02/2011 03:46 AM, bharata@gmail.com wrote: From: Bharata B Rao apic id returned to guest kernel in ebx for cpuid(function=1) depends on CPUX86State->cpuid_apic_id which gets populated after the cpuid information is cached in the host kernel. This results in broken CPU topology in guest

Re: [Qemu-devel] [PATCH 1.0] virtio-blk: pass full status to the guest

2011-11-02 Thread Michael S. Tsirkin
On Wed, Nov 02, 2011 at 01:19:40PM +0100, Paolo Bonzini wrote: > When SCSI passthrough is being used by the guest with virtio-blk, the > guest is not able to detect disk failures. This is because the status > field is expected by the guest driver to include also the msg_status, > host_status and d

Re: [Qemu-devel] We have now entered 1.0 hard freeze

2011-11-02 Thread Max Filippov
Hi. > If you're a contributor and have a question about a patch that didn't make > the hard freeze, please feel free to ask about it, but at this point, it's > very unlikely to make it to 1.0. My pull request for the xtensa (http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg03962.html) h

Re: [Qemu-devel] We have now entered 1.0 hard freeze

2011-11-02 Thread Anthony Liguori
On 11/02/2011 08:08 AM, Max Filippov wrote: Hi. If you're a contributor and have a question about a patch that didn't make the hard freeze, please feel free to ask about it, but at this point, it's very unlikely to make it to 1.0. My pull request for the xtensa (http://lists.nongnu.org/archiv

Re: [Qemu-devel] [PATCH 1.0] virtio-blk: pass full status to the guest

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 02:00 PM, Michael S. Tsirkin wrote: > When SCSI passthrough is being used by the guest with virtio-blk, the > guest is not able to detect disk failures. This is because the status > field is expected by the guest driver to include also the msg_status, > host_status and driver_s

Re: [Qemu-devel] We have now entered 1.0 hard freeze

2011-11-02 Thread Peter Maydell
On 2 November 2011 13:10, Anthony Liguori wrote: > On 11/02/2011 08:08 AM, Max Filippov wrote: >> And also I'd like it to be clarified, whether I should consider myself >> a contributor or a submaintainer. > > If you do PULL requests, you're a submaintainer :-) Speaking as somebody who spent a wh

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Stefan Weil
Am 02.11.2011 13:54, schrieb Paolo Bonzini: On 10/31/2011 06:13 PM, Stefan Weil wrote: They can't be more broken: I noticed today that QEMU on W32 aborts with the default timer (mmtimer) very quickly. Is there any reason why mmtimer2 is not the default (or indeed why mmtimer and win32 exis

[Qemu-devel] [PATCH v2] target-xtensa: mask out undefined bits of WINDOWSTART SR

2011-11-02 Thread Max Filippov
According to ISA, table 5-156, bits 32:NAREG/4 of the WINDOWSTART SR must be zero. Signed-off-by: Max Filippov --- v1->v2 changes: fix commit log subject --- target-xtensa/translate.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-xtensa/translate.c b/target-xte

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 02:31 PM, Stefan Weil wrote: Commit 2f9cba0c148af32fad6813480f5c92efe17c2d49 re-added mmtimer2 because it had existed before (it was called "dynticks" and the default for w32) and was needed for Linux. It also added mmtimer, a multimedia timer without rearm. Yes, I missed that it

Re: [Qemu-devel] [PATCH 1/2] block:fix cloop.c coding style

2011-11-02 Thread Kevin Wolf
Am 02.11.2011 09:36, schrieb Dong Xu Wang: > From: Dong Xu Wang > > Fix coding style in block/cloop.c. > > v3: Split to 2 patches: one for fixing coding style, one for replacing free > with > g_free. And correct other 2 places with coding style problem. > v2: Fix spelling: gfree->g_free. >

[Qemu-devel] [Bug 885213] [NEW] Latest GIT version fails to compile on Linux cris-softmmu/pci-stub.c

2011-11-02 Thread Nigel Horne
Public bug reported: The latest GIT version (e072ea2fd8fdceef64159b9596d3c15ce01bea91) fails to compile. Host: debian x86-64. gcc 4.6.2 ... CCcris-softmmu/pci-stub.o ... In file included from /home/njh/src/qemu/hw/pci-stub.c:24:0: ./qmp-commands.h: At top level: ./qmp-commands.h:3:1: erro

Re: [Qemu-devel] [PULL] Virtfs update

2011-11-02 Thread Aneesh Kumar K.V
On Wed, 02 Nov 2011 07:42:16 -0500, Anthony Liguori wrote: > On 11/02/2011 05:22 AM, Aneesh Kumar K.V wrote: > > > > The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: > > > >Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) > > > > are available in the git reposito

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Thomas Schmitt
Hi, Stefan Hajnoczi wrote: > I actually suggest focussing just > on qemu.git/master because that is where developers mostly invest > their time. I did now git clone git://git.qemu.org/qemu.git cd qemu && ./configure && make I assume this binary is the right one for my "AMD Athlon(tm) II X4 6

[Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread Fabien Chouteau
Hello fellow Qemu aficionados, On Windows, Qemu sets the affinity mask in order to run all thread on CPU0, with this comment in the code (os-win32.c:182): /* Note: cpu_interrupt() is currently not SMP safe, so we force QEMU to run on a single CPU */ This was added by Fabrice Bellard i

Re: [Qemu-devel] [PATCH 3/8] block: add image streaming block job

2011-11-02 Thread Stefan Hajnoczi
On Tue, Nov 1, 2011 at 6:06 PM, Marcelo Tosatti wrote: > On Thu, Oct 27, 2011 at 04:22:50PM +0100, Stefan Hajnoczi wrote: >> +static int stream_one_iteration(StreamBlockJob *s, int64_t sector_num, >> +                                void *buf, int max_sectors, int *n) >> +{ >> +    BlockDriverStat

Re: [Qemu-devel] [PATCH v4 1/4] Add basic version of bridge helper

2011-11-02 Thread Corey Bryant
On 11/02/2011 06:58 AM, Stefan Hajnoczi wrote: On Tue, Nov 1, 2011 at 5:13 PM, Corey Bryant wrote: +static bool has_vnet_hdr(int fd) +{ +unsigned int features = 0; +struct ifreq ifreq; + +if (ioctl(fd, TUNGETFEATURES,&features) == -1) { +return false; +} + +if (!(fea

Re: [Qemu-devel] [PULL] Virtfs update

2011-11-02 Thread Markus Armbruster
Anthony Liguori writes: > On 11/02/2011 05:22 AM, Aneesh Kumar K.V wrote: >> >> The following changes since commit e072ea2fd8fdceef64159b9596d3c15ce01bea91: >> >>Bump version to 1.0-rc0 (2011-11-01 19:37:01 -0500) >> >> are available in the git repository at: >>git://repo.or.cz/qemu/v9fs.

Re: [Qemu-devel] [PATCH v4 4/4] Add support for net bridge

2011-11-02 Thread Corey Bryant
On 11/02/2011 04:12 AM, Mark Wu wrote: On 11/02/2011 01:13 AM, Corey Bryant wrote: static int net_tap_init(QemuOpts *opts, int *vnet_hdr) { int fd, vnet_hdr_required; @@ -433,8 +570,11 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan if (qemu_opt_get(opts, "i

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 04:15 PM, Thomas Schmitt wrote: Hi, Stefan Hajnoczi wrote: I actually suggest focussing just on qemu.git/master because that is where developers mostly invest their time. I did now git clone git://git.qemu.org/qemu.git cd qemu&& ./configure&& make I assume this binary i

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 04:38 PM, Fabien Chouteau wrote: Hello fellow Qemu aficionados, On Windows, Qemu sets the affinity mask in order to run all thread on CPU0, with this comment in the code (os-win32.c:182): /* Note: cpu_interrupt() is currently not SMP safe, so we force QEMU to run on a

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Thomas Schmitt
Hi, Paolo Bonzini wrote: > I suggest trying with 1.0-rc (origin/master). Am i on the right track with git clone git://git.qemu.org/qemu.git ? > scsi-block uses > read+write for READ/WRITE CDBs and SG_IO for everything else. That sounds scary to me. On real Linux systems it is not advisable t

Re: [Qemu-devel] [RFC 1/6] block: add request tracking

2011-11-02 Thread Kevin Wolf
Am 17.10.2011 17:47, schrieb Stefan Hajnoczi: > The block layer does not know about pending requests. This information > is necessary for copy-on-read since overlapping requests must be > serialized to prevent races that corrupt the image. > > Add a simple mechanism to enable/disable request trac

Re: [Qemu-devel] [RFC 2/6] block: add bdrv_set_copy_on_read()

2011-11-02 Thread Kevin Wolf
Am 17.10.2011 17:47, schrieb Stefan Hajnoczi: > The bdrv_set_copy_on_read() function can be used to programmatically > enable or disable copy-on-read for a block device. Later patches add > the actual copy-on-read logic. > > Signed-off-by: Stefan Hajnoczi > --- > block.c | 17

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 05:26 PM, Thomas Schmitt wrote: Hi, Paolo Bonzini wrote: I suggest trying with 1.0-rc (origin/master). Am i on the right track with git clone git://git.qemu.org/qemu.git ? Yes. scsi-block uses read+write for READ/WRITE CDBs and SG_IO for everything else. That sounds scar

Re: [Qemu-devel] [PATCH 3/8] block: add image streaming block job

2011-11-02 Thread Kevin Wolf
Am 02.11.2011 16:43, schrieb Stefan Hajnoczi: > On Tue, Nov 1, 2011 at 6:06 PM, Marcelo Tosatti wrote: >> On Thu, Oct 27, 2011 at 04:22:50PM +0100, Stefan Hajnoczi wrote: >>> +static int stream_one_iteration(StreamBlockJob *s, int64_t sector_num, >>> +void *buf, int

Re: [Qemu-devel] [Bug 885213] [NEW] Latest GIT version fails to compile on Linux cris-softmmu/pci-stub.c

2011-11-02 Thread Stefan Weil
Am 02.11.2011 14:26, schrieb Nigel Horne: Public bug reported: The latest GIT version (e072ea2fd8fdceef64159b9596d3c15ce01bea91) fails to compile. Host: debian x86-64. gcc 4.6.2 ... CCcris-softmmu/pci-stub.o ... In file included from /home/njh/src/qemu/hw/pci-stub.c:24:0: ./qmp-command

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Alexander Graf
Michael S. Tsirkin wrote: > On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: > >> On 10/31/2011 11:45 AM, Stefan Weil wrote: >> >>> Am 31.10.2011 07:06, schrieb David Gibson: >>> From: Eduard - Gabriel Munteanu This updates the eepro100 device emulation

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Anthony Liguori wrote: > On 09/27/2011 09:26 AM, Avi Kivity wrote: >> Has no business in hw/. >> >> Signed-off-by: Avi Kivity > > Applied. Thanks. make: *** No rule to make target `/home/agraf/release/qemu/hw/event_notifier.c', needed by `event_notifier.o'. Stop. make: *** Waiting for unfinished

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread Fabien Chouteau
On 02/11/2011 17:25, Paolo Bonzini wrote: > On 11/02/2011 04:38 PM, Fabien Chouteau wrote: >> Hello fellow Qemu aficionados, >> >> On Windows, Qemu sets the affinity mask in order to run all thread on >> CPU0, with this comment in the code (os-win32.c:182): >> >> /* Note: cpu_interrupt() is cu

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 08:10 PM, Alexander Graf wrote: > Anthony Liguori wrote: > > On 09/27/2011 09:26 AM, Avi Kivity wrote: > >> Has no business in hw/. > >> > >> Signed-off-by: Avi Kivity > > > > Applied. Thanks. > > make: *** No rule to make target > `/home/agraf/release/qemu/hw/event_notifier.c', need

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 07:12 PM, Avi Kivity wrote: > On 11/02/2011 08:10 PM, Alexander Graf wrote: > > Anthony Liguori wrote: > > > On 09/27/2011 09:26 AM, Avi Kivity wrote: > > >> Has no business in hw/. > > >> > > >> Signed-off-by: Avi Kivity > > > > > > Applied. Thanks. > > > > make: *** No rule to make

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread malc
On Wed, 2 Nov 2011, Fabien Chouteau wrote: > On 02/11/2011 17:25, Paolo Bonzini wrote: > > On 11/02/2011 04:38 PM, Fabien Chouteau wrote: > >> Hello fellow Qemu aficionados, > >> > >> On Windows, Qemu sets the affinity mask in order to run all thread on > >> CPU0, with this comment in the code (os

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Anthony Liguori
On 11/02/2011 12:56 PM, Alexander Graf wrote: Michael S. Tsirkin wrote: On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: What does it get us, applying it before freeze? It's an api change without new functionality. Seems better on -next branch. It gets us that downstreams can

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Avi Kivity wrote: > On 11/02/2011 07:12 PM, Avi Kivity wrote: > >> On 11/02/2011 08:10 PM, Alexander Graf wrote: >> >>> Anthony Liguori wrote: >>> On 09/27/2011 09:26 AM, Avi Kivity wrote: > Has no business in hw/. > > Signed-off-by: Avi Kivity >

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Avi Kivity
On 11/02/2011 08:23 PM, Alexander Graf wrote: > > > > Plus, remove the tachyons from your system. > > > > Ah, yes. That helped a lot. Damn those tachyons! They're still there. (I hate explaining a joke, but your system clock is an hour ahead) -- error compiling committee.c: too many argument

Re: [Qemu-devel] [PATCH] event_notifier: move to top-level directory

2011-11-02 Thread Alexander Graf
Avi Kivity wrote: > On 11/02/2011 08:23 PM, Alexander Graf wrote: > >>> Plus, remove the tachyons from your system. >>> >>> >> Ah, yes. That helped a lot. Damn those tachyons! >> > > They're still there. > > (I hate explaining a joke, but your system clock is an hour ahead) >

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-11-02 Thread Alexander Graf
Anthony Liguori wrote: > On 11/02/2011 12:56 PM, Alexander Graf wrote: >> Michael S. Tsirkin wrote: >>> On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: >>> >>> What does it get us, applying it before freeze? >>> It's an api change without new functionality. >>> Seems better on -nex

Re: [Qemu-devel] [PATCH 1/2] tcg: Fix regression in tcg_gen_deposit_i64.

2011-11-02 Thread Alexander Graf
Richard Henderson wrote: > The error being caused by the failure to copy the other half of > the input to the output after having narrowed the deposit operation. > Thanks, this makes my ppc32 host work again :) Alex

[Qemu-devel] unable to set security context error ...

2011-11-02 Thread Onkar N Mahajan
I am getting 'system_u:object_r:svirt_image_t:s0:c129,c783' on '/var/lib/libvirt/images/vm01.img': Permission denied' when I try to install using virt-manager. #semanage fcontext -l | grep images /var/lib/libvirt/images(/.*)? all files system_u:object_r:svirt_imag

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-02 Thread Fabien Chouteau
On 31/10/2011 14:12, Peter Maydell wrote: > On 29 October 2011 14:52, Alexander Graf wrote: >> A lot of people seem to also have code that doesn't make sense >> upstream, for example implementing a one-off device that only >> really matters for their own devboard which nobody else owns. >> For suc

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread Paolo Bonzini
On 11/02/2011 06:16 PM, malc wrote: (mm)Timers have a possibility of running on a thread of their own which might be schedulled on the CPU different from the thread that runs emulated code, unchaining TBs and can (and will) fail in this case. This should not be a problem with dynticks+iothread

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread malc
On Wed, 2 Nov 2011, Paolo Bonzini wrote: > On 11/02/2011 06:16 PM, malc wrote: > > (mm)Timers have a possibility of running on a thread of their own which > > might be schedulled on the CPU different from the thread that runs > > emulated code, unchaining TBs and can (and will) fail in this case.

Re: [Qemu-devel] Multiple instances of Qemu on Windows multicore

2011-11-02 Thread Peter Maydell
On 2 November 2011 17:45, Paolo Bonzini wrote: > The rest is always done in the iothread.  The iothread will then > suspend/resume the VCPU thread around the unchaining, so what matters is (in > Unix parlance) signal-safety of the unchaining, not thread-safety. The unchaining is neither signal-sa

Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ?

2011-11-02 Thread Thomas Schmitt
Hi, i wrote: > > The sense code is listed in MMC as: > >B 00 06 I/O PROCESS TERMINATED Paolo Bonzini wrote: > Is it good or bad? :) I see it even in the very first command. It does not indicate success. MMC only has the meager info above. SPC-3 says in table 27 about sense key B: "Bh : AB

Re: [Qemu-devel] GSoC mentor summit QEMU users session

2011-11-02 Thread Jan Kiszka
On 2011-11-02 18:44, Fabien Chouteau wrote: > On 31/10/2011 14:12, Peter Maydell wrote: >> On 29 October 2011 14:52, Alexander Graf wrote: >>> A lot of people seem to also have code that doesn't make sense >>> upstream, for example implementing a one-off device that only >>> really matters for the

[Qemu-devel] Catching system calls and PIDs in Qemu

2011-11-02 Thread Ricardo Alves
Need Help! I am editing the Qemu source code to be able to catch every system call made by the guest OS and which processes do those system calls. I catch the system calls in the "void do_interrupt(CPUState *env1)" (op_helper.c) function by accessing the exception index on the cpu environment

  1   2   >