Re: [Qemu-devel] [PATCH] tcg: Remove redundant declarations of TCG_TARGET_REG_BITS

2011-12-07 Thread Stefan Weil
Am 08.12.2011 08:03, schrieb 陳韋任: On Wed, Dec 07, 2011 at 11:31:46PM +0100, Stefan Weil wrote: TCG_TARGET_REG_BITS is declared in tcg.h for all TCG targets. Just want to make sure. When we talk about target in TCG, that _always_ means the host, right? Regards, chenwj Yes. See file tcg/REA

Re: [Qemu-devel] [PATCH] tcg: Remove redundant declarations of TCG_TARGET_REG_BITS

2011-12-07 Thread 陳韋任
On Wed, Dec 07, 2011 at 11:31:46PM +0100, Stefan Weil wrote: > TCG_TARGET_REG_BITS is declared in tcg.h for all TCG targets. Just want to make sure. When we talk about target in TCG, that _always_ means the host, right? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of

[Qemu-devel] [PATCH] Fix parse of usb device description with multiple configurations

2011-12-07 Thread Cao,Bing Bu
When testing ipod on QEMU by He Jie Xu,qemu made a assertion. We found that the ipod with 2 configurations,and the usb-linux did not parse the descriptor correctly. The descr_len returned is the total length of the all configurations,not one configuration. The older version will through the oth

[Qemu-devel] [PATCH] use pci macro in virtio

2011-12-07 Thread hkran
Signed-off-by: hkran --- hw/virtio-pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c665f5c..f8ee772 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -627,9 +627,9 @@ void virtio_init_pci(VirtIOPCIProxy *proxy, VirtI

[Qemu-devel] [PATCH] block/cow : return real error code in cow.c

2011-12-07 Thread Li Zhi Hui
Signed-off-by: Li Zhi Hui --- block/cow.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/block/cow.c b/block/cow.c index 3c52735..383482b 100644 --- a/block/cow.c +++ b/block/cow.c @@ -64,10 +64,11 @@ static int cow_open(BlockDriverState *bs, int f

[Qemu-devel] [PATCH 3/3] linux-user:Signal handling for MIPS64

2011-12-07 Thread khansa
From: Khansa Butt Signed-off-by: Ehsan Ul Haq --- linux-user/signal.c | 429 +-- 1 files changed, 417 insertions(+), 12 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 78e3380..0f4091d 100644 --- a/linux-user/signal.c

[Qemu-devel] [PATCH 2/3] target-mips:enabling of 64 bit user mode and floating point operations MIPS_HFLAG_UX is included in env->hflags so that the address computation for LD instruction does not tre

2011-12-07 Thread khansa
From: Khansa Butt Signed-off-by: Abdul Qadeer --- target-mips/translate.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index d5b1c76..452a63b 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c @@ -

[Qemu-devel] [PATCH 1/3] linux-user:Support for MIPS64 user mode emulation in QEMU

2011-12-07 Thread khansa
From: Khansa Butt Signed-off-by: Khansa Butt --- configure |1 + default-configs/mips64-linux-user.mak |1 + linux-user/main.c | 21 +++-- linux-user/mips64/syscall.h |2 ++ 4 files changed, 23 insertions(+

[Qemu-devel] [PATCH 0/3] MIPS64 user mode emulation in QEMU

2011-12-07 Thread khansa
From: Khansa Butt This is the team work of Ehsan-ul-Haq, Abdul Qadeer, Abdul Waheed, Khansa Butt from HPCN Lab KICS UET Lahore. In previous patch set we were including Cavium specific instructions along with Cavium specifc registers in UME. Because of these register fields we had to bump the cpu

Re: [Qemu-devel] [PATCH v2] network scripts: don't block SIGCHLD before forking

2011-12-07 Thread Michael Roth
Bah, missed a 'git add', will resend. Sorry for the noise.

[Qemu-devel] [PATCH v3] network scripts: don't block SIGCHLD before forking

2011-12-07 Thread Michael Roth
This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling waitpid(-1, ...). This required other fork()/wai

[Qemu-devel] [PATCH v2] network scripts: don't block SIGCHLD before forking

2011-12-07 Thread Michael Roth
This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling waitpid(-1, ...). This required other fork()/wai

[Qemu-devel] [PATCH] network scripts: don't block SIGCHLD before forking

2011-12-07 Thread Michael Roth
This patch fixes a bug where child processes of launch_script() can misbehave due to SIGCHLD being blocked. In the case of `sudo`, this causes a permanent hang. Previously a SIGCHLD handler was added to reap fork_exec()'d zombie processes by calling waitpid(-1, ...). This required other fork()/wai

Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci

2011-12-07 Thread Anthony Liguori
On 12/07/2011 03:39 AM, hkran wrote: Signed-off-by: hkran A Signed-off-by line needs to use your full name. Regards, Anthony Liguori --- hw/virtio-pci.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index c665f5c..f8ee772 100644

Re: [Qemu-devel] [PATCH] use PCI MACRO in virtio-pci

2011-12-07 Thread hkran
On 12/07/2011 06:18 PM, Stefan Hajnoczi wrote: On Wed, Dec 7, 2011 at 9:39 AM, hkran wrote: Signed-off-by: hkran --- hw/virtio-pci.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) This patch is line-wrapped and git-am refuses to apply it. Are you using git-send-email(1)?

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread andrzej zaborowski
On 7 December 2011 19:56, Peter Maydell wrote: > On 7 December 2011 07:47, Andrzej Zaborowski wrote: >> Cocoa can only be enabled on Darwin, and is enabled by default too, >> making --enable-cocoa redundant, with no way to disable Cocoa.  It >> also interfered with SDL support in a way that was d

Re: [Qemu-devel] [PATCH 3/3] configure: add '--disable-cocoa' switch

2011-12-07 Thread Andreas Färber
Am 10.11.2011 19:40, schrieb Pavel Borzenkov: > When SDL support is disabled, there is no way to build QEMU without > Cocoa support on MacOS X. This patch adds '--disable-cocoa' switch and > allows to build QEMU without both SDL and Cocoa frontends. > > Signed-off-by: Pavel Borzenkov > --- > con

Re: [Qemu-devel] [PATCH 2/3] raw-posix: Do not use CONFIG_COCOA macro

2011-12-07 Thread Andreas Färber
Am 30.11.2011 01:38, schrieb Andreas Färber: > Am 10.11.2011 19:40, schrieb Pavel Borzenkov: >> Use __APPLE__ and __MACH__ macros instead of CONFIG_COCOA to detect Mac >> OS X host. The patch is based on the Ben Leslie's patch: >> http://patchwork.ozlabs.org/patch/97859/ >> >> Signed-off-by: Pavel

[Qemu-devel] an error while loading checkpoint

2011-12-07 Thread sparsh mittal
I get this warning while using a checkpoint. I issued the command -m 4G -icount 0 and other parameters. Unknown savevm section type 32 qemu-system-x86_64: Error -22 while loading VM state My computer has 48GB RAM, so I don't know what is the problem? Thanks and Regards Sparsh Mittal

Re: [Qemu-devel] [libvirt] virDomainBlockJobAbort and block_job_cancel

2011-12-07 Thread Eric Blake
On 12/07/2011 03:35 PM, Adam Litke wrote: > Stefan's qemu tree has a block_job_cancel command that always acts > asynchronously. In order to provide the synchronous behavior in libvirt (when > flags is 0), I need to wait for the block job to go away. I see two options: > > 1) Use the event: > To

Re: [Qemu-devel] [libvirt] virDomainBlockJobAbort and block_job_cancel

2011-12-07 Thread Adam Litke
On Thu, Nov 24, 2011 at 09:21:42AM +, Stefan Hajnoczi wrote: > On Thu, Nov 24, 2011 at 5:31 AM, Daniel Veillard wrote: > > On Wed, Nov 23, 2011 at 09:04:50AM -0700, Eric Blake wrote: > >> On 11/23/2011 07:48 AM, Stefan Hajnoczi wrote: > >> > This means that virDomainBlockJobAbort() returns to

[Qemu-devel] [PATCH] tcg: Remove redundant declarations of TCG_TARGET_REG_BITS

2011-12-07 Thread Stefan Weil
TCG_TARGET_REG_BITS is declared in tcg.h for all TCG targets. Signed-off-by: Stefan Weil --- tcg/i386/tcg-target.h |5 - 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h index 7756e7b..adbb036 100644 --- a/tcg/i386/tcg-target.h

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Lluís Vilanova writes: [...] > From my experience, these are the basics I need: > * Decide what to do when an event is translated (by default - no > instrumentation > -, it just generates a TCG call to an execution-time tracing routine). > This includes: > * Deciding whether to generate t

Re: [Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL.

2011-12-07 Thread Andreas Färber
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: > The SDL check is supposed to set $sdl to "yes" or "no", but with that > check it leaves $sdl unset on darwin, unless --enable-cocoa was > specified (which is not needed to enable cocoa anyway). > > Signed-off-by: Andrzej Zaborowski > --- > confi

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Peter Maydell
On 7 December 2011 21:12, Andreas Färber wrote: > Note that I have a patch that replaces uint16 with uint_fast16_t, > properly fixing the Cocoa build. What I don't have yet is all the other > conversions (Coccinelle doesn't fully do int16 conversion, for example) > to run the benchmarks Peter aske

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Paul Moore
On Wednesday, December 07, 2011 12:48:16 PM Anthony Liguori wrote: > On 12/07/2011 12:25 PM, Corey Bryant wrote: > > A group of us are starting to work on sandboxing QEMU device emulation > > code. We're just getting started investigating various approaches, and > > want to engage the community to

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Andreas Färber
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: > Cocoa can only be enabled on Darwin, and is enabled by default too, > making --enable-cocoa redundant, with no way to disable Cocoa. It > also interfered with SDL support in a way that was dependent on > the order of commandline switches. > > Sig

[Qemu-devel] [PATCH RFC 4/4] trace-instrument: Add a per-vCPU opaque pointer for the instrumentation backend

2011-12-07 Thread Lluís Vilanova
The 'instrument' opaque pointer can be used by the user-provided trace instrumentation backend to hold arbitrary data. Signed-off-by: Lluís Vilanova --- cpu-defs.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cpu-defs.h b/cpu-defs.h index db48a7a..9e46953 100644

[Qemu-devel] [PATCH RFC 3/4] trace-instrument: Add support for user-provided code on a per-event basis

2011-12-07 Thread Lluís Vilanova
Adds support for the 'instrument' propery into the "trace-events" file. Events with this property will generate tracing routines named '${api_name}_backend' (instead of '${api_name}'), and expect the user to provide its own implementation for the '${api_name}' routines. Signed-off-by: Lluís Vilan

[Qemu-devel] [PATCH RFC 2/4] trace-instrument: Add documentation

2011-12-07 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- docs/instrumentation.txt | 142 ++ docs/tracing.txt |9 +++ 2 files changed, 151 insertions(+), 0 deletions(-) create mode 100644 docs/instrumentation.txt diff --git a/docs/instrumentation.txt b/docs/inst

[Qemu-devel] [PATCH RFC 1/4] trace: [tracetool] Add 'get_api_name' to construct the name of tracing routines

2011-12-07 Thread Lluís Vilanova
All backends now use 'get_api_name' to build the name of the routines that are used by QEMU code when invoking trace points. This is built based on the values of 'get_api_name_fmt' and 'get_api_name_fmt_default'. The old 'get_name' is still available to refer to the name of an event. This allows

[Qemu-devel] [RFC][PATCH RFC 0/4] trace-instrument: Let the user wrap/override specific event tracing routines

2011-12-07 Thread Lluís Vilanova
XXX: Must be applied on top of the "backdoor" patch series and the patch "trace: Provide a per-event status define for conditional compilation", but is independent otherwise. Adds the "instrument" event property. When specified, this event property lets the user provide her own implement

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Eric Paris
On Wed, 2011-12-07 at 13:43 -0600, Anthony Liguori wrote: > On 12/07/2011 01:32 PM, Corey Bryant wrote: > > That would seem like the logical approach. I think there may be new mode 2 > > patches coming soon so we can see how they go over. > > I'd like to see what the whitelist would need to be fo

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: > On 12/07/2011 12:51 PM, Peter Maydell wrote: >> 2011/12/7 Lluís Vilanova: >>> Anthony Liguori writes: >>> [...] Why should this analyzer live outside of QEMU in the first place? I fail to see the rationale for that other than not wanting to do the work of

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
On 12/07/2011 02:43 PM, Anthony Liguori wrote: On 12/07/2011 01:32 PM, Corey Bryant wrote: Agreed. * The untrusted thread would be restricted by seccomp mode 1 and would contain the device emulation code. I think the best strategy would allow for a device to run either in the untrusted th

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Anthony Liguori
On 12/07/2011 01:44 PM, Michael Roth wrote: On 12/07/2011 07:49 AM, Anthony Liguori wrote: On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Stefan Weil
Am 07.12.2011 20:06, schrieb andrzej zaborowski: On 7 December 2011 19:57, Stefan Weil wrote: Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: +#ifdef NCURSES_VERSION +# if NCURSES_VERSION_PATCH < 20040117 +# error Old ncurses contain dangerous typedefs, break qemu build (and are old) +# end

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Michael Halcrow
On Wed, Dec 7, 2011 at 11:43 AM, Anthony Liguori wrote: > I'd like to see what the whitelist would need to be for something like > QEMU in mode 2. My biggest concern is that the whitelist would need to be > so large that the practical security what's all that much improved. > Based on some proto

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Michael Roth
On 12/07/2011 07:49 AM, Anthony Liguori wrote: On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one-off paravirtual devices. I would much prefer

Re: [Qemu-devel] [PATCH v5 0/4] -net bridge: rootless bridge support for qemu

2011-12-07 Thread Corey Bryant
On 11/13/2011 10:45 PM, Corey Bryant wrote: With qemu it is possible to run a guest from an unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network backend and a new network option for -net tap. Thi

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Anthony Liguori
On 12/07/2011 01:32 PM, Corey Bryant wrote: Agreed. * The untrusted thread would be restricted by seccomp mode 1 and would contain the device emulation code. I think the best strategy would allow for a device to run either in the untrusted thread or the trusted thread. This makes performance

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
On 12/07/2011 01:48 PM, Anthony Liguori wrote: On 12/07/2011 12:25 PM, Corey Bryant wrote: A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are

Re: [Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Stuart Yoder
On Wed, Dec 7, 2011 at 10:38 AM, Joerg Roedel wrote: > On Wed, Dec 07, 2011 at 09:54:39AM -0600, Stuart Yoder wrote: >> Alex, Alexey I'm wondering if you've had any new thoughts on this over >> the last week. >> >> For Freescale, our iommu domain attributes would look something like: >>     -domai

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread andrzej zaborowski
On 7 December 2011 19:57, Stefan Weil wrote: > Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: >> +#ifdef NCURSES_VERSION >> +# if NCURSES_VERSION_PATCH < 20040117 >> +# error Old ncurses contain dangerous typedefs, break qemu build (and are >> old) >> +# endif >> +#endif >> int main(void) { resi

Re: [Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Stefan Weil
Am 07.12.2011 08:47, schrieb Andrzej Zaborowski: This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski --- configure | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/confi

Re: [Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Peter Maydell
On 7 December 2011 07:47, Andrzej Zaborowski wrote: > Cocoa can only be enabled on Darwin, and is enabled by default too, > making --enable-cocoa redundant, with no way to disable Cocoa.  It > also interfered with SDL support in a way that was dependent on > the order of commandline switches. For

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 12:51 PM, Peter Maydell wrote: 2011/12/7 Lluís Vilanova: Anthony Liguori writes: [...] Why should this analyzer live outside of QEMU in the first place? I fail to see the rationale for that other than not wanting to do the work of making it suitable for upstream consumption. Fo

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Peter Maydell
2011/12/7 Lluís Vilanova : > Anthony Liguori writes: > [...] >> Why should this analyzer live outside of QEMU in the first place?  I fail to >> see >> the rationale for that other than not wanting to do the work of making it >> suitable for upstream consumption. > > For the same reason that System

Re: [Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Anthony Liguori
On 12/07/2011 12:25 PM, Corey Bryant wrote: A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are the design points that we are currently considerin

[Qemu-devel] [PATCH 2/2] configure: remove --enable-cocoa (default), add --disable-cocoa.

2011-12-07 Thread Andrzej Zaborowski
Cocoa can only be enabled on Darwin, and is enabled by default too, making --enable-cocoa redundant, with no way to disable Cocoa. It also interfered with SDL support in a way that was dependent on the order of commandline switches. Signed-off-by: Andrzej Zaborowski --- Cocoa support seems to be

[Qemu-devel] [PATCH 1/2] configure: don't check for Cocoa when detecting SDL.

2011-12-07 Thread Andrzej Zaborowski
The SDL check is supposed to set $sdl to "yes" or "no", but with that check it leaves $sdl unset on darwin, unless --enable-cocoa was specified (which is not needed to enable cocoa anyway). Signed-off-by: Andrzej Zaborowski --- configure |4 +--- 1 files changed, 1 insertions(+), 3 deletions

[Qemu-devel] [PATCH] configure: don't try to compile against known broken curses.

2011-12-07 Thread Andrzej Zaborowski
This should resolve a problem noted by Caraman Mihai Claudiu. Signed-off-by: Andrzej Zaborowski --- configure |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 61c43b9..678b982 100755 --- a/configure +++ b/configure @@ -1846,6 +1846,11 @@ if

[Qemu-devel] [PULL 00/35] VMState port of all cpus

2011-12-07 Thread Juan Quintela
The following changes since commit 217bfb445b54db618a30f3a39170bebd9fd9dbf2: hw/arm_gic.c: Ignore attempts to complete nonexistent IRQs (2011-12-05 21:38:56 +0100) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/quintela.git vmstate-cpus-v4-for-anthony [v4] - change co

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: [...] > Why should this analyzer live outside of QEMU in the first place? I fail to > see > the rationale for that other than not wanting to do the work of making it > suitable for upstream consumption. For the same reason that SystemTap lets you add user-provided code in

[Qemu-devel] [RFC] Device sandboxing

2011-12-07 Thread Corey Bryant
A group of us are starting to work on sandboxing QEMU device emulation code. We're just getting started investigating various approaches, and want to engage the community to gather input. Following are the design points that we are currently considering: * Decompose QEMU into multiple processes

Re: [Qemu-devel] ncurses 5.3 conflicts with latest qemu

2011-12-07 Thread andrzej zaborowski
On 5 December 2011 22:44, Stefan Weil wrote: > Am 05.12.2011 20:13, schrieb andrzej zaborowski: > >> Hi, >> >> On 17 November 2011 10:06, Caraman Mihai Claudiu-B02008 >> wrote: >>> >>> A recent patch in qemu conflicts with old ncurses libraries (version >>> 5.3). You will see this error cause by

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 10:59 AM, Lluís Vilanova wrote: Anthony Liguori writes: Well, both backdoor and trace instrumentation are implemented using the same approach (a static library selected at compile-time). The user sets which events to instrument in the "trace-events" file. This has the effect that t

Re: [Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Joerg Roedel
On Wed, Dec 07, 2011 at 09:54:39AM -0600, Stuart Yoder wrote: > Alex, Alexey I'm wondering if you've had any new thoughts on this over > the last week. > > For Freescale, our iommu domain attributes would look something like: > -domain iova base address > -domain iova window size I agree

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: >> Well, both backdoor and trace instrumentation are implemented using the same >> approach (a static library selected at compile-time). The user sets which >> events >> to instrument in the "trace-events" file. This has the effect that the >> tracetool >> script will not

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Michael Roth
On 12/07/2011 06:12 AM, Dor Laor wrote: On 12/07/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: On 12/07/2011 06:03 AM, Michael Roth wrote: This adds a command-line option, -b/--blacklist, that accepts a comma-seperated list of RPCs to disabl

[Qemu-devel] [PATCH] build: Cleanup qga make output

2011-12-07 Thread Adam Litke
Currently the make variable qapi-dir refers to the qapi-generated directory in absolute terms. This causes the harmless but ugly make output below. By changing this variable to the relative path the output conforms to the norm and the build works fine. Before patch: CC/home/aglitke/src/qem

[Qemu-devel] Error while booting

2011-12-07 Thread sparsh mittal
I use version 0.15 of qemu with marss cycle-accurate simulator. After making checkpoints in an image, I get this error, while trying to boot it (i.e. not using loadvm to run checkpoint, but just starting the image). This kernel requires an x86-64 CPU, but only detected an i686 CPU. Unable to boot

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Peter Maydell
On 7 December 2011 15:56, Anthony Liguori wrote: > Ok, let's add a docs/vmstate.txt and add a section that says "If you use the > following functions, you probably need to call them again in post_load" and > put these functions on the list. We've already got docs/migration.txt which talks about

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Anthony Liguori
On 12/07/2011 09:54 AM, Avi Kivity wrote: On 12/07/2011 05:52 PM, Anthony Liguori wrote: On 12/04/2011 12:09 PM, Avi Kivity wrote: This patchset introduces memory_region_set_enabled() and memory_region_set_address() to avoid the requirement on memory routers to track the internal state of the m

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Avi Kivity
On 12/07/2011 05:52 PM, Anthony Liguori wrote: > On 12/04/2011 12:09 PM, Avi Kivity wrote: >> This patchset introduces memory_region_set_enabled() and >> memory_region_set_address() to avoid the requirement on memory >> routers to track the internal state of the memory API (so they know >> whether

[Qemu-devel] vfio / iommu domain attributes

2011-12-07 Thread Stuart Yoder
In the vfio RFC thread there seemed to be convergence that some new iommu_ops API is needed to set some platform specific aspects of an iommu domain. On Wed, Nov 30, 2011 at 10:58 AM, Alex Williamson wrote: [cut] > In that case, you should definitely be following what Alexey is thinking > about w

Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators

2011-12-07 Thread Anthony Liguori
On 12/04/2011 12:09 PM, Avi Kivity wrote: This patchset introduces memory_region_set_enabled() and memory_region_set_address() to avoid the requirement on memory routers to track the internal state of the memory API (so they know whether they need to add or remove a region). Instead, they can si

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 09:23 AM, Lluís Vilanova wrote: Anthony Liguori writes: [...] If you want to extend QEMU, then send proper patches. Adding random C files to the build is unacceptable. What do you mean by proper patches? If you want to add "custom functionality" to QEMU, send a patch to upstr

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: [...] >>> If you want to extend QEMU, then send proper patches. Adding random C >>> files to >>> the build is unacceptable. >> >> What do you mean by proper patches? > If you want to add "custom functionality" to QEMU, send a patch to upstream > QEMU. See below. >> T

[Qemu-devel] [PATCH 2/2] net: take ownership of fd in socket init functions

2011-12-07 Thread Stefan Hajnoczi
Today net/socket.c has no consistent policy for closing the socket file descriptor when initialization fails. This means we leak the file descriptor in some cases or we could also try to close it twice. Make error paths consistent by taking ownership of the file descriptor and closing it on error

[Qemu-devel] [PATCH 1/2] net: expand tabs in net/socket.c

2011-12-07 Thread Stefan Hajnoczi
In order to make later patches sane, expand the tab characters and conform to QEMU coding style now. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 79 ++ 1 files changed, 41 insertions(+), 38 deletions(-) diff --git a/net/socket.c b/

[Qemu-devel] [PATCH 0/2] net: clean up net/socket.c

2011-12-07 Thread Stefan Hajnoczi
There is no consistent policy on closing the socket file descriptor when net/socket.c initialization fails. This has been on my TODO list for a while and I had a few minutes to fix it now. Stefan Hajnoczi (2): net: expand tabs in net/socket.c net: take ownership of fd in socket init functions

[Qemu-devel] ezmlm warning

2011-12-07 Thread 02hdec-help
Bonjour ! Je suis le programme ezmlm. Je m'occupe de la liste de diffusion 02h...@huiledecrete.com. Un certain nombre de messages provenant de la liste de diffusion <#l> n'ont pas pu vous etre remis correctement. En attachement, vous trouverez une copie du premier message de retour a l'envoyeur q

Re: [Qemu-devel] [PATCH] Documentation: Add qemu-img -t parameter in man page

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 12:58 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- >  qemu-img-cmds.hx |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) Please also document '-t' under "Command parameters:". So far this patch just lists -t but doesn't explain what it does or t

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Anthony Liguori
On 12/07/2011 06:21 AM, Lluís Vilanova wrote: Anthony Liguori writes: On 12/05/2011 04:22 PM, Lluís Vilanova wrote: Provides the ability for the guest to communicate with user-provided code inside QEMU itself, using a lightweight mechanism. See first commit for a full description. Signed-off

Re: [Qemu-devel] Insane virtio-serial semantics

2011-12-07 Thread Anthony Liguori
On 12/07/2011 02:21 AM, Markus Armbruster wrote: Anthony Liguori writes: On 12/06/2011 04:30 PM, Lluís Vilanova wrote: Anthony Liguori writes: I really worry about us introducing so many of these one-off paravirtual devices. I would much prefer that you look at doing this as an extension t

[Qemu-devel] [PATCH] Documentation: Add qemu-img -t parameter in man page

2011-12-07 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 4be00a5..49dce7c 100644 --- a/qemu-img-cmds.hx +++ b/qemu-img-cmds.hx @@ -24,13 +24,13 @@ ETEXI DEF("commit", img_commit, "c

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Zhi Yong Wu
On Wed, Dec 7, 2011 at 8:31 PM, Peter Maydell wrote: > On 7 December 2011 12:13, Zhi Yong Wu wrote: >> Can you let me know how you see that it is ISO-8859-1 coding, not >> UTF-8? They look same to me. > > This gets a bit confusing because mail clients and > web browsers tend to try to fix up what

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Peter Maydell
On 7 December 2011 12:13, Zhi Yong Wu wrote: > Can you let me know how you see that it is ISO-8859-1 coding, not > UTF-8? They look same to me. This gets a bit confusing because mail clients and web browsers tend to try to fix up what they think are wrongly labelled encodings, so for example in m

Re: [Qemu-devel] [PATCH v2 0/5] backdoor: lightweight guest-to-QEMU backdoor channel

2011-12-07 Thread Lluís Vilanova
Anthony Liguori writes: > On 12/05/2011 04:22 PM, Lluís Vilanova wrote: >> Provides the ability for the guest to communicate with user-provided code >> inside >> QEMU itself, using a lightweight mechanism. >> >> See first commit for a full description. >> >> Signed-off-by: Lluís Vilanova > Thi

Re: [Qemu-devel] [PATCH] Convert keymap file to UTF-8 encoding

2011-12-07 Thread Zhi Yong Wu
On Sat, Dec 3, 2011 at 5:45 PM, Stefan Weil wrote: > Most QEMU files either are pure ASCII or use UTF-8. > Convert this keymap file which still used ISO-8859-1 to UTF-8. > > Signed-off-by: Stefan Weil > --- >  pc-bios/keymaps/is |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > di

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 13:06, schrieb Stefan Hajnoczi: > On Wed, Dec 7, 2011 at 12:02 PM, Kevin Wolf wrote: >> Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: >>> On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: Backing files may be smaller than the corresponding COW file. When reading directly

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Dor Laor
On 12/07/2011 12:52 PM, Daniel P. Berrange wrote: On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: On 12/07/2011 06:03 AM, Michael Roth wrote: This adds a command-line option, -b/--blacklist, that accepts a comma-seperated list of RPCs to disable, or prints a list of available RPCs if

[Qemu-devel] [PATCH v2 1/3] block: add zero write detection interface

2011-12-07 Thread Stefan Hajnoczi
Some image formats can represent zero regions efficiently even when a backing file is present. In order to use this feature they need to detect zero writes and handle them specially. Since zero write detection consumes CPU cycles it is disabled by default and must be explicitly enabled. This pat

[Qemu-devel] [PATCH v2 2/3] qed: add zero write detection support

2011-12-07 Thread Stefan Hajnoczi
The QED image format is able to efficiently represent clusters containing zeroes with a magic offset value. This patch implements zero write detection for allocating writes so that image streaming can copy over zero clusters from a backing file without expanding the image file unnecessarily. This

[Qemu-devel] [PATCH v2 3/3] qemu-io: add zero write detection option

2011-12-07 Thread Stefan Hajnoczi
Add a -z option to qemu-io and the 'open' command to enable zero write detection. This is used by the qemu-iotests 029 test case and allows scripts to exercise zero write detection. Signed-off-by: Stefan Hajnoczi --- qemu-io.c | 29 ++--- 1 files changed, 22 insertions

[Qemu-devel] [PATCH v2 0/3] block: zero write detection

2011-12-07 Thread Stefan Hajnoczi
This series adds an interface for optimized writes when data contains all zeros. If zero detection is enabled a block driver can take extra steps to represent zero regions efficiently. The details of optimized zero representations depend on the image format but the main block layer change is a fi

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 12:02 PM, Kevin Wolf wrote: > Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: >> On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: >>> Backing files may be smaller than the corresponding COW file. When >>> reading directly from the backing file, qemu-img rebase must consider

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Am 07.12.2011 12:50, schrieb Stefan Hajnoczi: > On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: >> Backing files may be smaller than the corresponding COW file. When >> reading directly from the backing file, qemu-img rebase must consider >> this and assume zero sectors after the end of backing

Re: [Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Stefan Hajnoczi
On Wed, Dec 7, 2011 at 11:45 AM, Kevin Wolf wrote: > Backing files may be smaller than the corresponding COW file. When > reading directly from the backing file, qemu-img rebase must consider > this and assume zero sectors after the end of backing files. > > Signed-off-by: Kevin Wolf > --- >  qem

Re: [Qemu-devel] [PATCH 4/4] ccid: make threads joinable

2011-12-07 Thread Alon Levy
On Tue, Dec 06, 2011 at 06:05:55PM +0100, Paolo Bonzini wrote: > Destroying a mutex that another thread might have just unlocked > is racy. It usually works, but you cannot do that in general and > can lead to deadlocks or segfaults. Change ccid to use joinable > threads instead. > Looks good t

[Qemu-devel] [PATCH] qemu-img rebase: Fix for undersized backing files

2011-12-07 Thread Kevin Wolf
Backing files may be smaller than the corresponding COW file. When reading directly from the backing file, qemu-img rebase must consider this and assume zero sectors after the end of backing files. Signed-off-by: Kevin Wolf --- qemu-img.c | 42 +- 1 file

Re: [Qemu-devel] [PATCH 12/14] SD card: add query function to check wether SD card currently ready to recieve data Before executing data transfer to card, we must check that previously issued command

2011-12-07 Thread Peter Maydell
On 7 December 2011 09:47, Evgeny Voevodin wrote: > From: Mitsyanko Igor Shouldn't we have a Signed-off-by: from this person as well? There's a missing blank line in the commit message which has put all of it into the Subject. > Signed-off-by: Evgeny Voevodin > --- >  hw/sd.c |    5 + >  h

Re: [Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Peter Maydell
On 7 December 2011 10:58, Evgeny Voevodin wrote: > On 12/07/2011 02:09 PM, Peter Maydell wrote: >> >> On 7 December 2011 09:47, Evgeny Voevodin  wrote: >>> >>> We included this chip into s5pc210 platform because SMDK board holds >>> lan9215 chip. Difference is that 9215 access is 16-bit wide and s

Re: [Qemu-devel] [Bug 899140] Re: Problem with Linux Kernel Traffic Control

2011-12-07 Thread Vincent Autefage
Well I've compiled the ubuntu package. When I've launched qemu, I've got this : * *$ *qemu-system-x86_64 -hda debian.img -m 512 qemu: could not load PC BIOS 'bios.bin' ** *I've checked the content of the *pc-bios* directory and no bios are generated but I've got strange file like : **.bin *.d

Re: [Qemu-devel] [PATCH 01/14] ARM: s5pc210: Basic support of s5pc210 boards

2011-12-07 Thread Peter Maydell
If you split this patch up so it is: 1 cmu 2 uart 3 initial basic board this will be easier to review than a 2000 line patch. > +DeviceState *s5pc210_uart_create(target_phys_addr_t addr, > +                                 int fifo_size, > +                                 int channel, > +    

Re: [Qemu-devel] [PATCH 09/14] hw/lan9118.c: Basic byte/word/long access support.

2011-12-07 Thread Evgeny Voevodin
On 12/07/2011 02:09 PM, Peter Maydell wrote: On 7 December 2011 09:47, Evgeny Voevodin wrote: We included this chip into s5pc210 platform because SMDK board holds lan9215 chip. Difference is that 9215 access is 16-bit wide and some registers differ. By addition basic 16-bit access to 9118 emula

Re: [Qemu-devel] [PATCH 1/2] guest agent: add RPC blacklist command-line option

2011-12-07 Thread Daniel P. Berrange
On Wed, Dec 07, 2011 at 12:34:01PM +0200, Dor Laor wrote: > On 12/07/2011 06:03 AM, Michael Roth wrote: > >This adds a command-line option, -b/--blacklist, that accepts a > >comma-seperated list of RPCs to disable, or prints a list of > >available RPCs if passed "?". > > > >In consequence this also

[Qemu-devel] [PATCH 10/14] hw/s5pc210.c: Add lan9118 support to SMDK board.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- hw/s5pc210.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/s5pc210.c b/hw/s5pc210.c index 90858e9..8678b97 100644 --- a/hw/s5pc210.c +++ b/hw/s5pc210.c @@ -29,6 +29,8 @@ #include "sysemu.h" #include "sysbus.h"

[Qemu-devel] [PATCH 03/14] ARM: s5pc210: IRQ subsystem support.

2011-12-07 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- Makefile.target |3 +- hw/s5pc210.c | 163 +++- hw/s5pc210.h | 39 + hw/s5pc210_combiner.c | 381 + hw/s5pc210_gic.c | 411

  1   2   >