Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-08 Thread Gleb Natapov
On Sat, Jan 07, 2012 at 11:28:44AM -0500, Kevin O'Connor wrote: On Sat, Jan 07, 2012 at 10:00:56AM +0100, Gerhard Wiesinger wrote: On Fri, 6 Jan 2012, Kevin O'Connor wrote: I'm not sure what a SCSI rom would do with a CD drive. My guess is that it wouldn't map it to a BIOS visible drive id

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Michael S. Tsirkin
On Thu, Jan 05, 2012 at 04:14:29PM +0100, Stefan Weil wrote: Am 04.01.2012 15:47, schrieb Michael S. Tsirkin: On Wed, Jan 04, 2012 at 04:28:42PM +0200, Avi Kivity wrote: Commit d0ed8076cbdc261 converted the PCI config access to the memory API, but also inadvertantly changed it to accept

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Avi Kivity
On 01/08/2012 11:17 AM, Michael S. Tsirkin wrote: On Thu, Jan 05, 2012 at 04:14:29PM +0100, Stefan Weil wrote: Am 04.01.2012 15:47, schrieb Michael S. Tsirkin: On Wed, Jan 04, 2012 at 04:28:42PM +0200, Avi Kivity wrote: Commit d0ed8076cbdc261 converted the PCI config access to the memory

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Michael S. Tsirkin
On Sun, Jan 08, 2012 at 12:02:35PM +0200, Avi Kivity wrote: On 01/08/2012 11:17 AM, Michael S. Tsirkin wrote: On Thu, Jan 05, 2012 at 04:14:29PM +0100, Stefan Weil wrote: Am 04.01.2012 15:47, schrieb Michael S. Tsirkin: On Wed, Jan 04, 2012 at 04:28:42PM +0200, Avi Kivity wrote: Commit

Re: [Qemu-devel] Inconsistency detected by ld.so error, what can I do?

2012-01-08 Thread Andreas Färber
Hi, Am 04.01.2012 10:05, schrieb Liu: I configure qemu as: ./configure --prefix=$PREFIX --target-list=mipsel-softmmu,mipsel-linux-user a.out is compiled by mipsel-linux-gcc. When I run a.out using qemu-mipsel, I get a error like this: Inconsistency detected by ld.so:

Re: [Qemu-devel] [PATCH] Rename target_phys_addr_t to Phys

2012-01-08 Thread Avi Kivity
On 01/07/2012 07:44 PM, Blue Swirl wrote: Making the build faster (by killing libhw32/libhw64) would be a good justification for this type of change IMHO. The original reason was to avoid 64 bit arithmetic on 32 bit hosts. Now that 128 bit arithmetic is used for memory API, it probably does

Re: [Qemu-devel] [PATCH V2 5/5] vga-cirrus: Workaround during restore when using Xen.

2012-01-08 Thread Avi Kivity
On 01/06/2012 04:40 PM, Stefano Stabellini wrote: Avi, if you think that early_savevm is a decent solution, we'll start working on it. I don't like early_savevm because it complicates life for devices, for what is a localized problem. But if everything else is even more complicated maybe we

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Avi Kivity
On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: And the check for unaligned writes is, well, unusual :-) What's unusual? This seems to be how memory API behaves ... right, Avi? Maybe this should be documented somewhere. Document what? That address passed to

Re: [Qemu-devel] [PATCH] memory: Fix assertion for flash devices

2012-01-08 Thread Avi Kivity
On 01/07/2012 01:13 PM, Stefan Weil wrote: There is a regression since commit c5705a7728b4a6bc9e4f2d35911adbaf28042b25 or some other recent change. System emulation with a flash device raises an assertion in function qemu_ram_set_idstr because no new_block is found at the requested addr.

Re: [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch'

2012-01-08 Thread Avi Kivity
On 01/07/2012 10:45 AM, Andreas Färber wrote: Hello, This series fixes endianness issues in the memory core. Apparently the actual byte swapping had not yet been tested. /me hangs head. But strangely, sparc-test, mips-test, and ppc-virtex-ml507 (after the idstr fix) all boot for me.

Re: [Qemu-devel] [Bug] System emulation with flash broken?

2012-01-08 Thread Avi Kivity
On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: On Fri, 6 Jan 2012, Stefan Weil wrote: Hello Avi, latest QEMU seems to be broken when a system emulation with flash is started. I did not run git bisect, but it looks like the problem started with this change:

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Avi Kivity
On 01/07/2012 06:09 PM, Peter Maydell wrote: On 7 January 2012 04:40, Andreas Färber afaer...@suse.de wrote: I noticed you're dropping a comment about tlb_flush(). Is that because it was dead code, or does the Memory API take care of it for us? (I assume the former because

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Andreas Färber
Am 08.01.2012 12:16, schrieb Avi Kivity: On 01/07/2012 06:09 PM, Peter Maydell wrote: On 7 January 2012 04:40, Andreas Färber afaer...@suse.de wrote: I noticed you're dropping a comment about tlb_flush(). Is that because it was dead code, or does the Memory API take care of it for us? (I

Re: [Qemu-devel] [PATCH v4 2/2] hw/integratorcp: Simplify flash remap code

2012-01-08 Thread Avi Kivity
On 01/08/2012 01:19 PM, Andreas Färber wrote: Correct, and the memory core will flush the tlb, so all is well. Hm, I had grep'ed for tlb_flush in memory.* without a hit... I would've assumed to find tlb_flush_all() somewhere. It's at then end of cpu_register_physical_memory_log(), which

Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

2012-01-08 Thread Blue Swirl
On Sun, Jan 8, 2012 at 02:48, Andreas Färber afaer...@suse.de wrote: Am 07.01.2012 18:29, schrieb Blue Swirl: On Thu, Jan 5, 2012 at 17:45, Andreas Färber afaer...@suse.de wrote: Am 15.10.2011 15:50, schrieb Blue Swirl: Remove now incorrect address base arithmetic, missed by

[Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Gerhard Wiesinger
Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patch disables Option ROMs for iPXE for alls supported NICs (hotplugable and non hotplugable). Examples

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-08 Thread Gerhard Wiesinger
On Sat, 7 Jan 2012, Gerhard Wiesinger wrote: On Sat, 7 Jan 2012, Gerhard Wiesinger wrote: No NIC: -net none = No iPXE ROM (correct). but with the previously listed config no iPXE ROM should be there. Saw this is done through paravirtualization from Seabios/QEMU or KVM. So there must be a bug

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot

2012-01-08 Thread Gerhard Wiesinger
On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: Testscenario: 1.) Boot e.g. OS with VMMouse support (e.g. Windows) 2.) reboot 3.) Boot e.g. OS without VMMouse support (e.g. DOS) = PS/2 mouse doesn't work any more. Fixes that issue. Reason is that VMMouse has priority and disables all other

Re: [Qemu-devel] [PATCH 1/2] m48t59: drop obsolete address base arithmetic

2012-01-08 Thread Avi Kivity
On 01/08/2012 01:43 PM, Blue Swirl wrote: On Sun, Jan 8, 2012 at 02:48, Andreas Färber afaer...@suse.de wrote: Am 07.01.2012 18:29, schrieb Blue Swirl: On Thu, Jan 5, 2012 at 17:45, Andreas Färber afaer...@suse.de wrote: Am 15.10.2011 15:50, schrieb Blue Swirl: Remove now incorrect

Re: [Qemu-devel] [Bug] System emulation with flash broken?

2012-01-08 Thread Gerhard Wiesinger
On Sun, 8 Jan 2012, Avi Kivity wrote: On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: On Fri, 6 Jan 2012, Stefan Weil wrote: Hello Avi, latest QEMU seems to be broken when a system emulation with flash is started. I did not run git bisect, but it looks like the problem started with this

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v4

2012-01-08 Thread Blue Swirl
On Sun, Jan 8, 2012 at 00:52, Aurelien Jarno aurel...@aurel32.net wrote: On Sat, Jan 07, 2012 at 10:24:09PM +, Blue Swirl wrote: In this version, I made basic AREG0 free load/store implementations for all targets. Only x86-64 is tested, others have probably problems, especially 64 bit

[Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

2012-01-08 Thread Avi Kivity
rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just a RAM region. Mask the I/O handler to make it happy. Signed-off-by: Avi Kivity a...@redhat.com --- savevm.c |2 +- 1 files changed, 1

Re: [Qemu-devel] [Bug] System emulation with flash broken?

2012-01-08 Thread Avi Kivity
On 01/08/2012 02:23 PM, Gerhard Wiesinger wrote: On Sun, 8 Jan 2012, Avi Kivity wrote: On 01/07/2012 08:03 PM, Gerhard Wiesinger wrote: On Fri, 6 Jan 2012, Stefan Weil wrote: Hello Avi, latest QEMU seems to be broken when a system emulation with flash is started. I did not run git

[Qemu-devel] [PATCH] configure: fix library linking for smartcard NSS and usbredir

2012-01-08 Thread Aurelien Jarno
configure script currently add smartcard NSS and usbredir libraries to LIBS instead of libs_softmmu. This cause even the qemu-user builds to link with them, and causes some problems with --static as NSS libraries are usually not available as static. Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Michael S. Tsirkin
On Sun, Jan 08, 2012 at 12:48:05PM +0200, Avi Kivity wrote: On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: And the check for unaligned writes is, well, unusual :-) What's unusual? This seems to be how memory API behaves ... right, Avi? Maybe this should be

Re: [Qemu-devel] [PATCH master/stable-1.0] pci: fix corrupted pci conf index register by unaligned write

2012-01-08 Thread Avi Kivity
On 01/08/2012 02:45 PM, Michael S. Tsirkin wrote: On Sun, Jan 08, 2012 at 12:48:05PM +0200, Avi Kivity wrote: On 01/08/2012 12:12 PM, Michael S. Tsirkin wrote: And the check for unaligned writes is, well, unusual :-) What's unusual? This seems to be how memory

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

2012-01-08 Thread Stefan Weil
Am 08.01.2012 13:31, schrieb Avi Kivity: rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just a RAM region. Mask the I/O handler to make it happy. Signed-off-by: Avi Kivity a...@redhat.com ---

[Qemu-devel] nb_globals vs nb_temps

2012-01-08 Thread Xin Tong
From the line of comment at TCGTemp * temps. The globals first, temps after. Whenever a global/temp is allocated, the nb_globals/nb_temps is incremented. nb_globals is set to 0 when the tcg is initialized, but i can not find where nb_temps is set. Anyone care to answer ? Thanks Xin

Re: [Qemu-devel] nb_globals vs nb_temps

2012-01-08 Thread Peter Maydell
On 8 January 2012 13:05, Xin Tong xerox.time.t...@gmail.com wrote: From the line of comment at TCGTemp * temps. The  globals first, temps after. Whenever a global/temp is allocated, the nb_globals/nb_temps is incremented. nb_globals is set to 0 when the tcg is initialized, but i can not find

[Qemu-devel] [PULL] memory core fixes

2012-01-08 Thread Avi Kivity
Please pull from git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent to receive fixes for recent memory core breakages. Andreas Färber (2): memory: Fix memory_region_wrong_endianness() memory: Fix adjust_endianness() Avi Kivity (2): kvm: fix build error in ppc

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-08 Thread Dor Laor
On 01/06/2012 07:25 PM, Chris Wright wrote: * Corey Bryant (cor...@linux.vnet.ibm.com) wrote: Count me in for step 2. A good approach may be to run a static analysis tool against the code, followed by a manual scan of the code for common vulnerabilities that static analysis can't find. Good

Re: [Qemu-devel] nb_globals vs nb_temps

2012-01-08 Thread Xin Tong
s-nb_temps = s-nb_globals; in tcg_func_start. Is it still possible to allocated TCGTemp globals after tcg_func_start is called. If it is allowed, aren't global temps and local temps going to become interleaved ? Thanks Xin On Sun, Jan 8, 2012 at 8:37 AM, Peter Maydell

Re: [Qemu-devel] nb_globals vs nb_temps

2012-01-08 Thread Peter Maydell
On 8 January 2012 14:02, Xin Tong xerox.time.t...@gmail.com wrote:    s-nb_temps = s-nb_globals; in tcg_func_start. Is it still possible to allocated TCGTemp globals after tcg_func_start is called. No. From tcg/README: # A TCG global is a variable which is live in all the functions #

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 7 January 2012 20:56, Marek Vasut marek.va...@gmail.com wrote: On 7 January 2012 20:11, Marek Vasut marek.va...@gmail.com wrote: The AMBA IDs are supposed to be at the end of 0x2000 block, which the PL011 UART allocates. Current QEMU implementation puts those IDs at 0x1000 offset, which

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-08 Thread Kevin O'Connor
On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: On Sat, Jan 07, 2012 at 11:28:44AM -0500, Kevin O'Connor wrote: I downloaded 8xx_64.rom and tried the above command line. Interestingly, it will register a BEV for a CD drive - which confirms my suspicion that it wont use a BCV.

[Qemu-devel] [ANNOUNCE] kvm-kmod-3.2

2012-01-08 Thread Jan Kiszka
Here is the corresponding kvm-kmod [1] release for Linux 3.2. The package is available for download from http://sourceforge.net/projects/kvm/files/kvm-kmod/3.2/kvm-kmod-3.2.tar.bz2/download Major KVM changes since kvm-kmod-3.1: - APIC: Optimize EOI emulation - APIC: Emulate TSC deadline timer

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-08 Thread Gleb Natapov
On Sun, Jan 08, 2012 at 09:58:53AM -0500, Kevin O'Connor wrote: On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: On Sat, Jan 07, 2012 at 11:28:44AM -0500, Kevin O'Connor wrote: I downloaded 8xx_64.rom and tried the above command line. Interestingly, it will register a BEV for

Re: [Qemu-devel] Boot order problem and disable iPXE/gPXE

2012-01-08 Thread Kevin O'Connor
On Sun, Jan 08, 2012 at 05:17:45PM +0200, Gleb Natapov wrote: On Sun, Jan 08, 2012 at 09:58:53AM -0500, Kevin O'Connor wrote: On Sun, Jan 08, 2012 at 10:31:05AM +0200, Gleb Natapov wrote: Cool! What about non pnp roms that also register bcv? Should we use HD priority for those too? A

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

2012-01-08 Thread Andreas Färber
Am 08.01.2012 13:31, schrieb Avi Kivity: rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just expects :) - if you can still change it on your branch. Andreas a RAM region. Mask the I/O handler

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
On 7 January 2012 20:56, Marek Vasut marek.va...@gmail.com wrote: On 7 January 2012 20:11, Marek Vasut marek.va...@gmail.com wrote: The AMBA IDs are supposed to be at the end of 0x2000 block, which the PL011 UART allocates. Current QEMU implementation puts those IDs at 0x1000 offset,

Re: [Qemu-devel] [PATCH] Fix vmstate_register_ram() for rom/device regions

2012-01-08 Thread Avi Kivity
On 01/08/2012 05:50 PM, Andreas Färber wrote: Am 08.01.2012 13:31, schrieb Avi Kivity: rom/device regions have a ram_addr that is composed of both an I/O handler (low bits) and RAM region (high bits); but qemu_ram_set_idstr() excepts just expects :) - if you can still change it on your

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 16:02, Marek Vasut marek.va...@gmail.com wrote: Can you point me to some documentation? I looked at http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch=1s r=7 (i.MX28 Applications Processor Reference Manual) and although it has a number of UARTs none of

Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot

2012-01-08 Thread Andreas Färber
Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: Testscenario: 1.) Boot e.g. OS with VMMouse support (e.g. Windows) 2.) reboot 3.) Boot e.g. OS without VMMouse support (e.g. DOS) = PS/2 mouse doesn't work any more. Fixes that issue. Reason is

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Stefan Hajnoczi
On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger li...@wiesinger.com wrote: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. This patch disables Option ROMs

Re: [Qemu-devel] nb_globals vs nb_temps

2012-01-08 Thread Andreas Färber
Am 08.01.2012 14:05, schrieb Xin Tong: i can not find where nb_temps is set. Anyone care to answer ? $ grep -r nb_temps path/to/qemu/sources shows a manageable amount of search hits, with two assignments: one in tcg/optimize.c, one in tcg/tcg.c. Andreas -- SUSE LINUX Products GmbH,

Re: [Qemu-devel] [RFC] QEMU Code Audit Team

2012-01-08 Thread Stefan Hajnoczi
On Sun, Jan 8, 2012 at 2:01 PM, Dor Laor dl...@redhat.com wrote: On 01/06/2012 07:25 PM, Chris Wright wrote: * Corey Bryant (cor...@linux.vnet.ibm.com) wrote: Count me in for step 2.  A good approach may be to run a static analysis tool against the code, followed by a manual scan of the

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
On 8 January 2012 16:02, Marek Vasut marek.va...@gmail.com wrote: Can you point me to some documentation? I looked at http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf?fsrch= 1s r=7 (i.MX28 Applications Processor Reference Manual) and although it has a number of UARTs none

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 16:57, Marek Vasut marek.va...@gmail.com wrote: Peter Maydell wrote: Does the hardware give the ID registers the same values as stock PL011 or are the part number/designer/etc fields different? Slightly different, but compatible with Linux: 80075fe0: 0011 0010

Re: [Qemu-devel] [PATCH 0/2] memory: Fix 'Kill old-style I/O dispatch'

2012-01-08 Thread Andreas Färber
Am 08.01.2012 12:11, schrieb Avi Kivity: On 01/07/2012 10:45 AM, Andreas Färber wrote: This series fixes endianness issues in the memory core. Apparently the actual byte swapping had not yet been tested. /me hangs head. But strangely, sparc-test, mips-test, and ppc-virtex-ml507 (after the

[Qemu-devel] [PATCH 0/2] Remove memory_region_set_offset()

2012-01-08 Thread Avi Kivity
memory_region_set_offset() is used in only one place, and is deprecated. Remove the single use and the function itself. Avi Kivity (2): ioport: change portio_list not to use memory_region_set_offset() memory: remove memory_region_set_offset() ioport.c | 25 +++--

[Qemu-devel] [PATCH 2/2] memory: remove memory_region_set_offset()

2012-01-08 Thread Avi Kivity
memory_region_set_offset() complicates the API, and has been deprecated since its introduction. Now that it is no longer used, remove it. Signed-off-by: Avi Kivity a...@redhat.com --- memory.c | 26 ++ memory.h |9 - 2 files changed, 10 insertions(+), 25

[Qemu-devel] [PATCH 1/2] ioport: change portio_list not to use memory_region_set_offset()

2012-01-08 Thread Avi Kivity
memory_region_set_offset() will be going away soon, so don't use it. Use an alias instead. Signed-off-by: Avi Kivity a...@redhat.com --- ioport.c | 25 +++-- ioport.h |1 + 2 files changed, 20 insertions(+), 6 deletions(-) diff --git a/ioport.c b/ioport.c index

[Qemu-devel] [PATCH] Spelling fixes in comments and documentation

2012-01-08 Thread Stefan Weil
Codespell detected these new spelling issues. Signed-off-by: Stefan Weil s...@weilnetz.de --- docs/writing-qmp-commands.txt |2 +- memory.h |4 ++-- qemu-ga.c |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 0/2] Remove memory_region_set_offset()

2012-01-08 Thread Andreas Färber
Am 08.01.2012 18:57, schrieb Avi Kivity: memory_region_set_offset() is used in only one place, and is deprecated. Remove the single use and the function itself. Does the removal of the offset mean that memory_region_find() can be simplified to just return a MemoryRegion* now? :) Andreas --

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
On 8 January 2012 16:57, Marek Vasut marek.va...@gmail.com wrote: Peter Maydell wrote: Does the hardware give the ID registers the same values as stock PL011 or are the part number/designer/etc fields different? Slightly different, but compatible with Linux: 80075fe0: 0011

[Qemu-devel] [PATCH v10 0/8] PC system flash support

2012-01-08 Thread Jordan Justen
Enable flash emulation in a PC system using pflash_cfi01. v10: * Rebase to HEAD * decouple vmstate from memory API as in c5705a7 * Break changes into smaller pieces v9: * Add pc-1.1 * pc-1.0 uses previous rom firmware init code path v8: * Cleanup two chunks of debug code (printf messages) * Fix

[Qemu-devel] [PATCH v10 1/8] blockdev: allow read-only pflash devices

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index c832782..2d1b8f7 100644 --- a/blockdev.c +++ b/blockdev.c @@ -557,7 +557,8 @@ DriveInfo *drive_init(QemuOpts *opts, int

[Qemu-devel] [PATCH v10 2/8] pflash_cfi01/02: support read-only pflash devices

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pflash_cfi01.c | 44 +++- hw/pflash_cfi02.c | 83 2 files changed, 75 insertions(+), 52 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c

[Qemu-devel] [PATCH v10 5/8] hw/pc_sysfw: Support system flash memory with pflash

2012-01-08 Thread Jordan Justen
Flash can be enabled by calling pc_system_firmware_init with the system_flash_enabled parameter being non-zero. If system_flash_enabled is zero, then the older qemu rom creation method will be used. If flash is enabled and a pflash image is found, then it is used for the system firmware image.

[Qemu-devel] [PATCH v10 3/8] vl: make find_default_machine externally visible

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/boards.h |1 + vl.c|2 +- 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 716fd7b..45a31a1 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -33,6 +33,7 @@ typedef struct

[Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pc_piix.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 00f525e..aea95e4 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -314,8 +314,8 @@ static void

[Qemu-devel] [PATCH v10 4/8] hw/pc: move rom init to pc_sysfw.c

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- Makefile.target |1 + hw/pc.c | 56 +++-- hw/pc.h |3 ++ hw/pc_sysfw.c | 92 +++ 4 files changed, 101 insertions(+), 51

[Qemu-devel] [PATCH v10 6/8] hw/pc_piix: remove is_default for pc-0.15

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pc_piix.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -328,7 +328,6 @@ static QEMUMachine pc_machine_v0_15

[Qemu-devel] [PATCH v10 8/8] pc: enable system flash for pc-1.1

2012-01-08 Thread Jordan Justen
Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pc.c |5 +++-- hw/pc.h |3 ++- hw/pc_piix.c | 33 + 3 files changed, 30 insertions(+), 11 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 7a7af90..4af9974 100644 --- a/hw/pc.c +++

Re: [Qemu-devel] [PATCH v10 0/8] PC system flash support

2012-01-08 Thread Jordan Justen
This currently depends on Avi's patch to avoid an assert during boot. * Fix vmstate_register_ram() for rom/device regions -Jordan On Sun, Jan 8, 2012 at 11:51, Jordan Justen jordan.l.jus...@intel.com wrote: Enable flash emulation in a PC system using pflash_cfi01. v10: * Rebase to HEAD *

[Qemu-devel] [PATCH 00/10] Misc fixes for floppy emulation

2012-01-08 Thread Hervé Poussineau
Here are misc fixes done by VirtualBox team. With these patches, floppy emulation is now good enough to run Xenix. Hervé Poussineau (10): fdc: take head count into account fdc: set busy bit when starting a command fdc: most control commands do not generate interrupts fdc: emulate stepping

[Qemu-devel] [PATCH 02/10] fdc: set busy bit when starting a command

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index c1898a6..1b9f303 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1446,7 +1446,6 @@ static void fdctrl_handle_readid(FDCtrl *fdctrl, int

[Qemu-devel] [PATCH 06/10] block: add a transfer rate for floppy types

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- block.c | 74 - block.h | 10 +++- hw/fdc.c |3 +- hw/pc.c |3 +- 4 files changed, 52 insertions(+), 38 deletions(-) diff --git a/block.c b/block.c index

[Qemu-devel] [PATCH 01/10] fdc: take head count into account

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 70aa5c7..c1898a6 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -95,16 +95,19 @@ static void fd_init(FDrive *drv)

[Qemu-devel] [PATCH 05/10] fdc: handle read-only floppies (abort early on write commands)

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 0e167f8..078ff0c 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -300,6 +300,7 @@ enum { }; enum { +FD_SR1_NW =

[Qemu-devel] [PATCH 04/10] fdc: emulate stepping 0

2012-01-08 Thread Hervé Poussineau
Stepping 1 (S82078B) is not fully i82078 compatible, so better stick to initial revision Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index bedaeca..0e167f8 100644 --- a/hw/fdc.c

Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

2012-01-08 Thread Gerhard Wiesinger
On Sun, 8 Jan 2012, Stefan Hajnoczi wrote: On Sun, Jan 8, 2012 at 11:55 AM, Gerhard Wiesinger li...@wiesinger.com wrote: Option ROM for network interface cards (NICs) can now explicitly disabled with romfile=disabled parameter. With hotplugable NICs (currently NE2000, PCNET) romfile=(empty)

[Qemu-devel] [PATCH 03/10] fdc: most control commands do not generate interrupts

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 1b9f303..bedaeca 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1348,7 +1348,7 @@ static void fdctrl_handle_lock(FDCtrl

[Qemu-devel] [PATCH v4 0/4] VGA patches

2012-01-08 Thread Blue Swirl
I'm holding the patch for checking dirty range. Perhaps the original non-iterative version was better approach, the callers need less changes. Then 6/6 which lets Cirrus VGA compile only once is also held. These should be ready for committing. Blue Swirl (4): vga: improve VGA logic memory:

[Qemu-devel] [PATCH 1/4] vga: improve VGA logic

2012-01-08 Thread Blue Swirl
Improve VGA selection logic, push check for device availabilty to vl.c. Create the devices at board level unconditionally. Remove now unused pci_try_create*() functions. Make PCI VGA devices optional. Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/alpha_pci.c |6 +--- hw/boards.h

[Qemu-devel] [PATCH 10/10] fdc: DIR (Digital Input Register) should return status of current drive...

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c |9 ++--- 1 files changed, 2 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 7af0f7e..a23fb1e 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -215,6 +215,7 @@ static void fdctrl_reset_fifo(FDCtrl *fdctrl);

[Qemu-devel] [PATCH 08/10] fdc: add CCR (Configuration Control Register) write register

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index ddfa91f..67cd14f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -227,6 +227,7 @@ static void fdctrl_write_rate(FDCtrl

[Qemu-devel] [PATCH 2/4] memory: change dirty setting APIs to take a size

2012-01-08 Thread Blue Swirl
Instead of each target knowing or guessing the guest page size, just pass the desired size of dirtied memory area. This should also improve performance due to memset() optimizations. Signed-off-by: Blue Swirl blauwir...@gmail.com --- arch_init.c |2 +- exec-obsolete.h | 14

[Qemu-devel] [PATCH 3/4] vga: make Cirrus ISA device optional

2012-01-08 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- Makefile.target | 13 +++--- default-configs/alpha-softmmu.mak|2 + default-configs/arm-softmmu.mak |1 + default-configs/i386-softmmu.mak |2 + default-configs/mips-softmmu.mak |2 +

[Qemu-devel] [PATCH 4/4] sga: fix copypasta

2012-01-08 Thread Blue Swirl
Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/sga.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sga.c b/hw/sga.c index 7ef750a..ea11937 100644 --- a/hw/sga.c +++ b/hw/sga.c @@ -35,7 +35,7 @@ typedef struct ISAGAState { ISADevice dev; } ISASGAState;

[Qemu-devel] [PATCH 07/10] fdc: check if media rate is correct before doing any transfer

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 24 +++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index aec1e5e..ddfa91f 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -83,6 +83,7 @@ typedef struct FDrive {

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-01-08 Thread Jan Kiszka
On 2012-01-07 19:23, Liu, Jinsong wrote: Jan Kiszka wrote: On 2012-01-05 18:07, Liu, Jinsong wrote: Sorry, it remains bogus to expose the tsc deadline timer feature on machines pc-1.1. That's just like we introduced kvmclock only to pc-0.14 onward. The reason is that guest OSes so far

[Qemu-devel] [PATCH 09/10] fdc: fix seek command, which shouldn't check tracks

2012-01-08 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/fdc.c | 13 ++--- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 67cd14f..7af0f7e 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1597,13 +1597,12 @@ static void fdctrl_handle_seek(FDCtrl

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Peter Maydell
On 8 January 2012 19:44, Marek Vasut marek.va...@gmail.com wrote: It's just their position that's different indeed. And even this can be tuned via props. I'll update the patch once I get FEC operational. Incidentally, since this is only needed for a platform we don't currently support, you

[Qemu-devel] [PATCH qemu-kvm] Fix: SCI isn't sent on cpu hotplug

2012-01-08 Thread Igor Mammedov
Change introduced by e71f08bb4a Fix cpu/pci hotplug to generate level triggered interrupt. was lost somewhre along the way. And as result SCI is not sent in case of cpu hotplug event. Restoring hunk 1 of e71f08bb4a fixes issue. Signed-off-by: Igor Mammedov imamm...@redhat.com ---

Re: [Qemu-devel] [PATCH 4/4] sga: fix copypasta

2012-01-08 Thread Andreas Färber
Add Fix the name of the init function.? Am 08.01.2012 22:11, schrieb Blue Swirl: Signed-off-by: Blue Swirl blauwir...@gmail.com Reviewed-by: Andreas Färber afaer...@suse.de This seems independent of the other VGA patches and probably should go in early for Anthony to rebase his second QOM

Re: [Qemu-devel] [PATCH][v7] megasas: LSI Megaraid SAS emulation

2012-01-08 Thread Gerhard Wiesinger
On Tue, 19 Jul 2011, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. It is based off the 'block' tree from Kevin Wolf, as he pulled in the preliminary patches. I've tested it to work with Linux, Windows Vista, and Windows7. Why hasn't this patch

[Qemu-devel] [PATCH] PC: pc-0.15 is not the default

2012-01-08 Thread Alexander Graf
During creation of the pc-0.15 machine type something must have gone wrong and the is_default field was still set, even though our default machine is 1.0. Remove that field. Signed-off-by: Alexander Graf ag...@suse.de diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 ---

[Qemu-devel] [PATCH] PC: pc-0.15 is not the default

2012-01-08 Thread Alexander Graf
During creation of the pc-0.15 machine type something must have gone wrong and the is_default field was still set, even though our default machine is 1.0. Remove that field. Signed-off-by: Alexander Graf ag...@suse.de diff --git a/hw/pc_piix.c b/hw/pc_piix.c index b70431f..00f525e 100644 ---

[Qemu-devel] [PATCH 2/2] KVM: Use -cpu best as default on x86

2012-01-08 Thread Alexander Graf
When running QEMU without -cpu parameter, the user usually wants a sane default. So far, we're using the qemu64/qemu32 CPU type, which basically means the maximum TCG can emulate. That's a really good default when using TCG, but when running with KVM we much rather want a default saying the

Re: [Qemu-devel] [PATCH] PL011: Fix ID reporting

2012-01-08 Thread Marek Vasut
On 8 January 2012 19:44, Marek Vasut marek.va...@gmail.com wrote: It's just their position that's different indeed. And even this can be tuned via props. I'll update the patch once I get FEC operational. Incidentally, since this is only needed for a platform we don't currently support,

Re: [Qemu-devel] [PATCH 1/2] KVM: Add new -cpu best

2012-01-08 Thread Peter Maydell
On 8 January 2012 23:52, Alexander Graf ag...@suse.de wrote: During discussions on whether to make -cpu host the default in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if I already am so opposed to it for SLE, how can

Re: [Qemu-devel] [PATCH 1/2] KVM: Add new -cpu best

2012-01-08 Thread Alexander Graf
On 09.01.2012, at 01:02, Peter Maydell wrote: On 8 January 2012 23:52, Alexander Graf ag...@suse.de wrote: During discussions on whether to make -cpu host the default in SLE, I found myself disagreeing to the thought, because it potentially opens a big can of worms for potential bugs. But if

Re: [Qemu-devel] [PATCH][v7] megasas: LSI Megaraid SAS emulation

2012-01-08 Thread Andreas Färber
Am 08.01.2012 22:56, schrieb Gerhard Wiesinger: On Tue, 19 Jul 2011, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. It is based off the 'block' tree from Kevin Wolf, as he pulled in the preliminary patches. I've tested it to work with Linux, Windows

Re: [Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

2012-01-08 Thread Alexander Graf
On 08.01.2012, at 20:51, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pc_piix.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 00f525e..aea95e4 100644 --- a/hw/pc_piix.c +++

Re: [Qemu-devel] [PATCH v10 7/8] hw/pc_piix: add pc-1.1

2012-01-08 Thread Jordan Justen
On Sun, Jan 8, 2012 at 16:12, Alexander Graf ag...@suse.de wrote: On 08.01.2012, at 20:51, Jordan Justen wrote: Signed-off-by: Jordan Justen jordan.l.jus...@intel.com --- hw/pc_piix.c |   11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c

[Qemu-devel] [PATCH] Add a comment to autogenerated .texi files noting that fact.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- scripts/hxtool |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/scripts/hxtool b/scripts/hxtool index 995bb7f..a985f5c 100644 --- a/scripts/hxtool +++ b/scripts/hxtool @@ -20,6 +20,8 @@ hxtotexi() {

[Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

Re: [Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread andrzej zaborowski
On 8 January 2012 16:14, Andrzej Zaborowski balr...@gmail.com wrote: Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. ---  hw/qdev.c |   38

[Qemu-devel] [PATCH] Add tab-completion for device_add.

2012-01-08 Thread Andrzej Zaborowski
Signed-off-by: Andrzej Zaborowski andrew.zaborow...@intel.com --- There are other ways to do this, but adding an API for querying available qdev drivers was the one that made most sense to me. --- hw/qdev.c | 38 ++ hw/qdev.h |7 +++ monitor.c | 41

  1   2   >