Re: [Qemu-devel] [PATCH 2/4] memory: change dirty setting APIs to take a size

2012-01-21 Thread Blue Swirl
On Mon, Jan 9, 2012 at 12:11, Avi Kivity wrote: > On 01/08/2012 11:10 PM, Blue Swirl wrote: >> Instead of each target knowing or guessing the guest page size, >> just pass the desired size of dirtied memory area. This should also >> improve performance due to memset() optimizations. >> >> diff --g

Re: [Qemu-devel] Commit 5632ae46 broke the network on mips.

2012-01-21 Thread Stefan Weil
Am 21.01.2012 20:04, schrieb Rob Landley: commit 5632ae46: "mips_malta: move i8259 initialization after piix4 initialization" broke the network on mips. It still comes up, but doesn't pass packets. Try this: wget http://landley.net/aboriginal/bin/system-image-mips.tar.bz2 tar xvjf system

[Qemu-devel] TimersState timers_state in qemu-timer.c

2012-01-21 Thread Xin Tong
>From what I understand, qemu-timer.c keeps a timer which fires periodically to unlink TBs. there is a TimersState timers_state;. can anyone tell me what it is for ? Thanks Xin

Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

2012-01-21 Thread Andreas Färber
Am 21.01.2012 19:51, schrieb Blue Swirl: > On Mon, Jan 16, 2012 at 00:46, Andreas Färber wrote: >> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: >> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 >> type. >> >> Use uint64_t instead. >> >> Signed-off-by: And

Re: [Qemu-devel] [PATCH] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections

2012-01-21 Thread Blue Swirl
On Tue, Jan 10, 2012 at 17:38, Aurelien Jarno wrote: > On Sat, Jan 07, 2012 at 10:01:09PM +0100, Aurelien Jarno wrote: >> On Sat, Jan 07, 2012 at 08:36:12PM +, Blue Swirl wrote: >> > On Sat, Jan 7, 2012 at 20:16, Aurelien Jarno wrote: >> > > Fix .rel.plt sections in the output to not only inc

Re: [Qemu-devel] [PATCH 8/8] PPC: booke206: Implement tlbilx

2012-01-21 Thread Blue Swirl
On Sat, Jan 21, 2012 at 04:15, Alexander Graf wrote: > The PowerPC 2.06 BookE ISA defines an opcode called "tlbilx" which is used > to flush TLB entries. It's the recommended way of flushing in virtualized > environments. > > So far we got away without implementing it, but Linux for e500mc uses th

Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t

2012-01-21 Thread Blue Swirl
On Mon, Jan 16, 2012 at 00:46, Andreas Färber wrote: > Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: > Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint64 > type. > > Use uint64_t instead. > > Signed-off-by: Andreas Färber > Cc: Richard Henderson > Cc: Blue S

[Qemu-devel] Commit 5632ae46 broke the network on mips.

2012-01-21 Thread Rob Landley
commit 5632ae46: "mips_malta: move i8259 initialization after piix4 initialization" broke the network on mips. It still comes up, but doesn't pass packets. Try this: wget http://landley.net/aboriginal/bin/system-image-mips.tar.bz2 tar xvjf system-image-mips.tar.bz2 cd system-image-mips .

Re: [Qemu-devel] [PATCH 0/6] AREG0 patches v4

2012-01-21 Thread Blue Swirl
On Mon, Jan 9, 2012 at 23:04, Aurelien Jarno wrote: > On Sun, Jan 08, 2012 at 12:27:39PM +, Blue Swirl wrote: >> On Sun, Jan 8, 2012 at 00:52, Aurelien Jarno wrote: >> > On Sat, Jan 07, 2012 at 10:24:09PM +, Blue Swirl wrote: >> >> In this version, I made basic AREG0 free load/store imple

Re: [Qemu-devel] [PATCH v2 07/10] block: add a transfer rate for floppy types

2012-01-21 Thread Blue Swirl
On Mon, Jan 16, 2012 at 10:18, Kevin Wolf wrote: > Am 15.01.2012 08:51, schrieb Hervé Poussineau: >> Floppies must be read at a specific transfer rate, depending of its own >> format. >> Update floppy description table to include required transfer rate. >> >> Signed-off-by: Hervé Poussineau >> -

Re: [Qemu-devel] [PULL 00/26] ppc patch queue 2012-01-21

2012-01-21 Thread Blue Swirl
On Sat, Jan 21, 2012 at 04:18, Alexander Graf wrote: > Hi Anthony / Aurelien / Blue, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > Alex > > > The following changes since commit 515689235c4c3d9c3f0406ddcdd21ed8da77062b: >  Anthony Liguori (1): >        Merge remote-tr

Re: [Qemu-devel] [PATCH 3/4] vga: make Cirrus ISA device optional

2012-01-21 Thread Blue Swirl
On Fri, Jan 13, 2012 at 22:16, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 13.01.2012 21:09, schrieb Jan Kiszka: >> This actually also converts it to a proper ISADevice - a value of >> its own. > > Could this by any chance help with eliminating the global > isa_m

Re: [Qemu-devel] [PATCH] Init win32 CRITICAL_SECTION before starting thread; crash when attaching disks

2012-01-21 Thread Stefan Weil
Am 21.01.2012 23:08, schrieb Stefan Weil: Hi, could you please resend your patch with a Signed-by line? Signed-off-by, of course. Sorry, it's too late for writing mails :-) And you should use "git format-patch" to create the patch. See http://wiki.qemu.org/Contribute/SubmitAPatch for more

Re: [Qemu-devel] [PATCH] Init win32 CRITICAL_SECTION before starting thread; crash when attaching disks

2012-01-21 Thread Stefan Weil
Am 29.12.2011 18:29, schrieb Bogdan Harjoc: Git commit 8d3bc51 crashes on win32 on startup because qemu_tcg_init_vcpu calls: qemu_thread_create(th, qemu_tcg_cpu_thread_fn, ... ... qemu_thread_get_handle(th) which locks th->data->cs, a CRITICAL_SECTION which is initialized only in the thread_f

Re: [Qemu-devel] tb lock in qemu cpu-exec.c

2012-01-21 Thread Peter Maydell
On 21 January 2012 20:46, Xin Tong wrote: > If the unlinking does not happen. ( i.e., interrupt checking in every > TB is used instead of unlinking and force an exit). is the lock still > needed ? I don't think so. -- PMM

Re: [Qemu-devel] tb lock in qemu cpu-exec.c

2012-01-21 Thread Xin Tong
If the unlinking does not happen. ( i.e., interrupt checking in every TB is used instead of unlinking and force an exit). is the lock still needed ? Thanks Xin On Sat, Jan 21, 2012 at 2:55 PM, Peter Maydell wrote: > On 21 January 2012 19:39, Xin Tong wrote: >> There is a TB lock in the cpu-

Re: [Qemu-devel] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-21 Thread Jamie Lokier
Michael Roth wrote: > In some cases initializing the alarm timers can lead to non-negligable > overhead from programs that link against qemu-tool.o. At least, > setting a max-resolution WinMM alarm timer via mm_start_timer() (the > current default for Windows) can increase the "tick rate" on Window

Re: [Qemu-devel] tb lock in qemu cpu-exec.c

2012-01-21 Thread Peter Maydell
On 21 January 2012 19:39, Xin Tong wrote: > There is a TB lock in the cpu-exec.c. It is held before a vcpu is > trying to find the next tb it is trying to execute. I am wondering > what this lock is for. Currently, qemu is time multiplexing on a host > cpu to emulate smp. No other vcpu can be runn

[Qemu-devel] tb lock in qemu cpu-exec.c

2012-01-21 Thread Xin Tong
There is a TB lock in the cpu-exec.c. It is held before a vcpu is trying to find the next tb it is trying to execute. I am wondering what this lock is for. Currently, qemu is time multiplexing on a host cpu to emulate smp. No other vcpu can be running while the tb lookup/translation is performed.

Re: [Qemu-devel] [PATCH] block/vdi: Zero unused parts when allocating a new block (fix #919242)

2012-01-21 Thread Stefan Weil
Am 21.01.2012 13:54, schrieb Stefan Weil: The new block was filled with zero when it was allocated by g_malloc0, but when it was reused later and only partially used, data from the previously allocated block were still present and written to the new block. This caused the problems reported by bu

[Qemu-devel] [PATCH] main-loop: For tools, initialize timers as part of qemu_init_main_loop()

2012-01-21 Thread Michael Roth
In some cases initializing the alarm timers can lead to non-negligable overhead from programs that link against qemu-tool.o. At least, setting a max-resolution WinMM alarm timer via mm_start_timer() (the current default for Windows) can increase the "tick rate" on Windows OSs and affect frequency s

Re: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Jan Kiszka
On 2012-01-21 17:36, Andreas Färber wrote: > Am 21.01.2012 14:43, schrieb Jan Kiszka: >> By using strncasecmp, we allow for arbitrary characters after the >> "on"/"off" string. Fix this by switching to strcasecmp. >> >> Signed-off-by: Jan Kiszka > > Reviewed-by: Andreas Färber > > An alternativ

Re: [Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Andreas Färber
Am 21.01.2012 14:43, schrieb Jan Kiszka: > By using strncasecmp, we allow for arbitrary characters after the > "on"/"off" string. Fix this by switching to strcasecmp. > > Signed-off-by: Jan Kiszka Reviewed-by: Andreas Färber An alternative might be to increase the char count by one. For a cons

[Qemu-devel] [PATCH] qdev-property: Make bit property parsing stricter

2012-01-21 Thread Jan Kiszka
By using strncasecmp, we allow for arbitrary characters after the "on"/"off" string. Fix this by switching to strcasecmp. Signed-off-by: Jan Kiszka --- hw/qdev-properties.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c ind

[Qemu-devel] [Bug 919242] Re: qemu-img convert to VDI corrupts image

2012-01-21 Thread Stefan Weil
There is a bug in the VDI code of all current QEMU versions: when two new blocks (1 MiB clusters) were allocated in sequence and the 2nd new block was only partially filled with data, the unused parts of the new block still contained data of the 1st block instead of 0. http://patchwork.ozlabs.org

[Qemu-devel] [PATCH] block/vdi: Zero unused parts when allocating a new block (fix #919242)

2012-01-21 Thread Stefan Weil
The new block was filled with zero when it was allocated by g_malloc0, but when it was reused later and only partially used, data from the previously allocated block were still present and written to the new block. This caused the problems reported by bug #919242 (https://bugs.launchpad.net/qemu/+

Re: [Qemu-devel] vhost broken?

2012-01-21 Thread Michael Tokarev
On 21.01.2012 02:13, Lutz Vieweg wrote: > On 01/05/2012 04:00 PM, Michael S. Tsirkin wrote: >> Just chmod /dev/vhost-net to allow access > > I wonder whether it's considered a security risk to allow non-root > users access to /dev/vhost-net? > > (Or is there a way to have root prepare limited use

[Qemu-devel] [PATCH] iSCSI: add configuration variables for iSCSI

2012-01-21 Thread Ronnie Sahlberg
This patch adds configuration variables for iSCSI to set initiator-name to use when logging in to the target, which type of header-digest to negotiate with the target and username and password for CHAP authentication. This allows specifying a initiator-name either from the command line -iscsi init

[Qemu-devel] [PATCH] Add configuration variables for iscsi

2012-01-21 Thread Ronnie Sahlberg
Kevin, List This is version 2 of the patch to add configuration variables for iSCSI. This version adds the feature to specify configuration blocks that apply to a specific target name, allowing qemu to use different settings if/when connecting one guest to multiple different iscsi targets. T

Re: [Qemu-devel] [PATCH] arm: allow machine IDs > 0xffff

2012-01-21 Thread Grant Likely
On Fri, Jan 20, 2012 at 11:43 AM, Grant Likely wrote: > From: Jeremy Kerr > > Signed-off-by: Jeremy Kerr > Cc: Paul Brook > Cc: Peter Maydell > Cc: Rob Herring > Signed-off-by: Grant Likely Oops, this one won't apply directly since it's build on top of another patch. I'll repost a clean ve

Re: [Qemu-devel] [PATCH v12 4/4] arm: SoC model for Calxeda Highbank

2012-01-21 Thread Grant Likely
On Fri, Jan 20, 2012 at 01:57:29PM +, Peter Maydell wrote: > On 20 January 2012 13:48, Rob Herring wrote: > > Kernel DT co-maintainer is not authoritative enough for you? > > Only if I recognise their name :-) [ie, sorry.] > > > The documentation needs some clarification. > > > >> But this i

Re: [Qemu-devel] [PATCH v12 4/4] arm: SoC model for Calxeda Highbank

2012-01-21 Thread Grant Likely
On Fri, Jan 20, 2012 at 07:48:09AM -0600, Rob Herring wrote: > On 01/20/2012 02:47 AM, Peter Maydell wrote: > > On 19 January 2012 23:17, Rob Herring wrote: > >> On 01/19/2012 03:44 PM, Peter Maydell wrote: > >>> On 19 January 2012 21:31, Mark Langsdorf > >>> wrote: > +highbank_binfo.bo

[Qemu-devel] [PATCH] arm: allow machine IDs > 0xffff

2012-01-21 Thread Grant Likely
From: Jeremy Kerr Signed-off-by: Jeremy Kerr Cc: Paul Brook Cc: Peter Maydell Cc: Rob Herring Signed-off-by: Grant Likely --- hw/arm_boot.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/arm_boot.c b/hw/arm_boot.c index de8f1a4..f2b7332 100644 --- a/hw