Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-31 Thread Kevin Wolf
Am 30.01.2012 16:55, schrieb Paolo Bonzini: On 01/30/2012 04:43 PM, Kevin Wolf wrote: If we had force=true in the initial eject command, bdrv_close is called, which in turn goes through bdrv_dev_change_media_cb where an event is emitted. Can't this race with the guest eject? Can't see

Re: [Qemu-devel] [PATCH v11 4/9] ARM: exynos4210: PWM support.

2012-01-31 Thread Evgeny Voevodin
On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: Signed-off-by: Evgeny Voevodine.voevo...@samsung.com Reviewed-by: Peter Maydellpeter.mayd...@linaro.org --- This patch should not contain Reviewed-by: since QOM usage was added. Apologise for it. Peter, could you, please, rereview it? -- Kind

Re: [Qemu-devel] git bisect results

2012-01-31 Thread Erik Rull
On January 30, 2012 at 3:48 PM Jan Kiszka jan.kis...@siemens.com wrote: On 2012-01-30 15:17, Erik Rull wrote: On January 30, 2012 at 2:48 PM Jan Kiszka jan.kis...@siemens.com wrote: On 2012-01-30 14:17, Erik Rull wrote: On January 30, 2012 at 12:52 PM Jan Kiszka

Re: [Qemu-devel] [PATCH v11 6/9] ARM: exynos4210: MCT support.

2012-01-31 Thread Evgeny Voevodin
On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: Signed-off-by: Evgeny Voevodine.voevo...@samsung.com Reviewed-by: Peter Maydellpeter.mayd...@linaro.org This patch should not contain Reviewed-by: since QOM usage was added. Apologise for it. Peter, could you, please, rereview it? -- Kind

Re: [Qemu-devel] [PATCH v11 9/9] Exynos4210: added display controller implementation

2012-01-31 Thread Evgeny Voevodin
On 01/30/2012 11:38 AM, Evgeny Voevodin wrote: From: Mitsyanko Igori.mitsya...@samsung.com Exynos4210 display controller (FIMD) has 5 hardware windows with alpha and chroma key blending functions. Signed-off-by: Mitsyanko Igori.mitsya...@samsung.com Reviewed-by: Peter

Re: [Qemu-devel] nested page table translation for non-x86 operating system

2012-01-31 Thread 陳韋任
On Fri, Jan 20, 2012 at 08:54:12AM -0500, Xin Tong wrote: On Fri, Jan 20, 2012 at 3:23 AM, 陳韋任 che...@iis.sinica.edu.tw wrote: 1. The control of gCR3 and hCR3 needs kernel access. While they can be set with a device module as what is done in kvm. Trapping into the kernel every time gCR3 is

Re: [Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-01-31 Thread Andreas Färber
Am 31.01.2012 08:50, schrieb Paolo Bonzini: On 01/30/2012 10:09 PM, Anthony Liguori wrote: diff --git a/qom/container.c b/qom/container.c new file mode 100644 index 000..39d7b1e --- /dev/null +++ b/qom/container.c @@ -0,0 +1,15 @@ +#include qemu/object.h +#include module.h + +static

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-31 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 30.01.2012 16:18, schrieb Luiz Capitulino: On Fri, 27 Jan 2012 10:52:15 +0100 Kevin Wolf kw...@redhat.com wrote: Am 26.01.2012 18:57, schrieb Luiz Capitulino: On Wed, 25 Jan 2012 10:42:04 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Wed,

Re: [Qemu-devel] [PATCH v3 1/9] fdc: take side count into account

2012-01-31 Thread Markus Armbruster
Hervé Poussineau hpous...@reactos.org writes: Markus Armbruster a écrit : Hervé Poussineau hpous...@reactos.org writes: Floppies can be simple or double-sided. However, current code was only taking the common case into account (ie 2 sides). Impact? This repairs single-sided floppies

[Qemu-devel] [PATCH] sheepdog: fix co_recv coroutine context

2012-01-31 Thread MORITA Kazutaka
The co_recv coroutine has two things that will try to enter it: 1. The select(2) read callback on the sheepdog socket. 2. The aio_add_request() blocking operations, including a coroutine mutex. This patch fixes it by setting NULL to co_recv before sending data. In future, we should

Re: [Qemu-devel] longjmp in qemu

2012-01-31 Thread 陳韋任
On Sat, Jan 28, 2012 at 05:17:56PM -0500, Xin Tong wrote: I am investigating what longjmp is used for in qemu. longjmp is used in a couple of places. 1. void cpu_loop_exit(void) { env-current_tb = NULL; longjmp(env-jmp_env, 1); } cpu_loop_exit is called when there is an

Re: [Qemu-devel] TCG register allocator

2012-01-31 Thread 陳韋任
On Wed, Jan 25, 2012 at 01:58:10PM -0500, Xin Tong wrote: I am working on extending coremu (parallel version of qemu). Currently, the code cache in coremu is private, I am working towards to make it shared by all cores. I think the add_tb_jump may not be atomic. If you're talking about [1],

[Qemu-devel] [PATCH 08/19] linux-user: add SO_PEERCRED support for getsockopt

2012-01-31 Thread riku . voipio
From: Akos PASZTORY akos.paszt...@gmail.com Signed-off-by: Akos PASZTORY akos.paszt...@gmail.com Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 34 +- linux-user/syscall_defs.h |6 ++ 2 files changed, 39 insertions(+),

Re: [Qemu-devel] [PATCH] rtl8139: honor RxOverflow flag in can_receive method

2012-01-31 Thread Igor Kovalenko
2012/1/30 Fernando Luis Vázquez Cao ferna...@oss.ntt.co.jp: Some drivers (Linux' 8139too among them) rely on the NIC injecting an interrupt in the event of a receive buffer overflow and, accordingly, set the RxOverflow bit in the interrupt mask. Unfortunately rtl8139's can_receive method

Re: [Qemu-devel] [PATCH v3 5/9] fdc: add CCR (Configuration Control Register) write register

2012-01-31 Thread Markus Armbruster
Hervé Poussineau hpous...@reactos.org writes: Markus Armbruster a écrit : Hervé Poussineau hpous...@reactos.org writes: DIR and CCR registers share the same address ; DIR is read-only while CCR is write-only Looks like guest writes to CCR are silently ignored before this patch. Is that

[Qemu-devel] [PATCH 10/19] linux-user/strace.c: Correct errno printing for mmap etc

2012-01-31 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Correct the printing of errnos for syscalls which are handled via print_syscall_ret_addr (mmap, mmap2, brk, shmat): errnos are returned as negative returned values at this level, not via the host 'errno' variable. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 07/19] linux-user/main.c: Add option to user-mode emulation so that user can specify log file name

2012-01-31 Thread riku . voipio
From: 陳韋任 che...@iis.sinica.edu.tw QEMU linux user-mode's default log file name is /tmp/qemu.log. In order to change the log file name, user need to modify the source code then recompile QEMU. This patch allow user use -D logfile option to specify the log file name. Signed-off-by: Chen Wen-Ren

[Qemu-devel] qemu(-dm): aborting on wrong mmio size?

2012-01-31 Thread Laszlo Ersek
Hi, in the qemu-xen-unstable tree (git://xenbits.xen.org/qemu-xen-unstable.git), the do_inp() function [i386-dm/helper2.c] makes the process exit if the operand size is wrong. Blame: 6040eea5 (More files imported from xen-unstable 17192:59b8768d0d0d). In the qemu tree

Re: [Qemu-devel] [PATCH 22/23] container: make a decendent of Object

2012-01-31 Thread Paolo Bonzini
On 01/31/2012 10:21 AM, Andreas Färber wrote: License header, please. (GPLv2+ or LGPLv2+?) Given that object.c is GPLv2+, I've sticked with that license myself; but was that choice of license intentional? Effectively means we can't really have any liberally-licensed device emulation. (But

Re: [Qemu-devel] [PATCH v3 0/9] Misc fixes for floppy emulation

2012-01-31 Thread Markus Armbruster
Looks sane, except for the migration of media rate. See my reply to 7/9.

[Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets

2012-01-31 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org --- linux-user/qemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 55ad9d8..30e2abd 100644 --- a/linux-user/qemu.h +++ b/linux-user/qemu.h @@ -123,10 +123,10 @@ typedef struct

[Qemu-devel] [PATCH 15/19] linux-user: Add default-configs for mipsn32[el]

2012-01-31 Thread riku . voipio
From: Andreas Färber afaer...@suse.de Prepares for mipsn32[el]-linux-user targets. Signed-off-by: Ulricht Hecht u...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Riku Voipio riku.voi...@linaro.org --- default-configs/mipsn32-linux-user.mak |1 +

[Qemu-devel] [PATCH 11/19] linux-user: fix wait* syscall status returns

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de When calling wait4 or waitpid with a status pointer and WNOHANG, the syscall can potentially not modify the status pointer input. Now if we have guest code like: int status = 0; waitpid(pid, status, WNOHANG); if (status) breakage then we have to

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-31 Thread Avi Kivity
On 01/27/2012 06:42 AM, Alexey Korolev wrote: On 27/01/12 04:12, Avi Kivity wrote: On 01/26/2012 04:36 PM, Michael S. Tsirkin wrote: On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2012 at 06:46:03PM +1300,

[Qemu-devel] [PATCH 14/19] linux-user: Implement *listxattr syscalls

2012-01-31 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Implement listxattr, flistxattr and llistxattr syscalls. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 36 +++- 1 files changed, 35

[Qemu-devel] [PATCH 17/19] linux-user: Define TARGET_QEMU_ESIGRETURN for mipsn32

2012-01-31 Thread riku . voipio
From: Andreas Färber afaer...@suse.de Copied from mips/syscall.h. Signed-off-by: Ulrich Hecht u...@suse.de Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/mipsn32/syscall.h |3 +++ 1 files changed, 3 insertions(+), 0

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-31 Thread Avi Kivity
On 01/31/2012 11:40 AM, Avi Kivity wrote: On 01/27/2012 06:42 AM, Alexey Korolev wrote: On 27/01/12 04:12, Avi Kivity wrote: On 01/26/2012 04:36 PM, Michael S. Tsirkin wrote: On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote:

[Qemu-devel] [PATCH 12/19] linux-user: Allow NULL value pointer in setxattr and getxattr

2012-01-31 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org It's valid to pass a NULL value pointer to setxattr, so don't fail this case EFAULT. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c | 24 ++-- 1

[Qemu-devel] [PATCH 13/19] linux-user/syscall.c: Implement f and l versions of set/get/removexattr

2012-01-31 Thread riku . voipio
From: Peter Maydell peter.mayd...@linaro.org Implement the f and l versions (operate on fd, don't follow links) of the setxattr, getxattr and removexattr syscalls. Signed-off-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/syscall.c |

Re: [Qemu-devel] [PATCH 01/19] linux-user: stack_base is now mandatory on all targets

2012-01-31 Thread Andreas Färber
Am 31.01.2012 10:29, schrieb riku.voi...@linaro.org: From: Riku Voipio riku.voi...@linaro.org SoB missing. Andreas --- linux-user/qemu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/qemu.h b/linux-user/qemu.h index 55ad9d8..30e2abd 100644 ---

[Qemu-devel] [PATCH 06/19] linux-user: fake /proc/self/auxv

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de Gtk tries to read /proc/self/auxv to find its auxv table instead of taking it from its own program memory space. However, when running with linux-user, we see the host's auxv which clearly exposes wrong information. so let's instead expose the guest memory

[Qemu-devel] [PATCH 05/19] linux-user: fake /proc/self/stat

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de The boehm gc finds the program's stack starting pointer by checking /proc/self/stat. Unfortunately, so far it reads qemu's stack pointer which clearly is wrong. So let's instead fake the file so the guest program sees the right address. Signed-off-by:

[Qemu-devel] [PATCH 00/19] Pending linux-user patches

2012-01-31 Thread riku . voipio
From: Riku Voipio riku.voi...@linaro.org The collection of simpler linux-user patches submitted since release of 1.0. To be sent as pull request later this week unless bugs found. Patches are also available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git

[Qemu-devel] [PATCH 09/19] linux-user: fix QEMU_STRACE=1 segfault

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de While debugging some issues with QEMU_STRACE I stumbled over segmentation faults that were pretty reproducible. Turns out we tried to treat a normal return value as errno, resulting in an access over array boundaries for the resolution. Fix this by allowing

Re: [Qemu-devel] Proper way to walk through all vpcus

2012-01-31 Thread 陳韋任
On Sat, Jan 28, 2012 at 05:06:54PM -0500, Xin Tong wrote: What is the proper way to iterate over all vcpus in qemu ? below is what i use in my code. Not sure whether it is the best way, also is a a macro is qemu to do this ? CPUState *curr_cpu = first_cpu; for(; curr_cpu !=

Re: [Qemu-devel] setjmp outside cpu loop

2012-01-31 Thread 陳韋任
On Sun, Jan 22, 2012 at 11:18:43AM -0500, Xin Tong wrote: There is a setjmp outside the cpu loop in qemu cpu-exec.c. it is used by longjmp later when a cpu exit request is given. I am wondering that can a cpu_loop_exit() be called when the tcg is doing the translation ? Do you mean if there

Re: [Qemu-devel] Why QEMUClock is defined in qemu-timer.c?

2012-01-31 Thread Dmitry Zamaruev
This is used in many places. Maybe to simulate 'private' variables and access methods like in C++. If you define structure in .c file then every function that works with this structure must reside in same file. And any other code to use structure must use access-functions (api) to alter it and

[Qemu-devel] [PATCH 18/19] linux-user: Define TARGET_QEMU_ESIGRETURN for mips64

2012-01-31 Thread riku . voipio
From: Andreas Färber afaer...@suse.de Copied from mips/syscall.h. Signed-off-by: Khansa Butt kha...@kics.edu.pk Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Riku Voipio riku.voi...@linaro.org --- linux-user/mips64/syscall.h |3 +++ 1 files changed, 3 insertions(+), 0

[Qemu-devel] [PATCH 04/19] linux-user: fake /proc/self/maps

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de glibc's pthread_attr_getstack tries to find the stack range from /proc/self/maps. Unfortunately, /proc is usually the host's /proc which means linux-user guests see qemu's stack there. Fake the file with a constructed maps entry that exposes the guest's stack

[Qemu-devel] [PATCH 19/19] linux-user: Fix sa_flags byte swaps for mips

2012-01-31 Thread riku . voipio
From: Andreas Färber afaer...@suse.de sa_flags is uint32_t for mips{,n32,64}, so don't use tswapal(). edited by Riku Voipio: likewise on alpha Reported-by: Khansa Butt kha...@kics.edu.pk Suggested-by: Richard Henderson r...@twiddle.net Signed-off-by: Andreas Färber afaer...@suse.de Cc: Ehsan Ul

[Qemu-devel] [PATCH 16/19] linux-user: Add default configs for mips64[el]

2012-01-31 Thread riku . voipio
From: Andreas Färber afaer...@suse.de Prepares for mips64[el]-linux-user targets. Signed-off-by: Khansa Butt kha...@kics.edu.pk Signed-off-by: Andreas Färber afaer...@suse.de Signed-off-by: Riku Voipio riku.voi...@linaro.org --- default-configs/mips64-linux-user.mak |1 +

[Qemu-devel] [PATCH 03/19] linux-user: add open() hijack infrastructure

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de There are a number of files in /proc that expose host information to the guest program. This patch adds infrastructure to override the open() syscall for guest programs to enable us to on the fly generate guest sensible files. Signed-off-by: Alexander Graf

[Qemu-devel] [PATCH 02/19] linux-user: save auxv length

2012-01-31 Thread riku . voipio
From: Alexander Graf ag...@suse.de We create our own AUXV segment on stack and save a pointer to it. However we don't save the length of it, so any code that wants to do anything useful with it later on has to walk it again. Instead, let's remember the length of our AUXV segment. This simplifies

Re: [Qemu-devel] [Xen-devel] qemu(-dm): aborting on wrong mmio size?

2012-01-31 Thread Jan Beulich
On 31.01.12 at 10:34, Laszlo Ersek ler...@redhat.com wrote: in the qemu-xen-unstable tree (git://xenbits.xen.org/qemu-xen-unstable.git), the do_inp() function [i386-dm/helper2.c] makes the process exit if the operand size is wrong. Blame: 6040eea5 (More files imported from xen-unstable

Re: [Qemu-devel] [PATCH RFC 4/7] qom: Introduce CPU class

2012-01-31 Thread Andreas Färber
Am 30.01.2012 03:14, schrieb Anthony Liguori: On 01/29/2012 07:25 AM, Andreas Färber wrote: +static TypeInfo cpu_type_info = { +.name = TYPE_CPU, +.parent = TYPE_OBJECT, +.instance_size = sizeof(CPU), Probably want to do CPUState or something of that nature so that you can

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Lluís Vilanova
Anthony Liguori writes: On 01/30/2012 05:41 PM, Andreas Färber wrote: Mascot contest: Any update? Were there too few entries? Has it been forgotten? If the contest is still open then that should be stated on the list. Yes, I'm falling victim to perfectionism here attempting to find a

Re: [Qemu-devel] [RFC/PATCH] Fix guest OS panic when 64bit BAR is present

2012-01-31 Thread Avi Kivity
On 01/27/2012 06:42 AM, Alexey Korolev wrote: On 27/01/12 04:12, Avi Kivity wrote: On 01/26/2012 04:36 PM, Michael S. Tsirkin wrote: On Thu, Jan 26, 2012 at 03:52:27PM +0200, Avi Kivity wrote: On 01/26/2012 11:14 AM, Michael S. Tsirkin wrote: On Wed, Jan 25, 2012 at 06:46:03PM +1300,

Re: [Qemu-devel] [Xen-devel] qemu(-dm): aborting on wrong mmio size?

2012-01-31 Thread Laszlo Ersek
On 01/31/12 11:36, Jan Beulich wrote: On 31.01.12 at 10:34, Laszlo Ersekler...@redhat.com wrote: in the qemu-xen-unstable tree (git://xenbits.xen.org/qemu-xen-unstable.git), the do_inp() function [i386-dm/helper2.c] makes the process exit if the operand size is wrong. Blame: 6040eea5 (More

Re: [Qemu-devel] [Xen-devel] qemu(-dm): aborting on wrong mmio size?

2012-01-31 Thread Laszlo Ersek
On 01/31/12 11:36, Jan Beulich wrote: On 31.01.12 at 10:34, Laszlo Ersekler...@redhat.com wrote: Is it justified to kill the emulator when this happens (eg. memory mapped IO with 64-bit operand)? The AMD manual specifies that REX.W is ignored; the Intel manual doesn't mention REX at all

Re: [Qemu-devel] [help]how to make qemu-img utility to support writting file or directory to the image file

2012-01-31 Thread Kevin Wolf
Am 29.01.2012 10:02, schrieb 马磊: Hi, qemu-img is only to support create/info and so on whithout writting operation to the image file. I have ported the reading operation for a image file form grub2 to qemu-img. But NTFS document online is not detailed enough, how to do inorder to

Re: [Qemu-devel] [PATCH v2 00/15] SCSI s/g + SCSI migration + virtio-scsi

2012-01-31 Thread Paolo Bonzini
On 01/30/2012 10:33 AM, Hu Tao wrote: I cannot reproduce this with a 100G qcow2 image (created with qemu-img create scsi.qcow2 100G just before launching the host), with a partition starting at sector 2048 and extending to the end of the disk. mkfs (ext4) takes less than 1 minute and

[Qemu-devel] [PATCH 0/5] sdl: various fixes

2012-01-31 Thread Jan Kiszka
See individual patches for details. CC: Erik Rull erik.r...@rdsoftware.de Jan Kiszka (5): sdl: Do not grab mouse on mode switch while in background sdl: Fix block prevention of SDL_WM_GrabInput Revert Handle SDL grabs failing (Mark McLoughlin) sdl: Grab input on end of non-absolute mouse

[Qemu-devel] [PATCH 4/5] sdl: Grab input on end of non-absolute mouse click

2012-01-31 Thread Jan Kiszka
By grabbing the input already on button down, we leave the button in that state for the host GUI. Thus it takes another click after releasing the input again to synchronize the mouse button state. Avoid this by grabbing on button up. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- ui/sdl.c

[Qemu-devel] [PATCH 1/5] sdl: Do not grab mouse on mode switch while in background

2012-01-31 Thread Jan Kiszka
When the mouse mode changes to absolute while the SDL windows is not in focus, refrain from grabbing the input. It would steal from some other window. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- ui/sdl.c | 30 -- 1 files changed, 16 insertions(+), 14

[Qemu-devel] [PATCH 5/5] sdl: Limit sdl_grab_end in handle_activation to Windows hosts

2012-01-31 Thread Jan Kiszka
There are scenarios on Linux with some SDL versions where handle_activation is continuous invoked with state = SDL_APPINPUTFOCUS and gain = 0 while we grabbed the input. This causes a ping-pong when we grab the input after an absolute mouse entered the window. As this sdl_grab_end was once

[Qemu-devel] [PATCH 3/5] Revert Handle SDL grabs failing (Mark McLoughlin)

2012-01-31 Thread Jan Kiszka
This reverts commit 6bb816031f8bc0aafc3476e6dfa4293ee3a5f106. SDL_WM_GrabInput does not reliably bail out if grabbing is impossible. So if we get here, we already lost and will block. But this can no longer happen due to the check in sdl_grab_start. So this patch became obsolete. Conflicts:

[Qemu-devel] [PATCH 2/5] sdl: Fix block prevention of SDL_WM_GrabInput

2012-01-31 Thread Jan Kiszka
Consistently check for SDL_APPINPUTFOCUS before trying to grab the input focus. Just checking for SDL_APPACTIVE doesn't work. Moving the check to sdl_grab_start allows for some consolidation. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- ui/sdl.c | 26 ++ 1 files

Re: [Qemu-devel] [Xen-devel] qemu(-dm): aborting on wrong mmio size?

2012-01-31 Thread Jan Beulich
On 31.01.12 at 12:04, Laszlo Ersek ler...@redhat.com wrote: On 01/31/12 11:36, Jan Beulich wrote: On 31.01.12 at 10:34, Laszlo Ersekler...@redhat.com wrote: Is it justified to kill the emulator when this happens (eg. memory mapped IO with 64-bit operand)? The AMD manual specifies that

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Andreas Färber
Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. VMState: Anthony specifically said that VMState were not affected by QOM and that patches

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-31 Thread Kevin Wolf
Am 27.01.2012 18:53, schrieb Stefan Weil: Up to now, there was no special section for the different host operating systems used with QEMU. scripts/get_maintainer.pl did not show a maintainer for OS specific files and patches. Therefore I added three hosts systems: * POSIX for the

Re: [Qemu-devel] [PATCH] qmp: add BLOCK_MEDIUM_EJECT event

2012-01-31 Thread Luiz Capitulino
On Tue, 31 Jan 2012 10:23:59 +0100 Markus Armbruster arm...@redhat.com wrote: Kevin Wolf kw...@redhat.com writes: Am 30.01.2012 16:18, schrieb Luiz Capitulino: On Fri, 27 Jan 2012 10:52:15 +0100 Kevin Wolf kw...@redhat.com wrote: Am 26.01.2012 18:57, schrieb Luiz Capitulino: On

Re: [Qemu-devel] [PATCH 11/23] qom: allow object_class_foreach to take additional parameters to refine search

2012-01-31 Thread Andreas Färber
$subject is a bit long. Am 30.01.2012 22:08, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori aligu...@us.ibm.com Reviewed-by: Andreas Färber afaer...@suse.de However... diff --git a/hw/qdev.c b/hw/qdev.c index 636b6b4..a7980c5 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -255,7

Re: [Qemu-devel] [PATCH 07/23] qdev: kill off DeviceInfo list

2012-01-31 Thread Andreas Färber
Am 30.01.2012 22:08, schrieb Anthony Liguori: Teach the various bits of code that need to walk through available devices to do so via QOM. Signed-off-by: Anthony Liguori (Email missing.) NACK. This introduces broken code, see below. bool qdev_exists(const char *name) { -return

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Mitsyanko Igor
On 01/31/2012 05:15 PM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. VMState: Anthony specifically said that

Re: [Qemu-devel] [PATCH] multiboot: mh_load_end_addr and mh_bss_end_addr may be zero

2012-01-31 Thread Kevin Wolf
Am 23.01.2012 13:49, schrieb Göran Weinholt: There are two special cases in the address fields of the multiboot format. If mh_load_end_addr is zero then the whole image file should be loaded and if mh_bss_end_addr is zero then there is no bss segment. With this change it is again possible to

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Avi Kivity
On 01/31/2012 03:59 PM, Anthony Liguori wrote: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list. - Please officially designate a merge

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Anthony Liguori
On 01/31/2012 07:15 AM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. VMState: Anthony specifically said that

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:09 AM, Avi Kivity wrote: On 01/31/2012 03:59 PM, Anthony Liguori wrote: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering. QOM roadmap update: * Series 3/4 is on the list.

Re: [Qemu-devel] [PATCH 09/23] qdev: kill of DeviceInfo

2012-01-31 Thread Andreas Färber
Am 30.01.2012 22:08, schrieb Anthony Liguori: It is no longer used in the tree since everything is done natively through QEMU Object Model. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5,

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 hw/mc146818rtc.c | 30 ++--- hw/mc146818rtc.h | 27

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev) /* Setup the RTC IRQ */ s-rtc.irq = rtc_irq; +/* Realize the PIT */ +qdev_set_parent_bus(DEVICE(s-pit), BUS(s-bus)); +qdev_init_nofail(DEVICE(s-pit)); + +

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-31 Thread Jan Kiszka
On 2012-01-26 20:00, Anthony Liguori wrote: --- hw/pc.c | 70 -- hw/pc.h |3 +- hw/piix_pci.c | 74 +++- sysemu.h |2 - 4 files changed, 79 insertions(+), 70

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-31 Thread Peter Maydell
On 31 January 2012 13:35, Kevin Wolf kw...@redhat.com wrote: Am 27.01.2012 18:53, schrieb Stefan Weil: +Hosts: +-- + +LINUX +L: qemu-devel@nongnu.org +S: Maintained +F: linux-* +F: linux-headers/ + +POSIX +L: qemu-devel@nongnu.org +S: Maintained +F: *posix* How can these be

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40 hw/mc146818rtc.c | 30 ++---

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add a section for the host OS and a W32 maintainer

2012-01-31 Thread Kevin Wolf
Am 31.01.2012 15:40, schrieb Peter Maydell: On 31 January 2012 13:35, Kevin Wolf kw...@redhat.com wrote: Am 27.01.2012 18:53, schrieb Stefan Weil: +Hosts: +-- + +LINUX +L: qemu-devel@nongnu.org +S: Maintained +F: linux-* +F: linux-headers/ + +POSIX +L: qemu-devel@nongnu.org +S:

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Avi Kivity
On 01/31/2012 04:17 PM, Anthony Liguori wrote: On 01/31/2012 08:09 AM, Avi Kivity wrote: On 01/31/2012 03:59 PM, Anthony Liguori wrote: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are interested in covering.

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:34 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev) /* Setup the RTC IRQ */ s-rtc.irq = rtc_irq; +/* Realize the PIT */ +qdev_set_parent_bus(DEVICE(s-pit), BUS(s-bus)); +

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- hw/hpet.c| 38 +- hw/hpet_emul.h | 40

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:38 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: --- hw/pc.c | 70 -- hw/pc.h |3 +- hw/piix_pci.c | 74 +++- sysemu.h |

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:47, Anthony Liguori wrote: On 01/31/2012 08:34 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev) /* Setup the RTC IRQ */ s-rtc.irq = rtc_irq; +/* Realize the PIT */ +

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:50, Anthony Liguori wrote: On 01/31/2012 08:38 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: --- hw/pc.c | 70 -- hw/pc.h |3 +- hw/piix_pci.c | 74

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:49 AM, Jan Kiszka wrote: On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- hw/hpet.c| 38 +-

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:51 AM, Jan Kiszka wrote: On 2012-01-31 15:47, Anthony Liguori wrote: On 01/31/2012 08:34 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev) /* Setup the RTC IRQ */ s-rtc.irq = rtc_irq;

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:54, Anthony Liguori wrote: On 01/31/2012 08:49 AM, Jan Kiszka wrote: On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com --- hw/hpet.c|

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:53 AM, Jan Kiszka wrote: On 2012-01-31 15:50, Anthony Liguori wrote: On 01/31/2012 08:38 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: --- hw/pc.c | 70 -- hw/pc.h |3 +-

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Paolo Bonzini
On 01/31/2012 03:51 PM, Jan Kiszka wrote: BTW, this is yet another benefit of making structures public. You can take the address of a child and set link fields directly without accessors. Well, that has two sides. We introduced properties to avoid this direct messing. Does linking also

Re: [Qemu-devel] [PATCH 14/15] i440fx: move bios loading to i440fx

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:57, Anthony Liguori wrote: On 01/31/2012 08:53 AM, Jan Kiszka wrote: On 2012-01-31 15:50, Anthony Liguori wrote: On 01/31/2012 08:38 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: --- hw/pc.c | 70

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:56 AM, Jan Kiszka wrote: On 2012-01-31 15:54, Anthony Liguori wrote: On 01/31/2012 08:49 AM, Jan Kiszka wrote: On 2012-01-31 15:43, Anthony Liguori wrote: On 01/31/2012 08:26 AM, Jan Kiszka wrote: On 2012-01-26 20:00, Anthony Liguori wrote: Signed-off-by: Anthony

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Michael S. Tsirkin
On Tue, Jan 31, 2012 at 08:12:29AM -0600, Anthony Liguori wrote: On 01/31/2012 07:15 AM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012 19:55, schrieb Juan Quintela: Please send in any agenda items you are

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Michael S. Tsirkin
On Tue, Jan 31, 2012 at 05:04:48PM +0200, Michael S. Tsirkin wrote: On Tue, Jan 31, 2012 at 08:12:29AM -0600, Anthony Liguori wrote: On 01/31/2012 07:15 AM, Andreas Färber wrote: Am 31.01.2012 00:53, schrieb Anthony Liguori: On 01/30/2012 05:41 PM, Andreas Färber wrote: Am 30.01.2012

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-01-31 Thread Paolo Bonzini
On 01/31/2012 03:12 PM, Anthony Liguori wrote: Don't use VMState. Just open code a save/restore function. VMState is too limited in how it handles complex data structures. I really believe the only long term solution we're going to get to here is something that uses a builder interface (like

Re: [Qemu-devel] [PATCH v4 0/6] save/restore on Xen

2012-01-31 Thread Stefano Stabellini
On Wed, 25 Jan 2012, Stefano Stabellini wrote: Hi all, this is the fourth version of the Xen save/restore patch series. We have been discussing this issue for quite a while on #qemu and qemu-devel: http://marc.info/?l=qemu-develm=132346828427314w=2

Re: [Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:26, Jan Kiszka wrote: Also note that the HPET is not a part of the PIIX, so composition is wrong here. The RTC is again. Err, forgot my nonsense. The HPET is part of the PIIX. Dunno, I was somehow thinking of the IOAPIC while reading HPET. Too few sleep, I guess... Jan --

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Jan Kiszka
On 2012-01-31 15:58, Paolo Bonzini wrote: On 01/31/2012 03:51 PM, Jan Kiszka wrote: BTW, this is yet another benefit of making structures public. You can take the address of a child and set link fields directly without accessors. Well, that has two sides. We introduced properties to

[Qemu-devel] [PATCH v4 0/6] prevent QEMU from waking up needlessly

2012-01-31 Thread Stefano Stabellini
Hi all, this small patch series prevents QEMU from waking up needlessly on Xen several times a second in order to check some timers. The first patch stops QEMU from emulating the PIT on Xen, the second patch disables the rtc_clock entirely. The third patch makes use of a new mechanism to

[Qemu-devel] [PATCH v4 4/6] timers: the rearm function should be able to handle delta = INT64_MAX

2012-01-31 Thread Stefano Stabellini
Fix win32_rearm_timer and mm_rearm_timer: they should be able to handle INT64_MAX as a delta parameter without overflowing. Also, the next deadline in ms should be calculated rounding down rather than up (see unix_rearm_timer and dynticks_rearm_timer). Finally ChangeTimerQueueTimer takes an

[Qemu-devel] [PATCH v4 2/6] xen: disable rtc_clock

2012-01-31 Thread Stefano Stabellini
rtc_clock is only used by the RTC emulator (mc146818rtc.c), however Xen has its own RTC emulator in the hypervisor so we can disable it. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- xen-all.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v4 5/6] qemu_next_alarm_deadline: check the expire time of a clock only if it is enabled

2012-01-31 Thread Stefano Stabellini
Also delta in qemu_next_alarm_deadline is a 64 bit value so set the default to INT64_MAX instead of INT32_MAX. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- qemu-timer.c | 10 -- 1 files changed, 4 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c

[Qemu-devel] [PATCH v4 6/6] qemu_calculate_timeout: increase minimum timeout to 1h

2012-01-31 Thread Stefano Stabellini
There is no reason why the minimum timeout should be 1sec, it could easily be 1h and we would save lots of cpu cycles. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- qemu-timer.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-timer.c

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition

2012-01-31 Thread Anthony Liguori
On 01/31/2012 08:58 AM, Paolo Bonzini wrote: On 01/31/2012 03:51 PM, Jan Kiszka wrote: BTW, this is yet another benefit of making structures public. You can take the address of a child and set link fields directly without accessors. Well, that has two sides. We introduced properties to

  1   2   >