Re: [Qemu-devel] [PATCH 4/6] Endian fixes for virtfs

2012-02-24 Thread Aneesh Kumar K.V
On Fri, 24 Feb 2012 11:23:30 +1100, David Gibson da...@gibson.dropbear.id.au wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org This patch fixes several endian bugs in virtfs. Cc: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Benjamin Herrenschmidt

Re: [Qemu-devel] Core dumps - commit a0abe474d587499a1553372c1692811f81fd3eda

2012-02-24 Thread Peter Maydell
On 24 February 2012 05:49, Gerhard Wiesinger li...@wiesinger.com wrote: I'm getting coredumps: #0  qemu_opt_find (opts=0x0, name=0x7f18e8c833db kernel) at qemu-option.c:535 535         QTAILQ_FOREACH_REVERSE(opt, opts-head, QemuOptHead, next) { Yeah, I posted a fix for this on Tuesday:

Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:54 AM, Hu Tao wrote: should be req-req.tmf-lun here and elsewhere in this function? Yes, good catch! Paolo

[Qemu-devel] [Bug 939995] Re: v1.0-1172-g235fe3b crashes (opts=0x0)

2012-02-24 Thread Peter Maydell
This is fixed by http://patchwork.ozlabs.org/patch/142548/ (which hasn't been applied yet but hopefully will be soon). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/939995 Title:

Re: [Qemu-devel] [PATCH 1/4] Use getaddrinfo for migration

2012-02-24 Thread Kevin Wolf
Am 10.02.2012 07:27, schrieb Amos Kong: This allows us to use ipv4/ipv6 for migration addresses. Once there, it also uses /etc/services names (it came free). Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 60

Re: [Qemu-devel] [Bug 939995] Re: v1.0-1172-g235fe3b crashes (opts=0x0)

2012-02-24 Thread Roy Tam
2012/2/24 Peter Maydell peter.mayd...@linaro.org: This is fixed by http://patchwork.ozlabs.org/patch/142548/ (which hasn't been applied yet but hopefully will be soon). It looks like a workaround to me as if you feed NULL to qemu_opt_find() it will still crashing. -- You received this bug

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Stefan Hajnoczi
On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when draining activities are done, some requests maybe are in the throttled queue; So we need

Re: [Qemu-devel] [PATCH v7 00/11] XBRLE delta for live migration of large memory app

2012-02-24 Thread Stefan Hajnoczi
On Thu, Jan 26, 2012 at 04:24:46PM +0200, Orit Wasserman wrote: Changes from v6: 1) add assert checks to ULEB encoding/decoding 2) no need to send last zero run I took a quick look and I think the things I pointed out in previous versions have been addressed. I did not review the live

Re: [Qemu-devel] [PATCH 2/3] Allow larger return values from get_image_size()

2012-02-24 Thread Andreas Färber
Am 24.02.2012 01:36, schrieb David Gibson: Currently get_image_size(), used to find the size of files, returns an int. But for modern systems, int may be only 32-bit and we can have files larger than that. This patch, therefore, changes the return type of get_image_size() to off_t (the same

[Qemu-devel] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if you want to mentor a project this summer. I will

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when draining

Re: [Qemu-devel] [PATCH 2/4] net/socket: allow ipv6 for net_socket_listen_init and socket_connect_init

2012-02-24 Thread Kevin Wolf
Am 10.02.2012 07:27, schrieb Amos Kong: Remove use of parse_host_port. More SO_SOCKADDR changes. Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- net/socket.c | 60 +++--- 1 files

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with enabling I/O throttling function separately, when draining

Re: [Qemu-devel] [PATCH 3/4] net: split hostname and service by last colon

2012-02-24 Thread Kevin Wolf
Am 10.02.2012 07:27, schrieb Amos Kong: IPv6 address contains colons, parse will be wrong. [2312::8274]:5200 Signed-off-by: Amos Kong ak...@redhat.com --- net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index f63014c..9e1ef9e 100644

Re: [Qemu-devel] [PATCH 1/4] Use getaddrinfo for migration

2012-02-24 Thread Kevin Wolf
Am 10.02.2012 07:27, schrieb Amos Kong: This allows us to use ipv4/ipv6 for migration addresses. Once there, it also uses /etc/services names (it came free). Signed-off-by: Juan Quintela quint...@redhat.com Signed-off-by: Amos Kong ak...@redhat.com --- migration-tcp.c | 60

Re: [Qemu-devel] [PATCH 0/4] support to migrate with IPv6 address

2012-02-24 Thread Kevin Wolf
Am 10.02.2012 07:26, schrieb Amos Kong: Those four patches make migration of IPv6 address work. Use getaddrinfo() to socket addresses infomation. --- Amos Kong (4): Use getaddrinfo for migration net/socket: allow ipv6 for net_socket_listen_init and socket_connect_init

Re: [Qemu-devel] Qemu for simulating SoCs?

2012-02-24 Thread Magnus Therning
On Thu, Feb 23, 2012 at 23:26, Peter Maydell peter.mayd...@linaro.org wrote: On 23 February 2012 14:36, Magnus Therning mag...@therning.org wrote: Qemu seems to mostly ship with emulation of individual CPUs (e.g. ARM processors) and with emulation of boards (e.g. versatile), is it also used

Re: [Qemu-devel] Qemu for simulating SoCs?

2012-02-24 Thread Alex Bradbury
On 24 February 2012 10:20, Magnus Therning mag...@therning.org wrote: Well, true, except maybe that SystemC could be a way to write the co-processors/peripherals on the SoC. None of this is at all relevant to mainline qemu, but you might be interested in the proceedings of the 2011 QEMU Users

Re: [Qemu-devel] Qemu for simulating SoCs?

2012-02-24 Thread Peter Maydell
On 24 February 2012 10:20, Magnus Therning mag...@therning.org wrote: On Thu, Feb 23, 2012 at 23:26, Peter Maydell peter.mayd...@linaro.org wrote: Yes. Our infrastructure for doing it in a neatly encapsulated way has been a bit lacking but is getting better. Already in the tree there is

Re: [Qemu-devel] [PATCH v2] nic: zap obsolote romloading bits from ne2k + pcnet

2012-02-24 Thread Gerd Hoffmann
On 02/08/12 16:02, Gerd Hoffmann wrote: These days one just needs to specify the romfile in PCiDeviceInfo and everything magically works. It also allows to disable pxe rom loading via romfile=emptystring like it is possible for all other nics. [ v2: rebased adapted to qom changes ] ping?

Re: [Qemu-devel] [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Michal Privoznik
On 24.02.2012 10:19, Stefan Hajnoczi wrote: This is a reminder that QEMU will apply for Google Summer of Code 2012 and we need project ideas and mentors. Libvirt and kvm.ko projects are also welcome! http://wiki.qemu.org/Google_Summer_of_Code_2012 Please add yourself to the wiki now if

Re: [Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-24 Thread Gerd Hoffmann
On 02/08/12 13:54, Gerd Hoffmann wrote: This patch adds --{enable,disable}-debug-info switches to configure which allows to include/exclude the '-g' switch on the gcc ld command lines. Not building debug info reduces ressource usage (especially disk) alot and is quite useful for test builds.

Re: [Qemu-devel] FLR capability hidden in VF config space

2012-02-24 Thread rukhsana ansari
Thanks Alex. Pls see my responses below: On Thu, Feb 23, 2012 at 9:34 PM, Alex Williamson alex.william...@redhat.com wrote: On Thu, 2012-02-23 at 09:25 +0530, rukhsana ansari wrote: Hello, Was wondering whether someone could shed some light on the issue below. Without FLR exposed in

Re: [Qemu-devel] [PATCH] build: allow turning off debuginfo

2012-02-24 Thread Peter Maydell
On 24 February 2012 10:39, Gerd Hoffmann kra...@redhat.com wrote: On 02/08/12 13:54, Gerd Hoffmann wrote: This patch adds --{enable,disable}-debug-info switches to configure which allows to include/exclude the '-g' switch on the gcc ld command lines.  Not building debug info reduces ressource

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 05:25:08PM +0800, Zhi Yong Wu wrote: On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com If one guest has multiple disks with

Re: [Qemu-devel] [PATCH] split SCSI and LSI, add myself as SCSI maintainer

2012-02-24 Thread Kevin Wolf
Am 22.02.2012 15:59, schrieb Paolo Bonzini: This has been the de facto situation for a while now. Add a tree, too. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- MAINTAINERS |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

[Qemu-devel] [PATCH 1/2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- Makefile.objs |2 +- block/blkmirror.c | 247

[Qemu-devel] [PATCH] hw/arm11mpcore: Fix broken realview_mpcore/arm11mpcore_priv properties

2012-02-24 Thread Peter Maydell
Fix confusion in the Property arrays for the arm11mpcore_priv (per-CPU devices for the ARM11MPcore CPU) and realview_mpcore (realview-eb board specific device encapsulating CPU and some extra interrupt controllers) -- the num-irq property was defined on the wrong device and the

[Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- block/blkmirror.c |2 +- blockdev.c| 109 +++-- hmp-commands.hx | 36 + hmp.c | 30 ++ hmp.h |2 + qapi-schema.json

Re: [Qemu-devel] [PATCH] block: drop aio_multiwrite in BlockDriver

2012-02-24 Thread Kevin Wolf
Am 21.02.2012 16:43, schrieb Paolo Bonzini: These were never used. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH v2 1/3] vga: simplify screendump

2012-02-24 Thread Gerd Hoffmann
The displaychangelistener isn't needed at all, we can simply save the image when vga_hw_update is done instead of hooking into the update process. --- hw/vga.c | 36 +--- 1 files changed, 1 insertions(+), 35 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index

[Qemu-devel] [PATCH v2 2/3] Remove screendump dummy functions.

2012-02-24 Thread Gerd Hoffmann
The code in console.c verifies whenever a screen_dump function pointer is present before calling it, so there is no need to supply an dummy function. Remove them. Also report an error to notify the user that he didn't got a screenshot. --- console.c |2 ++ hw/jazz_led.c |7

[Qemu-devel] [PATCH v2 0/3] screendump fixups

2012-02-24 Thread Gerd Hoffmann
Hi, Next round, this time covering all screen dump implementations. cheers, Gerd Gerd Hoffmann (3): vga: simplify screendump Remove screendump dummy functions. optimize screendump for the common non-switch case console.c | 12 +--- console.h |2 +-

[Qemu-devel] [PATCH v2 3/3] optimize screendump for the common non-switch case

2012-02-24 Thread Gerd Hoffmann
switch console only if needed, also pass down whenever the console was switched or not because a displaysurface redraw is only needed in case the console was switched. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 10 +++--- console.h |2 +- hw/blizzard.c

Re: [Qemu-devel] [PATCH v5 8/9] qxl: introduce QXLCookie

2012-02-24 Thread Gerd Hoffmann
On 02/22/12 22:09, Alon Levy wrote: Will be used in the next patch. Fails checkpatch.pl. cheers, Gerd

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Kevin Wolf
Am 24.02.2012 12:37, schrieb Federico Simoncelli: Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- block/blkmirror.c |2 +- blockdev.c| 109 +++-- hmp-commands.hx | 36 + hmp.c | 30

Re: [Qemu-devel] [libvirt] Add GSoC project ideas to the wiki!

2012-02-24 Thread Stefan Hajnoczi
On Fri, Feb 24, 2012 at 10:38 AM, Michal Privoznik mpriv...@redhat.com wrote: On 24.02.2012 10:19, Stefan Hajnoczi wrote: Thank you for the opportunity. I was personally thinking about something libvirt-snmp related. Nowdays, it is difficult to add new elements to MIB, as some parts of code

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
- Original Message - From: Kevin Wolf kw...@redhat.com To: Federico Simoncelli fsimo...@redhat.com Cc: qemu-devel@nongnu.org, Marcelo Tosatti mtosa...@redhat.com, lcapitul...@redhat.com, Paolo Bonzini pbonz...@redhat.com, Markus Armbruster arm...@redhat.com Sent: Friday, February

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 09:49 AM, Stefan Hajnoczi wrote: +void bdrv_drain_request(BlockDriverState *throttled_bs) { BlockDriverState *bs; +QTAILQ_FOREACH(bs, bdrv_states, list) { +if (throttled_bs throttled_bs != bs) { +continue; +} +

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Igor Mammedov
On 02/17/2012 06:02 PM, Igor Mammedov wrote: On 02/16/2012 01:42 PM, Anthony Liguori wrote: On 02/16/2012 05:25 AM, Jan Kiszka wrote: On 2012-02-16 00:16, Igor Mammedov wrote: Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER COMMUNICATIONS), and new bus ICC to

Re: [Qemu-devel] [PATCH 1/2] block: add the support for draining the throttled request queue

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 7:18 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Fri, Feb 24, 2012 at 05:25:08PM +0800, Zhi Yong Wu wrote: On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:

Re: [Qemu-devel] [PATCH 2/2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 01:03 PM, Kevin Wolf wrote: + loop: +if (!(i sizeof(filename) - 2)) { +error_set(errp, QERR_INVALID_PARAMETER_VALUE, + new-image-file, shorter filename); +return; +} + +if

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Andreas Färber
Am 24.02.2012 14:05, schrieb Igor Mammedov: On 02/17/2012 06:02 PM, Igor Mammedov wrote: So I'd rather drop ICC patch and try your approach with CPU links, I see no point in introducing new bus providing we have an alternative model and existing bus for the task. I've looked at device_add

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 02:30 PM, Andreas Färber wrote: SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so I'd rather not base a new series on that. Not sure about that. I haven't understood well the scope of the series, but I think it only converted buses to QOM, it didn't kill

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Anthony Liguori
On 02/24/2012 07:40 AM, Paolo Bonzini wrote: On 02/24/2012 02:30 PM, Andreas Färber wrote: SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so I'd rather not base a new series on that. Not sure about that. I haven't understood well the scope of the series, but I think it

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 02:47 PM, Anthony Liguori wrote: I agree with you in principle, but in practice, there is not obvious way to serialize gpio_in/gpio_out via Visitors. Finding some way to do it as an integer is clearly wrong IMHO. %s/gpio_in[%d] % (object_get_canonical_path(...), opaque-n) is

Re: [Qemu-devel] [PATCH v4 14/18] virtio-scsi: process control queue requests

2012-02-24 Thread Paolo Bonzini
On 02/24/2012 08:54 AM, Hu Tao wrote: diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c index 380073a..1f3b851 100644 --- a/hw/virtio-scsi.c +++ b/hw/virtio-scsi.c @@ -239,7 +239,7 @@ static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq) static void

[Qemu-devel] [PULL 0/3] Trivial patches for 11 to 24 February 2012

2012-02-24 Thread Stefan Hajnoczi
The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to f293d8b1f26953ccaef794785cea0619d4f8c268:

[Qemu-devel] [PATCH 1/3] tcg: Remove unneeded include statements

2012-02-24 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de The standard include files are already included in qemu-common.h. malloc.h and alloca.h were needed for alloca() which was removed from TCG code some years ago when switching from dyngen to TCG (see commit 49516bc0d622112caac9df628caf19010fda8b67).

[Qemu-devel] [PATCH 2/3] vl.c: Increase width of machine name column in -M ? output

2012-02-24 Thread Stefan Hajnoczi
From: Peter Maydell peter.mayd...@linaro.org Increase the width of the column used for the machine name in the -M ? output from 10 to 20 spaces. This fixes the formatting so it looks nice for architectures where a few of the machines have overly long names. (Our current longest machine name is

[Qemu-devel] [PATCH 3/3] slirp/misc: fix gcc __warn_memset_zero_len warnings

2012-02-24 Thread Stefan Hajnoczi
From: Alon Levy al...@redhat.com By removing memset altogether (Patch from Stefan Hajnoczi, tested compile only by me). Signed-off-by: Alon Levy al...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- slirp/misc.c | 21 +++-- 1 files changed, 7

Re: [Qemu-devel] [RFC] sdl: initialize all graphic consoles

2012-02-24 Thread Stefano Stabellini
On Thu, 23 Feb 2012, Anthony Liguori wrote: diff --git a/console.c b/console.c index 135394f..2c413a7 100644 --- a/console.c +++ b/console.c @@ -1376,6 +1376,9 @@ DisplayState *get_displaystate(void) if (!display_state) { dumb_display_init (); } +if

[Qemu-devel] [PATCH 0/5]: Improve machine type functions

2012-02-24 Thread Luiz Capitulino
I was reading some related code yesterday and couldn't resist improving this. Not sure if this is aligned with any possible QOM work in this area, but I'm posting this anyway... Makefile.target |3 +- hw/alpha_dp264.c |2 +- hw/an5206.c |2

[Qemu-devel] [PATCH 1/5] boards: qemu_register_machine(): return void

2012-02-24 Thread Luiz Capitulino
It never fails. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/boards.h |2 +- vl.c|3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 667177d..7a9899f 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -31,7 +31,7 @@

Re: [Qemu-devel] [PATCH 1/5] boards: qemu_register_machine(): return void

2012-02-24 Thread Andreas Färber
Am 24.02.2012 15:13, schrieb Luiz Capitulino: It never fails. ...and is never checked. Low-impact cleanup, thanks. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas --- hw/boards.h |2 +- vl.c|3 +-- 2 files

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Andreas Färber
Am 24.02.2012 15:13, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Unless this fixes a bug, I'd rather not refactor this as in my head this is already just object_class_foreach() / object_class_by_name(), similar to CPUs on my qom-cpu branch. Andreas ---

[Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Luiz Capitulino
Perform the following renames: o qemu_register_machine() - machine_register() o find_machine() - machine_find() o find_default_machine() - machine_find_default() Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/alpha_dp264.c |2 +- hw/an5206.c

Re: [Qemu-devel] [PATCH 3/5] boards: introduce machine_print_all()

2012-02-24 Thread Andreas Färber
Am 24.02.2012 15:13, schrieb Luiz Capitulino: Print all registered machine types. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com I'm okay with the code movement, but is there a reason not to make it static? Needs a rebase due to 10 - 20 bump by Peter. Andreas --- hw/boards.h |

[Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/boards.h |3 ++- vl.c| 16 ++-- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 342a774..1eb8314 100644 --- a/hw/boards.h +++ b/hw/boards.h @@ -4,6 +4,7 @@

[Qemu-devel] [PATCH 3/5] boards: introduce machine_print_all()

2012-02-24 Thread Luiz Capitulino
Print all registered machine types. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/boards.h |1 + vl.c| 25 - 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/boards.h b/hw/boards.h index 098cbb7..342a774 100644 ---

[Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

2012-02-24 Thread Luiz Capitulino
The license text is the same as used in vl.c. Also note that it's necessary to make machine_parse() public. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile.target |3 +- hw/boards.c | 86 +++ hw/boards.h |1

Re: [Qemu-devel] [PATCH 1/7] Introduce a new bus ICC to connect APIC

2012-02-24 Thread Anthony Liguori
On 02/24/2012 07:50 AM, Paolo Bonzini wrote: On 02/24/2012 02:47 PM, Anthony Liguori wrote: I agree with you in principle, but in practice, there is not obvious way to serialize gpio_in/gpio_out via Visitors. Finding some way to do it as an integer is clearly wrong IMHO. %s/gpio_in[%d] %

Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 08:13 AM, Luiz Capitulino wrote: I was reading some related code yesterday and couldn't resist improving this. Not sure if this is aligned with any possible QOM work in this area, but I'm posting this anyway... I'm not sure how easy this is, but the way to do this with QOM would

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-02-24 Thread Anthony Liguori
On 02/18/2012 03:19 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wuwu...@linux.vnet.ibm.com The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. Signed-off-by: Zhi Yong

Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

2012-02-24 Thread Andreas Färber
Am 24.02.2012 15:13, schrieb Luiz Capitulino: The license text is the same as used in vl.c. Also note that it's necessary to make machine_parse() public. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- Makefile.target |3 +- hw/boards.c | 86

Re: [Qemu-devel] [PATCH] qom: Make object_unref() free the object's memory when refcount goes to 0.

2012-02-24 Thread Anthony Liguori
On 02/23/2012 10:21 AM, Alexander Barabash wrote: On 02/22/2012 09:12 PM, Anthony Liguori wrote: On 02/22/2012 12:00 PM, alexander_barab...@mentor.com wrote: From: Alexander Barabashalexander_barab...@mentor.com In the existing implementation, object_delete() calls object_unref(), then frees

Re: [Qemu-devel] [PATCH 3/5] boards: introduce machine_print_all()

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 15:26:36 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:13, schrieb Luiz Capitulino: Print all registered machine types. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com I'm okay with the code movement, but is there a reason not to make it

Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 08:58:55 -0600 Anthony Liguori aligu...@us.ibm.com wrote: On 02/24/2012 08:13 AM, Luiz Capitulino wrote: I was reading some related code yesterday and couldn't resist improving this. Not sure if this is aligned with any possible QOM work in this area, but I'm posting

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Andreas Färber
Am 24.02.2012 15:56, schrieb Luiz Capitulino: On Fri, 24 Feb 2012 15:23:43 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:13, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Unless this fixes a bug, I'd rather not refactor this as in my head

Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:10:17 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:13, schrieb Luiz Capitulino: The license text is the same as used in vl.c. Also note that it's necessary to make machine_parse() public. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com ---

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 16:21:56 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:56, schrieb Luiz Capitulino: On Fri, 24 Feb 2012 15:23:43 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:13, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH 00/19] Fix and improve chardev open error messages

2012-02-24 Thread Anthony Liguori
On 02/07/2012 08:09 AM, Markus Armbruster wrote: Our chardev open error messages are an embarrassment. Commit 6e1db57b tried to improve the useless opening backend FOO failed message in qemu_chr_open_opts(), but it is flawed: some failure modes went from an unhelpful failed to an outright

Re: [Qemu-devel] [PATCH 0/4] target-i386: Helpers for CPUID version

2012-02-24 Thread Anthony Liguori
On 02/17/2012 10:46 AM, Andreas Färber wrote: Hello x86 gurus, This series came out of my qom-cpu work. The reasoning is that in a QOM world we will need this logic twice, once as before and once for -cpu family=x,model=y,stepping=z,model_id=foo. Note: The family=x value is not bounds-checked

Re: [Qemu-devel] [PATCH 0/7] cpu model bug fixes and definition corrections (v3)

2012-02-24 Thread Anthony Liguori
On 02/17/2012 10:41 AM, Eduardo Habkost wrote: These are patches based on a series that John Cooper sent back in May 2011, and that I resent last June. Not all changes from that series are here, but just the most obvious ones. The previous submission of this series is:

Re: [Qemu-devel] [PATCH] split SCSI and LSI, add myself as SCSI maintainer

2012-02-24 Thread Anthony Liguori
On 02/22/2012 08:59 AM, Paolo Bonzini wrote: This has been the de facto situation for a while now. Add a tree, too. Signed-off-by: Paolo Bonzinipbonz...@redhat.com Applied. Thanks. Regards, Anthony Liguori --- MAINTAINERS |9 +++-- 1 files changed, 7 insertions(+), 2

Re: [Qemu-devel] [PATCH] qom: In function object_set_link_property(), first call object_ref(), then object_unref().

2012-02-24 Thread Anthony Liguori
On 02/22/2012 11:22 AM, alexander_barab...@mentor.com wrote: From: Alexander Barabashalexander_barab...@mentor.com In the old implementation, if the new value of the property links to the same object, as the old value, that object is first unref-ed, and then ref-ed. This leads to unintended

Re: [Qemu-devel] [PATCH 4/5] boards: switch machine type list to QTAILQ

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 15:23:43 +0100 Andreas Färber afaer...@suse.de wrote: Am 24.02.2012 15:13, schrieb Luiz Capitulino: Signed-off-by: Luiz Capitulino lcapitul...@redhat.com Unless this fixes a bug, I'd rather not refactor this as in my head this is already just object_class_foreach() /

Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 09:20 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 08:58:55 -0600 Anthony Liguorialigu...@us.ibm.com wrote: On 02/24/2012 08:13 AM, Luiz Capitulino wrote: I was reading some related code yesterday and couldn't resist improving this. Not sure if this is aligned with any

[Qemu-devel] [PATCH 1/2] Add \n to the end of fatal spice error messages

2012-02-24 Thread Christophe Fergeau
Without it the shell prompt doesn't appear on a new line after qemu dies. --- ui/spice-core.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 1308a3d..6d240a3 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -568,15

[Qemu-devel] [PATCH 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Christophe Fergeau
It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. --- ui/spice-core.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ui/spice-core.c

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Anthony Liguori
On 02/23/2012 08:08 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbrusterarm...@redhat.com wrote: Kevin Wolfkw...@redhat.com writes: Am 17.02.2012 20:21, schrieb Luiz Capitulino: It's emitted whenever the tray is

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-24 Thread Alexander Graf
On 24.02.2012, at 16:58, Anthony Liguori wrote: On 02/23/2012 09:34 AM, Michael S. Tsirkin wrote: On Tue, Feb 21, 2012 at 10:36:43AM +0100, Hannes Reinecke wrote: This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA. I've tested it to work with Linux, Windows Vista, and

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Peter Maydell
On 24 February 2012 14:13, Luiz Capitulino lcapitul...@redhat.com wrote: Perform the following renames:  o qemu_register_machine() - machine_register()  o find_machine() - machine_find()  o find_default_machine()  - machine_find_default() Signed-off-by: Luiz Capitulino

Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:05 AM, Alexander Graf wrote: So Alex asked whether I can merge this, which made me take a look. I don't know much about what this does so just general comments on all of the code. This should come through Paolo's new SCSI tree. And while I defended this before, I now think

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:12 AM, Peter Maydell wrote: On 24 February 2012 14:13, Luiz Capitulinolcapitul...@redhat.com wrote: Perform the following renames: o qemu_register_machine() - machine_register() o find_machine() - machine_find() o find_default_machine() - machine_find_default()

Re: [Qemu-devel] [PULL v4 00/18] virtio-scsi driver

2012-02-24 Thread Anthony Liguori
On 02/22/2012 08:33 AM, Paolo Bonzini wrote: Anthony, the following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git repository at: git://github.com/bonzini/qemu.git

Re: [Qemu-devel] [PULL] Merge qemu-iotests into qemu.git

2012-02-24 Thread Anthony Liguori
On 02/23/2012 03:48 AM, Kevin Wolf wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regards, Anthony

Re: [Qemu-devel] [PULL 0/5]: QMP queue

2012-02-24 Thread Anthony Liguori
On 02/23/2012 08:42 AM, Luiz Capitulino wrote: Contains only the DEVICE_TRAY_MOVED event series. The changes (since 235fe3bfd46b1104575b540d0bc3fdf584030b99) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Pulled. Thanks. Regards, Anthony

Re: [Qemu-devel] [PULL] Zynq-7000 EPP platform model

2012-02-24 Thread Anthony Liguori
On 02/20/2012 12:25 AM, Peter Crosthwaite wrote: Pull Request for Zynq-7000 platform model initial support. The following changes since commit 99c7f87826337fa81f2f0f9baa9ca0a44faf90e9: input: send kbd+mouse events only to running guests. (2012-02-17 11:02:55 -0600) are available in the git

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:01:00 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 02/23/2012 08:08 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus Armbrusterarm...@redhat.com wrote: Kevin Wolfkw...@redhat.com

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Anthony Liguori
On 02/24/2012 10:39 AM, Luiz Capitulino wrote: On Fri, 24 Feb 2012 10:01:00 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 02/23/2012 08:08 AM, Markus Armbruster wrote: Luiz Capitulinolcapitul...@redhat.com writes: On Thu, 23 Feb 2012 08:50:08 +0100 Markus

Re: [Qemu-devel] [PATCH 1/2] Add \n to the end of fatal spice error messages

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 11:37, Christophe Fergeau wrote: Without it the shell prompt doesn't appear on a new line after qemu dies. --- ui/spice-core.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 1308a3d..6d240a3 100644 ---

Re: [Qemu-devel] [PULL 0/3] Trivial patches for 11 to 24 February 2012

2012-02-24 Thread Anthony Liguori
On 02/24/2012 08:00 AM, Stefan Hajnoczi wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch

Re: [Qemu-devel] [PATCH 2/2] Error out when tls-channel option is used without TLS

2012-02-24 Thread Gerd Hoffmann
On 02/24/12 11:37, Christophe Fergeau wrote: It's currently possible to setup spice channels using TLS when no TLS port has been specified (ie TLS is disabled). This cannot work, so better to error out in such a situation. --- ui/spice-core.c |8 +++- 1 files changed, 7

[Qemu-devel] [PATCH 1/2 v2] Add blkmirror block driver

2012-02-24 Thread Federico Simoncelli
From: Marcelo Tosatti mtosa...@redhat.com Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- Makefile.objs |2 +- block/blkmirror.c | 247

[Qemu-devel] [PATCH 2/2 v2] Add the blockdev-reopen and blockdev-migrate commands

2012-02-24 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- blockdev.c | 107 -- hmp-commands.hx | 38 +++ hmp.c| 24 hmp.h|2 + qapi-schema.json | 54

Re: [Qemu-devel] [PATCH v2] net: add the support for -netdev socket, listen

2012-02-24 Thread Zhi Yong Wu
On Fri, Feb 24, 2012 at 11:05 PM, Anthony Liguori aligu...@us.ibm.com wrote: On 02/18/2012 03:19 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wuwu...@linux.vnet.ibm.com The -net socket,listen option does not work with the newer -netdev syntax:

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:15:52 -0600 Anthony Liguori aligu...@us.ibm.com wrote: On 02/24/2012 10:12 AM, Peter Maydell wrote: On 24 February 2012 14:13, Luiz Capitulinolcapitul...@redhat.com wrote: Perform the following renames: o qemu_register_machine() - machine_register() o

Re: [Qemu-devel] [PULL 0/8] qemu-ga: add support for Windows

2012-02-24 Thread Anthony Liguori
On 02/23/2012 04:10 PM, Michael Roth wrote: The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99: qom: add test tools (2012-02-22 12:18:26 -0600) are available in the git repository at: git://github.com/mdroth/qemu.git qga-win32-pull-2-23-12 Pulled. Thanks.

Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event

2012-02-24 Thread Luiz Capitulino
On Fri, 24 Feb 2012 10:44:11 -0600 Anthony Liguori anth...@codemonkey.ws wrote: I'm asking because the conversion of events to the qapi is not too far away, but I think that using QOM will somewhat deprecate the code you have in the glib branch (besides having to wait for 1.2)? I have

  1   2   >