Am 24.02.2012 15:56, schrieb Luiz Capitulino:
> On Fri, 24 Feb 2012 15:23:43 +0100
> Andreas Färber wrote:
>
>> Am 24.02.2012 15:13, schrieb Luiz Capitulino:
>>> Signed-off-by: Luiz Capitulino
>>
>> Unless this fixes a bug, I'd rather not refactor this as in my head this
>> is already just objec
On Fri, 24 Feb 2012 08:58:55 -0600
Anthony Liguori wrote:
> On 02/24/2012 08:13 AM, Luiz Capitulino wrote:
> > I was reading some related code yesterday and couldn't resist improving
> > this.
> > Not sure if this is aligned with any possible QOM work in this area, but I'm
> > posting this anywa
On Fri, 24 Feb 2012 15:26:36 +0100
Andreas Färber wrote:
> Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> > Print all registered machine types.
> >
> > Signed-off-by: Luiz Capitulino
>
> I'm okay with the code movement, but is there a reason not to make it
> static?
I can make it static.
>
On 02/23/2012 10:21 AM, Alexander Barabash wrote:
On 02/22/2012 09:12 PM, Anthony Liguori wrote:
On 02/22/2012 12:00 PM, alexander_barab...@mentor.com wrote:
From: Alexander Barabash
In the existing implementation, object_delete()
calls object_unref(), then frees the object's storage.
Running
Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> The license text is the same as used in vl.c. Also note that it's
> necessary to make machine_parse() public.
>
> Signed-off-by: Luiz Capitulino
> ---
> Makefile.target |3 +-
> hw/boards.c | 86
>
On 02/18/2012 03:19 AM, zwu.ker...@gmail.com wrote:
From: Zhi Yong Wu
The -net socket,listen option does not work with the newer -netdev
syntax:
http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html
This patch makes it work now.
Signed-off-by: Zhi Yong Wu
---
net.c| 26
On 02/24/2012 08:13 AM, Luiz Capitulino wrote:
I was reading some related code yesterday and couldn't resist improving this.
Not sure if this is aligned with any possible QOM work in this area, but I'm
posting this anyway...
I'm not sure how easy this is, but the way to do this with QOM would b
On 02/24/2012 07:50 AM, Paolo Bonzini wrote:
On 02/24/2012 02:47 PM, Anthony Liguori wrote:
I agree with you in principle, but in practice, there is not obvious way
to serialize gpio_in/gpio_out via Visitors. Finding some way to do it
as an integer is clearly wrong IMHO.
"%s/gpio_in[%d]" %
The license text is the same as used in vl.c. Also note that it's
necessary to make machine_parse() public.
Signed-off-by: Luiz Capitulino
---
Makefile.target |3 +-
hw/boards.c | 86 +++
hw/boards.h |1 +
vl.c|
Print all registered machine types.
Signed-off-by: Luiz Capitulino
---
hw/boards.h |1 +
vl.c| 25 -
2 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/hw/boards.h b/hw/boards.h
index 098cbb7..342a774 100644
--- a/hw/boards.h
+++ b/hw/boards.h
@
Signed-off-by: Luiz Capitulino
---
hw/boards.h |3 ++-
vl.c| 16 ++--
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/hw/boards.h b/hw/boards.h
index 342a774..1eb8314 100644
--- a/hw/boards.h
+++ b/hw/boards.h
@@ -4,6 +4,7 @@
#define HW_BOARDS_H
#incl
Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> Print all registered machine types.
>
> Signed-off-by: Luiz Capitulino
I'm okay with the code movement, but is there a reason not to make it
static?
Needs a rebase due to 10 -> 20 bump by Peter.
Andreas
> ---
> hw/boards.h |1 +
> vl.c
Perform the following renames:
o qemu_register_machine() -> machine_register()
o find_machine() -> machine_find()
o find_default_machine() -> machine_find_default()
Signed-off-by: Luiz Capitulino
---
hw/alpha_dp264.c |2 +-
hw/an5206.c |2 +-
hw/axis_d
Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> Signed-off-by: Luiz Capitulino
Unless this fixes a bug, I'd rather not refactor this as in my head this
is already just object_class_foreach() / object_class_by_name(), similar
to CPUs on my qom-cpu branch.
Andreas
> ---
> hw/boards.h |3 ++-
Am 24.02.2012 15:13, schrieb Luiz Capitulino:
> It never fails.
...and is never checked. Low-impact cleanup, thanks.
>
> Signed-off-by: Luiz Capitulino
Reviewed-by: Andreas Färber
Andreas
> ---
> hw/boards.h |2 +-
> vl.c|3 +--
> 2 files changed, 2 insertions(+), 3 deletio
It never fails.
Signed-off-by: Luiz Capitulino
---
hw/boards.h |2 +-
vl.c|3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/boards.h b/hw/boards.h
index 667177d..7a9899f 100644
--- a/hw/boards.h
+++ b/hw/boards.h
@@ -31,7 +31,7 @@ typedef struct QEMUMachin
I was reading some related code yesterday and couldn't resist improving this.
Not sure if this is aligned with any possible QOM work in this area, but I'm
posting this anyway...
Makefile.target |3 +-
hw/alpha_dp264.c |2 +-
hw/an5206.c |2
On Thu, 23 Feb 2012, Anthony Liguori wrote:
> > diff --git a/console.c b/console.c
> > index 135394f..2c413a7 100644
> > --- a/console.c
> > +++ b/console.c
> > @@ -1376,6 +1376,9 @@ DisplayState *get_displaystate(void)
> > if (!display_state) {
> > dumb_display_init ();
> > }
From: Alon Levy
By removing memset altogether (Patch from Stefan Hajnoczi, tested
compile only by me).
Signed-off-by: Alon Levy
Signed-off-by: Stefan Hajnoczi
---
slirp/misc.c | 21 +++--
1 files changed, 7 insertions(+), 14 deletions(-)
diff --git a/slirp/misc.c b/slirp/mi
From: Peter Maydell
Increase the width of the column used for the machine name in
the "-M ?" output from 10 to 20 spaces. This fixes the formatting
so it looks nice for architectures where a few of the machines
have overly long names. (Our current longest machine name is
"petalogix-s3adsp1800" wi
From: Stefan Weil
The standard include files are already included in qemu-common.h.
malloc.h and alloca.h were needed for alloca() which was removed
from TCG code some years ago when switching from dyngen to TCG
(see commit 49516bc0d622112caac9df628caf19010fda8b67).
Signed-off-by: Stefan Weil
The following changes since commit 235fe3bfd46b1104575b540d0bc3fdf584030b99:
qom: add test tools (2012-02-22 12:18:26 -0600)
are available in the git repository at:
git://github.com/stefanha/qemu.git trivial-patches
for you to fetch changes up to f293d8b1f26953ccaef794785cea0619d4f8c268:
On 02/24/2012 08:54 AM, Hu Tao wrote:
> diff --git a/hw/virtio-scsi.c b/hw/virtio-scsi.c
> index 380073a..1f3b851 100644
> --- a/hw/virtio-scsi.c
> +++ b/hw/virtio-scsi.c
> @@ -239,7 +239,7 @@ static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s,
> VirtQueue *vq)
>
> static void virtio_scsi_
On 02/24/2012 02:47 PM, Anthony Liguori wrote:
>>
>
> I agree with you in principle, but in practice, there is not obvious way
> to serialize gpio_in/gpio_out via Visitors. Finding some way to do it
> as an integer is clearly wrong IMHO.
"%s/gpio_in[%d]" % (object_get_canonical_path(...), opaque
On 02/24/2012 07:40 AM, Paolo Bonzini wrote:
On 02/24/2012 02:30 PM, Andreas Färber wrote:
SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so
I'd rather not base a new series on that.
Not sure about that. I haven't understood well the scope of the series,
but I think it on
On 02/24/2012 02:30 PM, Andreas Färber wrote:
> SysBus is supposed to go away in Anthony's upcoming 4th QOM series, so
> I'd rather not base a new series on that.
Not sure about that. I haven't understood well the scope of the series,
but I think it only converted buses to QOM, it didn't kill the
Am 24.02.2012 14:05, schrieb Igor Mammedov:
> On 02/17/2012 06:02 PM, Igor Mammedov wrote:
>> So I'd rather drop ICC patch and try your approach with CPU links<>, I
>> see no
>> point in introducing new bus providing we have an alternative model
>> and existing
>> bus for the task.
>
> I've looked
On 02/24/2012 01:03 PM, Kevin Wolf wrote:
>> + loop:
>> +if (!(i < sizeof(filename) - 2)) {
>> +error_set(errp, QERR_INVALID_PARAMETER_VALUE,
>> + "new-image-file", "shorter filename");
>> +return;
>> +}
>> +
>> +
On Fri, Feb 24, 2012 at 7:18 PM, Stefan Hajnoczi
wrote:
> On Fri, Feb 24, 2012 at 05:25:08PM +0800, Zhi Yong Wu wrote:
>> On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi wrote:
>> > On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:
>> >> From: Zhi Yong Wu
>> >>
>> >> If one
On 02/17/2012 06:02 PM, Igor Mammedov wrote:
On 02/16/2012 01:42 PM, Anthony Liguori wrote:
On 02/16/2012 05:25 AM, Jan Kiszka wrote:
On 2012-02-16 00:16, Igor Mammedov wrote:
Introduce a new structure CPUS as the controller of ICC (INTERRUPT
CONTROLLER COMMUNICATIONS), and new bus "ICC" to ho
On 02/24/2012 09:49 AM, Stefan Hajnoczi wrote:
>> > +void bdrv_drain_request(BlockDriverState *throttled_bs)
>> > {
>> > BlockDriverState *bs;
>> >
>> > +QTAILQ_FOREACH(bs, &bdrv_states, list) {
>> > +if (throttled_bs && throttled_bs != bs) {
>> > +continue;
>> > +
- Original Message -
> From: "Kevin Wolf"
> To: "Federico Simoncelli"
> Cc: qemu-devel@nongnu.org, "Marcelo Tosatti" ,
> lcapitul...@redhat.com, "Paolo Bonzini"
> , "Markus Armbruster"
> Sent: Friday, February 24, 2012 1:03:08 PM
> Subject: Re: [PATCH 2/2] Add the blockdev-reopen and bl
On Fri, Feb 24, 2012 at 10:38 AM, Michal Privoznik wrote:
> On 24.02.2012 10:19, Stefan Hajnoczi wrote:
> Thank you for the opportunity. I was personally thinking about something
> libvirt-snmp related. Nowdays, it is difficult to add new elements to
> MIB, as some parts of code were generated by
Am 24.02.2012 12:37, schrieb Federico Simoncelli:
> Signed-off-by: Federico Simoncelli
> ---
> block/blkmirror.c |2 +-
> blockdev.c| 109
> +++--
> hmp-commands.hx | 36 +
> hmp.c | 30 ++
On 02/22/12 22:09, Alon Levy wrote:
> Will be used in the next patch.
Fails checkpatch.pl.
cheers,
Gerd
switch console only if needed, also pass down whenever the console was
switched or not because a displaysurface redraw is only needed in case
the console was switched.
Signed-off-by: Gerd Hoffmann
---
console.c | 10 +++---
console.h |2 +-
hw/blizzard.c |8 ++--
Hi,
Next round, this time covering all screen dump implementations.
cheers,
Gerd
Gerd Hoffmann (3):
vga: simplify screendump
Remove screendump dummy functions.
optimize screendump for the common non-switch case
console.c | 12 +---
console.h |2 +-
hw/blizza
The code in console.c verifies whenever a screen_dump function
pointer is present before calling it, so there is no need to supply an
dummy function. Remove them. Also report an error to notify the user
that he didn't got a screenshot.
---
console.c |2 ++
hw/jazz_led.c |7 +-
The displaychangelistener isn't needed at all, we can simply save the
image when vga_hw_update is done instead of hooking into the update
process.
---
hw/vga.c | 36 +---
1 files changed, 1 insertions(+), 35 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index c10
Am 21.02.2012 16:43, schrieb Paolo Bonzini:
> These were never used.
>
> Signed-off-by: Paolo Bonzini
Thanks, applied to the block branch.
Kevin
Signed-off-by: Federico Simoncelli
---
block/blkmirror.c |2 +-
blockdev.c| 109 +++--
hmp-commands.hx | 36 +
hmp.c | 30 ++
hmp.h |2 +
qapi-schema.json | 63 +++
Fix confusion in the Property arrays for the "arm11mpcore_priv"
(per-CPU devices for the ARM11MPcore CPU) and "realview_mpcore"
(realview-eb board specific device encapsulating CPU and some
extra interrupt controllers) -- the num-irq property was defined
on the wrong device and the mpcore_rirq_prop
From: Marcelo Tosatti
Mirrored writes are used by live block copy.
Signed-off-by: Marcelo Tosatti
Signed-off-by: Federico Simoncelli
---
Makefile.objs |2 +-
block/blkmirror.c | 247
docs/blkmirror.txt | 16
3 files change
Am 22.02.2012 15:59, schrieb Paolo Bonzini:
> This has been the de facto situation for a while now.
> Add a tree, too.
>
> Signed-off-by: Paolo Bonzini
> ---
> MAINTAINERS |9 +++--
> 1 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 647
On Fri, Feb 24, 2012 at 05:25:08PM +0800, Zhi Yong Wu wrote:
> On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi wrote:
> > On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:
> >> From: Zhi Yong Wu
> >>
> >> If one guest has multiple disks with enabling I/O throttling function
On 24 February 2012 10:39, Gerd Hoffmann wrote:
> On 02/08/12 13:54, Gerd Hoffmann wrote:
>> This patch adds --{enable,disable}-debug-info switches to configure
>> which allows to include/exclude the '-g' switch on the gcc & ld
>> command lines. Not building debug info reduces ressource usage
>>
Thanks Alex. Pls see my responses below:
On Thu, Feb 23, 2012 at 9:34 PM, Alex Williamson wrote:
> On Thu, 2012-02-23 at 09:25 +0530, rukhsana ansari wrote:
> > Hello,
> >
> > Was wondering whether someone could shed some light on the issue below.
> > Without FLR exposed in the VF, VF reset via
On 02/08/12 13:54, Gerd Hoffmann wrote:
> This patch adds --{enable,disable}-debug-info switches to configure
> which allows to include/exclude the '-g' switch on the gcc & ld
> command lines. Not building debug info reduces ressource usage
> (especially disk) alot and is quite useful for test bui
On 24.02.2012 10:19, Stefan Hajnoczi wrote:
> This is a reminder that QEMU will apply for Google Summer of Code 2012 and we
> need project ideas and mentors. Libvirt and kvm.ko projects are also welcome!
>
> http://wiki.qemu.org/Google_Summer_of_Code_2012
>
> Please add yourself to the wiki now
On 02/08/12 16:02, Gerd Hoffmann wrote:
> These days one just needs to specify the romfile in PCiDeviceInfo and
> everything magically works. It also allows to disable pxe rom loading
> via "romfile=" like it is possible for all other nics.
>
> [ v2: rebased & adapted to qom changes ]
ping?
che
On 24 February 2012 10:20, Magnus Therning wrote:
> On Thu, Feb 23, 2012 at 23:26, Peter Maydell wrote:
>> Yes. Our infrastructure for doing it in a neatly encapsulated
>> way has been a bit lacking but is getting better. Already in
>> the tree there is emulation of OMAP1 and OMAP2 and (just land
On 24 February 2012 10:20, Magnus Therning wrote:
> Well, true, except maybe that SystemC could be a way to write the
> co-processors/peripherals on the SoC.
None of this is at all relevant to mainline qemu, but you might be
interested in the proceedings of the 2011 QEMU Users Forum which
contain
On Thu, Feb 23, 2012 at 23:26, Peter Maydell wrote:
> On 23 February 2012 14:36, Magnus Therning wrote:
>> Qemu seems to mostly ship with emulation of individual CPUs (e.g. ARM
>> processors) and with emulation of boards (e.g. versatile), is it also
>> used for emulation of SoC?
>
> Yes. Our infr
Am 10.02.2012 07:26, schrieb Amos Kong:
> Those four patches make migration of IPv6 address work.
> Use getaddrinfo() to socket addresses infomation.
>
> ---
>
> Amos Kong (4):
> Use getaddrinfo for migration
> net/socket: allow ipv6 for net_socket_listen_init and
> socket_connect_in
Am 10.02.2012 07:27, schrieb Amos Kong:
> This allows us to use ipv4/ipv6 for migration addresses.
> Once there, it also uses /etc/services names (it came free).
>
> Signed-off-by: Juan Quintela
> Signed-off-by: Amos Kong
> ---
> migration-tcp.c | 60 ---
> net.c
Am 10.02.2012 07:27, schrieb Amos Kong:
> IPv6 address contains colons, parse will be wrong.
>
> [2312::8274]:5200
>
> Signed-off-by: Amos Kong
> ---
> net.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/net.c b/net.c
> index f63014c..9e1ef9e 100644
> --- a
On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi wrote:
> On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> If one guest has multiple disks with enabling I/O throttling function
>> separately, when draining activities are done, some requests maybe a
Am 10.02.2012 07:27, schrieb Amos Kong:
> Remove use of parse_host_port.
> More SO_SOCKADDR changes.
>
> Signed-off-by: Juan Quintela
> Signed-off-by: Amos Kong
> ---
> net/socket.c | 60
> +++---
> 1 files changed, 11 insertions(+), 49 del
On Fri, Feb 24, 2012 at 4:49 PM, Stefan Hajnoczi wrote:
> On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:
>> From: Zhi Yong Wu
>>
>> If one guest has multiple disks with enabling I/O throttling function
>> separately, when draining activities are done, some requests maybe a
This is a reminder that QEMU will apply for Google Summer of Code 2012 and we
need project ideas and mentors. Libvirt and kvm.ko projects are also welcome!
http://wiki.qemu.org/Google_Summer_of_Code_2012
Please add yourself to the wiki now if you want to mentor a project
this summer. I will fil
Am 24.02.2012 01:36, schrieb David Gibson:
> Currently get_image_size(), used to find the size of files, returns an int.
> But for modern systems, int may be only 32-bit and we can have files
> larger than that.
>
> This patch, therefore, changes the return type of get_image_size() to off_t
> (the
On Thu, Jan 26, 2012 at 04:24:46PM +0200, Orit Wasserman wrote:
> Changes from v6:
> 1) add assert checks to ULEB encoding/decoding
> 2) no need to send last zero run
I took a quick look and I think the things I pointed out in previous
versions have been addressed. I did not review the live mig
On Mon, Feb 20, 2012 at 12:50:30PM +0800, zwu.ker...@gmail.com wrote:
> From: Zhi Yong Wu
>
> If one guest has multiple disks with enabling I/O throttling function
> separately, when draining activities are done, some requests maybe are in the
> throttled queue; So we need to restart them at fi
2012/2/24 Peter Maydell :
> This is fixed by http://patchwork.ozlabs.org/patch/142548/ (which hasn't
> been applied yet but hopefully will be soon).
>
It looks like a workaround to me as if you feed NULL to
qemu_opt_find() it will still crashing.
> --
> You received this bug notification because
Am 10.02.2012 07:27, schrieb Amos Kong:
> This allows us to use ipv4/ipv6 for migration addresses.
> Once there, it also uses /etc/services names (it came free).
>
> Signed-off-by: Juan Quintela
> Signed-off-by: Amos Kong
> ---
> migration-tcp.c | 60 ---
> net.c
This is fixed by http://patchwork.ozlabs.org/patch/142548/ (which hasn't
been applied yet but hopefully will be soon).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/939995
Title:
v1.0-1172-g235fe3b
On 02/24/2012 08:54 AM, Hu Tao wrote:
> should be req->req.tmf->lun here and elsewhere in this function?
Yes, good catch!
Paolo
On 24 February 2012 05:49, Gerhard Wiesinger wrote:
> I'm getting coredumps:
> #0 qemu_opt_find (opts=0x0, name=0x7f18e8c833db "kernel") at
> qemu-option.c:535
> 535 QTAILQ_FOREACH_REVERSE(opt, &opts->head, QemuOptHead, next) {
>
Yeah, I posted a fix for this on Tuesday:
http://patchwork
On Fri, 24 Feb 2012 11:23:30 +1100, David Gibson
wrote:
> From: Benjamin Herrenschmidt
>
> This patch fixes several endian bugs in virtfs.
>
> Cc: Aneesh Kumar K.V
>
> Signed-off-by: Benjamin Herrenschmidt
> Signed-off-by: David Gibson
> ---
> hw/9pfs/virtio-9p.c |8 +---
> 1 file
101 - 169 of 169 matches
Mail list logo
