On Fri, Feb 24, 2012 at 04:40:15PM -0600, Anthony Liguori wrote:
> On 02/24/2012 03:22 PM, Alon Levy wrote:
> >This is an across the board change since I wanted to keep the existing
> >(good imo) single graphic_console_init callback setter, instead of
> >introducing a new cb that isn't set by it bu
Hi guys,
Please don't submit these patches yet - I will re-submit from a different
email, to lessen the
legal complications.
I'm also adding a couple of new patches - just a heads up, when
transferring structs or arrays
in a syscall/ioctl, pointers also need conversions between target memory
spac
This was found by codespell.
Signed-off-by: Stefan Weil
---
test-qmp-output-visitor.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/test-qmp-output-visitor.c b/test-qmp-output-visitor.c
index c94c208..5452cd4 100644
--- a/test-qmp-output-visitor.c
+++ b/test-qmp-out
This fixes a new spelling issue which was detected by codespell.
Signed-off-by: Stefan Weil
---
include/qemu/object.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/qemu/object.h b/include/qemu/object.h
index 69e4b7b..dd7f3c0 100644
--- a/include/qemu/object.h
The 'struct' is not needed, and all other MemoryRegionOps don't use it.
Signed-off-by: Stefan Weil
---
hw/sh7750.c |2 +-
hw/sh_intc.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sh7750.c b/hw/sh7750.c
index 4f4d8e7..e712928 100644
--- a/hw/sh7750.c
+++ b/hw
spin_rw_ops is only used in hw/ppce500_spin.c.
Cc: Alexander Graf
Signed-off-by: Stefan Weil
---
hw/ppce500_spin.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ppce500_spin.c b/hw/ppce500_spin.c
index 6b8a189..6ed676b 100644
--- a/hw/ppce500_spin.c
+++ b/hw/ppce5
Please apply http://patchwork.ozlabs.org/patch/139660/ to the qemu-trivial
patch queue. Here are two additional trivial patches which also touch
MemoryRegionOps and make the code more uniform.
[PATCH 1/2] ppc: Add missing 'static' to spin_rw_ops
[PATCH 2/2] sh7750: Remove redundant 'struct' from M
l1_entry_sectors will never be less than 0.
Signed-off-by: Stefan Weil
---
block/vmdk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 5623ac1..45c003a 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -453,7 +453,7 @@ static int vmdk_op
All values read by sscanf are unsigned, so replace %d by %u.
This signed / unsigned mismatch was detected by splint.
Signed-off-by: Stefan Weil
---
cursor.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/cursor.c b/cursor.c
index efc5917..76e262c 100644
--- a/cursor.
This patch fixes warnings reported by splint:
For variables which are packed in a single bit, a signed data type
like 'int' does not make much sense.
There is no obvious reason why the two values should be packed,
so I removed the packing and changed the data type to bool
because both are used as
Static code analysers expect these comments for case statements without
a break statement.
Signed-off-by: Stefan Weil
---
audio/audio.c|3 +++
audio/esdaudio.c |2 +-
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 5fff6de..398763f 1
Without the break statement, case 5 sets month and year from the same
data. This does not look correct.
The missing break was reported by splint.
Signed-off-by: Stefan Weil
---
hw/ds1338.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ds1338.c b/hw/ds1338.c
index 6
splint reported warnings for those code statements.
Signed-off-by: Stefan Weil
---
libcacard/vscclient.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index e317a25..0adae13 100644
--- a/libcacard/vsccl
This was not a bug, but it is not common practice to omit the break statement
from the last case statement before an empty default case.
Any change of the default case would introduce a bug.
This was reported as a warning by splint.
Signed-off-by: Stefan Weil
---
ui/vnc-enc-hextile-template.h
On Sat, 25 Feb 2012, Stefan Weil wrote:
> Static code analysers expect these comments for case statements without
> a break statement.
Applied, thanks.
[..snip..]
--
mailto:av1...@comtv.ru
On 02/25/2012 06:57 AM, Stefan Weil wrote:
> This was not a bug, but it is not common practice to omit the break statement
> from the last case statement before an empty default case.
>
> Any change of the default case would introduce a bug.
>
> This was reported as a warning by splint.
>
> Sign
Am 25.02.2012 15:18, schrieb Eric Blake:
On 02/25/2012 06:57 AM, Stefan Weil wrote:
This was not a bug, but it is not common practice to omit the break statement
from the last case statement before an empty default case.
Any change of the default case would introduce a bug.
This was reported a
Hi All,
I wanted to add a summer of code idea to:
http://wiki.qemu.org/Google_Summer_of_Code_2012
But I cannot find an obvious way to create an account. So did I
miss the obvious way? Or do I need someone to do it for me?
Thanks & Regards,
Hans
Hi Aurelien,
could you please pull some Malta patches which I had sent in January?
http://patchwork.ozlabs.org/patch/138394/
http://patchwork.ozlabs.org/patch/138392/
http://patchwork.ozlabs.org/patch/138393/
http://patchwork.ozlabs.org/patch/138391/
Thanks,
Stefan
The following changes sin
On Fri, Feb 24, 2012 at 11:22:06AM -0600, Anthony Liguori wrote:
> According to git bisect and qemu-test, this breaks:
>
> qemu-system-x86_64 -kernel bin/vmlinuz-3.0 -initrd
> .tmp-26227/initramfs-26227.img.gz -append console=ttyS0 seed=1498
> -nographic -enable-kvm -device virtio-balloon-pci,id=b
Am 20.02.2012 00:45, schrieb Anthony Liguori:
Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we
don't allow arbitrary scaling based on window resizing. The current
behavior
with SDL causes a lot of problems for me.
Sometimes I accidentally resize the window a tiny bit
Hi Hans,
Am 25.02.2012 15:41, schrieb Hans de Goede:
> I wanted to add a summer of code idea to:
> http://wiki.qemu.org/Google_Summer_of_Code_2012
>
> But I cannot find an obvious way to create an account. So did I
> miss the obvious way? Or do I need someone to do it for me?
Yes, it's mentioned
Am 25.02.2012 14:57, schrieb Stefan Weil:
> This was not a bug, but it is not common practice to omit the break statement
> from the last case statement before an empty default case.
>
> Any change of the default case would introduce a bug.
>
> This was reported as a warning by splint.
>
> Signe
On 25 February 2012 13:50, Stefan Weil wrote:
> Without the break statement, case 5 sets month and year from the same
> data. This does not look correct.
Yep, looks like a simple missing break, checked against the
datasheet at http://datasheets.maxim-ic.com/en/ds/DS1338-DS1338Z.pdf
Reviewed-by:
Am 25.02.2012 16:41, schrieb Michael Roth:
> On Fri, Feb 24, 2012 at 11:22:06AM -0600, Anthony Liguori wrote:
>> According to git bisect and qemu-test, this breaks:
>>
>> qemu-system-x86_64 -kernel bin/vmlinuz-3.0 -initrd
>> .tmp-26227/initramfs-26227.img.gz -append console=ttyS0 seed=1498
>> -nogr
Am 25.02.2012 16:57, schrieb Andreas Färber:
Am 25.02.2012 14:57, schrieb Stefan Weil:
This was not a bug, but it is not common practice to omit the break
statement
from the last case statement before an empty default case.
Any change of the default case would introduce a bug.
This was report
Am 25.02.2012 17:09, schrieb Stefan Weil:
> Am 25.02.2012 16:57, schrieb Andreas Färber:
>> Am 25.02.2012 14:57, schrieb Stefan Weil:
>>> This was not a bug, but it is not common practice to omit the break
>>> statement
>>> from the last case statement before an empty default case.
>>>
>>> Any chan
Am 20.02.2012 00:45, schrieb Anthony Liguori:
This enables VteTerminal to be used to render the text consoles.
VteTerminal is
the same widget used by gnome-terminal which means it's VT100
emulation is as
good as they come.
It's also screen reader accessible, supports copy/paste, proper
scroll
Am 22.02.2012 20:48, schrieb Stefan Weil:
> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
>
> v2:
> Rebased, added new tests, tests sorted alphabetically.
>
> Signed-off-by: Stefan Weil
> ---
> tests/Makefile | 38 +++---
> 1 files chan
Am 25.02.2012 17:31, schrieb Andreas Färber:
Am 22.02.2012 20:48, schrieb Stefan Weil:
Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
v2:
Rebased, added new tests, tests sorted alphabetically.
Signed-off-by: Stefan Weil
---
tests/Makefile | 38 +++--
Am 25.02.2012 17:39, schrieb Stefan Weil:
> Am 25.02.2012 17:31, schrieb Andreas Färber:
>> Am 22.02.2012 20:48, schrieb Stefan Weil:
>>> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
>>>
>>> v2:
>>> Rebased, added new tests, tests sorted alphabetically.
>>>
>>> Signed-off-
Am 20.02.2012 00:44, schrieb Anthony Liguori:
Hi,
I realize UIs are the third rail of QEMU development, but over the
years I've
gotten a lot of feedback from users about our UI. I think everyone
struggles
with the SDL interface and its lack of discoverability but it's worse
than I
think most
This involves replacing the local APIC with the qtest interrupt controller.
It should be pretty straight forward to do the same for other machine types.
Signed-off-by: Anthony Liguori
---
hw/pc_piix.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/pc_piix.c b/hw/p
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Anthony Liguori
---
tests/libqtest.c | 12
tests/libqtest.h |6 ++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index dd07b07..1d1b06e 100644
--- a/test
Signed-off-by: Anthony Liguori
---
hw/mc146818rtc.c | 33 --
hw/mc146818rtc.h |3 +-
hw/mc146818rtc_regs.h | 62 +
3 files changed, 63 insertions(+), 35 deletions(-)
create mode 100644 hw/mc146818rtc_regs.h
Signed-off-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
v1 -> v2
- fix set_alarm_time (Paolo)
---
tests/Makefile |2 +-
tests/rtc-test.c | 267 ++
2 files changed, 268 insertions(+), 1 deletions(-)
create mode 100644 tests/rtc-
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Anthony Liguori
---
v1 -> v2
- rebased to latest (aliguori)
---
hw/irq.c | 17 ++
hw/irq.h |5 +++
hw/pc_piix.c |9 +++--
qtest.c | 97 -
qt
This will run all tests through gtester. The main targets are:
$ make check
Which will run each unit test and:
$ make check-report.html
Which will generate a nice HTML report of the test status.
Signed-off-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
v1 -> v2
- fix Makefile (Paolo)
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Anthony Liguori
---
tests/rtc-test.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/tests/rtc-test.c b/tests/rtc-test.c
index 1645b34..8280f45 100644
--- a/tests/rtc-test.c
+++ b/tests/rtc-test.c
@@ -249,
On 02/25/2012 10:21 AM, Stefan Weil wrote:
Am 20.02.2012 00:45, schrieb Anthony Liguori:
This enables VteTerminal to be used to render the text consoles. VteTerminal is
the same widget used by gnome-terminal which means it's VT100 emulation is as
good as they come.
It's also screen reader acces
Hi,
This is an updated version of the qtest patches I posted about a month ago.
I've included the RFC that Paolo posted in this series too.
On 02/25/2012 11:02 AM, Stefan Weil wrote:
Am 20.02.2012 00:44, schrieb Anthony Liguori:
Hi,
I realize UIs are the third rail of QEMU development, but over the years I've
gotten a lot of feedback from users about our UI. I think everyone struggles
with the SDL interface and its lack of discover
From: Paolo Bonzini
This patch combines qtest and -icount together to turn the vm_clock
into a source that can be fully managed by the client. To this end new
commands clock_step and clock_set are added. Hooking them with libqtest
is left as an exercise to the reader.
Signed-off-by: Paolo Bonz
This also includes a qtest wrapper script to make it easier to launch qtest
tests directly.
Signed-off-by: Anthony Liguori
---
scripts/qtest|5 +
tests/Makefile |2 +
tests/libqtest.c | 334 ++
tests/libqtest.h | 63 ++
The idea behind qtest is pretty simple. Instead of executing a CPU via TCG or
KVM, rely on an external process to send events to the device model that the CPU
would normally generate.
qtest presents itself as an accelerator. In addition, a new option is added to
establish a qtest server (-qtest)
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
> This involves replacing the local APIC with the qtest interrupt controller.
>
> It should be pretty straight forward to do the same for other machine types.
>
> Signed-off-by: Anthony Liguori
> ---
> hw/pc_piix.c |3 +++
> 1 files changed, 3
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
> +
> +qemu_irq *qtest_interrupt_controller_init(void)
> +{
> +return qemu_allocate_irqs(qtest_set_irq, NULL, MAX_IRQ);
> +}
This should not be needed anymore.
Paolo
Am 25.02.2012 20:49, schrieb Anthony Liguori:
On 02/25/2012 10:21 AM, Stefan Weil wrote:
Am 20.02.2012 00:45, schrieb Anthony Liguori:
This enables VteTerminal to be used to render the text consoles.
VteTerminal is
the same widget used by gnome-terminal which means it's VT100
emulation is as
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
> @@ -224,7 +223,9 @@ static void pc_init1(MemoryRegion *system_memory,
> gsi_state->i8259_irq[i] = i8259[i];
> }
> if (pci_enabled) {
> -ioapic_init(gsi_state);
> +dev = ioapic_init(gsi_state);
> +object_prop
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
> Signed-off-by: Anthony Liguori
> Signed-off-by: Paolo Bonzini
> ---
> v1 -> v2
> - fix set_alarm_time (Paolo)
> ---
> tests/Makefile |2 +-
> tests/rtc-test.c | 267
> ++
> 2 files chang
On 02/25/2012 05:08 PM, Andreas Färber wrote:
> Paolo did provide separate object_property_set_[u]int* accessors so we
> should be good in QOM land when not fiddling with these things at such a
> "deep" level.
There is only object_property_set_int right now, but it'd be great to
add the others.
P
Am 25.02.2012 20:42, schrieb Anthony Liguori:
Signed-off-by: Anthony Liguori
Signed-off-by: Paolo Bonzini
---
v1 -> v2
- fix set_alarm_time (Paolo)
---
tests/Makefile | 2 +-
tests/rtc-test.c | 267
++
2 files changed, 268 insertions(+), 1 del
On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
This involves replacing the local APIC with the qtest interrupt controller.
It should be pretty straight forward to do the same for other machine types.
Signed-off-by: Anthony Liguori
---
hw/pc_piix.c
Am 25.02.2012 21:11, schrieb Anthony Liguori:
On 02/25/2012 11:02 AM, Stefan Weil wrote:
Am 20.02.2012 00:44, schrieb Anthony Liguori:
Hi,
I realize UIs are the third rail of QEMU development, but over the
years I've
gotten a lot of feedback from users about our UI. I think everyone
struggle
On 02/25/2012 02:20 PM, Paolo Bonzini wrote:
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
@@ -224,7 +223,9 @@ static void pc_init1(MemoryRegion *system_memory,
gsi_state->i8259_irq[i] = i8259[i];
}
if (pci_enabled) {
-ioapic_init(gsi_state);
+dev = ioapic_
On 02/25/2012 02:22 PM, Stefan Weil wrote:
Am 25.02.2012 20:49, schrieb Anthony Liguori:
On 02/25/2012 10:21 AM, Stefan Weil wrote:
Am 20.02.2012 00:45, schrieb Anthony Liguori:
This enables VteTerminal to be used to render the text consoles. VteTerminal is
the same widget used by gnome-termin
Am 25.02.2012 22:12, schrieb Anthony Liguori:
> On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
>> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
>>> This involves replacing the local APIC with the qtest interrupt
>>> controller.
>>>
>>> It should be pretty straight forward to do the same for other ma
On 02/25/2012 03:21 PM, Andreas Färber wrote:
Am 25.02.2012 22:12, schrieb Anthony Liguori:
On 02/25/2012 02:19 PM, Paolo Bonzini wrote:
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
This involves replacing the local APIC with the qtest interrupt
controller.
It should be pretty straight forw
On 02/25/2012 10:12 PM, Anthony Liguori wrote:
>
> Why? This is necessary for IRQ to work.
Actually it's reverted later on in the series, so if you want to commit
it as is the end result is surely fine by me. :)
Paolo
Am 25.02.2012 22:15, schrieb Stefan Weil:
Am 25.02.2012 21:11, schrieb Anthony Liguori:
On 02/25/2012 11:02 AM, Stefan Weil wrote:
Am 20.02.2012 00:44, schrieb Anthony Liguori:
Hi,
I realize UIs are the third rail of QEMU development, but over the
years I've
gotten a lot of feedback from use
This function allows to obtain a singly-linked list of classes, which
can be sorted by the caller.
Signed-off-by: Andreas Färber
Cc: Anthony Liguori
---
v1 -> v2:
* Instead of object_class_foreach() using a GCompareFunc with a GTree
internally,
return a GSList so that the caller can sort h
Am 25.02.2012 23:07, schrieb Andreas Färber:
> This function allows to obtain a singly-linked list of classes, which
> can be sorted by the caller.
>
> Signed-off-by: Andreas Färber
> Cc: Anthony Liguori
> ---
> v1 -> v2:
> * Instead of object_class_foreach() using a GCompareFunc with a GTree
I can confirm this Bug with qemu 1.0 using a Windows7 or Windows 2003 virtual
machine.
After connecting 1-10 times the agent stops working.
Sometimes it helps to restart the VD Service within the vm.
Qemu Log shows:
dispatch_vdi_port_data: invalid port
--
You received this bug notification beca
Am 25.02.2012 13:37, schrieb Stefan Weil:
> spin_rw_ops is only used in hw/ppce500_spin.c.
>
> Cc: Alexander Graf
> Signed-off-by: Stefan Weil
Acked-by: Andreas Färber
/-F
> ---
> hw/ppce500_spin.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ppce500_sp
The Buildbot has detected a new failure on builder default_x86_64_rhel5 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel5/builds/173
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_rhel5
Buil
Am 25.02.2012 22:16, schrieb Anthony Liguori:
> On 02/25/2012 02:20 PM, Paolo Bonzini wrote:
>> On 02/25/2012 08:42 PM, Anthony Liguori wrote:
>>> +
>>> object_property_add_child(object_resolve_path("/i440fx/piix3", NULL),
>>> + "ioapic", OBJECT(dev), NULL);
On 02/25/2012 07:31 PM, Andreas Färber wrote:
Am 25.02.2012 22:16, schrieb Anthony Liguori:
On 02/25/2012 02:20 PM, Paolo Bonzini wrote:
On 02/25/2012 08:42 PM, Anthony Liguori wrote:
+
object_property_add_child(object_resolve_path("/i440fx/piix3", NULL),
+ "io
67 matches
Mail list logo
