Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Tue, Mar 06, 2012 at 08:36:34AM +0100, Gerd Hoffmann wrote: > Hi, > > >> How would the parallel execution facility be opaque to the implementer? > >> screendump returns, screendump_async needs to pass a closure. You can > >> automatically generate any amount of code, but you can only have a >

Re: [Qemu-devel] [PATCH] Add the drive-reopen command

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 20:36, Federico Simoncelli ha scritto: > Signed-off-by: Federico Simoncelli > --- > blockdev.c | 40 +++- > hmp-commands.hx | 16 > hmp.c| 11 +++ > hmp.h|1 + > qapi-schema.json |

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-05 Thread Liu, Jinsong
Jan, Any comments? I feel some confused about your point 'disable cpuid feature for older machine types by default': are you planning a common approach for this common issue, or, you just ask me a specific solution for the tsc deadline timer case? Thanks, Jinsong Liu, Jinsong wrote: >> My po

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Tue, Mar 06, 2012 at 08:36:34AM +0100, Gerd Hoffmann wrote: > Hi, > > >> How would the parallel execution facility be opaque to the implementer? > >> screendump returns, screendump_async needs to pass a closure. You can > >> automatically generate any amount of code, but you can only have a >

Re: [Qemu-devel] [PATCH v2 0/4] slirp: Fix for requeuing crash, cleanups

2012-03-05 Thread Jan Kiszka
On 2012-03-05 10:06, Jan Kiszka wrote: > Grmbl. Was very hard to reproduce here (triggered once every few hours > with lots of interaction beforehand), but now I think I got the point > (recursion of if_start due to if_encap). Will rework the code to address > this. > > Thanks for testing so far,

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Gerd Hoffmann
Hi, >> How would the parallel execution facility be opaque to the implementer? >> screendump returns, screendump_async needs to pass a closure. You can >> automatically generate any amount of code, but you can only have a >> single function implementation with longjmp/coroutine, or having a >> s

[Qemu-devel] [PATCH] qxl-render: call ppm_save on bh

2012-03-05 Thread Alon Levy
Uses the newly introduced hw_screen_dump_async. Now that the deadlock with virt-manager is fixed we need to call ppm_save in a bh, with the new command we can notify virt-manager using the SCREEN_DUMP_COMPLETE event. Signed-off-by: Alon Levy --- This needs to go on top of [PATCH v3 0/3] screendum

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 1/6] output: add 64bit hex print support

2012-03-05 Thread Gerd Hoffmann
On 03/05/12 16:23, Kevin O'Connor wrote: > On Wed, Feb 29, 2012 at 12:45:05PM +0100, Gerd Hoffmann wrote: >> --- >> src/output.c | 23 +-- >> 1 files changed, 21 insertions(+), 2 deletions(-) > > Thanks Gerd. > > I think your patch missed a couple of corner cases. I played

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/7] pseries: Configure PCI bridge using properties

2012-03-05 Thread David Gibson
On Sat, Mar 03, 2012 at 07:42:09PM +0100, Andreas Färber wrote: > Am 28.02.2012 04:18, schrieb David Gibson: > > From: Alexey Kardashevskiy [snip] > > -QLIST_INSERT_HEAD(&spapr->phbs, phb, list); > > +type_init(spapr_register_pci_type) > > Please respect the recently enforced convention of na

Re: [Qemu-devel] [SeaBIOS] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Alexey Korolev
On 06/03/12 02:49, Kevin O'Connor wrote: > On Mon, Mar 05, 2012 at 10:53:25AM +0100, Gerd Hoffmann wrote: >>> Given the churn in this area, I don't want to commit patches that do >>> wholesale code replacement. I'd prefer to see each patch >>> independently add some functionality and perform its r

Re: [Qemu-devel] [PATCH] KVM: expose Intel cpu new features to guest

2012-03-05 Thread Liu, Jinsong
Avi, Any comments? Thanks, Jinsong Liu, Jinsong wrote: > From ecd8be962f69393c183f941bfdbd7a7d3876d442 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Mon, 27 Feb 2012 05:19:32 +0800 > Subject: [PATCH] KVM: expose Intel cpu new features to guest > > Intel recently release 2 new features,

Re: [Qemu-devel] [SeaBIOS] [Seabios] [PATCH 0/6] 64bit PCI BARs allocations (take 2)

2012-03-05 Thread Alexey Korolev
On 05/03/12 23:12, Gerd Hoffmann wrote: > Hi, > >> I can either send a patch over existing patches, or send new series or both. > For testing a incremental patch is fine, for merge a new series with the > fixes squashed into the buggy patches is needed. > > cheers, > Gerd Sure. Here are the hot

Re: [Qemu-devel] RFC: rtl8139 improvements

2012-03-05 Thread Jason Wang
On 03/05/2012 02:48 PM, Gerhard Wiesinger wrote: Hello, I'm trying to implement better emulation and wider OS support for the rtl8139 card. Therefore I want to see the following testcases to be successful: * Testcases and successful regression tests: * 1.) DOS RSET8139.EXE: EEPROM Test suc

[Qemu-devel] bringing up virtio network device hangs guest

2012-03-05 Thread Stuart Yoder
I'm trying to solve a problem where bringing up a virtio network device in a KVM guest hangs the guest. Start QEMU with these options: -net nic,model=virtio -net tap,script=/root/qemu-ifup The qemu-ifup script is pretty simple, just adds the interface passed in to a bridge: #!/bin/sh bridg

Re: [Qemu-devel] Qemu disaggregation in Xen environment

2012-03-05 Thread Anthony Liguori
On 03/05/2012 04:53 PM, Stefano Stabellini wrote: On Mon, 5 Mar 2012, Anthony Liguori wrote: On 02/28/2012 05:46 AM, Julien Grall wrote: Hello, In the current model, only one instance of qemu is running for each running HVM domain. We are looking at disaggregating qemu to have, for example, a

Re: [Qemu-devel] [RFC][PATCH 00/16 v8] introducing a new, dedicated memory dump mechanism

2012-03-05 Thread Luiz Capitulino
On Mon, 05 Mar 2012 17:12:00 +0800 Wen Congyang wrote: > At 03/02/2012 05:59 PM, Wen Congyang Wrote: > > Hi, all > > > > 'virsh dump' can not work when host pci device is used by guest. We have > > discussed this issue here: > > http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.ht

Re: [Qemu-devel] Qemu disaggregation in Xen environment

2012-03-05 Thread Stefano Stabellini
On Mon, 5 Mar 2012, Anthony Liguori wrote: > On 02/28/2012 05:46 AM, Julien Grall wrote: > > Hello, > > > > In the current model, only one instance of qemu is running for each running > > HVM > > domain. > > > > We are looking at disaggregating qemu to have, for example, an instance to > > emulate

Re: [Qemu-devel] [PATCH v1 0/5] Microblaze machine models and bootloader refactoring

2012-03-05 Thread Edgar E. Iglesias
On Sun, Mar 04, 2012 at 09:03:50PM +1000, Peter A. G. Crosthwaite wrote: > From: "Peter A. G. Crosthwaite" > > Overhauled the microblaze bootloader process. Factored out the common boot > code between petalogix_ml605 and petalogix_s3adsp1800 machine models into a > dedicated microblaze bootload

Re: [Qemu-devel] Qemu disaggregation in Xen environment

2012-03-05 Thread Anthony Liguori
On 02/28/2012 05:46 AM, Julien Grall wrote: Hello, In the current model, only one instance of qemu is running for each running HVM domain. We are looking at disaggregating qemu to have, for example, an instance to emulate only network controllers, another to emulate block devices, etc... Why

Re: [Qemu-devel] [Xen-devel] Qemu disaggregation in Xen environment

2012-03-05 Thread Ian Campbell
On Tue, 2012-02-28 at 06:46 -0500, Julien Grall wrote: > Hello, > > In the current model, only one instance of qemu is running for each running > HVM domain. > > We are looking at disaggregating qemu to have, for example, an instance to > emulate only > network controllers, another to emulate b

Re: [Qemu-devel] [RFC] fix crashes with vmware driver

2012-03-05 Thread Serge E. Hallyn
Thanks. As there's been no substantial feedback, I'll resend with those changes. -serge Quoting Ryan Harper (ry...@us.ibm.com): > * Serge Hallyn [2012-03-02 15:13]: > > Hi, > > > > I don't know where the best place to catch this would be, but > > with vnc and vmware_vga it's possible to get se

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 20:44, Paolo Bonzini ha scritto: > Il 05/03/2012 19:55, Eric Blake ha scritto: >> Right now, libvirt has an API virDomainSnapshotCreateXML with a flag >> VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode >> operand. Am I guaranteed that if I pass a 'mode' argume

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread malc
On Mon, 5 Mar 2012, Blue Swirl wrote: > On Mon, Mar 5, 2012 at 15:17, Avi Kivity wrote: > > On 03/05/2012 05:15 PM, Anthony Liguori wrote: > >>> The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory > >>> API.  I think 32-on-32 is quite rare these days, so it wouldn't be much >

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Meador Inge
On 03/05/2012 01:53 PM, Andreas Färber wrote: > Am 05.03.2012 18:06, schrieb Meador Inge: >> On 02/23/2012 07:44 AM, Meador Inge wrote: >> >>> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the >>> opcode table creation code to erroneously register 'eieio' and 'mbar' >>> for th

[Qemu-devel] [PATCH] cache-utils: Add missing include file for uintptr_t

2012-03-05 Thread Stefan Weil
Commit 021ecd8b9db37927059f5d3234b51ed766706437 breaks the build for PPC hosts because it uses uintptr_t without the necessary include file. uintptr_t is defined in stdint.h, so add this include. Cc: Alexander Graf Signed-off-by: Stefan Weil --- Hi Alex, could you please test whether my patch

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Alexander Graf
On 05.03.2012, at 21:07, Stefan Weil wrote: > Am 05.03.2012 19:57, schrieb Alexander Graf: >> On 03/02/2012 11:30 PM, Stefan Weil wrote: >>> The TCG targets i386 and tci needed a change of the function >>> prototype for w64. >>> >>> This change is currently not needed here, but it can be appli

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Stefan Weil
Am 05.03.2012 19:57, schrieb Alexander Graf: On 03/02/2012 11:30 PM, Stefan Weil wrote: The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by: S

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Andreas Färber
Am 05.03.2012 18:06, schrieb Meador Inge: > On 02/23/2012 07:44 AM, Meador Inge wrote: > >> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the >> opcode table creation code to erroneously register 'eieio' and 'mbar' >> for the "default" processor: >> >>** ERROR: opcode 1a a

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 5 Mar 2012 20:58:08 +0200 Alon Levy wrote: > On Mon, Mar 05, 2012 at 08:17:52PM +0200, Avi Kivity wrote: > > On 03/05/2012 08:09 PM, Alon Levy wrote: > > > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > > > On Mon, 05 Mar 2012 11:27:07 -0600 > > > > Anthony Liguori

[Qemu-devel] [PATCH v3 4/7] qapi: add String visitor coverage to serialization unit tests

2012-03-05 Thread Michael Roth
Signed-off-by: Michael Roth --- test-visitor-serialization.c | 40 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/test-visitor-serialization.c b/test-visitor-serialization.c index 6ef57d0..b8ad16f 100644 --- a/test-visitor-serialization

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 19:55, Eric Blake ha scritto: > Right now, libvirt has an API virDomainSnapshotCreateXML with a flag > VIR_DOMAIN_SNAPSHOT_CREATE_REUSE_EXT, which should map to this new mode > operand. Am I guaranteed that if I pass a 'mode' argument of 'existing' > to an older qemu that lacked mode

Re: [Qemu-devel] [PATCH] [s390] Move helpers.h to helper.h

2012-03-05 Thread Alexander Graf
On 02/13/2012 04:33 PM, Lluís Vilanova wrote: Provides a file naming scheme consistent with other targets. Thanks, applied to s390-next. Alex

[Qemu-devel] [PATCH v3 1/7] qapi: add Visitor interfaces for uint*_t and int*_t

2012-03-05 Thread Michael Roth
This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid integer overflows for cases where the value fetched exceeds the bounds of our target C type. S

[Qemu-devel] [PATCH] Add the drive-reopen command

2012-03-05 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli --- blockdev.c | 40 +++- hmp-commands.hx | 16 hmp.c| 11 +++ hmp.h|1 + qapi-schema.json | 22 ++ 5 files changed, 77 insertions(+), 13

[Qemu-devel] [PATCH v3 2/7] qapi: unit tests for visitor-based serialization

2012-03-05 Thread Michael Roth
Currently we test our visitors individually, and seperately for input vs. output. This is useful for validating internal representations against the native C types and vice-versa, and other visitor-specific testing, but it doesn't cover the potential use-case of using visitor pairs for serializatio

[Qemu-devel] [PATCH 1/1] vmware_vga: stop crashing

2012-03-05 Thread Serge Hallyn
if x or y < 0, set them to 0 (and decrement width/height accordingly)> I don't know where the best place to catch this would be, but with vnc and vmware_vga it's possible to get set_bit called on a negative index, crashing qemu. See https://bugs.launchpad.net/ubuntu/+source/qemu-kvm/+bug/918791

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 12:22 PM, Avi Kivity wrote: On 03/05/2012 08:16 PM, Anthony Liguori wrote: We're pretty close to being there. Luiz, about how long do you think before we get there? It's a pity to add new commands along the way. It's more complicated than this unfortunately. A client

[Qemu-devel] [PATCH v3 7/7] qdev: switch property accessors to fixed-width visitor interfaces

2012-03-05 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/qdev-addr.c |4 +- hw/qdev-properties.c | 140 ++ 2 files changed, 87 insertions(+), 57 deletions(-) diff --git a/hw/qdev-addr.c b/hw/qdev-addr.c index 0bb16c7..b711b6b 100644 --- a/hw/qdev-addr.c +++

[Qemu-devel] [PATCH v3 5/7] qapi: String visitor, use %f represenation for floats

2012-03-05 Thread Michael Roth
Currently string-output-visitor formats floats as %g, which is nice in that trailing 0's are automatically truncated, but otherwise this causes some issues: - it 6 uses significant figures instead of 6 decimal places, which means something like 155777.5 (which even has an exact floating point

Re: [Qemu-devel] PPC: VGA broken in git master

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 04:16:54PM +, Mark Cave-Ayland wrote: > On 05/03/12 15:48, Avi Kivity wrote: > > >>>Can you provide the command line needed to reproduce the problem? > >> > >>Sure. I can reproduce it here using something as simple as: > >> > >>./qemu-system-ppc -cdrom /dev/null -boot d

[Qemu-devel] [PATCH 1/2] s390: Rework kernel loading: supports elf and newer kernels

2012-03-05 Thread Alexander Graf
From: Christian Borntraeger This reworks the image loading on s390. Newer kernels will not always have a 0dd0 (basr 13,0) at address 0x1. We must not rely on specific code at certain addresses. This check was introduced to warn users that tried to load vmlinux, since ELF loading was not sup

[Qemu-devel] [PULL 0/2] s390 patch queue 2012-03-05

2012-03-05 Thread Alexander Graf
Hi Aurelien / Blue, This is my current patch queue for s390. Please pull. Alex The following changes since commit 2aeabc08179553e1a7eed6cf26286c3efc06ee0b: Stefan Weil (1): w64: fix type casts when calling flush_icache_range are available in the git repository at: git://repo.or.cz

[Qemu-devel] [PATCH 2/2] Move helpers.h to helper.h

2012-03-05 Thread Alexander Graf
From: Lluís Vilanova Provides a file naming scheme consistent with other targets. Signed-off-by: Lluís Vilanova Signed-off-by: Alexander Graf --- target-s390x/{helpers.h => helper.h} |0 target-s390x/op_helper.c |2 +- target-s390x/translate.c |4 ++-- 3 fi

[Qemu-devel] [PATCH v3 6/7] qdev: use int32_t container for devfn property

2012-03-05 Thread Michael Roth
Valid range for devfn is -1 to 255 (-1 for automatic assignment). We do not currently validate this due to devfn being stored as a uint32_t. This can lead to segfaults and other strange behavior. We could technically just cast it to int32_t to implement the checking, but this will not work for vis

[Qemu-devel] [PATCH v3 3/7] qapi: QMP input visitor, handle floats parsed as ints

2012-03-05 Thread Michael Roth
JSON numbers can be interpreted as either integers or floating point values depending on their representation. As a result, QMP input visitor might visit a QInt when it was expecting a QFloat, so add handling to account for this. Signed-off-by: Michael Roth --- qapi/qmp-input-visitor.c |9 ++

[Qemu-devel] [PATCH v3 0/7] add fixed-width visitors and serialization tests

2012-03-05 Thread Michael Roth
These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git visitor-fixed-width-v3 CHANGES SINCE V2: - Fix qemu-test errors due to now-strict bounds-checking we doing assignment between signed/unsigned types. - uint* property getters/setters

[Qemu-devel] [PATCH 2/7] vdi: move end-of-I/O handling at the end

2012-03-05 Thread Paolo Bonzini
The next step is to take code that only triggers after the first operation, and move it at the end of vdi_aio_read_cb and vdi_aio_write_cb. Signed-off-by: Paolo Bonzini --- block/vdi.c | 123 +++ 1 files changed, 56 insertions(+), 67 delet

Re: [Qemu-devel] [PATCH] Userspace ARM BE8 support

2012-03-05 Thread Peter Maydell
On 29 February 2012 15:40, Paul Brook wrote: > Add support for ARM BE8 userspace binaries. > i.e. big-endian data and little-endian code. > In principle LE8 mode is also possible, but AFAIK has never actually > been implemented/used. There seems to have been an LE8 flag in the ARM ELF spec at one

Re: [Qemu-devel] [PATCH v3 7/8] add mirroring to transaction

2012-03-05 Thread Eric Blake
On 03/05/2012 10:34 AM, Paolo Bonzini wrote: > With it comes a new image creation mode, "no-backing-file", that can > be used to stream an image so that the destination does not need the > original image's backing file(s). > > Both bdrv_append and blkmirror will set the backing_hd on the target, >

[Qemu-devel] Fwd: Question on qemu-kvm 1.0

2012-03-05 Thread Al Patel
-- Forwarded message -- From: Al Patel Date: Mon, Mar 5, 2012 at 11:19 AM Subject: Re: Question on qemu-kvm 1.0 To: k...@vger.kernel.org, m...@redhat.com Side note: I am not using vhost-net yet. I am reading from the blogs that vhost-net gives much better performance. I am puttin

[Qemu-devel] Fwd: Question on qemu-kvm 1.0

2012-03-05 Thread Al Patel
-- Forwarded message -- From: Al Patel Date: Mon, Mar 5, 2012 at 11:17 AM Subject: Question on qemu-kvm 1.0 To: k...@vger.kernel.org, m...@redhat.com Hi , We have been using qemu/kvm 0.12.5 (unchanged with stock kernel 2.6.32). I just upgraded to qemu/kvm-1.0 and see noticable

[Qemu-devel] [PATCH 1/7] vdi: basic conversion to coroutines

2012-03-05 Thread Paolo Bonzini
Even a basic conversion changing the bdrv_aio_readv/bdrv_aio_writev calls to bdrv_co_readv/bdrv_co_writev, and callbacks to goto statements can eliminate a lot of code. This is because error handling is simplified and indirections through bottom halves can go away. After this patch, I/O to the un

Re: [Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Eric Blake
On 03/05/2012 10:33 AM, Paolo Bonzini wrote: > Simplify the blockdev-snapshot-sync code and gain failsafe operation > by turning it into a wrapper around the new transaction command. A new > option is also added matching "mode". > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 81 +

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 08:17:52PM +0200, Avi Kivity wrote: > On 03/05/2012 08:09 PM, Alon Levy wrote: > > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > > On Mon, 05 Mar 2012 11:27:07 -0600 > > > Anthony Liguori wrote: > > > > > > > On 03/05/2012 11:20 AM, Avi Kivity wrote:

Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range

2012-03-05 Thread Alexander Graf
On 03/02/2012 11:30 PM, Stefan Weil wrote: The TCG targets i386 and tci needed a change of the function prototype for w64. This change is currently not needed here, but it can be applied to avoid code differences. Cc: Alexander Graf Signed-off-by: Stefan Weil --- cache-utils.h |2 +- 1 f

Re: [Qemu-devel] [PULL 0/2] s390 patch queue 2012-03-05

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 18:51, Alexander Graf wrote: > Hi Aurelien / Blue, > > This is my current patch queue for s390. Please pull. Thanks, pulled. > Alex > > > The following changes since commit 2aeabc08179553e1a7eed6cf26286c3efc06ee0b: >  Stefan Weil (1): >        w64: fix type casts when call

Re: [Qemu-devel] [PATCH 0/2] Unbreak aliases of I/O regions (and -vga std)

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 15:51, Avi Kivity wrote: > Aliases to memory regions in the I/O address space are broken; this affects > -vga std.  These two patches fix the problem. > > Also available in > >  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent Thanks, pulled. > Avi Kivity (

[Qemu-devel] [PATCH 7/7] vdi: change goto to loop

2012-03-05 Thread Paolo Bonzini
Finally reindent all code and change goto statements to a loop. Signed-off-by: Paolo Bonzini --- block/vdi.c | 141 -- 1 files changed, 68 insertions(+), 73 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index c192c7e..41ec137 100644

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Blue Swirl
On Mon, Mar 5, 2012 at 15:17, Avi Kivity wrote: > On 03/05/2012 05:15 PM, Anthony Liguori wrote: >>> The other alternative is to s/target_phys_addr_t/uint64_t/ in the memory >>> API.  I think 32-on-32 is quite rare these days, so it wouldn't be much >>> of a performance issue. >> >> >> I think thi

[Qemu-devel] [PATCH] block: handle -EBUSY in bdrv_commit_all()

2012-03-05 Thread Stefan Hajnoczi
Monitor operations that manipulate image files must not execute while a background job (like image streaming) is in progress. This prevents corruptions from happening when two pieces of code are manipulating the image file without knowledge of each other. The monitor "commit" command raises QERR_

Re: [Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item

2012-03-05 Thread Eric Blake
On 03/05/2012 10:33 AM, Paolo Bonzini wrote: > The mode field lets a management application create the snapshot > destination outside QEMU. > > Right now, the only modes are "existing" and "absolute-paths". Mirroring > introduces "no-backing-file". In the future "relative-paths" could be > imple

[Qemu-devel] [PATCH v3 6/8] Add blkmirror block driver

2012-03-05 Thread Paolo Bonzini
From: Marcelo Tosatti Mirrored writes are used by live block copy. Signed-off-by: Marcelo Tosatti Signed-off-by: Federico Simoncelli Signed-off-by: Paolo Bonzini --- Makefile.objs |2 +- block/blkmirror.c | 239 + 2 files changed,

[Qemu-devel] [PATCH v3 5/8] qmp: convert blockdev-snapshot-sync to a wrapper around transactions

2012-03-05 Thread Paolo Bonzini
Simplify the blockdev-snapshot-sync code and gain failsafe operation by turning it into a wrapper around the new transaction command. A new option is also added matching "mode". Signed-off-by: Paolo Bonzini --- blockdev.c | 81 - hmp-c

[Qemu-devel] [PATCH 4/7] vdi: move aiocb fields to locals

2012-03-05 Thread Paolo Bonzini
Most of the AIOCB really holds local variables that need to persist across callback invocation. It can go away now. Signed-off-by: Paolo Bonzini --- block/vdi.c | 162 -- 2 files changed, 65 insertions(+), 101 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH] pci: fix bridge IO/BASE

2012-03-05 Thread Blue Swirl
On Sun, Mar 4, 2012 at 22:29, Michael S. Tsirkin wrote: > On Sun, Mar 04, 2012 at 09:54:02PM +, Blue Swirl wrote: >> >> 19.3.1.10 tells that the header type is 0, as you noted too. Still, >> >> the register layout matches bridge spec instead, for example there are >> >> bus number registers in

[Qemu-devel] [PATCH 6/7] vdi: do not create useless iovecs

2012-03-05 Thread Paolo Bonzini
Reads and writes to the underlying file can also occur with the simple non-vectored I/O interfaces. Signed-off-by: Paolo Bonzini --- block/vdi.c | 79 -- 1 files changed, 33 insertions(+), 46 deletions(-) diff --git a/block/vdi.c b/block

[Qemu-devel] [PATCH v3 2/8] qapi: complete implementation of unions

2012-03-05 Thread Paolo Bonzini
Reviewed-by: Luiz Capitulino Signed-off-by: Paolo Bonzini --- qapi-schema-test.json | 10 ++ scripts/qapi-types.py |5 + scripts/qapi-visit.py | 31 ++- test-qmp-input-visitor.c | 18 ++ test-qmp-output-visitor.c |

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 08:16 PM, Anthony Liguori wrote: > >> >>>We're pretty close to being there. Luiz, about how long do you >>> think before we get there? >> >> It's a pity to add new commands along the way. > > It's more complicated than this unfortunately. > > A client needs to be able to determin

[Qemu-devel] [PATCH v3 1/8] fix format name for backing file

2012-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- blockdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/blockdev.c b/blockdev.c index d78aa51..96a893b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -800,7 +800,8 @@ void qmp_blockdev_group_snapshot_sync(SnapshotDevList *dev_list,

[Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines

2012-03-05 Thread Paolo Bonzini
Conversion to coroutines simplifies the code and removes the need to duplicate common features of the block layer. Each step in the conversion is detailed in the corresponding commit message. Tested with qemu-iotests. Paolo Bonzini (7): vdi: basic conversion to coroutines vdi: move end-of-I/

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 08:09 PM, Alon Levy wrote: > On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > > On Mon, 05 Mar 2012 11:27:07 -0600 > > Anthony Liguori wrote: > > > > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > > >> > > > >

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 11:29 AM, Avi Kivity wrote: On 03/05/2012 07:27 PM, Anthony Liguori wrote: On 03/05/2012 11:20 AM, Avi Kivity wrote: On 03/05/2012 04:33 PM, Anthony Liguori wrote: async in QEMU doesn't mean "generate a QMP event when you're done". It should mean execute this closure when you f

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 02:31:42PM -0300, Luiz Capitulino wrote: > On Mon, 05 Mar 2012 11:27:07 -0600 > Anthony Liguori wrote: > > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > >> > > >> > > >> async in QEMU doesn't mean "generate a QMP event

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Paolo Bonzini
Il 05/03/2012 18:44, Marcelo Tosatti ha scritto: > OK, can't it be fixed by image streaming on top of a blkmirror device? > This would avoid a duplicate interface (such as no need to snapshot_blkdev > to change to final copy). > > That is, start image streaming to a blkmirror device so that updat

Re: [Qemu-devel] [PATCH] spice: set spice uuid and name

2012-03-05 Thread Alon Levy
On Mon, Mar 05, 2012 at 06:22:26PM +0100, Marc-André Lureau wrote: > This allows a Spice client to identify a VM Reviewed-by: Alon Levy > --- > ui/spice-core.c |6 ++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/ui/spice-core.c b/ui/spice-core.c > index c1091e1..

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 05 Mar 2012 19:29:14 +0200 Avi Kivity wrote: > On 03/05/2012 07:27 PM, Anthony Liguori wrote: > > On 03/05/2012 11:20 AM, Avi Kivity wrote: > >> On 03/05/2012 04:33 PM, Anthony Liguori wrote: > >>> > >>> > >>> async in QEMU doesn't mean "generate a QMP event when you're done". > >>> It sh

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Jan Kiszka
On 2012-03-05 18:39, Avi Kivity wrote: > On 03/05/2012 04:30 PM, Jan Kiszka wrote: >> On 2012-03-05 15:24, Avi Kivity wrote: Long-term, I'd like to cut out certain file descriptors from the main loop and process them completely in separate threads (for separate locking, prioritizatio

[Qemu-devel] [PATCH 3/7] vdi: merge aio_read_cb and aio_write_cb into callers

2012-03-05 Thread Paolo Bonzini
Now inline the former AIO callbacks into vdi_co_readv and vdi_co_writev. While many cleanups are possible, the code now really looks synchronous. Signed-off-by: Paolo Bonzini --- block/vdi.c | 40 1 files changed, 12 insertions(+), 28 deletions(-) diff

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Marcelo Tosatti
On Mon, Mar 05, 2012 at 10:20:36AM -0700, Eric Blake wrote: > On 03/05/2012 09:59 AM, Marcelo Tosatti wrote: > > On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: > >> Hi, > >> recently I've been working on live block migration combining the live > >> snapshots and the blkmirror

[Qemu-devel] [PATCH v3 3/8] rename blockdev-group-snapshot-sync

2012-03-05 Thread Paolo Bonzini
We will add other kinds of operation. Prepare for this by adjusting the schema. Signed-off-by: Paolo Bonzini --- blockdev.c | 78 - qapi-schema.json | 42 ++-- qmp-commands.hx | 52 +++--

[Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer

2012-03-05 Thread Paolo Bonzini
vdi.c really works as if it implemented bdrv_read and bdrv_write. However, because only vector I/O is supported by the asynchronous callbacks, it went through extra pain to bounce-buffer the I/O. With the conversion to coroutines bdrv_read and bdrv_write are now asynchronous, so they can be handled

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:30 PM, Jan Kiszka wrote: > On 2012-03-05 15:24, Avi Kivity wrote: > >> Long-term, I'd like to cut out certain file descriptors from the main > >> loop and process them completely in separate threads (for separate > >> locking, prioritization etc.). Dunno how NBD works, but maybe it

Re: [Qemu-devel] [RFC PATCH] fix select(2) race between main_loop_wait and qemu_aio_wait

2012-03-05 Thread Avi Kivity
On 03/05/2012 06:14 PM, Paolo Bonzini wrote: > Il 05/03/2012 16:14, Avi Kivity ha scritto: > >> > Hmm, I don't think so. It would need to protect execution of the > >> > iohandlers too, and pretty much everything can happen there including a > >> > nested loop. Of course recursive mutexes exist,

[Qemu-devel] [PATCH v3 8/8] add drive-mirror command and HMP equivalent

2012-03-05 Thread Paolo Bonzini
Since QMP transactions are supposed to take (pseudo) QMP commands, add a standalone drive-mirror command. The corresponding HMP command does not provide atomic snapshot+mirror, but it can still be used together with image streaming. Signed-off-by: Paolo Bonzini --- blockdev.c | 24 +

[Qemu-devel] [PATCH v3 4/8] add mode field to blockdev-snapshot-sync transaction item

2012-03-05 Thread Paolo Bonzini
The mode field lets a management application create the snapshot destination outside QEMU. Right now, the only modes are "existing" and "absolute-paths". Mirroring introduces "no-backing-file". In the future "relative-paths" could be implemented too. Signed-off-by: Paolo Bonzini --- blockdev.

[Qemu-devel] [PATCH v3 7/8] add mirroring to transaction

2012-03-05 Thread Paolo Bonzini
With it comes a new image creation mode, "no-backing-file", that can be used to stream an image so that the destination does not need the original image's backing file(s). Both bdrv_append and blkmirror will set the backing_hd on the target, even if the image is created without one, so that both s

[Qemu-devel] [PATCH v3 0/8] Mirrored block writes

2012-03-05 Thread Paolo Bonzini
v3 comes with a new QMP command drive-mirror, an improved blockdev-snapshot-sync that just reuses transaction functionality, and a new image creation mode enum. I also tested that the command can be used to migrate without shared storage. Tested with the following scenarios: a) mirror only 1) c

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Luiz Capitulino
On Mon, 05 Mar 2012 11:27:07 -0600 Anthony Liguori wrote: > On 03/05/2012 11:20 AM, Avi Kivity wrote: > > On 03/05/2012 04:33 PM, Anthony Liguori wrote: > >> > >> > >> async in QEMU doesn't mean "generate a QMP event when you're done". > >> It should mean execute this closure when you finish (fun

Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Stefan Weil
Am 05.03.2012 14:49, schrieb Peter Maydell: On 5 March 2012 13:23, Andreas Färber wrote: Am 05.03.2012 07:22, schrieb Stefan Weil: The macro offsetof is defined in stddef.h. It is conforming to the standards C89, C99 and POSIX.1-2001 (see man page), so it is a sufficiently old standard. There

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 07:27 PM, Anthony Liguori wrote: > On 03/05/2012 11:20 AM, Avi Kivity wrote: >> On 03/05/2012 04:33 PM, Anthony Liguori wrote: >>> >>> >>> async in QEMU doesn't mean "generate a QMP event when you're done". >>> It should mean execute this closure when you finish (function pointer >>>

Re: [Qemu-devel] KVM call agenda for tuesday 31

2012-03-05 Thread Avi Kivity
On 03/05/2012 05:50 PM, Peter Maydell wrote: > On 5 March 2012 15:43, Andreas Färber wrote: > > Mid-term also depends on how me want to proceed with LPAE softmmu-wise > > (bump "arm" to 64-bit target_phys_addr_t, or do LPAE and AArch64 in a > > new "arm64"). > > For LPAE I would have thought we wa

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Anthony Liguori
On 03/05/2012 11:20 AM, Avi Kivity wrote: On 03/05/2012 04:33 PM, Anthony Liguori wrote: async in QEMU doesn't mean "generate a QMP event when you're done". It should mean execute this closure when you finish (function pointer + opaque). The QMP event should be dispatched from the closure suc

[Qemu-devel] [PATCH] spice: set spice uuid and name

2012-03-05 Thread Marc-André Lureau
This allows a Spice client to identify a VM --- ui/spice-core.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index c1091e1..80535b6 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -19,6 +19,7 @@ #include #include +#incl

Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async

2012-03-05 Thread Avi Kivity
On 03/05/2012 04:33 PM, Anthony Liguori wrote: > > > async in QEMU doesn't mean "generate a QMP event when you're done". > It should mean execute this closure when you finish (function pointer > + opaque). > > The QMP event should be dispatched from the closure such that the > screendump code does

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Eric Blake
On 03/05/2012 09:59 AM, Marcelo Tosatti wrote: > On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: >> Hi, >> recently I've been working on live block migration combining the live >> snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. >> >> The design is sum

Re: [Qemu-devel] [PATCH v3 0/3] screendump async command

2012-03-05 Thread Anthony Liguori
On 03/05/2012 09:56 AM, Alon Levy wrote: v2->v3: pass a closure to hw_screen_dump_async Alon Levy (3): monitor, console: add QEVENT_SCREEN_DUMP_COMPLETE console: add hw_screen_dump_async add qmp screendump-async Reviewed-by: Anthony Liguori Regards, Anthony Liguori QMP/qmp-e

[Qemu-devel] [Bug 938937] Re: Slirp --> Abort when operate dhclient

2012-03-05 Thread ironstorm
*** This bug is a duplicate of bug 824650 *** https://bugs.launchpad.net/bugs/824650 Having just rebuilt qemu from GIT and started using the rebuild binary, this problem no longer occurs... definitely related to or duplicate of 824650. ** This bug has been marked a duplicate of bug 824650

Re: [Qemu-devel] Live Block Migration using Mirroring

2012-03-05 Thread Marcelo Tosatti
On Wed, Feb 22, 2012 at 05:13:32PM +, Federico Simoncelli wrote: > Hi, > recently I've been working on live block migration combining the live > snapshots and the blkmirror patch sent by Marcelo Tosatti few months ago. > > The design is summarized at this url as "Mirrored-Snapshot": > > htt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] osdep: Remove local definition of macro offsetof

2012-03-05 Thread Stefan Hajnoczi
On Mon, Mar 05, 2012 at 07:22:31AM +0100, Stefan Weil wrote: > The macro offsetof is defined in stddef.h. It is conforming to > the standards C89, C99 and POSIX.1-2001 (see man page), so it > is a sufficiently old standard. > > Therefore chances are very high that QEMU never needs a local > defini

Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT

2012-03-05 Thread Meador Inge
On 02/23/2012 07:44 AM, Meador Inge wrote: > 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the > opcode table creation code to erroneously register 'eieio' and 'mbar' > for the "default" processor: > >** ERROR: opcode 1a already assigned in opcode table 16 >*** ERROR:

  1   2   3   >