Il 20/04/2012 12:03, Stefan Weil ha scritto:
These patches remove timer code which is no longer needed
and try to improve the remaining code.
[PATCH 1/5] qemu-timer: Remove redundant include statements
[PATCH 2/5] qemu-timer: Remove unused function qemu_alarm_pending
[PATCH 3/5] qemu-timer:
On 20 April 2012 17:14, Andreas Färber afaer...@suse.de wrote:
Am 14.04.2012 18:42, schrieb Peter Maydell:
/* TODO Move contents into arm_cpu_reset() in cpu.c,
* once cpu_reset_model_id() is eliminated,
...if you were to drop this comment line it would be cleaner. There is
no
Am 20.04.2012 18:05, schrieb Peter Maydell:
On 20 April 2012 17:00, Andreas Färber afaer...@suse.de wrote:
Am 14.04.2012 18:42, schrieb Peter Maydell:
+cpu-clidr = (1 27) | (2 24) | 3;
Copypaste, should be (1 27) | (1 24) | 3.
Fixed and pushed, sigh.
Acked-by: Andreas Färber
On Fri, Apr 20, 2012 at 12:33:57PM +0200, Igor Mammedov wrote:
On 04/19/2012 04:08 PM, Vasilis Liaskovitis wrote:
-numa_fw_cfg = g_malloc0((1 + max_cpus + nb_numa_nodes) * 8);
+numa_fw_cfg = g_malloc0((2 + max_cpus + nb_numa_nodes + 3 *
nb_hp_memslots) * 8);
numa_fw_cfg[0] =
On Thu, 19 Apr 2012 14:59:25 -0500, Aaron Stover (Celestech)
aaron.sto...@celestech.com wrote:
Hi,
I'm curious as to the current status of the fault tolerance features of
QEMU? From reading what I could find on the wiki, it appears as though
the code was ready to be merged into version
Hi,
I am observing an interesting phenomenon on the latest QEMU git and the
latest HelenOS mainline (the problem is likely guest-neutral though).
The QEMU command line is as follows:
$ qemu-system-i386 -device rtl8139,vlan=0 -net user -boot d -redir \
udp:8080::8080 -redir udp:8081::8081
On 20.4.2012 12:17, Jakub Jermar wrote:
I am observing an interesting phenomenon on the latest QEMU git and the
latest HelenOS mainline (the problem is likely guest-neutral though).
The QEMU command line is as follows:
$ qemu-system-i386 -device rtl8139,vlan=0 -net user -boot d -redir \
Am 14.04.2012 18:42, schrieb Peter Maydell:
Now that cpu_reset_model_id() has gone we can move the
reset code over to the class reset function and have cpu_state_reset
simply do a reset on the CPU QOM object.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
Acked-by: Andreas Färber
If an AIO request is in flight that refers to a BlockDriverState that
has been closed and possibly even freed, more or less anything could
happen. I have seen segfaults, -EBADF return values and qcow2 sometimes
actually catches the situation in bdrv_close() and abort()s.
Signed-off-by: Kevin Wolf
The following changes since commit 51006bbc45bc74977ae538190a53df2af534acb9:
Merge remote-tracking branch 'origin/master' into staging (2012-04-18
10:06:09 -0500)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Andreas Färber (1):
iotests: Resolve
If the BlockDriverState is closed/freed without draining the AIO
requests first, the request coroutines may work on invalid data and file
descriptors or have some dangling pointers that cause segfaults.
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
Am 14.04.2012 18:42, schrieb Peter Maydell:
Move the A9 config_base_address cp15 register reset value to
ARMCPU. This should become a QOM property so that the Highbank
board can set it without having to pull in cpu-qom.h, but at
least this avoids the implicit dependency on reset ordering
that
Someone forgot something in commit 29c1a730... Documenting the right
return value is not enough, you also need to actually return it in the
code.
This bug sometimes causes error return values even when everything has
succeeded: The new offset of the refcount block is truncated to 32 bits
and
On 20 April 2012 18:01, Andreas Färber afaer...@suse.de wrote:
Am 14.04.2012 18:42, schrieb Peter Maydell:
@@ -213,14 +207,17 @@ static void highbank_init(ram_addr_t ram_size,
}
for (n = 0; n smp_cpus; n++) {
+ ARMCPU *cpu;
env = cpu_init(cpu_model);
if
On Fri, Apr 20, 2012 at 10:36:38AM -0300, Luiz Capitulino wrote:
On Fri, 20 Apr 2012 14:07:16 +0200
Michal Privoznik mpriv...@redhat.com wrote:
But, I think if we tell users we'll *only* send response on error,
we should do our part to *not* send the responses, rather than relying
on
From: Paolo Bonzini pbonz...@redhat.com
QED uses vm_clock timers so that images are not touched during and after
migration. This however does not apply to qemu-io and qemu-img.
Treat vm_clock as a synonym for rt_clock there, and enable it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Zero clusters will add another cluster type. Refactor the open-coded
cluster type detection into a switch of QCOW2_CLUSTER_* options so that
the detection is in a single place. This makes it easier to add new
cluster types.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2-refcount.c |
On Fri, Apr 20, 2012 at 12:26:10PM -0500, Michael Roth wrote:
On Fri, Apr 20, 2012 at 10:36:38AM -0300, Luiz Capitulino wrote:
On Fri, 20 Apr 2012 14:07:16 +0200
Michal Privoznik mpriv...@redhat.com wrote:
But, I think if we tell users we'll *only* send response on error,
we should
From: Andreas Färber andreas.faer...@web.de
Hello Peter,
This mini-series redoes your drop-reset-model-init patch 14/14 v2.
I've investigated doing it this way for sh4 and plan to adjust all targets.
Note that I haven't tested Highbank, just the Integrator/CP using old
cpu_init().
Regards,
Make cpu_arm_init() return a QOM ARMCPU, so that we don't need to
obtain an ARMCPU through arm_env_get_cpu() in machine init code.
This requires to adjust the inclusion site of cpu-qom.h and in turn,
forward-looking, to homogenize its include order.
cpu_init() must still return a CPUARMState for
From: Peter Maydell peter.mayd...@linaro.org
Move the A9 config_base_address cp15 register reset value to
ARMCPU. This should become a QOM property so that the Highbank
board can set it without having to pull in cpu-qom.h, but at
least this avoids the implicit dependency on reset ordering
that
Hi; this is a pullreq for the arm-devs queue, fairly minor stuff.
Please pull.
thanks
-- PMM
The following changes since commit 51006bbc45bc74977ae538190a53df2af534acb9:
Merge remote-tracking branch 'origin/master' into staging (2012-04-18
10:06:09 -0500)
are available in the git repository
From: Eric Benard e...@eukrea.com
- add support for the 64MB NOR CFI01 flash available at
0x3400 on the versatilepb board
http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0225d/BBAJIHEC.html
- tested with barebox bootloader
Signed-off-by: Eric Bénard e...@eukrea.com
On reset of the mpcore timer/watchdog block we need to
delete the qemu_timer in case it was running.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
hw/arm_mptimer.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/arm_mptimer.c b/hw/arm_mptimer.c
index
From: Oskar Andero oskar.and...@gmail.com
The versatile i2c controller implementation was separated to
its own file called versatile_i2c.c. This is done as a preparation
for adding i2c support to the versatilepb board.
Signed-off-by: Oskar Andero oskar.and...@gmail.com
Signed-off-by: Peter
From: Oskar Andero oskar.and...@gmail.com
Add ds1338 rtc attached on i2c.
Signed-off-by: Oskar Andero oskar.and...@gmail.com
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
hw/versatilepb.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/versatilepb.c
From: Paolo Bonzini pbonz...@redhat.com
posix_aio_read already calls qemu_aio_process_queue, and dually
qemu_aio_process_queue is always followed by a select loop that calls
posix_aio_read.
No races are possible, so there is no need for a separate process_queue
callback.
Signed-off-by: Paolo
Refcount block allocation and refcount table growth rely on
s-free_cluster_index pointing to somewhere after the current
allocation. Change qcow2_alloc_cluster_at() to fulfill this
assumption.
Without this change it could happen that a newly allocated refcount
block and the allocated data block
From: Paolo Bonzini pbonz...@redhat.com
The do...while loop can never loop, because select will just not return
0 when invoked with infinite timeout.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
aio.c | 133
On 04/03/2012 06:15 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzinipbonz...@redhat.com
---
hw/qdev.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index e674248..45f1133 100644
--- a/hw/qdev.c
+++
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
The IDE PIO write sector code path uses bdrv_write() and hence can make
the guest unresponsive while the I/O request is in progress. This patch
converts ide_sector_write() to use bdrv_aio_writev() by using the
BUSY_STAT bit to tell the guest that
This allows that different snapshots of an image can have different
sizes, which is a requirement for enabling image resizing even with
images that have internal snapshots.
We don't do the actual support for it now, but make sure that the
additional field is present and not completely ignored in
On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote:
From: Liu Yuan tailai...@taobao.com
Flush operation is supposed to flush the write-back cache of
sheepdog cluster.
By issuing flush operation, we can assure the Guest of data
reaching the sheepdog cluster storage.
How does qemu
Until now, count_contiguous_clusters() has an argument that allowed to
specify flags that should be ignored in the comparison, i.e. that are
allowed to change between contiguous clusters.
This patch changes the function so that it ignores all flags by default
now and you need to pass the flags on
From: Paolo Bonzini pbonz...@redhat.com
In the next patch we want to reenter the coroutine from
block_job_cancel_sync and cancel the timer.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-coroutine-sleep.c |3 ++-
1 files changed, 2
qcow2.py must be updated to work with version 3 images at all, the
output has changed since the feature table extension has been added, and
version 2 and version 3 images can't possibly have the same test output.
Change the test case to completely ignore IMGOPTS and run the test for
both
From: Liu Yuan tailai...@taobao.com
The 'qemu-img convert -h' advertise that the default cache mode is
'writeback', while in fact it is 'unsafe'.
This patch 1) fix the help manual and 2) let bdrv_close() call bdrv_flush()
2) is needed because some backend storage doesn't have a self-flush
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2-refcount.c |2 +-
block/qcow2.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 909d615..e0854dc 100644
--- a/block/qcow2-refcount.c
+++
From: Paolo Bonzini pbonz...@redhat.com
The definition of when qemu_aio_flush should loop is much simpler
than it looks. It just has to call qemu_aio_wait until it makes
no progress and all flush callbacks return false. qemu_aio_wait
is the logical place to tell the caller about this.
This changes the still existing places that assume that the only flags
are QCOW_OFLAG_COPIED and QCOW_OFLAG_COMPRESSED to properly mask out
reserved bits.
It does not convert bdrv_check yet.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2-cluster.c | 26 +-
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 14 +++--
block/qcow2-cluster.c | 72 +
block/qcow2.c | 21 ++
block/qcow2.h |1 +
4 files changed, 105 insertions(+), 3 deletions(-)
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/qemu-iotests/033 | 73
tests/qemu-iotests/033.out | 29 +
tests/qemu-iotests/group
count_cow_clusters() tries to reuse existing functions, and all it
achieves is to make things much more complicated than they really are:
Everything needs COW, unless it's a normal cluster with refcount 1.
This patch implements the obvious way of doing this, and by using
qcow2_get_cluster_type()
From: Andreas Färber afaer...@suse.de
`hostname -s` may output an errror:
hostname: Name or service not known
This causes all tests to fail for `make check-block`.
Suppress such error messages, letting the tests succeed.
Signed-off-by: Andreas Färber afaer...@suse.de
Signed-off-by: Kevin Wolf
This adds an -o option to qemu-iotests, which is an option string that
is passed through to qemu-img create -o... This allows testing different
subformat with a command like './check -qcow2 -o compat=0.10'.
For qcow2, if no compat option is specified, compat=1.1 is the new
default.
From: Paolo Bonzini pbonz...@redhat.com
This will let timers run during aio_read and aio_write commands,
though not during synchronous commands.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
cmd.c | 10 +-
qemu-io.c |7 ---
This adds the basic infrastructure to qcow2 to handle version 3 images.
It includes code to create v3 images, allow header updates for v3 images
and checks feature bits.
It still misses support for zero clusters, so this is not a fully
compliant implementation of v3 yet.
The default for creating
This updates the qcow2 specification to cover version 3. It contains the
following changes:
- Added compatible/incompatible/auto-clear feature bits plus an optional
feature name table to allow useful error messages even if an older
version doesn't know some feature at all.
- Configurable
This adds support for reading zero clusters in version 3 images.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2-cluster.c | 17 +
block/qcow2-refcount.c |7 +++
block/qcow2.c |8
block/qcow2.h |5 +
4 files changed, 33
From: Stefan Weil s...@weilnetz.de
Signed-off-by: Stefan Weil s...@weilnetz.de
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/cow.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 8d3c9f8..a5a00eb 100644
--- a/block/cow.c
+++
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
According comment, we should not read again, we will write.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/qemu-iotests/005 |
Instead of printing an ugly bitmask, qemu can now print a more helpful
string even for yet unknown features.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c | 66 +---
block/qcow2.h | 12 ++
2 files changed, 69
Some image formats do have a cluster size, others don't, but there are
tests that work with both sets of images and currently we get failures
because the qemu-img create output doesn't mention the cluster size for
some formats.
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini
Also don't infer the cluster type directly from the L2 entries, but use
qcow2_get_cluster_type() to keep everything in a single place.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2-refcount.c | 98 ++-
1 files changed, 54 insertions(+),
To be used as in 'qemu-io -t writeback test.img'
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
qemu-io.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index e6fcd77..3095a22 100644
---
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
The IDE PIO interface currently uses bdrv_read() to perform reads
synchronously. Synchronous I/O in the vcpu thread is bad because it
prevents the guest from executing code - it makes the guest
unresponsive.
This patch converts IDE PIO to use
Signed-off-by: Kevin Wolf kw...@redhat.com
---
tests/qemu-iotests/034 | 113
tests/qemu-iotests/034.out | 81 +++
tests/qemu-iotests/group |1 +
3 files changed, 195 insertions(+), 0 deletions(-)
create mode
qcow2_alloc_compressed_cluster_offset() already fails if the copied flag
is set, because qcow2_write_compressed() doesn't perform COW as it would
have to do to allow this.
However, what we really want to check here is whether the cluster is
allocated or not. With internal snapshots the copied
With this change, reading from a qcow2 image ignores all reserved bits
that are set in an L1 or L2 table entry.
Now get_cluster_offset() assigns *cluster_offset only the offset without
any other flags. The cluster type is not longer encoded in the offset,
but a positive return value in case of
From: Paolo Bonzini pbonz...@redhat.com
Both unused after the previous patch.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
aio.c | 29 ++---
block/curl.c | 10 --
block/iscsi.c |4
If do_alloc_cluster_offset() fails, the error handling code tried to
remove the request from the in-flight queue, to which it wasn't added
yet, resulting in a NULL pointer dereference.
m-nb_clusters really only becomes != 0 when the request is in the list.
Signed-off-by: Kevin Wolf
Il 20/04/2012 19:26, Michael Roth ha scritto:
Do we have a way of differentiating a guest shutting down as a result of
shutdown vs. suspend-to-disk? AFAIK they both have the same ending state. If
so I'm not sure we can say anything other than the machine may or may not
resume when you start it
Public bug reported:
When the GNOME 3 screensaver activates with the mouse cursor over the
SDL window, the screensaver will not unlock unless the gnome-shell
process is killed and restarted manually. This seems to be related to
the fact that the key strokes are grabbed by SDL, but the screensaver
At Fri, 20 Apr 2012 20:05:48 +0200,
Christoph Hellwig wrote:
On Tue, Apr 03, 2012 at 01:35:50AM +0800, Liu Yuan wrote:
From: Liu Yuan tailai...@taobao.com
Flush operation is supposed to flush the write-back cache of
sheepdog cluster.
By issuing flush operation, we can assure the
/* QEMU Synchronous Serial Interface support. */
-/* In principle SSI is a point-point interface. As such the qemu
- implementation has a single slave device on a bus.
+/* In principle SSI is a point-point interface.
However it is fairly common for boards to have multiple slaves
So my next question is, does qemu have a way that features can be sponsored?
Aaron Stover
Celestech Inc.
480-940-1640 x205
- Reply message -
From: Brian Jackson i...@theiggy.com
To: qemu-devel@nongnu.org, Aaron Stover (Celestech)
aaron.sto...@celestech.com
Subject: [Qemu-devel] Fault
On Fri, Apr 20, 2012 at 09:39:59PM +0200, Paolo Bonzini wrote:
Il 20/04/2012 19:26, Michael Roth ha scritto:
Do we have a way of differentiating a guest shutting down as a result of
shutdown vs. suspend-to-disk? AFAIK they both have the same ending state. If
so I'm not sure we can say
On 04/19/2012 05:47 AM, Laurent Vivier wrote:
Hi Rob,
you need to do a fresh clone because I rebase the branch frequently on
the qemu/master instead of merging it. It is easier to manage for me.
Ok. (Did that.)
BTW, qemu-system-m68k is not working currently.
Did it ever? :)
I'm working
On Thu, 19 Apr 2012 19:00:39 +0800
Wen Congyang we...@cn.fujitsu.com wrote:
At 04/18/2012 08:49 PM, Wen Congyang Wrote:
Hi, all
'virsh dump' can not work when host pci device is used by guest. We have
discussed this issue here:
v2
- convert netdev_add by using gen=no as suggested by Paolo
- drop unneeded patches (qemu-option code generator changes)
- re-work some error handling changes
- improve some changelogs
blockdev.c |2 +-
hmp-commands.hx |6 +-
hmp.c| 30 +
Note that qemu_opt_parse() callers still expect automatic error reporting
with QError, so qemu_opts_parse() calls qerror_report_err() to keep the
same semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 26 +++---
1 file changed, 19
Note that qemu_find_opts() and qemu_config_parse() need to call
error_report() to maintain their semantics on error.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-config.c | 32 +---
1 file changed, 25 insertions(+), 7 deletions(-)
diff --git
This commit converts qemu_opts_create() from qerror_report() to
error_set().
Currently, most calls to qemu_opts_create() can't fail, so most
callers don't need any changes.
The two cases where code checks for qemu_opts_create() erros are:
1. Initialization code in vl.c. All of them print their
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c |4
qerror.h |3 +++
2 files changed, 7 insertions(+)
diff --git a/qerror.c b/qerror.c
index 96fbe71..5d92096 100644
--- a/qerror.c
+++ b/qerror.c
@@ -156,6 +156,10 @@ static const QErrorStringTable qerror_table[] =
The only backend that really uses it is the socket one, which calls
monitor_get_fd(). But it can use 'cur_mon' instead.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hw/pci-hotplug.c |2 +-
hw/usb/dev-network.c |2 +-
net.c| 18 +++---
net.h
This is like qemu_opt_set(), except that it takes an Error argument.
This new function allows for a incremental conversion of code using
qemu_opt_set().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c |6 ++
qemu-option.h |2 ++
2 files changed, 8
do_device_add() and do_netdev_add() call qerror_report_err() to maintain
their QError semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hw/qdev-monitor.c |7 +--
net.c |5 -
qemu-option.c | 31 ---
qemu-option.h
This is like qemu_find_opts(), except that it takes an Error argument.
This new function allows for a incremental conversion of code using
qemu_find_opts().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-config.c |5 +
qemu-config.h |3 +++
2 files changed, 8
Note that set_option_parameter() callers still expect automatic error
reporting with QError, so set_option_parameter() calls
qerror_report_err() to keep the same semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 22 +++---
1 file changed, 15
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(),
but their callers expect QError semantics. Thus, both functions call
qerro_report_err() to keep the expected semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 36
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hmp-commands.hx |3 +--
hmp.c|9 +
hmp.h|1 +
net.c| 11 +--
net.h|1 -
qapi-schema.json | 14
net_client_init() propagates the error up by calling qerror_report_err(),
because its users expect QError semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
net.c |6 +-
qemu-option.c | 13 +
qemu-option.h |2 +-
3 files changed, 11
The functions qemu_opt_set() and opts_do_parse() both call opt_set(),
but their callers expect QError semantics. Thus, both functions call
qerro_report_err() to keep the expected semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 31
This is not a full QAPI conversion, but an intermediate step.
In essence, do_netdev_add() is split into three functions:
1. netdev_add(): performs the actual work. This function is fully
converted to Error (thus, it's qapi-friendly)
2. qmp_netdev_add(): the QMP front-end for netdev_add().
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qemu-option.c | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index a8b50af..61354af 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -203,7 +203,8 @@ static void
Callers are changed to use qerror_report_err() to keep their QError
semantics.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
hw/pci-hotplug.c |8 ++--
hw/usb/dev-network.c |7 +--
net.c| 53 +++---
Hi Peter,
Am 19.04.2012 04:33, schrieb Peter Crosthwaite:
So is there any standard policy on setting maintainer-ships for device
models? When I pushed the cadence IP device models (hw/cadence*) for
xilinx zynq there was insistence that they be in the MAINTAINERS,
Yes, that was my request.
Am 12.04.2012 13:20, schrieb Andreas Färber:
Hi Edgar,
Here's a rebased version of MicroBlaze CPU QOM'ification.
Ping! Any problem or just lack of time? Hard Freeze is Monday in a
week... I'd have one additional optional change to cpu_mb_init() for a
v4, so let me know if I need to change
101 - 188 of 188 matches
Mail list logo
