Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-26 Thread Kevin O'Connor
On Thu, Apr 26, 2012 at 07:12:22PM +1200, Alexey Korolev wrote: > On 26/04/12 03:29, Gerd Hoffmann wrote: > >> Okay - I missed that. I think the patches look okay to be committed - > >> any additional changes can be made on top. Gerd - do you have any > >> comments? > > These are certainly no blo

[Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()/strtoull()

2012-04-26 Thread Luiz Capitulino
It's not checked currently, so something like: (qemu) balloon -10114334234 (qemu) Will just "work" (in this case the balloon command will get a random value). Fix it by checking if strtoul()/strtoull() overflowed. Signed-off-by: Luiz Capitulino --- monitor.c |7 +++

[Qemu-devel] [PATCH 2/2] hmp: fix bad value conversion for M type

2012-04-26 Thread Luiz Capitulino
The M type converts from megabytes to bytes. However, the value can be negative before the conversion, which will lead to a flawed conversion. For example, this: (qemu) balloon -1011 (qemu) Just "works", but the value passed by the balloon command will be something else. This patc

[Qemu-devel] [PATCH v2 0/2]: hmp: integer parsing fixes

2012-04-26 Thread Luiz Capitulino
o V2 - Set errno to zero before calling strtoul()/strtoull() [Eric] - Better error message [Eric/Peter] monitor.c | 11 +++ 1 file changed, 11 insertions(+)

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Luiz Capitulino
On Thu, 26 Apr 2012 20:19:42 -0300 Luiz Capitulino wrote: > On Thu, 26 Apr 2012 20:18:02 -0300 > Luiz Capitulino wrote: > > > > Not quite right. ULLONG_MAX is a valid return, but you did not prime > > > errno, so if errno has junk ERANGE from some earlier point in the > > > program, you will h

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Luiz Capitulino
On Thu, 26 Apr 2012 20:18:02 -0300 Luiz Capitulino wrote: > > Not quite right. ULLONG_MAX is a valid return, but you did not prime > > errno, so if errno has junk ERANGE from some earlier point in the > > program, you will have a false negative. You are guaranteed that errno > > is unchanged on

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Luiz Capitulino
On Thu, 26 Apr 2012 15:34:50 -0600 Eric Blake wrote: > On 04/26/2012 03:10 PM, Luiz Capitulino wrote: > > It's not checked currently, so something like: > > > > (qemu) balloon -10114334234 > > (qemu) > > > > Will just "work" (in this case the balloon command will get a rando

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Luiz Capitulino
On Thu, 26 Apr 2012 22:30:20 +0100 Peter Maydell wrote: > On 26 April 2012 22:10, Luiz Capitulino wrote: > > It's not checked currently, so something like: > > > >  (qemu) balloon -10114334234 > >  (qemu) > > > > Will just "work" (in this case the balloon command will get a rando

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Andreas Färber
Am 26.04.2012 20:10, schrieb Anthony Liguori: >> Not so long ago you told me that the whole machine should go into >> configuration files... If we do start drilling up QEMUMachine now, we >> should seriously QOM'ify it for 1.2. > > QOM represents logic objects. It's a data model and when we model

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Alexander Graf
On 26.04.2012, at 21:00, Christian Borntraeger wrote: > On 26/04/12 19:11, Peter Maydell wrote: >> On 26 April 2012 18:09, Alexander Graf wrote: >>> On 26.04.2012, at 18:17, Peter Maydell wrote: Can you describe what the problem is that you're trying to solve here? It's not entirely ob

Re: [Qemu-devel] [PATCH] qapi: fix qmp_balloon() conversion

2012-04-26 Thread Michael Roth
On Thu, Apr 26, 2012 at 06:07:41PM -0300, Luiz Capitulino wrote: > Commit d72f326431 forgot to convert a call from qerror_report() to > error_set(). Fix it. > > Signed-off-by: Luiz Capitulino Reviewed-by: Michael Roth > --- > balloon.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [Qemu-devel] [PATCH 2/2] hmp: fix bad value conversion for M type

2012-04-26 Thread Eric Blake
On 04/26/2012 03:10 PM, Luiz Capitulino wrote: > The M type converts from megabytes to bytes. However, the value can be > negative before the conversion, which will lead to a flawed conversion. > > For example, this: > > (qemu) balloon -1011 > (qemu) > > Just "works", but the value

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Eric Blake
On 04/26/2012 03:10 PM, Luiz Capitulino wrote: > It's not checked currently, so something like: > > (qemu) balloon -10114334234 > (qemu) > > Will just "work" (in this case the balloon command will get a random > value). > > Fix it by checking if strtout() overflowed. > > Sig

[Qemu-devel] [PATCH] qapi: fix qmp_balloon() conversion

2012-04-26 Thread Luiz Capitulino
Commit d72f326431 forgot to convert a call from qerror_report() to error_set(). Fix it. Signed-off-by: Luiz Capitulino --- balloon.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/balloon.c b/balloon.c index 0166744..aa354f7 100644 --- a/balloon.c +++ b/balloon.c @@ -108,

Re: [Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Peter Maydell
On 26 April 2012 22:10, Luiz Capitulino wrote: > It's not checked currently, so something like: > >  (qemu) balloon -10114334234 >  (qemu) > > Will just "work" (in this case the balloon command will get a random > value). > > Fix it by checking if strtout() overflowed. "strtoul()/

[Qemu-devel] [Bug 989225] [NEW] windows XP Standard PC HAL does not work with qemu-kvm >= 0.15

2012-04-26 Thread Michael Chudobiak
Public bug reported: Basically, this is a clone of a Debian bug which is explained well here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=647312 For some reason, the Debian bug has been archived, but I do not think the issue has been fixed. Basically, mouse and network do not work for older

[Qemu-devel] [PATCH 2/2] hmp: fix bad value conversion for M type

2012-04-26 Thread Luiz Capitulino
The M type converts from megabytes to bytes. However, the value can be negative before the conversion, which will lead to a flawed conversion. For example, this: (qemu) balloon -1011 (qemu) Just "works", but the value passed by the balloon command will be something else. This patc

[Qemu-devel] [PATCH 1/2] hmp: expr_unary(): check for overflow in strtoul()

2012-04-26 Thread Luiz Capitulino
It's not checked currently, so something like: (qemu) balloon -10114334234 (qemu) Will just "work" (in this case the balloon command will get a random value). Fix it by checking if strtout() overflowed. Signed-off-by: Luiz Capitulino --- monitor.c |6 ++ 1 file cha

[Qemu-devel] [PATCH 0/2]: hmp: integer parsing fixes

2012-04-26 Thread Luiz Capitulino
Please, check individual patches for details. monitor.c | 10 ++ 1 file changed, 10 insertions(+)

Re: [Qemu-devel] [Bug 988291] Re: virsh -c qemu+ssh://root@source/system migrate --domain client --desturi qemu+ssh://root@destination/system fails

2012-04-26 Thread Anthony Liguori
On 04/25/2012 11:29 AM, Serge Hallyn wrote: O1 is an uptodate oneiric system (qemu-kvm 0.14.1) P1 is an uptodate precise system (qemu-kvm 1.0). Same thing happens with upstream git HEAD from qemu /mnt is an nfs mount shared between the two On O1: root@server-8987:/mnt# kvm -version QEMU emulat

[Qemu-devel] [Bug 965867] Re: 9p virtual file system on qemu slow

2012-04-26 Thread max
Hi Mohan, this parameter provide significant improvement in big file access/write: VirtFS on /srv/shared type 9p (rw,trans=virtio,version=9p2000.L,msize=262144) $ dd if=/dev/zero of=test count=10 bs=

Re: [Qemu-devel] [PATCH v10 2/4] sockets: change inet_connect() to support nonblock socket

2012-04-26 Thread Michael Roth
On Wed, Apr 25, 2012 at 01:21:14PM +0800, Amos Kong wrote: > Add a bool argument to inet_connect() to assign if set socket > to block/nonblock, and delete original argument 'socktype' > that is unused. > Add a new argument to inet_connect()/inet_connect_opts(), > to pass back connect error by error

[Qemu-devel] [Bug 989060] [NEW] https://sourceforge.net/projects/kvm/files/ says use 0.14

2012-04-26 Thread Stefan Lasiewski
Public bug reported: http://www.linux-kvm.org/page/Downloads says I should can download the latest version of qemu-kvm at https://sourceforge.net/projects/kvm/files/ . But I want to note that https://sourceforge.net/projects/kvm/files/ says: Looking for the latest version? Download qemu-kvm-

Re: [Qemu-devel] [PATCH v2 14/14] QemuOpts: correctly skip escaped , id=

2012-04-26 Thread Paolo Bonzini
Il 26/04/2012 20:03, Anthony Liguori ha scritto: >> >> Ok, I'll take a look and work on top of Luiz's netdev patches >> when I come back from holiday. >> >> Are you applying the non-problematic patches to 1.1, or even >> only the first 11? > > I had tried to do a subset of them but I ran into anot

[Qemu-devel] [PATCH 04 v2] s390: reset avail and used index on reboot

2012-04-26 Thread Christian Borntraeger
From: Jens Freimann reset the guest vring avail/used idx fields, otherwise it's possible that old values remain in memory which would cause a reboot to fail with a "Guest moved used index" message version 2: split out the index reset Signed-off-by: Jens Freimann Signed-off-by: Christian Bornt

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Christian Borntraeger
On 26/04/12 19:11, Peter Maydell wrote: > On 26 April 2012 18:09, Alexander Graf wrote: >> On 26.04.2012, at 18:17, Peter Maydell wrote: >>> Can you describe what the problem is that you're trying to solve >>> here? It's not entirely obvious from this commit message. >> >> On s390, there is no ide

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Anthony Liguori
On 04/26/2012 01:17 PM, Peter Maydell wrote: On 26 April 2012 19:10, Anthony Liguori wrote: QOM represents logic objects. It's a data model and when we model hardware, we can model something concrete (because hardware for the most part has a physical implementation). Machines are entirely a Q

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Peter Maydell
On 26 April 2012 19:10, Anthony Liguori wrote: > QOM represents logic objects.  It's a data model and when we model hardware, > we can model something concrete (because hardware for the most part has a > physical implementation). > > Machines are entirely a QEMU concept. Not this one again? The r

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Anthony Liguori
On 04/26/2012 11:11 AM, Andreas Färber wrote: Am 26.04.2012 17:48, schrieb Anthony Liguori: On 04/26/2012 10:23 AM, Christian Borntraeger wrote: From: Einar Lueck There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Theref

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Anthony Liguori
On 04/26/2012 01:00 PM, Peter Maydell wrote: On 26 April 2012 18:58, Igor Mitsyanko wrote: Well, performance characteristics of IDE/SCSI do not really matter if there is no IDE/SCSI support in machine model. In case if machine supports various interfaces, the fastest should be set as default,

Re: [Qemu-devel] [PATCH v2 14/14] QemuOpts: correctly skip escaped , id=

2012-04-26 Thread Anthony Liguori
On 04/26/2012 11:56 AM, Paolo Bonzini wrote: This breaks qemu-test. Specifically: out=`hmp netdev_add user,id=foo` Fails with an error in QemuOpts parsing. Ok, I'll take a look and work on top of Luiz's netdev patches when I come back from holiday. Are you applying the non-problematic patch

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Peter Maydell
On 26 April 2012 18:58, Igor Mitsyanko wrote: > Well, performance characteristics of IDE/SCSI do not really matter if there > is no IDE/SCSI support > in machine model. In case if machine supports various interfaces, the > fastest should be set as default, This would mean our user interface is co

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Igor Mitsyanko
On 04/26/2012 09:24 PM, Peter Maydell wrote: On 26 April 2012 18:13, Igor Mitsyanko wrote: As I understand, this patch only purpose is to remove necessity of specifying "if=" option for "-drive" command line argument (and drive_add HMP/QMP command), this way on a machine with SD card interfac

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Peter Maydell
On 26 April 2012 18:13, Igor Mitsyanko wrote: > As I understand, this patch only purpose is to remove necessity of > specifying "if=" option for "-drive" command line argument (and drive_add > HMP/QMP command), this way on a machine with SD card interface only you no > longer need to write "-drive

[Qemu-devel] [Bug 988909] Re: Assert failed in arp_table.c

2012-04-26 Thread Gustavo Padovan
Well, if I remove the assertion everything works, but this might not be the right fix. The bug maybe somewhere else. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/988909 Title: Assert failed in arp

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Igor Mitsyanko
On 04/26/2012 08:17 PM, Peter Maydell wrote: On 26 April 2012 16:23, Christian Borntraeger wrote: From: Einar Lueck There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field def_blk_

[Qemu-devel] [PATCH v2] xen_disk: use bdrv_aio_flush instead of bdrv_flush

2012-04-26 Thread Stefano Stabellini
Use bdrv_aio_flush instead of bdrv_flush. Make sure to call bdrv_aio_writev/readv after the presync bdrv_aio_flush is fully completed and make sure to call the postsync bdrv_aio_flush after bdrv_aio_writev/readv is fully completed. Signed-off-by: Stefano Stabellini --- hw/xen_disk.c | 22 +++

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Peter Maydell
On 26 April 2012 18:09, Alexander Graf wrote: > On 26.04.2012, at 18:17, Peter Maydell wrote: >> Can you describe what the problem is that you're trying to solve >> here? It's not entirely obvious from this commit message. > > On s390, there is no ide or scsi, so qemu-system-s390x currently > use

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Alexander Graf
On 26.04.2012, at 18:17, Peter Maydell wrote: > On 26 April 2012 16:23, Christian Borntraeger wrote: >> From: Einar Lueck >> >> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >> default/standard interface to their block devices / drives. Therefore, >> this patch introduces a

Re: [Qemu-devel] [PATCH] tracetool: use Python 2.5-compatible exception handling syntax

2012-04-26 Thread Erik Rull
On April 25, 2012 at 11:42 AM Stefan Hajnoczi wrote: > The newer "except as :" syntax is not > supported by Python 2.5, we need to use "except , > :". > > Tested all trace backends with Python 2.5.6. > > Reported-by: Andreas Färber > Signed-off-by: Stefan Hajnoczi > --- > scripts/tracetool

[Qemu-devel] [Bug 504368] Re: sdl window intermittently scales instead of resizing

2012-04-26 Thread Serge Hallyn
This may be the root cause of bug 986192 ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Triaged -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/504368 Title: sdl window intermittently

Re: [Qemu-devel] [PATCH v2 14/14] QemuOpts: correctly skip escaped , id=

2012-04-26 Thread Paolo Bonzini
> This breaks qemu-test. Specifically: > > out=`hmp netdev_add user,id=foo` > > Fails with an error in QemuOpts parsing. Ok, I'll take a look and work on top of Luiz's netdev patches when I come back from holiday. Are you applying the non-problematic patches to 1.1, or even only the first 11?

[Qemu-devel] [Bug 988909] [NEW] Assert failed in arp_table.c

2012-04-26 Thread Gustavo Padovan
Public bug reported: With latest git (8001954) hen running: qemu-system-64 -hda $VDISK -kernel arch/x86/boot/bzImage \ -append "ro root=/dev/hda1 console=ttyS0 init=/bin/systemd" \ -curses \ -net nic -smp 3 -m 312 $@ I'm getting this: qemu-system-x86_64: slirp/arp_tab

Re: [Qemu-devel] [PATCH 4/7] [s390] reset avail and used index on reboot

2012-04-26 Thread Jens Freimann
On Thu, Apr 26, 2012 at 03:16:00PM +0200, Alexander Graf wrote: > > On 23.04.2012, at 11:52, Christian Borntraeger wrote: > > > From: Jens Freimann > > > > reset the guest vring avail/used idx fields, otherwise it's possible > > that old values remain in memory which would cause a reboot to fai

[Qemu-devel] qemu -vga qxl

2012-04-26 Thread wangyingying
hi, when i use qemu-system-x86-64 command , the argvs -vga qxl, not effect. the qxl device is not to load wangyingying

Re: [Qemu-devel] [PATCH v2 3/4] softfloat: Replace uint16 type with uint_fast16_t

2012-04-26 Thread malc
On Thu, 26 Apr 2012, Peter Maydell wrote: > On 25 April 2012 23:15, Andreas F?rber wrote: > > From: Andreas F?rber > > > > Based on the following Coccinelle patch: > > > > @@ > > typedef uint16, uint_fast16_t; > > @@ > > -uint16 > > +uint_fast16_t > > > > Fixes the build of the Cocoa frontend on

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Peter Maydell
On 26 April 2012 16:23, Christian Borntraeger wrote: > From: Einar Lueck > > There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a > default/standard interface to their block devices / drives. Therefore, > this patch introduces a new field def_blk_if per QEMUMachine struct. Can you de

Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Replace int16 type with int_fast16_t

2012-04-26 Thread Peter Maydell
On 25 April 2012 23:15, Andreas Färber wrote: > From: Andreas Färber > > Based on the following Coccinelle patch: > > @@ > typedef int16, int_fast16_t; > @@ > -int16 > +int_fast16_t > > Avoids a workaround for AIX. > > Add typedef for pre-10 Solaris. > > Signed-off-by: Andreas Färber > Cc: malc

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Andreas Färber
Am 26.04.2012 17:48, schrieb Anthony Liguori: > On 04/26/2012 10:23 AM, Christian Borntraeger wrote: >> From: Einar Lueck >> >> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >> default/standard interface to their block devices / drives. Therefore, >> this patch introduces a new f

Re: [Qemu-devel] [PATCH v2 2/4] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h

2012-04-26 Thread Peter Maydell
On 25 April 2012 23:15, Andreas Färber wrote: > From: Andreas Färber > > osdep.h is included via qemu-common.h. > > Prepares for use of [u]int_fast*_t types in softfloat code. > > Signed-off-by: Andreas Färber > Cc: Ben Taylor > Cc: Aurélien Jarno > Cc: Peter Maydell Reviewed-by: Peter Mayde

Re: [Qemu-devel] [PATCH v2 3/4] softfloat: Replace uint16 type with uint_fast16_t

2012-04-26 Thread Peter Maydell
On 25 April 2012 23:15, Andreas Färber wrote: > From: Andreas Färber > > Based on the following Coccinelle patch: > > @@ > typedef uint16, uint_fast16_t; > @@ > -uint16 > +uint_fast16_t > > Fixes the build of the Cocoa frontend on Mac OS X and avoids a > workaround for AIX. > > For pre-10 Solaris

Re: [Qemu-devel] [PATCH] nbd: Fix uninitialised use of s->sock

2012-04-26 Thread Paolo Bonzini
Il 26/04/2012 13:45, Kevin Wolf ha scritto: > s->sock is assigned only afterwards, so we're really registering an > aio_fd_handler for file descriptor 0 here. Not exactly what we intended. > > Signed-off-by: Kevin Wolf > --- > block/nbd.c |2 +- > 1 files changed, 1 insertions(+), 1 deletion

[Qemu-devel] [PULL 0/1] nbd bugfix for 1.1

2012-04-26 Thread Paolo Bonzini
Anthony, The following changes since commit ec4a804792ea20f716371a0a661efc9ec15c7ff0: hda: fix codec ids (2012-04-26 12:54:17 +0400) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to b3adf53a3a10a1ca8347167907e4cf8bbd0204f1:

[Qemu-devel] [PATCH 1/1] nbd: Fix uninitialised use of s->sock

2012-04-26 Thread Paolo Bonzini
From: Kevin Wolf s->sock is assigned only afterwards, so we're really registering an aio_fd_handler for file descriptor 0 here. Not exactly what we intended. Signed-off-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block/nbd.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Anthony Liguori
On 04/26/2012 10:23 AM, Christian Borntraeger wrote: From: Einar Lueck There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field def_blk_if per QEMUMachine struct. The prior use_scsi f

Re: [Qemu-devel] [Xen-devel] [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER

2012-04-26 Thread Konrad Rzeszutek Wilk
On Wed, Apr 25, 2012 at 01:23:35PM +0200, Christoph Hellwig wrote: > On Wed, Apr 25, 2012 at 12:21:53PM +0100, Stefano Stabellini wrote: > > That is true, in fact I couldn't figure out what I had to implement just > > reading the comment. So I went through the blkback code and tried to > > understa

[Qemu-devel] [PATCH 1/1] Support default interface types per QEMUMachine

2012-04-26 Thread Christian Borntraeger
From: Einar Lueck There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a default/standard interface to their block devices / drives. Therefore, this patch introduces a new field def_blk_if per QEMUMachine struct. The prior use_scsi field becomes thereby obsolete and is replaced through

[Qemu-devel] [PATCH 0/1] RFC: trivial but tree-wide change for QEMUMachine

2012-04-26 Thread Christian Borntraeger
Folks, here is a patch that touches every QEMUMachine. Question for the maintainer: ok to apply? Question for platform maintainers: did we miss something? Christian PS: Alex, the patch applies against current master. There will be a trivial offset if applied against the s390 patch queue. Einar

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-26 Thread Markus Armbruster
Pavel Hrdina writes: > Hi, > this is the patch to fix incorrect handling of IDE floppy drive controller > emulation > when no media is present. If the guest is booted without a media then the > drive > was not being emulated at all but this patch enables the emulation with no > media present.

Re: [Qemu-devel] [PATCH] Fix IDE FDC emulation for no media

2012-04-26 Thread Markus Armbruster
Kevin Wolf writes: > Am 24.04.2012 11:55, schrieb Pavel Hrdina: >> On 04/24/2012 11:32 AM, Kevin Wolf wrote: >>> Am 23.04.2012 18:06, schrieb Pavel Hrdina: Hi, this is the patch to fix incorrect handling of IDE floppy drive controller emulation when no media is present. If th

Re: [Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-04-26 Thread Alexander Graf
On 26.04.2012, at 15:49, Christian Borntraeger wrote: > From: Einar Lueck > > This patch uses ioctl HDIO_GETGEO to guess geometry of a disk in > case nothing is specified explicitly. > > Signed-off-by: Einar Lueck > Signed-off-by: Christian Borntraeger > --- > block.c | 12 > 1

Re: [Qemu-devel] [PATCH 4/7] [s390] reset avail and used index on reboot

2012-04-26 Thread Alexander Graf
On 26.04.2012, at 15:56, Christian Borntraeger wrote: >>> @@ -250,6 +251,12 @@ void s390_virtio_device_sync(VirtIOS390Device *dev) >>>vring = s390_virtio_next_ring(bus); >>>virtio_queue_set_addr(dev->vdev, i, vring); >>>virtio_queue_set_vector(dev->vdev, i, i); >>> +

Re: [Qemu-devel] [PATCH 4/7] [s390] reset avail and used index on reboot

2012-04-26 Thread Christian Borntraeger
>> @@ -250,6 +251,12 @@ void s390_virtio_device_sync(VirtIOS390Device *dev) >> vring = s390_virtio_next_ring(bus); >> virtio_queue_set_addr(dev->vdev, i, vring); >> virtio_queue_set_vector(dev->vdev, i, i); >> +idx_addr = virtio_queue_get_avail_addr(dev->vdev, i) + >

Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default

2012-04-26 Thread Bernhard Walle
Am 26.04.12 14:50, schrieb Andreas Färber: > Am 26.04.2012 12:30, schrieb Bernhard Walle: >> >> Thanks. I already stumbled over this when trying to test your >> uint16 fixes (they work for me, BTW). > > In that case please add an appropriate tag (e.g., Tested-by) as reply > there (best with info o

Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix build on Darwin (uint16)

2012-04-26 Thread Bernhard Walle
Am 26.04.12 00:15, schrieb Andreas Färber: [...] > > That would fix the reported build problem and leave the door open to sed the > types to something more performant or smaller at a later point in time. > > As before, constructive feedback and in particular... > * tests on the various platforms,

[Qemu-devel] [PATCH 3/3] support host sensing of block sizes

2012-04-26 Thread Christian Borntraeger
From: Einar Lueck This patch provides a new function to guess physical and logical block sizes and exploits them in the context of s390 virtio bus. On s390 there may be block sizes different then 512. Therefore, we will use the new function to setup the physical and logical block size properly.

Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default

2012-04-26 Thread Bernhard Walle
Am 26.04.12 11:57, schrieb Andreas Färber: > Fixes the build when combined with the drop of darwin-user. > Enthusiasts can still try building it using --enable-bsd-user. > > Signed-off-by: Andreas Färber > Cc: Bernhard Walle Tested-by: Bernhard Walle [Mac OS 10.7.3] Acked-by: Bernhard Walle

[Qemu-devel] [PATCH 1/3] Fix geometry sector calculation

2012-04-26 Thread Christian Borntraeger
Currently the sector value for the geometry is masked based on the sector size. This works fine for with 512 physical sector size, but it fails for dasd devices on s390. A dasd device can have a physical block size of 4096 (== same for logical block size) and a typcial geometry of 15 heads and 12 s

[Qemu-devel] [PATCH 0/3] RFC: common code block related patches for s390

2012-04-26 Thread Christian Borntraeger
Here are some patches in common block code, that we want to use for s390. This is mostly for dasd devices which behave slightly different to other block devices. Feedback, suggestions for better solutions and comments are welcome. Christian Borntraeger (1): Fix geometry sector calculation Einar

[Qemu-devel] [PATCH 2/3] geometry detection: use HDIO_GETGEO

2012-04-26 Thread Christian Borntraeger
From: Einar Lueck This patch uses ioctl HDIO_GETGEO to guess geometry of a disk in case nothing is specified explicitly. Signed-off-by: Einar Lueck Signed-off-by: Christian Borntraeger --- block.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/block.c b/b

Re: [Qemu-devel] [RFC 00/14] MAINTAINERS cleanups - please read

2012-04-26 Thread Andreas Färber
Am 17.04.2012 22:45, schrieb Blue Swirl: > On Mon, Apr 16, 2012 at 21:47, Anthony Liguori wrote: >> On 04/16/2012 04:24 PM, Peter Maydell wrote: >>> >>> On 16 April 2012 18:42, Anthony Liguori wrote: On 04/16/2012 12:17 PM, Peter Maydell wrote: > > Here's my stab at it: >

Re: [Qemu-devel] [PATCH] configure: Virtfs doesn't require libcap.

2012-04-26 Thread Gerd Hoffmann
On 04/26/12 14:59, Kusanagi Kouichi wrote: > On 2012-04-25 14:20:12 -0500, Anthony Liguori wrote: >> On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote: >>> Only proxy helper does. >>> >>> Signed-off-by: Kusanagi Kouichi >> >> This broke the build: >> >> http://spunk.home.kraxel.org/bb/builders/ubuntu-

Re: [Qemu-devel] [PATCH] qcow2: fix the return value -ENOENT -> -EEXIST

2012-04-26 Thread Zhi Yong Wu
On Thu, Apr 26, 2012 at 5:27 PM, Stefan Hajnoczi wrote: > On Thu, Apr 26, 2012 at 9:11 AM,   wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >>  block/qcow2-snapshot.c |    2 +- >>  1 files changed, 1 insertions(+), 1 deletions(-) > > Checked that no callers depend on -ENOENT

Re: [Qemu-devel] [PATCH v2] pseries: Fix use of global CPU state

2012-04-26 Thread Alexander Graf
On 23.04.2012, at 19:27, Peter Portante wrote: > Commit ed120055c7f9b26b5707d3ceabbe5a3f06aaf937 (Implement PAPR VPA > functions for pSeries shared processor partitions) introduced the > register_dtl() function and typo "emv" as name of its argument. > This went unnoticed because the code in that

Re: [Qemu-devel] [PATCH] target-ppc: Some support for dumping TLB_EMB TLBs

2012-04-26 Thread Alexander Graf
On 24.04.2012, at 18:48, François Revol wrote: > Add mmubooke_dump_mmu(). > > TODO: Add printing of individual flags. > > Signed-off-by: François Revol agraf@lychee:/home/agraf/release/qemu> git pw am 'target-ppc: Some support for dumping TLB_EMB TLBs' WARNING: line over 80 characters #42: F

Re: [Qemu-devel] [PATCH 0/7] Fixes for s390

2012-04-26 Thread Alexander Graf
On 23.04.2012, at 11:52, Christian Borntraeger wrote: > Alex, > > here are some fixes for s390 kvm. > The reboot patches are fixes only and are not enough to have a fully working > reboot. > Additional infrastructure that completes reboot will come with a later > patch series. Thanks, applied a

Re: [Qemu-devel] [RFC 07/14] Drop darwin-user

2012-04-26 Thread Andreas Färber
Am 24.04.2012 16:37, schrieb Peter Maydell: > On 16 April 2012 15:31, Andreas Färber wrote: >> It's been orphaned, not compiling for a long time and despite Apple's >> drop of their Rosetta ppc emulation technology with Mac OS X Lion no one >> has stepped up to fix it. >> >> Testing necessary chan

Re: [Qemu-devel] [PATCH 4/7] [s390] reset avail and used index on reboot

2012-04-26 Thread Alexander Graf
On 23.04.2012, at 11:52, Christian Borntraeger wrote: > From: Jens Freimann > > reset the guest vring avail/used idx fields, otherwise it's possible > that old values remain in memory which would cause a reboot to fail > with a "Guest moved used index" message > > Signed-off-by: Jens Freimann

Re: [Qemu-devel] [PATCH] configure: Virtfs doesn't require libcap.

2012-04-26 Thread Kusanagi Kouichi
On 2012-04-25 14:20:12 -0500, Anthony Liguori wrote: > On 04/22/2012 05:16 AM, Kusanagi Kouichi wrote: > >Only proxy helper does. > > > >Signed-off-by: Kusanagi Kouichi > > This broke the build: > > http://spunk.home.kraxel.org/bb/builders/ubuntu-default/builds/52 I cannot see IPv6 only sites. C

Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default

2012-04-26 Thread Andreas Färber
Am 26.04.2012 12:30, schrieb Bernhard Walle: > Am 26.04.12 11:57, schrieb Andreas Färber: >> Fixes the build when combined with the drop of darwin-user. >> Enthusiasts can still try building it using --enable-bsd-user. >> >> Signed-off-by: Andreas Färber >> Cc: Bernhard Walle > > Thanks. I alrea

Re: [Qemu-devel] [SeaBIOS] [PATCH 11/12] Migrate 64bit entries to 64bit pci regions

2012-04-26 Thread Kevin O'Connor
On Wed, Apr 25, 2012 at 05:29:04PM +0200, Gerd Hoffmann wrote: > Issue #1: seabios can't boot from a virtio-scsi disk if the controller > is behind a pci bridge. I think the reason simply is that (according to > the seabios log) only root bus pci devices are initialized. Probably > even isn't re

Re: [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts

2012-04-26 Thread Riku Voipio
On 26 April 2012 14:53, Alexander Graf wrote: > Ok, changed to sizeof(void*). Since the patch is so trivial, I won't repost > it, but instead just send it out with my next pull request. That's fine from my side. Riku

Re: [Qemu-devel] [PATCH v2 00/22] PPC AREG0 conversion

2012-04-26 Thread Alexander Graf
On 22.04.2012, at 15:22, Blue Swirl wrote: > In this rebased version I pushed the exception helper conversion first. > > Helpers for cpu_{ld,st}_data are in common code. > > Two new bonus patches last. Thanks, applied all to ppc-next :). Alex

Re: [Qemu-devel] [PATCH] Fix SPI SD emulation

2012-04-26 Thread Igor Mitsyanko
On 04/26/2012 01:12 AM, Paul Brook wrote: When in SPI mode, we give a bogus response to CMD8 (part of the SD physical spec v2). Fixing this also makes most drivers also issue CMD58. Despite some skeleton code in hw/ssi-sd.c this isn't actually implemented in hw/sd.h. CMD58 is valid in both idl

Re: [Qemu-devel] [PATCH 0/2] Outstanding pseries updates

2012-04-26 Thread Alexander Graf
On 26.04.2012, at 05:55, David Gibson wrote: > Hi Alex, > > Here are a couple of patches that I sent to Andreas while you were > away, but he didn't feel quite confident to review and commit at the > time. > > The VIO address allocation patch, in particular, helps with a bunch of > libvirt prob

Re: [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts

2012-04-26 Thread Alexander Graf
On 19.04.2012, at 21:25, Stefan Weil wrote: > Am 19.04.2012 16:47, schrieb Peter Maydell: >> On 19 April 2012 15:23, Alexander Graf wrote: >>> On my PPC host, HOST_LONG_SIZE is not defined even after >>> running configure. Use the normal C way of determining the >>> long size instead. >>> #elif

[Qemu-devel] [PATCH] nbd: Fix uninitialised use of s->sock

2012-04-26 Thread Kevin Wolf
s->sock is assigned only afterwards, so we're really registering an aio_fd_handler for file descriptor 0 here. Not exactly what we intended. Signed-off-by: Kevin Wolf --- block/nbd.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/nbd.c b/block/nbd.c index 56dbf6e

Re: [Qemu-devel] [PATCH 1/9] hw/qxl.c: qxl_phys2virt: replace panics with guest_bug

2012-04-26 Thread Alon Levy
On Thu, Apr 26, 2012 at 10:15:27AM +0200, Gerd Hoffmann wrote: > On 04/25/12 11:13, Alon Levy wrote: > > Signed-off-by: Alon Levy > > Nice work! :) > > Applied all to spice patch queue. > > thanks, > Gerd >

Re: [Qemu-devel] chatty qxl vga mode

2012-04-26 Thread Alon Levy
On Wed, Apr 25, 2012 at 06:14:03PM +0200, Jan Kiszka wrote: > Hi, > > just played with qxl and noticed quite a lot of debug output on the > local console: > > do_spice_init: starting 0.10.1 > spice_server_add_interface: SPICE_INTERFACE_QXL > red_worker_main: begin > display_channel_create: create

Re: [Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-04-26 Thread Alexander Graf
On 09.02.2012, at 15:28, Kevin Wolf wrote: > Am 30.01.2012 23:29, schrieb Alexander Graf: >> When using Windows 8 with an AHCI disk drive, it issues a blue screen. >> The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not >> supported by our ATA implementation, but Windows expects it

[Qemu-devel] [PATCH] ATA: Allow WIN_SECURITY_FREEZE_LOCK as nop

2012-04-26 Thread Alexander Graf
When using Windows 8 with an AHCI disk drive, it issues a blue screen. The reason is that WIN_SECURITY_FREEZE_LOCK / CFA_WEAR_LEVEL is not supported by our ATA implementation, but Windows expects it to be there. Since without security stuff implemented, the lock would be a nop anyway and CFA_WEAR_

Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default

2012-04-26 Thread Bernhard Walle
Am 26.04.12 11:57, schrieb Andreas Färber: > Fixes the build when combined with the drop of darwin-user. > Enthusiasts can still try building it using --enable-bsd-user. > > Signed-off-by: Andreas Färber > Cc: Bernhard Walle Thanks. I already stumbled over this when trying to test your uint16 f

Re: [Qemu-devel] [PULL 00/14] usb patch queue

2012-04-26 Thread Gerd Hoffmann
Hi, > are available in the git repository at: > > git://git.kraxel.org/qemu usb.48 Updated pull at branch usb.49 Rebased to latest master, dropped this patch ... > usb-host: add timeout handler ... which caused a regression for Johannes Stezenbach. cheers, Gerd

Re: [Qemu-devel] [PATCH 14/14] usb-host: add timeout handler

2012-04-26 Thread Gerd Hoffmann
Hi, > When the "end" packet is received the actual flashing starts, > which can take minutes. The device will not ACK the packet > until flashing completes. Thus I now get an error from the > flash tool (while flashing completes on the device). > Qemu says: > > husb: urb timeout (5 secs, #1

Re: [Qemu-devel] [PATCH 2/2] virtio-serial-bus: Unset guest_connected at reset and driver reset

2012-04-26 Thread Michael S. Tsirkin
On Thu, Apr 26, 2012 at 12:52:24PM +0530, Amit Shah wrote: > When a guest driver resets the virtio status to not ready, or when qemu > is reset, reset all ports' guest_connected bit and let port users know > of this event if they have the guest_close() callback registered. > > Reviewed-by: Alon Le

[Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default

2012-04-26 Thread Andreas Färber
Fixes the build when combined with the drop of darwin-user. Enthusiasts can still try building it using --enable-bsd-user. Signed-off-by: Andreas Färber Cc: Bernhard Walle --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index dd09f1a

Re: [Qemu-devel] [PATCH 2/2] pseries: Use the same interrupt swizzling for host bridges as p2p bridges

2012-04-26 Thread Michael S. Tsirkin
On Thu, Apr 26, 2012 at 01:55:42PM +1000, David Gibson wrote: > Currently the pseries PCI code uses a somewhat strange scheme of PCI irq > allocation - one per slot up to a maximum that's greater than the usual 4. > This scheme more or less worked, because we were able to tell the guest the > irq m

Re: [Qemu-devel] [PATCH 14/14] usb-host: add timeout handler

2012-04-26 Thread Johannes Stezenbach
Hi, On Tue, Apr 24, 2012 at 05:51:31PM +0200, Gerd Hoffmann wrote: > Add a timeout handler. In case bulk transfers take too long to finish > the request will be canceled. The timeout is tunable via property, by > default it is 5 seconds. This patch causes an issue for my firmware download. The

Re: [Qemu-devel] [PATCH] qcow2: fix the return value -ENOENT -> -EEXIST

2012-04-26 Thread Kevin Wolf
Am 26.04.2012 11:27, schrieb Stefan Hajnoczi: > On Thu, Apr 26, 2012 at 9:11 AM, wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> --- >> block/qcow2-snapshot.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > Checked that no callers depend on -ENOENT. Looks g

[Qemu-devel] [PATCH 09/12] qxl: interface_notify_update: remove guest trigerrable abort

2012-04-26 Thread Gerd Hoffmann
From: Alon Levy Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann --- hw/qxl.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6e7232c..44ee495 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -768,8 +768,13 @@ static int interface_req_curs

  1   2   >