[Qemu-devel] [Bug 996798] Re: Incorrect order of task switching

2012-05-08 Thread Yury Popov
** Description changed: In Intel specifications (http://download.intel.com/design/processor/manuals/253668.pdf 7.3), we can see: - 8. Saves the state of the current (old) task in the current task’s + 8. Saves the state of the current (old) task in the current task’s TSS. …

[Qemu-devel] [Bug 996798] [NEW] Incorrect order of task switching

2012-05-08 Thread Юрий Попов
Public bug reported: In Intel specifications (http://download.intel.com/design/processor/manuals/253668.pdf 7.3), we can see: 8. Saves the state of the current (old) task in the current task’s TSS. … 11. Loads the task register with the segment selector and descriptor for the new task'

Re: [Qemu-devel] qemu-1.0-rc1 delayed (need fix for PPC32 build)

2012-05-08 Thread malc
On Tue, 8 May 2012, Anthony Liguori wrote: > Hi, > > I was hoping we'd have a solution by now but it looks like we don't. I'm > going to delay the qemu-1.0-rc1 release until tomorrow. I'd like to propose a > couple paths forward. Here's my understanding of the situation: > > 1) TCG changes we

[Qemu-devel] qemu-1.0-rc1 delayed (need fix for PPC32 build)

2012-05-08 Thread Anthony Liguori
Hi, I was hoping we'd have a solution by now but it looks like we don't. I'm going to delay the qemu-1.0-rc1 release until tomorrow. I'd like to propose a couple paths forward. Here's my understanding of the situation: 1) TCG changes were made for the Sparc/Alpha targets that use AREG0 2)

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 00/22] PPC AREG0 conversion

2012-05-08 Thread Andreas Färber
Am 09.05.2012 01:54, schrieb Andreas Färber: > Am 22.04.2012 15:22, schrieb Blue Swirl: >> In this rebased version I pushed the exception helper conversion first. >> >> Helpers for cpu_{ld,st}_data are in common code. >> >> Two new bonus patches last. >> >> URL git://repo.or.cz/qemu/blueswirl.git

Re: [Qemu-devel] [PATCH v2 for-1.1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Andreas Färber
Am 09.05.2012 02:43, schrieb malc: > On Wed, 9 May 2012, Andreas F?rber wrote: > >> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, >> based on patches by malc. >> >> Also adjust the registers clobbered, based on patch by Alex. > > Alexander, my head is splitting now, so i can n

Re: [Qemu-devel] [PATCH v2 for-1.1 0/4] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Am 09.05.2012 02:33, schrieb malc: > On Wed, 9 May 2012, Andreas F?rber wrote: > >> Here's an updated series to fix AREG0 and ppc build. >> >> Debian/sparc fsck on Darwin/ppc now succeeds. No regressions noticed with >> Debian/sparc, HelenOS/sparc64, Haiku/i386, Haiku/x86_64. > > If Alexander is

[Qemu-devel] [PATCH v2 for-1.1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Andreas Färber
Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, based on patches by malc. Also adjust the registers clobbered, based on patch by Alex. Signed-off-by: Andreas Färber --- tcg/ppc/tcg-target.c | 37 - 1 files changed, 36 insertions(+), 1 dele

Re: [Qemu-devel] [PATCH v2 for-1.1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread malc
On Wed, 9 May 2012, Andreas F?rber wrote: > Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, > based on patches by malc. > > Also adjust the registers clobbered, based on patch by Alex. Alexander, my head is splitting now, so i can not calculate things inside it, aren't we reser

Re: [Qemu-devel] [PATCH v2 for-1.1 0/4] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Wed, 9 May 2012, Andreas F?rber wrote: > Hello malc, > > Here's an updated series to fix AREG0 and ppc build. > > Debian/sparc fsck on Darwin/ppc now succeeds. No regressions noticed with > Debian/sparc, HelenOS/sparc64, Haiku/i386, Haiku/x86_64. > > Regards, > Andreas > > Cc: malc > Cc: A

[Qemu-devel] [PATCH v2 for-1.1 2/4] tcg/ppc: Don't hardcode register numbers

2012-05-08 Thread Andreas Färber
Also assure i64 alignment where necessary. Alignment code optimization suggested by malc. Signed-off-by: Andreas Färber --- tcg/ppc/tcg-target.c | 29 + 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c ind

[Qemu-devel] [PATCH v2 for-1.1 1/4] tcg/ppc: Do not overwrite lower address word on Darwin and AIX

2012-05-08 Thread Andreas Färber
From: Andreas Färber For targets where TARGET_LONG_BITS != 32, i.e. 64-bit guests, addr_reg is moved to r4. For hosts without TCG_TARGET_CALL_ALIGN_ARGS either data_reg2 or data_reg or a masked version thereof would overwrite r4. Place it in r5 instead, matching TCG_TARGET_CALL_ALIGN_ARGS hosts.

[Qemu-devel] [PATCH v2 for-1.1 3/4] tcg/ppc: Clobber r5 for 64-bit qemu_ld

2012-05-08 Thread Andreas Färber
This accounts for the additional addr_reg2 register. Signed-off-by: Andreas Färber --- tcg/ppc/tcg-target.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index b4e0466..20888e2 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/pp

[Qemu-devel] [PATCH v2 for-1.1 0/4] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Hello malc, Here's an updated series to fix AREG0 and ppc build. Debian/sparc fsck on Darwin/ppc now succeeds. No regressions noticed with Debian/sparc, HelenOS/sparc64, Haiku/i386, Haiku/x86_64. Regards, Andreas Cc: malc Cc: Alexander Graf v1 -> v2: * Drop _CALL_DARWIN fix that malc doesn't

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 00/22] PPC AREG0 conversion

2012-05-08 Thread Andreas Färber
Am 22.04.2012 15:22, schrieb Blue Swirl: > In this rebased version I pushed the exception helper conversion first. > > Helpers for cpu_{ld,st}_data are in common code. > > Two new bonus patches last. > > URL git://repo.or.cz/qemu/blueswirl.git > http://repo.or.cz/r/qemu/blueswirl.git Wi

Re: [Qemu-devel] Semantics of "-cpu host" (was Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest)

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 22:14, Eduardo Habkost wrote: > On Tue, May 08, 2012 at 02:58:11AM +0200, Alexander Graf wrote: >> On 07.05.2012, at 20:21, Eduardo Habkost wrote: >> >>> >>> Andre? Are you able to help to answer the question below? >>> >>> I would like to clarify what's the expected behavior

Re: [Qemu-devel] Re : [SeaBIOS] : Memory problem with Qemu/SeaBIOS

2012-05-08 Thread Kevin O'Connor
On Tue, May 08, 2012 at 09:47:56AM -0700, Alain Ribière wrote: > Thanks for your answer. > > Here is the debug log in attachement. > I disabled the debug on the screen shot I sent because I noticed I could get > a bit more memory without it. > With the debug on, I got : > Banked Window  416K at 3

[Qemu-devel] GlobalProperty in QEMUMachine overwrites explicit command line value

2012-05-08 Thread Crístian Viana
Hi, I'm trying to change the default value of the parameter "-rtc driftfix=" and something's going wrong. This is a GlobalProperty and, currently, it is equivalent to setting "-rtc driftfix=none" in the command line. I'm appending a new GlobalProperty value to all previous QEMUMachine instanc

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Wed, 9 May 2012, malc wrote: > On Tue, 8 May 2012, Andreas F?rber wrote: > > > Am 08.05.2012 22:28, schrieb malc: > > > On Tue, 8 May 2012, Andreas F?rber wrote: > > > > > >> What about the following? (untested) > > > > > > I'd much rather have the ifdefery scattered around the code than > >

Re: [Qemu-devel] [PATCH v2 0/2] QEMU copyright update

2012-05-08 Thread Andreas Färber
Am 02.05.2012 00:07, schrieb Andreas Färber: > Am 27.04.2012 12:08, schrieb Andreas Färber: >> Hello, >> >> For 1.0 I had brought up the issue that the copyright statement reads 2008. > > Ping for 1.1-rc0. Ping^2 for 1.1-rc1! Is this waiting on some legal department's review or just being forgott

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 22:28, schrieb malc: > > On Tue, 8 May 2012, Andreas F?rber wrote: > > > >> What about the following? (untested) > > > > I'd much rather have the ifdefery scattered around the code than > > having to remember what this function does, > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Am 08.05.2012 22:28, schrieb malc: > On Tue, 8 May 2012, Andreas F?rber wrote: > >> What about the following? (untested) > > I'd much rather have the ifdefery scattered around the code than > having to remember what this function does, The name was supposed to explain that. :) > but that's just

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 21:42, schrieb Alexander Graf: > > > > On 08.05.2012, at 21:29, Andreas F?rber wrote: > > > >> On patch 3/3 he didn't like my alignment macro. I don't have a better > >> one though, suggestions or patches welcome. Ideal might be some > >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Am 08.05.2012 21:42, schrieb Alexander Graf: > > On 08.05.2012, at 21:29, Andreas Färber wrote: > >> On patch 3/3 he didn't like my alignment macro. I don't have a better >> one though, suggestions or patches welcome. Ideal might be some >> ROUND_TO_ODD() macro, but the problem is that for Darwin

Re: [Qemu-devel] Semantics of "-cpu host" (was Re: [PATCH 2/2] Expose tsc deadline timer cpuid to guest)

2012-05-08 Thread Eduardo Habkost
On Tue, May 08, 2012 at 02:58:11AM +0200, Alexander Graf wrote: > On 07.05.2012, at 20:21, Eduardo Habkost wrote: > > > > > Andre? Are you able to help to answer the question below? > > > > I would like to clarify what's the expected behavior of "-cpu host" to > > be able to continue working on

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-05-08 Thread Wei-Ren Chen
IIRC, clang doesn't support global register yet. Do you configure QEMU to use TCI? What's the version of Clang and QEMU you're using? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/996303 Title: doe

[Qemu-devel] [Bug 732864] Re: groupadd: cannot lock /etc/gshadow; try again later.

2012-05-08 Thread de_mitt
*** This bug is a duplicate of bug 523896 *** https://bugs.launchpad.net/bugs/523896 ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 19:39, schrieb malc: > > On Tue, 8 May 2012, Alexander Graf wrote: > > > >> > >> On 07.05.2012, at 01:46, Andreas F?rber wrote: > >> > >>> Hello malc, > >>> > >>> This series fixes two long-standing issues on Darwin/ppc and, based on > >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Am 08.05.2012 19:39, schrieb malc: > On Tue, 8 May 2012, Alexander Graf wrote: > >> >> On 07.05.2012, at 01:46, Andreas F?rber wrote: >> >>> Hello malc, >>> >>> This series fixes two long-standing issues on Darwin/ppc and, based on your >>> second patch, fixes the AREG0 mode for Linux and Darwin a

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 21:29, Andreas Färber wrote: > Am 08.05.2012 20:09, schrieb Alexander Graf: >> >> On 08.05.2012, at 19:39, malc wrote: >> >>> On Tue, 8 May 2012, Alexander Graf wrote: >>> On 07.05.2012, at 01:46, Andreas F?rber wrote: > This series fixes two long-standing issu

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 21:34, Andreas Färber wrote: > Am 08.05.2012 19:43, schrieb Alexander Graf: >> >> On 08.05.2012, at 19:39, Alexander Graf wrote: >> >>> On 07.05.2012, at 01:46, Andreas Färber wrote: >>> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3. Automate the

[Qemu-devel] coroutine-ucontext broken for x86-32

2012-05-08 Thread Jan Kiszka
Hi, I hunted down a fairly subtle corruption of the VCPU thread signal mask in KVM mode when using the ucontext version of coroutines: coroutine_new calls getcontext, makecontext, swapcontext. Those functions get/set also the signal mask of the caller. Unfortunately, they only use the sigprocmask

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Andreas Färber
Am 08.05.2012 19:43, schrieb Alexander Graf: > > On 08.05.2012, at 19:39, Alexander Graf wrote: > >> On 07.05.2012, at 01:46, Andreas Färber wrote: >> >>> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3. >>> Automate the register numbering to avoid double-coding the two modes, >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Andreas Färber
Am 08.05.2012 20:09, schrieb Alexander Graf: > > On 08.05.2012, at 19:39, malc wrote: > >> On Tue, 8 May 2012, Alexander Graf wrote: >> >>> On 07.05.2012, at 01:46, Andreas F?rber wrote: >>> This series fixes two long-standing issues on Darwin/ppc and, based on your second patch, fixes

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 20:54, Christian Borntraeger wrote: >> Well, the only shortcomings I'm aware of of the external IPL are: >> >> * You lose the boot menu. All you get is "entry 0", "entry 1", etc. as the >> description is not part of the boot map >> * You can't choose different entries during

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Anthony Liguori
On 05/08/2012 07:32 AM, Christian Borntraeger wrote: On 04/05/12 20:12, Alexander Graf wrote: On 04.05.2012, at 16:02, Christian Borntraeger wrote: On 04/05/12 16:00, Christian Borntraeger wrote: An IPL (booting) on s390 of SCSI disks is done by a firmware component. Lets implement this sche

Re: [Qemu-devel] [PATCH 1/1] s390: IPL device for s390

2012-05-08 Thread Christian Borntraeger
> Well, the only shortcomings I'm aware of of the external IPL are: > > * You lose the boot menu. All you get is "entry 0", "entry 1", etc. as the > description is not part of the boot map > * You can't choose different entries during runtime. Doing a reboot of a VM > and selecting a differe

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 20:20, Alexander Graf wrote: > > On 08.05.2012, at 19:43, Alexander Graf wrote: > >> >> On 08.05.2012, at 19:39, Alexander Graf wrote: >> >>> >>> On 07.05.2012, at 01:46, Andreas Färber wrote: >>> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3.

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 19:43, Alexander Graf wrote: > > On 08.05.2012, at 19:39, Alexander Graf wrote: > >> >> On 07.05.2012, at 01:46, Andreas Färber wrote: >> >>> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3. >>> Automate the register numbering to avoid double-coding the two

[Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return

2012-05-08 Thread Luiz Capitulino
This is a valid condition when a command chooses to not emit a success response. Signed-off-by: Luiz Capitulino --- qemu-ga.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-ga.c b/qemu-ga.c index 216be39..3547119 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -488,8 +488,6 @@ static voi

[Qemu-devel] [PULL 3/6] runstate: introduce suspended state

2012-05-08 Thread Luiz Capitulino
QEMU enters in this state when the guest suspends to ram (S3). This is important so that HMP users and QMP clients can know that the guest is suspended. QMP also has an event for this, but events are not reliable and are limited (ie. a client can connect to QEMU after the event has been emitted).

[Qemu-devel] [PULL 5/6] hmp: expr_unary(): check for overflow in strtoul()/strtoull()

2012-05-08 Thread Luiz Capitulino
It's not checked currently, so something like: (qemu) balloon -10114334234 (qemu) Will just "work" (in this case the balloon command will get a random value). Fix it by checking if strtoul()/strtoull() overflowed. Signed-off-by: Luiz Capitulino Reviewed-by: Eric Blake ---

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 19:39, malc wrote: > On Tue, 8 May 2012, Alexander Graf wrote: > >> >> On 07.05.2012, at 01:46, Andreas F?rber wrote: >> >>> Hello malc, >>> >>> This series fixes two long-standing issues on Darwin/ppc and, based on your >>> second patch, fixes the AREG0 mode for Linux and D

[Qemu-devel] [PULL 4/6] vl: drop is_suspended variable

2012-05-08 Thread Luiz Capitulino
Check for the RUN_STATE_SUSPENDED state instead. Signed-off-by: Luiz Capitulino --- vl.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/vl.c b/vl.c index a7afc79..5e0080b 100644 --- a/vl.c +++ b/vl.c @@ -1293,7 +1293,6 @@ static pid_t shutdown_pid; static int powe

Re: [Qemu-devel] [PATCH 00/32] target-arm: refactor copro register implementation

2012-05-08 Thread Peter Maydell
On 8 May 2012 06:57, Rusty Russell wrote: > (Accidentally made first reply to Peter only, fixed that now). > > On Mon, 7 May 2012 13:25:07 +0100, Peter Maydell > wrote: >> On 7 May 2012 08:23, Rusty Russell wrote: >> > OK, I reviewed the infrastructure, and it looks excellent.  A few of >> > mi

Re: [Qemu-devel] ahci drive: how to make it non-bootable?

2012-05-08 Thread Michael Tokarev
On 08.05.2012 10:43, Gerd Hoffmann wrote: > Hi, > >>> bootindex=1 for virtio >> >> -drive file=winguest.raw,if=virtio,bootindex=1 -- >> >> this does not work: > > Oops. I through it does, but seems this is only the case for the old & > deprecated boot=on (and maybe even that only in qemu-kvm).

Re: [Qemu-devel] [PATCH for-1.1] scripts/qemu-binfmt-conf.sh: Fix shell syntax

2012-05-08 Thread Anthony Liguori
On 05/07/2012 12:47 PM, Andreas Färber wrote: The script is organized as a sequence of binfmt registrations, with a check whether the to be registered architecture matches the host. Add a missing fi for the SuperH section. Reported-by: Alexander Graf Signed-off-by: Andreas Färber Applied. Th

[Qemu-devel] [PULL 6/6] hmp: fix bad value conversion for M type

2012-05-08 Thread Luiz Capitulino
The M type converts from megabytes to bytes. However, the value can be negative before the conversion, which will lead to a flawed conversion. For example, this: (qemu) balloon -1011 (qemu) Just "works", but the value passed by the balloon command will be something else. This patc

[Qemu-devel] [PULL 2/6] qapi-schema.json: fix RunState enums alphabetical order

2012-05-08 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- qapi-schema.json |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 4279259..33f2f92 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -92,6 +92,8 @@ # # @debug: QEMU is running on a debug

[Qemu-devel] [PULL 1/6] wakeup on migration

2012-05-08 Thread Luiz Capitulino
From: Gerd Hoffmann Wakeup the guest when the live part of the migation is finished. This avoids being in suspended state on migration, so we don't have to save the is_suspended bit. Signed-off-by: Gerd Hoffmann Reviewed-by: Luiz Capitulino --- migration.c |1 + 1 file changed, 1 insertio

[Qemu-devel] [PULL 1.1 0/6]: QMP queue

2012-05-08 Thread Luiz Capitulino
This pull request contains the new 'suspended' RunState series, a related fix from Gerd and HMP fixes. The HMP fixes are not directly related to QMP, but are included in this pull request for my convenience (besides, HMP is becoming QMP front-end anyway). I can do a separate pull if needed, though

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Alexander Graf
On 08.05.2012, at 19:39, Alexander Graf wrote: > > On 07.05.2012, at 01:46, Andreas Färber wrote: > >> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3. >> Automate the register numbering to avoid double-coding the two modes, >> and introduce TCG_TARGET_CALL_ALIGN_I64_ARG() macr

Re: [Qemu-devel] [PATCH for-1.1] user-exec.c: Don't assert on segfaults for non-valid addresses

2012-05-08 Thread Anthony Liguori
On 05/03/2012 01:32 PM, Peter Maydell wrote: h2g() will assert if passed an address that's not a valid guest address, so handle_cpu_signal() needs to check before passing "data address which caused a segfault" to it, since for a misbehaving guest that could be anything. If the address isn't a val

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Alexander Graf wrote: > > On 07.05.2012, at 01:46, Andreas F?rber wrote: > > > Hello malc, > > > > This series fixes two long-standing issues on Darwin/ppc and, based on your > > second patch, fixes the AREG0 mode for Linux and Darwin and thus the ppc > > build. > > > > Co

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 3/3] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread Alexander Graf
On 07.05.2012, at 01:46, Andreas Färber wrote: > Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3. > Automate the register numbering to avoid double-coding the two modes, > and introduce TCG_TARGET_CALL_ALIGN_I64_ARG() macro to align for SVR4 > but not for Darwin ABI. > > Based o

Re: [Qemu-devel] [PATCH for-1.1] qemu-timer: Move include for __FreeBSD_version to header

2012-05-08 Thread Anthony Liguori
On 05/05/2012 01:08 PM, Andreas Faerber wrote: sys/param.h is needed for __FreeBSD_version. Pointed out by Juergen, thanks. Signed-off-by: Andreas Faerber Cc: Juergen Lock Applied. Thanks. Regards, Anthony Liguori --- qemu-timer.c |4 qemu-timer.h |4 2 files changed

Re: [Qemu-devel] [PATCH for-1.1] cpu: Update documentation and comment

2012-05-08 Thread Anthony Liguori
On 05/02/2012 03:28 PM, Andreas Färber wrote: State struct CPU had been renamed to CPUState, former CPUState to CPUArchState. Signed-off-by: Andreas Färber Applied. Thanks. Regards, Anthony Liguori --- include/qemu/cpu.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) di

Re: [Qemu-devel] [PATCH for-1.1 0/2] configure: Cosmetic VirtFS fix

2012-05-08 Thread Anthony Liguori
On 04/30/2012 06:12 PM, Andreas Färber wrote: Hello, I recently noticed that lack of VirtFS support leads to configure printing just "VirtFS support". This mini-series fixes it to say "VirtFS support no". I'm not sure if we have a definitive Coding Style for shell scripts (or Python code for

Re: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code

2012-05-08 Thread Anthony Liguori
On 05/03/2012 11:09 AM, Stefan Weil wrote: Code which is compiled with CONFIG_TCG_DEBUG (set by configure option --enable-debug-tcg) should not disable the assert macro by defining NDEBUG. With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c were completely useless because NDEBUG

[Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-disk completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

[Qemu-devel] [PATCH 1/6] qapi: add support for command options

2012-05-08 Thread Luiz Capitulino
Options allow for changes in commands behavior. This commit introduces the QCO_NO_SUCCESS_RESP option, which causes a command to not emit a success response. This is needed by commands such as qemu-ga's guest-shutdown, which may not be able to complete before the VM vanishes. In this case, it's us

[Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-shutdown completes. This happens because the VM may vanish before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check for

[Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-ram completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should check

[Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: don't emit a success response

2012-05-08 Thread Luiz Capitulino
Today, qemu-ga may not be able to emit a success response when guest-suspend-hybrid completes. This happens because the VM may suspend before qemu-ga is able to emit a response. This semantic is a bit confusing, as it's not clear for clients if they should wait for a response or how they should ch

[Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands

2012-05-08 Thread Luiz Capitulino
This series changes qemu-ga to not emit a success response for commands guest-shutdown and guest-suspend-{ram,disk,hybrid}. More details and the reason for this change can be found in the following patches. V2 o Rename option_is_enabled() to option_value_matches() [Michael] o Improve guest-shutdo

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread Alexander Graf
On 07.05.2012, at 01:46, Andreas Färber wrote: > Hello malc, > > This series fixes two long-standing issues on Darwin/ppc and, based on your > second patch, fixes the AREG0 mode for Linux and Darwin and thus the ppc > build. > > Compared to your last patch I have tried to avoid the { int ir; }

Re: [Qemu-devel] KVM call agenda for May, Tuesday 8th

2012-05-08 Thread Andreas Färber
Am 08.05.2012 16:24, schrieb Anthony Liguori: > On 05/08/2012 09:10 AM, Andreas Färber wrote: >> Am 07.05.2012 14:54, schrieb Anthony Liguori: >> rc0 is available, but patches submitted for 1.1 shortly before rc0 >> neither got review nor were applied. Neither did pulls or patches >> applied by Ant

[Qemu-devel] [PATCH 1.1 14/22] stream: add testcase for partial streaming

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/030 | 27 ++- tests/qemu-iotests/030.out |4 ++-- 2 file changed, 28 insertions(+), 3 deletion(-) diff --git a/tests/qemu-iotests/030.out b/tests/qemu-iotests/030.out index 0d2f87b..0aa7a0a 100644 --- a/tests/q

[Qemu-devel] [PATCH 1.1 12/22] qemu-io: fix the alloc command

2012-05-08 Thread Paolo Bonzini
Because sector_num is not updated, the loop would either go on forever or return garbage. Signed-off-by: Paolo Bonzini --- qemu-io.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index b48364f..5882067 100644 --- a/qemu-io.c +++ b/qemu-io.

[Qemu-devel] [PATCH 1.1 07/22] block: simplify path_is_absolute

2012-05-08 Thread Paolo Bonzini
On Windows, all the logic is already in is_windows_drive and is_windows_drive_prefix. On POSIX, there is no need to look out for colons. The win32 code changes the behaviour in some cases, we could have something like "d:foo.img". The old code would treat it as relative path, the new one as absol

[Qemu-devel] [PATCH 1.1 19/22] block: implement is_allocated for raw

2012-05-08 Thread Paolo Bonzini
Either FIEMAP, or SEEK_DATA+SEEK_HOLE can be used to implement the is_allocated callback for raw files. Ext4, btrfs and XFS all support it. Signed-off-by: Paolo Bonzini --- block/raw-posix.c | 102 + block/raw.c |8 + 2 files ch

[Qemu-devel] [PATCH 1.1 08/22] block: protect path_has_protocol from filenames with colons

2012-05-08 Thread Paolo Bonzini
path_has_protocol will erroneously return "true" if the colon is part of a filename. These names are common with stable device names produced by udev. We cannot fully protect against this in case the filename does not have a path component (e.g. if the current directory is /dev/disk/by-path), but

[Qemu-devel] [PATCH 1.1 15/22] stream: pass new base image format to bdrv_change_backing_file

2012-05-08 Thread Paolo Bonzini
When an image is modified to point to the new backing file, the backing file format is set to NULL, which means auto-probe. This is wrong, in fact it is a small security problem. Reviewed-by: Kevin Wolf Signed-off-by: Paolo Bonzini --- block/stream.c |7 +-- 1 file changed, 5 insertion

[Qemu-devel] [PATCH v4 5/7] trace: [default] Use new event control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- trace/default.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace/default.c b/trace/default.c index c9b27a2..3c41990 100644 --- a/trace/default.c +++ b/trace/default.c @@ -1,7 +1,7 @@ /* * Default implementation for backend ini

Re: [Qemu-devel] [PATCH v2] softfloat: float32_to_float16() should do inexact instead of underflow for rounding case

2012-05-08 Thread Peter Maydell
On 3 May 2012 15:37, Alexey Starikovskiy wrote: > IEEE Standard for Floating-Point Arithmetic: > 7.5 Underflow > The underflow exception shall be signaled when a tiny non-zero result > is detected. For binary formats, this > shall be either: > a) after rounding — when a non-zero result computed as

[Qemu-devel] [PATCH 1.1 13/22] stream: fix sectors not allocated test

2012-05-08 Thread Paolo Bonzini
The test on sectors not allocated can fail if the L1/L2 tables are not on disk yet. Allow tests to shutdown the VM early. Signed-off-by: Paolo Bonzini --- tests/qemu-iotests/030|1 + tests/qemu-iotests/iotests.py | 10 ++ 2 files changed, 7 insertions(+), 4 deletions(-) d

[Qemu-devel] [PATCH 1.1 18/22] stream: do not copy unallocated sectors from the base

2012-05-08 Thread Paolo Bonzini
Unallocated sectors should really never be accessed by the guest, so there's no need to copy them during the streaming process. If they are read by the guest during streaming, guest-initiated copy-on-read will copy them (we're in the base == NULL case, which enables copy on read). If they are read

[Qemu-devel] [PATCH 1.1 20/22] stream: tweak usage of bdrv_co_is_allocated

2012-05-08 Thread Paolo Bonzini
is_allocated_base has complex semantics that are not really usable outside streaming. Split the check in two parts, where the allocated state for the top bs is moved to the caller. The resulting function is more generally useful. Signed-off-by: Paolo Bonzini --- Starting from this patch

[Qemu-devel] [PATCH 1.1 17/22] stream: fix ratelimiting corner case

2012-05-08 Thread Paolo Bonzini
This fixes inability to make progress in streaming if the quota is set to less than the amount of data that an I/O operation has to write. In this case, limit->dispatched + n will always be above the quota and, due to the "goto retry" to recheck cancellation and allocation, streaming will livelock

[Qemu-devel] [PATCH v4 4/7] trace: [monitor] Use new event control interface

2012-05-08 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- monitor.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/monitor.c b/monitor.c index 8946a10..86c2538 100644 --- a/monitor.c +++ b/monitor.c @@ -625,10 +625,19 @@ static void do_trace_event_set_state(Monitor *mon, const QD

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Paolo Bonzini
Il 08/05/2012 16:49, Anthony Liguori ha scritto: > On 05/08/2012 09:43 AM, Avi Kivity wrote: >> On 05/08/2012 05:40 PM, Anthony Liguori wrote: >>> On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: h

[Qemu-devel] [PATCH 1.1 06/22] block: wait for job callback in block_job_cancel_sync

2012-05-08 Thread Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be kept. Even streaming has a very small race window where you could cancel a job and have it report completion. If this window is hit, bdrv_change_backing_file() will yield and possibly cause accesses to dangling pointers etc. So

[Qemu-devel] [PATCH 1.1 03/22] block: do not reuse the backing file across bdrv_close/bdrv_open

2012-05-08 Thread Paolo Bonzini
This is another bug caused by not doing a full cleanup of the BDS across close/open. This was found with mirroring by Shaolong Hu, but it can probably be reproduced also with eject or change. Signed-off-by: Paolo Bonzini --- block.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/block

[Qemu-devel] [PATCH 1.1 10/22] qemu-img: make "info" backing file output correct and easier to use

2012-05-08 Thread Paolo Bonzini
qemu-img info should use the same logic as qemu when printing the backing file path, or debugging becomes quite tricky. We can also simplify the output in case the backing file has an absolute path or a protocol. Signed-off-by: Paolo Bonzini --- block.c| 19 +++ block.h

Re: [Qemu-devel] [PULL 1.1 0/6] Missing patches for QEMU 1.1

2012-05-08 Thread Anthony Liguori
On 05/03/2012 12:14 AM, Stefan Weil wrote: Hi Anthony, here are some of my patches which were not committed up to now, but which should be included in QEMU 1.1. Only the last one (qemu-timer, which did not get any review up to now) is w32 related. The first one was discussed a lot, but then for

Re: [Qemu-devel] [PULL 0/5] Block patches for 1.1

2012-05-08 Thread Anthony Liguori
On 05/07/2012 12:55 PM, Kevin Wolf wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anth

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Anthony Liguori
On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/ac97: Mask out the EAPD bit on Powerdown Ctrl/Stat writes (2012-05-07 16:31:40 +0400) Pulled. Thanks. Regards, Anthony Liguori are available in the git re

Re: [Qemu-devel] [PULL 00/14] SCSI changes for 1.1

2012-05-08 Thread Anthony Liguori
On 05/04/2012 03:45 AM, Paolo Bonzini wrote: Anthony, the following changes since commit f05ae5379e40f81a6c8526d891693af8bf6e62da: Bail out if CONFIG_TCG_PASS_AREG0 is defined (2012-05-03 15:48:49 +0400) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next

Re: [Qemu-devel] [PULL 00/12] spice patch queue

2012-05-08 Thread Anthony Liguori
On 05/03/2012 03:53 AM, Gerd Hoffmann wrote: Hi, Here comes the spice patch queue. Nothing major. Most patches make qxl robust against guest bugs, by making qxl logging a message and raising an error IRQ instead of calling abort(). And a few other bugfixes. Pulled. Thanks. Regards, An

Re: [Qemu-devel] [PATCH 0/2] [PULL 1.1] linux-user fixes for 1.1

2012-05-08 Thread Anthony Liguori
On 05/03/2012 10:15 AM, riku.voi...@linaro.org wrote: From: Riku Voipio The following fixes since commit f05ae5379e40f81a6c8526d891693af8bf6e62da: Bail out if CONFIG_TCG_PASS_AREG0 is defined (2012-05-03 15:48:49 +0400) are available in the git repository at: git://git.linaro.org/people

Re: [Qemu-devel] [PULL] rtl8139 bugfix

2012-05-08 Thread Avi Kivity
On 05/08/2012 05:49 PM, Anthony Liguori wrote: > On 05/08/2012 09:43 AM, Avi Kivity wrote: >> On 05/08/2012 05:40 PM, Anthony Liguori wrote: >>> On 05/08/2012 09:20 AM, Michael S. Tsirkin wrote: The following changes since commit 847c25d01cbe8e4fe457a7426f82daaaf3287aae: hw/

Re: [Qemu-devel] [PATCH 1/1 v3] Allow machines to configure the QEMU_VERSION that's exposed via hardware

2012-05-08 Thread Crístian Viana
On 27-04-2012 20:14, Crístian Viana wrote: On 27-04-2012 18:23, Peter Maydell wrote: That appears to contain one of your older versions of this patch, not v3. (It touches bsd-user/main.c, for example.) -- PMM You were right, it was an older version. Now the branch is updated and rebased agains

[Qemu-devel] [PATCH 1.1 21/22] stream: move is_allocated_above to block.c

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c| 49 + block.h|4 block/stream.c | 53 ++--- 3 files changed, 55 insertions(+), 51 deletions(-) diff --git a/block.c b/block.c ind

[Qemu-devel] [PATCH 1.1 16/22] stream: fix HMP block_job_set_speed

2012-05-08 Thread Paolo Bonzini
The change of the argument name from value to speed was not propagated there. Signed-off-by: Paolo Bonzini --- hmp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hmp.c b/hmp.c index eb96618..645f873 100644 --- a/hmp.c +++ b/hmp.c @@ -847,7 +847,7 @@ void hmp_block_job_s

[Qemu-devel] [PATCH 1/2] qtest: Add function to send QMP commands

2012-05-08 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- tests/libqtest.c | 123 ++ tests/libqtest.h | 17 +++ 2 files changed, 113 insertions(+), 27 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 295c6d4..6d333ef 100644 --- a/tests/libqtest.c

[Qemu-devel] [PATCH 2/2] qtest: Add floppy test

2012-05-08 Thread Kevin Wolf
Let's start with testing media change. Signed-off-by: Kevin Wolf --- tests/Makefile |2 + tests/fdc-test.c | 186 ++ 2 files changed, 188 insertions(+), 0 deletions(-) create mode 100644 tests/fdc-test.c diff --git a/tests/Makefile b/t

[Qemu-devel] [PATCH 0/2] qtest: Add floppy media change test

2012-05-08 Thread Kevin Wolf
Kevin Wolf (2): qtest: Add function to send QMP commands qtest: Add floppy test tests/Makefile |2 + tests/fdc-test.c | 186 ++ tests/libqtest.c | 123 tests/libqtest.h | 17 + 4 files chang

[Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED

2012-05-08 Thread Paolo Bonzini
QED's opaque data includes a pointer back to the BlockDriverState. This breaks when bdrv_append shuffles data between bs_new and bs_top. To avoid this, add a "rebind" function that tells the driver about the new relationship between the BlockDriverState and its opaque. The patch also adds rebind t

[Qemu-devel] [PATCH 1.1 22/22] stream: move rate limiting to a separate header file

2012-05-08 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block/stream.c | 31 ++-- include/qemu/ratelimit.h | 50 ++ 2 files changed, 52 insertions(+), 29 deletions(-) create mode 100644 include/qemu/ratelimit.h diff --git a/block/stream

[Qemu-devel] [Bug 996303] Re: does not work with clang

2012-05-08 Thread Stevan Vucenovic
This one does not compile: ./configure --prefix=/usr/local/Cellar/qemu/1.0.1 --cc=/usr/bin/clang --host-cc=/usr/bin/clang --disable-darwin-user --enable-cocoa --disable- bsd-user --disable-guest-agent > In file included from > /private/tmp/homebrew-qemu-1.0.1-CpcD/qemu-1.0.1/target-i386/op_helpe

  1   2   >