Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-05-16 Thread Paolo Bonzini
> Am 03.04.2012 15:05, schrieb Paolo Bonzini: > > Il 03/04/2012 14:28, Jan Kiszka ha scritto: > if (object_property_get_type(OBJECT(dev), legacy_name, > NULL)) { > value = object_property_get_str(OBJECT(dev), > legacy_name, &err); > >>

[Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread Pavel Dovgaluk
Prevent disk data loss when closing qemu window. Signed-off-by: Pavel Dovgalyuk --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 23ab3a3..b6cfd29 100644 --- a/vl.c +++ b/vl.c @@ -3650,10 +3650,10 @@ int main(int argc, char **argv, char **envp)

Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree

2012-05-16 Thread Paolo Bonzini
- Messaggio originale - > Da: "Paolo Bonzini" > A: "Andreas Färber" > Cc: "Jan Kiszka" , aligu...@us.ibm.com, > qemu-devel@nongnu.org > Inviato: Mercoledì, 16 maggio 2012 9:40:12 > Oggetto: Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in > info qtree > > > Am 03.04.2

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-16 Thread nicolas.sauzede
> Yes, it's entirely intentional to prevent io handlers from accessing CPUState. > > For what you're doing, you need to hook more deeply into target-arm before > the > dispatch actually happens. Ok, but then I guess that this kind of hooks may be less generic than the traditional "io_handler"

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-16 Thread nicolas.sauzede
> First, please don't top-post and please don't use HTML emails. Sorry about that. > Yes, there is work towards getting rid of implicit AREG0 env. This will > be leading towards removing the register-pinned AREG0. Will this AREG0 removal be optional/configurable if the patches hit the mainstrea

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-16 Thread Zhi Hui Li
On 2012年05月15日 17:27, Paolo Bonzini wrote: Il 15/05/2012 11:17, Li Zhi Hui ha scritto: Signed-off-by: Paolo Bonzini Signed-off-by: Li Zhi Hui --- hw/fdc.c | 313 + 1 files changed, 210 insertions(+), 103 deletions(-) To reviewers,

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Paolo Bonzini
Il 15/05/2012 23:00, Michael S. Tsirkin ha scritto: > On Tue, May 15, 2012 at 04:26:39PM +0100, Anthony PERARD wrote: >> In the context of PV-on-HVM under Xen, the emulated nics are supposed to be >> unplug before the guest drivers are initialized. This mean that there must be >> unplug without the

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > Il 15/05/2012 23:00, Michael S. Tsirkin ha scritto: > > On Tue, May 15, 2012 at 04:26:39PM +0100, Anthony PERARD wrote: > >> In the context of PV-on-HVM under Xen, the emulated nics are supposed to be > >> unplug before the guest driv

Re: [Qemu-devel] [PATCH 04/21] qom: make Object a type

2012-05-16 Thread Andreas Färber
Am 02.05.2012 13:30, schrieb Paolo Bonzini: > Right now the base Object class has a special NULL type. Change this so > that we will be able to add class_init and class_base_init callbacks. > To do this, remove some special casing of ObjectClass that is not really > necessary. > > Signed-off-by:

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread dunrong huang
What's the difference of these two method to call bdrv_close_all? If you close qemu window, the main_loop will return immediately, and call bdrv_close_all. 2012/5/16 Pavel Dovgaluk > Prevent disk data loss when closing qemu window. > > Signed-off-by: Pavel Dovgalyuk > --- > vl.c |2 +- >

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-16 Thread Fabien Chouteau
On 05/16/2012 05:50 AM, Andreas Färber wrote: > Am 15.05.2012 18:08, schrieb Fabien Chouteau: >> On 05/15/2012 03:31 PM, Andreas Färber wrote: >>> Am 15.05.2012 11:39, schrieb Fabien Chouteau: Do not call cpu_dump_state if logfile is NULL. >>> >>> And where is log_cpu_state() being called from

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: >> On Xen the PV drivers can ask the firmware to surprise-remove the >> emulated NICs. > > So driver tells firmware (meaning acpi? how?) that it's ok > to do surprize removal? It w

[Qemu-devel] A error abou t gtester-report, can anyone help me, thank you !

2012-05-16 Thread Zhi Hui Li
When I use gtest. Compiler did not have a problem, the use of gtester implementation and generate xml file testlog also no problem, but in the use of gterster-report, the output is as follows: gtester-report test.log > test-report.html Traceback (most recent call last): File "/usr/bin/gt

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 10:23, Zhi Hui Li ha scritto: > > Yes , I think maybe Paolo is right. > > Because the spec is incredibly complex and obscure and I am newer. > To write the whole code's qtest beyond my ability. I am afraid I can't > finish it. so I want only do a qtest about basic read/write in PIO

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-16 Thread Zhi Hui Li
On 2012年05月15日 17:38, Paolo Bonzini wrote: Il 15/05/2012 11:33, Kevin Wolf ha scritto: which blindly overwrites status2. Hence the new code was not written based on it. However, the new code is untested as far as I know. In the thread of an earlier version of this series, I said that a qtest

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-16 Thread Andreas Färber
Am 15.05.2012 17:16, schrieb Igor Mammedov: > On Thu, May 10, 2012 at 02:13:38AM +0200, Andreas Färber wrote: >> target-i386: Pass X86CPU to do_cpu_{init,sipi}() >> target-i386: Let cpu_x86_init() return X86CPU >> pc: Use cpu_x86_init() to obtain X86CPU >> pc: Pass X86CPU to pc_cpu_reset()

Re: [Qemu-devel] [PATCH 1.1] linux-user: Fix stale tbs after mmap

2012-05-16 Thread Riku Voipio
On Tue, May 15, 2012 at 04:32:51PM -0500, Anthony Liguori wrote: > Riku, > > Can you review/ack this patch? Acked-by: Riku Voipio Are there any other Linux-user patches to consider for 1.1 ? > > Regards, > > Anthony Liguori > > > On 05/15/2012 03:35 PM, Peter Maydell wrote: > >Ping? This i

Re: [Qemu-devel] [PATCH 1.1] linux-user: Fix stale tbs after mmap

2012-05-16 Thread Andreas Färber
Am 16.05.2012 11:26, schrieb Riku Voipio: > On Tue, May 15, 2012 at 04:32:51PM -0500, Anthony Liguori wrote: >> Riku, >> >> Can you review/ack this patch? > > Acked-by: Riku Voipio > > Are there any other Linux-user patches to consider for 1.1 ? I had noticed that Alex' binfmt wrappers did not

[Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-16 Thread Daniel P. Berrange
From: "Daniel P. Berrange" After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest has reacted to this request. The virtio-balloon backend knows exactly when the guest has reacted though, and thus it is possible to emit a JSON eve

Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu

2012-05-16 Thread Pavel Dovgaluk
I use qemu under Windows and it has two windows when executes - console and SDL ones. When I close SDL window main loop function terminates correctly, and when I close console window to terminate qemu then the code after main loop is not executed. Pavel Dovgaluk From: dunrong huang [mailto:rie

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Stefano Stabellini
On Wed, 16 May 2012, Paolo Bonzini wrote: > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > >> On Xen the PV drivers can ask the firmware to surprise-remove the > >> emulated NICs. > > > > So driver tells firmware (meaning ac

[Qemu-devel] [PATCH 1.1] virtio: check virtio_load return code

2012-05-16 Thread Paolo Bonzini
From: Orit Wassermann Otherwise we crash on error. Signed-off-by: Ulrich Obergfell Signed-off-by: Orit Wassermann Signed-off-by: Paolo Bonzini --- hw/virtio-balloon.c|6 +- hw/virtio-blk.c|7 ++- hw/virtio-net.c|6 +- hw/virtio-scsi.c |7

Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX

2012-05-16 Thread Christian Borntraeger
On 03/05/12 16:33, Peter Maydell wrote: > On 3 May 2012 15:27, Christian Borntraeger wrote: >> commit 17df768c1e4580f03301d18ea938d3557d441911 >>load_image_targphys() should enforce the max size >> >> caused some problems with external kernel and specific ram sizes on s390: >> >> We load the e

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > On Wed, 16 May 2012, Paolo Bonzini wrote: > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > > >> On Xen the PV drivers can ask the firmware to surprise-

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Stefano Stabellini
On Tue, 15 May 2012, Michael S. Tsirkin wrote: > On Tue, May 15, 2012 at 04:26:36PM +0100, Anthony PERARD wrote: > > This hotplug state will be used to remove a device without the guest > > cooperation. > > > > Signed-off-by: Anthony PERARD > > This can crash guest, can't it? If you are fine wit

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Stefano Stabellini
On Wed, 16 May 2012, Michael S. Tsirkin wrote: > On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > > On Wed, 16 May 2012, Paolo Bonzini wrote: > > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: > > > > On Wed, May 16, 2012 at 10:06:25AM +0200, Paolo Bonzini wrote: > > > >

[Qemu-devel] [PATCH 1.1 2/4] virtio-blk: blockdev_mark_auto_del is transport-independent

2012-05-16 Thread Paolo Bonzini
Move it from virtio_blk_exit_pci to virtio_blk_exit. This is included here because the next patch removes proxy->block. Signed-off-by: Paolo Bonzini --- hw/virtio-blk.c |1 + hw/virtio-pci.c |1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio-blk.c b/hw/virtio-b

[Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support

2012-05-16 Thread Paolo Bonzini
Previous versions of these patches have been posted already, but they were lost. Sorry for realizing this quite late. VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* SCSI requests, not *execute* them. So it should always be enabled, and the scsi=on/off property tied to a separ

[Qemu-devel] [PATCH 1.1 3/4] virtio-blk: define VirtIOBlkConf

2012-05-16 Thread Paolo Bonzini
We will have to add another field to the virtio-blk configuration in the next patch. Avoid a proliferation of arguments to virtio_blk_init. Signed-off-by: Paolo Bonzini --- hw/s390-virtio-bus.c |7 +++ hw/s390-virtio-bus.h |4 ++-- hw/virtio-blk.c | 27 +--

[Qemu-devel] [PATCH 1.1 1/4] virtio-blk: report non-zero status when failing SG_IO requests

2012-05-16 Thread Paolo Bonzini
Linux really looks only at scsi->errors for SG_IO requests; it does not look at the virtio request status at all. Because of this, when a SG_IO request is failed early with virtio_blk_req_complete(req, VIRTIO_BLK_S_UNSUPP), without writing hdr.status, it will look like a success to the guest. Thi

[Qemu-devel] [PATCH 1.1 4/4] virtio-blk: always enable VIRTIO_BLK_F_SCSI

2012-05-16 Thread Paolo Bonzini
VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* SCSI requests, not *execute* them. You could run QEMU with scsi=on and a file-backed disk, and QEMU would fail all SCSI requests even though it advertises VIRTIO_BLK_F_SCSI. Because we need to do this to fix a migration compatibil

Re: [Qemu-devel] [PATCH 2/3 v6] Replace bdrv_* to bdrv_aio_* functions in DMA mode in fdc.c

2012-05-16 Thread Kevin Wolf
Am 16.05.2012 10:23, schrieb Zhi Hui Li: > On 2012年05月15日 17:38, Paolo Bonzini wrote: >> Il 15/05/2012 11:33, Kevin Wolf ha scritto: > which blindly overwrites status2. Hence the new code was not written > based on it. However, the new code is untested as far as I know. >>> In the thread

Re: [Qemu-devel] [PATCH 1.1] tests: Add rtc-test (fix test regression)

2012-05-16 Thread Kevin Wolf
Am 16.05.2012 06:07, schrieb Andreas Färber: > Am 15.05.2012 18:19, schrieb Stefan Weil: >> Commit 93e9eb6808c886f5f1c903b7ced1eed65de2ba39 added fdc-test, >> but accidentally removed rtc-test because check-qtest-i386-y was >> not enhanced but set twice. >> >> This patch adds rtc-test again (and so

Re: [Qemu-devel] [PATCH v3 3/8] kvm: Introduce basic MSI support for in-kernel irqchips

2012-05-16 Thread Jan Kiszka
On 2012-05-16 00:27, Marcelo Tosatti wrote: > On Thu, May 10, 2012 at 06:02:52PM -0300, Jan Kiszka wrote: >> This patch basically adds kvm_irqchip_send_msi, a service for sending >> arbitrary MSI messages to KVM's in-kernel irqchip models. >> >> As the current KVI API requires us to establish a sta

Re: [Qemu-devel] [Xen-devel] [PATCH V8 RESEND 2/8] configure: Introduce --enable-xen-pci-passthrough.

2012-05-16 Thread Konrad Rzeszutek Wilk
On Mon, May 14, 2012 at 11:49:46AM +0100, Anthony PERARD wrote: > On Sat, May 12, 2012 at 2:42 AM, Konrad Rzeszutek Wilk > wrote: > > > > I thought I reviewed this last time? Is there a reason for not > > attaching 'Reviewed-by: Konrad Rzeszutek Wilk > > ' on this patch? > > Yes, one: you reviewe

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Anthony PERARD
On Wed, May 16, 2012 at 11:32 AM, Stefano Stabellini wrote: > On Tue, 15 May 2012, Michael S. Tsirkin wrote: >> On Tue, May 15, 2012 at 04:26:36PM +0100, Anthony PERARD wrote: >> > This hotplug state will be used to remove a device without the guest >> > cooperation. >> > >> > Signed-off-by: Antho

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 13:15, Anthony PERARD ha scritto: >> > qdev_unplug(&(d->qdev), NULL); >> > +qdev_free(&(d->qdev)); >> > } >> > } >> > >> > >> > Anthony, can you confirm that this solves the problem for you? > This work until I try to hotplug a new device to the guest at wish > po

Re: [Qemu-devel] [Xen-devel] [PATCH V11 3/8] Introduce XenHostPCIDevice to access a pci device on the host.

2012-05-16 Thread Konrad Rzeszutek Wilk
On Tue, Apr 03, 2012 at 04:32:38PM +0100, Anthony PERARD wrote: > Signed-off-by: Anthony PERARD Looks good, thought I've just couple of tiny comments: > +#define XEN_HOST_PCI_RESSOURCE_BUFFER_SIZE 512 You might want a comment explaining why 512, and not a more precise number like 741. > +{ .. s

[Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. Feeding randomness from host's /dev/urandom into the guest is sufficient, so this i

[Qemu-devel] [PATCH] kvm: update vmxcap for EPT A/D, INVPCID, RDRAND, VMFUNC

2012-05-16 Thread Avi Kivity
Signed-off-by: Avi Kivity --- scripts/kvm/vmxcap | 13 + 1 file changed, 13 insertions(+) diff --git a/scripts/kvm/vmxcap b/scripts/kvm/vmxcap index a74ce71..cbe6440 100755 --- a/scripts/kvm/vmxcap +++ b/scripts/kvm/vmxcap @@ -22,6 +22,7 @@ MSR_IA32_VMX_TRUE_PINBASED_CTLS = 0x48D

Re: [Qemu-devel] [Xen-devel] [PATCH V11 5/8] Introduce Xen PCI Passthrough, qdevice (1/3)

2012-05-16 Thread Konrad Rzeszutek Wilk
> +void xen_pt_log(const PCIDevice *d, const char *f, ...) > +{ > +va_list ap; > + > +va_start(ap, f); > +if (d) { > +fprintf(stderr, "[%02x:%02x.%x] ", pci_bus_num(d->bus), %d at the end and in the other location pls fix it up.. > +PCI_SLOT(d->devfn), PCI_FUNC

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 13:30, Amit Shah ha scritto: > hw-obj-$(CONFIG_VIRTIO) += virtio-console.o > +hw-obj-$(CONFIG_VIRTIO) += virtio-rng.o This needs to be conditional on CONFIG_LINUX too. Paolo

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Anthony PERARD
On Wed, May 16, 2012 at 12:23 PM, Paolo Bonzini wrote: > Il 16/05/2012 13:15, Anthony PERARD ha scritto: >>> >         qdev_unplug(&(d->qdev), NULL); >>> > +        qdev_free(&(d->qdev)); >>> >     } >>> >  } >>> > >>> > >>> > Anthony, can you confirm that this solves the problem for you? >> This

[Qemu-devel] [PATCH v10 0/9] XBZRLE delta for live migration of large memory app

2012-05-16 Thread Orit Wasserman
Changes from v9: - move cache implementation to separate files. Kept our own implementation because GCache or GHashTable have no size limit. - Add migrate_set_parameter function - removed XBZRLE option from migrate command - add cache size information to query_migra

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [13:38:06], Paolo Bonzini wrote: > Il 16/05/2012 13:30, Amit Shah ha scritto: > > hw-obj-$(CONFIG_VIRTIO) += virtio-console.o > > +hw-obj-$(CONFIG_VIRTIO) += virtio-rng.o > > This needs to be conditional on CONFIG_LINUX too. Right. Thanks, Amit

[Qemu-devel] [PATCH v10 0/9] XBZRLE delta for live migration of large memory app

2012-05-16 Thread Orit Wasserman
Changes from v9: - move cache implementation to separate files. Kept our own implementation because GCache or GHashTable have no size limit. - Add migrate_set_parameter function - removed XBZRLE option from migrate command - add cache size information to query_migra

[Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2). If XBZRLE cache size is too small there will be many cache miss. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c |7 +++ hmp-c

[Qemu-devel] [PATCH v10 1/9] From: Isaku Yamahata

2012-05-16 Thread Orit Wasserman
Add MigrationParams structure Signed-off-by: Isaku Yamahata --- block-migration.c |8 migration.c | 13 - migration.h |8 ++-- qemu-common.h |1 + savevm.c | 11 --- sysemu.h |3 ++- vmstate.h |2 +

Re: [Qemu-devel] [PATCH qom-next 00/22] ARM: QOM cpu_reset() followups

2012-05-16 Thread Igor Mitsyanko
On 05/14/2012 09:31 PM, Andreas Färber wrote: Hello Peter, Following up on your remark about ugly naming as a consequence of my CPU reset patches and my OMAP field rename, here's a few more patches. Patch 1 is spelling fixes in a comment and could be pulled into 1.1. Patches 2-7 fix some more

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Igor Mammedov
On 05/11/2012 01:26 PM, Andreas Färber wrote: Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber --- linux-user/main.c|2 +- linux-user/syscall.c |2 +- 2 files changed, 2 in

[Qemu-devel] [PATCH v10 2/9] Add migration capabilites

2012-05-16 Thread Orit Wasserman
Add migration capabiltes that can be queried by the management. The managment can query the source QEMU and the destination QEMU in order to verify both support some migration capability (currently only XBZRLE). The managment can enable a capabilty for the next migration by using migrate_set_param

Re: [Qemu-devel] [PATCH v10 1/9] From: Isaku Yamahata

2012-05-16 Thread Peter Maydell
On 16 May 2012 12:59, Orit Wasserman wrote: > Add MigrationParams structure > > Signed-off-by: Isaku Yamahata You seem to have managed to get the From: authorship line in the subject commit summary line somehow in this patch... -- PMM

[Qemu-devel] [PATCH v10 4/9] Add cache handling functions

2012-05-16 Thread Orit Wasserman
Add LRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs|1 + cache.c | 212 +++

[Qemu-devel] [PATCH v10 3/9] Add XBZRLE documentation

2012-05-16 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 97 +++ 1 files changed, 97 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..aafdb84 --- /

[Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Daniel P. Berrange
From: "Daniel P. Berrange" Sometimes it is neccessary for an application to determine whether a particular QMP event is available, so they can decide whether to use compatibility code instead. This introduces a new 'query-events' command to QMP todo just that { "execute": "query-events" } {"re

[Qemu-devel] [PATCH v10 9/9] Add XBZRLE statistics

2012-05-16 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 68 +- hmp.c| 13 ++ migration.c | 12 + migration.h |

[Qemu-devel] [PATCH v10 6/9] Add save_block_hdr function

2012-05-16 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- arch_init.c | 26 ++ 1 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch_init.c b/arch_init.c index 9a35aee..a334a2e 100644 --- a

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Andreas Färber
Am 16.05.2012 14:36, schrieb Igor Mammedov: > On 05/11/2012 01:26 PM, Andreas Färber wrote: >> Am 11.05.2012 13:22, schrieb Peter Maydell: >>> On 10 May 2012 01:14, Andreas Färber wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber --- linux-user/mai

[Qemu-devel] [PATCH v10 7/9] Add XBZRLE to ram_save_block and ram_save_live

2012-05-16 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed than send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-of

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Peter Maydell
On 16 May 2012 14:01, Andreas Färber wrote: > Am 16.05.2012 14:36, schrieb Igor Mammedov: >> On 05/11/2012 01:26 PM, Andreas Färber wrote: >>> Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber  wrote: > Eliminates cpu_state_reset() usage. > > Signed-

[Qemu-devel] [PATCH v10 5/9] Add uleb encoding/decoding functions

2012-05-16 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 29 + qemu-common.h |8 2 files changed, 37 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index af308cd..60fb7c8 100644 --- a/cutils.c +++ b/c

[Qemu-devel] [PATCH 1/6] qcow2: don't leak buffer for unexpected qcow_version in header

2012-05-16 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 655799c..f3388bf 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -919,6 +919,7 @@ int qcow2_update_header(BlockDriverState *bs) re

[Qemu-devel] [PATCH 0/6] plug memory and file-descriptor leaks

2012-05-16 Thread Jim Meyering
From: Jim Meyering These changes fix most of the legitimate coverity-reported leak warnings. Jim Meyering (6): qcow2: don't leak buffer for unexpected qcow_version in header qemu-ga: avoid unconditional lockfile file descriptor leak linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFA

[Qemu-devel] [PATCH 4/6] sheepdog: don't leak socket file descriptor upon connection failure

2012-05-16 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- block/sheepdog.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index e01d371..a5c834f 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -489,6 +489,7 @@ static int connect_to_sdog(const char *add

[Qemu-devel] [PATCH 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure

2012-05-16 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 20d2a74..bdf8ce0 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -2814,6 +2814,7 @@ static inline abi_lo

[Qemu-devel] [PATCH 6/6] softmmu-semi: fix lock_user* functions not to deref NULL upon OOM

2012-05-16 Thread Jim Meyering
From: Jim Meyering Use g_malloc/g_free in place of malloc/free. Signed-off-by: Jim Meyering --- softmmu-semi.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu-semi.h b/softmmu-semi.h index 648cb95..996e0f7 100644 --- a/softmmu-semi.h +++ b/softmmu-semi.h @@ -3

Re: [Qemu-devel] A error abou t gtester-report, can anyone help me, thank you !

2012-05-16 Thread Anthony Liguori
On 05/16/2012 02:51 AM, Zhi Hui Li wrote: When I use gtest. Compiler did not have a problem, the use of gtester implementation and generate xml file testlog also no problem, but in the use of gterster-report, the output is as follows: gtester-report test.log > test-report.html There's a bug i

Re: [Qemu-devel] [PATCH 5/6] arm-semi: don't leak 1kb user string lock buffer upon TARGET_SYS_OPEN

2012-05-16 Thread Peter Maydell
On 16 May 2012 14:08, Jim Meyering wrote: > From: Jim Meyering > > Always call unlock_user before returning. > > . Gratuitous dot in your commit message here, but > > Signed-off-by: Jim Meyering Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 2/6] qemu-ga: avoid unconditional lockfile file descriptor leak

2012-05-16 Thread Jim Meyering
From: Jim Meyering Do not leak a file descriptor. Also, do not forget to unlink the lockfile upon failed lockf. Always close the lockfile file descriptor, taking care to diagnose close, as well as open and write, failure. Signed-off-by: Jim Meyering --- qemu-ga.c | 10 -- 1 file change

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 12:37:54PM +0100, Anthony PERARD wrote: > On Wed, May 16, 2012 at 12:23 PM, Paolo Bonzini wrote: > > Il 16/05/2012 13:15, Anthony PERARD ha scritto: > >>> >         qdev_unplug(&(d->qdev), NULL); > >>> > +        qdev_free(&(d->qdev)); > >>> >     } > >>> >  } > >>> > > >>>

Re: [Qemu-devel] [PATCH 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure

2012-05-16 Thread Peter Maydell
On 16 May 2012 14:07, Jim Meyering wrote: > From: Jim Meyering > > > Signed-off-by: Jim Meyering > --- >  linux-user/syscall.c | 1 + >  1 file changed, 1 insertion(+) > > diff --git a/linux-user/syscall.c b/linux-user/syscall.c > index 20d2a74..bdf8ce0 100644 > --- a/linux-user/syscall.c > +++ b

[Qemu-devel] [PATCH 5/6] arm-semi: don't leak 1kb user string lock buffer upon TARGET_SYS_OPEN

2012-05-16 Thread Jim Meyering
From: Jim Meyering Always call unlock_user before returning. . Signed-off-by: Jim Meyering --- arm-semi.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/arm-semi.c b/arm-semi.c index 88ca9bb..5d2a2d2 100644 --- a/arm-semi.c +++ b/arm-semi.c @@ -194,18 +194,1

Re: [Qemu-devel] [PATCH 4/4] xen: Fix PV-on-HVM

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:37:02AM +0100, Stefano Stabellini wrote: > On Wed, 16 May 2012, Michael S. Tsirkin wrote: > > On Wed, May 16, 2012 at 11:19:53AM +0100, Stefano Stabellini wrote: > > > On Wed, 16 May 2012, Paolo Bonzini wrote: > > > > Il 16/05/2012 10:13, Michael S. Tsirkin ha scritto: >

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put entropy into that buffer, and push it back to the guest. Feeding randomness from host's /dev/uran

Re: [Qemu-devel] [PATCH] Avoid segfault in cpu_dump_state

2012-05-16 Thread Fabien Chouteau
On 05/16/2012 10:29 AM, Fabien Chouteau wrote: > On 05/16/2012 05:50 AM, Andreas Färber wrote: >> Am 15.05.2012 18:08, schrieb Fabien Chouteau: >>> On 05/15/2012 03:31 PM, Andreas Färber wrote: Am 15.05.2012 11:39, schrieb Fabien Chouteau: > Do not call cpu_dump_state if logfile is NULL. >

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Daniel P. Berrange
On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > On 05/16/2012 06:30 AM, Amit Shah wrote: > >The Linux kernel already has a virtio-rng driver, this is the device > >implementation. > > > >When Linux needs more entropy, it puts a buffer in the vq. We then put > >entropy into that

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Gleb Natapov
On Tue, May 15, 2012 at 07:18:10PM -0400, Kevin O'Connor wrote: > On Tue, May 15, 2012 at 11:06:05AM +0300, Gleb Natapov wrote: > > On Mon, May 14, 2012 at 09:43:19PM -0400, Kevin O'Connor wrote: > > > On Mon, May 14, 2012 at 03:35:23PM +0300, Gleb Natapov wrote: > > > > QEMU may want to disable gu

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in th

Re: [Qemu-devel] [PATCH 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure

2012-05-16 Thread Jim Meyering
Peter Maydell wrote: > On 16 May 2012 14:07, Jim Meyering wrote: >> From: Jim Meyering >> >> >> Signed-off-by: Jim Meyering >> --- >>  linux-user/syscall.c | 1 + >>  1 file changed, 1 insertion(+) >> >> diff --git a/linux-user/syscall.c b/linux-user/syscall.c >> index 20d2a74..bdf8ce0 100644 >>

[Qemu-devel] [PATCHv2 3/6] linux-user: do_msgrcv: don't leak host_mb upon TARGET_EFAULT failure

2012-05-16 Thread Jim Meyering
Also, use g_malloc to avoid NULL-deref upon OOM. Signed-off-by: Jim Meyering --- There are other, similar NULL-deref risks in this file. TBD separately. linux-user/syscall.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c inde

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Daniel P. Berrange
On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: > On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: > >On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > >>On 05/16/2012 06:30 AM, Amit Shah wrote: > >>>The Linux kernel already has a virtio-rng driver, this is the de

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 08:53 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel alrea

Re: [Qemu-devel] [Qemu-discuss] Issue of usb emulation with qemu

2012-05-16 Thread Linux Porting
On 04/09/2012 06:42 AM, tangming wrote: Recentlly I have an usb emulation issue with qemu. There is one usb device on host, and now I need this usb device to be used by several VMs. I enable the usb emulation with the VMs' qemu parameter "-usbdevice host::", with individual qemu instance

[Qemu-devel] Fw: [Qemu-discuss] Issue of usb emulation with qemu

2012-05-16 Thread Linux Porting
u dear sir, this is vikas pandey,i am using qemu and i am abe to run some of kernel image   and initrd which is available on qemu site for testing purpose. now my ami is to connect the host usb and access the content after running  iso image or specifing kernel and initrd image on qemu .

Re: [Qemu-devel] [PATCH v3] pci: clean all funcs when hot-removing multifunc device

2012-05-16 Thread Bjorn Helgaas
On Fri, May 11, 2012 at 8:00 AM, Jiang Liu wrote: > On 05/11/2012 08:24 AM, Amos Kong wrote: >> On 05/11/2012 07:54 AM, Amos Kong wrote: >>> On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote: On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote: > On 05/10/2012 11:44 PM, Amos Kong wro

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 15:46, Gleb Natapov ha scritto: > I saw that, but I don't get why doing it this way instead of defining > the object in AML and patching it? I can define Name(S4VL, 0x2) and path > 0x2 to whatever QEMU wants me to use, or I can patch Package directly > like I did. > Can we build an

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto: >>> Because it's missing the object_unparent done by qdev_unplug. Does >>> object_unparent+qdev_free work? (I believe object_unparent should be >>> done by qdev_free rather than qdev_unplug, but that's something for 1.2). >> >> Cool, this seems

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Anthony Liguori
On 05/16/2012 06:23 AM, Paolo Bonzini wrote: Il 16/05/2012 13:15, Anthony PERARD ha scritto: qdev_unplug(&(d->qdev), NULL); +qdev_free(&(d->qdev)); } } Anthony, can you confirm that this solves the problem for you? This work until I try to hotplug a new device to the g

Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Eric Blake
On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > Sometimes it is neccessary for an application to determine > whether a particular QMP event is available, so they can > decide whether to use compatibility code instead. This > introduces a new 'query-events' comma

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Igor Mammedov
On 05/16/2012 03:01 PM, Andreas Färber wrote: Am 16.05.2012 14:36, schrieb Igor Mammedov: On 05/11/2012 01:26 PM, Andreas Färber wrote: Am 11.05.2012 13:22, schrieb Peter Maydell: On 10 May 2012 01:14, Andreas Färber wrote: Eliminates cpu_state_reset() usage. Signed-off-by: Andreas Färber

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Peter Maydell
On 16 May 2012 17:05, Igor Mammedov wrote: > 1. I'd like to have cpu_reset in realizefn - which is kind of equivalent > of cpu power-on, after which cpu should be in known state > (i.e. the state after reset, at least for target-i386). Realize is not the same as "has come out of reset". Consider

Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Anthony Liguori
On 05/16/2012 11:04 AM, Eric Blake wrote: On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: From: "Daniel P. Berrange" Sometimes it is neccessary for an application to determine whether a particular QMP event is available, so they can decide whether to use compatibility code instead. This intro

Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Daniel P. Berrange
On Wed, May 16, 2012 at 11:18:22AM -0500, Anthony Liguori wrote: > On 05/16/2012 11:04 AM, Eric Blake wrote: > >On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: > >>From: "Daniel P. Berrange" > >> > >>Sometimes it is neccessary for an application to determine > >>whether a particular QMP event is

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Alex Williamson
On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: > On 05/15/2012 05:09 PM, Alex Williamson wrote: > > On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: > >> On Mon, May 14, 2012 at 4:49 PM, Alex Williamson > >> wrote: > >>> On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: >

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:02:30AM -0500, Anthony Liguori wrote: > On 05/16/2012 06:23 AM, Paolo Bonzini wrote: > >Il 16/05/2012 13:15, Anthony PERARD ha scritto: > qdev_unplug(&(d->qdev), NULL); > +qdev_free(&(d->qdev)); > } > } > > > Anthony,

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 05:52:17PM +0200, Paolo Bonzini wrote: > Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto: > >>> Because it's missing the object_unparent done by qdev_unplug. Does > >>> object_unparent+qdev_free work? (I believe object_unparent should be > >>> done by qdev_free rather t

Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Luiz Capitulino
On Wed, 16 May 2012 11:18:22 -0500 Anthony Liguori wrote: > On 05/16/2012 11:04 AM, Eric Blake wrote: > > On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: > >> From: "Daniel P. Berrange" > >> > >> Sometimes it is neccessary for an application to determine > >> whether a particular QMP event is a

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 18:40, Gleb Natapov ha scritto: > On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: >> Il 16/05/2012 15:46, Gleb Natapov ha scritto: >>> I saw that, but I don't get why doing it this way instead of defining >>> the object in AML and patching it? I can define Name(S4VL, 0x

Re: [Qemu-devel] [PATCH v10 3/9] Add XBZRLE documentation

2012-05-16 Thread Eric Blake
On 05/16/2012 05:59 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 97 > +++ > 1 files changed, 97 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > diff --git a/docs/xbzrle.txt b/do

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Orit Wasserman
On 05/16/2012 07:45 PM, Eric Blake wrote: > On 05/16/2012 05:59 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >

  1   2   >