Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-21 Thread Stefan Hajnoczi
On Tue, May 15, 2012 at 02:42:54PM +0200, Paolo Bonzini wrote: Il 15/05/2012 14:01, Kevin Wolf ha scritto: Hi all, after having implemented refcount fixing in qcow2's img_check, I'm now wondering what the best way is to allow users to optionally enable the QED mode for

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Avi Kivity
On 05/21/2012 04:13 PM, Jan Kiszka wrote: Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose, another PCI bridge callback function is introduced: map_host_irq.

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 15:59, Luiz Capitulino ha scritto: I understand your reasoning, and since the beginning I thought this was something useful to do, but we've already settled for not doing this. I also think that we shouldn't have exceptions, as in practice this means we're extending commands

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is: commands = qmp.query_commands() if 'block-stream' in commands: # has block-stream I have a

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 16:40, Anthony Liguori ha scritto: On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is: commands = qmp.query_commands() if

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:36, Avi Kivity wrote: On 05/21/2012 04:13 PM, Jan Kiszka wrote: Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose, another PCI bridge

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Igor Mammedov
On 05/10/2012 01:15 AM, Andreas Färber wrote: Am 17.04.2012 12:28, schrieb Igor Mammedov: - Original Message - From: Andreas Färberafaer...@suse.de ... I think the right name would be /machine/cpu[%d]/cpu. The local APIC for example should reside under /machine/cpu[%d]/apic.

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Alex Williamson
On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: On 05/15/2012 05:09 PM, Alex

Re: [Qemu-devel] [PATCH RFC 6/6] target-i386: make cpus childs of /machine

2012-05-21 Thread Jan Kiszka
On 2012-05-21 11:50, Igor Mammedov wrote: I've used cpu_index, but it seems cpuid_apic_id is assigned only once, from cpu_index, so it should be identical. What's the difference? Once Jan voiced that user visible cpu id, should be apic_id in context of cpu hotplug (i.e. when doing:

Re: [Qemu-devel] qxl performance problems and spice issues

2012-05-21 Thread Luis Geraldes
Thank you for you reply, What version of drivers (windows guest, linux guest) do you have? Windows: http://spice-space.org/download/binaries/spice-guest-tools-0.1.exe Debian wheezy: from repository: http://packages.debian.org/wheezy/xserver-xorg-video-qxl (0.0.17-2)

Re: [Qemu-devel] [PATCH] Add a memory barrier to guest memory access functions

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 14:18, Michael S. Tsirkin ha scritto: Almost all our devices were written without any thought given to ordering, so they basically can and should be considered as all broken. Problem is, a lot of code is likely broken even after you sprinkle barriers around. For example qemu

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 15:07, Kevin Wolf ha scritto: Am 21.05.2012 13:02, schrieb Paolo Bonzini: Il 21/05/2012 12:32, Kevin Wolf ha scritto: Am 21.05.2012 12:02, schrieb Paolo Bonzini: Il 21/05/2012 11:29, Kevin Wolf ha scritto: If source/target is really the distinction we want to have, should the

Re: [Qemu-devel] Interface for enabling lazy refcount updates in qcow2

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 16:34, schrieb Stefan Hajnoczi: On Tue, May 15, 2012 at 02:42:54PM +0200, Paolo Bonzini wrote: Il 15/05/2012 14:01, Kevin Wolf ha scritto: Hi all, after having implemented refcount fixing in qcow2's img_check, I'm now wondering what the best way is to allow users to optionally

[Qemu-devel] KVM call agenda for May, Tuesday 22

2012-05-21 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Eric Blake
On 05/21/2012 07:59 AM, Richard W.M. Jones wrote: Hm, I'm wondering... If I have a command line like this: qemu-img diff -b base.img modified.img diff.qcow2 Would this be equivalent to this sequence? qemu-img create -f qcow2 -b modified.img diff.qcow2 qemu-img rebase -b base.img

Re: [Qemu-devel] [PATCH v3] qemu-img: Implement 'diff' operation.

2012-05-21 Thread Kevin Wolf
Am 21.05.2012 17:30, schrieb Eric Blake: On 05/21/2012 07:59 AM, Richard W.M. Jones wrote: Hm, I'm wondering... If I have a command line like this: qemu-img diff -b base.img modified.img diff.qcow2 Would this be equivalent to this sequence? qemu-img create -f qcow2 -b modified.img

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Anthony Liguori
On 05/21/2012 09:47 AM, Paolo Bonzini wrote: Il 21/05/2012 16:40, Anthony Liguori ha scritto: On 05/21/2012 09:26 AM, Paolo Bonzini wrote: Il 21/05/2012 16:19, Anthony Liguori ha scritto: I'm not against it in principle, just in practice. Today, checking whether a command exists is:

Re: [Qemu-devel] [PATCH 1.1 2/4] sheepdog: fix return value of do_load_save_vm_state

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 20:15, schrieb MORITA Kazutaka: bdrv_save_vmstate and bdrv_load_vmstate should return the number of processed bytes on success. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- block/sheepdog.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH 1.1 0/4] sheepdog: various sheepdog fixes

2012-05-21 Thread Kevin Wolf
Am 16.05.2012 20:15, schrieb MORITA Kazutaka: This patchset contains various fixes for Sheepdog. See individual patches for details. MORITA Kazutaka (4): sheepdog: mark image as snapshot when tag is specified sheepdog: fix return value of do_load_save_vm_state sheepdog: return

Re: [Qemu-devel] Proposal for extensions of block job commands in QEMU 1.2

2012-05-21 Thread Paolo Bonzini
Il 21/05/2012 17:44, Anthony Liguori ha scritto: It also gets very challenging if some options are backported and others aren't. It gets challenging anyway with backports. If qmp_block_stream_v1_2 knows of defaults and doesn't send them on the wire, it will work if you only rely on the subset

Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support

2012-05-21 Thread Paolo Bonzini
Il 16/05/2012 12:54, Paolo Bonzini ha scritto: Previous versions of these patches have been posted already, but they were lost. Sorry for realizing this quite late. VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* SCSI requests, not *execute* them. So it should always be

[Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Fabien Chouteau
The size of EPN field in MAS2 depends on page size. This patch adds a mask to discard invalid bits in EPN field. Definition of EPN field from e500v2 RM: EPN Effective page number: Depending on page size, only the bits associated with a page boundary are valid. Bits that represent offsets within a

Re: [Qemu-devel] [PATCH 1.1 0/4] decouple VIRTIO_BLK_F_SCSI from SG_IO support

2012-05-21 Thread Anthony Liguori
On 05/21/2012 10:56 AM, Paolo Bonzini wrote: Il 16/05/2012 12:54, Paolo Bonzini ha scritto: Previous versions of these patches have been posted already, but they were lost. Sorry for realizing this quite late. VIRTIO_BLK_F_SCSI is supposed to mean whether the host can *parse* SCSI requests,

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Andreas Färber
Am 21.05.2012 18:11, schrieb Fabien Chouteau: The size of EPN field in MAS2 depends on page size. This patch adds a mask to discard invalid bits in EPN field. Definition of EPN field from e500v2 RM: EPN Effective page number: Depending on page size, only the bits associated with a page

[Qemu-devel] [PATCH for-1.1] Makefile.user: Clean libuser/qom/ subdirectory

2012-05-21 Thread Andreas Färber
Commit dd83b06ae61cfa2dc4381ab49f365bd0995fc930 (qom: Introduce CPU class) introduced a qom/ subdir in libuser/. It contains cpu.o once built. That never gets cleaned up. Add qom to the list of subdirectories to be cleaned. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Riku Voipio

[Qemu-devel] Current differences between qemu --enable-kvm and qemu-kvm?

2012-05-21 Thread Erik Rull
Hi all, is there a summary existing that shows up the rough or actual differences between qemu --enable-kvm and qemu-kvm? I tested both versions with the same compile and start options, the CPU performance results are identical, only the bootup time of my guest system with qemu-kvm seemed to

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 8:14 AM, Kevin Wolf kw...@redhat.com wrote: Am 21.05.2012 10:11, schrieb Paolo Bonzini: Il 21/05/2012 09:51, Kevin Wolf ha scritto: GTESTER check-qtest-i386 FLOPPY ERROR: fdctrl_read_data: controller not ready for reading FLOPPY ERROR: fdctrl_read_data: controller not

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 8:18 AM, Paolo Bonzini pbonz...@redhat.com wrote: What do you mean by fixing? Turning them into DPRINTFs? Or trace events? Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the point here is that today it's a FLOPPY_ERROR, and except for register

Re: [Qemu-devel] [PATCH 02/15] Openrisc: add MMU support

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 9:03 AM, 陳韋任 che...@iis.sinica.edu.tw wrote: diff --git a/target-openrisc/mem_helper.c b/target-openrisc/mem_helper.c index a2d93c7..922dd6b 100644 --- a/target-openrisc/mem_helper.c +++ b/target-openrisc/mem_helper.c @@ -42,5 +42,30 @@ 戹oid

Re: [Qemu-devel] [PATCH] qtest: add a fuzz test to fdc-test

2012-05-21 Thread Peter Maydell
On 21 May 2012 18:30, Blue Swirl blauwir...@gmail.com wrote: On Mon, May 21, 2012 at 8:14 AM, Kevin Wolf kw...@redhat.com wrote: Yeah, you could turn all FLOPPY_DPRINTFs into trace events. But the point here is that today it's a FLOPPY_ERROR, and except for register fuzzing they report real

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:     -const MemoryRegionPortio virtio_portio[] = {     +static const MemoryRegionPortio

Re: [Qemu-devel] [PATCH] memory: add -dont-dump-guest option to reduce core dump size

2012-05-21 Thread Jason Baron
On Fri, May 04, 2012 at 05:23:51PM -0400, Jason Baron wrote: Add a command line parameter to not dump guest memory in the core dump, the command line is: -dont-dump-guest. This brought the core dump down from 383MB to 13 MB on a 1GB guest. Signed-off-by: Jason Baron jba...@redhat.com ---

Re: [Qemu-devel] [PATCH 1/3] envlist.c: handle strdup failure

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:25 AM, Jim Meyering j...@meyering.net wrote: Blue Swirl wrote: On Tue, May 15, 2012 at 1:04 PM,  j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com Without this, envlist_to_environ may silently fail to copy all strings into the destination buffer, and

[Qemu-devel] [PATCH 08/16] qemu-option: introduce qemu_opt_set_err()

2012-05-21 Thread Luiz Capitulino
This is like qemu_opt_set(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_opt_set(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c |6 ++ qemu-option.h |2 ++ 2 files changed, 8

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 10:36 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 21 May 2012 08:21, nicolas.sauzede nicolas.sauz...@laposte.net wrote: Ok, so I guess that for now, we have to live with the lack of a way to actually get those io transaction properties, right ? Do you think

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 10:13:47AM -0300, Jan Kiszka wrote: Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose, another PCI bridge callback function is

[Qemu-devel] [PATCH 14/16] net: net_client_init(): use error_set()

2012-05-21 Thread Luiz Capitulino
Callers are changed to use qerror_report_err() to keep their QError semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/pci-hotplug.c |8 ++-- hw/usb/dev-network.c |7 +-- net.c| 54 +++---

[Qemu-devel] [PATCH 01/16] qemu-option: qemu_opts_create(): use error_set()

2012-05-21 Thread Luiz Capitulino
This commit converts qemu_opts_create() from qerror_report() to error_set(). Currently, most calls to qemu_opts_create() can't fail, so most callers don't need any changes. The two cases where code checks for qemu_opts_create() erros are: 1. Initialization code in vl.c. All of them print their

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:     -const MemoryRegionPortio virtio_portio[] = {     +static const

[Qemu-devel] [PATCH 15/19] kvm: Make kvm_irqchip_commit_routes an internal service

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Automatically commit route changes after kvm_add_routing_entry and kvm_irqchip_release_virq. There is no performance relevant use case for which collecting multiple route changes is beneficial. This makes kvm_irqchip_commit_routes an internal service which

Re: [Qemu-devel] [PATCH qmp-next v5 00/16]: qapi: convert netdev_add netdev_del

2012-05-21 Thread Laszlo Ersek
On 05/21/12 19:41, Luiz Capitulino wrote: v5 - Simplify set_option_parameter() [Laszlo] patches changed: 3 4 - Fix bad patch split in patch 15/16, hunk changing net_init_netdev() pertains to patch 14/16 [Laszlo] hunk squashed from 15 into 14 blockdev.c |2 +-

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/21/2012 10:59 AM, Alex Williamson wrote: On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 9:09 AM, Andreas Färber afaer...@suse.de wrote: Am 14.05.2012 23:22, schrieb Blue Swirl: On Mon, May 14, 2012 at 8:59 PM, Andreas Färber afaer...@suse.de wrote: Am 14.05.2012 21:54, schrieb Blue Swirl: On Mon, May 14, 2012 at 4:15 PM, Andreas Färber afaer...@suse.de

[Qemu-devel] [PATCH 02/19] Introduce MSIMessage structure

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Will be used for generating and distributing MSI messages, both in emulation mode and under KVM. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- hw/msi.h |5 + qemu-common.h |1 + 2

[Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-05-21 Thread Avi Kivity
Please pull from: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master This is mostly Jan's MSI for KVM patches. Avi Kivity (1): kvm: update vmxcap for EPT A/D, INVPCID, RDRAND, VMFUNC Jan Kiszka (19): kvm:

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Peter Maydell
On 21 May 2012 19:08, Blue Swirl blauwir...@gmail.com wrote: On Mon, May 21, 2012 at 10:36 AM, Peter Maydell peter.mayd...@linaro.org wrote: I think it would be nice to have this in upstream qemu; however adding transaction properties to the IO interface would be quite tricky I suspect...

[Qemu-devel] [PATCH 05/16] qemu-option: qemu_opt_parse(): use error_set()

2012-05-21 Thread Luiz Capitulino
The functions opt_set() and qemu_opts_validate() both call qemu_opt_parse(), but their callers expect QError semantics. Thus, both functions call qerro_report_err() to keep the expected semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c | 36

[Qemu-devel] [PATCH 03/16] qemu-option: parse_option_bool(): use error_set()

2012-05-21 Thread Luiz Capitulino
Note that set_option_parameter() callers still expect automatic error reporting with QError, so set_option_parameter() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c | 24 1 file changed, 16

[Qemu-devel] [PATCH 04/16] qemu-option: parse_option_size(): use error_set()

2012-05-21 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index b5da116..42bb685 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -203,7 +203,8 @@ static void

[Qemu-devel] [PATCH 12/16] qemu-config: introduce qemu_find_opts_err()

2012-05-21 Thread Luiz Capitulino
This is like qemu_find_opts(), except that it takes an Error argument. This new function allows for a incremental conversion of code using qemu_find_opts(). Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-config.c |5 + qemu-config.h |3 +++ 2 files changed, 8

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 6:10 PM, Jim Meyering j...@meyering.net wrote: Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made this change:    

[Qemu-devel] [PATCH 02/16] qemu-option: parse_option_number(): use error_set()

2012-05-21 Thread Luiz Capitulino
Note that qemu_opt_parse() callers still expect automatic error reporting with QError, so qemu_opts_parse() calls qerror_report_err() to keep the same semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- qemu-option.c | 26 +++--- 1 file changed, 19

Re: [Qemu-devel] [PULL] qemu-ga fixes for 1.1

2012-05-21 Thread Luiz Capitulino
On Tue, 15 May 2012 09:48:46 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: The following changes since commit 76ee152a86d5f2533443ce4d2be6fe253cfb3c45: Update version to 1.1.0-rc2 (2012-05-14 17:56:50 -0500) are available in the git repository at:

[Qemu-devel] [PATCH 04/19] pc: Enable MSI support at APIC level

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. Acked-by: Stefano Stabellini stefano.stabell...@eu.citrix.com Signed-off-by: Jan Kiszka

Re: [Qemu-devel] Get current env within io_handler ?

2012-05-21 Thread Blue Swirl
On Mon, May 21, 2012 at 6:28 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 21 May 2012 19:08, Blue Swirl blauwir...@gmail.com wrote: On Mon, May 21, 2012 at 10:36 AM, Peter Maydell peter.mayd...@linaro.org wrote: I think it would be nice to have this in upstream qemu; however adding

Re: [Qemu-devel] [PATCH 0/3] tighten scope of accidentally global variables

2012-05-21 Thread Jim Meyering
Blue Swirl wrote: On Mon, May 21, 2012 at 6:10 PM, Jim Meyering j...@meyering.net wrote: Blue Swirl wrote: On Mon, May 21, 2012 at 10:03 AM, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com I noticed this commit,    virtio-pci: add missing 'static' which made

[Qemu-devel] [PATCH 17/19] kvm: Enable use of kvm_irqchip_in_kernel in hwlib code

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Provide a dummy kvm_kernel_irqchip so that kvm_irqchip_in_kernel can be used by code that is not under CONFIG_KVM protection. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- kvm-stub.c |1 + 1 file

[Qemu-devel] [PATCH v2 1/3] Add 'query-events' command to QMP to query async events

2012-05-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Sometimes it is neccessary for an application to determine whether a particular QMP event is available, so they can decide whether to use compatibility code instead. This introduces a new 'query-events' command to QMP to do just that { execute:

[Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes

2012-05-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest has reacted to this request. The virtio-balloon backend knows exactly when the guest has reacted though, and thus it is possible

[Qemu-devel] [PATCH 08/19] kvm: Enable in-kernel irqchip support by default

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com As MSI is now fully supported by KVM (/wrt available features in upstream), we can finally enable the in-kernel irqchip by default. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c |2 +-

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Jan Kiszka
On 2012-05-21 14:34, Michael S. Tsirkin wrote: On Mon, May 21, 2012 at 10:13:47AM -0300, Jan Kiszka wrote: Add a PCI IRQ path discovery function that walks from a given device to the host bridge, returning the IRQ number that is reported to the attached interrupt controller. For this purpose,

[Qemu-devel] [PATCH 05/19] kvm: x86: Wire up MSI support for in-kernel irqchip

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Catch writes to the MSI MMIO region in the KVM APIC and forward them to the kernel. Provide the kernel support GSI routing, this allows to enable MSI support also for in-kernel irqchip mode. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by:

Re: [Qemu-devel] [PATCH 1/2] pci: Add pci_device_get_host_irq

2012-05-21 Thread Michael S. Tsirkin
On Mon, May 21, 2012 at 10:13:47AM -0300, Jan Kiszka wrote: @@ -386,6 +387,14 @@ static void piix3_set_irq(void *opaque, int pirq, int level) piix3_set_irq_level(piix3, pirq, level); } +static int piix3_map_host_irq(void *opaque, int pci_intx) +{ +PIIX3State *piix3 = opaque;

[Qemu-devel] [PATCH 11/19] msix: Introduce vector notifiers

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Vector notifiers shall be triggered by the MSI/MSI-X core whenever a relevant configuration change is programmed by the guest. In case of MSI-X, changes are reported when the effective mask (global per-vector) alters its state. On unmask, the current

[Qemu-devel] [PATCH 09/16] qemu-option: qemu_opts_from_qdict(): use error_set()

2012-05-21 Thread Luiz Capitulino
do_device_add() and do_netdev_add() call qerror_report_err() to maintain their QError semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/qdev-monitor.c |7 +-- net.c |5 - qemu-option.c | 31 --- qemu-option.h

[Qemu-devel] [PATCH 12/19] kvm: Rename kvm_irqchip_add_route to kvm_irqchip_add_irq_route

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com We will add kvm_irqchip_add_msi_route, so let's make the difference clearer. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/pc_piix.c |8 kvm-all.c|2 +- kvm.h|2 +- 3

[Qemu-devel] [PATCH v2 3/3] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE WATCHDOG events

2012-05-21 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Allow certain event types to be rate limited to avoid flooding monitor clients. The monitor_protocol_event() method is changed such that instead of immediately emitting the event to Monitor instances, it will call a new monitor_protocol_event_queue()

[Qemu-devel] [PATCH 15/16] qapi: convert netdev_add

2012-05-21 Thread Luiz Capitulino
This is not a full QAPI conversion, but an intermediate step. In essence, do_netdev_add() is split into three functions: 1. netdev_add(): performs the actual work. This function is fully converted to Error (thus, it's qapi-friendly) 2. qmp_netdev_add(): the QMP front-end for netdev_add().

Re: [Qemu-devel] [PATCH V2] booke_206_tlbwe: Discard invalid bits in MAS2

2012-05-21 Thread Alexander Graf
On 21.05.2012, at 18:31, Andreas Färber afaer...@suse.de wrote: Am 21.05.2012 18:11, schrieb Fabien Chouteau: The size of EPN field in MAS2 depends on page size. This patch adds a mask to discard invalid bits in EPN field. Definition of EPN field from e500v2 RM: EPN Effective page

[Qemu-devel] Current differences between qemu --enable-kvm and qemu-kvm?

2012-05-21 Thread Erik Rull
Hi all, is there a summary existing that shows up the rough or actual differences between qemu --enable-kvm and qemu-kvm? I tested both versions with the same compile and start options, the CPU performance results are identical, only the bootup time of my guest system with qemu-kvm seemed to

Re: [Qemu-devel] [PATCH 11/13] pci: Create common pcibios_err_to_errno

2012-05-21 Thread Konrad Rzeszutek Wilk
On Fri, May 11, 2012 at 04:56:44PM -0600, Alex Williamson wrote: For returning errors out to non-PCI code. Re-name xen's version. Signed-off-by: Alex Williamson alex.william...@redhat.com Acked-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- drivers/xen/xen-pciback/conf_space.c |

[Qemu-devel] [PATCH 01/19] kvm: Refactor KVMState::max_gsi to gsi_count

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Instead of the bitmap size, store the maximum of GSIs the kernel support. Move the GSI limit assertion to the API function kvm_irqchip_add_route and make it stricter. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti

[Qemu-devel] [PATCH 07/19] kvm: Add support for direct MSI injections

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com If the kernel supports KVM_SIGNAL_MSI, we can avoid the route-based MSI injection mechanism. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c | 22 +++--- 1 file changed,

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [08:48:20], Anthony Liguori wrote: On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device

[Qemu-devel] [PATCH 06/19] kvm: Update kernel headers

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Corresponding kvm.git hash: f2569053e0 Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- linux-headers/linux/kvm.h | 38 ++ 1 file changed, 38 insertions(+) diff

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [13:24:10], Anthony Liguori wrote: On 05/16/2012 12:26 PM, Amit Shah wrote: On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a

[Qemu-devel] [PATCH 06/16] qemu-option: qemu_opts_validate(): use error_set()

2012-05-21 Thread Luiz Capitulino
net_client_init() propagates the error up by calling qerror_report_err(), because its users expect QError semantics. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- net.c |6 +- qemu-option.c | 13 + qemu-option.h |2 +- 3 files changed, 11

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-21 Thread Amit Shah
On (Wed) 16 May 2012 [13:23:11], Anthony Liguori wrote: On 05/16/2012 12:21 PM, Amit Shah wrote: On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux

[Qemu-devel] [PATCH 19/19] virtio/vhost: Add support for KVM in-kernel MSI injection

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Make use of the new vector notifier to track changes of the MSI-X configuration of virtio PCI devices. On enabling events, we establish the required virtual IRQ to MSI-X message route and link the signaling eventfd file descriptor to this vIRQ line. That

Re: [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes

2012-05-21 Thread Amit Shah
On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest has reacted to this request. The virtio-balloon backend knows

[Qemu-devel] [PATCH 14/19] kvm: Publicize kvm_irqchip_release_virq

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com This allows to drop routes created by kvm_irqchip_add_irq/msi_route again. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- kvm-all.c |2 +- kvm-stub.c |4 kvm.h |1 + 3 files changed, 6

Re: [Qemu-devel] [PATCH v2 2/3] Add event notification for guest balloon changes

2012-05-21 Thread Daniel P. Berrange
On Tue, May 22, 2012 at 01:14:59AM +0530, Amit Shah wrote: On (Mon) 21 May 2012 [17:59:52], Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest

[Qemu-devel] [PATCH 0/9] convert many more globals to static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Following up on discussion here, http://marc.info/?t=13375948768r=1w=2 here are patches to limit the scope of the remaining global variables. Most changes simply added a preceding static. However, in some cases, I've made minor additional changes,

[Qemu-devel] [PATCH 1/9] ccid: declare DEFAULT_ATR table to be static const

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- hw/ccid-card-passthru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c index bd6c777..1caaa45 100644 --- a/hw/ccid-card-passthru.c

[Qemu-devel] [PATCH 1/9] ccid: declare DEFAULT_ATR table to be static const

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- hw/ccid-card-passthru.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ccid-card-passthru.c b/hw/ccid-card-passthru.c index bd6c777..1caaa45 100644 --- a/hw/ccid-card-passthru.c

[Qemu-devel] [PATCH 2/9] tcg: declare __jit_debug_descriptor to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- tcg/tcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ab589c7..350fdad 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2293,7 +2293,7 @@ void

[Qemu-devel] [PATCH 2/9] tcg: declare __jit_debug_descriptor to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- tcg/tcg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ab589c7..350fdad 100644 --- a/tcg/tcg.c +++ b/tcg/tcg.c @@ -2293,7 +2293,7 @@ void

[Qemu-devel] [PATCH 3/9] alpha-dis: remove unused global; declare others to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com alpha_num_operands: Remove both declarations of this unused global. alpha_opcodes: Declare static to limit scope. Remove duplicate decl. alpha_num_opcodes: Likewise. alpha_operands: Likewise. Signed-off-by: Jim Meyering meyer...@redhat.com --- alpha-dis.c

[Qemu-devel] [PATCH 09/19] msix: Factor out msix_get_message

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com This helper will also be used by the upcoming config notifier. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/msix.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH 3/9] alpha-dis: remove unused global; declare others to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com alpha_num_operands: Remove both declarations of this unused global. alpha_opcodes: Declare static to limit scope. Remove duplicate decl. alpha_num_opcodes: Likewise. alpha_operands: Likewise. Signed-off-by: Jim Meyering meyer...@redhat.com --- alpha-dis.c

[Qemu-devel] [PATCH 16/19] kvm: Introduce kvm_irqchip_add/remove_irqfd

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Add services to associate an eventfd file descriptor as input with an IRQ line as output. Such a line can be an input pin of an in-kernel irqchip or a virtual line returned by kvm_irqchip_add_route. Signed-off-by: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] [PATCH 03/19] kvm: Introduce basic MSI support for in-kernel irqchips

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the original KVM API requires us to establish a static route from a pseudo GSI to the target MSI message and inject the MSI

[Qemu-devel] [PATCH 6/9] sheepdog: declare bdrv_sheepdog to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index e01d371..fdb3eca 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@

[Qemu-devel] [PATCH 4/9] linux-user: arg_table need not have global scope

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Declare arg_table to be static const, and adjust the two users to also be const. Signed-off-by: Jim Meyering meyer...@redhat.com --- linux-user/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/linux-user/main.c

[Qemu-devel] [PATCH 8/9] bonito: declare bonito_state to be static

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- hw/bonito.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/bonito.c b/hw/bonito.c index 77786f8..6bd0242 100644 --- a/hw/bonito.c +++ b/hw/bonito.c @@ -218,7 +218,7 @@ typedef

Re: [Qemu-devel] [PATCH 2/9] tcg: declare __jit_debug_descriptor to be static

2012-05-21 Thread Peter Maydell
On 21 May 2012 20:51, Jim Meyering j...@meyering.net wrote: From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com ---  tcg/tcg.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index ab589c7..350fdad 100644 ---

[Qemu-devel] [PATCH 18/19] msix: Add msix_nr_vectors_allocated

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Analogously to msi_nr_vectors_allocated, add a service for MSI-X. Will be used by the virtio-pci layer. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com --- hw/msix.c |5 + hw/msix.h |2 ++ 2 files

[Qemu-devel] [PATCH 13/16] net: purge the monitor object from all init functions

2012-05-21 Thread Luiz Capitulino
The only backend that really uses it is the socket one, which calls monitor_get_fd(). But it can use 'cur_mon' instead. Signed-off-by: Luiz Capitulino lcapitul...@redhat.com --- hw/pci-hotplug.c |2 +- hw/usb/dev-network.c |2 +- net.c| 18 +++--- net.h

[Qemu-devel] [PATCH 13/19] kvm: Introduce kvm_irqchip_add_msi_route

2012-05-21 Thread Avi Kivity
From: Jan Kiszka jan.kis...@siemens.com Add a service that establishes a static route from a virtual IRQ line to an MSI message. Will be used for IRQFD and device assignment. As we will use this service outside of CONFIG_KVM protected code, stub it properly. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH 5/9] ccid: make backend_enum_table static const and adjust users

2012-05-21 Thread Jim Meyering
From: Jim Meyering meyer...@redhat.com Signed-off-by: Jim Meyering meyer...@redhat.com --- hw/ccid-card-emulated.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ccid-card-emulated.c b/hw/ccid-card-emulated.c index f4a6da4..440f050 100644 ---

<    1   2   3   >