[Qemu-devel] [PATCH 1/2] Makefile: Remove BUILD_DIR from qapi-dir

2012-06-09 Thread Stefan Weil
qapi-dir does not need an absolute path. All other build directories are relative. When BUILD_DIR is removed, the build output looks better (no long lines with absolute paths when everything else uses short lines): GEN qapi-generated/qga-qapi-types.c CCqapi-generated/qga-qapi-types.o

[Qemu-devel] [PATCH 2/2] Makefile: Remove macro qapi-dir

2012-06-09 Thread Stefan Weil
As qapi-dir was now a constant, it can be replaced by its value. Signed-off-by: Stefan Weil s...@weilnetz.de --- Makefile | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/Makefile b/Makefile index 8880a3e..10874b8 100644 --- a/Makefile +++ b/Makefile

[Qemu-devel] QEMU translation flags

2012-06-09 Thread Xin Tong
In QEMU x86, TB translation flags are set up when the TB is allocated. what will happen if the translation flags are modified by one instruction in the translation block ? will the translation block be terminated right there. For example, there is a code32 flag which is set to the value of (flags

[Qemu-devel] vm state save/restore question

2012-06-09 Thread Benjamin Herrenschmidt
Hi folks ! I'm looking at sorting out the state save/restore of target-ppc (which means understanding in general how it works in qemu :-) So far I've somewhat figured out that there's the old way where we just provide a bulk save/restore function pair, and the new way where we have nicely tagged

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-09 Thread Laszlo Ersek
On 06/07/12 17:46, Paolo Bonzini wrote: Il 07/06/2012 17:29, Michael Roth ha scritto: For QEMU - X serialization/deserialization, such as a visitor which implements a wire encoding (QMP being the only example currently), we need to take care that the wire encoding is compatible with the

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-09 Thread Taisuke Yamada
This split-image configration is done to keep VM I/Os on a SSD This is an interesting use case that I wasn't aware of yet. So you're not really interested in a snapshot here, but what you're trying to do is using the SSD as some sort of a cache, right? Right. By splitting, not only I can

Re: [Qemu-devel] [PATCH] do not include libutil.h needlessly or if it doesn't exist

2012-06-09 Thread Blue Swirl
Thanks, applied. On Sat, Jun 2, 2012 at 7:43 PM, Michael Tokarev m...@tls.msk.ru wrote: libutil.h and util.h on *BSD (some have one, some another) were #included just for openpty() declaration.  The only file where this function is actually used is qemu-char.c. In vl.c and net/tap-bsd.c,

Re: [Qemu-devel] [PATCH] dump: Fix build breakage (missing sys/procfs.h)

2012-06-09 Thread Blue Swirl
Thanks, applied. On Fri, Jun 8, 2012 at 5:57 PM, Stefan Weil s...@weilnetz.de wrote: sys/procfs is not available everywhere (MingW does not have it). Remove this and more unused or redundant include statements. This fixes the broken build. qerror.h was previously included indirectly. Add

Re: [Qemu-devel] [PATCH] w32: Fix broken build (missing include file)

2012-06-09 Thread Blue Swirl
Thanks, applied. On Thu, Jun 7, 2012 at 1:45 PM, Stefan Weil s...@weilnetz.de wrote: dump.c was recently added to the code. It unconditionally includes sys/procfs which is not available with MinGW (w32, w64). It looks like this file is not needed at all (tested on Linux), so I removed it

Re: [Qemu-devel] [PATCH buildfix] target-ppc: Unbreak kvm_ppc.c build

2012-06-09 Thread Blue Swirl
Thanks, applied. On Sat, Jun 9, 2012 at 1:43 AM, Andreas Färber andreas.faer...@web.de wrote: The file is located in target-ppc/, not hw/. Signed-off-by: Andreas Färber andreas.faer...@web.de Cc: Paolo Bonzini pbonz...@redhat.com Cc: Anthony Liguori anth...@codemonkey.ws Cc: Blue Swirl

Re: [Qemu-devel] [PULL 1.1 0/6] target-xtensa MMU fixes

2012-06-09 Thread Blue Swirl
Thanks, applied all. On Sun, May 27, 2012 at 2:34 PM, Max Filippov jcmvb...@gmail.com wrote: Hello. This series fixes subtle bugs in the xtensa hardware pagewalking implementation and adds more MMU test cases. The following changes since commit aeb29b6459cb9496b38c820f3faff64cf2369d0d:  

Re: [Qemu-devel] [PATCH 1.1] exec: fix TB invalidation after breakpoint insertion/deletion

2012-06-09 Thread Blue Swirl
Thanks, applied. On Sun, May 27, 2012 at 4:21 PM, Max Filippov jcmvb...@gmail.com wrote: tb_invalidate_phys_addr has to be called with the exact physical address of the breakpoint we add/remove, not just the page's base address. Otherwise we easily fail to flush the right TB. This breakage

Re: [Qemu-devel] [PATCH 1.1] target-xtensa: fix CCOUNT for conditional branches

2012-06-09 Thread Blue Swirl
Thanks, applied. On Sun, May 27, 2012 at 11:18 PM, Max Filippov jcmvb...@gmail.com wrote: Taken conditional branches fail to update CCOUNT register because accumulated ccount_delta is reset during translation of non-taken branch. To fix it only update CCOUNT once per conditional branch

Re: [Qemu-devel] [PATCH 2/2] target-xtensa: switch to AREG0-free mode

2012-06-09 Thread Blue Swirl
On Sun, Jun 3, 2012 at 9:06 PM, Max Filippov jcmvb...@gmail.com wrote: Add env parameter to every helper function that needs it, update 'configure' script. Signed-off-by: Max Filippov jcmvb...@gmail.com ---  configure                 |    2 +-  target-xtensa/helper.h    |   54

Re: [Qemu-devel] vm state save/restore question

2012-06-09 Thread Benjamin Herrenschmidt
On Sat, 2012-06-09 at 20:53 +1000, Benjamin Herrenschmidt wrote: Hi folks ! (After some discussion with Andreas ...) I'm looking at sorting out the state save/restore of target-ppc (which means understanding in general how it works in qemu :-) So far I've somewhat figured out that there's

Re: [Qemu-devel] vm state save/restore question

2012-06-09 Thread Andreas Färber
Hi, Am 09.06.2012 13:34, schrieb Benjamin Herrenschmidt: On Sat, 2012-06-09 at 20:53 +1000, Benjamin Herrenschmidt wrote: (After some discussion with Andreas ...) I'm looking at sorting out the state save/restore of target-ppc (which means understanding in general how it works in qemu :-)

[Qemu-devel] [PATCH] Makefile.user: Define CONFIG_USER_ONLY for libuser/

2012-06-09 Thread Andreas Färber
In *-*-user/ build dirs CONFIG_USER_ONLY is defined via config-target.h. In libuser/ it is not defined. Add it via QEMU_CFLAGS. Signed-off-by: Andreas Färber afaer...@suse.de --- Soon needed for cpu.c. Makefile.user |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v2 0/6] Log unimplemented functionality

2012-06-09 Thread Blue Swirl
v2: address Kevin's comments to 5/6 Blue Swirl (6): qemu-log: move logging to qemu-log.c qemu-log: cleanup qemu-log: add log category for unimplemented functionality qemu-log: use LOG_UNIMP for some target CPU cases fdc: use LOG_UNIMP logging qtest: add a fuzz test to fdc-test

[Qemu-devel] [PATCH 3/6] qemu-log: add log category for unimplemented functionality

2012-06-09 Thread Blue Swirl
Add new log category (LOG_UNIMP) for unimplemented functionality. Signed-off-by: Blue Swirl blauwir...@gmail.com --- qemu-log.c |2 ++ qemu-log.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/qemu-log.c b/qemu-log.c index 1dd3de4..1ec70e7 100644 --- a/qemu-log.c

[Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-06-09 Thread Blue Swirl
Move logging functions from exec.c to qemu-log.c, compile it only once. Signed-off-by: Blue Swirl blauwir...@gmail.com --- Makefile.objs |1 + cpu-all.h | 24 - exec.c| 122 --- qemu-log.c| 146

[Qemu-devel] [PATCH 6/6] qtest: add a fuzz test to fdc-test

2012-06-09 Thread Blue Swirl
Add a simple register fuzzing test to floppy controller tests. Signed-off-by: Blue Swirl blauwir...@gmail.com --- tests/fdc-test.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index 22d24ac..676b215 100644 ---

[Qemu-devel] [PATCH 5/6] fdc: use LOG_UNIMP logging

2012-06-09 Thread Blue Swirl
Convert uses of FLOPPY_ERROR to either FLOPPY_DPRINTF (for implemented cases) or to use LOG_UNIMP (unimplemented). Signed-off-by: Blue Swirl blauwir...@gmail.com --- hw/fdc.c | 30 +- 1 files changed, 17 insertions(+), 13 deletions(-) diff --git a/hw/fdc.c

[Qemu-devel] [PATCH 2/6] qemu-log: cleanup

2012-06-09 Thread Blue Swirl
Don't use global variables directly but via accessor functions. Rename globals. Convert macros to functions, add GCC format attributes. Signed-off-by: Blue Swirl blauwir...@gmail.com --- linux-user/main.c|3 +- linux-user/signal.c | 12 ++--- qemu-log.c | 54

[Qemu-devel] [PATCH 4/6] qemu-log: use LOG_UNIMP for some target CPU cases

2012-06-09 Thread Blue Swirl
Use LOG_UNIMP for some target CPU cases. Signed-off-by: Blue Swirl blauwir...@gmail.com Acked-by: Alexander Graf ag...@suse.de --- target-i386/op_helper.c |1 + target-microblaze/translate.c | 11 -- target-ppc/helper.c |2 +- target-s390x/translate.c |2 +-

Re: [Qemu-devel] [PATCH v2 0/6] Log unimplemented functionality

2012-06-09 Thread Andreas Färber
Am 09.06.2012 14:12, schrieb Blue Swirl: v2: address Kevin's comments to 5/6 Blue Swirl (6): qemu-log: move logging to qemu-log.c qemu-log: cleanup qemu-log: add log category for unimplemented functionality qemu-log: use LOG_UNIMP for some target CPU cases fdc: use LOG_UNIMP

[Qemu-devel] How to speed up the CPU logging?

2012-06-09 Thread Yue Chen
Hi, Guy, When I use *log cpu* or *log exec* in the system *-monitor stdio* mode, it's extremely slow(lose my mouse/keyboard control). I used a buffer instead of directly writing log to disk, but even slower. When I give a large memory (-m 4G) to VM, or set the process priority(chrt -f 99) of

Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t

2012-06-09 Thread Laszlo Ersek
On 06/08/12 17:35, Andreas Färber wrote: From: Michael Roth mdr...@linux.vnet.ibm.com This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with some additional bounds checking to avoid

Re: [Qemu-devel] How to speed up the CPU logging?

2012-06-09 Thread Blue Swirl
On Sat, Jun 9, 2012 at 2:37 PM, Yue Chen ycyc...@gmail.com wrote: Hi, Guy, When I use log cpu or log exec in the system -monitor stdio mode, it's extremely slow(lose my mouse/keyboard control). I used a buffer instead of directly writing log to disk, but even slower. When I give a large

Re: [Qemu-devel] How to speed up the CPU logging?

2012-06-09 Thread Yue Chen
Thanks for replying. Do you know any easy way to do that? On Sat, Jun 9, 2012 at 11:02 AM, Blue Swirl blauwir...@gmail.com wrote: On Sat, Jun 9, 2012 at 2:37 PM, Yue Chen ycyc...@gmail.com wrote: Hi, Guy, When I use log cpu or log exec in the system -monitor stdio mode, it's extremely

Re: [Qemu-devel] How to speed up the CPU logging?

2012-06-09 Thread Blue Swirl
On Sat, Jun 9, 2012 at 3:07 PM, Yue Chen ycyc...@gmail.com wrote: Thanks for replying. Do you know any easy way to do that? See for example commit 870be6ad57d38dd630c5d5ac7e01fc5d8b784485. Please don't top post. On Sat, Jun 9, 2012 at 11:02 AM, Blue Swirl blauwir...@gmail.com wrote: On

Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t

2012-06-09 Thread Andreas Färber
Am 09.06.2012 17:03, schrieb Laszlo Ersek: On 06/08/12 17:35, Andreas Färber wrote: From: Michael Roth mdr...@linux.vnet.ibm.com This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall back to visit_type_int() (int64_t) with

Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build

2012-06-09 Thread Edgar E. Iglesias
On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: Hello Edgar and Peter, With the Makefile refactoring applied now, here's the Makefile improvements for MicroBlaze I mentioned. All Xilinx devices that are used for more than one softmmu are compiled once in libhw32. Actually

Re: [Qemu-devel] [PATCH v3 1/4] hw: introduce standard SD host controller

2012-06-09 Thread Andreas Färber
Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite: From: Igor Mitsyanko i.mitsya...@samsung.com Device model for standard SD Host Controller Interface (SDHCI) compliant with version 2.00 of SD association specification. Signed-off-by: Peter A. G. Crosthwaite

Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing

2012-06-09 Thread Laszlo Ersek
On 06/06/12 15:03, Laszlo Ersek wrote: (b) make all Netdev integer types as strict as possible, remove superfluous checks, The net init functions all depend on integer optarg values being non-negative. Originally this is (or should be...) ensured by parse_option_number() [qemu-option.c]

Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build

2012-06-09 Thread Andreas Färber
Am 09.06.2012 17:20, schrieb Edgar E. Iglesias: On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on microblazeel? I wonder if we could change the device from DEVICE_NATIVE_ENDIAN to DEVICE_BIG_ENDIAN and

Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t

2012-06-09 Thread Laszlo Ersek
On 06/09/12 17:16, Andreas Färber wrote: Am 09.06.2012 17:03, schrieb Laszlo Ersek: On 06/08/12 17:35, Andreas Färber wrote: From: Michael Roth mdr...@linux.vnet.ibm.com This adds visitor interfaces for fixed-width integers types. Implementing these in visitors is optional, otherwise we fall

[Qemu-devel] [PATCH v3 00/25] x86 AREG0 conversion

2012-06-09 Thread Blue Swirl
v3: Rebased due to Makefile changes. If there are no objections, I'll apply this next weekend. v2: Rebased. Updated 07/25: removed confused comment and split sse_op_table3 so that void pointers are avoided there too, adjusted 08/25 accordingly. v1: I only sent the tree URL. Blue Swirl (25):

[Qemu-devel] [PATCH 03/25] x86: split off exception handlers

2012-06-09 Thread Blue Swirl
Move exception handlers from op_helper.c to excp_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 + target-i386/cpu.h | 10 +++- target-i386/excp_helper.c | 132 + target-i386/op_helper.c |

[Qemu-devel] [PATCH 04/25] x86: avoid an extern declaration

2012-06-09 Thread Blue Swirl
After the previous patch, we can use the proper declaration in a common header file. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/excp_helper.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/target-i386/excp_helper.c b/target-i386/excp_helper.c

[Qemu-devel] [PATCH 17/25] x86: avoid AREG0 for SVM helpers

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 - target-i386/helper.h | 22 +++--- target-i386/svm_helper.c | 181 ++---

[Qemu-devel] [PATCH 20/25] x86: split off misc helpers

2012-06-09 Thread Blue Swirl
Move various functions to misc_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |3 +- target-i386/cpu.h |2 + target-i386/misc_helper.c | 599 + target-i386/op_helper.c | 580

[Qemu-devel] [PATCH 21/25] x86: avoid AREG0 for misc helpers

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 - target-i386/helper.h | 40 +- target-i386/misc_helper.c | 69 ++---

[Qemu-devel] [PATCH 22/25] x86: split off memory access helpers

2012-06-09 Thread Blue Swirl
Move memory access helpers to mem_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |3 +- target-i386/mem_helper.c | 212 + target-i386/op_helper.c | 189 +--- 3 files

[Qemu-devel] [PATCH 18/25] x86: split off SMM helpers

2012-06-09 Thread Blue Swirl
Move SMM helpers to smm_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |2 + target-i386/op_helper.c | 285 - target-i386/smm_helper.c | 307 + 3 files changed,

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-09 Thread Jeff Cody
On 06/08/2012 05:08 PM, Kevin Wolf wrote: Am 08.06.2012 20:33, schrieb Jeff Cody: On 06/08/2012 01:57 PM, Kevin Wolf wrote: Am 08.06.2012 19:46, schrieb Jeff Cody: On 06/08/2012 12:11 PM, Kevin Wolf wrote: Am 08.06.2012 16:32, schrieb Jeff Cody: On 06/08/2012 09:53 AM, Stefan Hajnoczi wrote:

[Qemu-devel] [PATCH 19/25] x86: avoid AREG0 for SMM helpers

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 - target-i386/helper.h |2 +- target-i386/smm_helper.c | 14 -- target-i386/translate.c |2 +- 4 files changed, 6

[Qemu-devel] [PATCH 10/25] x86: split condition code and shift templates

2012-06-09 Thread Blue Swirl
Move shift templates from helper_template.h to shift_helper_template.h and the condition code helpers to cc_helper_template.h. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/cc_helper_template.h| 277 +++ target-i386/helper_template.h | 353

[Qemu-devel] [PATCH 09/25] x86: fix coding style in helper_template.h

2012-06-09 Thread Blue Swirl
Fix coding style in helper_template.h before next commit. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/helper_template.h | 25 ++--- 1 files changed, 22 insertions(+), 3 deletions(-) diff --git a/target-i386/helper_template.h

[Qemu-devel] [PATCH 25/25] x86: switch to AREG0 free mode

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Remove temporary wrappers and switch to AREG0 free mode. Signed-off-by: Blue Swirl blauwir...@gmail.com --- configure |2 +- cpu-all.h | 22 ++ target-i386/Makefile.objs |2 -

[Qemu-devel] [PATCH 07/25] x86: improve SSE table type safety

2012-06-09 Thread Blue Swirl
SSE function tables could easily be corrupted because of use of void pointers. Introduce function pointer types and helper variables in order to improve type safety. Split sse_op_table3 according to types used. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/translate.c | 134

[Qemu-devel] [PATCH 13/25] x86: avoid AREG0 for condition code helpers

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 - target-i386/cc_helper.c | 199 +-- target-i386/cc_helper_template.h| 36 +++---

[Qemu-devel] [PATCH 15/25] x86: avoid AREG0 for integer helpers

2012-06-09 Thread Blue Swirl
Add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |1 - target-i386/helper.h| 50 +- target-i386/int_helper.c| 36 +-

[Qemu-devel] [PATCH 23/25] x86: use wrappers for memory access helpers

2012-06-09 Thread Blue Swirl
Switch to wrapped versions of memory access functions. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/cpu.h|9 ++ target-i386/mem_helper.c |8 ++ target-i386/op_helper.c | 209 +++--- 3 files changed, 123 insertions(+),

[Qemu-devel] [PATCH 12/25] x86: split off condition code helpers

2012-06-09 Thread Blue Swirl
Move condition code helpers to cc_helper.c. Move the shared inline functions lshift(), cpu_load_eflags() and cpu_cc_compute_all() to cpu.h. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |3 +- target-i386/cc_helper.c | 387

[Qemu-devel] [PATCH 14/25] x86: split off integer helpers

2012-06-09 Thread Blue Swirl
Move integer and bit field helpers to int_helper.c. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/Makefile.objs |3 +- target-i386/int_helper.c | 500 + target-i386/op_helper.c | 478 ---

[Qemu-devel] [PATCH 11/25] x86: prepare eflags helpers for general use

2012-06-09 Thread Blue Swirl
Adjust function names and add an explicit CPUX86State parameter instead of relying on AREG0. Signed-off-by: Blue Swirl blauwir...@gmail.com --- target-i386/op_helper.c | 68 +- 1 files changed, 37 insertions(+), 31 deletions(-) diff --git

[Qemu-devel] [Bug 1002121] Re: disk error when guest boot up via qcow2 image

2012-06-09 Thread Michael Tokarev
I can't reproduce it no matter how I try -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1002121 Title: disk error when guest boot up via qcow2 image Status in QEMU: New Bug description: Host

Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t

2012-06-09 Thread Michael Roth
On Sat, Jun 09, 2012 at 05:33:14PM +0200, Laszlo Ersek wrote: On 06/09/12 17:16, Andreas Färber wrote: Am 09.06.2012 17:03, schrieb Laszlo Ersek: On 06/08/12 17:35, Andreas Färber wrote: From: Michael Roth mdr...@linux.vnet.ibm.com This adds visitor interfaces for fixed-width integers

Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build

2012-06-09 Thread Edgar E. Iglesias
On Sat, Jun 09, 2012 at 05:31:39PM +0200, Andreas Färber wrote: Am 09.06.2012 17:20, schrieb Edgar E. Iglesias: On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: xilinx_ethlite.c uses tswap32(). Have you ever tested this device to work on microblazeel? I wonder if we could

Re: [Qemu-devel] [PATCH 1.1] monitor: Fix memory leak with readline completion

2012-06-09 Thread Stefan Weil
Am 22.05.2012 22:24, schrieb Stefan Weil: Am 14.05.2012 21:47, schrieb Stefan Weil: Each string which is shown during readline completion in the QEMU monitor is allocated dynamically but currently never deallocated. Add the missing loop which calls g_free for the allocated strings.

[Qemu-devel] [PATCH qom-next v2 1/7] make_device_config.sh: Fix target path in generated dependency file

2012-06-09 Thread Andreas Färber
config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual config-devices.mak. Symptoms were spurious dependency issues with default-configs/pci.mak. Fix by using `basename` to strip the

[Qemu-devel] [PATCH qom-next v2 2/7] qdev: Push state up to Object

2012-06-09 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com qdev properties use the state member (an embryo of the realized property) in order to disable setting them after a device has been initialized. So, in order to push qdev properties up to Object we need to push this bit there too. Signed-off-by: Paolo

[Qemu-devel] [PATCH qom-next v2 5/7] qdev: Move bulk of qdev-properties.c to qom/object-properties.c

2012-06-09 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com [AF: Move to new qom/object-properties.c, update documentation.] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/qdev-properties.c| 487 +-- hw/qdev.c

[Qemu-devel] [PATCH qom-next v2 0/7] QOM realize, revised again

2012-06-09 Thread Andreas Färber
Hello Anthony and Paolo, This is our QOM remainder from the freeze, please review. v1 - v2: * Reverted Object state enum to bool realized, as requested by Anthony. This means we have no way of detecting if an object was initialized, but that feature was unused so far. * Use gtk-doc Returns:

[Qemu-devel] [PATCH qom-next v2 3/7] qom: Add realized property

2012-06-09 Thread Andreas Färber
Since we had to move the state field from DeviceState to Object, we cannot delay the implementation of the realized property. The property is a trigger for two actions that propagate through the composition tree. Realize is called when the property becomes true, and propagates in pre-order;

[Qemu-devel] [PATCH qom-next v2 7/7] qom: Add QERR_PROPERTY_SET_AFTER_REALIZE

2012-06-09 Thread Andreas Färber
From: Peter Maydell peter.mayd...@linaro.org Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts to set a QOM or qdev property after the object/device has been realized. This allows a slightly more informative diagnostic than the previous Insufficient permission message. Signed-off-by:

Re: [Qemu-devel] [PATCH qom-next v2 1/7] make_device_config.sh: Fix target path in generated dependency file

2012-06-09 Thread Andreas Färber
Am 10.06.2012 03:09, schrieb Andreas Färber: config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual config-devices.mak. Symptoms were spurious dependency issues with

[Qemu-devel] [PATCH qom-next v2 4/7] qdev: Generalize properties to Objects

2012-06-09 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com The property machinery uses DeviceState arguments in a few places. Replace this with Object so that we can push properties up. Signed-off-by: Paolo Bonzini pbonz...@redhat.com [AF: Fixed indentation in set_taddr(), drop use of object_get_id().]