[Qemu-devel] [Bug 1013888] Re: windows xp sp3 setup blank screen on boot

2012-06-15 Thread Michael Sabino
qemu-system-x86_64 -L ../path/to/bios -cdrom winxp.iso -hda winxp.img -boot d where ../path/to/bios is the location of the pc-bios files from that version of qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad

Re: [Qemu-devel] [PATCH v3 00/25] x86 AREG0 conversion

2012-06-15 Thread Blue Swirl
On Sat, Jun 16, 2012 at 12:59 AM, Andreas Färber wrote: > Am 09.06.2012 18:18, schrieb Blue Swirl: >> v3: Rebased due to Makefile changes. If there are no objections, >> I'll apply this next weekend. > > If you have it on some branch to test I'll give it a whirl tomorrow. URL git://repo.or.cz

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Blue Swirl
On Fri, Jun 15, 2012 at 9:36 PM, Paul Moore wrote: > On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: >> On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: >> > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >> >> I think allowing execve() would render seccomp pretty much useless. >

[Qemu-devel] [Bug 1013888] Re: windows xp sp3 setup blank screen on boot

2012-06-15 Thread Michael Sabino
Qemu 1.0.1 - Doesn't have a problem Qemu 1.1.0 - has the problem Qemu master commit eb2aeacf983a2a88a2b31e8fee067c38bd10abd3 - has the problem -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013888 T

[Qemu-devel] [Bug 1013888] [NEW] windows xp sp3 setup blank screen on boot

2012-06-15 Thread Michael Sabino
Public bug reported: When attempting to run Windows XP SP3 setup in qemu on a Lubuntu host with the following kernel: Linux michael-XPS-M1530 3.2.0-23-generic #36-Ubuntu SMP Tue Apr 10 20:39:51 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux Qemu does not get past a blank screen after "Setup is inspecti

[Qemu-devel] [PATCH v1 2/2] xilinx_timer: Fixed deadlock issue

2012-06-15 Thread Peter A. G. Crosthwaite
The timer was deadlocking when the interval was set too low. It would cause a flood of timer events and the CPU would halt indefinately. This is a known issue and theres a generic workaround in place in ptimer on ptimer_set_limit(), however the Xilinx timer uses ptimer_set_count() instead of set_li

[Qemu-devel] [PATCH v1 1/2] xilinx_timer: Removed include of qemu-timer

2012-06-15 Thread Peter A. G. Crosthwaite
The Xilinx timer does not interact with the qemu_timer API, so dont include it. Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_timer.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_timer.c b/hw/xilinx_timer.c index 0683ce1..e8b7a59 100644 --- a/hw/xilin

[Qemu-devel] [PATCH v1 0/2] Xilinx Timer updates

2012-06-15 Thread Peter A. G. Crosthwaite
Patch 1 is trival, just deleted a redundant include that shouldn't be there. Patch 2 is a major bugfix for Microblaze platforms - the timer was deadlocking the system. Peter A. G. Crosthwaite (2): xilinx_timer: Removed include of qemu-timer xilinx_timer: Fixed deadlock issue hw/xilinx_timer.

Re: [Qemu-devel] [PATCH 0/3] xilinx: Speed up the build

2012-06-15 Thread Peter Crosthwaite
On Sat, Jun 16, 2012 at 12:52 AM, Andreas Färber wrote: > Am 15.06.2012 13:13, schrieb Edgar E. Iglesias: >> On Sat, Jun 09, 2012 at 03:54:28AM +0200, Andreas Färber wrote: >>> Hello Edgar and Peter, >>> >>> With the Makefile refactoring applied now, here's the Makefile improvements >>> for MicroB

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-15 Thread Edgar E. Iglesias
On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote: > Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite: > > Changed device name to xlnx,axi-dma. This is the exact name of the device > > in the > > Xilinx EDK development tools. > > > > Signed-off-by: Peter A. G. Crosthwaite > > S

Re: [Qemu-devel] [PATCH v3 00/25] x86 AREG0 conversion

2012-06-15 Thread Andreas Färber
Am 09.06.2012 18:18, schrieb Blue Swirl: > v3: Rebased due to Makefile changes. If there are no objections, > I'll apply this next weekend. If you have it on some branch to test I'll give it a whirl tomorrow. Andreas > > v2: Rebased. Updated 07/25: removed confused comment and split > sse_op_ta

[Qemu-devel] [qom-next] Bisecting virtio-scsi issue

2012-06-15 Thread Andreas Färber
Hi, After multiple runs of not-so-successful bisecting, it appears as if the qom-next commit "qbus: Make child devices links" [1] is causing assertions for both virtio-scsi and ahci but not for qemu-system-x86_64 without parameters: $ x86_64-softmmu/qemu-system-x86_64 -enable-kvm -device virtio-s

Re: [Qemu-devel] [RFC PATCH 36/36] mirror: allow customizing the granularity

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The desired granularity may be very different depending on the kind of > operation > (e.g. continous replication vs. collapse-to-raw) and whether the VM is > expected > to perform lots of I/O while mirroring is in progress. Allow the user to > cust

Re: [Qemu-devel] [RFC PATCH 30/36] add hierarchical bitmap data type and test cases

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > HBitmaps provides an array of bits. The bits are stored as usual in an > array of unsigned longs, but HBitmap is also optimized to provide fast > iteration over set bits; going from one bit to the next is O(log log n) > worst case, which is low enough

Re: [Qemu-devel] [PATCHv3 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Benjamin Herrenschmidt
On Fri, 2012-06-15 at 22:40 -0400, Li Zhang wrote: > For pseries machine, it needs to enable usb to add > keyboard or usb mouse. -usb option won't be used in > the future, and machine options is a better way to > enable usb. Patch looks much better. Now, should we also create the default keyboard

Re: [Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen

2012-06-15 Thread Eric Blake
On 06/15/2012 02:48 PM, Supriya Kannery wrote: > raw-posix driver changes for bdrv_reopen_xx functions to > safely reopen image files. Reopening of image files while > changing hostcache dynamically is handled here. > > Signed-off-by: Supriya Kannery > > > +static int raw_reopen_prepare(Bloc

Re: [Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely

2012-06-15 Thread Eric Blake
On 06/15/2012 02:47 PM, Supriya Kannery wrote: > Struct BDRVReopenState along with three reopen related functions > introduced for handling reopening of images safely. This can be > extended by each of the block drivers to reopen respective > image files. > > Signed-off-by: Supriya Kannery > >

Re: [Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-06-15 Thread Eric Blake
On 06/15/2012 02:47 PM, Supriya Kannery wrote: > New command "block_set_hostcache" added for dynamically changing > host pagecache setting of a block device. > > Usage: > block_set_hostcache > = block device > = on/off > > Example: > (qemu) block_set_hostcache ide0-hd0 off > > Sig

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Eric Blake
On 06/15/2012 03:23 PM, Blue Swirl wrote: > How about seccomp mode selected by command line switch -seccomp, in > which bind/connect/open/execve are forbidden? The functionality > remaining would be somewhat limited (can't migrate or use SMB etc. More properly, can't migrate with exec:command mig

Re: [Qemu-devel] [RFC PATCH 28/36] block: add block-job-complete

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > While streaming can be dropped as soon as it progressed through the whole > image, mirroring needs to be completed manually for two reasons: 1) so that > management knows exactly when the VM switches to the target; 2) because > for other use cases such

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Paul Moore
On Friday, June 15, 2012 09:23:46 PM Blue Swirl wrote: > On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: > > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > >> I think allowing execve() would render seccomp pretty much useless. > > > > Not necessarily. > > > > I'll agree that it does

[Qemu-devel] [v1 Patch 6/10]Qemu: raw-win32 image file reopen

2012-06-15 Thread Supriya Kannery
raw-win32 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Signed-off-by: Shrinidhi Joshi Index: qemu/block/raw-win32.c

[Qemu-devel] [v1 Patch 5/10]Qemu: raw-posix image file reopen

2012-06-15 Thread Supriya Kannery
raw-posix driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Index: qemu/block/raw.c === --- qemu.

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Blue Swirl
On Fri, Jun 15, 2012 at 9:02 PM, Paul Moore wrote: > On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: >> I think allowing execve() would render seccomp pretty much useless. > > Not necessarily. > > I'll agree that it does seem a bit odd to allow execve(), but there is still > value in enabli

[Qemu-devel] [v1 Patch 2/10]Qemu: Error classes for hostcache setting and data sync failures

2012-06-15 Thread Supriya Kannery
New error classes defined for hostcache setting and data sync error Signed-off-by: Supriya Kannery --- qerror.c |8 qerror.h |6 ++ 2 files changed, 14 insertions(+) Index: qemu/qerror.c === --- qemu.orig/qer

Re: [Qemu-devel] [RFC PATCH 26/36] block: live snapshot documentation tweaks

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json |4 > 1 file changed, 4 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 2ee988b..250edf2 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -1289,6

Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > (Mostly untested). > > Signed-off-by: Paolo Bonzini > --- > block/mirror.c | 50 +- > block_int.h |4 > blockdev.c | 14 -- > hmp.c|3 ++- > qapi-s

[Qemu-devel] [v1 Patch 4/10]Qemu: Framework for reopening image files safely

2012-06-15 Thread Supriya Kannery
Struct BDRVReopenState along with three reopen related functions introduced for handling reopening of images safely. This can be extended by each of the block drivers to reopen respective image files. Signed-off-by: Supriya Kannery Index: qemu/block.c

[Qemu-devel] [v1 Patch 9/10]Qemu: qcow image file reopen

2012-06-15 Thread Supriya Kannery
qcow driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Shrinidhi Joshi Index: qemu/block/qcow.c === --- qemu.orig/

Re: [Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting

2012-06-15 Thread Eric Blake
On 06/15/2012 02:47 PM, Supriya Kannery wrote: > Enhance "info block" to display hostcache setting for each > block device. > > ## > { 'type': 'BlockInfo', >'data': {'device': 'str', 'type': 'str', 'removable': 'bool', > - 'locked': 'bool', '*inserted': 'BlockDeviceInfo', > +

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Paul Moore
On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: > I think allowing execve() would render seccomp pretty much useless. Not necessarily. I'll agree that it does seem a bit odd to allow execve(), but there is still value in enabling seccomp to disable potentially buggy/exploitable syscalls.

Re: [Qemu-devel] CoW image commit+shrink(= make_empty) support

2012-06-15 Thread Supriya Kannery
On 06/14/2012 11:58 PM, Supriya Kannery wrote: On 06/14/2012 07:59 PM, Jeff Cody wrote: On 06/14/2012 10:23 AM, Zhi Hui Li wrote: On 2012年06月11日 23:37, Jeff Cody wrote: On 06/11/2012 10:24 AM, Stefan Hajnoczi wrote: On Mon, Jun 11, 2012 at 1:50 PM, Kevin Wolf wrote: Am 11.06.2012 14:09, schr

[Qemu-devel] [v1 Patch 8/10]Qemu: qcow2 image file reopen

2012-06-15 Thread Supriya Kannery
qcow2 driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Index: qemu/block/qcow2.c === --- qemu.ori

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Corey Bryant
On 06/15/2012 04:00 PM, Eric Blake wrote: On 06/15/2012 01:19 PM, Corey Bryant wrote: There are some flags that I don't think we'll be able to change. For example: O_RDONLY, O_WRONLY, O_RDWR. I assume libvirt would open all files O_RDWR. I think we need to check all of them and fail qemu_

[Qemu-devel] [v1 Patch 10/10]Qemu: qed image file reopen

2012-06-15 Thread Supriya Kannery
qed driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Index: qemu/block/qed.c === --- qemu.orig/bl

[Qemu-devel] [v1 Patch 7/10]Qemu: vmdk image file reopen

2012-06-15 Thread Supriya Kannery
vmdk driver changes for bdrv_reopen_xx functions to safely reopen image files. Reopening of image files while changing hostcache dynamically is handled here. Signed-off-by: Supriya Kannery Index: qemu/block/vmdk.c === --- qemu.orig/

[Qemu-devel] [v1 Patch 3/10]Qemu: Cmd "block_set_hostcache" for dynamic cache change

2012-06-15 Thread Supriya Kannery
New command "block_set_hostcache" added for dynamically changing host pagecache setting of a block device. Usage: block_set_hostcache = block device = on/off Example: (qemu) block_set_hostcache ide0-hd0 off Signed-off-by: Supriya Kannery --- block.c | 54 +

[Qemu-devel] [v1 Patch 1/10]Qemu: Enhance "info block" to display host cache setting

2012-06-15 Thread Supriya Kannery
Enhance "info block" to display hostcache setting for each block device. Example: (qemu) info block ide0-hd0: removable=0 file=../rhel6-32.raw ro=0 drv=raw encrypted=0 Enhanced to display "hostcache" setting: (qemu) info block ide0-hd0: removable=0 hostcache=1 file=../rhel6-32.raw ro=0 drv=raw en

[Qemu-devel] [v1 Patch 0/10]Qemu: Dynamic host pagecache change and image file reopen

2012-06-15 Thread Supriya Kannery
For changing host pagecache setting of a running VM, it is important to have a safe way of reopening its image file. Following patchset introduces: * a generic way to reopen image files safely. In this approach, before reopening an image, for each block driver, its state will be sta

Re: [Qemu-devel] [RFC PATCH 23/36] qmp: add drive-mirror command

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > This adds the monitor commands that start the mirroring job. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 120 > -- > hmp-commands.hx | 21 ++ > hmp.c| 28

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Eric Blake
On 06/15/2012 01:19 PM, Corey Bryant wrote: >>> There are some flags that I don't think we'll be able to change. For >>> example: O_RDONLY, O_WRONLY, O_RDWR. I assume libvirt would open all >>> files O_RDWR. >> >> I think we need to check all of them and fail qemu_open() if they don't >> match.

[Qemu-devel] [Bug 1013714] Re: Data corruption after block migration (LV->LV)

2012-06-15 Thread Dennis Krul
Hello Paolo, Thank you for your quick response! Did you intend to mention 3 different commits or did you accidentally paste the same commit thrice? ;) I came across that commit but somehow thought it was already included in 0.13. Thanks! We're of course in no position to ask, but I'll do it anyw

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-15 Thread Blue Swirl
On Thu, Jun 14, 2012 at 12:35 PM, YeongKyoon Lee wrote: > Hi, > > I proposed QEMU ld/st optimizations two times, late last year and early this > year, however, there was no replies and even more 0/3 patch mail in this year > has been missed so I cannot find the mail in QEMU mail archives. :( > T

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Corey Bryant
On 06/15/2012 02:46 PM, Kevin Wolf wrote: Am 15.06.2012 20:16, schrieb Corey Bryant: On 06/15/2012 11:16 AM, Eric Blake wrote: On 06/14/2012 09:55 AM, Corey Bryant wrote: This patch adds support to qemu_open to dup(fd) a pre-opened file descriptor if the filename is of the format /dev/fd/X

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Paolo Bonzini
Il 15/06/2012 19:48, Anthony Liguori ha scritto: >> So I guess we can proceed with errno values, yuppy! > > Yes, but I reserve the right to nack abuses :-) I will help, don't worry. Paolo

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-15 Thread Lluís Vilanova
Laurent Desnogues writes: > On Fri, Jun 15, 2012 at 12:30 AM, Lluís Vilanova wrote: > [...] >> Now that I think of it, you will have problems generating code to surround >> each >> qemu_ld/st with a lightweight mechanism to get the time. In x86 it would be >> rdtsc, but you want to generate a ho

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Corey Bryant
On 06/15/2012 02:42 PM, Eric Blake wrote: On 06/15/2012 12:16 PM, Corey Bryant wrote: I think you need to honor flags so that the end use of the fd will be as if qemu had directly opened the file, rather than just doing a blind dup with a resulting fd that is in a different state than the cal

Re: [Qemu-devel] [PATCH] Makefile: Fix linker failure for vscclient

2012-06-15 Thread Blue Swirl
On Wed, Jun 13, 2012 at 8:45 PM, Stefan Weil wrote: > When QEMU was built with the simple trace backend, linking failed: > >  LINK  vscclient > oslib-posix.o: In function `trace_qemu_memalign': > qemu/bin/debug/x86/./trace.h:31: undefined reference to `trace3' > oslib-posix.o: In function `trace_q

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Blue Swirl
On Wed, Jun 13, 2012 at 8:30 PM, Daniel P. Berrange wrote: > On Wed, Jun 13, 2012 at 04:20:22PM -0300, Eduardo Otubo wrote: >> I added a syscall struct using priority levels as described in the >> libseccomp man page. The priority numbers are based to the frequency >> they appear in a sample strac

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-15 Thread Blue Swirl
On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange wrote: > On Wed, Jun 13, 2012 at 07:56:06PM +, Blue Swirl wrote: >> On Wed, Jun 13, 2012 at 7:20 PM, Eduardo Otubo >> wrote: >> > I added a syscall struct using priority levels as described in the >> > libseccomp man page. The priority numb

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Kevin Wolf
Am 15.06.2012 20:16, schrieb Corey Bryant: > > > On 06/15/2012 11:16 AM, Eric Blake wrote: >> On 06/14/2012 09:55 AM, Corey Bryant wrote: >>> This patch adds support to qemu_open to dup(fd) a pre-opened file >>> descriptor if the filename is of the format /dev/fd/X. >>> >> >>> +++ b/osdep.c >>> @

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Eric Blake
On 06/15/2012 12:16 PM, Corey Bryant wrote: >> I think you need to honor flags so that the end use of the fd will be as >> if qemu had directly opened the file, rather than just doing a blind dup >> with a resulting fd that is in a different state than the caller >> expected. I can think of at le

Re: [Qemu-devel] [PATCH v3 4/5] block: Convert open calls to qemu_open

2012-06-15 Thread Corey Bryant
On 06/15/2012 11:21 AM, Eric Blake wrote: On 06/14/2012 09:55 AM, Corey Bryant wrote: This patch converts all block layer open calls to qemu_open. This enables all block layer open paths to dup(X) a pre-opened file descriptor if the filename is of the format /dev/fd/X. This is useful if QEMU

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-15 Thread Markus Armbruster
Li Zhang writes: > On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster wrote: >> Li Zhang writes: >> >>> For pseries machine, it needs to enable usb to add >>> keyboard or usb mouse. -usb option won't be used in >>> the future, and machine options is a better way to >>> enable usb. >>> >>> So th

Re: [Qemu-devel] [RFC PATCH 22/36] block: add mirror job

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > This patch adds the implementation of a new job that mirrors a disk to > a new image while letting the guest continue using the old image. > The target is treated as a "black box" and data is copied from the > source to the target in the background. >

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-15 Thread Corey Bryant
On 06/15/2012 11:16 AM, Eric Blake wrote: On 06/14/2012 09:55 AM, Corey Bryant wrote: This patch adds support to qemu_open to dup(fd) a pre-opened file descriptor if the filename is of the format /dev/fd/X. +++ b/osdep.c @@ -82,6 +82,19 @@ int qemu_open(const char *name, int flags, ...)

Re: [Qemu-devel] q35 chipset support

2012-06-15 Thread Anthony Liguori
On 06/15/2012 12:57 PM, Jason Baron wrote: On Thu, Jun 14, 2012 at 03:16:03PM -0500, Anthony Liguori wrote: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios trees. On the qemu side, most of the changes revolve

[Qemu-devel] [PATCH 4/8] monitor: Fix memory leak with readline completion

2012-06-15 Thread Luiz Capitulino
From: Stefan Weil Each string which is shown during readline completion in the QEMU monitor is allocated dynamically but currently never deallocated. Add the missing loop which calls g_free for the allocated strings. Signed-off-by: Stefan Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Luiz

Re: [Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > This patch adds support for error management to streaming. > > Signed-off-by: Paolo Bonzini > --- > block/stream.c | 28 +++- > block_int.h |3 ++- > blockdev.c | 11 --- > hmp.c|3

Re: [Qemu-devel] q35 chipset support

2012-06-15 Thread Anthony Liguori
On 06/15/2012 02:04 AM, Markus Armbruster wrote: Anthony Liguori writes: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios trees. On the qemu side, most of the changes revolved around updating to use QOM and

[Qemu-devel] [PATCH 6/8] Add event notification for guest balloon changes

2012-06-15 Thread Luiz Capitulino
From: "Daniel P. Berrange" After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest has reacted to this request. The virtio-balloon backend knows exactly when the guest has reacted though, and thus it is possible to emit a JSON eve

Re: [Qemu-devel] q35 chipset support

2012-06-15 Thread Jason Baron
On Thu, Jun 14, 2012 at 03:16:03PM -0500, Anthony Liguori wrote: > On 06/14/2012 02:54 PM, Jason Baron wrote: > >Hi, > > > >I recently updated Isaku Yamahata's q35 patches to work on the latest qemu > >and > >seabios trees. On the qemu side, most of the changes revolved around updating > >to use Q

Re: [Qemu-devel] [RFC PATCH 13/36] block: introduce block job error

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The following behaviors are possible: > > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediately > with an error code. > > 'ignore': An I/O error, respectively during a

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Anthony Liguori
On 06/15/2012 11:55 AM, Paolo Bonzini wrote: Il 15/06/2012 18:52, Anthony Liguori ha scritto: Having an error like: { 'error': 'OpenFileFailed', 'file': 'filename', 'mode': 'r/w', 'os_error': 'enospc' } is actually pretty reasonable for something like a memory dump command where the user speci

[Qemu-devel] [PATCH 2/8] qmp: include monitor.h when needed

2012-06-15 Thread Luiz Capitulino
From: Paolo Bonzini This is needed to get file descriptors from SCM_RIGHTS. Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- hmp.c | 1 + net/tap.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 2ce8cb9..b9cec1d 100644 --- a/hmp.c +++ b/hmp.c @@ -

Re: [Qemu-devel] [RFC PATCH 12/36] block: sort BlockDeviceIoStatus errors by severity

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > +++ b/qapi-schema.json > @@ -429,7 +429,7 @@ > # > # Since: 1.0 > ## > -{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ] } > +{ 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'nospace', 'failed' ] } Isn't this an ABI change?

[Qemu-devel] [PATCH 8/8] build: install qmp-commands.txt

2012-06-15 Thread Luiz Capitulino
From: Bruce Rogers File is targeted for install, but is never installed. Signed-off-by: Bruce Rogers Signed-off-by: Luiz Capitulino --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 32550cb..74f5c5f 100644 --- a/Makefile +++ b/Makefile @@ -272,6 +272,7

Re: [Qemu-devel] [RFC PATCH 06/36] qmp: add block-job-pause and block-job-resume

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Add QMP commands matching the functionality. > > Paused jobs cannot be canceled without first resuming them. This > ensures that I/O errors are never missed by management. However, an > optional force argument can be specified to allow that. > > Si

[Qemu-devel] [PATCH 3/8] qmp: do not include monitor.h from qapi-types-core.h

2012-06-15 Thread Luiz Capitulino
From: Paolo Bonzini The comment is stale, monitor.h is not needed anymore (only qerror.h is, because it contains the schema for errors). Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- qapi/qapi-types-core.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 5/8] Fix some more license versions (GPL2+ instead of GPL2)

2012-06-15 Thread Luiz Capitulino
From: Stefan Weil Cc: Wen Congyang Signed-off-by: Stefan Weil Signed-off-by: Wen Congyang Signed-off-by: Luiz Capitulino --- memory_mapping-stub.c | 4 ++-- memory_mapping.c | 4 ++-- memory_mapping.h | 4 ++-- target-i386/arch_dump.c |

[Qemu-devel] [PATCH 1/8] kvm: add missing include files

2012-06-15 Thread Luiz Capitulino
From: Paolo Bonzini These are included via monitor.h right now, add them explicitly. Signed-off-by: Paolo Bonzini Signed-off-by: Luiz Capitulino --- kvm-all.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index 4ea7d85..f8e4328 100644 --- a/kvm-all.c +++ b/kvm-al

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Kevin Wolf
Am 15.06.2012 19:02, schrieb Luiz Capitulino: > On Fri, 15 Jun 2012 11:52:57 -0500 > Anthony Liguori wrote: > >> On 06/13/2012 12:49 PM, Luiz Capitulino wrote: >>> On Thu, 31 May 2012 16:54:47 +0200 >>> Paolo Bonzini wrote: >>> Wait, I think you're conflating two things. One is "d

Re: [Qemu-devel] [RFC PATCH 05/36] block: add support for job pause/resume

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Job pausing reuses the existing support for cancellable sleeps. A pause > happens at the next sleeping point and lasts until the coroutine is > re-entered explicitly. Cancellation was already doing a forced resume, > so implement it explicitly in ter

Re: [Qemu-devel] [libvirt] [PATCH 2/2] qemu_agent: Wait for events instead of agent response

2012-06-15 Thread Eric Blake
On 06/15/2012 10:10 AM, Michal Privoznik wrote: > With latest changes to qemu-ga success on some commands is not reported > anymore, e.g. guest-shutdown or guest-suspend-*. However, errors are > still being reported. Therefore, we need to find different source of > indication if operation was succe

[Qemu-devel] [Bug 1013691] Re: ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2012-06-15 Thread Richard W.M. Jones
Yes, that works fine, both disks seen by the guest. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013691 Title: ppc64 + virtio-scsi: only first scsi disk shows up in the guest Status in QEMU: N

[Qemu-devel] [PATCH 7/8] Add rate limiting of RTC_CHANGE, BALLOON_CHANGE & WATCHDOG events

2012-06-15 Thread Luiz Capitulino
From: "Daniel P. Berrange" Allow certain event types to be rate limited to avoid flooding monitor clients. The monitor_protocol_event() method is changed such that instead of immediately emitting the event to Monitor instances, it will call a new monitor_protocol_event_queue() method. This will

[Qemu-devel] [PULL 0/8]: QMP queue

2012-06-15 Thread Luiz Capitulino
Anthony, This pull contains mostly fixes and the new BALLOON_CHANGE event with rate limiting support. The changes (since 63bb682a18acc5d2f3219ea96c4d81c1a3b50748) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Bruce Rogers (1): build: insta

Re: [Qemu-devel] [libvirt] [PATCH 1/2] qemu_agent: Add some more debug prints

2012-06-15 Thread Eric Blake
On 06/15/2012 10:10 AM, Michal Privoznik wrote: > for agent ref count and qemuProcessHandleAgentDestroy > --- > src/qemu/qemu_agent.c |3 ++- > src/qemu/qemu_process.c |2 ++ > 2 files changed, 4 insertions(+), 1 deletions(-) ACK. -- Eric Blake ebl...@redhat.com+1-919-301-3266 L

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 11:52:57AM -0500, Anthony Liguori wrote: > On 06/13/2012 12:49 PM, Luiz Capitulino wrote: > No, you're confusing things I think. { 'error': 'NoSpace' } is bad. > errno is not an intrinsically bad thing but errno critically relies > on the *caller* to understand the context

Re: [Qemu-devel] [PATCH v3] s390: autodetect map private

2012-06-15 Thread Jan Kiszka
On 2012-06-15 17:10, Christian Borntraeger wrote: > By default qemu will use MAP_PRIVATE for guest pages. This will write > protect pages and thus break on s390 systems that dont support this feature. > Therefore qemu has a hack to always use MAP_SHARED for s390. But MAP_SHARED > has other problems

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:52:57 -0500 Anthony Liguori wrote: > On 06/13/2012 12:49 PM, Luiz Capitulino wrote: > > On Thu, 31 May 2012 16:54:47 +0200 > > Paolo Bonzini wrote: > > > >> Wait, I think you're conflating two things. > >> > >> One is "do not shoehorn errors into errno values". So for QOM

[Qemu-devel] [Bug 1013714] Re: Data corruption after block migration (LV->LV)

2012-06-15 Thread Paolo Bonzini
Hi, I suggest that you try a newer version. There were several fixes that I think went only in 0.14, in particular commit 62155e2b51e3c282ddc30adbb6d7b8d3bb7c386e, commit 62155e2b51e3c282ddc30adbb6d7b8d3bb7c386e, commit 62155e2b51e3c282ddc30adbb6d7b8d3bb7c386e. RHEL6.2 doesn't have them. With the f

Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-06-15 Thread Paolo Bonzini
Il 15/06/2012 18:51, Eric Blake ha scritto: > Looks reasonable, but it will affect libvirt: Right now, libvirt parses > the particular return code (qemu_monitor.c:qemuMonitorJSONBlockJob), and > translates > > DeviceNotActive => "No active operation on device" > ... > all others => "Unexpected er

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Paolo Bonzini
Il 15/06/2012 18:52, Anthony Liguori ha scritto: > Having an error like: > > { 'error': 'OpenFileFailed', 'file': 'filename', 'mode': 'r/w', > 'os_error': 'enospc' } > > is actually pretty reasonable for something like a memory dump command > where the user specifies a file. > > OTOH, for someth

Re: [Qemu-devel] [PATCH] build: install qmp-commands.txt

2012-06-15 Thread Luiz Capitulino
On Wed, 13 Jun 2012 16:29:17 -0600 Bruce Rogers wrote: > File is targeted for install, but is never installed. I've applied this to the qmp branch. But note that the qapi-schema.json is going to supersede qmp-commands.txt for the 1.2 release and we'll generate a new qmp spec from it. Thanks.

Re: [Qemu-devel] Adding errno to QMP errors

2012-06-15 Thread Anthony Liguori
On 06/13/2012 12:49 PM, Luiz Capitulino wrote: On Thu, 31 May 2012 16:54:47 +0200 Paolo Bonzini wrote: Wait, I think you're conflating two things. One is "do not shoehorn errors into errno values". So for QOM invalid values we have PropertyValueBad, not a generic InvalidArgument value. We c

Re: [Qemu-devel] [RFC PATCH 02/36] qerror/block: introduce QERR_BLOCK_JOB_NOT_ACTIVE

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The DeviceNotActive error is not a particularly good match, add > a separate one. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c |4 ++-- > qapi-schema.json |5 ++--- > qerror.c |4 > qerror.h |3 +++ >

Re: [Qemu-devel] [RFC PATCH 01/36] qapi: generalize documentation of streaming commands

2012-06-15 Thread Eric Blake
On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Talk about background operations in general, rather than specifically > about streaming. > > Signed-off-by: Paolo Bonzini > --- > hmp-commands.hx |2 +- > qapi-schema.json | 17 - > 2 files changed, 9 insertions(+), 10 deletio

Re: [Qemu-devel] [PATCH v3 0/2] Balloon event change notifications

2012-06-15 Thread Luiz Capitulino
On Thu, 14 Jun 2012 18:12:55 +0100 "Daniel P. Berrange" wrote: > This is a followup to: > > https://lists.gnu.org/archive/html/qemu-devel/2012-05/msg02833.html Applied to the qmp branch, thanks Daniel.

[Qemu-devel] [RFC PATCH 20/36] block: forward bdrv_iostatus_reset to block job

2012-06-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- block.c|3 +++ blockjob.c |7 +++ blockjob.h | 12 3 files changed, 22 insertions(+) diff --git a/block.c b/block.c index 5d293a0..f1afdd6 100644 --- a/block.c +++ b/block.c @@ -4123,6 +4123,9 @@ void bdrv_iostatus_reset(BlockDriver

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:29:03 -0400 Corey Bryant wrote: > >> I'm not clear on what the problem is with returning the same error class > >> for two different errors. Could you explain? I don't have a problem > >> changing it if it's an issue. > > > > Because an mngt app/user won't know if what ha

[Qemu-devel] [PATCH 01/39] qcow2: remove a line of unnecessary code

2012-06-15 Thread Kevin Wolf
From: Zhi Yong Wu Commit 3948d1d4 removed the pointer argument we filled in with l2_offset but forgot to remove the unnecessary l2_offset assignment. Signed-off-by: Zhi Yong Wu Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/qcow2-cluster.c |1 - 1 files changed, 0 inser

[Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument

2012-06-15 Thread Paolo Bonzini
This patch adds support for error management to streaming. Signed-off-by: Paolo Bonzini --- block/stream.c | 28 +++- block_int.h |3 ++- blockdev.c | 11 --- hmp.c|3 ++- qapi-schema.json |9 ++--- qmp-commands.hx |

[Qemu-devel] [Bug 1013691] Re: ppc64 + virtio-scsi: only first scsi disk shows up in the guest

2012-06-15 Thread Paolo Bonzini
Can you test whether the spapr-vscsi controller works instead? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1013691 Title: ppc64 + virtio-scsi: only first scsi disk shows up in the guest Status i

[Qemu-devel] [PATCH 12/39] rbd: hook up cache options

2012-06-15 Thread Kevin Wolf
From: Josh Durgin Writeback caching was added in Ceph 0.46, and writethrough will be in 0.47. These are controlled by general config options, so there's no need to check for librbd version. Signed-off-by: Josh Durgin Signed-off-by: Kevin Wolf --- block/rbd.c | 19 +++ 1 file

[Qemu-devel] [RFC PATCH 23/36] qmp: add drive-mirror command

2012-06-15 Thread Paolo Bonzini
This adds the monitor commands that start the mirroring job. Signed-off-by: Paolo Bonzini --- blockdev.c | 120 -- hmp-commands.hx | 21 ++ hmp.c| 28 + hmp.h|1 + qapi-schema.json |

[Qemu-devel] [RFC PATCH 09/36] block: rename BlockErrorAction, BlockQMPEventAction

2012-06-15 Thread Paolo Bonzini
We want to remove knowledge of BLOCK_ERR_STOP_ENOSPC from drivers, so free up the nicer BlockErrorAction name for them. Do not change the enums. Signed-off-by: Paolo Bonzini --- block.c |8 block.h | 12 ++-- block_int.h |2 +- hw/ide/core.c |

[Qemu-devel] [RFC PATCH 32/36] block: make round_to_clusters public

2012-06-15 Thread Paolo Bonzini
This is needed in the following patch. Signed-off-by: Paolo Bonzini --- block.c | 16 block.h |4 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index a105f9e..35ceed5 100644 --- a/block.c +++ b/block.c @@ -1456,10 +1456,10 @@ static

[Qemu-devel] [RFC PATCH 28/36] block: add block-job-complete

2012-06-15 Thread Paolo Bonzini
While streaming can be dropped as soon as it progressed through the whole image, mirroring needs to be completed manually for two reasons: 1) so that management knows exactly when the VM switches to the target; 2) because for other use cases such as replication, we may leave the operation running f

[Qemu-devel] [RFC PATCH 25/36] mirror: add support for on_source_error/on_target_error

2012-06-15 Thread Paolo Bonzini
(Mostly untested). Signed-off-by: Paolo Bonzini --- block/mirror.c | 50 +- block_int.h |4 blockdev.c | 14 -- hmp.c|3 ++- qapi-schema.json |7 ++- qmp-commands.hx |8 +++- 6

  1   2   3   >