Re: [Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Monday, August 06, 2012 9:27 PM > To: Bhushan Bharat-R65777 > Cc: qemu-devel@nongnu.org; Avi Kivity > Subject: Re: Running KVM guest on X86 > > On Mon, 2012-08-06 at 15:40 +, Bhushan Bharat-R6577

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Peter Crosthwaite
On Tue, Aug 7, 2012 at 4:28 PM, Igor Mitsyanko wrote: > On 08/07/2012 10:10 AM, Peter Crosthwaite wrote: + +extern const VMStateDescription vmstate_fifo8; + +#define VMSTATE_FIFO8(_field, _state) { \ +.name = (stringify(_field)),

[Qemu-devel] [PATCH] Allow QEMUMachine to override reset sequencing

2012-08-06 Thread David Gibson
qemu_system_reset() function always performs the same basic actions on all machines. This includes running all the reset handler hooks, however the order in which these will run is not always easily predictable. This patch splits the core of qemu_system_reset() - the invocation of the reset handl

Re: [Qemu-devel] [PATCH v6 1/4] hw: introduce standard SD host controller

2012-08-06 Thread Peter Crosthwaite
>>> +sdhci_update_irq(s); >>> +break; >>> +} >>> +} >>> +} >> >> So I think the guest can make this loop never terminate if it sets up >> a loop of ACT_LINK descriptors, right? I don't know how we should >> handle this but I'm pretty sure "make qemu sit there for

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Igor Mitsyanko
On 08/07/2012 10:10 AM, Peter Crosthwaite wrote: + +extern const VMStateDescription vmstate_fifo8; + +#define VMSTATE_FIFO8(_field, _state) { \ +.name = (stringify(_field)), \ +.size = sizeof(Fifo8),

[Qemu-devel] [PATCH v3] fix info qtree indention

2012-08-06 Thread Gerd Hoffmann
Without the patch bus properties are are not in line with the other properties: [ ... ] dev: fw_cfg, id "" ctl_iobase = 0x510 data_iobase = 0x511 irq 0 mmio /0002 mmio /0001 [ ... ] With the patch applied everythi

Re: [Qemu-devel] [PATCH] eventfd: making it thread safe

2012-08-06 Thread Paolo Bonzini
Il 07/08/2012 06:02, David Gibson ha scritto: >> Perhaps it's better to do this unconditionally (on the delete path too) >> so that removals are processed without delay and we don't have closed >> fds hanging around in select(). > > Well, I understand that Alexey discussed the patch with Paolo and

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Peter Crosthwaite
>> + >> +extern const VMStateDescription vmstate_fifo8; >> + >> +#define VMSTATE_FIFO8(_field, _state) { \ >> +.name = (stringify(_field)), \ >> +.size = sizeof(Fifo8), \ >> +.vmsd

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Benjamin Herrenschmidt
On Tue, 2012-08-07 at 07:30 +0200, Gerd Hoffmann wrote: > On 08/06/12 23:16, Benjamin Herrenschmidt wrote: > > On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote: > >> There are discussions about re-doing the guest/host interface (command > >> rings etc) now and then, by adding a qxl2 device (o

Re: [Qemu-devel] [PATCH v5 09/15] hw: Added generic FIFO API.

2012-08-06 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:48 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Added a FIFO API that can be used to create and operate byte FIFOs. > > I'm not asking for actual conversions, but it would be nice to see a > list of some devices that could in prin

Re: [Qemu-devel] [PATCH v2] target-arm: Fix typos in comments

2012-08-06 Thread Peter Crosthwaite
On Mon, 2012-08-06 at 17:42 +0100, Peter Maydell wrote: > Fix a variety of typos in comments in target-arm files. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > Changes v1->v2: s/inputs values/input values/ > > target-arm/arm-semi.c|2 +- > target-arm/cpu.h

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Gerd Hoffmann
On 08/06/12 23:16, Benjamin Herrenschmidt wrote: > On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote: >> There are discussions about re-doing the guest/host interface (command >> rings etc) now and then, by adding a qxl2 device (or maybe even extend >> stdvga), dropping a bunch of backward com

Re: [Qemu-devel] [PATCH v5 12/15] petalogix-ml605: added SPI controller with n25q128

2012-08-06 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:50 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Added SPI controller to the reference design, with two n25q128 spi-flashes >> connected. >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> hw/petalogix_ml605_mmu.c | 28

Re: [Qemu-devel] [PATCH v5 03/15] ssi: Implemented CS behaviour

2012-08-06 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:25 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Added default CS behaviour for SSI slaves. SSI devices can set a property >> to enable CS behaviour which will create a GPIO on the device which is the >> CS. Tristating of the bus o

[Qemu-devel] [Bug 1033727] [NEW] USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-08-06 Thread Klaus Hochlehnert
Public bug reported: Hi, I have a "Bus 006 Device 002: ID 0d46:3003 Kobil Systems GmbH mIDentity Light / KAAN SIM III" (kind of smart card) in an USB port whitch I make available to a Windows XP guest. This worked fine with every older qemu-kvm version I've used so far. But since 1.1.0 it does

[Qemu-devel] [PATCH] Update Linux kernel headers

2012-08-06 Thread David Gibson
This patch updates qemu's copy of the Linux kernel headers by running scripts/update-linux-headers.sh against Linus' master branch as at commit 42a579a0f960081cd16fc945036e4780c3ad3202. We need this for the pseries machine in particular to get the definitions of the new KVM_CAP_PPC_ALLOC_HTAB and

[Qemu-devel] [PATCH] ppc: Fix bug in handling of PAPR hypercall exits

2012-08-06 Thread David Gibson
Currently for powerpc, kvm_arch_handle_exit() always returns 1, meaning that its caller - kvm_cpu_exec() - will always exit immediately afterwards to the loop in qemu_kvm_cpu_thread_fn(). There's no need to do this. Once we've handled the hypercall there's no reason we can't go straight around an

Re: [Qemu-devel] [PATCH] eventfd: making it thread safe

2012-08-06 Thread David Gibson
On Mon, Aug 06, 2012 at 05:05:57PM +0300, Avi Kivity wrote: > On 08/01/2012 07:05 AM, David Gibson wrote: > > From: Alexey Kardashevskiy > > > > QEMU uses IO handlers to run select() in the main loop. > > The handlers list is managed by qemu_set_fd_handler() helper > > which works fine when calle

Re: [Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-08-06 Thread Jamie Heilman
Paolo Bonzini wrote: > The patch at http://permalink.gmane.org/gmane.comp.emulators.qemu/162828 > fixes it for ioeventfd=on (the bug is that the ioeventfd is not added to > the select() arguments), but I and Avi disagreed on whether > ioeventfd=off works. :) > > Jamie/Richard/Georg, can you test y

[Qemu-devel] [Qemu-ppc][PATCH v7 3/3] spapr: Add support for -vga option

2012-08-06 Thread Li Zhang
Also instanciate the USB keyboard and mouse when that option is used (you can still use -device to create individual devices without all the defaults) Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Li Zhang --- hw/spapr.c | 31 ++- 1 files changed, 30 inserti

[Qemu-devel] [Qemu-ppc][PATCH v7 2/3] Add one new file vga-pci.h and cleanup on all platforms

2012-08-06 Thread Li Zhang
Functions pci_vga_init() and pci_cirrus_vga_init() are declared in pc.h. That prevents other platforms (e.g. sPAPR) to use them. This patch is to create one new file vga-pci.h and move the declarations to vga-pci.h, so that they can be shared by all platforms. This patch also cleans up on all plat

[Qemu-devel] [Qemu-ppc][PATCH v7 1/3] Add USB option in machine options

2012-08-06 Thread Li Zhang
When -usb option is used, global varible usb_enabled is set. And all the plafrom will create one USB controller according to this variable. In fact, global varibles make code hard to read. So this patch is to remove global variable usb_enabled and add USB option in machine options. All the plaform

[Qemu-devel] [Qemu-ppc][PATCH v7 0/3] Add USB enablement and VGA enablement on sPAPR

2012-08-06 Thread Li Zhang
v1 -> v2: * Convert USB option from char to bool. v2 -> v3: * Remove global USB option * Get USB option with qemu_opt_get_bool(). * Send vga patch for sPAPR which requires USB enabled. v3 -> v4: * Fix some English grammar and coding style faults * Replace usb_on with add_u

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-08-06 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/287 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

[Qemu-devel] [PATCH] slirp: fix build on mingw32

2012-08-06 Thread Anthony Liguori
in_addr_t isn't available on mingw32. Just use an unsigned long instead. I considered typedef'ing in_addr_t on mingw32 but this would potentially be brittle if mingw32 did introduce the type. Cc: Jan Kiszka Signed-off-by: Anthony Liguori --- slirp/main.h |2 +- slirp/slirp.c |2 +- 2

Re: [Qemu-devel] [PATCH v5 05/15] qdev: allow multiple qdev_init_gpio_in() calls

2012-08-06 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:38 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Allow multiple qdev_init_gpio_in() calls for the one device. The first call >> will >> define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be >> handled >> with d

Re: [Qemu-devel] [PATCH v5 04/15] ssi: Added create_slave_no_init()

2012-08-06 Thread Peter Crosthwaite
On Mon, Aug 6, 2012 at 7:29 PM, Peter Maydell wrote: > On 6 August 2012 03:16, Peter A. G. Crosthwaite > wrote: >> Slave creation function that can be used to create an SSI slave without >> qdev_init() being called. This give machine models a change to set >> properties. > > Not convinced about

[Qemu-devel] buildbot failure in qemu on default_mingw32

2012-08-06 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/338 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization

2012-08-06 Thread Phil Staub
On Tue, Jun 12, 2012 at 10:28:14AM -0400, qemu-devel-requ...@nongnu.org wrote: > Date: Tue, 12 Jun 2012 07:14:45 -0700 > From: Richard Henderson > To: "Maciej W. Rozycki" > Cc: qemu-devel@nongnu.org, Aurelien Jarno > Subject: Re: [Qemu-devel] [PATCH] MIPS: Correct FCR0 initialization > Message-I

Re: [Qemu-devel] KVM segfaults with 3.5 while installing ubuntu 12.04

2012-08-06 Thread Stefan Priebe - Profihost AG
can confirm - this fixed it! Am 06.08.2012 14:37, schrieb Avi Kivity: On 08/06/2012 03:12 PM, Avi Kivity wrote: On 08/06/2012 11:46 AM, Stefan Priebe - Profihost AG wrote: But still i got the segfault and core dump - this is my main problem? I mean qemu-kvm master isn't declared as stable. So

[Qemu-devel] [Bug 1033494] [NEW] qemu-system-x86_64 segfaults with kernel 3.5.0

2012-08-06 Thread Stefan Priebe
Public bug reported: qemu-kvm 1.1.1 stable is running fine for me with RHEL 6 2.6.32 based kernel. But with 3.5.0 kernel qemu-system-x86_64 segfaults while i'm trying to install ubuntu 12.04 server reproducable. You find three backtraces here: http://pastebin.com/raw.php?i=xCy2pEcP Stefan ** A

[Qemu-devel] KVM call agenda for Tuesday, August 7

2012-08-06 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-06 Thread Eric Blake
On 08/06/2012 03:54 PM, Eric Blake wrote: > On 08/06/2012 02:44 PM, Kevin Wolf wrote: >> qemu-iotests already filters out image creation options that may be >> present or not in order to get the same output in both cases. However, >> often it only considers the default value of the option. Cover al

Re: [Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-06 Thread Eric Blake
On 08/06/2012 02:44 PM, Kevin Wolf wrote: > qemu-iotests already filters out image creation options that may be > present or not in order to get the same output in both cases. However, > often it only considers the default value of the option. Cover all valid > values instead so that ./check -o nam

[Qemu-devel] [PATCH 01/12] ide scsi: Mess with geometry only for hard disk devices

2012-08-06 Thread Kevin Wolf
From: Markus Armbruster Legacy -drive cyls=... are now ignored completely when the drive doesn't back a hard disk device. Before, they were first checked against a hard disk's limits, then ignored. Signed-off-by: Markus Armbruster Acked-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/ide

[Qemu-devel] [PULL 00/12] Block patches

2012-08-06 Thread Kevin Wolf
The following changes since commit 26b9b5fe17cc1b6be2e8bf8b9d16094f420bb8ad: virtio: fix vhost handling (2012-08-06 14:01:44 -0500) are available in the git repository at: http://repo.or.cz/r/qemu/kevin.git for-anthony Dong Xu Wang (1): qemu-img: use QemuOpts instead of QEMUOptionParam

[Qemu-devel] [PATCH 09/12] qemu-io: add "abort" command to simulate program crash

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi Avoiding data loss and corruption is the top requirement for image file formats. The qemu-io "abort" command makes it possible to simulate program crashes and does not give the image format a chance to cleanly shut down. This command is useful for data integrity test cases

[Qemu-devel] [PATCH 10/12] qemu-iotests: add 039 qcow2 lazy refcounts test

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi This tests establishes the basic post-conditions of the qcow2 lazy refcounts features: 1. If the image was closed normally, it is marked clean. 2. If an allocating write was performed and the image was not closed normally, then it is marked dirty. a. Written

[Qemu-devel] [PATCH 04/12] docs: add dirty bit to qcow2 specification

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi The dirty bit will make it possible to perform lazy refcount updates, where the image file is not kept consistent all the time. Upon opening a dirty image file, it is necessary to perform a consistency check and repair any incorrect refcounts. Therefore the dirty bit must

[Qemu-devel] [PATCH 08/12] qcow2: implement lazy refcounts

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi Lazy refcounts is a performance optimization for qcow2 that postpones refcount metadata updates and instead marks the image dirty. In the case of crash or power failure the image will be left in a dirty state and repaired next time it is opened. Reducing metadata I/O is im

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Benjamin Herrenschmidt
On Mon, 2012-08-06 at 15:20 +0200, Gerd Hoffmann wrote: > There are discussions about re-doing the guest/host interface (command > rings etc) now and then, by adding a qxl2 device (or maybe even extend > stdvga), dropping a bunch of backward compatibility stuff in qxl.c. > > Sending the spice comm

[Qemu-devel] [PATCH 07/12] qemu-iotests: ignore qemu-img create lazy_refcounts output

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi Hide the default lazy_refcounts=off output from qemu-img like we do with other image creation options. This ensures that existing golden outputs continue to pass despite the new option that has been added. Note that this patch applies before the one that actually introduce

[Qemu-devel] [PATCH 06/12] docs: add lazy refcounts bit to qcow2 specification

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi The lazy refcounts bit indicates that this image can take advantage of the dirty bit and that refcount updates can be postponed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- docs/specs/qcow2.txt |7 ++- 1 files changed, 6 insertions(+), 1 deletion

[Qemu-devel] [PATCH 03/12] qemu-iotests: add qed.py image manipulation utility

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi The qed.py utility can inspect and manipulate QED image files. It can be used for testing to see the state of image metadata and also to inject corruptions into the image file. It also has a scrubbing feature to copy just the metadata out of an image file, allowing users t

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-06 Thread Benjamin Herrenschmidt
On Mon, 2012-08-06 at 16:02 +0200, Gerd Hoffmann wrote: > > A vbe rom isn't a big deal. You probably want support the 0x01CE and > 0x01CF ports (on x86) so the vgabios running in real mode can easily > reach the bochs interface registers without a protected mode round > trip > for mmio access. >

[Qemu-devel] [PATCH 02/12] qapi: generalize documentation of streaming commands

2012-08-06 Thread Kevin Wolf
From: Paolo Bonzini Talk about background operations in general, rather than specifically about streaming. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hmp-commands.hx |2 +- qapi-schema.json | 17 - 2 files changed, 9 insertions(+), 10 deletions(-) diff

Re: [Qemu-devel] vga-pci and MMIO BAR

2012-08-06 Thread Benjamin Herrenschmidt
On Mon, 2012-08-06 at 14:03 +0200, Gerd Hoffmann wrote: > Hacked up something like that a while back (patch attached). Doesn't > use DRM though, just plain old fbdev. Maybe you can reuse some bits > nevertheless. > > /me wonders what the advantage of using drm is for non-3D hardware? Thanks. Ye

[Qemu-devel] [PATCH 05/12] qcow2: introduce dirty bit

2012-08-06 Thread Kevin Wolf
From: Stefan Hajnoczi This patch adds an incompatible feature bit to mark images that have not been closed cleanly. When a dirty image file is opened a consistency check and repair is performed. Update qemu-iotests 031 and 036 since the extension header size changes when we add feature bit tabl

[Qemu-devel] [PATCH 12/12] qemu-img: use QemuOpts instead of QEMUOptionParameter in resize function

2012-08-06 Thread Kevin Wolf
From: Dong Xu Wang Signed-off-by: Dong Xu Wang Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- qemu-img.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index b866f80..94a31ad 100644 --- a/qemu-img.c +++

[Qemu-devel] [PATCH 11/12] qemu-iotests: Be more flexible with image creation options

2012-08-06 Thread Kevin Wolf
qemu-iotests already filters out image creation options that may be present or not in order to get the same output in both cases. However, often it only considers the default value of the option. Cover all valid values instead so that ./check -o name=value can be used successfull for all of them.

Re: [Qemu-devel] [PATCH 15/34] net: inet_connect(), inet_connect_opts(): return -errno

2012-08-06 Thread Luiz Capitulino
On Mon, 6 Aug 2012 02:52:24 -0400 (EDT) Amos Kong wrote: > > > - Original Message - > > [cc: Juan & Amos] > > > > Luiz Capitulino writes: > > > > > On Wed, 1 Aug 2012 22:02:35 -0300 > > > Luiz Capitulino wrote: > > > > > >> Next commit wants to use this. > > >> > > >> Signed-off-b

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Anthony Liguori
Paolo Bonzini writes: > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net > because it always registers the virtio_pci_host_notifier_read() handler > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. > The result is both QEMU and vhost_net.ko polling on the

[Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats

2012-08-06 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- qapi-schema.json |4 ++-- qmp-commands.hx |6 ++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 8cc40e2..3238403 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -260,7 +260,7 @@ # #

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Orit Wasserman
On 08/06/2012 07:14 PM, Eric Blake wrote: > On 08/06/2012 10:04 AM, Orit Wasserman wrote: >> On 08/06/2012 05:26 PM, Eric Blake wrote: >>> On 08/05/2012 03:13 AM, Orit Wasserman wrote: The management can enable/disable a capability for the next migration by using migrate-set-apabili

[Qemu-devel] [PATCH 06/12] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-08-06 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia Signed-off-by: Pe

[Qemu-devel] [PATCH 03/12] Add XBZRLE documentation

2012-08-06 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 128 +++ 1 files changed, 128 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..cc3a26a ---

[Qemu-devel] [PATCH 02/12] Add migrate-set-capabilities

2012-08-06 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate-set-capabilities QMP command. The user can use migrate_set_capability HMP command. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- hmp-commands.hx | 14 ++ hmp.c| 3

[Qemu-devel] [PATCH 05/12] Add uleb encoding/decoding functions

2012-08-06 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index b0bdd4b..700f943 100644 --- a/cutils.c +++

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Orit Wasserman
On 08/06/2012 07:39 PM, Eric Blake wrote: > On 08/06/2012 10:28 AM, Orit Wasserman wrote: > >>> That is, BOTH commands end up iterating over a list of caps, and output >>> identical information in the case where caps exist of 'name: state' for >>> each capability. >>> > >> The information is diff

[Qemu-devel] [PATCH 04/12] Add cache handling functions

2012-08-06 Thread Orit Wasserman
Add MRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + cutils.c |9 ++ include/qemu/page_cache.h |

[Qemu-devel] [PATCH 05/12] Add uleb encoding/decoding functions

2012-08-06 Thread Orit Wasserman
Implement Unsigned Little Endian Base 128. Signed-off-by: Orit Wasserman --- cutils.c | 33 + qemu-common.h |8 2 files changed, 41 insertions(+), 0 deletions(-) diff --git a/cutils.c b/cutils.c index b0bdd4b..700f943 100644 --- a/cutils.c +++

[Qemu-devel] [PATCH 09/12] Add migration accounting for normal and duplicate pages

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 38 ++ hmp.c|6 ++ migration.c |6 ++ migration.h

[Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info migrate_cache_size' HMP command to query cache value. Signed-

[Qemu-devel] [PATCH 11/12] Add XBZRLE statistics

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 28 hmp.c| 13 + migration.c | 17 + migrati

[Qemu-devel] [PATCH 02/12] Add migrate-set-capabilities

2012-08-06 Thread Orit Wasserman
The management can enable/disable a capability for the next migration by using migrate-set-capabilities QMP command. The user can use migrate_set_capability HMP command. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- hmp-commands.hx | 14 ++ hmp.c| 3

[Qemu-devel] [PATCH 03/12] Add XBZRLE documentation

2012-08-06 Thread Orit Wasserman
Signed-off-by: Orit Wasserman --- docs/xbzrle.txt | 128 +++ 1 files changed, 128 insertions(+), 0 deletions(-) create mode 100644 docs/xbzrle.txt diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt new file mode 100644 index 000..cc3a26a ---

Re: [Qemu-devel] [PATCH 00/12] Migration next v12

2012-08-06 Thread Eric Blake
On 08/06/2012 12:42 PM, Orit Wasserman wrote: > Changes from v11: > Fix example for query-migrate-cache-size commands > Move patch 10 (Change total_time to total-time) to patch 9 and fix > comment. > > patches are based on git://repo.or.cz/qemu/quintela.git Migration-next-v5 > branch > > Please

[Qemu-devel] [PATCH 01/12] Add migration capabilities

2012-08-06 Thread Orit Wasserman
The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use 'info migrate_capabilities' HMP command. Currently only XBZRLE capability is available. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- hmp-commands.hx |

[Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Orit Wasserman
Change XBZRLE cache size in bytes (the size should be a power of 2, it will be rounded down to the nearest power of 2). If XBZRLE cache size is too small there will be many cache miss. New query-migrate-cache-size QMP command and 'info migrate_cache_size' HMP command to query cache value. Signed-

[Qemu-devel] [PATCH 07/12] Add XBZRLE to ram_save_block and ram_save_live

2012-08-06 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed, then send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-

[Qemu-devel] [PATCH 12/12] Restart optimization on stage3 update version

2012-08-06 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5f864a6..5181953 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

[Qemu-devel] [PATCH 07/12] Add XBZRLE to ram_save_block and ram_save_live

2012-08-06 Thread Orit Wasserman
In the outgoing migration check to see if the page is cached and changed, then send compressed page by using save_xbrle_page function. In the incoming migration check to see if RAM_SAVE_FLAG_XBZRLE is set and decompress the page (by using load_xbrle function). Signed-off-by: Benoit Hudzia Signed-

[Qemu-devel] [PATCH 10/12] Add migration accounting for normal and duplicate pages

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 38 ++ hmp.c|6 ++ migration.c |6 ++ migration.h

[Qemu-devel] [PATCH 09/12] Change total_time to total-time in MigrationStats

2012-08-06 Thread Orit Wasserman
migration total_time was introduced in commit d5f8a5701d3690b5ec0c34b6a5c0b5a24d274540 for QEMU 1.2 Signed-off-by: Orit Wasserman --- qapi-schema.json |4 ++-- qmp-commands.hx |9 +++-- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.jso

[Qemu-devel] [PATCH 06/12] Add xbzrle_encode_buffer and xbzrle_decode_buffer functions

2012-08-06 Thread Orit Wasserman
For performance we are encoding long word at a time. For nzrun we use long-word-at-a-time NULL-detection tricks from strcmp(): using ((lword - 0x0101010101010101) & (~lword) & 0x8080808080808080) test to find out if any byte in the long word is zero. Signed-off-by: Benoit Hudzia Signed-off-by: Pe

[Qemu-devel] [PATCH 01/12] Add migration capabilities

2012-08-06 Thread Orit Wasserman
The management can query the current migration capabilities using query-migrate-capabilities QMP command. The user can use 'info migrate_capabilities' HMP command. Currently only XBZRLE capability is available. Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- hmp-commands.hx |

[Qemu-devel] [PATCH 00/12] Migration next v12

2012-08-06 Thread Orit Wasserman
Changes from v11: Fix example for query-migrate-cache-size commands Move patch 10 (Change total_time to total-time) to patch 9 and fix comment. Changes from v10: remove query-migrate-supported-capabilities commands. Update documentation. Replace total_time with total-time fix other comments by Eri

[Qemu-devel] [PATCH 04/12] Add cache handling functions

2012-08-06 Thread Orit Wasserman
Add MRU page cache mechanism. The page are accessed by their address. Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman --- Makefile.objs |1 + cutils.c |9 ++ include/qemu/page_cache.h |

[Qemu-devel] [PATCH 11/12] Add XBZRLE statistics

2012-08-06 Thread Orit Wasserman
Signed-off-by: Benoit Hudzia Signed-off-by: Petter Svard Signed-off-by: Aidan Shribman Signed-off-by: Orit Wasserman Signed-off-by: Juan Quintela --- arch_init.c | 28 hmp.c| 13 + migration.c | 17 + migrati

[Qemu-devel] [PATCH 00/12] Migration next v11

2012-08-06 Thread Orit Wasserman
Changes from v10: remove query-migrate-supported-capabilities commands. Update documentation. Replace total_time with total-time fix other comments by Eric Changes from v9: rename query-migrtion-supported-capabilities to query-migrate-supported-capabilities rename 'info migration_supported_capabi

[Qemu-devel] [PATCH 12/12] Restart optimization on stage3 update version

2012-08-06 Thread Orit Wasserman
From: Juan Quintela Signed-off-by: Juan Quintela --- arch_init.c | 24 +++- 1 files changed, 15 insertions(+), 9 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5f864a6..5181953 100644 --- a/arch_init.c +++ b/arch_init.c @@ -273,14 +273,16 @@ static void save_bl

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Eric Blake
On 08/06/2012 10:28 AM, Orit Wasserman wrote: >> That is, BOTH commands end up iterating over a list of caps, and output >> identical information in the case where caps exist of 'name: state' for >> each capability. >> > The information is different: > the first: > MigrationCapabilityStatusList *

Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Orit Wasserman
On 08/06/2012 09:13 PM, Eric Blake wrote: > On 08/06/2012 11:51 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2, it will >> be >> rounded down to the nearest power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> New q

Re: [Qemu-devel] [PATCH 10/12] Change total_time to total-time in MigrationStats

2012-08-06 Thread Eric Blake
On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman Sparse on the commit message. You need to document why the change is safe (namely, call out which commit introduced 'total_time' in the first place, and the fact that the commit is not part of 1.1, so we are fixing an

Re: [Qemu-devel] [PATCH 08/12] Add migrate_set_cache_size command

2012-08-06 Thread Eric Blake
On 08/06/2012 11:51 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > New query-migrate-cache-size QMP command and 'info migrat

[Qemu-devel] [PATCH] kvm-all.c: Move init of irqchip_inject_ioctl out of kvm_irqchip_create()

2012-08-06 Thread Peter Maydell
Move the init of the irqchip_inject_ioctl field of KVMState out of kvm_irqchip_create() and into kvm_init(), so that kvm_set_irq() can be used even when no irqchip is created (for architectures that support async interrupt notification even without an in kernel irqchip). Signed-off-by: Peter Mayde

[Qemu-devel] [PATCH v2] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
Fix a variety of typos in comments in target-arm files. Signed-off-by: Peter Maydell --- Changes v1->v2: s/inputs values/input values/ target-arm/arm-semi.c|2 +- target-arm/cpu.h |2 +- target-arm/helper.c |6 +++--- target-arm/neon_helper.c | 26 +---

Re: [Qemu-devel] [PATCH] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
On 6 August 2012 17:33, Peter Maydell wrote: > Fix a variety of typos in comments in target-arm files. > -/* Handling addition overflow with 64 bits inputs values is more > - * tricky than with 32 bits values. */ > +/* Handling addition overflow with 64 bit inputs values is more > + * tricky tha

[Qemu-devel] [PATCH] target-arm: Fix typos in comments

2012-08-06 Thread Peter Maydell
Fix a variety of typos in comments in target-arm files. Signed-off-by: Peter Maydell --- Includes all the ones I spotted but not the 'middel' fix which Peter C has already submitted a patch for, so the two patches shouldn't conflict. target-arm/arm-semi.c|2 +- target-arm/cpu.h

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Eric Blake
On 08/06/2012 10:04 AM, Orit Wasserman wrote: > On 08/06/2012 05:26 PM, Eric Blake wrote: >> On 08/05/2012 03:13 AM, Orit Wasserman wrote: >>> The management can enable/disable a capability for the next migration by >>> using >>> migrate-set-apabilities QMP command. >> >> s/set-apabilities/set-cap

Re: [Qemu-devel] [PATCH 02/11] Add migrate-set-capabilities and query-migrate-capabilities

2012-08-06 Thread Orit Wasserman
On 08/06/2012 05:26 PM, Eric Blake wrote: > On 08/05/2012 03:13 AM, Orit Wasserman wrote: >> The management can enable/disable a capability for the next migration by >> using >> migrate-set-apabilities QMP command. > > s/set-apabilities/set-capabilities/ > >> The management can query the current

Re: [Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Alex Williamson
On Mon, 2012-08-06 at 15:40 +, Bhushan Bharat-R65777 wrote: > Hi Avi/All, > > I am facing issue to boot KVM guest on x86 (I used to work on PowerPC > platform and do not have enough knowledge of x86). I am working on making > VFIO working on PowerPC Booke, So I have cloned Alex Williamsons g

Re: [Qemu-devel] [PATCH 10/11] Add XBZRLE statistics

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > arch_init.c | 28 > hmp.c| 13 +++

Re: [Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Avi Kivity
On 08/06/2012 06:40 PM, Bhushan Bharat-R65777 wrote: > Hi Avi/All, > > I am facing issue to boot KVM guest on x86 (I used to work on PowerPC > platform and do not have enough knowledge of x86). I am working on making > VFIO working on PowerPC Booke, So I have cloned Alex Williamsons git > repos

Re: [Qemu-devel] [PATCH 09/11] Add migration accounting for normal and duplicate pages

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by: Orit Wasserman > Signed-off-by: Juan Quintela > --- > +++ b/qapi-schema.json > @@ -264,11 +264,18 @@ > #migration has ended, it

Re: [Qemu-devel] [PATCH 08/11] Add migrate_set_cache_size command

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2, it will be > rounded down to the nearest power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > New query-migrate-cache-size QMP command and 'info migrat

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-06 Thread Stefan Hajnoczi
On Mon, Aug 6, 2012 at 3:56 PM, Paolo Bonzini wrote: > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net > because it always registers the virtio_pci_host_notifier_read() handler > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. > The result is both QEMU an

Re: [Qemu-devel] [PATCH 03/11] Add XBZRLE documentation

2012-08-06 Thread Eric Blake
On 08/05/2012 03:13 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 136 > +++ > 1 files changed, 136 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > diff --git a/docs/xbzrle.txt b/d

[Qemu-devel] Running KVM guest on X86

2012-08-06 Thread Bhushan Bharat-R65777
Hi Avi/All, I am facing issue to boot KVM guest on x86 (I used to work on PowerPC platform and do not have enough knowledge of x86). I am working on making VFIO working on PowerPC Booke, So I have cloned Alex Williamsons git repository, compiled kernel for x86 on fedora with virtualization conf

Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry

2012-08-06 Thread Corey Minyard
On 08/02/2012 04:05 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/02/2012 01:32 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 09:40 PM, Anthony Liguori wrote: Corey Minyard writes: On 08/01/2012 08:15 PM, Kevin O'Connor wrote: Well, I should also probably add

  1   2   >