[Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..d69d5be 100644 --- a/hw/pl190.c +++ b/hw/pl190.c @@ -133,7 +133,7 @@ static uint64_t pl190_read(void *opaque, target_phys_addr_t offset,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/7] ppc: Make kvm_arch_put_registers() put *all* the registers

2012-08-18 Thread David Gibson
On Fri, Aug 17, 2012 at 03:58:08PM +0200, Alexander Graf wrote: > On 08/15/2012 06:33 AM, David Gibson wrote: > >At least when invoked with high enough 'level' arguments, > >kvm_arch_put_registers() is supposed to copy essentially all the cpu state > >as encoded in qemu's internal structures into t

Re: [Qemu-devel] [PATCH 1/3] usb: Halt ep queue en cancel pending packets on a packet error

2012-08-18 Thread Hans de Goede
Hi, On 08/17/2012 07:03 PM, Andreas Färber wrote: Not being too familiar with the USB code I wonder if $subject was supposed to say "and cancel"? Yes, "en" is Dutch for and, no idea what I was thinking, sorry about that :) Regards, Hans

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Peter Maydell
On 18 August 2012 03:55, Brendan Fennell wrote: > Signed-off-by: Brendan Fennell > --- > hw/pl190.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/pl190.c b/hw/pl190.c > index cb50afb..d69d5be 100644 > --- a/hw/pl190.c > +++ b/hw/pl190.c > @@ -133,7 +133,7 @@ s

Re: [Qemu-devel] qemu for android arm

2012-08-18 Thread Peter Maydell
On 18 August 2012 06:35, Xin Tong wrote: > Does QEMU have all the supports to boot android on arm ? You mean Android as a guest? The first question you should be asking is "android on ARM on what hardware?". If you can find an Android build for one of the machines QEMU supports (vexpress-a9 is pr

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 03:55, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/pl190.c b/hw/pl190.c index cb50afb..d69d5be 100644 --- a/hw/pl190.c +++ b/hw/

[Qemu-devel] [PATCH 1/8] buffered_file: g_realloc() can't fail

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- buffered_file.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index f170aa0..4148abb 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -50,20 +50,12 @@ static void buffered_append(QEMUFileBuffer

[Qemu-devel] [PATCH 2/8] fix migration sync

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- arch_init.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch_init.c b/arch_init.c index 9b46bfc..0a9ca85 100644 --- a/arch_init.c +++ b/arch_init.c @@ -488,6 +488,7 @@ static int ram_save_setup(QEMUFile *f, void *opaque) ram_addr_t addr; RAMBlock

[Qemu-devel] [PATCH v2 0/8] Migration stats

2012-08-18 Thread Juan Quintela
Hi v2: - rebase on top of master - apply all review comments for Eric & Luiz (1st time writting Eric correctly) - dropped dirty_pages_rate: requires migration bitmap changes - add examples were missing - get feedback from several people that they were useful - Intregrated migration bitmap sync, ot

[Qemu-devel] [PATCH 4/8] migration: store end_time in a local variable

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 8e4c508..159728d 100644 --- a/migration.c +++ b/migration.c @@ -326,6 +326,7 @@ static void migrate_fd_put_ready(void *opaque) migrate_fd_er

[Qemu-devel] [PATCH 5/8] migration: print total downtime for final phase of migration

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hmp.c| 4 migration.c | 6 +- migration.h | 1 + qapi-schema.json | 7 ++- qmp-commands.hx | 3 +++ 5 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hmp.c b/hmp.c index 81c8acb..8f24d9d 100644 --- a/hmp.c +++ b/hm

[Qemu-devel] [PATCH 8/8] migration: print expected downtime in info migrate

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- arch_init.c | 2 ++ hmp.c| 4 migration.c | 2 ++ migration.h | 1 + qapi-schema.json | 5 + qmp-commands.hx | 6 ++ 6 files changed, 20 insertions(+) diff --git a/arch_init.c b/arch_init.c index 7eb6e86..3ddfff9 100644 --

[Qemu-devel] [PATCH 3/8] migration: move total_time from ram stats to migration info

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hmp.c| 4 ++-- migration.c | 6 +++--- qapi-schema.json | 14 +++--- qmp-commands.hx | 6 +++--- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/hmp.c b/hmp.c index a9d5675..81c8acb 100644 --- a/hmp.c +++ b/hmp.c @@ -1

[Qemu-devel] [PATCH 7/8] migration: export migrate_get_current()

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration.c | 2 +- migration.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 49cd336..186bcf2 100644 --- a/migration.c +++ b/migration.c @@ -53,7 +53,7 @@ static NotifierList migration_state_notifiers = m

[Qemu-devel] [PATCH 6/8] migration: rename expected_time to expected_downtime

2012-08-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- arch_init.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index 0a9ca85..7eb6e86 100644 --- a/arch_init.c +++ b/arch_init.c @@ -538,7 +538,7 @@ static int ram_save_iterate(QEMUFile *f, void *opaque)

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Peter Maydell
On 18 August 2012 11:41, Brendan Fennell wrote: > > > On Sat, 18 Aug 2012, Peter Maydell wrote: > >> On 18 August 2012 03:55, Brendan Fennell wrote: >>> >>> Signed-off-by: Brendan Fennell >>> --- >>> hw/pl190.c |2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a

[Qemu-devel] For 1.2: Re: [PATCH 3/8] migration: move total_time from ram stats to migration info

2012-08-18 Thread Eric Blake
On 08/18/2012 05:17 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hmp.c| 4 ++-- > migration.c | 6 +++--- > qapi-schema.json | 14 +++--- > qmp-commands.hx | 6 +++--- > 4 files changed, 15 insertions(+), 15 deletions(-) > > +++ b/qapi-schema.json

Re: [Qemu-devel] [PATCH 5/8] migration: print total downtime for final phase of migration

2012-08-18 Thread Eric Blake
On 08/18/2012 05:17 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > hmp.c| 4 > migration.c | 6 +- > migration.h | 1 + > qapi-schema.json | 7 ++- > qmp-commands.hx | 3 +++ > 5 files changed, 19 insertions(+), 2 deletions(-) > +++ b/qmp-comm

Re: [Qemu-devel] [PATCH 8/8] migration: print expected downtime in info migrate

2012-08-18 Thread Eric Blake
On 08/18/2012 05:17 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > arch_init.c | 2 ++ > hmp.c| 4 > migration.c | 2 ++ > migration.h | 1 + > qapi-schema.json | 5 + > qmp-commands.hx | 6 ++ > 6 files changed, 20 insertions(+) > > +++

Re: [Qemu-devel] [PATCH 16/20] qidl: Add documentation

2012-08-18 Thread Blue Swirl
On Tue, Aug 14, 2012 at 10:20 PM, Peter Maydell wrote: > On 14 August 2012 23:15, Michael Roth wrote: >> On Tue, Aug 14, 2012 at 08:41:56PM +0100, Peter Maydell wrote: >>> On 14 August 2012 17:27, Michael Roth wrote: >>> > +In our *SerialDevice* example, the *CharDriverState* pointer reflects >

Re: [Qemu-devel] [PATCH] linux-user: fix emulation of getdents

2012-08-18 Thread Blue Swirl
On Thu, Aug 16, 2012 at 9:20 PM, Dmitry V. Levin wrote: > In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last > byte of the target dirent structure (aka d_type byte) was never copied > from the native dirent structure, thus breaking everything that relies > on valid d_type value,

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 2:36 AM, Ronnie Sahlberg wrote: > There is no bdrv_* API for the commands for burning a blank MMC disk > so when iSCSI LUNs are specified and the LUN is a MMC device with > 0 available blocks. This is a blank disk so force scsi generic. > > This allows the guest to talk dir

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > Revision bumped to 4 for new IO support, enabled for spice-server >= > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > 0.12.0. > > On migration reissue spice_qxl_monitors_config_async. > > RHBZ: 770842 > > Signed-off-by:

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-18 Thread Richard Davies
Hi Robert, Robert Vineyard wrote: > Not sure if you've tried this, but I noticed massive performance > gains (easily booting 2-3 times as fast) by converting from RAW disk > images to direct-mapped raw partitions and making sure that IOMMU > support was enabled in the BIOS and in the kernel at boo

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Alon Levy
On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: > On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > > Revision bumped to 4 for new IO support, enabled for spice-server >= > > 0.11.1. New io enabled iff spice-server >= 0.11.1 && spice-protocol >= > > 0.12.0. > > > > On migration reiss

Re: [Qemu-devel] Qemu phone modem emulation

2012-08-18 Thread Blue Swirl
On Fri, Aug 17, 2012 at 7:26 PM, Eric Koldeweij wrote: > Hello all, > > I am currently working on a serial telephone modem emulation implementation > for Qemu. My question is if it would be a good idea to offer it for > inclusion in the qemu main trunk when it's ready. These are the requirements >

Re: [Qemu-devel] Hard freeze for 1.2 today

2012-08-18 Thread Paolo Bonzini
Il 15/08/2012 16:36, Eric Blake ha scritto: >> > If there are existing patches and/or pull requests on the mailing list >> > that you think should be in 1.2, please respond to the email with a >> > pointer to the mail. > Paolo - where do we stand on drive-mirror and friends? > https://lists.gnu.org

Re: [Qemu-devel] [PATCH 2/2] 9p-synth: use mutex on read-side

2012-08-18 Thread Paolo Bonzini
Il 13/08/2012 21:13, Harsh Bora ha scritto: >> > > Hi Paolo, > > The rcu_read_[un]lock() macros were added as no-ops (based on your > inputs on #qemu) to replace reader-writer locks with RCU based locking > as suggested while proposing QemuRWLock API for RW locks (See > http://lists.gnu.org/archi

Re: [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition

2012-08-18 Thread Paolo Bonzini
Il 14/08/2012 22:20, Nicholas A. Bellinger ha scritto: >>> > > Since virtio_scsi currently assumes a single vqs for data, this patch >>> > > simply changes ->cmd_vqs[1] to handle the single VirtQueue. Wrong, multiqueue works just fine. :) It's just the kernel driver that doesn't support it yet.

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-18 Thread Paolo Bonzini
Il 12/08/2012 12:08, Michael Tokarev ha scritto: >> > Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net >> > because it always registers the virtio_pci_host_notifier_read() handler >> > function on the ioeventfd, even when vhost_net.ko is using the ioeventfd. >> > The result is both

Re: [Qemu-devel] [PATCH] virtio: fix vhost handling

2012-08-18 Thread Michael Tokarev
On 18.08.2012 22:56, Paolo Bonzini wrote: > Il 12/08/2012 12:08, Michael Tokarev ha scritto: Commit b1f416aa8d870fab71030abc9401cfc77b948e8e breaks vhost_net because it always registers the virtio_pci_host_notifier_read() handler function on the ioeventfd, even when vhost_net.ko is u

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Blue Swirl
On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote: > On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: >> > Revision bumped to 4 for new IO support, enabled for spice-server >= >> > 0.11.1. New io enabled iff spice-server >= 0.11.1 &&

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-18 Thread Paolo Bonzini
Il 15/08/2012 14:38, Stefan Hajnoczi ha scritto: > The new live block copy approach is different and that's why classic > block migration is only deprecated but not dropped: > > Live block copy doesn't transfer data in-band during live migration. > Instead it currently requires storage access from

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Michael S. Tsirkin
On Tue, Aug 14, 2012 at 02:12:29PM -0700, Nicholas A. Bellinger wrote: > On Mon, 2012-08-13 at 11:59 +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > From: Stefan Hajnoczi > > > > > > This patch adds a new type of host device that d

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-18 Thread Paolo Bonzini
Il 14/08/2012 16:42, Stefan Hajnoczi ha scritto: >> > >> > +if (blk && !suppress_deprecation_message) { >> > +qerror_report(ERROR_CLASS_GENERIC_ERROR, > qerror_report_once() would be nice :). > >> > + "Block migration is deprecated. " >> > +

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Michael S. Tsirkin
On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: > On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > From: Stefan Hajnoczi > > > > > > This patch adds a new type of host device that d

Re: [Qemu-devel] [PATCH 08/10] iscsi: Fix NULL dereferences / races between task completion and abort

2012-08-18 Thread Paolo Bonzini
Il 15/08/2012 15:56, Kevin Wolf ha scritto: > @@ -76,6 +76,10 @@ static void > iscsi_abort_task_cb(struct iscsi_context *iscsi, int status, void > *command_data, > void *private_data) > { > +IscsiAIOCB *acb = (IscsiAIOCB *)private_data; > + > +scsi_free_scsi_task(acb

Re: [Qemu-devel] [PATCH] pl190: fix read of VECTADDR

2012-08-18 Thread Brendan Fennell
On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 11:41, Brendan Fennell wrote: On Sat, 18 Aug 2012, Peter Maydell wrote: On 18 August 2012 03:55, Brendan Fennell wrote: Signed-off-by: Brendan Fennell --- hw/pl190.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(

Re: [Qemu-devel] [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Michael S. Tsirkin
Hi Nicholas, I just noticed this problem in the interface: +#include + +/* + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. + * + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge candidate + + *RFC-v2 vhost-scsi userspace. Add GET_ABI_VERSION ioctl usa

Re: [Qemu-devel] [PATCH v2 0/2] two little build fixes

2012-08-18 Thread Blue Swirl
On Mon, Aug 13, 2012 at 11:05 AM, Gerd Hoffmann wrote: > Hi, > > Patch #1 uses g_strdup_printf now, #2 is unchanged. Thanks, applied both. > > cheers, > Gerd > > Gerd Hoffmann (2): > Avoid asprintf() which is not available on mingw > scsi: fix warning > > hw/msix.c |8 ++-- >

Re: [Qemu-devel] [PATCH v3 0/2] Fix two bugs related to ram_size

2012-08-18 Thread Blue Swirl
On Wed, Aug 15, 2012 at 11:12 AM, Markus Armbruster wrote: > There are more, but let's start with these two. Thanks, applied both. > > v1 -> v3: > * Use QEMU_ALIGN_UP (Avi) > * Cover size overflow > * Coding style (Blue) > > Markus Armbruster (2): > vl: Round argument of -m up to multiple of 8

[Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-18 Thread Blue Swirl
Some variables are only used on !win32, declare them only when used. This avoids a warning in mingw32 build: CCi386-softmmu/monitor.o /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': /src/qemu/monitor.c:2575: warning: unused variable 'mon_fd_flags' /src/qemu/monitor.c:2574: warning:

Re: [Qemu-devel] [PATCH] monitor: avoid declaring unused variables

2012-08-18 Thread Stefan Weil
Am 18.08.2012 22:14, schrieb Blue Swirl: Some variables are only used on !win32, declare them only when used. This avoids a warning in mingw32 build: CCi386-softmmu/monitor.o /src/qemu/monitor.c: In function 'monitor_fdset_get_fd': /src/qemu/monitor.c:2575: warning: unused variable 'mon_f

Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-18 Thread Stefan Weil
Am 17.08.2012 17:02, schrieb Luiz Capitulino: On Fri, 17 Aug 2012 16:41:34 +0200 Markus Armbruster wrote: Luiz Capitulino writes: On Fri, 17 Aug 2012 16:10:12 +0200 Markus Armbruster wrote: Stefan Weil writes: ccc-analyzer reports these warnings: monitor.c:3532:21: warning: Division

[Qemu-devel] [PATCH] qapi: Fix memory leak

2012-08-18 Thread Stefan Weil
valgrind report: ==24534== 232 bytes in 2 blocks are definitely lost in loss record 1,245 of 1,601 ==24534==at 0x4824F20: malloc (vg_replace_malloc.c:236) ==24534==by 0x293C88: malloc_and_trace (vl.c:2281) ==24534==by 0x489AD99: ??? (in /lib/libglib-2.0.so.0.2400.1) ==24534==by 0x

Re: [Qemu-devel] [PATCH] qapi: Fix memory leak

2012-08-18 Thread Stefan Weil
Am 18.08.2012 22:51, schrieb Stefan Weil: valgrind report: ==24534== 232 bytes in 2 blocks are definitely lost in loss record 1,245 of 1,601 ==24534==at 0x4824F20: malloc (vg_replace_malloc.c:236) ==24534==by 0x293C88: malloc_and_trace (vl.c:2281) ==24534==by 0x489AD99: ??? (in /lib

Re: [Qemu-devel] [PATCH] qapi: Fix memory leak

2012-08-18 Thread Michael Tokarev
On 19.08.2012 00:51, Stefan Weil wrote: > +++ b/qapi/opts-visitor.c > @@ -416,7 +416,7 @@ opts_visitor_cleanup(OptsVisitor *ov) > g_hash_table_destroy(ov->unprocessed_opts); > } > g_free(ov->fake_id_opt); > -memset(ov, '\0', sizeof *ov); > +g_free(ov); Shouldn't the fu

[Qemu-devel] Compilation Error with gcc 4.6

2012-08-18 Thread MJ embd
Hi All, I am trying to compile qemu for arm top of tree on ubuntu 12.04 and am getting the following errors. Can anyone help ... CCjson-streamer.o CCjson-parser.o CCqerror.o CCerror.o CCqemu-error.o LINK qemu-ga /usr/lib/gcc/arm-linux-gnueabi/4.6/../../../../arm-linu

[Qemu-devel] qemu compilation fails on ubuntu 12.04

2012-08-18 Thread MJ embd
Hi All, I am trying to compile qemu for arm top of tree on ubuntu 12.04 and am getting the following errors. Can anyone help ... CCjson-streamer.o CCjson-parser.o CCqerror.o CCerror.o CCqemu-error.o LINK qemu-ga /usr/lib/gcc/arm-linux-gnueabi/4.6/../../../../arm-linu

Re: [Qemu-devel] [RFC-v2 6/6] virtio-scsi: Fix incorrect VirtIOSCSI->cmd_vqs[0] definition

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 20:52 +0200, Paolo Bonzini wrote: > Il 14/08/2012 22:20, Nicholas A. Bellinger ha scritto: > >>> > > Since virtio_scsi currently assumes a single vqs for data, this patch > >>> > > simply changes ->cmd_vqs[1] to handle the single VirtQueue. > > Wrong, multiqueue works just fi

[Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-18 Thread Paolo Bonzini
Hi Stefan, this is my version of your patch. I think the flow of the code is a bit simpler (or at least matches other implementations of cancellation). Can you test it on your test case? Thanks! Paolo Paolo Bonzini (3): iscsi: move iscsi_schedule_bh and iscsi_readv_writev_bh_cb iscsi: simp

[Qemu-devel] [PATCH 1/3] iscsi: move iscsi_schedule_bh and iscsi_readv_writev_bh_cb

2012-08-18 Thread Paolo Bonzini
Put these functions at the beginning, to avoid forward references in the next patches. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 56 1 file modificato, 28 inserzioni(+), 28 rimozioni(-) diff --git a/block/iscsi.c b/block/iscsi.c in

[Qemu-devel] [PATCH 2/3] iscsi: simplify iscsi_schedule_bh

2012-08-18 Thread Paolo Bonzini
It is always used with the same callback, remove the argument. And its return value is never used, assume allocation succeeds. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 24 +--- 1 file modificato, 9 inserzioni(+), 15 rimozioni(-) diff --git a/block/iscsi.c b/block/is

[Qemu-devel] [PATCH 3/3] iscsi: fix races between task completion and abort

2012-08-18 Thread Paolo Bonzini
This patch fixes two main issues with block/iscsi.c: 1) iscsi_task_mgmt_abort_task_async calls iscsi_scsi_task_cancel which was also directly called in iscsi_aio_cancel 2) a race between task completion and task abortion could happen cause the scsi_free_scsi_task were done before iscsi_schedule_b

[Qemu-devel] [PATCH v2] linux-user: fix emulation of getdents

2012-08-18 Thread Dmitry V. Levin
In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last byte of the target dirent structure (aka d_type byte) was never copied from the host dirent structure, thus breaking everything that relies on valid d_type value, e.g. glob(3). Signed-off-by: Dmitry V. Levin --- linux-user/sysc

Re: [Qemu-devel] [PATCH 1/2] ISCSI: Set number of blocks to 0 for blank CDROM devices

2012-08-18 Thread Paolo Bonzini
Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: > The number of blocks of the device is used to compute the device size > in bdrv_getlength()/iscsi_getlength(). > For MMC devices, the ReturnedLogicalBlockAddress in the READCAPACITY10 > has a special meaning when it is 0. > In this case it does not

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Paolo Bonzini
Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: > There is no bdrv_* API for the commands for burning a blank MMC disk > so when iSCSI LUNs are specified and the LUN is a MMC device with > 0 available blocks. This is a blank disk so force scsi generic. > > This allows the guest to talk directly t

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread ronnie sahlberg
On Sun, Aug 19, 2012 at 7:58 AM, Paolo Bonzini wrote: > Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: >> There is no bdrv_* API for the commands for burning a blank MMC disk >> so when iSCSI LUNs are specified and the LUN is a MMC device with >> 0 available blocks. This is a blank disk so force

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread ronnie sahlberg
Ah, This patch only affects the case when there is a blank / empty disk loaded. It has no effect on when real *.iso images are loaded and the disk contains data. The use case to be able to "burn" to an iscsi cdrom is probably not very urgent, so maybe it is best to delay this until post 1.2 reg

Re: [Qemu-devel] [PATCH 1/2] ISCSI: Set number of blocks to 0 for blank CDROM devices

2012-08-18 Thread ronnie sahlberg
On Sun, Aug 19, 2012 at 7:57 AM, Paolo Bonzini wrote: > Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: >> The number of blocks of the device is used to compute the device size >> in bdrv_getlength()/iscsi_getlength(). >> For MMC devices, the ReturnedLogicalBlockAddress in the READCAPACITY10 >> h

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Paolo Bonzini
Il 19/08/2012 00:02, ronnie sahlberg ha scritto: > Neither of them work, basically because in > block.c:find_image_format() > > if bs->sg is not set in > > if (bs->sg || !bdrv_is_inserted(bs)) { > > then we continue to > > ret = bdrv_pread(bs, 0, buf, sizeof(buf)); > > which fails with an e

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread ronnie sahlberg
On Sun, Aug 19, 2012 at 8:16 AM, Paolo Bonzini wrote: > Il 19/08/2012 00:02, ronnie sahlberg ha scritto: >> Neither of them work, basically because in >> block.c:find_image_format() >> >> if bs->sg is not set in >> >> if (bs->sg || !bdrv_is_inserted(bs)) { >> >> then we continue to >> >> ret =

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Paolo Bonzini
Il 19/08/2012 00:02, ronnie sahlberg ha scritto: > On Sun, Aug 19, 2012 at 7:58 AM, Paolo Bonzini wrote: >> Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: >>> There is no bdrv_* API for the commands for burning a blank MMC disk >>> so when iSCSI LUNs are specified and the LUN is a MMC device wit

Re: [Qemu-devel] [GIT PULL] tcm_vhost: Initial merge of vhost level target fabric driver

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 23:04 +0300, Michael S. Tsirkin wrote: > Hi Nicholas, > I just noticed this problem in the interface: > > +#include > + > +/* > + * Used by QEMU userspace to ensure a consistent vhost-scsi ABI. > + * > + * ABI Rev 0: July 2012 version starting point for v3.6-rc merge > candi

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread Paolo Bonzini
Il 19/08/2012 00:19, ronnie sahlberg ha scritto: >> > Yeah, I think in this case find_image_format should just use raw. > Ok, so that is basically what the patch does. It forces bs->sg==true > so that we pick "raw" right there instead of trying to read from the > device. > > So you are happy with

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 22:10 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 14, 2012 at 02:12:29PM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2012-08-13 at 11:59 +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > > > > +if

Re: [Qemu-devel] [PATCH 2/2] ISCSI: Force scsi-generic for MMC with blank disks

2012-08-18 Thread ronnie sahlberg
On Sun, Aug 19, 2012 at 8:20 AM, Paolo Bonzini wrote: > Il 19/08/2012 00:02, ronnie sahlberg ha scritto: >> On Sun, Aug 19, 2012 at 7:58 AM, Paolo Bonzini wrote: >>> Il 17/08/2012 04:36, Ronnie Sahlberg ha scritto: There is no bdrv_* API for the commands for burning a blank MMC disk so

Re: [Qemu-devel] Compilation Error with gcc 4.6

2012-08-18 Thread Peter Maydell
On 18 August 2012 17:54, MJ embd wrote: > Hi All, > I am trying to compile qemu for arm top of tree on ubuntu 12.04 and am > getting the following errors. Can anyone help > LINK qemu-ga > /usr/lib/gcc/arm-linux-gnueabi/4.6/../../../../arm-linux-gnueabi/bin/ld: > cannot find -lgthread-2.0 > /us

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-18 Thread Nicholas A. Bellinger
On Sat, 2012-08-18 at 22:12 +0300, Michael S. Tsirkin wrote: > On Tue, Aug 14, 2012 at 01:31:14PM -0700, Nicholas A. Bellinger wrote: > > On Mon, 2012-08-13 at 11:53 +0300, Michael S. Tsirkin wrote: > > > On Mon, Aug 13, 2012 at 08:35:14AM +, Nicholas A. Bellinger wrote: > > > > From: Stefan Ha

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-18 Thread Brian Jackson
On Friday 17 August 2012 07:36:42 Richard Davies wrote: > Hi Avi, > > Thanks to you and several others for offering help. We will work with Avi > at first, but are grateful for all the other offers of help. We have a > number of other qemu-related projects which we'd be interested in getting > don