Re: [Qemu-devel] [PATCH] monitor: Fix warning from clang

2012-08-20 Thread Markus Armbruster
Stefan Weil writes: > Am 17.08.2012 17:02, schrieb Luiz Capitulino: >> On Fri, 17 Aug 2012 16:41:34 +0200 >> Markus Armbruster wrote: >> >>> Luiz Capitulino writes: >>> On Fri, 17 Aug 2012 16:10:12 +0200 Markus Armbruster wrote: > Stefan Weil writes: > >> ccc-analyz

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-20 Thread Paolo Bonzini
Il 19/08/2012 21:22, Stefan Priebe - Profihost AG ha scritto: > >> No problem, my fault---I'm just back and I haven't really started again >> all my stuff, so the patch was not tested. >> >> This should fix it, though. > > Booting works fine now. But the VM starts to hang after trying to unmap >

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-20 Thread Stefan Priebe - Profihost AG
Am 20.08.2012 09:22, schrieb Paolo Bonzini: Il 19/08/2012 21:22, Stefan Priebe - Profihost AG ha scritto: No problem, my fault---I'm just back and I haven't really started again all my stuff, so the patch was not tested. This should fix it, though. Booting works fine now. But the VM starts

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> Hi, > > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > >> > >> Just delete this and use > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > > > So you are telling me to undo a change that Gerd asked for - could > > you > > please at least debat

Re: [Qemu-devel] qemu compilation fails on ubuntu 12.04

2012-08-20 Thread Stefan Hajnoczi
On Sat, Aug 18, 2012 at 11:14:43PM +0530, MJ embd wrote: > Hi All, > I am trying to compile qemu for arm top of tree on ubuntu 12.04 and am > getting the following errors. Can anyone help > > ... > CCjson-streamer.o > CCjson-parser.o > CCqerror.o > CCerror.o > CCqemu-er

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 09:34, Stefan Priebe - Profihost AG ha scritto: >>> Booting works fine now. But the VM starts to hang after trying to unmap >>> large regions. No segfault or so just not reacting anymore. >> >> This is expected; unfortunately cancellation right now is a synchronous >> operation in the

Re: [Qemu-devel] [PATCH RFT 0/3] iscsi: fix NULL dereferences / races between task completion and abort

2012-08-20 Thread Stefan Priebe - Profihost AG
Hi Ronnie, Am 20.08.2012 10:08, schrieb Paolo Bonzini: That's because the "big QEMU lock" is held by the thread that called qemu_aio_cancel. and i also see no cancellation message in kernel log. And that's because the UNMAP actually ultimately succeeds. You'll probably see soft lockup messa

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-20 Thread Richard Davies
Brian Jackson wrote: > Richard Davies wrote: > > The host in question has 128GB RAM and dual AMD Opteron 6128 (16 cores > > total). It is running kernel 3.5.1 and qemu-kvm 1.1.1. > > > > In this morning's test, we have 3 guests, all booting Windows with 40GB RAM > > and 8 cores each (we have seen s

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> > Hi, > > > > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC > > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > > >> > > >> Just delete this and use > > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > > > > > > So you are telling me to undo a change that Gerd asked for - > > > could > > > you

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-20 Thread Paolo Bonzini
Il 19/08/2012 10:13, Ruben Kerkhof ha scritto: >> > That's correct. Live block migration will use two ports, both served by >> > the destination, one using NBD and one for RAM/device migration data. >> > It will be a little more complicated than just migrate -b, but nothing >> > that libvirt canno

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
On 08/20/12 10:00, Alon Levy wrote: >> Hi, >> > +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define > QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). >>> >>> So you are telling me to undo a change that Gerd asked for -

Re: [Qemu-devel] [PATCH] block-migration: deprecate block migration for the 1.2 release

2012-08-20 Thread Ruben Kerkhof
On Mon, Aug 20, 2012 at 10:23 AM, Paolo Bonzini wrote: > Il 19/08/2012 10:13, Ruben Kerkhof ha scritto: >>> > That's correct. Live block migration will use two ports, both served by >>> > the destination, one using NBD and one for RAM/device migration data. >>> > It will be a little more complica

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
> On 08/20/12 10:00, Alon Levy wrote: > >> Hi, > >> > > +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define > > QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 > > Just delete this and use > defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). > >>> > >>> So you are telling me to undo a change th

Re: [Qemu-devel] [PATCH 2/2] hd-geometry.c: Integrate HDIO_GETGEO in guessing

2012-08-20 Thread Paolo Bonzini
Il 15/08/2012 09:44, Jens Freimann ha scritto: > From: Einar Lueck > > This patch extends the function guess_disk_lchs. If no geo could > be derived from reading disk content, HDIO_GETGEO ioctl is issued. > If this is not successful (e.g. image files) geometry is derived > from the size of the di

Re: [Qemu-devel] [PATCH 1/2] virtio-block: support auto-sensing of block sizes

2012-08-20 Thread Paolo Bonzini
Il 15/08/2012 09:44, Jens Freimann ha scritto: > From: Einar Lueck > > Virtio-blk does not impose fixed block sizes for access to > backing devices. This patch introduces support for auto > lookup of the block sizes of the backing block device. This > automatic lookup needs to be enabled explicit

Re: [Qemu-devel] [PATCH v3 2/2] pc: Fix RTC CMOS info on RAM for ram_size < 1MiB

2012-08-20 Thread Markus Armbruster
"Kevin O'Connor" writes: > On Wed, Aug 15, 2012 at 01:12:20PM +0200, Markus Armbruster wrote: >> pc_cmos_init() always claims 640KiB base memory, and ram_size - 1MiB >> extended memory. The latter can underflow to "lots of extended >> memory". Fix both, and clean up some. >> >> Note: SeaBIOS c

[Qemu-devel] [PATCH uq/master] kvm: Clean up irqfd API

2012-08-20 Thread Jan Kiszka
No need to expose the fd-based interface, everyone will already be fine with the more handy EventNotifier variant. Rename the latter to clarify that we are still talking about irqfds here. Signed-off-by: Jan Kiszka --- Alex, please update your vfio patch accordingly. hw/virtio-pci.c |4 ++-

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
On Sat, Aug 18, 2012 at 07:07:46PM +, Blue Swirl wrote: > On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy wrote: > > On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: > >> On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy wrote: > >> > Revision bumped to 4 for new IO support, enabled for spice-

Re: [Qemu-devel] [RFC-v2 3/6] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-08-20 Thread Paolo Bonzini
Il 13/08/2012 10:35, Nicholas A. Bellinger ha scritto: > From: Stefan Hajnoczi > > This patch adds a new type of host device that drives the vhost_scsi > device. The syntax to add vhost-scsi is: > > qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 > > The virtio-scsi emulated device will ma

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
Hi, >> Maybe revisit upstream spice packaging? spice internal usage of >> spice-protocol is handled via submodules now. Are there external >> users, other than qemu? Does it make sense to keep the >> spice-server / spice-protocol split in the first place? Or should >> spice-server just pro

Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-20 Thread Paolo Bonzini
Il 13/08/2012 10:35, Nicholas A. Bellinger ha scritto: > From: Stefan Hajnoczi > > This patch starts and stops vhost as the virtio device transitions > through its status phases. Vhost can only be started once the guest > reports its driver has successfully initialized, which means the > virtque

[Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query

2012-08-20 Thread Cong Meng
Each virtio scsi HBA has global request queue limits. But the passthrough LUNs (scsi-generic) come from different host HBAs may have different request queue limits. If the guest sends commands that exceed the host limits, the commands will be rejected by host HAB. To address this issue, this patc

[Qemu-devel] [PATCH v8 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- Changes for patchset v7->v8: QXL_IO_MONITORS_CONFIG_ASYNC is defined even when spice-protocol < 0.12 (Gerd Hoffman) QXL_HAS_.. is either defined or not, same as other feature definitions (Blue Swirl) Only the third patch "qxl: add QXL_IO_MONITORS_CONFIG_ASYNC" i

[Qemu-devel] [PATCH v8 2/4] qxl: disallow unknown revisions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break

[Qemu-devel] [PATCH v8 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= 0.12.0. This io calls the corresponding new spice api spice_qxl_monitors_config_async to let s

[Qemu-devel] [PATCH v8 4/4] configure: print spice-protocol and spice-server versions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ff6443e..aae051b 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice="yes" libs_softmmu="$libs_softmmu $spice_libs" QEMU_CFLA

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
- Original Message - > Hi, > > >> Maybe revisit upstream spice packaging? spice internal usage of > >> spice-protocol is handled via submodules now. Are there external > >> users, other than qemu? Does it make sense to keep the > >> spice-server / spice-protocol split in the first pla

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : > This patchset create a block driver implementing a quorum using m qemu disk > images. Writes are mirrored on the m files. > For the reading part the m files are read at the same time and a vote is > done to determine if a qiov vers

Re: [Qemu-devel] [PATCH] i2c: factor out VMSD to parent class

2012-08-20 Thread Juan Quintela
Peter Crosthwaite wrote: > On Tue, Aug 14, 2012 at 6:46 PM, Peter Maydell > wrote: >> On 14 August 2012 09:27, Juan Quintela wrote: >>> "Peter A. G. Crosthwaite" wrote: Hi All. PMM raised a query on a recent series of mine (the SSI series) about handling VMSD for devices which

[Qemu-devel] KVM call agenda for Tuesday, August 21

2012-08-20 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

[Qemu-devel] [PATCH for-1.2] linux-user: Clarify "Unable to reserve guest address space" error

2012-08-20 Thread Peter Maydell
Now that we default to reserving nearly 4GB of RAM for the guest address space when running a 32 bit linux-user guest on 64 bit hosts, users are much more likely to run into it. Reword the message to be more informative about what failed and provide suggestions for how to fix things. Signed-off-by

Re: [Qemu-devel] [PATCH v8 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Gerd Hoffmann
Hi, Patch looks alot nicer now with a bunch if #ifdefs removed. One issue left I missed before: > case QXL_MODE_COMPAT: > /* note: no need to call qxl_create_memslots, qxl_set_mode > @@ -2065,6 +2124,7 @@ static VMStateDescription qxl_vmstate = { > VMSTATE_ARRAY(guest_su

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-08-20 Thread Andreas Färber
Am 17.08.2012 19:53, schrieb Eduardo Habkost: > It's nice to have a flexible system to maintain CPU models as data, but > this is holding us from making improvements in the CPU code because it's > not using the common infra-structure, and because the machine-type data > is still inside C code. > >

Re: [Qemu-devel] [RFC v0] HACK: qom: object_property_set: abort on failure

2012-08-20 Thread Andreas Färber
Am 20.08.2012 04:18, schrieb Peter Crosthwaite: > [...] Here's my code as it stands: > > Error *errp = NULL; > object_property_set_link(OBJECT(dev), OBJECT(cpus[0]), "cpu0", &errp); > assert_no_error(errp); There's two pitfalls there, the needed object_property_add_link() that you stumbled over a

[Qemu-devel] buildbot failure in qemu on monitor_i386_debian_6_0

2012-08-20 Thread qemu
The Buildbot has detected a new failure on builder monitor_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/monitor_i386_debian_6_0/builds/366 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

Re: [Qemu-devel] [PATCH 1/5] move qemu_irq typedef out of cpu-common.h

2012-08-20 Thread Igor Mammedov
On Mon, 20 Aug 2012 06:41:04 +0200 Stefan Weil wrote: > Am 20.08.2012 01:39, schrieb Igor Mammedov: > > it's necessary for making CPU child of DEVICE without > > causing circular header deps. > > > > Signed-off-by: Igor Mammedov > > --- > > hw/arm-misc.h |1 + > > hw/bt.h |2 ++

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 11:12 AM, Benoît Canet wrote: > Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : >> This patchset create a block driver implementing a quorum using m qemu disk >> images. Writes are mirrored on the m files. >> For the reading part the m files are read at th

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi wrote: > On Mon, Aug 20, 2012 at 11:12 AM, Benoît Canet > wrote: >> Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : >>> This patchset create a block driver implementing a quorum using m qemu disk >>> images. Writes are mirrored

Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 10:04 AM, Paolo Bonzini wrote: > Il 13/08/2012 10:35, Nicholas A. Bellinger ha scritto: >> From: Stefan Hajnoczi >> >> This patch starts and stops vhost as the virtio device transitions >> through its status phases. Vhost can only be started once the guest >> reports its

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Monday 20 Aug 2012 à 12:24:33 (+0100), Stefan Hajnoczi a écrit : > On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi wrote: > > On Mon, Aug 20, 2012 at 11:12 AM, Benoît Canet > > wrote: > >> Le Tuesday 14 Aug 2012 à 16:14:02 (+0200), Benoît Canet a écrit : > >>> This patchset create a block

Re: [Qemu-devel] [PATCH 0/5 v2] cpu: make a child of DeviceState

2012-08-20 Thread Igor Mammedov
On Mon, 20 Aug 2012 06:52:51 +0200 Stefan Weil wrote: > Am 20.08.2012 01:39, schrieb Igor Mammedov: > > this is th 3rd approach to make CPU a child of DeviceState > > for both kinds of targets *-user and *-softmmu. It seems > > with current state of qemu it doesn't take too much effort > > to mak

[Qemu-devel] [RFC V4 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a vote is done to determine if a qiov version is present $threshold or more times. It then return thi

Re: [Qemu-devel] [PATCH v2 00/12] Portable thread-pool/AIO, Win32 emulated AIO

2012-08-20 Thread Paolo Bonzini
Il 13/08/2012 21:43, Stefan Weil ha scritto: >> >> Label out_free_buf is only used with CONFIG_LINUX_AIO. >> >> off_t is always 32 bit with MinGW header files, but we >> want support for large files, so off64_t is a better choice >> here. It also avoids a compiler warning when the value >> is right

Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-20 Thread Michael S. Tsirkin
On Mon, Aug 20, 2012 at 12:31:01PM +0100, Stefan Hajnoczi wrote: > On Mon, Aug 20, 2012 at 10:04 AM, Paolo Bonzini wrote: > > Il 13/08/2012 10:35, Nicholas A. Bellinger ha scritto: > >> From: Stefan Hajnoczi > >> > >> This patch starts and stops vhost as the virtio device transitions > >> through

[Qemu-devel] [RFC V4 8/9] quorum: Add quorum mechanism.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 211 +++- 1 file changed, 210 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 95f4668..a909ce2 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -14,6 +14,20 @@

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-08-20 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:38 -0300 Eduardo Habkost wrote: > It's nice to have a flexible system to maintain CPU models as data, but > this is holding us from making improvements in the CPU code because it's > not using the common infra-structure, and because the machine-type data > is still insid

Re: [Qemu-devel] [RFC-v2 4/6] virtio-scsi: Add start/stop functionality for vhost-scsi

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 13:57, Michael S. Tsirkin ha scritto: >>> > > How much of the functionality of virtio-scsi.[ch] is still in use at >>> > > this point? Would it make more sense to use a separate vhost-scsi-pci >>> > > device instead? >> > >> > Since the SCSI target lives in the kernel, almost everyt

Re: [Qemu-devel] [RFC 0/6] i386: CPU: remove duplicate feature names

2012-08-20 Thread Igor Mammedov
On Fri, 17 Aug 2012 14:53:36 -0300 Eduardo Habkost wrote: > The problem: > > - Some features are report at the same time on both CPUID[1].EDX and >CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx). > - "-cpu ,+feature" should enable the bit only on CPUID[1] if >it's not a

[Qemu-devel] [RFC V4 7/9] quorum: Add quorum_aio_readv.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 092d1ea..95f4668 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -180,15 +180,24 @@ static void quo

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
On Tue, 2012-07-31 at 14:59 +0200, Andreas Färber wrote: > Am 24.07.2012 09:37, schrieb Christian Borntraeger: > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those events don't > > provide SCLP commands on their own, instead they are all based on > > Read Even

Re: [Qemu-devel] [PATCH 3/7] s390: sclp base support

2012-08-20 Thread Heinz Graalfs
Hi Alex, there was one leftover ... On Mon, 2012-07-30 at 14:38 +0200, Alexander Graf wrote: > On 24.07.2012, at 09:37, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > This adds a more generic infrastructure for handling Service-Call > > requests on s390. Currently we only supp

Re: [Qemu-devel] [PATCH 4/7] s390: sclp event support

2012-08-20 Thread Heinz Graalfs
Alex, some more answers for a couple of leftovers. Heinz On Mon, 2012-07-30 at 15:24 +0200, Alexander Graf wrote: > On 24.07.2012, at 09:37, Christian Borntraeger wrote: > > > From: Heinz Graalfs > > > > Several SCLP features are considered to be events. Those events don't > > provide SCLP co

Re: [Qemu-devel] [PATCH 07/21] target-i386: convert cpuid features into properties

2012-08-20 Thread Igor Mammedov
On Thu, 16 Aug 2012 15:10:50 -0300 Eduardo Habkost wrote: > On Wed, Aug 15, 2012 at 06:13:27PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > -- > > v2: > > * replaced mask/ffs tricks by plain 'for (bit = 0; bit < 32; bit++)' > > as suggested by Eduardo Habkost > > --- >

[Qemu-devel] [RFC V4 4/9] quorum: Add quorum_aio_writev and its dependencies.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 112 1 file changed, 112 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 70e7216..5c87cec 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -159,6 +159,116 @@ static void

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Juan Quintela
Natanael Copa wrote: > Fixes build against uClibc. > > uClibc provides 2 versions of clock_gettime(), one with realtime > support and one without (this is so you can avoid linking in -lrt > unless actually needed). This means that the clock_gettime() don't > need -lrt. We still need it for timer_c

[Qemu-devel] [RFC V4 1/9] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index b5754d3..66af6dc 100644 --- a/

[Qemu-devel] [RFC V4 3/9] quorum: Add quorum_open() and quorum_close().

2012-08-20 Thread Benoît Canet
Valid quorum resources look like: quorum:threshold/total:path/to/image_1: ... :path/to/image_total '\' can escape the ':' character. Signed-off-by: Benoit Canet --- block/quorum.c | 110 1 file changed, 110 insertions(+) diff --git a/bl

[Qemu-devel] [RFC V4 9/9] quorum: Add quorum_getlength().

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a909ce2..7bd6f0e 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -525,12 +525,42 @@ static coroutine_fn int quorum_co_flus

[Qemu-devel] [RFC V4 2/9] quorum: Create BDRVQuorumState and BlkDriver and do init.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 65a6b55..19a9a44 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block_int.h" +typedef struct { +

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-08-20 Thread Eduardo Habkost
On Mon, Aug 20, 2012 at 02:00:14PM +0200, Igor Mammedov wrote: > On Fri, 17 Aug 2012 14:53:38 -0300 > Eduardo Habkost wrote: > > > It's nice to have a flexible system to maintain CPU models as data, but > > this is holding us from making improvements in the CPU code because it's > > not using the

[Qemu-devel] [RFC V4 5/9] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + cutils.c | 103 ++ qemu-common.h |2 + 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blkveri

[Qemu-devel] [RFC V4 6/9] quorum: Add quorum_co_flush().

2012-08-20 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 13 + 1 file changed, 13 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 5c87cec..092d1ea 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -269,6 +269,18 @@ static BlockDriverAIOCB *quorum_aio_writev(BlockDriverS

Re: [Qemu-devel] [PATCH 07/21] target-i386: convert cpuid features into properties

2012-08-20 Thread Eduardo Habkost
On Mon, Aug 20, 2012 at 02:16:26PM +0200, Igor Mammedov wrote: > On Thu, 16 Aug 2012 15:10:50 -0300 > Eduardo Habkost wrote: > > > On Wed, Aug 15, 2012 at 06:13:27PM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > -- > > > v2: > > > * replaced mask/ffs tricks by plain 'for

Re: [Qemu-devel] [PATCH v2] configure: properly check if -lrt and -lm is needed

2012-08-20 Thread Peter Maydell
On 16 August 2012 14:22, Natanael Copa wrote: > Fixes build against uClibc. > > uClibc provides 2 versions of clock_gettime(), one with realtime > support and one without (this is so you can avoid linking in -lrt > unless actually needed). This means that the clock_gettime() don't > need -lrt. We

Re: [Qemu-devel] [PATCH 4/4] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-20 Thread Paolo Bonzini
Il 17/08/2012 21:25, Kevin Wolf ha scritto: > From: Stefan Hajnoczi > > QEMU has a policy of keeping a stable guest device ABI. When new guest device > features are introduced they must not change hardware info seen by existing > guests. This is important because operating systems or applicatio

Re: [Qemu-devel] [PATCH 4/4] virtio-blk: hide VIRTIO_BLK_F_CONFIG_WCE from old machine types

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 1:46 PM, Paolo Bonzini wrote: > Il 17/08/2012 21:25, Kevin Wolf ha scritto: >> From: Stefan Hajnoczi >> >> QEMU has a policy of keeping a stable guest device ABI. When new guest >> device >> features are introduced they must not change hardware info seen by existing >> g

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Stefan Hajnoczi
On Mon, Aug 20, 2012 at 12:42 PM, Benoît Canet wrote: > > Le Monday 20 Aug 2012 à 12:24:33 (+0100), Stefan Hajnoczi a écrit : >> On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi wrote: >> > On Mon, Aug 20, 2012 at 11:12 AM, Benoît Canet >> > wrote: >> >> Le Tuesday 14 Aug 2012 à 16:14:02 (+020

[Qemu-devel] [PATCH] linux-user: Remove #if 0'd cpu_get_real_ticks() definition

2012-08-20 Thread Peter Maydell
Remove the cpu_get_real_ticks() definition from linux-user/main.c. This has been disabled via #if 0 and unused since commit 1dce7c3c22 in 2006; the definitions we actually use are in qemu-timer.h. Signed-off-by: Peter Maydell --- linux-user/main.c | 13 - 1 file changed, 13 deletio

Re: [Qemu-devel] [PATCH] virtio-scsi spec: add per-LUN parameter query

2012-08-20 Thread Paolo Bonzini
Il 20/08/2012 11:03, Cong Meng ha scritto: > Each virtio scsi HBA has global request queue limits. But the passthrough > LUNs (scsi-generic) come from different host HBAs may have different request > queue limits. If the guest sends commands that exceed the host limits, the > commands will be rejec

[Qemu-devel] [PATCH] net: add receive_disabled logic to iov delivery path

2012-08-20 Thread Stefan Hajnoczi
This patch adds the missing NetClient->receive_disabled logic in the sendv delivery code path. It seems that commit 893379efd0e1b84ceb0c42a713293f3dbd27b1bd ("net: disable receiving if client returns zero") only added the logic to qemu_deliver_packet() and not qemu_deliver_packet_iov(). The recei

[Qemu-devel] [PATCH] net: do not report queued packets as sent

2012-08-20 Thread Stefan Hajnoczi
Net send functions have a return value where 0 means the packet has not been sent and will be queued. A non-zero value means the packet was sent or an error caused the packet to be dropped. This patch fixes two instances where packets are queued but we return their size. This causes callers to b

[Qemu-devel] [PATCH v2 3/5] spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

2012-08-20 Thread Yonit Halperin
When migrating, libvirt queries the migration status, and upon migration completions, it closes the migration src. On the other hand, when migration is completed, spice transfers data from the src to destination via the client. This data is required for keeping the spice session after migration, wi

Re: [Qemu-devel] [PATCH v7 0/6] convert sendkey to qapi

2012-08-20 Thread Eric Blake
On 08/19/2012 10:39 PM, Amos Kong wrote: > This series converted 'sendkey' command to qapi. The raw value > in hexadecimal format is not supported by 'send-key' of qmp. Are we still trying to get this into 1.2, or have we missed that deadline? -- Eric Blake ebl...@redhat.com+1-919-301-3266

[Qemu-devel] [PATCH v9 1/5] qxl/update_area_io: guest_bug on invalid parameters

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- v8->v9: * split guest_monitors_config to a subsection (Gerd Hoffman) - no change to other patches. hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6

[Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-20 Thread Alon Levy
--- .gitmodules| 3 +++ compiler.h | 7 +++ spice-protocol | 1 + 3 files changed, 11 insertions(+) create mode 16 spice-protocol diff --git a/.gitmodules b/.gitmodules index eca876f..ba6844b 100644 --- a/.gitmodules +++ b/.gitmodules @@ -19,3 +19,6 @@ [submodule "roms/sgabios"]

[Qemu-devel] [PATCH v2 1/5] spice: notify spice server on vm start/stop

2012-08-20 Thread Yonit Halperin
Spice server needs to know about the vm state in order to prevent attempts to write to devices when they are stopped, mainly during the non-live stage of migration. Instead, spice will take care of restoring this writes, on the migration target side, after migration completes. Signed-off-by: Yonit

[Qemu-devel] [PATCH v2 2/5] spice: notify on vm state change only via spice_server_vm_start/stop

2012-08-20 Thread Yonit Halperin
QXLWorker->start/stop are deprecated since spice-server 0.11.2 Signed-off-by: Yonit Halperin --- ui/spice-core.c| 44 ui/spice-display.c |6 ++ ui/spice-display.h |2 ++ 3 files changed, 52 insertions(+), 0 deletions(-) diff --git a

Re: [Qemu-devel] qemu-ga : Guest Agent : Windows 2008 : Unknown command guest-fsfreeze-freeze

2012-08-20 Thread Luiz Capitulino
On Fri, 17 Aug 2012 10:11:29 -0700 (PDT) desi babu wrote: > Guest-Agent : Windows 2008 Error : Relase 1.1.90 > > error : internal error unable to execute QEMU command > 'guest-fsfreeze-freeze': this feature or command is not currently supported. That's correct, fsfreze is not supported on Wind

Re: [Qemu-devel] Windows slow boot: contractor wanted

2012-08-20 Thread Richard Davies
Avi Kivity wrote: > Richard Davies wrote: > > Hi Avi, > > > > Thanks to you and several others for offering help. We will work with Avi at > > first, but are grateful for all the other offers of help. We have a number > > of other qemu-related projects which we'd be interested in getting done, and

Re: [Qemu-devel] [PATCH] device_tree: load_device_tree(): Allow NULL sizep

2012-08-20 Thread Stefan Hajnoczi
On Thu, Aug 16, 2012 at 3:14 AM, David Gibson wrote: > On Wed, Aug 15, 2012 at 02:41:56PM +0100, Stefan Hajnoczi wrote: >> On Sat, Aug 11, 2012 at 01:33:42PM +0100, Stefan Hajnoczi wrote: >> > On Sat, Aug 11, 2012 at 12:11 AM, Peter Crosthwaite >> > wrote: >> > > On Fri, Aug 10, 2012 at 11:42 PM,

[Qemu-devel] [PATCH] Hack qmp.py to support reading a JSON multi-line response

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" The qmp-shell code assumes the JSON response is only on a single line. If the QEMU monitor is configured in "pretty print" mode the JSON response can be multi-line. The basic Python JSON APIs do not appear to support a streaming mode, so the simple hack here is to try p

[Qemu-devel] [PATCH] Add a '-r' option to qmp-shell to print out raw JSON replies

2012-08-20 Thread Daniel P. Berrange
From: "Daniel P. Berrange" By default, the JSON reply is parsed and the corresponding python object printed on the console. When developing JSON client apps for QEMU though, it is handy to see the raw JSON document instead. Add a '-r' option that will cause the raw JSON to be printed, instead of

Re: [Qemu-devel] [RFC V3 0/9] Quorum disk image corruption resiliency

2012-08-20 Thread Benoît Canet
Le Monday 20 Aug 2012 à 13:56:53 (+0100), Stefan Hajnoczi a écrit : > On Mon, Aug 20, 2012 at 12:42 PM, Benoît Canet > wrote: > > > > Le Monday 20 Aug 2012 à 12:24:33 (+0100), Stefan Hajnoczi a écrit : > >> On Mon, Aug 20, 2012 at 12:23 PM, Stefan Hajnoczi > >> wrote: > >> > On Mon, Aug 20, 201

Re: [Qemu-devel] [PATCH] qapi: Fix memory leak

2012-08-20 Thread Luiz Capitulino
On Sun, 19 Aug 2012 12:12:29 +0200 Laszlo Ersek wrote: > On 08/18/12 22:51, Stefan Weil wrote: > > valgrind report: > > > > ==24534== 232 bytes in 2 blocks are definitely lost in loss record 1,245 of > > 1,601 > > ==24534==at 0x4824F20: malloc (vg_replace_malloc.c:236) > > ==24534==by 0

[Qemu-devel] [PATCH v2 4/5] spice: add 'migrated' flag to spice info

2012-08-20 Thread Yonit Halperin
The flag is 'true' when spice migration has completed on the src side. It is needed for a case where libvirt dies before migration completes and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED. When libvirt is restored and queries the migration status, it also needs to query spice and check if i

[Qemu-devel] [PATCH v9 3/5] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server >= 0.11.1. New io enabled iff revision is 4. Revision can be set to 4, and defaults to 4, iff spice-server >= 0.11.1 && spice-protocol >= 0.12.0. This io calls the corresponding new spice api spice_qxl_monitors_config_async to let s

[Qemu-devel] [PATCH v9 2/5] qxl: disallow unknown revisions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size = 16; break

[Qemu-devel] [PATCH 4/5] iscsi: fix races between task completion and abort

2012-08-20 Thread Paolo Bonzini
This patch fixes two main issues with block/iscsi.c: 1) iscsi_task_mgmt_abort_task_async calls iscsi_scsi_task_cancel which was also directly called in iscsi_aio_cancel 2) a race between task completion and task abortion could happen cause the scsi_free_scsi_task were done before iscsi_schedule_b

[Qemu-devel] [PATCH 1/5] Revert "iscsi: Fix NULL dereferences / races between task completion and abort"

2012-08-20 Thread Paolo Bonzini
This reverts commit 64e69e80920d82df3fa679bc41b13770d2f99360. The commit returned immediately from iscsi_aio_cancel, risking corruption in case the following happens: guest qemu target =

[Qemu-devel] [PATCH 3/5] iscsi: simplify iscsi_schedule_bh

2012-08-20 Thread Paolo Bonzini
It is always used with the same callback, remove the argument. And its return value is never used, assume allocation succeeds. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 24 +--- 1 file modificato, 9 inserzioni(+), 15 rimozioni(-) diff --git a/block/iscsi.c b/block/is

[Qemu-devel] [PATCH 2/5] iscsi: move iscsi_schedule_bh and iscsi_readv_writev_bh_cb

2012-08-20 Thread Paolo Bonzini
Put these functions at the beginning, to avoid forward references in the next patches. Signed-off-by: Paolo Bonzini --- block/iscsi.c | 56 1 file modificato, 28 inserzioni(+), 28 rimozioni(-) diff --git a/block/iscsi.c b/block/iscsi.c in

[Qemu-devel] [PULL 0/5] SCSI fixed for -rc1

2012-08-20 Thread Paolo Bonzini
The following changes since commit e89001f72edde37fb36fa7c964daa1bbeb2eca26: pc: Fix RTC CMOS info on RAM for ram_size < 1MiB (2012-08-18 16:54:23 +) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you to fetch changes up to 07a5298c3067ed63f7d82d

[Qemu-devel] [PATCH v2 0/5] add support for spice migration v2

2012-08-20 Thread Yonit Halperin
v2: Notify spice about vm state changes only via spice_server_vm_start/stop spice repo: http://cgit.freedesktop.org/~yhalperi/spice/log/?h=seamless-migration.v2 --- Hi, The following series introduces support for keeping the spice session active after migration. For more details about s

[Qemu-devel] [PATCH v9 4/5] configure: print spice-protocol and spice-server versions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ff6443e..aae051b 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice="yes" libs_softmmu="$libs_softmmu $spice_libs" QEMU_CFLA

[Qemu-devel] [PATCH 2/3] net: EAGAIN handling for net/socket.c UDP

2012-08-20 Thread Stefan Hajnoczi
Implement asynchronous send for UDP (or other SOCK_DGRAM) sockets. If send fails with EAGAIN we wait for the socket to become writable again. Signed-off-by: Stefan Hajnoczi --- net/socket.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/net/socket.c b/net/

[Qemu-devel] [PATCH 3/3] net: EAGAIN handling for net/socket.c TCP

2012-08-20 Thread Stefan Hajnoczi
Replace spinning send_all() with a proper non-blocking send. When the socket write buffer limit is reached, we should stop trying to send and wait for the socket to become writable again. Non-blocking TCP sockets can return in two different ways when the write buffer limit is reached: 1. ret = -

[Qemu-devel] [PATCH 0/4 v4] s390: sclp patch set

2012-08-20 Thread Jens Freimann
This patch-set improves the Service-Call Logical Processor support for s390. changes v3->v4: - Event Facility was moved to the main system bus and we now keep the event_facility pointer within the current machine's global property-list as opaque pointer - removed locking - some code refactor

[Qemu-devel] [PATCH 2/4] s390: sclp event support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs Several SCLP features are considered to be events. Those events don't provide SCLP commands on their own, instead they are all based on Read Event Data, Write Event Data, Write Event Mask and the service interrupt. Follow-on patches will provide SCLP's Signal Quiesce (via syst

[Qemu-devel] [PATCH 1/4] s390: sclp base support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs This adds a more generic infrastructure for handling Service-Call requests on s390. Currently we only support a small subset of Read SCP Info directly in target-s390x. This patch provides the base infrastructure for supporting more commands and moves Read SCP Info. In the futu

[Qemu-devel] [PATCH 4/4] s390: sclp ascii console support

2012-08-20 Thread Jens Freimann
From: Heinz Graalfs This code adds console support by implementing SCLP's ASCII Console Data event. This is the same console as LPARs ASCII console or z/VMs sysascii. The console can be specified manually with something like -chardev stdio,id=charconsole0 -device sclpconsole,chardev=charconsole

  1   2   >