Re: [Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open

2012-10-04 Thread Paolo Bonzini
Il 05/10/2012 08:28, Paolo Bonzini ha scritto: >>> void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) >>> diff --git a/vl.c b/vl.c >>> index 53917c9..45a5ba5 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -3692,8 +3692,11 @@ int main(int argc, char **argv, char **envp) >>> #ifdef

Re: [Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 22:29, Luiz Capitulino ha scritto: > On Wed, 3 Oct 2012 16:37:00 +0200 > Paolo Bonzini wrote: > >> Before: >> >> $ qemu-system-x86_64 -vnc foo.bar:12345 >> getaddrinfo(foo.bar,18245): Name or service not known >> Failed to start VNC server on `foo.bar:12345' >> >> $

Re: [Qemu-devel] [PATCH 11/18] nbd: ask and print error information from qemu-sockets

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 22:08, Luiz Capitulino ha scritto: > On Wed, 3 Oct 2012 16:36:58 +0200 > Paolo Bonzini wrote: > >> Before: >> >> $ qemu-system-x86_64 nbd:localhost:12345 >> inet_connect_opts: >> connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345): Connection refused >> qemu-system-x

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 20:24, Luiz Capitulino ha scritto: > That DPRINTF() usage is really bizarre, it seems its purpose is to report > an error to the user, but that's a debugging call. > > I'd let it there and replace it later with proper tracing code, but that's > quite minor for me. Please, at least me

Re: [Qemu-devel] [PATCH 05/18] migration: avoid using error_is_set

2012-10-04 Thread Paolo Bonzini
Il 04/10/2012 20:06, Luiz Capitulino ha scritto: >> > +if (ret < 0 || local_err) { >> > +if (!local_err) { >> > +error_set_errno(errp, -ret, QERR_UNDEFINED_ERROR); > Two problems here. First, ret usually is not -errno. If we really want to > use it here (I think this is grea

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Avik Sil
I looked at the bootindex stuff and found that when the bootindex is specified for the disk and cdrom it generates a string like: "/spapr-vio-bridge/spapr-vscsi/channel@0/disk@0,1 /spapr-vio-bridge/spapr-vscsi/channel@0/disk@0,0" Ok, so I've just started looking at the bootindex stuff. What fu

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Stefan Weil
Am 05.10.2012 04:10, schrieb Anthony Liguori: Avi Kivity writes: The hassle and compile time overhead of maintaining both 32-bit and 64-bit capable source isn't worth the tiny performance advantage which is seen on a minority of configurations. Switch to compiling libhw only once, with target

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Nikunj A Dadhania
On Fri, 5 Oct 2012 10:34:16 +1000, David Gibson wrote: > On Thu, Oct 04, 2012 at 04:25:28PM +0530, Avik Sil wrote: > > On 09/27/2012 03:21 PM, Gleb Natapov wrote: > > >On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: > > >> > > >>On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Nikunj A Dadhania
On Thu, 4 Oct 2012 14:37:22 +0200, Alexander Graf wrote: > > Imagine you have 2 controllers: > > * vio > * virtio > > and you specify -boot c. Which device are you going to boot from? > >>> > >>> Currently, by default SLOF boots from the first disk it discover

Re: [Qemu-devel] [Qemu-ppc] [PATCH] PPC: KVM: Fix BAT put

2012-10-04 Thread David Gibson
On Fri, Oct 05, 2012 at 04:36:46AM +0200, Alexander Graf wrote: > In the sregs API, upper and lower 32bit segments of the BAT registers > are swapped when doing a set. Since we need to support old kernels out > there, don't bother to fix it in the kernel, but instead work around > the problem in QE

[Qemu-devel] [PATCH] PPC: KVM: Fix BAT put

2012-10-04 Thread Alexander Graf
In the sregs API, upper and lower 32bit segments of the BAT registers are swapped when doing a set. Since we need to support old kernels out there, don't bother to fix it in the kernel, but instead work around the problem in QEMU by swapping on put. Signed-off-by: Alexander Graf --- target-ppc/k

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-04 Thread Alexander Graf
On 05.10.2012, at 04:17, Anthony Liguori wrote: > Alexander Graf writes: > >> On 03.10.2012, at 22:26, Peter Maydell wrote: >> >>> On 3 October 2012 21:01, Blue Swirl wrote: On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori wrote: > Jan Kiszka writes: >> +/* The def

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-04 Thread Anthony Liguori
Alexander Graf writes: > On 03.10.2012, at 22:26, Peter Maydell wrote: > >> On 3 October 2012 21:01, Blue Swirl wrote: >>> On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori >>> wrote: Jan Kiszka writes: > +/* The default accelerator depends on the availability of KVM. */ >

Re: [Qemu-devel] [PULL 0/8] usb patch queue

2012-10-04 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > This is the usb patch queue. Adds a pc-1.3 machine type (patch #1) so I > can add xhci compat properties (patch #2). xhci gets usb hub support. > Other that that just a bunch of bugfixes. > > please pull, > Gerd > Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] virtio fixes

2012-10-04 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > The following changes since commit 6f8fd2530e9a530f237240daf1c981fa5df7f978: > > Merge branch 'arm-devs.for-upstream' of > git://git.linaro.org/people/pmaydell/qemu-arm (2012-09-27 21:48:56 +0200) > > are available in the git repository at: > > > git://git.kern

Re: [Qemu-devel] [PULL 00/15]: QMP queue

2012-10-04 Thread Anthony Liguori
Luiz Capitulino writes: > The changes (since ac05f3492421caeb05809ffa02c6198ede179e43) are available > in the following repository: > > git://repo.or.cz/qemu/qmp-unstable.git queue/qmp > Pulled. Thanks. Regards, Anthony Liguori > Luiz Capitulino (7): > qapi: convert add_client > qmp:

Re: [Qemu-devel] [PULL 00/30] Block patches

2012-10-04 Thread Anthony Liguori
Kevin Wolf writes: > The following changes since commit 6f8fd2530e9a530f237240daf1c981fa5df7f978: > > Merge branch 'arm-devs.for-upstream' of > git://git.linaro.org/people/pmaydell/qemu-arm (2012-09-27 21:48:56 +0200) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevi

Re: [Qemu-devel] [PULL] Xen tree 2012-10-03

2012-10-04 Thread Anthony Liguori
Stefano Stabellini writes: > Hi Anthony, > please pull from the following tree based on > e744c06fca438dc08271e626034e632a270c91c8: > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2012-10-03 Pulled. Thanks. Regards, Anthony Liguori > > > Anthony PERARD (6): > xen: Fix, no u

Re: [Qemu-devel] [PATCH v2] Make target_phys_addr_t 64 bits unconditionally

2012-10-04 Thread Anthony Liguori
Avi Kivity writes: > The hassle and compile time overhead of maintaining both 32-bit and 64-bit > capable source isn't worth the tiny performance advantage which is seen on > a minority of configurations. Switch to compiling libhw only once, with > target_phys_addr_t unconditionally typedefed to

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread David Gibson
On Fri, Oct 05, 2012 at 02:43:31AM +0200, Alexander Graf wrote: > > On 05.10.2012, at 02:34, David Gibson wrote: > > > On Thu, Oct 04, 2012 at 04:25:28PM +0530, Avik Sil wrote: > >> On 09/27/2012 03:21 PM, Gleb Natapov wrote: > >>> On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: >

Re: [Qemu-devel] [PATCH] kvm: Set default accelerator to "kvm" if the host supports it

2012-10-04 Thread Alexander Graf
On 03.10.2012, at 22:26, Peter Maydell wrote: > On 3 October 2012 21:01, Blue Swirl wrote: >> On Mon, Oct 1, 2012 at 4:20 PM, Anthony Liguori >> wrote: >>> Jan Kiszka writes: +/* The default accelerator depends on the availability of KVM. */ +p = kvm_configured ? "kv

[Qemu-devel] [PATCH 06/14] stellaris: Removed SSI mux

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Removed the explicit SSI mux and wired the CS line directly up to the SSI devices. Signed-off-by: Peter A. G. Crosthwaite --- hw/ssd0323.c |1 + hw/ssi-sd.c|1 + hw/stellaris.c | 98 ++-- 3 files

[Qemu-devel] [PATCH 02/14] ssi: Implemented CS behaviour

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added default CS behaviour for SSI slaves. SSI devices can set a property to enable CS behaviour which will create a GPIO on the device which is the CS. Tristating of the bus on SSI transfers is implemented. Signed-off-by: Peter A. G. Crosthwaite --- hw/ads7846.c

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Alexander Graf
On 05.10.2012, at 02:34, David Gibson wrote: > On Thu, Oct 04, 2012 at 04:25:28PM +0530, Avik Sil wrote: >> On 09/27/2012 03:21 PM, Gleb Natapov wrote: >>> On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: >

[Qemu-devel] [PATCH 09/14] xilinx_spi: Initial impl. of Xilinx SPI controller

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Device model for xilinx XPS SPI controller (v2.0) Signed-off-by: Peter A. G. Crosthwaite --- hw/microblaze/Makefile.objs |1 + hw/xilinx_spi.c | 390 +++ 2 files changed, 391 insertions(+), 0 deletions(-) c

[Qemu-devel] [PATCH 01/14] ssi: Support for multiple attached devices

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Removed assertion that only one device is attached to the SSI bus. When multiple devices are attached, all slaves have their transfer function called for transfers. Each device is responsible for knowing whether or not its CS is active, and if not returning 0. The r

[Qemu-devel] [PATCH 03/14] ssi: Added create_slave_no_init()

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Slave creation function that can be used to create an SSI slave without qdev_init() being called. This give machine models a chance to set properties. Signed-off-by: Peter A. G. Crosthwaite --- hw/ssi.c |9 +++-- hw/ssi.h |1 + 2 files changed, 8 inser

[Qemu-devel] [PATCH 07/14] hw: Added generic FIFO API.

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added a FIFO API that can be used to create and operate byte FIFOs. Signed-off-by: Peter A. G. Crosthwaite --- hw/Makefile.objs |1 + hw/fifo.c| 78 ++ hw/fifo.h| 47 ++

[Qemu-devel] [PATCH 08/14] m25p80: Initial implementation of SPI flash device

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added device model for m25p80 style SPI flash family. Signed-off-by: Peter A. G. Crosthwaite --- default-configs/arm-softmmu.mak |1 + default-configs/microblaze-softmmu.mak |2 + default-configs/microblazeel-softmmu.mak |2 + hw/Makefile.ob

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread David Gibson
On Thu, Oct 04, 2012 at 04:25:28PM +0530, Avik Sil wrote: > On 09/27/2012 03:21 PM, Gleb Natapov wrote: > >On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: > >> > >>On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: > >> > >>>On Thu, 2012-09-27 at 14:51 +0530, Avik Sil wrote: > >

[Qemu-devel] [PATCH 14/14] ssi: Add slave autoconnect helper

2012-10-04 Thread Peter Crosthwaite
Added helper function to automatically connect SPI slaves based on the QOM child nodes of a device. A SSI master device can call this routine to automatically hook-up all child nodes to its SPI bus. Signed-off-by: Peter Crosthwaite --- hw/ssi.c | 33 +

[Qemu-devel] [PATCH 10/14] petalogix-ml605: added SPI controller with n25q128

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added SPI controller to the reference design, with two n25q128 spi-flashes connected. Signed-off-by: Peter A. G. Crosthwaite --- hw/petalogix_ml605_mmu.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/hw/petalog

[Qemu-devel] [PATCH 12/14] xilinx_zynq: Added SPI controllers + flashes

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added the two SPI controllers to the zynq machine model. Attached two SPI flash devices to each controller. Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) di

[Qemu-devel] [PATCH 11/14] xilinx_spips: Xilinx Zynq SPI cntrlr device model

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added device model for the Xilinx Zynq SPI controller (SPIPS). Signed-off-by: Peter A. G. Crosthwaite --- hw/arm/Makefile.objs |1 + hw/xilinx_spips.c| 352 ++ 2 files changed, 353 insertions(+), 0 deletions

[Qemu-devel] [PATCH 13/14] MAINTAINERS: Added maintainerships for SSI

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Added maintainership for SSI, M25P80 and the Xilinx SPI controllers. Signed-off-by: Peter A. G. Crosthwaite --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 29aac4f..e25794b 100644 ---

[Qemu-devel] [PATCH 05/14] hw/stellaris: Removed gpio_out init array.

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite stellaris_init() defines arrays of qemu_irq to decides what each of the GPIO pins are connected to. This is ok for inputs (as an input can only have one source) but is flawed for outputs as an output can connect to any number of sinks. Removed the gpio_out array comp

[Qemu-devel] [PATCH 04/14] qdev: allow multiple qdev_init_gpio_in() calls

2012-10-04 Thread Peter Crosthwaite
From: Peter A. G. Crosthwaite Allow multiple qdev_init_gpio_in() calls for the one device. The first call will define GPIOs 0-N-1, the next GPIOs N- ... . Allows different GPIOs to be handled with different handlers. Needed when two levels of the QOM class heirachy both define GPIO functionality,

[Qemu-devel] [PULL 0/14] Ehnahced SSI bus support + M25P80 SPI flash + Xilinx SPI controller

2012-10-04 Thread Peter Crosthwaite
The following changes since commit e744c06fca438dc08271e626034e632a270c91c8: Peter Maydell (1): fpu/softfloat.c: Return correctly signed values from uint64_to_float32 are available in the git repository at: git://developer.petalogix.com/public/qemu.git for-upstream/spi-initial.8 Pete

[Qemu-devel] buildbot failure in qemu on default_i386_rhel61

2012-10-04 Thread qemu
The Buildbot has detected a new failure on builder default_i386_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/384 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61_32bit

[Qemu-devel] [Bug 1061778] [NEW] signal mask not reset on exec

2012-10-04 Thread John Sullivan
Public bug reported: Seen in qemu-1.0 under 12.04, but AFAICT from current git it hasn't changed. ./main-loop.c:qemu_signal_init blocks SIGALRM so it can be handled via signalfd. ./net/tap.c:launch_script does not reset the signal mask before the execv() call, and signal masks are inherited. So

[Qemu-devel] [PATCH 09/11] vfio-pci: Remove setting of MSI qsize

2012-10-04 Thread Alex Williamson
This was a misinterpretation of the spec, hardware doesn't get to specify how many were actually enabled through this field. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 0ca77cf..a55

[Qemu-devel] [PATCH 04/11] vfio-pci: Rework MSIX setup/teardown

2012-10-04 Thread Alex Williamson
We try to do lazy initialization of MSIX since we don't actually need to setup anything until MSIX vectors start getting used. This leads to problems if MSIX is enabled, but never used (we can end up trying to re-enable INTx while it's still enabled). We also run into problems trying to expand ou

[Qemu-devel] [PATCH 03/11] vfio-pci: Unmap and retry DMA mapping

2012-10-04 Thread Alex Williamson
Occasionally we get regions added that overlap with existing mappings. These always seems to be in the VGA ROM range. VFIO returns EBUSY for these mapping attempts. We can try a little harder and assume that the latest mapping is correct by removing any overlapping ranges and retrying the origina

[Qemu-devel] [PATCH 02/11] vfio-pci: Re-order map/unmap

2012-10-04 Thread Alex Williamson
This cleans up the next patch that calls unmap from map. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 7ec9c30..2d89d17 100644 --- a/hw/vfio_pci.c

[Qemu-devel] [PATCH 10/11] vfio-pci: Extend reset

2012-10-04 Thread Alex Williamson
Take what we've learned from pci-assign and apply it to vfio-pci. On reset, disable previous interrupt config, perform a device reset if available, re-enable INTx, and disable memory regions on the device to prevent continuing DMA. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 29 +++

[Qemu-devel] [PATCH 08/11] vfio-pci: Use uintptr_t for void* cast

2012-10-04 Thread Alex Williamson
We don't seem to run into any sign extension problems, but unsigned looks more correct. Signed-off-by: Alex williamson --- hw/vfio_pci.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index d62ddd1..0ca77cf 100644 --- a/hw/vfio_pci.c +++ b/h

[Qemu-devel] [PATCH 05/11] vfio-pci: No spurious MSIs

2012-10-04 Thread Alex Williamson
FreeBSD doesn't like these spurious MSIs, remove them as they're mostly paranoia anyway. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 89e00ba..bca4083 100644 --- a/hw/vfio_pci.c +++ b/h

[Qemu-devel] [PATCH 11/11] vfio-pci: Cleanup on INTx setup failure

2012-10-04 Thread Alex Williamson
Missing some unwind code. Signed-off-by: Alex Williamson --- hw/vfio_pci.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index b2383c4..2325272 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_pci.c @@ -285,6 +285,8 @@ static int vfio_enable_intx(VFIODevice *vde

[Qemu-devel] [PATCH 07/11] vfio-pci: Don't peak at msi_supported

2012-10-04 Thread Alex Williamson
Let the init function fail, just don't warn for -ENOTSUP. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/hw/vfio_pci.c b/hw/vfio_pci.c index 4d01707..d62ddd1 100644 --- a/hw/vfio_pci.c +++ b/hw/vfio_

[Qemu-devel] [PATCH 06/11] vfio-pci: Roll the header into the .c file

2012-10-04 Thread Alex Williamson
It's only ~100 lines and nobody else should be using this. Suggested by Michael Tsirkin. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 97 + hw/vfio_pci_int.h | 114 - 2 files changed, 96

[Qemu-devel] [PATCH 01/11] vfio-pci: Update slow path INTx algorithm

2012-10-04 Thread Alex Williamson
We can't afford the overhead of switching out and back into mmap mode around each interrupt, but we can do it lazily via a timer. On INTx interrupt, disable the mmap'd memory regions and set a timer. On every interrupt, push the timer out. If the timer expires and the interrupt is no longer pend

[Qemu-devel] [PATCH 00/11] vfio-pci cleanup and fixes

2012-10-04 Thread Alex Williamson
I've been accumulating a backlog of vfio-pci changes while we've been getting the first implementation accepted. This series includes a new algorithm for dealing with INTx that should avoid users needing to know about experimental parameters, a re-try mechanism for mappings that avoids common erro

Re: [Qemu-devel] [PATCH] tcg: Remove redundant pointer from TCGContext

2012-10-04 Thread Richard Henderson
On 10/04/2012 11:29 AM, Stefan Weil wrote: > The pointer entry 'temps' always refers to the array entry 'static_temps'. > Removing the pointer and renaming 'static_temps' to 'temps' reduces the > size of TCGContext (4 or 8 byte) and allows better code generation. > > Signed-off-by: Stefan Weil R

[Qemu-devel] [PATCH 01/15] i386: kvm: kvm_arch_get_supported_cpuid: move R_EDX hack outside of for loop

2012-10-04 Thread Eduardo Habkost
The for loop will become a separate function, so clean it up so it can become independent from the bit hacking for R_EDX. No behavior change[1], just code movement. [1] Well, only if the kernel returned CPUID leafs 1 or 0x8001 as unsupported, but there's no kernel version that does that.

[Qemu-devel] [PATCH] versatilepb: Use symbolic indices for ARM PIC

2012-10-04 Thread Stefan Weil
It is more readable, and all other code does it like that, too. Signed-off-by: Stefan Weil --- hw/versatilepb.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/versatilepb.c b/hw/versatilepb.c index 7a92034..b3f8077 100644 --- a/hw/versatilepb.c +++ b/hw/versatilepb.c

[Qemu-devel] [PATCH 14/15] i386: kvm: reformat filter_features_for_kvm() code

2012-10-04 Thread Eduardo Habkost
Cosmetic, but it will also help to make futher patches easier to review. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index a5c1628..7921b1b 100644 ---

[Qemu-devel] [PATCH] exec: Don't request an address for code_gen_buffer if -fpie

2012-10-04 Thread Richard Henderson
The hard-coded addresses inside code_gen_alloc only make sense if we're building an executable that will actually run at the address we've put into the linker scripts. When we're building with -fpie, the executable will run at some random location chosen by the kernel. We get better placement for

[Qemu-devel] [PATCH 07/15] i386: kvm: kvm_arch_get_supported_cpuid: replace if+switch with single 'if'

2012-10-04 Thread Eduardo Habkost
Additional fixups will be added, and making them a single 'if/else if' chain makes it clearer than two nested switch statements. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/target-i386/kvm.c b/t

Re: [Qemu-devel] [PATCH 00/16 v4] Add an IPMI device to qemu

2012-10-04 Thread Corey Minyard
On 09/18/2012 03:00 PM, miny...@acm.org wrote: I haven't pushed on the SEABIOS changes for IPMI, and the changes for qemu for BIOS support are quite small, anyway. So I've separated out those changes; here's the driver without BIOS table support. -corey I haven't seen any comments on this. I

[Qemu-devel] [ 30/33] x86/alternatives: Fix p6 nops on non-modular kernels

2012-10-04 Thread Greg Kroah-Hartman
3.0-stable review patch. If anyone has any objections, please let me know. -- From: Avi Kivity commit cb09cad44f07044d9810f18f6f9a6a6f3771f979 upstream. Probably a leftover from the early days of self-patching, p6nops are marked __initconst_or_module, which causes them to be d

[Qemu-devel] [PATCH 00/15] QEMU KVM_GET_SUPPORTED_CPUID cleanups and fixes

2012-10-04 Thread Eduardo Habkost
Most of this series are just cleanups that will help when making -cpu check/enforce work properly, with some fixes. In addition to code movements, the main changes are: - x2apic won't be enabled if in-kernel irqchip is disabled (patch 10) - CPUID feature bit filtering is done much earlier, an

[Qemu-devel] [ 50/52] x86/alternatives: Fix p6 nops on non-modular kernels

2012-10-04 Thread Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know. -- From: Avi Kivity commit cb09cad44f07044d9810f18f6f9a6a6f3771f979 upstream. Probably a leftover from the early days of self-patching, p6nops are marked __initconst_or_module, which causes them to be d

[Qemu-devel] [PATCH 13/15] i386: kvm: filter CPUID feature words earlier, on cpu.c

2012-10-04 Thread Eduardo Habkost
cpu.c contains the code that will check if all requested CPU features are available, so the filtering of KVM features must be there, so we can implement "check" and "enforce" properly. The only point where kvm_arch_init_vcpu() is called on i386 is: - cpu_x86_init() - x86_cpu_realize() (after cp

[Qemu-devel] [ 56/58] x86/alternatives: Fix p6 nops on non-modular kernels

2012-10-04 Thread Greg Kroah-Hartman
3.5-stable review patch. If anyone has any objections, please let me know. -- From: Avi Kivity commit cb09cad44f07044d9810f18f6f9a6a6f3771f979 upstream. Probably a leftover from the early days of self-patching, p6nops are marked __initconst_or_module, which causes them to be d

[Qemu-devel] [PATCH 11/15] i386: kvm: mask cpuid_kvm_features earlier

2012-10-04 Thread Eduardo Habkost
Instead of masking the KVM feature bits very late (while building the KVM_SET_CPUID2 data), mask it out on env->cpuid_kvm_features, at the same point where the other feature words are masked out. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 6 -- 1 file changed, 4 insertions(+), 2

[Qemu-devel] [PATCH 03/15] i386: kvm: kvm_arch_get_supported_cpuid: use 'entry' variable

2012-10-04 Thread Eduardo Habkost
The reg switch will be moved to a separate function, so store the entry pointer in a variable. No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target-i386/kvm.c b/target-i38

[Qemu-devel] [PATCH 09/15] i386: kvm: set CPUID_EXT_TSC_DEADLINE_TIMER on kvm_arch_get_supported_cpuid()

2012-10-04 Thread Eduardo Habkost
This moves the CPUID_EXT_TSC_DEADLINE_TIMER CPUID flag hacking from kvm_arch_init_vcpu() to kvm_arch_get_supported_cpuid(). Full git grep for kvm_arch_get_supported_cpuid: kvm.h:uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, target-i386/cpu.c:x86_cpu_def->cp

[Qemu-devel] [PATCH 06/15] i386: kvm: extract try_get_cpuid() loop to get_supported_cpuid() function

2012-10-04 Thread Eduardo Habkost
No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 3519028..7115921 100644 --- a/target-i386/kvm.c +++ b/target-i386/kvm.

[Qemu-devel] [PATCHv3 19/20] hw/r2d: add comment: this strncpy use is ok

2012-10-04 Thread Jim Meyering
From: Jim Meyering Signed-off-by: Jim Meyering --- hw/r2d.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/r2d.c b/hw/r2d.c index 0f16e81..1bc191f 100644 --- a/hw/r2d.c +++ b/hw/r2d.c @@ -332,6 +332,8 @@ static void r2d_init(ram_addr_t ram_size, } if (kernel_cmdline) { +

[Qemu-devel] [PATCH 05/15] i386: kvm: extract CPUID entry lookup to cpuid_find_entry() function

2012-10-04 Thread Eduardo Habkost
No behavior change, just code movement. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 30 ++ 1 file changed, 22 insertions(+), 8 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index ae51573..3519028 100644 --- a/target-i386/kvm.c +++ b/targe

[Qemu-devel] [RFC 09/13] qdev: move reset register/unregister code to qdev-system.c

2012-10-04 Thread Eduardo Habkost
Also, add weak symbols that will be used if qdev-system.o is not compiled in (i.e. on *-user). Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 16 +++- hw/qdev-core.h | 3 +++ hw/qdev-system.c | 15 +++ 3 files changed, 25 insertions(+), 9 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH] versatilepb: Use symbolic indices for ARM PIC

2012-10-04 Thread Peter Maydell
On 4 October 2012 21:49, Stefan Weil wrote: > It is more readable, and all other code does it like that, too. > > Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell The right long term fix is named pins. -- PMM

[Qemu-devel] [PATCH v3 06/22] qapi: qapi_visit.py, support generating static functions

2012-10-04 Thread Michael Roth
qidl embeds visitor code into object files rather than linking against seperate files, so allow for static declarations when we're using qapi_visit.py as a library as we do with qidl.py Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth --- scripts/qapi_visit.py | 51 +++

[Qemu-devel] [PATCH 15/15] i386: kvm: filter CPUID leaf 7 based on GET_SUPPORTED_CPUID, too

2012-10-04 Thread Eduardo Habkost
Now that CPUID leaf 7 features can be enabled/disabled on the command-line, we need to filter them properly using GET_SUPPORTED_CPUID, at the same place where other features are filtered out. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Qemu-devel] [PATCH 02/15] i386: kvm: kvm_arch_get_supported_cpuid: clean up has_kvm_features check

2012-10-04 Thread Eduardo Habkost
Instead of a function-specific has_kvm_features variable, simply use a "found" variable that will be checked in case we have to use the legacy get_para_features() interface. No behavior change, just code cleanup. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 8 +++- 1 file changed,

[Qemu-devel] [PATCH 08/15] i386: kvm: set CPUID_EXT_HYPERVISOR on kvm_arch_get_supported_cpuid()

2012-10-04 Thread Eduardo Habkost
Full grep for kvm_arch_get_supported_cpuid: kvm.h:uint32_t kvm_arch_get_supported_cpuid(KVMState *env, uint32_t function, target-i386/cpu.c:x86_cpu_def->cpuid_7_0_ebx_features = kvm_arch_get_supported_cpuid(kvm_state, 0x7, 0, R_EBX); target-i386/cpu.c:*eax = kvm_arch_

[Qemu-devel] [PATCH 04/15] i386: kvm: extract register switch to cpuid_entry_get_reg() function

2012-10-04 Thread Eduardo Habkost
No behavior change: just code movement. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 22e8564..ae51573 100644 --- a/target-i386/kvm.c +++

[Qemu-devel] [PATCH 12/15] i386: kvm: mask cpuid_ext4_features bits earlier

2012-10-04 Thread Eduardo Habkost
This way all the filtering by GET_SUPPORTED_CPUID is being done at the same place in the code. Signed-off-by: Eduardo Habkost --- target-i386/kvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 3f4bee5..335b3e7 100644 --- a/t

[Qemu-devel] [PATCH 10/15] i386: kvm: x2apic is not supported without in-kernel irqchip

2012-10-04 Thread Eduardo Habkost
This is necessary so that x2apic is not improperly enabled when the in-kernel irqchip is disabled. This won't generate a warning with "-cpu ...,check" because the current check/enforce code is broken (it checks the host CPU data directly, instead of using kvm_arch_get_supported_cpuid()), but it wi

[Qemu-devel] [PATCH v3 13/22] qom-fuse: force single-threaded mode to avoid QMP races

2012-10-04 Thread Michael Roth
python-fuse defaults to multi-threaded handling of filesystem calls. In the case of QOM this can lead to threads reading QMP responses to requests executed by other threads, causing all sorts of strangeness when interacting with QOM mounts. For instance: mdroth@loki:~/w/qom$ ls -l machine | grep

[Qemu-devel] [PATCHv3 04/20] sheepdog: avoid a few buffer overruns

2012-10-04 Thread Jim Meyering
From: Jim Meyering * parse_vdiname: Use pstrcpy, not strncpy, when the destination buffer must be NUL-terminated. * sd_open: Likewise, avoid buffer overrun. * do_sd_create: Likewise. Leave the preceding memset, since pstrcpy does not NUL-fill, and filename needs that. * sd_snapshot_create: Add a

[Qemu-devel] [RFC v2 00/13] include qdev core in *-user, make CPU child of DeviceState

2012-10-04 Thread Eduardo Habkost
Previous version: http://article.gmane.org/gmane.comp.emulators.qemu/166630 This version removes the CONFIG_USER_ONLY ifdefs, and use weak symbols to move the vmstate and qemu_register_reset() handling to qdev-system.c. Anthony Liguori (1): qdev: split up header so it can be used in cpu.h E

[Qemu-devel] [PATCHv3 08/20] os-posix: avoid buffer overrun

2012-10-04 Thread Jim Meyering
From: Jim Meyering os_set_proc_name: Use pstrcpy, in place of strncpy and the ineffectual preceding assignment: name[sizeof(name) - 1] = 0; Signed-off-by: Jim Meyering --- os-posix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/os-posix.c b/os-posix.c index eabccb8..f8

[Qemu-devel] [PATCH v3 07/22] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs

2012-10-04 Thread Michael Roth
Reviewed-by: Anthony Liguori Signed-off-by: Michael Roth --- scripts/qapi_visit.py |9 + 1 file changed, 9 insertions(+) diff --git a/scripts/qapi_visit.py b/scripts/qapi_visit.py index af23770..ebff0f0 100644 --- a/scripts/qapi_visit.py +++ b/scripts/qapi_visit.py @@ -107,6 +107,15

[Qemu-devel] [RFC 02/13] qdev: split up header so it can be used in cpu.h

2012-10-04 Thread Eduardo Habkost
From: Anthony Liguori Header file dependency is a frickin' nightmare right now. cpu.h tends to get included in our 'include everything' header files but qdev also needs to include those headers mainly for qdev-properties since it knows about CharDriverState and friends. We can solve this for no

[Qemu-devel] [RFC 07/13] qdev: move vmstate handling to qdev-system.c

2012-10-04 Thread Eduardo Habkost
Add GCC_WEAK symbols to qdev-core.c, so that qdev-core.o can be used without qdev-system.o (i.e. by *-user). Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 23 +++ hw/qdev-core.h | 2 ++ hw/qdev-system.c | 22 ++ 3 files changed, 31 insertions(+)

[Qemu-devel] [RFC 06/13] qdev-core: isolate vmstate handling into separate functions

2012-10-04 Thread Eduardo Habkost
Those functions will eventually be moved somewhere else, and won't get included on *-user. Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/qdev-core.c b/hw/qdev-core.c index c3c4d77..242347f 1006

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Avik Sil
On 09/27/2012 03:21 PM, Gleb Natapov wrote: On Thu, Sep 27, 2012 at 11:33:31AM +0200, Alexander Graf wrote: On 27.09.2012, at 11:29, Benjamin Herrenschmidt wrote: On Thu, 2012-09-27 at 14:51 +0530, Avik Sil wrote: Hi, We would like to get a method to boot from devices provided in -boot argu

Re: [Qemu-devel] [PATCH 13/18] vnc: add error propagation to vnc_display_open

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:37:00 +0200 Paolo Bonzini wrote: > Before: > > $ qemu-system-x86_64 -vnc foo.bar:12345 > getaddrinfo(foo.bar,18245): Name or service not known > Failed to start VNC server on `foo.bar:12345' > > $ qemu-system-x86_64 -vnc localhost:12345,reverse=on > in

Re: [Qemu-devel] [RFC 10/13] move qemu_irq typedef out of cpu-common.h

2012-10-04 Thread Peter Maydell
On 4 October 2012 20:15, Eduardo Habkost wrote: > --- a/sysemu.h > +++ b/sysemu.h > @@ -9,6 +9,7 @@ > #include "qapi-types.h" > #include "notify.h" > #include "main-loop.h" > +#include "hw/irq.h" > > /* vl.c */ Igor's qemu_system_powerdown cleanup has hit master now, so sysemu.h doesn't need

[Qemu-devel] [RFC 11/13] qdev: use full qdev.h include path on qdev*.c

2012-10-04 Thread Eduardo Habkost
This way, the files can be moved to the qom/ directory as-is. Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 2 +- hw/qdev-properties.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-core.c b/hw/qdev-core.c index 46ab239..472fe8f 100644 --- a/hw/qdev-co

[Qemu-devel] [PATCH v3 11/22] qapi: qapi.py, make json parser more robust

2012-10-04 Thread Michael Roth
Currently the QAPI JSON parser expects a very particular style of code indentation, the major one being that terminating curly/square brackets are not on placed on a seperate line. This is incompatible with most pretty-print formats, so make it a little more robust by supporting these cases. Signe

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2012-10-04 Thread Rolando Zappacosta
Hi Stefan, also experiencing this issue after installing PointSec: 1) installed win7 64bits (by manually decompressing the .WIM installation files and making the disk image file bootable) 2) installed PointSec FDE (Full Disk Encryption => http://www.checkpoint.com/products/full-disk-encryption/i

Re: [Qemu-devel] [PATCH 10/18] qemu-char: ask and print error information from qemu-sockets

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:57 +0200 Paolo Bonzini wrote: > Before: > > $ qemu-system-x86_64 -monitor tcp:localhost:6000 > (starts despite error) > > $ qemu-system-x86_64 -monitor tcp:foo.bar:12345 > getaddrinfo(foo.bar,12345): Name or service not known > chardev: opening back

Re: [Qemu-devel] [PATCH 12/18] qemu-ga: ask and print error information from qemu-sockets

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:59 +0200 Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini Reviewed-by: Luiz Capitulino > --- > qga/channel-posix.c | 8 +--- > 1 file modificato, 5 inserzioni(+), 3 rimozioni(-) > > diff --git a/qga/channel-posix.c b/qga/channel-posix.c > index e22eee6..d152

[Qemu-devel] [RFC 03/13] qapi-types.h doesn't really need to include qemu-common.h

2012-10-04 Thread Eduardo Habkost
From: Igor Mammedov needed to prevent build breakage when CPU becomes a child of DeviceState [ehabkost: include too] Signed-off-by: Igor Mammedov Signed-off-by: Eduardo Habkost --- scripts/qapi-types.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/qapi-types

Re: [Qemu-devel] [Qemu-ppc] Qemu boot device precedence over nvram boot-device setting

2012-10-04 Thread Avik Sil
I looked at the bootindex stuff and found that when the bootindex is specified for the disk and cdrom it generates a string like: "/spapr-vio-bridge/spapr-vscsi/channel@0/disk@0,1 /spapr-vio-bridge/spapr-vscsi/channel@0/disk@0,0" Now converting/translating this to OF device path is going to be m

[Qemu-devel] [RFC 05/13] qdev: rename qdev.c to qdev-core.c

2012-10-04 Thread Eduardo Habkost
Just to make clear that it's the qdev core code, corresponding to qdev-core.h. Signed-off-by: Eduardo Habkost --- hw/Makefile.objs | 2 +- hw/{qdev.c => qdev-core.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename hw/{qdev.c => qdev-core.c} (100%) diff --git a/hw/Makefile.

Re: [Qemu-devel] [PATCH 08/18] migration (outgoing): add error propagation for fd and exec protocols

2012-10-04 Thread Luiz Capitulino
On Wed, 3 Oct 2012 16:36:55 +0200 Paolo Bonzini wrote: > Error propagation is already there for socket backends, but it > is (and remains) incomplete because no Error is passed to the > NonBlockingConnectHandler. > > With all protocols understanding Error, the code can be simplified > by removi

[Qemu-devel] [PATCHv3 20/20] doc: update HACKING wrt strncpy/pstrcpy

2012-10-04 Thread Jim Meyering
From: Jim Meyering Reword the section on strncpy: its NUL-filling is important in some cases. Mention that pstrcpy's signature is different. Signed-off-by: Jim Meyering --- HACKING | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/HACKING b/HACKING index 471cf1d..dd

  1   2   3   4   >