Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-16 Thread Kuniyasu Suzaki
Hello, From: Paolo Bonzini pbonz...@redhat.com Subject: Re: delvm does not reduce the qcow2 file size Date: Mon, 15 Oct 2012 15:25:16 +0200 Il 15/10/2012 11:33, Kuniyasu Suzaki ha scritto: Hello, delvm is a command to delete a snapshot image in a qcow2 file. However it does not reduce

Re: [Qemu-devel] [PATCH] vnc: fix info vnc with -vnc ..., reverse=on

2012-10-16 Thread Michael Tokarev
On 10.10.2012 16:30, Paolo Bonzini wrote: [] --- a/ui/vnc.c +++ b/ui/vnc.c @@ -372,6 +372,10 @@ VncInfo *qmp_query_vnc(Error **errp) } } +if (vnc_display-lsock == -1) { FWIW, can't we use 0 condition in all cases like this - for testing whenever a

Re: [Qemu-devel] [PATCH v2 26/45] mirror: introduce mirror job

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 18:57, Kevin Wolf ha scritto: Am 26.09.2012 17:56, schrieb Paolo Bonzini: This patch adds the implementation of a new job that mirrors a disk to a new image while letting the guest continue using the old image. The target is treated as a black box and data is copied from the

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Michael S. Tsirkin
On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote: This makes use of the new level irqfd support enabling bypass of qemu userspace both on INTx injection and unmask. This significantly boosts the performance of devices making use of legacy interrupts. Signed-off-by: Alex

Re: [Qemu-devel] [PATCH v2 27/45] qmp: add drive-mirror command

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 19:33, Kevin Wolf ha scritto: + +flags = bs-open_flags | BDRV_O_RDWR; The two questions from last time are still open: Jeff's patches are in now, so we can do a bdrv_reopen() to remove BDRV_O_RDWR again when completing the mirror job. It's not a big change, so I'll add

[Qemu-devel] [Patch]KVM: enabling per domain PLE

2012-10-16 Thread Hu, Xuekun
Setting the same PLE parameter arbitrarily for different workloads is not a good solution. The solution enables per domain PLE which gives user ability to set PLE parameter for different domain for better performance. Signed-off-by: Xuekun Hu xuekun...@intel.com ---

[Qemu-devel] [Patch]QEMU: Add -ple-gap and -ple-window options for per domain PLE

2012-10-16 Thread Hu, Xuekun
QEMU: Add -ple-gap and -ple-window options for per domain PLE Signed-off-by: Xuekun Hu xuekun...@intel.com --- linux-headers/linux/kvm.h |3 +++ qemu-options.hx | 16 sysemu.h |2 ++ target-i386/kvm.c | 13 + vl.c

[Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top of master. Can anyone take a look? --- This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To

Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 08:23, Kuniyasu Suzaki ha scritto: delvm is a command to delete a snapshot image in a qcow2 file. However it does not reduce the qcow2 file size. Note that the file will not grow when new allocations are performed in the future. You mean that the qcow2 file size will not

Re: [Qemu-devel] [PATCH v4 24/26] qidl: add QAPI-based code generator

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 18:35, Michael Roth ha scritto: - immutable/derived/broken/elsewhere (and the default, let's call it serialized) are really five cases of the same QIDL property. Perhaps this could be enforced in the extended syntax like this: #define q_immutable QIDL(serialize(immutable))

Re: [Qemu-devel] [PATCH v4 26/26] qidl: unit tests and build infrastructure

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 18:37, Michael Roth ha scritto: There is another way to do this (still using a dummy target) that is a bit less cryptic: QIDL-PP-%: %.c qidl.h ... grep and create %.qidl.c %.o: QIDL-PP-% build normal or qidl CC But make detects that QIDL-PP-% is an intermediate

[Qemu-devel] [PATCH v6 0/3] tcg: enhance code generation quality for qemu_ld/st IRs

2012-10-16 Thread Yeongkyoon Lee
Hi, all. Here is the 6th version of the series optimizing TCG qemu_ld/st code generation. v6: - Remove an extra argument of return addr from MMU helpers Instead, embed the fast path addr to the slow path for helpers to use it - Change some bitwise operations to bitfields of structure -

[Qemu-devel] [PATCH v6 1/3] configure: Add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-10-16 Thread Yeongkyoon Lee
Enable CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization only when a host is i386 or x86_64. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- configure |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization

2012-10-16 Thread Yeongkyoon Lee
Add GETPC_EXT which is used by MMU helpers to selectively calculate the code address of accessing guest memory when called from a qemu_ld/st optimized code or a C function. Currently, it supports only i386 and x86-64 hosts. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- exec-all.h

[Qemu-devel] [PATCH v6 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-10-16 Thread Yeongkyoon Lee
Add optimized TCG qemu_ld/st generation which locates the code of TLB miss cases at the end of a block after generating the other IRs. Currently, this optimization supports only i386 and x86_64 hosts. Signed-off-by: Yeongkyoon Lee yeongkyoon@samsung.com --- tcg/i386/tcg-target.c | 415

Re: [Qemu-devel] [PATCH v4 22/26] qidl: add lexer library (based on QC parser)

2012-10-16 Thread Paolo Bonzini
Il 12/10/2012 23:11, Michael Roth ha scritto: Adds an abstract Lexer class to handle tokenizer via a peek/pop/peekline/popline interface, along with an implementation for C based on the lexer from qc.git Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Michael Roth

[Qemu-devel] [PATCH v4 0/5] Better allocation of code_gen_buffer

2012-10-16 Thread Richard Henderson
Changes v3-v4: * Patch 5 actually included, * Patch 1 updates printf format for changed size_t. r~ Richard Henderson (5): exec: Split up and tidy code_gen_buffer exec: Don't make DEFAULT_CODE_GEN_BUFFER_SIZE too large exec: Do not use absolute address hints for code_gen_buffer with

[Qemu-devel] [PATCH 3/5] exec: Do not use absolute address hints for code_gen_buffer with -fpie

2012-10-16 Thread Richard Henderson
The hard-coded addresses inside alloc_code_gen_buffer only make sense if we're building an executable that will actually run at the address we've put into the linker scripts. When we're building with -fpie, the executable will run at some random location chosen by the kernel. We get better

[Qemu-devel] [PATCH 5/5] exec: Make MIN_CODE_GEN_BUFFER_SIZE private to exec.c

2012-10-16 Thread Richard Henderson
It is used nowhere else, and the corresponding MAX_CODE_GEN_BUFFER_SIZE also lives there. Signed-off-by: Richard Henderson r...@twiddle.net --- exec-all.h | 2 -- exec.c | 4 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/exec-all.h b/exec-all.h index 6516da0..7f29820

[Qemu-devel] [PATCH 1/5] exec: Split up and tidy code_gen_buffer

2012-10-16 Thread Richard Henderson
It now consists of: A macro definition of MAX_CODE_GEN_BUFFER_SIZE with host-specific values, A function size_code_gen_buffer that applies most of the reasoning for choosing a buffer size, Three variations of a function alloc_code_gen_buffer that contain all of the logic for allocating

[Qemu-devel] [PATCH 2/5] exec: Don't make DEFAULT_CODE_GEN_BUFFER_SIZE too large

2012-10-16 Thread Richard Henderson
For ARM we cap the buffer size to 16MB. Do not allocate 32MB in that case. Signed-off-by: Richard Henderson r...@twiddle.net --- exec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/exec.c b/exec.c index eecae2f..6c0b2d7 100644 --- a/exec.c +++ b/exec.c @@ -529,7

[Qemu-devel] [Bug 1067119] [NEW] e1000 missing statistics

2012-10-16 Thread Stephen Hemminger
Public bug reported: The E1000 emulation is missing several counters that are used by other software. The following would be useful: Good bytes receive counter GORCH/GORCL Good bytes transmit counter GOTCH/GOTCL Broadcast packets sent/received Multicast packets sent/received. ** Affects:

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 09:46:06PM -, Edivaldo de Araujo Pereira wrote: Hi Stefan, Thank you, very much for taking the time to help me, and excuse me for not seeing your answer early... I've run the procedure you pointed me out, and the result is:

[Qemu-devel] [PATCH 4/5] exec: Allocate code_gen_prologue from code_gen_buffer

2012-10-16 Thread Richard Henderson
We had a hack for arm and sparc, allocating code_gen_prologue to a special section. Which, honestly does no good under certain cases. We've already got limits on code_gen_buffer_size to ensure that all TBs can use direct branches between themselves; reuse this limit to ensure the prologue is also

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-16 Thread Alexander Graf
On 16.10.2012, at 05:44, Avik Sil avik...@linux.vnet.ibm.com wrote: On 10/12/2012 05:33 AM, Alexander Graf wrote: On 12.10.2012, at 00:59, David Gibson wrote: On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: This patch adds nvram specified boot device into qemu default

Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 22:58, schrieb Jeff Cody: In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation from __negotiate_capabilities(), which breaks _accept(). This causes failures in qemu-io python based tests (i.e. tests 030 and 040). This patch creates the sockfile in __accept()

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 10:25:58AM +0100, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it with a new tap

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Markus Armbruster
Laine Stump la...@redhat.com writes: On 10/15/2012 05:25 AM, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host side, then reconnect it

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 11:15:30AM -0400, Laine Stump wrote: On 10/15/2012 05:25 AM, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to disconnect only the host

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add 041 backing file chain infinite loop test

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 11:47:04AM -0600, Eric Blake wrote: On 10/15/2012 06:44 AM, Stefan Hajnoczi wrote: This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 04:58:02PM -0400, Jeff Cody wrote: In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation from __negotiate_capabilities(), which breaks _accept(). This causes failures in qemu-io python based tests (i.e. tests 030 and 040). This patch creates the

Re: [Qemu-devel] [PATCH v2 26/45] mirror: introduce mirror job

2012-10-16 Thread Kevin Wolf
Am 16.10.2012 08:36, schrieb Paolo Bonzini: Il 15/10/2012 18:57, Kevin Wolf ha scritto: Am 26.09.2012 17:56, schrieb Paolo Bonzini: + +/* We're out of the streaming phase. From now on, if the job + * is cancelled we will actually complete all pending I/O and +

Re: [Qemu-devel] [PATCH 2/2] Fix a race condition in E1000 device live migration. One of data-transfer related flags not in migrated fields list.

2012-10-16 Thread Stefan Hajnoczi
On Mon, Oct 15, 2012 at 06:48:53PM +0200, Dmitry Fleytman wrote: The commit message is very long but the commit description is empty. Please keep the message short and add the rest into the description. Signed-off-by: Dmitry Fleytman dmi...@daynix.com --- hw/e1000.c | 3 ++- 1 file changed,

Re: [Qemu-devel] [PATCH v2 26/45] mirror: introduce mirror job

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 10:24, Kevin Wolf ha scritto: The idea was that block-job-cancel will still leave the target in a consistent state if executed during the second phase. Otherwise it is impossible to take a consistent snapshot and keep running on the first image. Yes, I noticed that when

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-16 Thread Andreas Färber
Am 16.10.2012 10:04, schrieb Alexander Graf: On 16.10.2012, at 05:44, Avik Sil avik...@linux.vnet.ibm.com wrote: On 10/12/2012 05:33 AM, Alexander Graf wrote: On 12.10.2012, at 00:59, David Gibson wrote: On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil wrote: This patch adds nvram

[Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA

2012-10-16 Thread Mel Gorman
Thierry reported that the iron out patch for isolate_freepages_block() had problems due to the strict check being too strict with mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1. It's possible that more pages than necessary are isolated but the check still

Re: [Qemu-devel] KVM call agenda for 2012-10-16

2012-10-16 Thread Alexander Graf
-boot and -bootindex On 15.10.2012, at 12:17, Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda topics you are interested in. Later, Juan. -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-16 Thread Lei Li
On 10/15/2012 04:06 PM, Gerd Hoffmann wrote: This patch adds chardev_add and chardev_del monitor commands. They work simliar to the netdev_{add,del} commands. The hmp version of chardev_add accepts like the -chardev command line option does. The qmp version expects the arguments being passed

[Qemu-devel] [PATCH] target-arm/translate: Fix RRX operands

2012-10-16 Thread Peter Crosthwaite
Instructions that both use the RRX second operand and update CS were incorrect, as the Carry flag was updated too early. An example of such an instruction would be: ands r12,r13,RRX Ands, because of the s flag will update the carry flag. But the RRX second operand rotates through the C flag

Re: [Qemu-devel] [Patch]KVM: enabling per domain PLE

2012-10-16 Thread Avi Kivity
On 10/16/2012 08:53 AM, Hu, Xuekun wrote: Setting the same PLE parameter arbitrarily for different workloads is not a good solution. True. The solution enables per domain PLE which gives user ability to set PLE parameter for different domain for better performance. The problem with this

Re: [Qemu-devel] [libvirt] Problems using netdev_del+netdev_add w/o corresponding device_del+device_add

2012-10-16 Thread Daniel P. Berrange
On Tue, Oct 16, 2012 at 10:08:21AM +0200, Stefan Hajnoczi wrote: On Mon, Oct 15, 2012 at 10:25:58AM +0100, Daniel P. Berrange wrote: On Mon, Oct 15, 2012 at 10:30:07AM +0200, Stefan Hajnoczi wrote: On Sat, Oct 13, 2012 at 04:47:14PM -0400, Laine Stump wrote: Here is the sequence sent to

Re: [Qemu-devel] [RFC v1 0/7] IOMMU support

2012-10-16 Thread Avi Kivity
On 10/15/2012 09:52 PM, Benjamin Herrenschmidt wrote: I do have an is_write parameter to translate, in fact I added it in order to implement the spapr iommu. Or do you mean something else? Hrm, sort of. is_write means you can only express RO vs RW. Two parameter for read and write allow

[Qemu-devel] [PATCH 01/20] target-sparc: Add gen_load/store/dest_gpr

2012-10-16 Thread Richard Henderson
Infrastructure to be used to clean up handling of temporaries. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 52 1 file changed, 52 insertions(+) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

Re: [Qemu-devel] [PATCH 2/2] Fix a race condition in E1000 device live migration. One of data-transfer related flags not in migrated fields list.

2012-10-16 Thread Kevin Wolf
Am 16.10.2012 10:32, schrieb Stefan Hajnoczi: On Mon, Oct 15, 2012 at 06:48:53PM +0200, Dmitry Fleytman wrote: The commit message is very long but the commit description is empty. Please keep the message short and add the rest into the description. Signed-off-by: Dmitry Fleytman

[Qemu-devel] [PATCH 10/20] target-sparc: Use get_temp_i32 in gen_dest_fpr_F

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 5296a37..5013aee 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 11/20] target-sparc: Avoid cpu_tmp32 in Read Priv Register

2012-10-16 Thread Richard Henderson
We don't need another temporary here. Load directly into the register we want to set. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 53 +++- 1 file changed, 21 insertions(+), 32 deletions(-) diff --git

Re: [Qemu-devel] KVM call agenda for 2012-10-16

2012-10-16 Thread Igor Mammedov
On Mon, 15 Oct 2012 18:27:51 +0200 Igor Mammedov imamm...@redhat.com wrote: CPU as DEVICE http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg00719.html latest known tree for testing: https://github.com/ehabkost/qemu-hacks/commits/work/cpu-devicestate-qdev-core may

[Qemu-devel] [PATCH v2 00/20] target-sparc: Cleanup handling of temps

2012-10-16 Thread Richard Henderson
The primary goal of this patch set is to have all references to windowed registers to go through new routines that have access to DisasContext. This is a prerequisite to any change in how windowed registers might be managed. Since such a goal must of course touch get_src[12], and therefore touch

[Qemu-devel] [PATCH 07/20] target-sparc: Cleanup cpu_src[12] allocation

2012-10-16 Thread Richard Henderson
Now that get_temp_tl is used for get_src[12], we don't need to pre-allocate these temporaries. Fallout from this is moving some assignments around cas/casx to avoid uninitialized variable warnings. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 16

[Qemu-devel] [PATCH 02/20] target-sparc: Conversion to gen_*_gpr, part 1

2012-10-16 Thread Richard Henderson
Only handle the easy cases directly within disas_sparc_insn. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 420 --- 1 file changed, 177 insertions(+), 243 deletions(-) diff --git a/target-sparc/translate.c

Re: [Qemu-devel] [PATCH v2 1/3] qemu-img: Add --backing-chain option to info command

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2

Re: [Qemu-devel] [PATCH v2 2/3] qemu-img: Detect backing file chain infinite loops

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: A malicious or corruption image can contain an infinite loop of backing files. The qemu-img info --backing-chain command must not hang when such files are encountered. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com This seems to do what is

[Qemu-devel] [PATCH 18/20] target-sparc: Only use cpu_dst for eventual writes to a gpr

2012-10-16 Thread Richard Henderson
Use cpu_tmp0 for other stuff, like Write Priv Register. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 52 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/target-sparc/translate.c

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add 041 backing file chain infinite loop test

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/041 | 90

[Qemu-devel] [PATCH 09/20] target-sparc: Split out get_temp_i32

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 29 + 1 file changed, 17 insertions(+), 12 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index e3e4256..5296a37 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 12/20] target-sparc: Avoid cpu_tmp32 in Write Priv Register

2012-10-16 Thread Richard Henderson
No need to copy to a temporary to store 32 bits. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 56 +--- 1 file changed, 24 insertions(+), 32 deletions(-) diff --git a/target-sparc/translate.c

[Qemu-devel] [PATCH 04/20] target-sparc: Convert asi helpers to gen_*_gpr

2012-10-16 Thread Richard Henderson
Push the DisasContext down so that we can use gen_load/store_gpr in sode gen_ldda_asi, gen_stda_ast, gen_cas_asi, gen_casx_asi. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 61 +--- 1 file changed, 32 insertions(+),

[Qemu-devel] [PATCH 19/20] target-sparc: Make cpu_dst local to OP=2 insns

2012-10-16 Thread Richard Henderson
And initialize it such that it (may) write directly to rd. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 5b7e82b..8559cc3 100644

[Qemu-devel] [PATCH 08/20] target-sparc: Make the cpu_addr variable local to load/store handling

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 2a95c1f..e3e4256 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 03/20] target-sparc: Use gen_load_gpr in get_src[12]

2012-10-16 Thread Richard Henderson
This means we can avoid the incoming temporary, though the cleanup of the existing temporaries is not performed in this patch. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 75 +++- 1 file changed, 29 insertions(+),

[Qemu-devel] [PATCH 13/20] target-sparc: Tidy ldfsr, stfsr

2012-10-16 Thread Richard Henderson
Remove the last uses of cpu_tmp32. Unify the code between sparc64 and sparc32 by using the proper tl functions. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff

[Qemu-devel] [PATCH 15/20] target-sparc: Don't use a temporary for gen_dest_fpr_D

2012-10-16 Thread Richard Henderson
In all cases we don't have write-before-read problems. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index

[Qemu-devel] [PATCH 14/20] target-sparc: Remove usage of cpu_tmp64 from most helper functions

2012-10-16 Thread Richard Henderson
Use a locally allocated temporary instead. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 73 +--- 1 file changed, 44 insertions(+), 29 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

[Qemu-devel] [PATCH 17/20] target-sparc: Remove last uses of cpu_tmp64

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index 64feaa3..16cf8de 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 05/20] target-sparc: Convert swap to gen_load/store_gpr

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c index f4ab6cc..8a2e914 100644 --- a/target-sparc/translate.c +++

[Qemu-devel] [PATCH 16/20] target-sparc: Remove cpu_tmp64 use from softint insns

2012-10-16 Thread Richard Henderson
The use of tl functions and a tmp64 is logically incompatible. Use cpu_tmp0 instead. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

[Qemu-devel] [PATCH 06/20] target-sparc: Finish conversion to gen_load_gpr

2012-10-16 Thread Richard Henderson
All users of gen_movl_{reg_TN,TN_reg} are removed. At the same time, make cpu_val a local variable for load/store disassembly. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 58 +--- 1 file changed, 20 insertions(+),

[Qemu-devel] [PATCH 20/20] target-sparc: Remove cpu_tmp0 as a global

2012-10-16 Thread Richard Henderson
Subroutines do their own local temporary management. Within disas_sparc_insn we limit the existance of the variable to OP=2 insns, and delay initialization as late as is reasonable for the specific XOP. Signed-off-by: Richard Henderson r...@twiddle.net --- target-sparc/translate.c | 203

[Qemu-devel] Singlestepping Target assembly instructions

2012-10-16 Thread Emmanuel Blot
Hi, I'm using QEmu to debug an ARM target (OS-less code). I searched/googled for help on how to trace all instructions executed on the target CPU. Using -singlestep and -d in_asm option switches generate the data I'm looking for, however as the translation blocks are cached, the instructions are

Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-16 Thread Kuniyasu Suzaki
Hello, From: Paolo Bonzini pbonz...@redhat.com Subject: Re: delvm does not reduce the qcow2 file size Date: Tue, 16 Oct 2012 08:54:46 +0200 QEMU should also convert the unused clusters to holes in the file system, but it doesn't do that yet. I hope a qcow2 file is reduced automatically

Re: [Qemu-devel] delvm does not reduce the qcow2 file size

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 13:06, Kuniyasu Suzaki ha scritto: QEMU should also convert the unused clusters to holes in the file system, but it doesn't do that yet. I hope a qcow2 file is reduced automatically when a snapshot is deleted. Yes, that's part of the plan. The file would not reduce

Re: [Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Kevin Wolf
Am 15.10.2012 22:50, schrieb Alex Bligh: This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is

Re: [Qemu-devel] [PATCH v2] hw/armv7m_nvic: Implement byte/halfword access for NVIC SCB_SHPRx registers

2012-10-16 Thread Peter Maydell
On 14 October 2012 19:43, Andre Beckus mikemail98-q...@yahoo.com wrote: Implement byte/halfword read and write for the NVIC SCB_SHPRx (System Handler Priority Registers). Do this by removing SHPR word access from nvic_readl/writel and adding common code to hande all access sizes in

Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_find_backing_image compare canonical filenames

2012-10-16 Thread Kevin Wolf
Am 13.10.2012 17:25, schrieb Jeff Cody: On 10/12/2012 05:52 PM, Eric Blake wrote: On 10/09/2012 11:56 PM, Jeff Cody wrote: Currently, bdrv_find_backing_image compares bs-backing_file with what is passed in as a backing_file name. Mismatches may occur, however, when bs-backing_file and

Re: [Qemu-devel] [PATCH] Add nvram to default boot device list

2012-10-16 Thread Avik Sil
On 10/12/2012 08:32 AM, Chris Wright wrote: * Alexander Graf (ag...@suse.de) wrote: On 12.10.2012, at 02:28, David Gibson wrote: On Fri, Oct 12, 2012 at 02:03:00AM +0200, Alexander Graf wrote: On 12.10.2012, at 00:59, David Gibson wrote: On Thu, Oct 11, 2012 at 07:34:42AM +0530, Avik Sil

[Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-10-16 Thread Edivaldo de Araujo Pereira
Hi Stefan I finally could revert that commit in the latest snapshot; problem was I needed to revert one later, that modified hw/virtio-serial-bus.c accordingly; after that reversion, the regression in network performance went completely away; this confirms my previous identification of the commit

[Qemu-devel] [PATCHv4] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Alex Bligh
This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is used; this adds support when -u is not used.

Re: [Qemu-devel] [PATCHv3] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Alex Bligh
Kevin, --On 16 October 2012 13:22:47 +0200 Kevin Wolf kw...@redhat.com wrote: Apart from the coding style problems, the patch looks good to me. Coding problems fixed v4 sent under separate cover. -- Alex Bligh

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Peter Maydell
On 16 October 2012 07:53, Catalin Patulea catal...@google.com wrote: Sorry this got abandoned.. here is a fresh (and slightly leaner) patch on top of master. Can anyone take a look? --- This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm

Re: [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA

2012-10-16 Thread Rik van Riel
On 10/16/2012 04:39 AM, Mel Gorman wrote: Thierry reported that the iron out patch for isolate_freepages_block() had problems due to the strict check being too strict with mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1. It's possible that more pages than

Re: [Qemu-devel] [PATCH 15/25] qemu-sockets: add error propagation to inet_connect_addr

2012-10-16 Thread Luiz Capitulino
On Wed, 10 Oct 2012 16:02:56 +0200 Paolo Bonzini pbonz...@redhat.com wrote: perror and fprintf can be removed because all clients can now consume Errors properly. However, we need to change the non-blocking connect handlers to take an Error, in order to improve error handling for migration

Re: [Qemu-devel] [PATCHv4] qemu-img rebase: use empty string to rebase without backing file

2012-10-16 Thread Kevin Wolf
Am 16.10.2012 14:46, schrieb Alex Bligh: This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is

Re: [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server

2012-10-16 Thread Luiz Capitulino
On Wed, 10 Oct 2012 16:02:41 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Luiz, The following changes since commit b4ae3cfa57b8c1bdbbd7b7d420971e9171203ade: ssi: Add slave autoconnect helper (2012-10-10 11:13:32 +1000) are available in the git repository at:

Re: [Qemu-devel] [PULL for Luiz 00/25] Combined qemu-sockets cleanup v2 + NBD server

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 15:09, Luiz Capitulino ha scritto: I've applied all these patches to the qmp tree, ie. I didn't pull. I did this because it was easier to me and because of the following changes: 1. I've added my signed-off to all patches 2. I've dropped previous acked reviewed-by from me

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-16 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote: For writes, the standard seems to be a commit latch. We could abuse the

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 13:09:55 +0200 Andreas Färber afaer...@suse.de wrote: Am 15.10.2012 08:51, schrieb Lei Li: On 10/12/2012 08:39 PM, Gerd Hoffmann wrote: +void qmp_chardev_del(const char *id, Error **errp) +{ +CharDriverState *chr; + +chr = qemu_chr_find(id); +if

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-16 Thread Michael S. Tsirkin
On Tue, Oct 16, 2012 at 11:45:41PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:21:50PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: On Fri, Oct 12, 2012 at 08:59:36AM +1030, Rusty Russell wrote: For writes,

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Alex Williamson
On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote: On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote: This makes use of the new level irqfd support enabling bypass of qemu userspace both on INTx injection and unmask. This significantly boosts the performance of

Re: [Qemu-devel] Using PCI config space to indicate config location

2012-10-16 Thread Rusty Russell
Michael S. Tsirkin m...@redhat.com writes: On Tue, Oct 16, 2012 at 11:45:41PM +1030, Rusty Russell wrote: Michael S. Tsirkin m...@redhat.com writes: I was assuming the implementation would keep two complete copies of the config space: writes go to the scratch version, which gets copied to the

Re: [Qemu-devel] [PATCH v2] chardev: add hotplug support.

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 19:36, Eric Blake ha scritto: +## +# @chardev_del: And this should be 'chardev-del' or even 'chardev-remove', as QMP commands tend to favor legibility over abbreviations. In doubt we should favor consistency though (with netdev_add and netdev_del). I'm for keeping this as

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Michael S. Tsirkin
On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote: On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote: On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote: This makes use of the new level irqfd support enabling bypass of qemu userspace both on INTx

Re: [Qemu-devel] [RFC 09/13] qdev: move reset register/unregister code to qdev-system.c

2012-10-16 Thread Anthony Liguori
Eduardo Habkost ehabk...@redhat.com writes: Also, add weak symbols that will be used if qdev-system.o is not compiled in (i.e. on *-user). Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/qdev-core.c | 16 +++- hw/qdev-core.h | 3 +++ hw/qdev-system.c | 15

[Qemu-devel] [PATCH v2 0/4] block-commit fixes

2012-10-16 Thread Jeff Cody
v1 - v2 differences: * Updated changes to be protocol friendly * Updated block-commit tests to account for different error message wording * Updated block-commit tests to add relative backing filename tests * In bdrv_find_backing_image(), use g_malloc() instead of char arrays Jeff Cody (4):

[Qemu-devel] [PATCH v2 3/4] qemu-iotests: qemu-io tests update for block-commit (040)

2012-10-16 Thread Jeff Cody
Some of the error messages put out by block-commit have changed slightly, which causes 2 tests cases for block-commit to fail. This patch updates the test cases to look for the correct error output. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/040 | 4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v2 4/4] qemu-iotests: add relative backing file tests for block-commit (040)

2012-10-16 Thread Jeff Cody
The previous block commit used absolute filenames for all block-commit images and commands; this adds relative filenames for the same tests. Signed-off-by: Jeff Cody jc...@redhat.com --- tests/qemu-iotests/040 | 102 + tests/qemu-iotests/040.out |

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Alex Williamson
On Tue, 2012-10-16 at 16:14 +0200, Michael S. Tsirkin wrote: On Tue, Oct 16, 2012 at 07:51:43AM -0600, Alex Williamson wrote: On Tue, 2012-10-16 at 08:39 +0200, Michael S. Tsirkin wrote: On Mon, Oct 15, 2012 at 02:28:15PM -0600, Alex Williamson wrote: This makes use of the new level

[Qemu-devel] KVM call minutes for 2012-10-16

2012-10-16 Thread Juan Quintela
2012-10-16 -- - cpu as dev making qdev available to all parts of qemu is the best solution (aliguory) how does linux-user people think about it? Eduardo will follow Objections: * conceptually it makes no sense to have devices on *-user * desire of linux-user to maintain the

Re: [Qemu-devel] [PATCH v2 1/3] qemu-img: Add --backing-chain option to info command

2012-10-16 Thread Stefan Hajnoczi
On Tue, Oct 16, 2012 at 12:04:24PM +0200, Kevin Wolf wrote: Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info

Re: [Qemu-devel] [PATCH v2 3/3] qemu-iotests: Add 041 backing file chain infinite loop test

2012-10-16 Thread Stefan Hajnoczi
On Tue, Oct 16, 2012 at 12:22:38PM +0200, Kevin Wolf wrote: Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] [PATCH v2 2/3] qemu-img: Detect backing file chain infinite loops

2012-10-16 Thread Kevin Wolf
Am 16.10.2012 16:42, schrieb Stefan Hajnoczi: On Tue, Oct 16, 2012 at 12:11:44PM +0200, Kevin Wolf wrote: Am 15.10.2012 14:44, schrieb Stefan Hajnoczi: A malicious or corruption image can contain an infinite loop of backing files. The qemu-img info --backing-chain command must not hang when

  1   2   3   >