Re: [Qemu-devel] [PATCH 1/2] hmp: fix info cpus for sparc targets

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 11:01:45PM -0300, Luiz Capitulino wrote: > On Wed, 17 Oct 2012 01:28:34 +0200 > Aurelien Jarno wrote: > > > On sparc targets, info cpus returns this kind of output: > > > > | info cpus > > | * CPU #0: > > pc=0x00424d18pc=0x00424d18npc=0x00424d1c

Re: [Qemu-devel] [PATCH v11 06/14] target-mips: Add ASE DSP arithmetic instructions

2012-10-16 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 12:54:45PM +0800, Jia Liu wrote: > >>> +if (ret == 0) { > >>> +/* Treat as NOP. */ > >>> +MIPS_DEBUG("NOP"); > >>> +return; > >>> +} > >>> + > >>> +if (v1 == 0) { > >>> +tcg_gen_movi_tl(v1_t, 0); > >>> +} else { > >>> +

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-16 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 11:44:41AM +0800, Jia Liu wrote: > Hi Aurelien, > > >> +#ifdef TARGET_MIPS64 > >> +case OPC_ABSQ_S_QH_DSP: > >> +switch (op2) { > >> +case OPC_REPL_OB: > >> +check_dsp(ctx); > >> +{ > >> +target_long temp; > >> + >

[Qemu-devel] [PATCH 2/4] linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr

2012-10-16 Thread Richard Henderson
The previous formuation with multiple assignments to __typeof(*hptr) falls down when hptr is qualified const. E.g. with const struct S *p, p->f is also qualified const. With this formulation, there's no assignment to any local variable. Signed-off-by: Richard Henderson --- linux-user/qemu.h |

[Qemu-devel] [PATCH 4/4] user: Consider symbolic links as possible directories

2012-10-16 Thread Richard Henderson
Commit 2296f194dfde4c0a54f249d3fdb8c8ca21dc611b reduced the number of syscalls performed during user emulation startup, but failed to consider the use of symbolic links in creating directory structures. Signed-off-by: Richard Henderson --- path.c | 5 +++-- 1 file changed, 3 insertions(+), 2 del

[Qemu-devel] [PATCH 3/4] alpha-linux-user: Fix sigaction

2012-10-16 Thread Richard Henderson
Unconditional bswap replaced by __get_user/__put_user. Signed-off-by: Richard Henderson --- linux-user/signal.c | 22 -- linux-user/syscall_defs.h | 2 +- 2 files changed, 9 insertions(+), 15 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 95

[Qemu-devel] [PATCH 1/4] cpu-all: Add unaligned load/store helper functions

2012-10-16 Thread Richard Henderson
Signed-off-by: Richard Henderson --- cpu-all.h | 38 ++ 1 file changed, 38 insertions(+) diff --git a/cpu-all.h b/cpu-all.h index 2b99682..2db4414 100644 --- a/cpu-all.h +++ b/cpu-all.h @@ -113,6 +113,44 @@ static inline void tswap64s(uint64_t *s) #define bsw

[Qemu-devel] [PATCH 0/4] linux-user improvements

2012-10-16 Thread Richard Henderson
The remaining alpha-linux-user patch, with updated dependencies. In addition, a new fix for guest system paths containing links. r~ Richard Henderson (4): cpu-all: Add unaligned load/store helper functions linux-user: Rewrite __get_user/__put_user with __builtin_choose_expr alpha-linux-us

Re: [Qemu-devel] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-16 Thread Eric Blake
On 10/16/2012 12:10 PM, Corey Bryant wrote: > This option can be used for passing file descriptors on the > command line. It mirrors the existing add-fd QMP command which > allows an fd to be passed to QEMU via SCM_RIGHTS and added to an > fd set. > > This can be combined with commands such as -d

Re: [Qemu-devel] [PATCH v3 3/4] monitor: Prevent removing fd from set during init

2012-10-16 Thread Eric Blake
On 10/16/2012 12:08 PM, Corey Bryant wrote: > If an fd is added to an fd set via the command line, and it is not > referenced by another command line option (ie. -drive), then clean > it up after QEMU initialization is complete. > > Signed-off-by: Corey Bryant > --- > v3: > - This patch was spl

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-16 Thread Jia Liu
Hi Aurelien, On Wed, Oct 17, 2012 at 7:23 AM, Aurelien Jarno wrote: > On Tue, Oct 16, 2012 at 12:39:13AM +0800, Jia Liu wrote: >> Add MIPS ASE DSP Bit/Manipulation instructions. >> >> Signed-off-by: Jia Liu >> --- >> target-mips/dsp_helper.c | 55 +++ >> target-mips/helper.h |

Re: [Qemu-devel] [PATCH v11 01/14] target-mips: Add ASE DSP internal functions

2012-10-16 Thread Jia Liu
Hi Aurelien, On Wed, Oct 17, 2012 at 7:20 AM, Aurelien Jarno wrote: > On Tue, Oct 16, 2012 at 12:39:05AM +0800, Jia Liu wrote: >> Add internal functions using by MIPS ASE DSP instructions. >> >> Signed-off-by: Jia Liu >> --- >> target-mips/Makefile.objs |2 +- >> target-mips/dsp_helper.c |

Re: [Qemu-devel] [PATCH 1/2] hmp: fix info cpus for sparc targets

2012-10-16 Thread Luiz Capitulino
On Wed, 17 Oct 2012 01:28:34 +0200 Aurelien Jarno wrote: > On sparc targets, info cpus returns this kind of output: > > | info cpus > | * CPU #0: pc=0x00424d18pc=0x00424d18npc=0x00424d1c > thread_id=19460 > > pc is printed twice, there is no space between pc, pc and npc

Re: [Qemu-devel] [PATCH v2] qmp: fix __accept() in qmp.py

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 16:58:02 -0400 Jeff Cody wrote: > In QEMUMonitorProtocol, commit e9d17b6 removed the __sockfile creation > from __negotiate_capabilities(), which breaks _accept(). This causes > failures in qemu-io python based tests (i.e. tests 030 and 040). > > This patch creates the sockf

Re: [Qemu-devel] [PATCH v3 0/9] serial device hotplug patch series.

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 10:06:48 +0200 Gerd Hoffmann wrote: > This patch series tackles serial device hotplug. This conflicts with Paolo's work merged in: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp You could base your work on top of that to avoid conflicts, but note that I might rebase that

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 12:04:52 -0600 Eric Blake wrote: > On 10/15/2012 02:06 AM, Gerd Hoffmann wrote: > > This patch adds chardev_add and chardev_del monitor commands. > > > > They work simliar to the netdev_{add,del} commands. The hmp version of > > s/simliar/similar/ > > > chardev_add accepts

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 10:06:57 +0200 Gerd Hoffmann wrote: > This patch adds chardev_add and chardev_del monitor commands. > > They work simliar to the netdev_{add,del} commands. The hmp version of > chardev_add accepts like the -chardev command line option does. The qmp > version expects the arg

Re: [Qemu-devel] [PATCH v3 8/9] chardev: fix QemuOpts lifecycle

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 10:06:56 +0200 Gerd Hoffmann wrote: > qemu_chr_new_from_opts handles QemuOpts release now, so callers don't > have to worry. It will either be saved in CharDriverState, then > released in qemu_chr_delete, or in the error case released instantly. > > Signed-off-by: Gerd Hoffm

Re: [Qemu-devel] [PATCH v3 7/9] chardev: add error reporting for qemu_chr_new_from_opts

2012-10-16 Thread Luiz Capitulino
On Tue, 16 Oct 2012 22:12:13 -0300 Luiz Capitulino wrote: > On Mon, 15 Oct 2012 10:06:55 +0200 > Gerd Hoffmann wrote: > > > Signed-off-by: Gerd Hoffmann > > --- > > qemu-char.c | 24 +++- > > qemu-char.h |3 ++- > > vl.c|7 ++- > > 3 files changed, 23

Re: [Qemu-devel] [PATCH v3 7/9] chardev: add error reporting for qemu_chr_new_from_opts

2012-10-16 Thread Luiz Capitulino
On Mon, 15 Oct 2012 10:06:55 +0200 Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > qemu-char.c | 24 +++- > qemu-char.h |3 ++- > vl.c|7 ++- > 3 files changed, 23 insertions(+), 11 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c >

Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-16 Thread Richard Henderson
On 2012-10-17 09:25, Aurelien Jarno wrote: >> > +gen_opc_buf[op_index] = op = INDEX_op_mul_i32; > Very minor nitpick: you probably don't need to set op there. > Perhaps not, but I prefer to keep the variables in sync as we drop into common code... r~

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread David Gibson
On Tue, Oct 16, 2012 at 06:12:22PM -0500, Anthony Liguori wrote: > Peter Maydell writes: > > > On 16 October 2012 20:55, Anthony Liguori wrote: > >> > >> We discussed nvram and it's interaction with boot order in today's KVM > >> call. Here's the outcome. This list is completely incremental so

[Qemu-devel] [Bug 1067517] [NEW] qemu dosn't save snapshots with the 'commit' command

2012-10-16 Thread Michael Mair-Keimberger
Public bug reported: Usually there is the 'commit' command in qemu which is described as followed: "commit changes to the disk images (if -snapshot is used) or backing files" >From the context i though if i start a guest with the "-snapshot" option, the >commit command would save all the changes

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread David Gibson
On Tue, Oct 16, 2012 at 02:55:21PM -0500, Anthony Liguori wrote: > > We discussed nvram and it's interaction with boot order in today's KVM > call. Here's the outcome. This list is completely incremental so it's > fine to start with 1-4, for instance, as long as we eventually get > to 6. Sorry

Re: [Qemu-devel] [PATCH 0/2] tcg/arm: Implement movcond_i32

2012-10-16 Thread Aurelien Jarno
On Wed, Sep 26, 2012 at 07:48:53PM +0100, Peter Maydell wrote: > These patches implement movcond_i32 for the ARM TCG backend; we > emit "mov dst, v2; cmp c1, c2; movcc dst, v1". We could have > done this with a pair of conditional movs, but (a) this is not > actually any shorter (b) it means we don

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2012-10-16 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/407 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 B

[Qemu-devel] [PATCH 1/2] hmp: fix info cpus for sparc targets

2012-10-16 Thread Aurelien Jarno
On sparc targets, info cpus returns this kind of output: | info cpus | * CPU #0: pc=0x00424d18pc=0x00424d18npc=0x00424d1c thread_id=19460 pc is printed twice, there is no space between pc, pc and npc. As npc implies pc, don't set has_pc on sparc, and add a space between p

[Qemu-devel] [PATCH 2/2] target-sparc: fix FMOVr instruction

2012-10-16 Thread Aurelien Jarno
Like the MOVr instruction, the FMOVr instruction has the condition encoded between bits 10 and 12. Cc: Blue Swirl Signed-off-by: Aurelien Jarno --- target-sparc/translate.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

Re: [Qemu-devel] [PATCH] tcg-ia64: Implement deposit

2012-10-16 Thread Aurelien Jarno
On Wed, Oct 10, 2012 at 04:01:35PM -0700, Richard Henderson wrote: > Note that in the general reg=reg,reg case we're restricted > to 16-bit insertions. This makes it easy to allow "any" > constant as input, as post-truncation it will fit into the > constant load insn for which we have room in the

Re: [Qemu-devel] [PATCH 09/10] tcg: Optimize half-dead add2/sub2

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 02, 2012 at 11:32:29AM -0700, Richard Henderson wrote: > When x86_64 guest is not in 64-bit mode, the high-part of the 64-bit > add is dead. When the host is 32-bit, we can simplify to 32-bit > arithmetic. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 34 +

Re: [Qemu-devel] [PATCH v11 12/14] target-mips: Add ASE DSP processors

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:16AM +0800, Jia Liu wrote: > Add 74kf and mips64dspr2-generic-cpu model for test. > > Signed-off-by: Jia Liu > --- > target-mips/translate_init.c | 52 > ++ > 1 file changed, 52 insertions(+) > > diff --git a/target-mips/t

Re: [Qemu-devel] [PATCH 04/14] target-mips: use softfloat constants when possible

2012-10-16 Thread Aurelien Jarno
On Wed, Oct 10, 2012 at 01:09:49PM -0700, Richard Henderson wrote: > On 10/09/2012 01:27 PM, Aurelien Jarno wrote: > > softfloat already has a few constants defined, use them instead of > > redefining them in target-mips. > > > > Rename FLOAT_SNAN32 and FLOAT_SNAN64 to FP_TO_INT32_OVERFLOW and > >

Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 02, 2012 at 11:32:30AM -0700, Richard Henderson wrote: > Like add2, do operand ordering, constant folding, and dead operand > elimination. The latter happens about 15% of all mulu2 during an > x86_64 bios boot. > > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 26 +++

Re: [Qemu-devel] [PATCH v11 14/14] target-mips: Change TODO file

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:18AM +0800, Jia Liu wrote: > Change DSP r1 & DSP r2 into microMIPS DSP encodings in TODO file. > > Signed-off-by: Jia Liu > --- > target-mips/TODO |3 +-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target-mips/TODO b/target-mips/TODO > i

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:13AM +0800, Jia Liu wrote: > Add MIPS ASE DSP Bit/Manipulation instructions. > > Signed-off-by: Jia Liu > --- > target-mips/dsp_helper.c | 55 +++ > target-mips/helper.h |7 ++ > target-mips/translate.c | 231 > ++

Re: [Qemu-devel] [PATCH v11 10/14] target-mips: Add ASE DSP compare-pick instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:14AM +0800, Jia Liu wrote: > Add MIPS ASE DSP Compare-Pick instructions. > > Signed-off-by: Jia Liu > --- > target-mips/dsp_helper.c | 233 + > target-mips/helper.h | 52 +++ > target-mips/translate.c | 372 > +++

Re: [Qemu-devel] [PATCH v11 11/14] target-mips: Add ASE DSP accumulator instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:15AM +0800, Jia Liu wrote: > Add MIPS ASE DSP Accumulator and DSPControl Access instructions. > > Signed-off-by: Jia Liu > --- > target-mips/dsp_helper.c | 609 > ++ > target-mips/helper.h | 35 +++ > target-mips/t

Re: [Qemu-devel] [PATCH v11 07/14] target-mips: Add ASE DSP GPR based shift instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:11AM +0800, Jia Liu wrote: > Add MIPS ASE DSP GPR-Based Shift instructions. > > Signed-off-by: Jia Liu > --- > target-mips/dsp_helper.c | 256 > target-mips/helper.h | 38 ++ > target-mips/translate.c | 328 > ++

Re: [Qemu-devel] [PATCH v11 05/14] target-mips: Add ASE DSP load instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:09AM +0800, Jia Liu wrote: > Add MIPS ASE DSP Load instructions. > > Signed-off-by: Jia Liu > --- > target-mips/translate.c | 89 > +++ > 1 file changed, 89 insertions(+) > > diff --git a/target-mips/translate.c b/targ

Re: [Qemu-devel] [PATCH v11 03/14] target-mips: Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:07AM +0800, Jia Liu wrote: > Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number. > > Signed-off-by: Jia Liu > --- > target-mips/translate.c | 122 > --- > 1 file changed, 95 insertions(+), 27 del

Re: [Qemu-devel] [PATCH v11 04/14] target-mips: Add ASE DSP branch instructions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:08AM +0800, Jia Liu wrote: > Add MIPS ASE DSP Branch instructions. > > Signed-off-by: Jia Liu > --- > target-mips/translate.c | 36 > 1 file changed, 36 insertions(+) > > diff --git a/target-mips/translate.c b/target-mips/tran

Re: [Qemu-devel] [PATCH v11 02/14] target-mips: Add ASE DSP resources access check

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:06AM +0800, Jia Liu wrote: > Add MIPS ASE DSP resources access check. > > Signed-off-by: Jia Liu > --- > linux-user/main.c |6 ++ > target-mips/cpu.h | 23 +-- > target-mips/helper.c|3 +++ > target-mips/translate.c

Re: [Qemu-devel] [PATCH v11 01/14] target-mips: Add ASE DSP internal functions

2012-10-16 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 12:39:05AM +0800, Jia Liu wrote: > Add internal functions using by MIPS ASE DSP instructions. > > Signed-off-by: Jia Liu > --- > target-mips/Makefile.objs |2 +- > target-mips/dsp_helper.c | 1086 > + > 2 files changed, 10

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread Anthony Liguori
Peter Maydell writes: > On 16 October 2012 20:55, Anthony Liguori wrote: >> >> We discussed nvram and it's interaction with boot order in today's KVM >> call. Here's the outcome. This list is completely incremental so it's >> fine to start with 1-4, for instance, as long as we eventually get t

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-16 Thread Peter Maydell
On 16 October 2012 21:20, Stefan Weil wrote: > Hi Peter, hi Blue, > > gcc uses a different flag -Wno-override-init to disable initializer override > warnings. > > I tested the following patch which uses -Wextra with gcc-4.4 and gcc-4.7. > It allows compilation of QEMU without warnings. > > A test

Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-16 Thread Eric Blake
On 10/16/2012 12:08 PM, Corey Bryant wrote: > qmp_add_fd() gets an fd that was received over a socket with > SCM_RIGHTS and adds it to an fd set. This patch adds support > that will enable adding an fd that was inherited on the > command line to an fd set. > > Note: All of the code added to monit

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Tue, 2012-10-16 at 14:55 -0500, Anthony Liguori wrote: >> >> 4) If -boot is specified, the parameter should alter the contents of >>NVRAM to change the boot order to what is specified by -boot. >> >> 5) If ,bootorder is specified, it should take predence

Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes

2012-10-16 Thread Eric Blake
On 10/16/2012 01:49 PM, Jeff Cody wrote: > v2 -> v3 differences: > > * Simplified code in patch 2, minor commit rewording > * Made conditional check more valgrind-friendly > > v1 -> v2 differences: > > * Updated changes to be protocol friendly > * Updated block-commit tests to account for differ

Re: [Qemu-devel] Singlestepping & Target assembly instructions

2012-10-16 Thread Richard Henderson
On 2012-10-17 06:17, Laurent Desnogues wrote: > If I remember correctly, that only works if block chaining is disabled. Which it will be with -singlestep. r~

Re: [Qemu-devel] [PATCH v3 1/4] monitor: Allow add-fd to any specified fd set

2012-10-16 Thread Eric Blake
On 10/16/2012 12:05 PM, Corey Bryant wrote: > The first call to add an fd to an fd set was previously not > allowed to choose the fd set ID. The ID was generated as > the first available and ensuing calls could add more fds by > specifying the fd set ID. This change allows users to > choose the f

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-16 Thread Stefan Weil
Am 14.10.2012 22:24, schrieb Peter Maydell: On 14 October 2012 21:15, Blue Swirl wrote: On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell wrote: Blue Swirl previously submitted a patch which enabled this flag (among others): http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html In

Re: [Qemu-devel] Singlestepping & Target assembly instructions

2012-10-16 Thread Laurent Desnogues
On Tue, Oct 16, 2012 at 9:07 PM, Richard Henderson wrote: > On 2012-10-16 20:49, Emmanuel Blot wrote: >> Is there any way to force QEmu to disable the TB cache so that the >> translation occurs each time a target instruction is loaded, or a >> clever way to print out the address of each executed t

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread Peter Maydell
On 16 October 2012 20:55, Anthony Liguori wrote: > > We discussed nvram and it's interaction with boot order in today's KVM > call. Here's the outcome. This list is completely incremental so it's > fine to start with 1-4, for instance, as long as we eventually get to 6. > > Today, on x86, we imp

Re: [Qemu-devel] [PATCHv5] tests/tcg: fix build

2012-10-16 Thread Peter Maydell
On 16 October 2012 21:00, Catalin Patulea wrote: > This broke when the tests were moved from tests/ to tests/tcg/. > > On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are > broken, but at least they build. > > To build/run the tests: > $ cd $BUILD_PATH/tests/tcg > $ SRC_PATH

Re: [Qemu-devel] nvram and boot order

2012-10-16 Thread Benjamin Herrenschmidt
On Tue, 2012-10-16 at 14:55 -0500, Anthony Liguori wrote: > > 4) If -boot is specified, the parameter should alter the contents of >NVRAM to change the boot order to what is specified by -boot. > > 5) If ,bootorder is specified, it should take predence over -boot. > > 6) ,bootorder= should a

Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Peter Maydell
On 16 October 2012 20:57, Catalin Patulea wrote: > On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell > wrote: >> This patch isn't in the right format to apply, I'm afraid. >> Major problem: >> * missing signed-off-by line: we can't accept any patch >>without one >> Minor problem: >> * the act

[Qemu-devel] [PATCH 08/12] qdev: move reset register/unregister code to qdev-system.c

2012-10-16 Thread Eduardo Habkost
Also, add weak symbols that will be used if qdev-system.o is not compiled in (i.e. on *-user). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Add GCC_WEAK_DECL to function declarations --- hw/qdev-core.c | 16 +++- hw/qdev-core.h | 3 +++ hw/qdev-system.c | 15 +

[Qemu-devel] [PATCH 10/12] qdev: use full qdev.h include path on qdev*.c

2012-10-16 Thread Eduardo Habkost
This way, the files can be moved to the qom/ directory as-is. Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 2 +- hw/qdev-properties.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/qdev-core.c b/hw/qdev-core.c index a756e07..fbb7cb5 100644 --- a/hw/qdev-co

[Qemu-devel] [PATCHv5] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To build/run the tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to/qemu make Signed-off-by: Catalin Patulea --- This ve

[Qemu-devel] [PATCH v3 3/4] qemu-iotests: qemu-io tests update for block-commit (040)

2012-10-16 Thread Jeff Cody
Some of the error messages put out by block-commit have changed slightly, which causes 2 tests cases for block-commit to fail. This patch updates the test cases to look for the correct error output. Signed-off-by: Jeff Cody --- tests/qemu-iotests/040 | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 3:54 PM, Peter Maydell wrote: > This patch isn't in the right format to apply, I'm afraid. > Major problem: > * missing signed-off-by line: we can't accept any patch >without one > Minor problem: > * the actual commit message is below the first '---' line, >so 'gi

[Qemu-devel] nvram and boot order

2012-10-16 Thread Anthony Liguori
We discussed nvram and it's interaction with boot order in today's KVM call. Here's the outcome. This list is completely incremental so it's fine to start with 1-4, for instance, as long as we eventually get to 6. Today, on x86, we implement up to (5) but we don't persist NVRAM. 1) We should m

Re: [Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Peter Maydell
On 16 October 2012 20:37, Catalin Patulea wrote: > Fixes compile line for test-x86_64 target as well. > > --- > This broke when the tests were moved from tests/ to tests/tcg/. > > On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are > broken, but at least they build. > > To b

[Qemu-devel] [PATCH v3 4/4] qemu-iotests: add relative backing file tests for block-commit (040)

2012-10-16 Thread Jeff Cody
The previous block commit used absolute filenames for all block-commit images and commands; this adds relative filenames for the same tests. Signed-off-by: Jeff Cody --- tests/qemu-iotests/040 | 102 + tests/qemu-iotests/040.out | 4 +- 2 files c

[Qemu-devel] [PATCH v3 2/4] block: in commit, determine base image from the top image

2012-10-16 Thread Jeff Cody
This simplifies some code and error checking, and also fixes a bug. bdrv_find_backing_image() should only be passed absolute filenames, or filenames relative to the chain. In the QMP message handler for block commit, when looking up the base do so from the determined top image, so we know it is r

[Qemu-devel] [PATCH v3 1/4] block: make bdrv_find_backing_image compare canonical filenames

2012-10-16 Thread Jeff Cody
Currently, bdrv_find_backing_image compares bs->backing_file with what is passed in as a backing_file name. Mismatches may occur, however, when bs->backing_file and backing_file are not both absolute or relative. Use path_combine() to make sure any relative backing filenames are relative to the c

[Qemu-devel] [PATCH v3 0/4] block-commit fixes

2012-10-16 Thread Jeff Cody
v2 -> v3 differences: * Simplified code in patch 2, minor commit rewording * Made conditional check more valgrind-friendly v1 -> v2 differences: * Updated changes to be protocol friendly * Updated block-commit tests to account for different error message wording * Updated block-commit tests to

[Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-*

2012-10-16 Thread Eduardo Habkost
This change should help on two things: - Allowing DeviceState to be used by *-user; - Writing qdev unit tests without pulling too many dependencies. Note that there are two parts that depend on code compiled only on qemu-system-*, but are still inside qdev.c: - vmstate handling - reset functio

Re: [Qemu-devel] [PATCH 6/6] chardev: convert file backend to realize

2012-10-16 Thread Anthony Liguori
Paolo Bonzini writes: > Il 15/10/2012 21:34, Anthony Liguori ha scritto: >> +static char *chardev_file_get_path(Object *obj, Error **errp) >> +{ >> +CharDriverState *chr = CHARDEV(obj); >> +FDCharDriver *s = chr->opaque; >> + >> +return s->path ? g_strdup(s->path) : g_strdup(""); >> +

Re: [Qemu-devel] [PATCH v3 0/4] command line fd passing using fd sets

2012-10-16 Thread Corey Bryant
On 10/16/2012 03:26 PM, Eric Blake wrote: On 10/16/2012 11:51 AM, Corey Bryant wrote: This series adds command line file descriptor passing support via a new -add-fd option. This is a follow-on to the existing QMP fd passing support provided in the following patch series: comments.gmane.org/g

[Qemu-devel] [PATCH 01/12] qdev: split up header so it can be used in cpu.h

2012-10-16 Thread Eduardo Habkost
From: Anthony Liguori Header file dependency is a frickin' nightmare right now. cpu.h tends to get included in our 'include everything' header files but qdev also needs to include those headers mainly for qdev-properties since it knows about CharDriverState and friends. We can solve this for no

[Qemu-devel] [PATCH 06/12] qdev: move vmstate handling to qdev-system.c

2012-10-16 Thread Eduardo Habkost
Add GCC_WEAK symbols to qdev-core.c, so that qdev-core.o can be used without qdev-system.o (i.e. by *-user). Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: - Add GCC_WEAK_DECL to function declarations --- hw/qdev-core.c | 23 +++ hw/qdev-core.h | 2 ++ hw/qdev-sys

[Qemu-devel] [PATCHv4] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
Fixes compile line for test-x86_64 target as well. --- This broke when the tests were moved from tests/ to tests/tcg/. On x86_64 host/i386-linux-user non-kvm guest, test-i386 and test-mmap are broken, but at least they build. To build/run the tests: $ cd $BUILD_PATH/tests/tcg $ SRC_PATH=path/to

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 2:47 PM, Peter Maydell wrote: > I have a feeling that precise's mostly-working multiarch support > may be the issue... Seems I've got libgcc1:i386 and lib32gcc1 which provide libgcc_s.so* in various forms. Not entirely sure what the 'right' setup is.

Re: [Qemu-devel] [PATCH v3 0/4] command line fd passing using fd sets

2012-10-16 Thread Eric Blake
On 10/16/2012 11:51 AM, Corey Bryant wrote: > This series adds command line file descriptor passing support > via a new -add-fd option. This is a follow-on to the existing > QMP fd passing support provided in the following patch series: > comments.gmane.org/gmane.comp.emulators.qemu/165463 > > Th

[Qemu-devel] [PATCH 04/12] qdev: rename qdev.c to qdev-core.c

2012-10-16 Thread Eduardo Habkost
Just to make clear that it's the qdev core code, corresponding to qdev-core.h. Signed-off-by: Eduardo Habkost --- hw/Makefile.objs | 2 +- hw/qdev-core.c | 716 +++ hw/qdev.c| 716

[Qemu-devel] [PATCH 09/12] move qemu_irq typedef out of cpu-common.h

2012-10-16 Thread Eduardo Habkost
From: Igor Mammedov it's necessary for making CPU child of DEVICE without causing circular header deps. Signed-off-by: Igor Mammedov --- Changes v2 -> v3: imammedo: sysemu.h doesn't need irq.h since 013c2f150 --- hw/arm-misc.h | 1 + hw/bt.h | 2 ++ hw/devices.h | 2 ++ hw/omap.h

[Qemu-devel] [PATCH 12/12] qom: make CPU a child of DeviceState

2012-10-16 Thread Eduardo Habkost
From: Igor Mammedov Signed-off-by: Igor Mammedov [ehabkost: change CPU type declaration to hae TYPE_DEVICE as parent] Signed-off-by: Eduardo Habkost --- Yes, there is "changelog" data before the "---" mark, but I believe that in this case they are important to indicate authorship and the scope

[Qemu-devel] [PATCH 05/12] qdev-core: isolate vmstate handling into separate functions

2012-10-16 Thread Eduardo Habkost
Those functions will eventually be moved somewhere else, and won't get included on *-user. Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/hw/qdev-core.c b/hw/qdev-core.c index ee19dd5..92c3021 1006

[Qemu-devel] [PATCH 07/12] qdev-core: isolate reset register/unregister code

2012-10-16 Thread Eduardo Habkost
The reset register/unregister code is specific to qemu-system-*, so isolate it so it can be moved to qdev-system.c. Signed-off-by: Eduardo Habkost --- hw/qdev-core.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/hw/qdev-core.c b/hw/qdev-core.c inde

[Qemu-devel] [PATCH 00/12] make CPU child of DeviceState and include qdev core in *-user

2012-10-16 Thread Eduardo Habkost
v2: This version removes the CONFIG_USER_ONLY ifdefs, and use weak symbols to move the vmstate and qemu_register_reset() handling to qdev-system.c v3 (submitted by Igor): - rebased on top of 8b4a3df (today's master) - slight code reshuffling in (see commit's changelog) "qdev: separate

[Qemu-devel] [PATCH 02/12] qapi-types.h doesn't really need to include qemu-common.h

2012-10-16 Thread Eduardo Habkost
From: Igor Mammedov needed to prevent build breakage when CPU becomes a child of DeviceState Signed-off-by: Igor Mammedov [ehabkost: include too] Signed-off-by: Eduardo Habkost --- Yes, there is "changelog" data before the "---" mark, but I believe that in this case they are important to indi

Re: [Qemu-devel] Singlestepping & Target assembly instructions

2012-10-16 Thread Richard Henderson
On 2012-10-16 20:49, Emmanuel Blot wrote: > Is there any way to force QEmu to disable the TB cache so that the > translation occurs each time a target instruction is loaded, or a > clever way to print out the address of each executed target instruction ? "-d exec" prints the entry point of each TB

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Peter Maydell
On 16 October 2012 19:09, Catalin Patulea wrote: > On Tue, Oct 16, 2012 at 8:50 AM, Peter Maydell > wrote: >> I can't work out how to get a working i386 compiler on my 64-bit Ubuntu >> system >> but I think that's an Ubuntu issue :-) Tests run ok on a 32 bit native box >> (there are some failur

[Qemu-devel] [PATCH v3 3/4] monitor: Prevent removing fd from set during init

2012-10-16 Thread Corey Bryant
If an fd is added to an fd set via the command line, and it is not referenced by another command line option (ie. -drive), then clean it up after QEMU initialization is complete. Signed-off-by: Corey Bryant --- v3: - This patch was split into it's own patch in v3 (ebl...@redhat.com, kw...@r

Re: [Qemu-devel] [PATCH 03/12] qdev: separate core from the code used only by qemu-system-*

2012-10-16 Thread Eduardo Habkost
On Tue, Oct 16, 2012 at 03:57:15AM +0200, Igor Mammedov wrote: [...] > @@ -0,0 +1,68 @@ > +#include "qdev.h" > + > +void qdev_init_gpio_in(DeviceState *dev, qemu_irq_handler handler, int n) > +{ > +assert(dev->num_gpio_in == 0); > +dev->num_gpio_in = n; > +dev->gpio_in = qemu_allocate_i

[Qemu-devel] [PATCH v3 0/4] command line fd passing using fd sets

2012-10-16 Thread Corey Bryant
This series adds command line file descriptor passing support via a new -add-fd option. This is a follow-on to the existing QMP fd passing support provided in the following patch series: comments.gmane.org/gmane.comp.emulators.qemu/165463 The new -add-fd option is designed to mirror the add-fd QM

[Qemu-devel] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-16 Thread Corey Bryant
This option can be used for passing file descriptors on the command line. It mirrors the existing add-fd QMP command which allows an fd to be passed to QEMU via SCM_RIGHTS and added to an fd set. This can be combined with commands such as -drive to link file descriptors in an fd set to a drive:

Re: [Qemu-devel] [PATCHv3] tests/tcg: fix build

2012-10-16 Thread Catalin Patulea
On Tue, Oct 16, 2012 at 8:50 AM, Peter Maydell wrote: > The compile line for the test-x86_64 target also needs > QEMU_INCLUDES added to it. Done. > I can't work out how to get a working i386 compiler on my 64-bit Ubuntu system > but I think that's an Ubuntu issue :-) Tests run ok on a 32 bit nati

[Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-16 Thread Corey Bryant
qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. Note: All of the code added to monitor_fdset_add_fd(), with the exception of the error path

[Qemu-devel] [PATCH v3 1/4] monitor: Allow add-fd to any specified fd set

2012-10-16 Thread Corey Bryant
The first call to add an fd to an fd set was previously not allowed to choose the fd set ID. The ID was generated as the first available and ensuing calls could add more fds by specifying the fd set ID. This change allows users to choose the fd set ID on the first call. Signed-off-by: Corey Brya

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Michael S. Tsirkin
On Tue, Oct 16, 2012 at 10:49:38AM -0600, Alex Williamson wrote: > On Tue, 2012-10-16 at 17:23 +0200, Michael S. Tsirkin wrote: > > On Tue, Oct 16, 2012 at 09:13:15AM -0600, Alex Williamson wrote: > > > > There's no chance we ship e.g. q35 by mistake without this API: since > > > > there is no way

Re: [Qemu-devel] [PATCH] vfio-pci: Add KVM INTx acceleration

2012-10-16 Thread Alex Williamson
On Tue, 2012-10-16 at 17:23 +0200, Michael S. Tsirkin wrote: > On Tue, Oct 16, 2012 at 09:13:15AM -0600, Alex Williamson wrote: > > > There's no chance we ship e.g. q35 by mistake without this API: since > > > there is no way this specific assert can be missed in even basic > > > testing: > > > >

Re: [Qemu-devel] Connecting virtio-9p-pci to a remote 9p server

2012-10-16 Thread Eric Van Hensbergen
On Mon, Oct 15, 2012 at 6:36 AM, Chris Webb wrote: > > Whilst we can mount the shares on each host and then use qemu's 9p > passthrough/proxy support to access the mountpoint, going via the host > kernel and vfs like this feels quite inefficient. We would be converting > back and forth between vfs

Re: [Qemu-devel] [PATCH] mm: compaction: Correct the nr_strict_isolated check for CMA

2012-10-16 Thread Minchan Kim
On Tue, Oct 16, 2012 at 09:39:27AM +0100, Mel Gorman wrote: > Thierry reported that the "iron out" patch for isolate_freepages_block() > had problems due to the strict check being too strict with "mm: compaction: > Iron out isolate_freepages_block() and isolate_freepages_range() -fix1". > It's poss

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-16 Thread Paolo Bonzini
Il 16/10/2012 18:02, Andreas Färber ha scritto: > Am 12.10.2012 03:26, schrieb Andreas Färber: >> This prepares for changing the variable type from void*. >> >> Signed-off-by: Andreas Färber >> Cc: Igor Mammedov > > Paolo, are you happy with getting rid of the pointer property this way? I would

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-16 Thread Andreas Färber
Am 12.10.2012 03:26, schrieb Andreas Färber: > This prepares for changing the variable type from void*. > > Signed-off-by: Andreas Färber > Cc: Igor Mammedov Paolo, are you happy with getting rid of the pointer property this way? Jan, are you okay with accessing APICCommonState in target-i386/

Re: [Qemu-devel] [PATCH 6/6] chardev: convert file backend to realize

2012-10-16 Thread Paolo Bonzini
Il 15/10/2012 21:34, Anthony Liguori ha scritto: > +static char *chardev_file_get_path(Object *obj, Error **errp) > +{ > +CharDriverState *chr = CHARDEV(obj); > +FDCharDriver *s = chr->opaque; > + > +return s->path ? g_strdup(s->path) : g_strdup(""); > +} > + > +static void chardev_file

Re: [Qemu-devel] [PATCH 1/6] object: add object_property_add_bool

2012-10-16 Thread Andreas Färber
Am 15.10.2012 21:34, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori This feels like a resend or v2. I remember discussing whether an opaque might be a good idea and we decided not to lacking an immanent use case. Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Max

Re: [Qemu-devel] [PATCH v2 1/4] block: make bdrv_find_backing_image compare canonical filenames

2012-10-16 Thread Jeff Cody
On 10/16/2012 11:12 AM, Eric Blake wrote: > On 10/16/2012 08:44 AM, Jeff Cody wrote: >> Currently, bdrv_find_backing_image compares bs->backing_file with >> what is passed in as a backing_file name. Mismatches may occur, >> however, when bs->backing_file and backing_file are both not > > Reads be

  1   2   3   >