Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Avi Kivity
On 09/19/2012 02:50 PM, Julien Grall wrote: This is the tenth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it. Acked-by: Avi Kivity a...@redhat.com

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Avi Kivity
On 11/24/2012 03:09 AM, Julien Grall wrote: ping ? Sorry, I must have missed this (twice). -- error compiling committee.c: too many arguments to function

[Qemu-devel] manually refresh the screen

2012-11-25 Thread Peter Cheung
Hi All Which code i can refresh the screen manually? Thanksfrom Peter

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Avi Kivity
On 11/05/2012 02:37 PM, Jan Kiszka wrote: As I noted, init and destroy cannot cause a topology update. Ah, right. Why are we wrapping them in transaction_begin/commit at all then? We aren't. void memory_region_destroy(MemoryRegion *mr) { assert(QTAILQ_EMPTY(mr-subregions));

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Jan Kiszka
On 2012-11-25 11:18, Avi Kivity wrote: On 11/05/2012 02:37 PM, Jan Kiszka wrote: As I noted, init and destroy cannot cause a topology update. Ah, right. Why are we wrapping them in transaction_begin/commit at all then? We aren't. void memory_region_destroy(MemoryRegion *mr) {

Re: [Qemu-devel] [PATCH] exec.c: Use tb1-phys_hash_next directly in tb_remove

2012-11-25 Thread Peter Maydell
On 25 November 2012 07:50, 陳韋任 (Wei-Ren Chen) che...@iis.sinica.edu.tw wrote: ping? This is v1 of the patch, you've sent a v2 and should be pinging that instead... Also (a) it won't go in before 1.3 release now so not much point in being too eager with the pings (b) you could cc qemu-trivial.

Re: [Qemu-devel] qemu-system-arm v1.3.0-rc0 / 1.2.1 freeze on OSX 10.8.2

2012-11-25 Thread Peter Maydell
On 25 November 2012 05:04, Pi LFS lfs...@gmail.com wrote: I've compiled it using the apple-gcc42 toolchain from homebrew. qemu-system-arm starts up with a white window, CPU usage goes up but window just hangs there. I can access the menus and click the window to switch input focus, that's

Re: [Qemu-devel] [PATCH V10 1/8] isa: add isa_address_space_io

2012-11-25 Thread Andreas Färber
Am 19.09.2012 13:50, schrieb Julien Grall: This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall julien.gr...@citrix.com Reviewed-by: Andreas Färber afaer...@suse.de A note below: ---

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Andreas Färber
Am 25.11.2012 10:10, schrieb Avi Kivity: On 09/19/2012 02:50 PM, Julien Grall wrote: This is the tenth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it.

Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions

2012-11-25 Thread Avi Kivity
On 11/25/2012 12:45 PM, Jan Kiszka wrote: On 2012-11-25 11:18, Avi Kivity wrote: On 11/05/2012 02:37 PM, Jan Kiszka wrote: As I noted, init and destroy cannot cause a topology update. Ah, right. Why are we wrapping them in transaction_begin/commit at all then? We aren't. void

Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*

2012-11-25 Thread Andreas Färber
Am 19.09.2012 13:50, schrieb Julien Grall: This patch replaces all register_ioport* by a MemorySection. MemoryRegion fwiw. No need to resend. Andreas It permits to use the new Memory stuff like listener. Moreover, the PCI is added as an argument for apm_init, so we can register IO inside

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Avi Kivity
On 11/25/2012 02:42 PM, Andreas Färber wrote: Am 25.11.2012 10:10, schrieb Avi Kivity: On 09/19/2012 02:50 PM, Julien Grall wrote: This is the tenth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions

[Qemu-devel] [PATCH] hw/virtio-serial-bus: replay guest open on destination

2012-11-25 Thread Alon Levy
When migrating a host with with a spice agent running the mouse becomes non operational after the migration due to the agent state being inconsistent between the guest and the client if the client is using semi-seamless or switch host migration. After migration the target client has never

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-25 Thread Aurelien Jarno
On Sat, Nov 24, 2012 at 09:39:35AM -0800, Richard Henderson wrote: In addition to better compile-time detection, perform runtime detection. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/i386/tcg-target.c | 34 +- tcg/i386/tcg-target.h | 5 -

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Andreas Färber
Am 25.11.2012 10:10, schrieb Avi Kivity: On 09/19/2012 02:50 PM, Julien Grall wrote: This is the tenth version of patch series about ioport registration. Some part of QEMU still use register_ioport* functions to register ioport. These functions doesn't allow to use Memory Listener on it.

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Avi Kivity
On 11/25/2012 05:01 PM, Andreas Färber wrote: Note that there are still some register_ioport_*() usages left: $ git grep register_ioport -- hw/ | grep -v isa_register_ioport | wc --lines 32 For the record, my plan for when that number drops to zero was to use address_space_rw() (or

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Jan Kiszka
On 2012-11-25 16:40, Avi Kivity wrote: On 11/25/2012 05:01 PM, Andreas Färber wrote: Note that there are still some register_ioport_*() usages left: $ git grep register_ioport -- hw/ | grep -v isa_register_ioport | wc --lines 32 For the record, my plan for when that number drops to zero

Re: [Qemu-devel] [PATCH for 1.3] target-i386: enable SSSE3 TCG support

2012-11-25 Thread Andreas Färber
Am 24.11.2012 15:07, schrieb Aurelien Jarno: SSSE3 support has been added to TCG more than 4 years ago in commit 4242b1bd8acc19cffdaad4ac23213d72a72b. It has been disabled by mistake in commit 551a2dec8fa55006a68393b9d6fb63577d2b3f1c. Signed-off-by: Aurelien Jarno aurel...@aurel32.net

Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing flags to Haswell CPU model

2012-11-25 Thread Andreas Färber
Am 22.11.2012 16:31, schrieb Eduardo Habkost: When adding the Haswell CPU model, I intended to make it a superset of the features present on the SandyBridge model, but I have removed the SEP and RDTSCP features from the feature list by mistake. This patch adds the missing SEP and RDTSCP

Re: [Qemu-devel] [RFC] target-i386: register a class for each CPU model

2012-11-25 Thread Andreas Färber
Am 12.11.2012 22:48, schrieb Eduardo Habkost: This creates the following class hierarchy: - TYPE_X86_CPU (arch-cpu) - TYPE_X86_DEFCPU arch-cpu-predefined: abstract base class for the predefined CPU models - arch-cpu-model-model: a class for each predefined CPU model -

[Qemu-devel] [PATCH for-1.3?] i8259: Fix PIC_COMMON() macro

2012-11-25 Thread Andreas Färber
It used a wrong struct type name since its introduction in 8f04ee0882aec9fe91fb70f767edf5dacff59835 (isa: pic: convert to QEMU Object Model), apparently it is unused so far. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8259_internal.h |2 +- 1 Datei geändert, 1 Zeile

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-25 Thread Tim Penhey
Peter, if you try to run the cmake file for lp:unity you should hit it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-static Status in QEMU: New Status

Re: [Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-25 Thread Peter Maydell
On 25 November 2012 20:40, Tim Penhey tim.pen...@canonical.com wrote: Peter, if you try to run the cmake file for lp:unity you should hit it. I'm afraid that's way too little detail. Assume I know nothing about launchpad, cmake or unity, and give me a set of instructions I can run on a machine

[Qemu-devel] [PATCH v7 02/10] vl: fix -hdachs/-hda argument order parsing issues

2012-11-25 Thread Matthew Ogilvie
Without this patch, the -hdachs argument had to occur either BEFORE the corresponding -hda option, or AFTER the plain disk image name (if neither -hda nor -drive is used). Otherwise it would effectively be ignored. Option -hdachs still has no effect on -drive, but that seems best.

[Qemu-devel] [PATCH v7 03/10] qemu-options.hx: mention retrace= VGA option

2012-11-25 Thread Matthew Ogilvie
The feature was added in commit cb5a7aa8c32141bb Sep 2008. My description is based on Better VGA retrace emulation (needed for some DOS games/demos) from http://www.boblycat.org/~malc/code/patches/qemu/index.html Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- qemu-options.hx | 8

[Qemu-devel] [PATCH v7 04/10] vga: add some optional CGA compatibility hacks

2012-11-25 Thread Matthew Ogilvie
This patch adds some optional compatibility hacks (default disabled) to allow Microport UNIX to function under qemu. I've tried to structure it to be easy to add more hacks for other old CGA programs, if anyone ever needs them. Microport UNIX System V/386 v 2.1 (ca 1987) tries to program the CGA

[Qemu-devel] [PATCH v7 09/10] i8254: prepare for migration compatibility with future fixes

2012-11-25 Thread Matthew Ogilvie
Under normal operation this patch should have no effect. But it adds some redundant (no-change) calls to qemu_set_irq(), so that if a running host image is migrated from a future version of qemu that has various fixes to the i8254 output line logic, this version can still deliver exactly the

[Qemu-devel] [PATCH v7 10/10] FOR FUTURE: fix i8254/i8259 IRQ0 line logic

2012-11-25 Thread Matthew Ogilvie
This patch fixes i8254 output line logic to match the spec, and eliminates compatibility logic that was added as a transition strategy for fixing the i8254 without breaking migration. Tentatively, the idea is to apply this patch sometime in the distant future (years from now?) after versions of

[Qemu-devel] [PATCH v7 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-11-25 Thread Matthew Ogilvie
This series makes a series of mostly-unrelated fixes to allow running an old Microport UNIX (ca 1987) guest under qemu. Changes since version 6: * Patches 1 through 6 haven't changed, other than resolving a couple of simple conflicts. * Patch 7 fixes IRQ0 by just making it work like

[Qemu-devel] [PATCH v7 05/10] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-11-25 Thread Matthew Ogilvie
Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or goes away unhandled. So the only difference between edge triggered and level triggered is in

[Qemu-devel] [PATCH v7 07/10] i8254/i8259: workaround to make IRQ0 work like before

2012-11-25 Thread Matthew Ogilvie
Someday it should be fixed properly, but doing so may break migration. So go with an incremental approach instead. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/i8259.c | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/hw/i8259.c

[Qemu-devel] [PATCH v7 08/10] i8254: add comments about fixing timings

2012-11-25 Thread Matthew Ogilvie
There may be risk of problems with migration if these are just fixed blindly, but at least comment what it ought to be changed to. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/i8254.c| 31 ++- hw/i8254_common.c | 40

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-25 Thread Julien Grall
On Sun, Nov 25, 2012 at 3:01 PM, Andreas Färber afaer...@suse.de wrote: Thanks, queued for the v1.4 merge window: https://github.com/afaerber/qemu-cpu/commits/memory-ioport Julien: When pinging a patch series, please make sure it actually still applies. This needed to be rebased both onto

[Qemu-devel] [PATCH v7 01/10] fix some debug printf format strings

2012-11-25 Thread Matthew Ogilvie
These are normally ifdefed out and don't matter. But if you enable them, they ought to be correct. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/cirrus_vga.c | 4 ++-- hw/i8259.c | 3 ++- hw/ide/cmd646.c | 5 +++-- hw/ide/via.c| 5 +++-- 4 files changed, 10

[Qemu-devel] [PATCH v7 06/10] i8259: refactor pic_set_irq level logic

2012-11-25 Thread Matthew Ogilvie
No change in functionality. Clarify that the only difference between level triggered and edge triggered interrupts is on the leading edge. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/i8259.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-)

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-25 Thread David Gibson
On Fri, Nov 23, 2012 at 04:01:58PM +0200, Michael S. Tsirkin wrote: On Fri, Nov 23, 2012 at 02:44:15PM +0100, Alexander Graf wrote: On 23.11.2012, at 14:44, Michael S. Tsirkin wrote: On Fri, Nov 23, 2012 at 11:59:51PM +1100, David Gibson wrote: Look, even if solution using a

[Qemu-devel] [RFC 12/34] i8259: QOM cleanups

2012-11-25 Thread Andreas Färber
Eliminate DO_UPCAST() for PICCommonState. Prepares for ISA realizefn. Also give the i8259_common type registration functions unique names while at it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8259.c | 18 ++ hw/i8259_common.c | 10 +-

[Qemu-devel] [RFC 18/34] pc: QOM'ify port 92

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pc.c | 16 ++-- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/hw/pc.c b/hw/pc.c index 5fc2076..e878106

[Qemu-devel] [RFC 13/34] ide: QOM'ify ISA IDE

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Add missing braces. Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ide/isa.c | 41 + 1 Datei geändert, 25 Zeilen hinzugefügt(+), 16 Zeilen entfernt(-)

[Qemu-devel] [RFC 34/34] i8259: Convert PICCommonState to use QOM realizefn

2012-11-25 Thread Andreas Färber
Instead of having the parent provide PICCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility of saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori

[Qemu-devel] [RFC 26/34] vmport: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Drop reserved underscore from struct name while at it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/vmport.c | 14 +- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen

[Qemu-devel] [RFC 31/34] i8254: Convert PITCommonState to QOM realizefn

2012-11-25 Thread Andreas Färber
Instead of having the parent provide PITCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility for saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori

[Qemu-devel] [RFC 25/34] vmmouse: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST() and container_of(). Prepares for ISA realizefn. Remove reserved underscore from struct name while at it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/vmmouse.c | 16 ++-- 1 Datei geändert, 10 Zeilen

[Qemu-devel] [RFC 02/34] qbus: QOM'ify qbus_realize()

2012-11-25 Thread Andreas Färber
Add the designated Error-reporting argument, even if currently unused. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/qdev.c |6 +++--- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/hw/qdev.c b/hw/qdev.c index c2d9b48..e7c9493 100644 --- a/hw/qdev.c +++

[Qemu-devel] [RFC 09/34] fdc: QOM'ify ISA floppy controller

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Reuse type constant for PC machine compatibility settings. Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Markus Armbruster arm...@redhat.com --- hw/fdc.c | 23 +-- hw/fdc.h

[Qemu-devel] [RFC 29/34] i8254: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and avoid DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8254.c |6 +++--- hw/i8254.h |4 +++- 2 Dateien geändert, 6 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/i8254.c b/hw/i8254.c index

[Qemu-devel] [RFC 21/34] sb16: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/sb16.c | 16 +--- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/hw/sb16.c b/hw/sb16.c index

[Qemu-devel] [RFC 16/34] ne2000-isa: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ne2000-isa.c | 12 1 Datei geändert, 8 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/ne2000-isa.c b/hw/ne2000-isa.c

[Qemu-devel] [RFC 32/34] i8259: QOM'ify some more

2012-11-25 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8259.c | 23 ++- 1 Datei geändert, 14 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/i8259.c b/hw/i8259.c index 55c2cb9..e03db77 100644 ---

[Qemu-devel] [RFC 04/34] qdev: Prepare realized property

2012-11-25 Thread Andreas Färber
Based on earlier patches by Paolo and me, introduce the QOM realizefn at device level only, as requested by Anthony. For now this just wraps the qdev initfn. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori anth...@codemonkey.ws

[Qemu-devel] [RFC 27/34] wdt_ib700: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/wdt_ib700.c | 14 +- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/hw/wdt_ib700.c b/hw/wdt_ib700.c

[Qemu-devel] [RFC 06/34] applesmc: QOM'ify

2012-11-25 Thread Andreas Färber
Add a typedef for the state struct and rename from Status to State. Add type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/applesmc.c | 35 --- 1 Datei geändert, 20 Zeilen

[Qemu-devel] [RFC 00/34] QOM realize, device-only plus ISA conversion

2012-11-25 Thread Andreas Färber
Hello Anthony and Paolo, As announced at KVM Forum, I have been preparing a new approach to incrementally get us Anthony's QOM realizefn concept. A previous attempt by Paolo and me had been turned down for making this available at Object-level and over questions whether BlockDriverState may need

[Qemu-devel] [PATCH 11/34] i8259: Fix PIC_COMMON() macro

2012-11-25 Thread Andreas Färber
It used a wrong struct type name since its introduction in 8f04ee0882aec9fe91fb70f767edf5dacff59835 (isa: pic: convert to QEMU Object Model), apparently it is unused so far. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8259_internal.h |2 +- 1 Datei geändert, 1 Zeile

[Qemu-devel] [RFC 19/34] pckbd: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pckbd.c | 18 -- 1 Datei geändert, 12 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/hw/pckbd.c b/hw/pckbd.c index

[Qemu-devel] [RFC 10/34] i82374: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i82374.c | 12 1 Datei geändert, 8 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/i82374.c b/hw/i82374.c index

[Qemu-devel] [PATCH 01/34] qdev: Eliminate qdev_free() in favor of QOM

2012-11-25 Thread Andreas Färber
qdev_free() was trivially wrapping object_delete(). Inline it and drop the wrapper as a further step to QOM'ify qdev. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Paolo Bonzini pbonz...@redhat.com --- hw/acpi_piix4.c |2 +- hw/pci-hotplug.c |2 +- hw/pci_bridge.c |

[Qemu-devel] [PATCH] virtio-scsi: Fix subtle (guest) endian bug

2012-11-25 Thread David Gibson
The virtio-scsi config space is, by specification, in guest endian (which is ill-defined, but there you go). In virtio_scsi_get_config() we set up all the fields in there, using stl_raw(). Which is a problem for the max_channel and max_target fields, which are 16-bit, not 32-bit. For

[Qemu-devel] [RFC 05/34] isa: Split off instance_init for ISADevice

2012-11-25 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- hw/isa-bus.c | 14 ++ 1 Datei geändert, 10 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/isa-bus.c b/hw/isa-bus.c index 144a88e..2b1fc40 100644 --- a/hw/isa-bus.c +++ b/hw/isa-bus.c @@ -124,9 +124,6 @@ static int

[Qemu-devel] [RFC 03/34] qdev: Fold state enum into bool realized

2012-11-25 Thread Andreas Färber
Whether the device was initialized or not is QOM-level information and currently unused. Drop it from qdev. This leaves the boolean state of whether or not DeviceClass::init was called or not, a.k.a. realized. Suggested-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Andreas Färber

[Qemu-devel] [RFC 30/34] kvm/i8254: QOM'ify some more

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i8254.h |3 ++- hw/kvm/i8254.c | 21 - 2 Dateien geändert, 14 Zeilen hinzugefügt(+), 10 Zeilen entfernt(-) diff --git

[Qemu-devel] [RFC 28/34] isa: Use realizefn for ISADevice

2012-11-25 Thread Andreas Färber
Drop ISADeviceClass::init and the resulting no-op initfn and let children implement their own realizefn. Adapt error handling. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/applesmc.c | 10 -- hw/cirrus_vga.c | 10 +- hw/debugcon.c | 21

[Qemu-devel] [RFC 14/34] m48t59: QOM'ify ISA M48T59 NVRAM

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST() and container_of(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/m48t59.c | 37 ++--- 1 Datei geändert, 22 Zeilen hinzugefügt(+), 15 Zeilen entfernt(-) diff

[Qemu-devel] [RFC 17/34] parallel: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/parallel.c | 13 + 1 Datei geändert, 9 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/parallel.c b/hw/parallel.c index

[Qemu-devel] [RFC 20/34] pcspk: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/pcspk.c | 11 +++ hw/pcspk.h |4 +++- 2 Dateien geändert, 10 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git a/hw/pcspk.c

[Qemu-devel] [RFC 15/34] mc146818rtc: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/mc146818rtc.c | 38 +- hw/mc146818rtc.h |2 ++ 2 Dateien geändert, 23 Zeilen hinzugefügt(+), 17 Zeilen

[Qemu-devel] [RFC 33/34] kvm/i8259: QOM'ify some more

2012-11-25 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/kvm/i8259.c |8 +--- 1 Datei geändert, 5 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/hw/kvm/i8259.c b/hw/kvm/i8259.c index 2aaf14a..973cc08 100644 ---

[Qemu-devel] [RFC 07/34] cirrus_vga: QOM'ify ISA Cirrus VGA

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/cirrus_vga.c | 17 +++-- 1 Datei geändert, 11 Zeilen hinzugefügt(+), 6 Zeilen entfernt(-) diff --git a/hw/cirrus_vga.c

Re: [Qemu-devel] [RFC PATCH v5 4/4] free the memory malloced by load_at()

2012-11-25 Thread Yin Olivia-R63875
Hi Stuart Alex, syms and str could not be free since symbols is a global variable which need stay in the memory during the whole life of VM. So it will not be free and reload when reset. The only change is to the previous patch of elf loader (hw/elf_ops.h) as below: @@ -232,7 +235,9 @@ static

[Qemu-devel] [RFC 22/34] serial: QOM'ify ISA serial

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/serial-isa.c | 13 - hw/serial.h |1 + 2 Dateien geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen entfernt(-) diff --git

[Qemu-devel] [RFC 24/34] vga-isa: QOM'ify ISA VGA

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST() and container_of(). Prepares for ISA realizefn. Unify function naming scheme while at it. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/vga-isa.c | 29 + 1 Datei geändert, 17 Zeilen

[Qemu-devel] [RFC 23/34] sga: QOM'ify

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro. Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/sga.c | 12 1 Datei geändert, 8 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/sga.c b/hw/sga.c index a666349..d828f45 100644 --- a/hw/sga.c +++

[Qemu-devel] [RFC 08/34] debugcon: QOM'ify ISA debug console

2012-11-25 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for ISA realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/debugcon.c | 13 + 1 Datei geändert, 9 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/hw/debugcon.c b/hw/debugcon.c index

Re: [Qemu-devel] qemu-system-arm v1.3.0-rc0 / 1.2.1 freeze on OSX 10.8.2

2012-11-25 Thread Pi LFS
On Sun, Nov 25, 2012 at 5:51 AM, Peter Maydell peter.mayd...@linaro.orgwrote: You need to give more detail -- what is the command line you are running, the kernel / image you are trying to run, etc, have you confirmed that that kernel/image/commandline work ok on a Linux QEMU and it's not

Re: [Qemu-devel] [PATCH 0/5] TCG global gen_opc_ arrays clean-up

2012-11-25 Thread Evgeny Voevodin
On 11/21/2012 11:43 AM, Evgeny Voevodin wrote: This set of patches moves global variables to tcg_ctx: gen_opc_instr gen_opparam_icount gen_opc_pc Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was aplied, I noticed no speed-up or slow-down of code

Re: [Qemu-devel] [PATCH for 1.3] pflash_cfi01: Suppress warning when Linux probes for AMD flash

2012-11-25 Thread walimis
On Sat, Nov 24, 2012 at 11:03:13PM +0100, Stefan Weil wrote: There are several ARM and MIPS boards which are manufactured with either Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory. The Linux kernel supports both and first probes for AMD flash which resulted in one or two warnings

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-25 Thread Dietmar Maurer
Which raises the question of how to distinguish whether it's a new request to bs that must go through the filters or whether it actually comes from the last filter in the chain. As you can see, we don't have a well thought out plan yet, just rough ideas (otherwise it would probably be

Re: [Qemu-devel] [PATCH for 1.3] pflash_cfi01: Suppress warning when Linux probes for AMD flash

2012-11-25 Thread Stefan Weil
Am 26.11.2012 06:31, schrieb walimis: On Sat, Nov 24, 2012 at 11:03:13PM +0100, Stefan Weil wrote: There are several ARM and MIPS boards which are manufactured with either Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory. The Linux kernel supports both and first probes for AMD flash

Re: [Qemu-devel] [PATCH] exec.c: Use tb1-phys_hash_next directly in tb_remove

2012-11-25 Thread Wei-Ren Chen
On Sun, Nov 25, 2012 at 10:47:00AM +, Peter Maydell wrote: On 25 November 2012 07:50, 陳韋任 (Wei-Ren Chen) che...@iis.sinica.edu.tw wrote: ping? This is v1 of the patch, you've sent a v2 and should be pinging that instead... Also (a) it won't go in before 1.3 release now so not much

Re: [Qemu-devel] [PATCH 01/34] qdev: Eliminate qdev_free() in favor of QOM

2012-11-25 Thread Paolo Bonzini
Il 26/11/2012 01:12, Andreas Färber ha scritto: qdev_free() was trivially wrapping object_delete(). Inline it and drop the wrapper as a further step to QOM'ify qdev. The reference counts of devices and buses are completely disconnected from reality, and that's why object_delete() works. I'd

Re: [Qemu-devel] [PATCH] virtio-scsi: Fix subtle (guest) endian bug

2012-11-25 Thread Paolo Bonzini
Il 26/11/2012 02:33, David Gibson ha scritto: The virtio-scsi config space is, by specification, in guest endian (which is ill-defined, but there you go). In virtio_scsi_get_config() we set up all the fields in there, using stl_raw(). Which is a problem for the max_channel and max_target

Re: [Qemu-devel] [PATCH V11 4/7] libqblock build system

2012-11-25 Thread Paolo Bonzini
Il 24/11/2012 10:27, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is old ones used in qemu, second and

Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset

2012-11-25 Thread Jens Freimann
On Fri, Nov 23, 2012 at 03:32:16PM +0100, Christian Borntraeger wrote: On 23/11/12 14:40, Alexander Graf wrote: On 23.11.2012, at 11:18, Jens Freimann wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a

Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset

2012-11-25 Thread Jens Freimann
On Fri, Nov 23, 2012 at 02:40:10PM +0100, Alexander Graf wrote: On 23.11.2012, at 11:18, Jens Freimann wrote: When resetting vcpus on s390/kvm we have to clear registers, psw and prefix as described in the z/Architecture PoP, otherwise a reboot won't work. IPL PSW and prefix are set