[Qemu-devel] [RFC PATCH v6 3/4] use elf_reset to reload elf image

2012-11-26 Thread Olivia Yin
Signed-off-by: Olivia Yin --- elf.h| 10 ++ hw/elf_ops.h | 44 +++- hw/loader.c | 11 +++ 3 files changed, 60 insertions(+), 5 deletions(-) diff --git a/elf.h b/elf.h index a21ea53..335f1af 100644 --- a/elf.h +++ b/elf.h @@ -

[Qemu-devel] [RFC PATCH v6 4/4] free rom->data when rom_reset

2012-11-26 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/loader.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index d075ed3..2dde6ba 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -752,11 +752,8 @@ static void rom_reset(void *unused) continue;

[Qemu-devel] [RFC PATCH v6 2/4] use uimage_reset to reload uimage

2012-11-26 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/loader.c | 57 + hw/loader.h |6 ++ 2 files changed, 51 insertions(+), 12 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index e45f56a..0d93c3b 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -4

[Qemu-devel] [RFC PATCH v6 1/4] use image_file_reset to reload initrd

2012-11-26 Thread Olivia Yin
Signed-off-by: Olivia Yin --- hw/loader.c | 39 +++ hw/loader.h |6 ++ 2 files changed, 45 insertions(+), 0 deletions(-) diff --git a/hw/loader.c b/hw/loader.c index ba01ca6..e45f56a 100644 --- a/hw/loader.c +++ b/hw/loader.c @@ -86,6 +86,39 @@ int l

[Qemu-devel] [RFC PATCH v6 0/4] reload images from host rootfs on reset to save footprint

2012-11-26 Thread Olivia Yin
The current model of loader copy "rom blobs" and kept in memory until a reset occurs and waste host memory. This serial of patches uses private reset handlers to load uimage/initrd/vmlinux from hard disk on reset, which could make loader framework more dynamic and reduce the memory consumption of

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-26 Thread Dietmar Maurer
> > The only solution I came up with is to add before/after hooks in the > > block job. I agree with the criticism, but I think it's general > > enough and at the same time easy enough to implement. > > > > > IMHO, the current implementation is quite simple and easy to maintain. > > > > No, "if (b

Re: [Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
On Mon, Nov 26, 2012 at 05:35:07PM -0800, Will Auld wrote: > In order to track who initiated the call (host or guest) to modify an msr > value I have changed function call parameters along the call path. The > specific change is to add a struct pointer parameter that points to (index, > data, calle

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-11-26 Thread Gleb Natapov
On Mon, Nov 26, 2012 at 09:46:12PM -0200, Marcelo Tosatti wrote: > On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote: > > > > > > > -Original Message- > > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > > > Sent: Tuesday, November 20, 2012 5:41 AM > > > To: P

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-26 Thread Dietmar Maurer
> The only solution I came up with is to add before/after hooks in the block > job. I agree with the criticism, but I think it's general enough and at the > same > time easy enough to implement. > > > IMHO, the current implementation is quite simple and easy to maintain. > > No, "if (bs->backup

[Qemu-devel] [0/2] pseries: Rework PCI code for handling multiple PHBs

2012-11-26 Thread David Gibson
Hi Michael, Alex, This patch represents a compromise I hope will be acceptable after the long thread discussing handling of multiple PCI host bridges on the pseries machine. Patch 1/1 is just a preliminary enforcing uniqueness of LIOBNs in the IOMMU code. Patch 2/2 is the meat. It allows either

[Qemu-devel] [PATCH 2/2] pseries: Properly handle allocation of multiple PCI host bridges

2012-11-26 Thread David Gibson
From: Alexey Kardashevskiy Multiple - even many - PCI host bridges (i.e. PCI domains) are very common on real PAPR compliant hardware. For reasons related to the PAPR specified IOMMU interfaces, PCI device assignment with VFIO will generally require at least two (virtual) PHBs and possibly more

[Qemu-devel] [PATCH 1/2] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs

2012-11-26 Thread David Gibson
The PAPR specification requires that every bus or device mediated by the IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check to enforce this, which will help catch errors in configuration earlier. Signed-off-by: David Gibson --- hw/spapr_iommu.c |6 ++ 1 file chan

[Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro

2012-11-26 Thread Lei Li
As step behind Paolo's fix for RHBZ#879657 and according to the current fix in Commit b5007bc (hmp: do not crash on invalid SCSI hotplug), the macro SCSI_BUS has already been replaced to object_dynamic_cast which has been improved when try to cast to NULL value and it is also what DO_UPCAST macro d

[Qemu-devel] [PATCH V5] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to the hypervisor vcpu specific locations to store the value of the emulated MSRs. In this way the IA32_TSC_ADJUST value will be included in all reads to the TSC MSR w

Re: [Qemu-devel] MIPS exception number limits?

2012-11-26 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of ??? (Wei-Ren Chen) > Sent: Thursday, November 22, 2012 11:34 AM > To: qemu-devel@nongnu.org > Subject: [Qemu-devel] MIPS exception number limits? >

Re: [Qemu-devel] [PATCH] cocoa: Fix VBE function Set Display Start

2012-11-26 Thread Andreas Färber
Am 21.11.2012 20:08, schrieb Henry Harrington: > Register a dpy_gfx_setdata callback so that the Cocoa code > is notified whenever the screen start address changes. > > Signed-off-by: Henry Harrington > --- > ui/cocoa.m | 18 ++ > 1 files changed, 18 insertions(+), 0 deletions(

[Qemu-devel] buildbot failure in qemu on default_i386_macosx

2012-11-26 Thread qemu
The Buildbot has detected a new failure on builder default_i386_macosx while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_macosx/builds/27 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: MacOSX-10.5 Build Re

Re: [Qemu-devel] [PATCH V4] target-i386: Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-11-26 Thread Andreas Färber
Am 27.11.2012 03:29, schrieb Will Auld: > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported > > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated MSRs. > In this way the IA32_TSC_ADJUST va

Re: [Qemu-devel] [PATCH V11 6/7] libqblock API implement

2012-11-26 Thread Wenchao Xia
> Il 24/11/2012 10:27, Wenchao Xia ha scritto: This patch contains implemention for APIs. Important APIs: 1 QBlockContext. This structure was used to retrieve errors, every thread must create one first. 2 QBlockImage. It stands for an block image object. 3 QBlockStaticInfo. It contain

Re: [Qemu-devel] [PATCH V11 4/7] libqblock build system

2012-11-26 Thread Wenchao Xia
于 2012-11-26 15:36, Paolo Bonzini 写道: Il 24/11/2012 10:27, Wenchao Xia ha scritto: Libqblock was placed in new directory ./libqblock, libtool will build dynamic library there, source files of block layer remains in ./block. So block related source code will generate 3 sets of binary, first is

Re: [Qemu-devel] [PATCH 2/5] semaphore: implement fallback counting semaphores with mutex+condvar

2012-11-26 Thread Brad Smith
On Sun, Nov 18, 2012 at 05:06:40PM +0100, Paolo Bonzini wrote: > Il 18/11/2012 10:09, Brad Smith ha scritto: > > On 11/02/12 09:14, Paolo Bonzini wrote: > >> OpenBSD and Darwin do not have sem_timedwait. Implement a fallback > >> for them. > >> > >> Signed-off-by: Paolo Bonzini > >> --- > >> qe

Re: [Qemu-devel] [PATCH v4 2/2] qemu-ga: sample fsfreeze hooks

2012-11-26 Thread Tomoki Sekiyama
On 2012/11/26 21:40, Luiz Capitulino wrote: > On Mon, 26 Nov 2012 20:49:17 +0900 > Tomoki Sekiyama wrote: > >> On 2012/11/23 1:03, Luiz Capitulino wrote: >>> On Thu, 22 Nov 2012 11:15:49 +0900 >>> Tomoki Sekiyama wrote: >>> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >>

[Qemu-devel] [PATCH V4] target-i386: Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to the hypervisor vcpu specific locations to store the value of the emulated MSRs. In this way the IA32_TSC_ADJUST value will be included in all reads to the TSC MSR w

Re: [Qemu-devel] [RFC PATCH v5 4/4] free the memory malloced by load_at()

2012-11-26 Thread Yin Olivia-R63875
I added parameter 'reset' into the original load_elf32/64() in patch 3/4. Reserve the most lines and rename this function as elf_phy_loader32/64(). -static int glue(load_elf, SZ)(const char *name, int fd, +static int glue(elf_phy_loader, SZ)(const char *name, int fd,

Re: [Qemu-devel] [PATCH V3] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-26 Thread Auld, Will
Sorry, let me figure this out and resend. Thanks, Will > -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Andreas Färber > Sent: Monday, November 26, 2012 5:51 PM > To: Auld, Will > Cc: Will Auld; qemu-devel; Gleb; mtosa...@redhat.com

Re: [Qemu-devel] [PATCH V3] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-26 Thread Andreas Färber
Am 27.11.2012 02:40, schrieb Will Auld: > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported > > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated MSRs. > In this way the IA32_TSC_ADJUST va

Re: [Qemu-devel] [PATCH V2] Resend - Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-26 Thread Auld, Will
Andreas, Thanks. I just sent the update patch (V3) to address your comments. Will > -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Andreas Färber > Sent: Monday, November 26, 2012 11:05 AM > To: Auld, Will > Cc: Will Auld; qemu-de

[Qemu-devel] [PATCH V3] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to the hypervisor vcpu specific locations to store the value of the emulated MSRs. In this way the IA32_TSC_ADJUST value will be included in all reads to the TSC MSR w

[Qemu-devel] [PATCH V4 2/2] Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to a guest vcpu specific location to store the value of the emulated MSR while adding the value to the vmcs tsc_offset. In this way the IA32_TSC_ADJUST value will be i

[Qemu-devel] [PATCH V4 1/2] Add code to track call origin for msr assignment.

2012-11-26 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as indivi

[Qemu-devel] [PATCH V4 0/2] Enable guest use of TSC_ADJUST functionality

2012-11-26 Thread Will Auld
This reversion, V4, addresses a couple of issues I missed from Gleb and Marcelo. Thanks, Will Will Auld (2): Add code to track call origin for msr assignment. Enabling IA32_TSC_ADJUST for KVM guest VM support arch/x86/include/asm/cpufeature.h | 1 + arch/x86/include/asm/kvm_host.h | 15

Re: [Qemu-devel] [PATCH V10 0/8] memory: unify ioport registration

2012-11-26 Thread Andreas Färber
Am 26.11.2012 15:25, schrieb Gerd Hoffmann: > On 11/25/12 16:01, Andreas Färber wrote: >> Am 25.11.2012 10:10, schrieb Avi Kivity: >>> On 09/19/2012 02:50 PM, Julien Grall wrote: This is the tenth version of patch series about ioport registration. Some part of QEMU still use register

[Qemu-devel] [PATCH] qdev: Rename unparenting callback

2012-11-26 Thread Andreas Färber
In commit 667d22d1ae59da46b4c1fbd094ca61145f19b8c3 (qdev: move bus removal to object_unparent) a certain reviewer missed that a private qdev_remove_from_bus() function was introduced in midst new-style device_*() functions... Fix this. Signed-off-by: Andreas Färber Cc: Paolo Bonzini Cc: Anthony

Re: [Qemu-devel] [PATCH 1.3 2/5] qdev: move bus removal to object_unparent

2012-11-26 Thread Andreas Färber
Am 23.11.2012 09:47, schrieb Paolo Bonzini: > diff --git a/hw/qdev.c b/hw/qdev.c > index 7ddcd24..f43717b 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c [...] > @@ -720,6 +717,18 @@ static void device_class_base_init(ObjectClass *class, > void *data) > klass->props = NULL; > } > > +static void

[Qemu-devel] [ANNOUNCE] QEMU 1.3.0-rc1 is out!

2012-11-26 Thread anthony
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate for the QEMU 1.3 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.3.0-rc1.tar.bz2 You can help improv

Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport*

2012-11-26 Thread Andreas Färber
Am 19.09.2012 13:50, schrieb Julien Grall: > This patch replaces all register_ioport* by a MemorySection. > It permits to use the new Memory stuff like listener. > > Moreover, the PCI is added as an argument for apm_init, so we > can register IO inside the pci IO address space. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/4] AER-KVM: Error containment of PCI pass-thru devices assigned to KVM guests

2012-11-26 Thread Marcelo Tosatti
On Tue, Nov 20, 2012 at 02:09:46PM +, Pandarathil, Vijaymohan R wrote: > > > > -Original Message- > > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > > Sent: Tuesday, November 20, 2012 5:41 AM > > To: Pandarathil, Vijaymohan R > > Cc: k...@vger.kernel.org; linux-...@vger.kernel.or

[Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2012-11-26 Thread qemu
The Buildbot has detected a new failure on builder default_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_i386_debian_6_0/builds/462 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki Buil

Re: [Qemu-devel] X-Window under Mac OSX

2012-11-26 Thread Andreas Färber
Am 26.11.2012 19:11, schrieb Loreley Giraudon: > On Nov 26, 2012, at 7:02 AM, Andreas Färber > wrote: >> Am 26.11.2012 02:31, schrieb Loreley Giraudon: >>> im trying to initiate the following command: >>> >>> kvm -hda mysql.img -m 256 -monitor stdio -cdrom >>> debian

Re: [Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2012-11-26 Thread Anthony Liguori
q...@buildbot.b1-systems.de writes: > The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 > while building qemu. > Full details are available at: > > http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/462 > > Buildbot URL: http://buildbot.b1-sy

[Qemu-devel] buildbot failure in qemu on default_x86_64_debian_6_0

2012-11-26 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_debian_6_0/builds/462 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH] vnc: fix option misspelling ("non-adapative" -> "non-adaptive")

2012-11-26 Thread Anthony Liguori
Catalin Patulea writes: > Signed-off-by: Catalin Patulea > --- > A cursory web search shows that this flag doesn't show up much other than in > QEMU mailing lists and source. I don't think this will break anything. > Applied. Thanks. Regards, Anthony Liguori > ui/vnc.c |2 +- > 1 files c

Re: [Qemu-devel] [PATCH for-1.3] vl.c: Fix broken -usb option

2012-11-26 Thread Anthony Liguori
Peter Maydell writes: > Commit 094b287f0b accidentally broke the "-usb" command line > option, so it would have no effect if the user had not specified > any machine options at that point. (the return value from > 'qemu_opts_find(qemu_find_opts("machine"), 0);' is NULL if there > are no user spec

Re: [Qemu-devel] [PATCH 1.3] aio: avoid livelock behavior for Win32

2012-11-26 Thread Anthony Liguori
Paolo Bonzini writes: > The repeated calls to WaitForMultipleObjects may cause a livelock in aio_poll, > where no progress is made on bottom halves. This patch matches the behavior > of the POSIX code. > > Signed-off-by: Paolo Bonzini > --- > Found by the new unit tests. Applied. Thank

Re: [Qemu-devel] [PATCH 1.3? 0/2] AioContext and thread pool unit tests

2012-11-26 Thread Anthony Liguori
Paolo Bonzini writes: > As requested. :) The tests pass on both Linux and Wine. > > I'm not sure if it makes sense to include these in 1.3, but the idea > has some worth. > Applied. Thanks. Regards, Anthony Liguori > Paolo Bonzini (2): > tests: add AioContext unit tests > tests: add thre

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-26 Thread Paul Moore
On Monday, November 26, 2012 03:41:00 PM Paul Moore wrote: > On Monday, November 26, 2012 02:59:21 PM Corey Bryant wrote: > > On 11/26/2012 12:08 PM, Paul Moore wrote: > > > On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: > > >> On 11/21/2012 10:24 AM, Paul Moore wrote: > > >>> On Wedn

Re: [Qemu-devel] [PATCH] chardev: Use real-time clock for open timer

2012-11-26 Thread Anthony Liguori
Jan Kiszka writes: > The vm clock may be stopped, and then we won't get open events anymore. > Seen with QMP sessions. > > Reported-by: Dietmar Maurer > Tested-by: Luiz Capitulino > Signed-off-by: Jan Kiszka Applied. Thanks. Regards, Anthony Liguori > --- > qemu-char.c |4 ++-- > 1 fi

Re: [Qemu-devel] [PATCH 1.3 0/2] "drive_add NN if=scsi" fixes

2012-11-26 Thread Anthony Liguori
Paolo Bonzini writes: > Reported by Markus, and a regression from 1.1. Not really SCSI stuff, > just happens to have it in the name, so I'm not sending it through my tree. > > Paolo Bonzini (2): > qom: dynamic_cast of NULL is always NULL > hmp: do not crash on invalid SCSI hotplug > > hw/pc

Re: [Qemu-devel] [PATCH 1.3] qapi: handle visitor->type_size() in QapiDeallocVisitor

2012-11-26 Thread Anthony Liguori
Stefan Hajnoczi writes: > visit_type_size() requires either visitor->type_size() or > visitor_uint64() to be implemented, otherwise a NULL function pointer is > invoked. > > It is possible to trigger this crash as follows: > > $ qemu-system-x86_64 -netdev tap,sndbuf=0,id=netdev0 \ >

Re: [Qemu-devel] [PATCH 1.3 0/5] QOM/qdev lifetime fixes

2012-11-26 Thread Anthony Liguori
Paolo Bonzini writes: > These patches fix problems in the handling of freeing QOM/qdev > objects. Together, they fix hot-unplug of USB mass storage devices, > which crashed with an assertion failure. > > I'm not 100% sure, but I think we were always leaking the scsi-disk in > pre-QOM days. Now

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-26 Thread Paul Moore
On Monday, November 26, 2012 02:59:21 PM Corey Bryant wrote: > On 11/26/2012 12:08 PM, Paul Moore wrote: > > On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: > >> On 11/21/2012 10:24 AM, Paul Moore wrote: > >>> On Wednesday, November 21, 2012 11:20:44 AM Eduardo Otubo wrote: > Hell

Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
On Mon, Nov 26, 2012 at 07:42:28PM +, Auld, Will wrote: > Gleb, Marcelo, > > Sorry Gleb, I did not see comments from you but I have now found them. In > doing so I also found one form Marcelo that I missed. > > What I believe is now outstanding to be addressed are: > >From Gleb: > - You've

Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman

2012-11-26 Thread Alexander Graf
On 26.11.2012, at 21:04, Gerd Hoffmann wrote: > Hi, > >> Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing >> case, so that compilation is fixed. Functionality on such old pixman is a >> different question ;-). > >> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-11-26 Thread Alexander Graf
On 26.11.2012, at 21:01, Gerd Hoffmann wrote: > On 11/26/12 19:42, Alexander Graf wrote: >> Replying here because my INBOX doesn't contain the original message. >> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8) +type = PIXMAN_TYPE_RGBA; +#endif +}

Re: [Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman

2012-11-26 Thread Gerd Hoffmann
Hi, > Guard the PIXMAN_TYPE_BGRA branch like in the case right above the failing > case, so that compilation is fixed. Functionality on such old pixman is a > different question ;-). > +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8) > type = PIXMAN_TYPE_BGRA; > +#endif Vers

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-11-26 Thread Gerd Hoffmann
On 11/26/12 19:42, Alexander Graf wrote: > Replying here because my INBOX doesn't contain the original message. > >>> +#if PIXMAN_VERSION >= PIXMAN_VERSION_ENCODE(0, 21, 8) >>> +type = PIXMAN_TYPE_RGBA; >>> +#endif >>> +} >>> +} else if (rshift < gshift && gshift < bshift)

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-26 Thread Corey Bryant
On 11/26/2012 12:08 PM, Paul Moore wrote: On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: On 11/21/2012 10:24 AM, Paul Moore wrote: On Wednesday, November 21, 2012 11:20:44 AM Eduardo Otubo wrote: Hello folks, Does anyone had a chance to take a look at this? We would like to ge

Re: [Qemu-devel] [PATCH 0/8] qemu-common.h header cleanups

2012-11-26 Thread Andreas Färber
Hi, Am 22.11.2012 18:27, schrieb Eduardo Habkost: > These are the remaining header cleanups that didn't enter the tree yet. They > should help breaking some circular header dependencies involving > qemu-common.h. > > Basically they were reordered by Igor to keep the tree bisectable, and some > c

Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Auld, Will
Gleb, Marcelo, Sorry Gleb, I did not see comments from you but I have now found them. In doing so I also found one form Marcelo that I missed. What I believe is now outstanding to be addressed are: >From Gleb: - You've changed function pointer signature here, but emulator_set_msr() remained th

[Qemu-devel] [PATCH 5/6] vl.c: Fix broken -usb option

2012-11-26 Thread Alexander Graf
From: Peter Maydell Commit 094b287f0b accidentally broke the "-usb" command line option, so it would have no effect if the user had not specified any machine options at that point. (the return value from 'qemu_opts_find(qemu_find_opts("machine"), 0);' is NULL if there are no user specified option

[Qemu-devel] [PATCH 3/6] kvm: fix incorrect length in a loop over kvm dirty pages map

2012-11-26 Thread Alexander Graf
From: Alexey Kardashevskiy QEMU allocates a map enough for 4k pages. However the system page size can be 64K (for example on POWER) and the host kernel uses only a small part of it as one big stores a dirty flag for 16 pages 4K each, the hpratio variable stores this ratio and the kvm_get_dirty_pa

[Qemu-devel] [PATCH 1/2] s390: Fix ram_size updating in machine init

2012-11-26 Thread Alexander Graf
From: Heinz Graalfs The global variable 'ram_size' is hidden by the local variable declaration in s390_init(). Since we want to update the global ram size in certain cases we must not use a local ram_size variable. - This fixes booting with unusual ram sizes like -m 67001 - This changes behaviour

[Qemu-devel] [PULL 1.3 0/2] s390 1.3 patch queue 2012-11-26

2012-11-26 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390 with patches that should go in for 1.3. Please pull. Alex The following changes since commit cab1e8f3e37d8e883c270e3afd9c7c1c18332f0e: Anthony Liguori (1): Merge remote-tracking branch 'qemu-kvm/uq/master' into staging are a

[Qemu-devel] [PATCH 2/2] sclp: Fix uninitialized var in handle_write_event_buf().

2012-11-26 Thread Alexander Graf
From: Cornelia Huck Some gcc versions rightly complain about a possibly unitialized rc, so let's move setting it before the QTAILQ_FOREACH(). Signed-off-by: Cornelia Huck Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann Signed-off-by: Alexander Graf --- hw/s390x/event-facil

Re: [Qemu-devel] [PATCH V2] Resend - Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-11-26 Thread Andreas Färber
Hello, Am 26.11.2012 19:42, schrieb Will Auld: > CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported > > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated MSRs. > In this way the IA32_TSC_A

[Qemu-devel] [PATCH 1/6] hw/ide/macio: Fix segfault caused by NULL DMAContext*

2012-11-26 Thread Alexander Graf
From: Peter Maydell Pass qemu_sglist_init the global dma_context_memory rather than a NULL pointer; this fixes a segfault in dma_memory_map() when the guest starts using DMA. Reported-by: Amadeusz Sławiński Signed-off-by: Peter Maydell Signed-off-by: Alexander Graf --- hw/ide/macio.c |6

[Qemu-devel] [PATCH 2/6] PPC: Fix missing TRACE exception

2012-11-26 Thread Alexander Graf
From: Julio Guerra This patch fixes bug 1031698 : https://bugs.launchpad.net/qemu/+bug/1031698 If we look at the (truncated) translation of the conditional branch instruction in the test submitted in the bug post, the call to the exception helper is missing in the "bne-false" chunk of translated

[Qemu-devel] [PATCH 4/6] pseries: Fix bug in PCI MSI allocation

2012-11-26 Thread Alexander Graf
From: Alexey Kardashevskiy In one of the recent reworks to the XICS code, a bug was introduced where we use the wrong sense and allocate level interrupts instead of message interrupts for PCI MSIs. This patch fixes it. Signed-off-by: Alexey Kardashevskiy Signed-off-by: David Gibson Signed-off

[Qemu-devel] [PATCH 6/6] fbdev: fix pixman compile on old pixman

2012-11-26 Thread Alexander Graf
My QEMU compile failed with the following error: qemu-pixman.c: In function ‘qemu_pixman_get_type’: qemu-pixman.c:24: error: ‘PIXMAN_TYPE_BGRA’ undeclared (first use in this function) qemu-pixman.c:24: error: (Each undeclared identifier is reported only once qemu-pixman.c:24: error: for each func

[Qemu-devel] [PULL 1.3 0/6] ppc 1.3 patch queue 2012-11-26

2012-11-26 Thread Alexander Graf
Hi Blue / Aurelien, This is my patch queue for ppc with patches that should go into 1.3. Please pull. Alex The following changes since commit cab1e8f3e37d8e883c270e3afd9c7c1c18332f0e: Anthony Liguori (1): Merge remote-tracking branch 'qemu-kvm/uq/master' into staging are available in

[Qemu-devel] [PATCH] fbdev: fix pixman compile on old pixman

2012-11-26 Thread Alexander Graf
My QEMU compile failed with the following error: qemu-pixman.c: In function ‘qemu_pixman_get_type’: qemu-pixman.c:24: error: ‘PIXMAN_TYPE_BGRA’ undeclared (first use in this function) qemu-pixman.c:24: error: (Each undeclared identifier is reported only once qemu-pixman.c:24: error: for each func

Re: [Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Gleb Natapov
Comments are still not addressed. On Mon, Nov 26, 2012 at 10:40:51AM -0800, Will Auld wrote: > In order to track who initiated the call (host or guest) to modify an msr > value I have changed function call parameters along the call path. The > specific change is to add a struct pointer parameter t

[Qemu-devel] [PATCH V2] Resend - Enabling IA32_TSC_ADJUST for Qemu KVM guest VMs

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to the hypervisor vcpu specific locations to store the value of the emulated MSRs. In this way the IA32_TSC_ADJUST value will be included in all reads to the TSC MSR w

Re: [Qemu-devel] [PATCH 7/9] fbdev: move to pixman

2012-11-26 Thread Alexander Graf
Replying here because my INBOX doesn't contain the original message. On 18.09.2012, at 21:14, Anthony Liguori wrote: > Gerd Hoffmann writes: > >> Stop reinventing the wheel. Use the pixman library for raster ops. >> >> Signed-off-by: Gerd Hoffmann > > Why not cairo? I already have a cairo

[Qemu-devel] [PATCH V3 2/2] Resend - Enabling IA32_TSC_ADJUST for KVM guest VM support

2012-11-26 Thread Will Auld
CPUID.7.0.EBX[1]=1 indicates IA32_TSC_ADJUST MSR 0x3b is supported Basic design is to emulate the MSR by allowing reads and writes to a guest vcpu specific location to store the value of the emulated MSR while adding the value to the vmcs tsc_offset. In this way the IA32_TSC_ADJUST value will be i

[Qemu-devel] [PATCH V3 1/2] Resend - Add code to track call origin for msr assignment.

2012-11-26 Thread Will Auld
In order to track who initiated the call (host or guest) to modify an msr value I have changed function call parameters along the call path. The specific change is to add a struct pointer parameter that points to (index, data, caller) information rather than having this information passed as indivi

[Qemu-devel] [PATCH V3 0/2] Resend - IA32_TSC_ADJUST support for KVM

2012-11-26 Thread Will Auld
Resending these as the mail seems to have not fully worked last Wed. Marcelo, I have addressed your comments for this patch set (V3), the following patch for QEMU-KVM and for adding a test case for tsc_adjust also to follow today. Thanks, Will Will Auld (2): Add code to track call origin

Re: [Qemu-devel] [BUG] Missing feature, KVM on ARM, dirty page logging.

2012-11-26 Thread Peter Maydell
On 26 November 2012 17:58, Ian Molton wrote: > I'm looking at dirty page logging on KVM on ARM, which appears, at present > to be non-existent. Is anyone working on this, or willing to lend a hand? I've cc'd the kvmarm mailing list to give this a slightly wider airing. > I'm running KVM on an OM

[Qemu-devel] [BUG] Missing feature, KVM on ARM, dirty page logging.

2012-11-26 Thread Ian Molton
Hi folks, I'm looking at dirty page logging on KVM on ARM, which appears, at present to be non-existent. Is anyone working on this, or willing to lend a hand? I'm running KVM on an OMAP5, and my guest is a vexpress-a15 with PL-111 framebuffer. running tcg mode, this works, however in KVM I

[Qemu-devel] Minutes from 2012 QEMU Summit

2012-11-26 Thread Anthony Liguori
Hi, This year at KVM Forum we held the first QEMU Summit. Below are the minutes from this meeting. We plan to make this an annual event so look for more information next year as we plan QEMU Summit 2013. Thanks to everyone who attended and in particular to those that helped pull together the no

Re: [Qemu-devel] [RFC] target-i386: register a class for each CPU model

2012-11-26 Thread Eduardo Habkost
On Sun, Nov 25, 2012 at 08:32:46PM +0100, Andreas Färber wrote: > Am 12.11.2012 22:48, schrieb Eduardo Habkost: > > This creates the following class hierarchy: > > > > - TYPE_X86_CPU ("-cpu") > > - TYPE_X86_DEFCPU "-cpu-predefined": abstract base class for the > >predefined CPU models > >

Re: [Qemu-devel] net: RFC New Socket-Based, Switched Network Backend (QDES)

2012-11-26 Thread Mike Lovell
On 11/24/2012 08:21 AM, Stefan Hajnoczi wrote: On Mon, Jun 25, 2012 at 7:42 AM, Mike Lovell wrote: This is what I've been calling QDES or QEMU Distributed Ethernet Switch. I first had the idea when I was playing with the udp and mcast socket network backends while exploring how to build a VM in

[Qemu-devel] [Bug 1077806] Re: Integrate Virtualbox/Qemu Guest booting as a desktop environment listing (request)

2012-11-26 Thread David Gomes
** Changed in: pantheon-greeter Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1077806 Title: Integrate Virtualbox/Qemu Guest booting as a desktop environment listi

[Qemu-devel] [PATCH] target-mips: Fix incorrect code and test for INSV

2012-11-26 Thread Petar Jovanovic
From: Petar Jovanovic Content of register rs should be shifted for pos before applying a mask. This change contains both fix for the instruction and to the existing test. Signed-off-by: Petar Jovanovic --- target-mips/dsp_helper.c |2 +- tests/tcg/mips/mips32-dsp/insv.c |2 +-

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-26 Thread Paul Moore
On Monday, November 26, 2012 11:41:06 AM Corey Bryant wrote: > On 11/21/2012 10:24 AM, Paul Moore wrote: > > On Wednesday, November 21, 2012 11:20:44 AM Eduardo Otubo wrote: > >> Hello folks, > >> > >> Does anyone had a chance to take a look at this? We would like to get > >> this into the 1.3 rel

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-26 Thread Anthony Liguori
Peter Maydell writes: > On 26 November 2012 14:33, Anthony Liguori wrote: >> VirtioBusInfo is not a great name. This is a proxy class that allows >> for a device to implement the virtio bus interface. >> >> This could be done as an interface but since nothing else uses >> interfaces, I'm okay w

Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce VirtioBus.

2012-11-26 Thread Anthony Liguori
Andreas Färber writes: > Am 26.11.2012 15:33, schrieb Anthony Liguori: >> fred.kon...@greensocs.com writes: >>> +#define DEBUG_VIRTIO_BUS 1 >>> + >>> +#define DPRINTF(fmt, ...) if (DEBUG_VIRTIO_BUS) {\ >>> +printf("virtio_bus: " fmt , ## __VA_AR

Re: [Qemu-devel] [PATCHv3 1/5] seccomp: adding new syscalls (bugzilla 855162)

2012-11-26 Thread Corey Bryant
On 11/21/2012 10:24 AM, Paul Moore wrote: On Wednesday, November 21, 2012 11:20:44 AM Eduardo Otubo wrote: Hello folks, Does anyone had a chance to take a look at this? We would like to get this into the 1.3 release. Thanks again :) I way a bit delayed due to travel, but I started playing

Re: [Qemu-devel] [PATCH for 1.3] target-i386: cpu: add missing flags to Haswell CPU model

2012-11-26 Thread Eduardo Habkost
On Sun, Nov 25, 2012 at 07:33:12PM +0100, Andreas Färber wrote: > Am 22.11.2012 16:31, schrieb Eduardo Habkost: > > When adding the Haswell CPU model, I intended to make it a superset of the > > features present on the SandyBridge model, but I have removed the SEP and > > RDTSCP features from the f

[Qemu-devel] [PATCH 1.3] rtc: Only call rtc_set_cmos when Register B SET flag is disabled.

2012-11-26 Thread Paolo Bonzini
From: Alex Horn This bug occurs when the SET flag of Register B is enabled. When an RTC data register (i.e. any of the ten time/calender CMOS bytes) is set, the data is (as expected) correctly stored in the cmos_data array. However, since the SET flag is enabled, the function rtc_set_time is not

[Qemu-devel] [PULL for-1.3] QOM CPUState patch queue 2012-11-26

2012-11-26 Thread Andreas Färber
Hello Anthony, As discussed, here's two bugfixes for x86 CPUs. Please pull for rc1. Regards, Andreas Cc: Eduardo Habkost Cc: Igor Mammedov Cc: Aurélien Jarno The following changes since commit cab1e8f3e37d8e883c270e3afd9c7c1c18332f0e: Merge remote-tracking branch 'qemu-kvm/uq/master' int

[Qemu-devel] [PATCH 2/2] target-i386: Enable SSSE3 TCG support

2012-11-26 Thread Andreas Färber
From: Aurelien Jarno SSSE3 support has been added to TCG more than 4 years ago in commit 4242b1bd8acc19cffdaad4ac23213d72a72b. It has been disabled by mistake in commit 551a2dec8fa55006a68393b9d6fb63577d2b3f1c. Signed-off-by: Aurelien Jarno Signed-off-by: Andreas Färber --- target-i386/cp

[Qemu-devel] [PATCH 1/2] target-i386/cpu: Add missing flags to Haswell CPU model

2012-11-26 Thread Andreas Färber
From: Eduardo Habkost When adding the Haswell CPU model, I intended to make it a superset of the features present on the SandyBridge model, but I have removed the SEP and RDTSCP features from the feature list by mistake. This patch adds the missing SEP and RDTSCP features (that are present on San

Re: [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed

2012-11-26 Thread Kevin Wolf
Am 21.11.2012 14:24, schrieb Paolo Bonzini: > Il 24/10/2012 12:10, Dietmar Maurer ha scritto: >> The formula to compute slice_quota was wrong. >> >> Signed-off-by: Dietmar Maurer >> --- >> include/qemu/ratelimit.h |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/i

Re: [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection

2012-11-26 Thread Richard Henderson
On 11/24/2012 10:12 AM, Peter Maydell wrote: > MacOS gcc objects to this: > In file included from /Users/pm215/src/qemu/tcg/tcg.c:174: > /Users/pm215/src/qemu/tcg/i386/tcg-target.c:105:19: warning: cpuid.h: > No such file or directory > > (though for some reason not as a fatal error). Bizzare. O

Re: [Qemu-devel] [PATCH 1.3 1/5] qom: fix refcount of non-heap-allocated objects

2012-11-26 Thread Paolo Bonzini
Il 26/11/2012 16:49, Anthony Liguori ha scritto: > But object_property_add_child() will take a reference. > When the parent object goes away, this will cause that reference to get > dropped and ultimately the child object to be destroyed. This is still wrong if you have: object_init(&obj->subob

Re: [Qemu-devel] [PATCH v4 1/1] atapi: make change media detection for guests easier

2012-11-26 Thread Kevin Wolf
Am 26.11.2012 16:37, schrieb Pavel Hrdina: > If you have a guest with a media in the optical drive and you change > it, the windows guest cannot properly recognize this media change. > > Windows needs to detect sense "NOT_READY with ASC_MEDIUM_NOT_PRESENT" > before we send sense "UNIT_ATTENTION wi

Re: [Qemu-devel] [PATCH 1.3 1/5] qom: fix refcount of non-heap-allocated objects

2012-11-26 Thread Anthony Liguori
Paolo Bonzini writes: > The reference count for embedded objects is always one too low, because > object_initialize_with_type returns with zero references to the object. > This causes premature finalization of the object (or an assertion failure) > after calling object_ref to add an extra referen

Re: [Qemu-devel] [PATCH 1.3] qapi: handle visitor->type_size() in QapiDeallocVisitor

2012-11-26 Thread mdroth
On Mon, Nov 26, 2012 at 01:10:12PM +0100, Stefan Hajnoczi wrote: > visit_type_size() requires either visitor->type_size() or > visitor_uint64() to be implemented, otherwise a NULL function pointer is > invoked. > > It is possible to trigger this crash as follows: > > $ qemu-system-x86_64 -netde

Re: [Qemu-devel] [PATCH 1.3] qapi: handle visitor->type_size() in QapiDeallocVisitor

2012-11-26 Thread mdroth
On Mon, Nov 26, 2012 at 02:22:58PM +0100, Stefan Hajnoczi wrote: > On Mon, Nov 26, 2012 at 1:43 PM, Andreas Färber wrote: > > Am 26.11.2012 13:10, schrieb Stefan Hajnoczi: > >> visit_type_size() requires either visitor->type_size() or > >> visitor_uint64() to be implemented, otherwise a NULL funct

  1   2   >