This patch adds an x argument to qemu_pixman_linebuf_fill so it can
also be used to convert a partial scanline. Then fix tight + png/jpeg
encoding by passing in the x+y offset, so the data is read from the
correct screen location instead of the upper left corner.
Cc: 1087...@bugs.launchpad.net
Cc
Hi,
Pixman patch queue, fixing vnc tight/png and tackeling build issues.
cheers,
Gerd
Gerd Hoffmann (5):
pixman: fix version check for PIXMAN_TYPE_BGRA
Revert "pixman: require 0.18.4 or newer"
pixman: update internal copy to pixman-0.28.2
pixman: fix vnc tight png/jpeg support
cons
This reverts commit 288fa40736e6eb63132d01aa6dc21ee831b796ae.
The only reason old pixman versions didn't work was the missing
PIXMAN_TYPE_BGRA, which is properly #ifdef'ed now. So we don't
have to require a minimum pixman version.
Conflicts:
configure
Signed-off-by: Gerd Hoffmann
---
Some w64 fixes by Stefan Weil found their way into 0.28.2,
so update the internal copy to that version to improve
windows support.
Signed-off-by: Gerd Hoffmann
---
pixman |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/pixman b/pixman
index 97336fa..a5e5179 16
--- a
- Messaggio originale -
> Da: "Jason Baron"
> A: qemu-devel@nongnu.org
> Cc: aligu...@us.ibm.com, kw...@redhat.com, pbonz...@redhat.com,
> quint...@redhat.com
> Inviato: Giovedì, 13 dicembre 2012 23:02:22
> Oggetto: [PATCH 3/3] qtest: add migrate-test
>
> From: Jason Baron
>
> Tests
Hi,
> No, they are with prefix, just not in $PATH. I have more than one
> "powerpc-linux-gnu" toolchain and I don't want to mess with my $PATH
> constantly to choose between them.
# ls -l /usr/bin/*-gcc
-rwxr-xr-x. 2 root root 264112 Aug 23 2011 /usr/bin/i686-pc-mingw32-gcc
-rwxr-xr-x. 2 root
Hi,
> Yes, I could manually install it, though then I get to deal with telling
> the pixman build exactly where to install itself, and repeating the
> process for each toolchain and multilib-variant thereof.
That part is easy too. You just need ${cross_prefix}-pkg-config.
A simple two-liner sc
> > Yeah, make it
>
> > oslib-obj-y += trace/
>
> > and get rid of trace-obj-y.
>
> Mmm, but according to Makefile.objs:
>
> oslib-obj-y is code depending on the OS (win32 vs posix)
True... I'd like to simplify this jungle sooner or later though.
We can keep trace-obj-y, but please do leav
qemu_chr_new_from_opts handles QemuOpts release now, so callers don't
have to worry. It will either be saved in CharDriverState, then
released in qemu_chr_delete, or in the error case released instantly.
Signed-off-by: Gerd Hoffmann
---
qemu-char.c | 15 ++-
qemu-char.h |1 +
Signed-off-by: Gerd Hoffmann
---
qemu-char.c | 24 +++-
qemu-char.h |3 ++-
vl.c|9 ++---
3 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index 242b799..5b91228 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2766
This patch adds chardev_add_file, chardev_add_tty and chardev_remove
monitor commands.
chardev_add_file and chardev_add_tty expect an id and a path, they
create a file/tty chardev.
chardev_del just takes an id argument and zaps the chardev specified.
Signed-off-by: Gerd Hoffmann
---
hmp-comman
Hi,
Got stuck in discussions & 1.3 freeze. Resending series to resume merge
effort, almost unmodified, only rebased & trivial conflicts resolved.
please review & comment,
Gerd
Gerd Hoffmann (3):
chardev: add error reporting for qemu_chr_new_from_opts
chardev: fix QemuOpts lifecycle
ch
On Wed, 12 Dec 2012 20:22:26 -0200
Eduardo Habkost wrote:
> This replaces the feature-bit fields on both X86CPU and x86_def_t
> structs with an array.
>
> With this, we will be able to simplify code that simply does the same
> operation on all feature words (e.g. kvm_check_features_against_host(
On Wed, 12 Dec 2012 20:22:24 -0200
Eduardo Habkost wrote:
> Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES)
> expression everywhere, use EXT2_PPRO_FEATURES.
>
> Signed-off-by: Eduardo Habkost
> ---
> target-i386/cpu.c | 13 +++--
> 1 file changed, 7 insertions(+), 6 d
On 14.12.2012, at 08:54, Gerd Hoffmann wrote:
> Hi,
>
>>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708
>>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
>>
>> 6e72719 is perfectly sane, because it brings consistency into the
>> file. Now both users of PIXMAN_TY
When controlling a qemu instance from another program, it's
hard to know which serial port or monitor device is redirected
to which pty. With more than one device using "pty" a lot of
guesswork is involved.
$ ./x86_64-softmmu/qemu-system-x86_64 -serial pty -serial pty -monitor pty
char device redi
v13:
Moved another function into stubs, added xml rule in tests/makefile, little
changes in patch 4, 6, 7.
Wenchao Xia (7):
Hi Paolo,
Do you think a rebase of the libqblock is needed? It have been quite
a time without comments.
--
Best Regards
Wenchao Xia
Il 14/12/2012 11:06, Wenchao Xia ha scritto:
>
> Hi Paolo,
> Do you think a rebase of the libqblock is needed? It have been quite
> a time without comments.
I was hoping that other people would jump in. :)
Paolo
On Wed, 12 Dec 2012 16:16:23 -0200
Eduardo Habkost wrote:
> Instead of forcing the caller to guess what went wrong while creating
> the CPU object, return error information in a Error argument.
>
> Also, as cpu_x86_create() won't print error messages itself anymore,
> change cpu_x86_init() to pr
On Wed, 12 Dec 2012 16:16:22 -0200
Eduardo Habkost wrote:
> As we will need to create the CPU object after splitting the CPU model
> string (because we're going to use different subclasses for each CPU
> model), move the CPU object creation to cpu_x86_register(), and at the
> same time rename cpu
From: Alex Horn
* Define enum for TMP105 registers
* Move tmp105_set() from I2C to TMP105 header
* Document units and range of temperature as preconditions
Signed-off-by: Alex Horn
Signed-off-by: Andreas Färber
---
hw/i2c.h|3 ---
hw/tmp105.c | 17 ---
hw/tmp105.h | 67
On 14.12.2012, at 12:04, Bharat Bhushan wrote:
> This is corrently done for powerpc.
>
> Signed-off-by: Bharat Bhushan
Jan, could you please check if this is correct?
> ---
> configure |1 +
> scripts/update-linux-headers.sh |5 +
> 2 files changed, 6 insertion
Am 12.12.2012 23:22, schrieb Eduardo Habkost:
> Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES)
> expression everywhere, use EXT2_PPRO_FEATURES.
>
> Signed-off-by: Eduardo Habkost
Technically this patch looks fine. My dislike for these defines aside, I
have doubts about the sem
An early length postincrement in the TMP105's I2C TX path led to
transfers of more than one byte to place the second byte in the third
byte's place within the buffer and the third byte to get discarded.
Fix this by explictly incrementing the length after the checks but
before the callback is calle
On Wed, Dec 12, 2012 at 4:49 PM, Michael S. Tsirkin wrote:
> On Wed, Dec 12, 2012 at 04:34:21PM +0100, Stefan Hajnoczi wrote:
>> On Tue, Dec 11, 2012 at 08:09:56PM +0200, Michael S. Tsirkin wrote:
>> > On Tue, Dec 11, 2012 at 10:32:28AM -0600, Anthony Liguori wrote:
>> > > "Michael S. Tsirkin" wr
This is corrently done for powerpc.
Signed-off-by: Bharat Bhushan
---
configure |1 +
scripts/update-linux-headers.sh |5 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index 780b19a..bdc2d5e 100755
--- a/configure
+++ b/c
Il 10/12/2012 15:29, Anthony Liguori ha scritto:
> Putting raw structures on the wire is bad news. Add a wrapper and use it.
>
> Note that in virtio-serial-bus, we were mapping both the in and out vectors as
> writable. This is a bug that is fixed by this change. I checked the revision
> histor
Introduce TYPE_ constant and cast macro.
Move the state struct to the new header to allow for future embedding.
Signed-off-by: Andreas Färber
---
hw/tmp105.c | 38 +-
hw/tmp105.h | 27 +++
2 Dateien geändert, 40 Zeilen hinzugefügt(+
Il 14/12/2012 01:57, Rusty Russell ha scritto:
> With the new code we only need the head from that structure.
We also need to do again all validation of the elements if we fetch it
back from the data. Sometimes the parsed data is saved elsewhere (e.g.
in a SCSIRequest struct that is serialized by
This obsoletes tmp105_set() and allows for better error handling.
Signed-off-by: Andreas Färber
---
hw/tmp105.c | 39 ---
hw/tmp105.h | 15 ---
2 Dateien geändert, 32 Zeilen hinzugefügt(+), 22 Zeilen entfernt(-)
diff --git a/hw/tmp105.c b/hw/t
Allows value sharing with qtest.
Signed-off-by: Andreas Färber
---
hw/tmp105.h | 34 +-
hw/tmp105_regs.h | 50 ++
2 Dateien geändert, 51 Zeilen hinzugefügt(+), 33 Zeilen entfernt(-)
create mode 100644 hw/tm
On 14 December 2012 11:04, Bharat Bhushan wrote:
> This is corrently done for powerpc.
This commit message is a bit cryptic.
> Signed-off-by: Bharat Bhushan
> ---
> configure |1 +
> scripts/update-linux-headers.sh |5 +
> 2 files changed, 6 insertions(+), 0 d
Exercise all four commands of the TMP105, testing for an issue in the
I2C TX path.
The test case uses the N800's OMAP I2C and is the first for ARM.
Signed-off-by: Andreas Färber
---
tests/Makefile |2 ++
tests/tmp105-test.c | 76 +++
2
liguang writes:
> if value to be translated is larger than INT64_MAX,
> this function will not be convenient for caller to
> be aware of it, so change a little for this.
>
> Signed-off-by: liguang
> ---
> cutils.c |3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/c
On Fri, Dec 14, 2012 at 12:44:43PM +0100, Andreas Färber wrote:
> Am 12.12.2012 23:22, schrieb Eduardo Habkost:
> > Instead of repeating the (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES)
> > expression everywhere, use EXT2_PPRO_FEATURES.
> >
> > Signed-off-by: Eduardo Habkost
>
> Technically this pat
Hi Blue / Aurelien,
This is my current patch queue for ppc. Please pull.
Alex
The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d:
Anthony Liguori (1):
Merge remote-tracking branch 'afaerber/qom-cpu' into staging
are available in the git repository at:
git
The ppce500 machine doesn't have to stick to hardware limitations,
as it's defined as being fully device tree based.
Thus we can change the initial PCI slot ID to 0x1 which gives us a
whopping 31 PCI devices we can support with this machine now!
Signed-off-by: Alexander Graf
---
hw/ppc/e500plat
The only difference between the "openpic" and "mpic" memory api subregion
descriptors is the endianness. Unify them as openpic accessors with explicit
endianness markers in their names.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 108 ++--
The openpic and mpic reset handlers are almost identical. Combine
them and extract the differences into state variables.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 103 +++--
1 files changed, 42 insertions(+), 61 deletions(-)
diff --git
From: David Gibson
The hwaddr type is somewhat vaguely defined as being able to contain bus
addresses on the widest possible bus in the system. For that reason it's
discouraged for representing specific pieces of persistent hardware state,
which should instead use an explicit width type that mat
The new PCI host bridge device needs to identify itself as PCI host bridge.
Declare it as such.
Signed-off-by: Alexander Graf
---
hw/ppce500_pci.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/ppce500_pci.c b/hw/ppce500_pci.c
index 54c72b4..e534341 100644
--- a
Now that we can properly distinguish between openpic model differences,
let's move brr1 out of the raven code path.
Signed-off-by: Alexander Graf
---
hw/openpic.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index 591b291..5bf16ea 10064
The IRQ line calculation is more or less hardcoded today. Instead, let's
write it as an algorithmic function that theoretically allows an arbitrary
number of PCI slots.
Signed-off-by: Alexander Graf
---
hw/ppce500_pci.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
dif
Now that our interrupt controller supports MSIs, let's expose that feature
to the guest through the device tree!
Signed-off-by: Alexander Graf
---
hw/ppc/e500.c | 23 +++
1 files changed, 23 insertions(+), 0 deletions(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index fa9
From: Ben Herrenschmidt
Currently the lowest "real" irq number for the XICS irq controller (as
opposed to numbers reserved for IPIs and other special purposes) is
hard coded as 16 in two places - in xics_system_init() and in spapr.c.
As well as being generally bad practice, we're going to need t
From: Ben Herrenschmidt
Kernel-based RTAS calls will not have a qemu handler, but will
still be registered in qemu in order to be assigned a token
number and appear in the device-tree.
Let's test for the name being NULL rather than the handler
when deciding to skip an entry while building the de
Il 14/12/2012 10:38, Gerd Hoffmann ha scritto:
> This patch adds chardev_add_file, chardev_add_tty and chardev_remove
> monitor commands.
>
> chardev_add_file and chardev_add_tty expect an id and a path, they
> create a file/tty chardev.
I'd rather avoid introducing this interface. Using multipl
liguang writes:
> qemu-img will complain when qcow or qcow2
> size overflow for 64 bits, report the right
> message in this condition.
>
> before change:
> qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for
> qemu-img: kilobytes, megabytes, gigabytes and terabytes.
>
>
The "openpic" controller is currently using one big region and does
subregion dispatching manually. Move this to the memory api.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 106 +
1 files changed, 61 insertions(+), 45 deletions(-)
di
From: David Gibson
This patch adds tracing / debugging calls to the XICS interrupt controller
implementation used on the pseries machine.
Signed-off-by: Ben Herrenschmidt
Signed-off-by: David Gibson
Signed-off-by: Alexander Graf
---
hw/xics.c| 23 ---
trace-events |
On Fri, Dec 14, 2012 at 10:38:50AM +0100, Igor Mammedov wrote:
> On Wed, 12 Dec 2012 20:22:26 -0200
> Eduardo Habkost wrote:
>
> > This replaces the feature-bit fields on both X86CPU and x86_def_t
> > structs with an array.
> >
> > With this, we will be able to simplify code that simply does the
From: David Gibson
Currently in the reset code for the XICS interrupt controller, we
initialize the pending_priority field to 0 (most favored, by XICS
convention). This is incorrect, since there is no pending interrupt, it
should be set to least favored - 0xff. At the moment our XICS
implementa
From: Michael Ellerman
The kernel will soon be able to service some RTAS calls. However the
choice of tokens will still be up to userspace. To support this have
spapr_rtas_register() return the token that is allocated for an
RTAS call, that allows the calling code to tell the kernel what the
toke
On 14.12.2012, at 03:12, Scott Wood wrote:
> If we access a register via the QEMU memory inspection commands (e.g.
> "xp") rather than from guest code, we won't have a CPU context.
> Gracefully fail to access the register in that case, rather than
> crashing.
Can't we set cpu_single_env in the d
The patch does fix the issue for me, thanks.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1087974
Title:
[regression] vnc tight png produces garbled output
Status in QEMU:
New
Bug description:
Paolo Bonzini wrote:
> Il 12/11/2012 12:44, Paolo Bonzini ha scritto:
>>> @@ -339,7 +351,11 @@ void migrate_fd_put_ready(MigrationState *s)
>>> DPRINTF("done iterating\n");
>>> start_time = qemu_get_clock_ms(rt_clock);
>>> qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OT
On Fri, Dec 14, 2012 at 11:18:18AM +0100, Igor Mammedov wrote:
> On Wed, 12 Dec 2012 16:16:23 -0200
> Eduardo Habkost wrote:
>
> > Instead of forcing the caller to guess what went wrong while creating
> > the CPU object, return error information in a Error argument.
> >
> > Also, as cpu_x86_crea
On 14.12.2012, at 03:11, Scott Wood wrote:
> There'll be more to come, but here's an initial set of cleanups
> and fixes for openpic.
Thanks, applied all except for 4/6 to ppc-next.
Alex
>
> This is based on the ppc-mpic-cleanup branch in
> git://repo.or.cz/qemu/agraf.git
>
> Scott Wood (6)
From: David Gibson
If no image file for NVRAM is specified, the pseries machine currently
creates a 16K non-persistent NVRAM by default. This basically works, but
is not large enough for current firmware and guest kernels to create all
the NVRAM partitions they would like to. Increasing the def
From: David Gibson
Currently the XICS irq controller code has a per-irq state structure which
amongst other things includes whether the interrupt is level or message
triggered - this is configured by the platform code, and is not directly
visible to the guest. This leads to a slightly awkward co
Paolo Bonzini wrote:
> Il 21/09/2012 16:08, Juan Quintela ha scritto:
>> -s->fd = inet_connect(host_port, false, &in_progress, errp);
>> +s->fd = inet_connect(host_port, true, &in_progress, errp);
>
> This makes the connect operation blocking.
>
> Does this mean that Orit's patches for non
The openpic code has its own bitmap code to access bits inside of a
bitmap. However, that is overkill when we simply want to check for a
bit inside of a uint32_t.
So instead, let's use normal bit masks and C builtin shifts and ands.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 67
Paolo Bonzini wrote:
> Il 21/09/2012 16:08, Juan Quintela ha scritto:
>> Instead of locking the whole migration_thread inside loop, just lock
>> migration_fd_put_notify, that is what interacts with the rest of the
>> world.
>
> Wrong commit message: just lock migrate_fd_put_ready.
Fixed.
>> @@ -
On Fri, Dec 14, 2012 at 11:26:55AM +0100, Igor Mammedov wrote:
> On Wed, 12 Dec 2012 16:16:22 -0200
> Eduardo Habkost wrote:
>
> > As we will need to create the CPU object after splitting the CPU model
> > string (because we're going to use different subclasses for each CPU
> > model), move the C
The MSI-X vector tables are usually stored in little endian in memory,
so let's mark the accessors as such.
This fixes MSI-X on e500 for me.
Signed-off-by: Alexander Graf
Acked-by: Michael S. Tsirkin
---
hw/msix.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw
The OpenPIC allows MSI access through shared MSI registers. Implement
them for the MPC8544 MPIC, so we can support MSIs.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 150 ++
1 files changed, 130 insertions(+), 20 deletions(-)
diff --g
We have a params struct that allows us to expose differences between
e500 machine models. Include PCI slot information there, so we can have
different machines with different PCI slot topology.
Signed-off-by: Alexander Graf
---
hw/ppc/e500.c |4 +++-
hw/ppc/e500.h |2 ++
hw/ppc
From: David Gibson
The PAPR specification requires that every bus or device mediated by the
IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check
to enforce this, which will help catch errors in configuration earlier.
Signed-off-by: David Gibson
Signed-off-by: Alexander Gr
Hello Kevin,
On Wednesday 12 December 2012 18:29:48 Philipp Hahn wrote:
> I just re-run my "git bisect run ~/bisect.sh" case, but it again arrived
> at that patch. I just queued another run for tonight so make sure the test
> is reliable:
The run from last night again arrived at the refecenced p
On 12/14/2012 05:17 AM, Paolo Bonzini wrote:
> Il 14/12/2012 10:38, Gerd Hoffmann ha scritto:
>> This patch adds chardev_add_file, chardev_add_tty and chardev_remove
>> monitor commands.
>>
>> chardev_add_file and chardev_add_tty expect an id and a path, they
>> create a file/tty chardev.
>
> I'd
Today we're hardcoding the PCI interrupt map in the e500 machine file.
Instead, let's write it dynamically so that different machine types
can have different slot properties.
Signed-off-by: Alexander Graf
---
hw/ppc/e500.c | 51 +++
1 files chang
This patch removes all remaining occurences of spaces before function
parameter indicating parenthesis.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index 4bea1e7..25d5cd7 100644
---
Rename the openpic_t struct to OpenPICState, so it adheres better to
the current coding style rules.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 68 +-
1 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/hw/openpic.c b/h
The MPIC source irq handler suddenly became identical to the standard
OpenPIC source irq handler. Combine them into the same function.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 52 +---
1 files changed, 5 insertions(+), 47 deletions(-)
di
We need the calculation method to get from a PCI slot ID to its respective
interrupt line twice. Once in the internal map function and once when
assembling the device tree.
So let's extract the calculation to a separate function that can be called
by both users.
Signed-off-by: Alexander Graf
---
Hi,
> { 'enum': 'ChardevFileMode', 'data':
> # pty = console under Windows
> # serial = tty under POSIX
> [ 'file', 'pipe', 'parport', 'pty', 'serial' ] }
Hmm, why this enum? I'd stay close to -chardev, i.e. specify the type
by backend name.
> { 'enum: 'ChardevFileSource', 'data':
> [
The current openpic emulation contains half-ready code for bypass mode.
Remove it, so that when someone wants to finish it they can start from a
clean state.
Signed-off-by: Alexander Graf
---
hw/openpic.c |8 ++--
hw/openpic.h |4 ++--
hw/ppc/e500.c |2 +-
hw/ppc_ne
The IRQ raise mechanisms of the OpenPIC and MPIC controllers is identical,
just that the MPIC one can also raise critical interrupts.
Combine those two and check for critical raise capability during runtime.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 34 -
The openpic code was still using the old mmio memory api. Convert it to
be a generic memory api user and clean up some code that becomes redundant
that way.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 138 --
1 files changed, 48 inser
This patch converts the OpenPIC device to qdev. Along the way it
renames the "openpic" target to "raven" and the "mpic" target to
"fsl_mpic_20", to better reflect the actual models they implement.
This way we have a generic OpenPIC device now that can handle
different flavors of the OpenPIC specif
Paolo Bonzini writes:
>> > > > I think distros that used to ship qemu-kvm should just change
>> > > > the default just like for the acpi_piix4.c change.
>> > >
>> > > Maybe we could provide a --with-qemu-kvm-compat configure flag to
>> > > them?
>
> I like this.
>
>> > I think that defeats the pu
The openpic code had a few WIP bits left that nobody reanimated within
the last few years. Remove that code.
Signed-off-by: Alexander Graf
Acked-by: Hervé Poussineau
---
hw/openpic.c | 163 --
1 files changed, 0 insertions(+), 163 deletio
On Wed, 12 Dec 2012 16:16:42 -0200
Eduardo Habkost wrote:
> On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote:
> > Caller of visit_type_suffixed_int() have to specify
> > value of 'K' suffix using suffix_factor argument.
> > Example of selecting suffix_factor value:
> > * Kbytes: 102
Today the first slot id in our e500 pci implementation is hardcoded to
0x11. Keep it there as default, but allow users to change the default to
a different id.
Signed-off-by: Alexander Graf
---
hw/ppce500_pci.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/hw/p
From: Bharat Bhushan
PCI Root complex have TYPE-1 configuration header while PCI endpoint
have type-0 configuration header. The type-1 configuration header have
a BAR (BAR0). In Freescale PCI controller BAR0 is used for mapping pci
address space to CCSR address space. This can used for 2 purposes
Some usb devices (host or network redirection) can benefit from knowing when
the guest stops using an endpoint. Redirection may involve submitting packets
independently from the guest (in combination with a fifo buffer between the
redirection code and the guest), to ensure that buffers of the real
Rather then using the magic 32 value in various places.
Signed-off-by: Hans de Goede
---
hw/usb/hcd-uhci.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index 1e32549..11ccdc8 100644
--- a/hw/usb/hcd-uhci.c
+++ b/hw/usb/hcd-uhc
I tried lowering the time between raising an interrupt and rescanning the
async schedule to see if the guest has queued a new transfer before, but
that did not have any positive effect. I now believe the cause for this is
that lowering this time made it more likely to hit the 1 ms interrupt
thresho
Signed-off-by: Hans de Goede
---
hw/usb/redirect.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 4cf8780..7b2cd8c 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -43,6 +43,11 @@
#define NO_INTERFACE_INFO 255 /
Signed-off-by: Hans de Goede
---
hw/usb/redirect.c | 41 +++--
1 file changed, 19 insertions(+), 22 deletions(-)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index a4d324f..4cf8780 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -761,6 +761,23
Before this patch uhci would process an unlimited amount of frames when
behind on schedule, by setting the timer to a time already past, causing the
timer subsys to immediately recall the frame_timer function gain.
This would cause invalid cancellations of bulk queues when the catching up
processe
To ensure that interrupt receiving is properly stopped when the guest is
no longer interested in an interrupt endpoint.
Signed-off-by: Hans de Goede
---
hw/usb/redirect.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 7b2cd8c..ed2f427 100
The xhci-hcd may submit bulk transfers > 65535 bytes even when not using
bulk-in pipeling, so usbredir can only be used in combination with an xhci
hcd if the client has the 32 bits bulk length capability.
Signed-off-by: Hans de Goede
---
hw/usb/redirect.c | 2 ++
1 file changed, 2 insertions(+)
The openpic and mpic timer handling code is basically the same.
Merge them.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 131 ++
1 files changed, 31 insertions(+), 100 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index d709e3
When we're done with one interrupt, we need to search for the next pending
interrupt in the queue. This search has grown quite big now that we have
more than 256 possible irq lines.
So let's memorize how many interrupts we have pending in our bitmaps, so
that we can always bail out in the usual ca
The openpic source irqs are carrying around a type indicator that
is never accessed by anything. Remove it.
Signed-off-by: Alexander Graf
---
hw/openpic.c | 27 ++-
1 files changed, 2 insertions(+), 25 deletions(-)
diff --git a/hw/openpic.c b/hw/openpic.c
index 623c807
> -Original Message-
> From: Alexander Graf [mailto:ag...@suse.de]
> Sent: Friday, December 14, 2012 5:06 PM
> To: Bhushan Bharat-R65777
> Cc: qemu-devel qemu-devel; qemu-...@nongnu.org List; Bhushan Bharat-R65777;
> Jan
> Kiszka
> Subject: Re: [PATCH RFC] PowerPC: Added uapi directory i
Also drop the warning printf, which was there mainly because this was an
untested code path (as the previous bug fixes to it show), but that no
longer is the case now :)
Signed-off-by: Hans de Goede
---
hw/usb/hcd-ehci.c | 28 +---
1 file changed, 17 insertions(+), 11 del
Signed-off-by: Hans de Goede
---
hw/usb/hcd-ehci.c | 51 +++
1 file changed, 35 insertions(+), 16 deletions(-)
diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c
index 218b1d7..0d31597 100644
--- a/hw/usb/hcd-ehci.c
+++ b/hw/usb/hcd-ehci.c
@@ -438,
On 12/13/2012 03:09 PM, Peter Maydell wrote:
I certainly will send further patches.
As you noticed I am new to git. Thanks for your patience and advice.
1 - 100 of 237 matches
Mail list logo