[Qemu-devel] [PATCH] configure: Earlier pkg-config probe

2012-12-16 Thread Stefan Weil
Probe pkg-config before it is used for the first time (libseccomp check). Signed-off-by: Stefan Weil s...@weilnetz.de --- configure | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index ecdb33a..728caca 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH v2] build: Use separate makefile for trace/

2012-12-16 Thread Paolo Bonzini
Il 14/12/2012 20:13, Lluís Vilanova ha scritto: Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu -- Changes in v2: * Do not depend on qemu-timer-common.o. * Use $(obj) in rules to refer to the build sub-directory. * Remove dependencies against $(GENERATED_HEADERS). Cc: Paolo Bonzini

Re: [Qemu-devel] big wait check in ram_save_iterate()

2012-12-16 Thread Paolo Bonzini
Il 15/12/2012 12:20, Peter Lieven ha scritto: Am 15.12.2012 10:02, schrieb Paolo Bonzini: is the check for spending 50ms in the loop still necessary in qemu 1.3.0? Yes, it helps finding the available bandwidth and tuning the downtime of migration. Aha, okay. But then it should also be

[Qemu-devel] [Bug 1071236] Re: creating qcow2 image with preallocation fails if size =4G

2012-12-16 Thread Michael Tokarev
This is fixed by commit a3548077062dd9dc2701ebffd931ba6eaef40bec which is included in 1.3 release of qemu. ** Changed in: qemu Status: Confirmed = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-16 Thread Paolo Bonzini
Are you using /bin/sh (broken) or /usr/xpg4/bin/sh (should work)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090837 Title: Error in building Qemu-1.3.0 on Solaris 10 Status in QEMU: New

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-16 Thread Michael S. Tsirkin
On Thu, Dec 13, 2012 at 02:31:53PM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-16 Thread Michael S. Tsirkin
On Fri, Dec 14, 2012 at 09:37:17PM +, Blue Swirl wrote: Perhaps the use of '-' vs. '_' in file names could be unified while renaming. I think most new files use dash. I can do this in a follow up patch but first let's put this rule in coding style file. As it is more files use _ than -. And

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-16 Thread Andreas Färber
Am 14.12.2012 17:46, schrieb Jens Freimann: Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com The logic looks okay now. Some comments inline. --- v2 - v3: * explain in comment which code sets cpu 0 to running during

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-16 Thread Michael S. Tsirkin
Please setup your tree in buildbot and wait for a full run before sending a pull requests in the future. I actually waited 24 hours which is normally enough for buildbot to run the tree, and assumed pass means OK. Turns out buildbot was passing, but only because it was building some old

Re: [Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-16 Thread Andreas Färber
Am 14.12.2012 17:46, schrieb Jens Freimann: From: Viktor Mihajlovski mihaj...@linux.vnet.ibm.com This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-16 Thread Michael S. Tsirkin
On Thu, Dec 13, 2012 at 08:51:30AM -0600, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 12/12/2012 18:58, Peter Maydell ha scritto: It should be equally valid to just use the PCI transport plugged into a VirtioDevice, both of which were created by the user with

Re: [Qemu-devel] [PATCH v6 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-16 Thread Michael S. Tsirkin
On Mon, Dec 10, 2012 at 02:09:45PM +0100, Stefan Hajnoczi wrote: @@ -33,6 +34,7 @@ typedef struct VirtIOBlock VirtIOBlkConf *blk; unsigned short sector_mask; DeviceState *qdev; +VirtIOBlockDataPlane *dataplane; } VirtIOBlock; static VirtIOBlock

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-16 Thread Dipanjan Das
If I invoke /usr/xpg4/bin/sh from bash and then start the build process, will it be OK/ Or do I need to add /usr/xpg4/bin/sh to PATH? Does the patch mentioned in the referred bug need to be applied? -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH v6 03/12] dataplane: add host memory mapping code

2012-12-16 Thread Michael S. Tsirkin
On Fri, Dec 14, 2012 at 12:45:16PM +0100, Stefan Hajnoczi wrote: On Wed, Dec 12, 2012 at 4:49 PM, Michael S. Tsirkin m...@redhat.com wrote: On Wed, Dec 12, 2012 at 04:34:21PM +0100, Stefan Hajnoczi wrote: On Tue, Dec 11, 2012 at 08:09:56PM +0200, Michael S. Tsirkin wrote: On Tue, Dec 11,

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-16 Thread Michael S. Tsirkin
On Thu, Dec 13, 2012 at 11:48:17AM +0100, Kevin Wolf wrote: Am 12.12.2012 17:37, schrieb Michael S. Tsirkin: On Wed, Dec 12, 2012 at 04:52:53PM +0100, Paolo Bonzini wrote: Il 12/12/2012 16:25, Michael S. Tsirkin ha scritto: On Wed, Dec 12, 2012 at 04:01:27PM +0100, Paolo Bonzini wrote: Il

Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-16 Thread Andreas Färber
Am 14.12.2012 17:46, schrieb Jens Freimann: From: Christian Borntraeger borntrae...@de.ibm.com Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately Careful with the ordering

Re: [Qemu-devel] [RFC PATCH v7 7/8] virtio-pci-blk : Switch to new API.

2012-12-16 Thread Andreas Färber
Am 12.12.2012 18:53, schrieb Andreas Färber: Finally supplying a public device_initialize() or so would be helpful for the latter since VMState cannot cross pointers IIRC. I'll look into that part since inlining the old qdev functions cripples my Tegra work. Investigating this, it turned out

Re: [Qemu-devel] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-12-16 Thread Michael Tokarev
This is a follow-up to a more-or-less trivial commit, 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 . I'm adding some more context - the whole function in question. commit 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 Author: Don Slutz d...@cloudswitch.com Date: Fri Sep 21 20:13:13 2012 -0400

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-16 Thread Michael S. Tsirkin
On Thu, Dec 13, 2012 at 09:54:23AM +0100, Paolo Bonzini wrote: Il 12/12/2012 22:27, Michael S. Tsirkin ha scritto: Maybe it's obvious to you that qdev_reset_all(x) does a soft reset and what soft reset means for each bus type We can define soft reset to be *independent* of the bus type.

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-16 Thread Dipanjan Das
Until tomorrow, I can't report back as the Solaris 10 system is in my workplace. What I tried was to trigger ./configure from bash shell which produced the log above and aborted. As the title already says, I tried to build Qemu 1.3.0. P.S. If I already use bash shell to invoke the script, do I

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-16 Thread Paolo Bonzini
Il 16/12/2012 18:04, Michael S. Tsirkin ha scritto: On Thu, Dec 13, 2012 at 09:54:23AM +0100, Paolo Bonzini wrote: Il 12/12/2012 22:27, Michael S. Tsirkin ha scritto: Maybe it's obvious to you that qdev_reset_all(x) does a soft reset and what soft reset means for each bus type We can define

Re: [Qemu-devel] [PATCHv2] virtio: verify that all outstanding buffers are flushed

2012-12-16 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: We technically should save the addresses and sizes too. It makes it a heck of a lot safer then re-reading guest memory since we do some validation on the size of the sg elements. Not really. The guest puts the descriptors in the ring and

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-16 Thread Michael S. Tsirkin
On Thu, Dec 13, 2012 at 02:31:53PM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are

[Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-16 Thread Michael S. Tsirkin
The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 08:35:15 -0600) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to

Re: [Qemu-devel] [PATCH 0/2] virtio: reset all qbuses too when writing to the status field

2012-12-16 Thread Michael S. Tsirkin
On Sun, Dec 16, 2012 at 08:31:16PM +0100, Paolo Bonzini wrote: Il 16/12/2012 18:04, Michael S. Tsirkin ha scritto: On Thu, Dec 13, 2012 at 09:54:23AM +0100, Paolo Bonzini wrote: Il 12/12/2012 22:27, Michael S. Tsirkin ha scritto: Maybe it's obvious to you that qdev_reset_all(x) does a

Re: [Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-16 Thread Christian Borntraeger
On 16/12/12 17:26, Andreas Färber wrote: Am 14.12.2012 17:46, schrieb Jens Freimann: From: Christian Borntraeger borntrae...@de.ibm.com Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW

[Qemu-devel] [Bug 1031698] Re: Missing PPC TRACE exception on a branch

2012-12-16 Thread Michael Tokarev
This is fixed by qemu commit f0cc4aa8450376ca2aee3ebb09db71f9f2ff333b which went into qemu-1.3 release. ** Changed in: qemu Status: New = Fix Committed ** Changed in: qemu Status: Fix Committed = Fix Released -- You received this bug notification because you are a member of qemu-

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-16 Thread Andreas Färber
Just using $SHELL inside configure would be insufficient if run via Solaris' sh. Using `bash ./configure ...` should've worked for v1.2 without patches, didn't test v1.3 on Sol10 yet. Whether the DTrace support scripts fully work on Solaris 10 is another issue. -- You received this bug

[Qemu-devel] [Bug 1090837] Re: Error in building Qemu-1.3.0 on Solaris 10

2012-12-16 Thread Andreas Färber
Yes, if you execute `./configure ...` the shell will execute the shebang line inside the script, which says /bin/sh and happens to be a really ancient version for backwards compatibility on Solaris. -- You received this bug notification because you are a member of qemu- devel-ml, which is

[Qemu-devel] [PATCH v8 01/10] fix some debug printf format strings

2012-12-16 Thread Matthew Ogilvie
These are normally ifdefed out and don't matter. But if you enable them, they ought to be correct. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/cirrus_vga.c | 4 ++-- hw/i8259.c | 3 ++- hw/ide/cmd646.c | 5 +++-- hw/ide/via.c| 5 +++-- 4 files changed, 10

[Qemu-devel] [PATCH v8 07/10] i8259: refactor pic_set_irq level logic

2012-12-16 Thread Matthew Ogilvie
No change in functionality. Clarify that the only difference between level triggered and edge triggered interrupts is on the leading edge. Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/i8259.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-)

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-16 Thread Marcelo Tosatti
On Sat, Dec 15, 2012 at 01:45:38PM +, Julien Grall wrote: On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti mtosa...@redhat.com wrote: The high byte of the ioport address is necessary to compute the register address, see 82371AB PCI ISA IDE Xcelerator (PIIX4) document, eg:

[Qemu-devel] [PATCH v8 05/10] fix i8254 output logic to match the spec

2012-12-16 Thread Matthew Ogilvie
This patch fixes i8254 output line (IRQ0) logic to match the spec. Basically, IRQ0 line should normally be high, and only occasionally go low to cause an edge. This is an important prerequisite to fixing the i8259 interrupt controller to cancel an unhandled interrupt when the IRQ line goes low.

[Qemu-devel] [PATCH v8 00/10] i8254, i8259 and running Microport UNIX (ca 1987)

2012-12-16 Thread Matthew Ogilvie
This series makes a series of mostly-unrelated fixes to allow running an old Microport UNIX (ca 1987) guest under qemu. The most intrusive of the fixes is modifying how the i8259 handles the trailing edge of an interrupt request (the trailing edge ought to cancel interrupt, even when the line is

[Qemu-devel] [PATCH v8 03/10] qemu-options.hx: mention retrace= VGA option

2012-12-16 Thread Matthew Ogilvie
The feature was added in commit cb5a7aa8c32141bb Sep 2008. My description is based on Better VGA retrace emulation (needed for some DOS games/demos) from http://www.boblycat.org/~malc/code/patches/qemu/index.html Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- qemu-options.hx | 8

[Qemu-devel] buildbot failure in qemu on block_mingw32

2012-12-16 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/417 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

[Qemu-devel] [PATCH v8 08/10] qtest: fix qemu_irq_intercept_out()

2012-12-16 Thread Matthew Ogilvie
For the 8259 (at least), we need to modify the entries in gpio_out (which is pointing at PICCommonState::int_out) in-place rather than change it to point to a totally different table. The 8259 sends its output to int_out even if gpio_out is a different table. Signed-off-by: Matthew Ogilvie

Re: [Qemu-devel] [PATCH 2/2] qemu-img:report size overflow error message

2012-12-16 Thread li guang
在 2012-12-14五的 13:19 +0100,Markus Armbruster写道: liguang lig.f...@cn.fujitsu.com writes: qemu-img will complain when qcow or qcow2 size overflow for 64 bits, report the right message in this condition. before change: qemu-img: Invalid image size specified! You may use k, M, G or T

Re: [Qemu-devel] [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-16 Thread li guang
在 2012-12-14五的 13:09 +0100,Markus Armbruster写道: liguang lig.f...@cn.fujitsu.com writes: if value to be translated is larger than INT64_MAX, this function will not be convenient for caller to be aware of it, so change a little for this. Signed-off-by: liguang lig.f...@cn.fujitsu.com

[Qemu-devel] buildbot failure in qemu on block_openbsd_4.9

2012-12-16 Thread qemu
The Buildbot has detected a new failure on builder block_openbsd_4.9 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_openbsd_4.9/builds/417 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_openbsd49 Build

[Qemu-devel] [PATCH v8 10/10] add test/pic-test.c

2012-12-16 Thread Matthew Ogilvie
Microport UNIX System V/386 v2.1 (ca. 1987) does something similar to the slave_imr() test, and doesn't run if the canceling behavior of IRQ2 doesn't work. I don't know anything that depends on the canceling behavior of other interrupts (master_basic() or slave_basic() tests), but it seems best

[Qemu-devel] [PATCH v8 02/10] vl: fix -hdachs/-hda argument order parsing issues

2012-12-16 Thread Matthew Ogilvie
Without this patch, the -hdachs argument had to occur either BEFORE the corresponding -hda option, or AFTER the plain disk image name (if neither -hda nor -drive is used). Otherwise it would effectively be ignored. Option -hdachs still has no effect on -drive, but that seems best.

Re: [Qemu-devel] [PATCH 1/2] cutils:change strtosz_suffix_unit function

2012-12-16 Thread li guang
在 2012-12-14五的 14:45 +0100,Igor Mammedov写道: On Fri, 14 Dec 2012 13:09:17 +0100 Markus Armbruster arm...@redhat.com wrote: liguang lig.f...@cn.fujitsu.com writes: if value to be translated is larger than INT64_MAX, this function will not be convenient for caller to be aware of it,

[Qemu-devel] [PATCH v8 04/10] vga: add some optional CGA compatibility hacks

2012-12-16 Thread Matthew Ogilvie
This patch adds some optional compatibility hacks (default disabled) to allow Microport UNIX to function under qemu. I've tried to structure it to be easy to add more hacks for other old CGA programs, if anyone ever needs them. Microport UNIX System V/386 v 2.1 (ca 1987) tries to program the CGA

[Qemu-devel] [PATCH v8 06/10] i8259: fix so that dropping IRQ level always clears the interrupt request

2012-12-16 Thread Matthew Ogilvie
Intel's definition of edge triggered means: asserted with a low-to-high transition at the time an interrupt is registered and then kept high until the interrupt is served via one of the EOI mechanisms or goes away unhandled. So the only difference between edge triggered and level triggered is in

[Qemu-devel] [PATCH v8 09/10] qtest: add set_irq_{in, out} infrastructure for testing interrupt controllers

2012-12-16 Thread Matthew Ogilvie
Signed-off-by: Matthew Ogilvie mmogilvi_q...@miniinfo.net --- hw/i8259.c | 6 ++ qtest.c | 51 +++ tests/libqtest.c | 12 tests/libqtest.h | 48 4 files changed, 117

[Qemu-devel] [PATCH v3 2/2] qemu-img:report size overflow error message

2012-12-16 Thread liguang
qemu-img will complain when qcow or qcow2 size overflow for 64 bits, report the right message in this condition. $./qemu-img create -f qcow2 /tmp/foo 0x1 before change: qemu-img: Invalid image size specified! You may use k, M, G or T suffixes for qemu-img: kilobytes, megabytes,

[Qemu-devel] [PATCH v3 1/2] cutils:change strtosz_suffix_unit function

2012-12-16 Thread liguang
if value to be translated is larger than INT64_MAX, this function will not be convenient for caller to be aware of it, so change a little for this. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- cutils.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/cutils.c

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-16 Thread David Gibson
On Thu, Dec 13, 2012 at 02:18:15PM +, Peter Maydell wrote: On 13 December 2012 14:17, Peter Maydell peter.mayd...@linaro.org wrote: On 13 December 2012 13:19, Alexander Graf ag...@suse.de wrote: So because we don't call kvm_arch_init, the cap is 0 and thus we return 1? No, if we

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties

2012-12-16 Thread David Gibson
On Thu, Dec 13, 2012 at 01:50:25PM +0100, Alexander Graf wrote: On 04.12.2012, at 03:42, David Gibson wrote: PAPR requires that the device tree's CPU nodes have several properties with information about the L1 cache. We created two of these properties, but with incorrect names -

Re: [Qemu-devel] [PATCH Update] sheepdog: don't update inode when create_and_write fails

2012-12-16 Thread MORITA Kazutaka
At Sat, 15 Dec 2012 17:59:12 +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO

[Qemu-devel] [PATCH] Added uapi directory into linux-header

2012-12-16 Thread Bharat Bhushan
Linux ARCH specific header files are now in uapi/ directory also. These header files (epapr_hcalls.h on powerpc) are needed in qemu in linux-headers/uapi/asm/ directory as these are referenced by other header files in linux-headers/asm/. This patch is about changing the scripts for same.

Re: [Qemu-devel] main-loop.c: About Select handling

2012-12-16 Thread Furukawa, Eiji
Sorry,I was misunderstanding it. If The main loop will iterate again, it is unquestionable. -- E.Furukawa On Thu, Dec 06, 2012 at 12:30:19AM +, Furukawa, Eiji wrote: The select() do not masked signal in os_host_main_loop_wait. For example, qemu-timer.c gives SIGALRM regularly.

[Qemu-devel] [PATCH] pci: Rework handling of multiple host bridges (pci domains)

2012-12-16 Thread David Gibson
Currently the qemu core PCI code doesn't support a machine having multiple independent PCI host bridges (aka PCI domains). It does have some incomplete stubs for such support, but unfortunately what's there is based on a bogus premise. PCI domains are often referenced by a PCI domain number, and

Re: [Qemu-devel] [PATCH Update] sheepdog: don't update inode when create_and_write fails

2012-12-16 Thread Liu Yuan
On 12/17/2012 11:43 AM, MORITA Kazutaka wrote: send_pending_req() needs to be called even in error case. Rather than moving the error check, I think it looks better to update s-inode.data_vdi_id only when rsp.result is SD_RES_SUCCESS. Why can't we check the rsp.result in the first place?

Re: [Qemu-devel] [PATCH V8 3/4] Use QemuOpts support in block layer

2012-12-16 Thread Bharata B Rao
On Fri, Dec 14, 2012 at 7:34 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: diff --git a/block/gluster.c b/block/gluster.c index 1c90174..daabb61 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -335,8 +335,7 @@ out: return ret; } -static int qemu_gluster_create(const char

[Qemu-devel] QMP command implementation help

2012-12-16 Thread Shraddha Kamat
I am implementing couple of QMP commands to Qemu - so trying a hello-world command first as shown here https://github.com/qemu/qemu/blob/master/docs/writing-qmp-commands.txt Step 1 : Added to qapi-schema.json file this : { 'command': 'hello-world' } Step 2: === Added to qmp.c :

Re: [Qemu-devel] [PATCH Update] sheepdog: don't update inode when create_and_write fails

2012-12-16 Thread MORITA Kazutaka
At Mon, 17 Dec 2012 13:22:31 +0800, Liu Yuan wrote: On 12/17/2012 11:43 AM, MORITA Kazutaka wrote: send_pending_req() needs to be called even in error case. Rather than moving the error check, I think it looks better to update s-inode.data_vdi_id only when rsp.result is SD_RES_SUCCESS.

[Qemu-devel] [PATCH 1/3] Synchronized the linux headers

2012-12-16 Thread Bharat Bhushan
This is needed for the watchdog patches (following up this one) Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- linux-headers/asm-generic/kvm_para.h |4 + linux-headers/asm-powerpc/kvm.h | 86 ++ linux-headers/asm-powerpc/kvm_para.h

[Qemu-devel] [PATCH 3/3] Enable kvm emulated watchdog

2012-12-16 Thread Bharat Bhushan
Enable the KVM emulated watchdog if KVM supports (use the capability enablement in watchdog handler). Also watchdog exit (KVM_EXIT_WATCHDOG) handling is added. Watchdog state machine is cleared whenever VM state changes to running. This is to handle the cases like return from debug halt etc.

[Qemu-devel] [PATCH 2/3] Reset qemu timers when guest reset

2012-12-16 Thread Bharat Bhushan
This patch install the timer reset handler. This will be called when the guest is reset. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- hw/ppc_booke.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c index

[Qemu-devel] [PATCH 2/6] snapshot: add error set function

2012-12-16 Thread Wenchao Xia
Added two function which will try replace the error if it is already set, so only last error is reported. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- error.c | 23 +++ error.h |9 + 2 files changed, 32 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2012-12-16 Thread Wenchao Xia
This patch changes the implemtion of external block snapshot to use internal unified interface, now qmp handler just do a translation of request and submit. Also internal block snapshot qmp interface was added. Now add external snapshot, add/delete internal snapshot can be started in their

Re: [Qemu-devel] [PATCH V8 3/4] Use QemuOpts support in block layer

2012-12-16 Thread Dong Xu Wang
On Mon, Dec 17, 2012 at 1:44 PM, Bharata B Rao bharata@gmail.com wrote: On Fri, Dec 14, 2012 at 7:34 PM, Dong Xu Wang wdon...@linux.vnet.ibm.com wrote: diff --git a/block/gluster.c b/block/gluster.c index 1c90174..daabb61 100644 --- a/block/gluster.c +++ b/block/gluster.c @@ -335,8

[Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

2012-12-16 Thread Wenchao Xia
This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block.c | 30 ++ block.h |3 +++ savevm.c | 22 -- 3 files

[Qemu-devel] [PATCH v2 1/2] sheepdog: don't update inode when create_and_write fails

2012-12-16 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka

[Qemu-devel] [PATCH v2 2/2] sheepdog: pass oid directly to send_pending_req()

2012-12-16 Thread Liu Yuan
From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com --- block/sheepdog.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

[Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Wenchao Xia
This patch is the implemention of transaction based snapshot internal API. Internal snapshot for specified block device is added, which can be used as part of functionality in one way to live full back up vm seperating internal block snapshot and vmstate(vmstate goes to another file, not

[Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

2012-12-16 Thread Wenchao Xia
This patch added API to take snapshots in unified style for both internal or external type. The core structure is based on transaction, for that there is a qmp interface need to support , qmp_transaction, so all operations are packed as requests. In this way a sperate internal layer for

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Dietmar Maurer
This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Seems this makes it impossible to use external commands to make snapshots?

[Qemu-devel] [PATCH 0/3] Enable and Handle in-kernel watchdog emulation

2012-12-16 Thread Bharat Bhushan
The Patchset enables and handle the in-kernel watchdog emulation if KVM supports. The first Patch is synchronizes the Linux-headers as this is needed for enabling the in-kernel watchdog emulation. The Second Patch installs the timer reset handler and the Third patch enables and handles the

[Qemu-devel] [PATCH V9 2/4] Create four opts list related functions

2012-12-16 Thread Dong Xu Wang
This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. v6-v7): 1) Fix typo. v5-v6): 1) allocate enough space in append_opts_list function. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH V9 0/4] replace QEMUOptionParameter with QemuOpts parser

2012-12-16 Thread Dong Xu Wang
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 3 was changed according Paolo's comments. Patch 4-5: because qemu_opts_create can not fail while id is null, so create function

[Qemu-devel] [PATCH V9 4/4] remove QEMUOptionParameter related functions and struct

2012-12-16 Thread Dong Xu Wang
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- qemu-option.c | 285 - qemu-option.h | 32 --- 2 files changed, 0 insertions(+), 317 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 4a577e7..75b93ff 100644 ---

[Qemu-devel] [PATCH V9 1/4] add def_print_str and use it in qemu_opts_print.

2012-12-16 Thread Dong Xu Wang
qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print will be used while using qemu-img create, it will produce the same output as previous code. The behavior of this function has changed: 1. Print every possible option, whether a value has been set or not. 2.

[Qemu-devel] [PATCH 0/6] snapshot: take snapshots in unified way

2012-12-16 Thread Wenchao Xia
These patch added a seperated layer to take internal or external snapshots in a unified way, the granularity is block device, so other functions can just combine the request and submit, such as group snapshot, savevm. Total goal are: Live back up vm in external or internal image, which need

[Qemu-devel] [PATCH 6/6] snapshot: human monitor interface

2012-12-16 Thread Wenchao Xia
This patch add support in human monitor to create/delete/check internal snapshot on a single blk device. To make info command get parameter, added a new info handler type which can take QDict as parameter. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- hmp-commands.hx | 50

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Wenchao Xia
于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you referring? In group case a check should be

Re: [Qemu-devel] [PATCH v2 2/2] sheepdog: pass oid directly to send_pending_req()

2012-12-16 Thread MORITA Kazutaka
At Mon, 17 Dec 2012 14:17:27 +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com Cc: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Liu Yuan tailai...@taobao.com --- block/sheepdog.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH v2 1/2] sheepdog: don't update inode when create_and_write fails

2012-12-16 Thread MORITA Kazutaka
At Mon, 17 Dec 2012 14:17:26 +0800, Liu Yuan wrote: From: Liu Yuan tailai...@taobao.com For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-16 Thread Dietmar Maurer
于 2012-12-17 14:36, Dietmar Maurer 写道: This patch is the implemention of transaction based snapshot internal API. What exactly is the advantage of using qmp transactions (as opposed to the pve snapshot patches)? Which pve snapshot patches you referring? I refer to: