[Qemu-devel] [PATCH] tcg: Remove unneeded assertion

2012-12-29 Thread Stefan Weil
Commit 7f6f0ae5b95adfa76e10eabe2c34424a955fd10c added two assertions. One of these assertions is not needed: The pointer ts is never NULL because it is initialized with the address of an array element. Signed-off-by: Stefan Weil --- tcg/tcg.c |1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2012-12-29 Thread Amos Kong
On Sun, Dec 30, 2012 at 09:02:09AM +0800, Amos Kong wrote: > This patch added there options for filtering cases by logics, > > For example: > ./run -t qemu -c tests.cfg --oronly="WinXP Win7" --andonly="boot 64" > --not="sp1" Oh! a typo in commitlog ./run -t qemu -c tests.cfg --or="WinXP Win7"

[Qemu-devel] [Autotest PATCH 1/2] virt run: fix typo in help message

2012-12-29 Thread Amos Kong
type 'kvm' already been changed to 'qemu' Signed-off-by: Amos Kong --- run |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/run b/run index 97dcdad..aac332a 100755 --- a/run +++ b/run @@ -145,7 +145,7 @@ class VirtTestRunParser(optparse.OptionParser): general.

[Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2012-12-29 Thread Amos Kong
This patch added there options for filtering cases by logics, For example: ./run -t qemu -c tests.cfg --oronly="WinXP Win7" --andonly="boot 64" --not="sp1" (following cases will be executed) Test1: virtio_blk.smp2.virtio_net.WinXP.64.boot Test2: virtio_blk.smp2.virtio_net.Win7.64.boot

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-12-29 Thread Peter Schaefer
Referring to my last comment: The URL does only work if you add a backslash at the end, sorry about that. One last note: In Germany, the Kobil USB Reader is/was supplied by DATEV (see http://www.datev.com/) to their members/partners. So, anybody who's running DATEV software on kvm-virtualized syst

[Qemu-devel] [Bug 1033727] Re: USB passthrough doesn't work anymore with qemu-kvm 1.1.1

2012-12-29 Thread Peter Schaefer
Just confirming the bug. I'm having the same issues with the same USB smart card reader as the submitter (Kobil mIDentity) on Debian Squeeze using the qemu-kvm version 1.2.0 from debian-backports. Going back to 1.0 fixes the problem (http://snapshot.debian.org/package/qemu- kvm/1.0%2Bdfsg-8~bpo60%2

Re: [Qemu-devel] pixman dependency - compile issue

2012-12-29 Thread Erik Rull
Libtool was missing, works now :-) Erik Rull wrote: Hi all, with the current git master and the git submodule pixman, I get the following errors when trying to "make": erik@debian:~/qemu-test/qemu-now/qemu$ make GEN x86_64-softmmu/config-devices.mak GEN config-all-devices.mak GEN

[Qemu-devel] pixman dependency - compile issue

2012-12-29 Thread Erik Rull
Hi all, with the current git master and the git submodule pixman, I get the following errors when trying to "make": erik@debian:~/qemu-test/qemu-now/qemu$ make GEN x86_64-softmmu/config-devices.mak GEN config-all-devices.mak GEN config-host.h (cd /home/erik/qemu-test/qemu-now/qemu/

[Qemu-devel] [PATCH v3] tests: add gcov support

2012-12-29 Thread Blue Swirl
Add support for compiling for GCOV test coverage, enabled with '--enable-gcov' during configure. Test coverage will be reported after each test. Signed-off-by: Blue Swirl --- v3: report coverage after each test instead of after all tests improve setting up file lists: mechanical conversion cou

Re: [Qemu-devel] [PATCH] Disable semaphores fallback code for OpenBSD

2012-12-29 Thread Blue Swirl
On Fri, Dec 28, 2012 at 11:36 PM, Peter Maydell wrote: > On 28 December 2012 06:38, Brad Smith wrote: >> Disable the semaphores fallback code for OpenBSD as modern OpenBSD >> releases now have sem_timedwait(). > > Maybe we should have a configure test for existence of sem_timedwait() > rather tha

Re: [Qemu-devel] [PATCH] tcg-hppa: Fix typo in brcond2

2012-12-29 Thread Blue Swirl
Thanks, applied. On Fri, Dec 28, 2012 at 10:19 PM, Richard Henderson wrote: > Reported-by: Stuart Brady > Signed-off-by: Richard Henderson > --- > tcg/hppa/tcg-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcg/hppa/tcg-target.c b/tcg/hppa/tcg-target.c > inde

Re: [Qemu-devel] [PATCH] tcg-i386: Perform cmov detection at runtime for 32-bit.

2012-12-29 Thread Blue Swirl
Thanks, applied. On Fri, Dec 28, 2012 at 10:17 PM, Richard Henderson wrote: > Existing compile-time detection is spotty at best. Convert > it all to runtime detection instead. > > Signed-off-by: Richard Henderson > --- > configure | 19 +++ > tcg/i386/tcg-target.c |

Re: [Qemu-devel] [PATCH v2] tcg: Add TCGV_IS_UNUSED_*

2012-12-29 Thread Blue Swirl
Thanks, applied. On Fri, Dec 7, 2012 at 9:07 PM, Richard Henderson wrote: > Cc: Aurelien Jarno > Signed-off-by: Richard Henderson > --- > tcg/tcg-op.h | 2 ++ > tcg/tcg.h| 3 +++ > 2 files changed, 5 insertions(+) > > Changes since v1: > * Add tl-sized TCGV_IS_UNUSED to tcg-op.h. > > > r

Re: [Qemu-devel] [PATCH] Fix semaphores fallback code

2012-12-29 Thread Blue Swirl
Thanks, applied. On Fri, Dec 28, 2012 at 6:00 AM, Brad Smith wrote: > As reported in bug 1087114 the semaphores fallback code is broken which > results in QEMU crashing and making QEMU unusable. > > This patch is from Paolo. > > This needs to be back ported to the 1.3 stable tree as well. > > Sig

Re: [Qemu-devel] setting migrate_downtime results in halted vm (qemu 1.3)

2012-12-29 Thread Paolo Bonzini
Il 29/12/2012 16:19, Stefan Priebe ha scritto: >> >> >> I suppose it will be between 05e72dc5812a9f461fc2c606dff2572909eafc39 >> and aa723c23147e93fef8475bd80fd29e633378c34d. >> >> Probably at 2dddf6f4133975af62e64cb6406ec1239491fa89, which was supposed >> to be placed before switching to the migra

Re: [Qemu-devel] setting migrate_downtime results in halted vm (qemu 1.3)

2012-12-29 Thread Stefan Priebe
Am 29.12.2012 15:58, schrieb Paolo Bonzini: Il 29/12/2012 15:05, Stefan Priebe ha scritto: It starts working to me after the first 22 patches (after introducing the new mutex and threading for writes). And when does it break in 1.3? I suppose it will be between 05e72dc5812a9f461fc2c606dff2572

Re: [Qemu-devel] setting migrate_downtime results in halted vm (qemu 1.3)

2012-12-29 Thread Paolo Bonzini
Il 29/12/2012 15:05, Stefan Priebe ha scritto: > Hi Paolo, > Am 29.12.2012 15:00, schrieb Paolo Bonzini: >>> i cherry picked that one on top of 1.3 sadly it does not help. VM halts, >>> monitor socket is no longer available kvm process is running with 100% >>> CPU on source side. >> >> Can you plea

Re: [Qemu-devel] setting migrate_downtime results in halted vm (qemu 1.3)

2012-12-29 Thread Stefan Priebe
Hi Paolo, Am 29.12.2012 15:00, schrieb Paolo Bonzini: i cherry picked that one on top of 1.3 sadly it does not help. VM halts, monitor socket is no longer available kvm process is running with 100% CPU on source side. Can you please test master and, if it works, bisect it in reverse? (That is,

Re: [Qemu-devel] setting migrate_downtime results in halted vm (qemu 1.3)

2012-12-29 Thread Paolo Bonzini
Il 28/12/2012 20:03, Stefan Priebe ha scritto: > Hi Paolo, > > Am 28.12.2012 18:53, schrieb Paolo Bonzini: >> Il 28/12/2012 08:05, Alexandre DERUMIER ha scritto: >>> Hi list, >>> After discuss with Stefan Yesterday here some more info: >>> >>> (this is for stable qemu 1.3, it was working fine with

Re: [Qemu-devel] [PATCH v3 0/2] soft-float-fixes for target-s390x

2012-12-29 Thread Blue Swirl
On Fri, Dec 28, 2012 at 10:04 PM, Richard Henderson wrote: > Ping 2... Patch 2/2 doesn't apply due to reorganization, please rebase. > > r~ > > On 2012-12-20 11:45, Richard Henderson wrote: >> Ping? It's got reviews... >> >> r~ >> >> On 12/11/2012 09:21 AM, Richard Henderson wrote: >>> Changes

[Qemu-devel] [PATCH 04/11] qemu-img: move image retrieving function to block layer

2012-12-29 Thread Wenchao Xia
This patch moves collect_image_info() and collect_snapshot() to general block layer and encapsulate them as bdrv_query_image_info() and bdrv_query_snapshot_infolist(), as mirror function to brdv_query_info(). The called function in qemu-img.c is switched to bdrv_query_image_info(). To help filter

[Qemu-devel] [PATCH 09/11] hmp: export function hmp_handle_error()

2012-12-29 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp.c |2 +- hmp.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hmp.c b/hmp.c index 2465d9b..89a1a8c 100644 --- a/hmp.c +++ b/hmp.c @@ -23,7 +23,7 @@ #include "monitor/monitor.h" #include "ui/console.h" -static void hmp_handle_er

[Qemu-devel] [PATCH 05/11] block: rename bdrv_query_info to bdrv_query_block_info

2012-12-29 Thread Wenchao Xia
Now this function have a mirror name with bdrv_query_image_info to tip well what it is doing. Signed-off-by: Wenchao Xia --- block.c |4 ++-- include/block/block.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c index d39da3d..9dcec

[Qemu-devel] [PATCH 10/11] hmp: retrieve info from qmp for snapshot info

2012-12-29 Thread Wenchao Xia
With this patch, hmp command info snapshot simply call a block layer funtion which will return a qmp object, and then translate it in monitor console. Now snapshot info retrieving code in qemu and qemu-tool are merged by calling same block layer function, and then they just translate the qmp to s

[Qemu-devel] [PATCH 01/11] qemu-img: remove unused parameter in collect_image_info()

2012-12-29 Thread Wenchao Xia
Parameter *fmt was not used, so remove it. Signed-off-by: Wenchao Xia --- qemu-img.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 69cc028..5a4df3a 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1182,8 +1182,7 @@ static void dump_json_

[Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot

2012-12-29 Thread Wenchao Xia
This interface now return valid internal snapshots. Signed-off-by: Wenchao Xia --- block.c | 32 qapi-schema.json | 12 2 files changed, 44 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index d7eb213..ad058f9 100644 ---

[Qemu-devel] [PATCH 11/11] hmp: show snapshot on single block device

2012-12-29 Thread Wenchao Xia
This patch use block layer API to qmp snapshot info on a block device, then use the same code dumping vm snapshot info, to print in monitor. Note: This patch need previous hmp extention patch which enable info sub command take qdict * as paramter. Signed-off-by: Wenchao Xia --- monitor.c |

[Qemu-devel] [PATCH 07/11] block: move bdrv_find_snapshot to block.c

2012-12-29 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- block.c | 23 +++ include/block/block.h |2 ++ savevm.c | 22 -- 3 files changed, 25 insertions(+), 22 deletions(-) diff --git a/block.c b/block.c index 0e9f414..d7eb213 100644 --- a/block.c

[Qemu-devel] [PATCH 03/11] qemu-img: remove parameter filename in collect_image_info()

2012-12-29 Thread Wenchao Xia
Switch the filename getting from parameter to block function, now collect_image_info depends only on *bs. Signed-off-by: Wenchao Xia --- qemu-img.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 5a4df3a..d70435f 100644 --- a/qemu-i

[Qemu-devel] [PATCH 02/11] block: add bdrv_get_filename() function

2012-12-29 Thread Wenchao Xia
This function will simply return the uri or filename used to open the image. Signed-off-by: Wenchao Xia --- block.c |5 + include/block/block.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 4e28c55..5f95da5 100644 --- a/b

[Qemu-devel] [PATCH 06/11] qmp: add interface query-image

2012-12-29 Thread Wenchao Xia
This mirror function will return all image info including snapshots. Now Qemu have both query-image and query-block interfaces, and qemu-img share the code for image info retrieving with qemu emulator. Signed-off-by: Wenchao Xia --- block.c | 16 qapi-schema.json |

[Qemu-devel] [PATCH 00/11] add qmp/hmp interfaces for snapshot info

2012-12-29 Thread Wenchao Xia
This serial of patches does two things: merge some info code in qemu-img, and add following interfaces: 1) qmp: query-image 2) qmp: query-snapshot 3) hmp: show snapshot info on a single block device These patches follows the rule that use qmp to retieve information, hmp layer just do a translat