Re: [Qemu-devel] [PATCH 06/15] openpic: rework critical interrupt support

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 00:07, Scott Wood wrote: On 01/03/2013 12:31:47 PM, Alexander Graf wrote: On 22.12.2012, at 03:15, Scott Wood wrote: Critical interrupts on FSL MPIC are not supposed to pay attention to priority, IACK, EOI, etc. On the currently modeled version it's not supposed to pay

[Qemu-devel] [PATCH 3/4] apci: assign memory regions to piix4 acpi device

2013-01-04 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_piix4.c | 20 +--- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c index f53b969..06a8aca 100644 --- a/hw/acpi_piix4.c +++

Re: [Qemu-devel] [PATCH v2 0/4] openpic cleanups and fixes

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 00:25, Scott Wood wrote: Respin of the patches from the 12/21 patchset that were not already applied. Thanks, applied all to ppc-next. Alex Scott Wood (4): openpic: fix sense and priority bits openpic: IRQ_check: search the queue a word at a time openpic: move IACK

[Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Gerd Hoffmann
Hi, This patch series improves the debug devices we have. isa-debugcon is switched over to the memory api. isa-debug-exit is added and replaces the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests) is added. please pull, Gerd The following changes since commit

[Qemu-devel] [PATCH 1/4] configure: also symlink *.aml files

2013-01-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 9538041..1e9fd86 100755 --- a/configure +++ b/configure @@ -4240,6 +4240,7 @@ FILES=$FILES pc-bios/spapr-rtas/Makefile FILES=$FILES

[Qemu-devel] [PATCH 2/4] acpi: autoload dsdt

2013-01-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc.c | 23 +++ hw/pc.h |1 + hw/pc_piix.c |1 + hw/pc_q35.c |1 + 4 files changed, 26 insertions(+), 0 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 71902e2..5ec3bd5 100644 --- a/hw/pc.c +++

[Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2013-01-04 Thread qemu
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/503 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build:

[Qemu-devel] [PULL 0/4] acpi fixups

2013-01-04 Thread Gerd Hoffmann
Hi, This patch series carries a bunch of acpi bits: Some small incremental fixes for the memory api conversion and dsdt autoloading. The later makes q35 JustWork[tm] without explicit -acpitable switch. please pull, Gerd The following changes since commit

[Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_6_0

2013-01-04 Thread qemu
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/504 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

[Qemu-devel] [PATCH 2/4] add isa-debug-exit device.

2013-01-04 Thread Gerd Hoffmann
When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/debugexit.c| 75

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 05:22, Bhushan Bharat-R65777 wrote: -Original Message- From: Marcelo Tosatti [mailto:mtosa...@redhat.com] Sent: Friday, January 04, 2013 7:08 AM To: Alexander Graf Cc: jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori; qemu- de...@nongnu.org

[Qemu-devel] [PATCH 1/4] switch debugcon to memory api

2013-01-04 Thread Gerd Hoffmann
Also some QOM glue while being at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/debugcon.c | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/hw/debugcon.c b/hw/debugcon.c index 14f83f1..e8a855e 100644 --- a/hw/debugcon.c +++

[Qemu-devel] [PATCH 3/4] hw: Add test device for unittests execution

2013-01-04 Thread Gerd Hoffmann
From: Lucas Meneghel Rodrigues l...@redhat.com Add a test device which supports the kvmctl ioports, so one can run the KVM unittest suite. Intended Usage: qemu-system-x86_64 -nographic \ -device pc-testdev \ -device isa-debug-exit,iobase=0xf4,iosize=0x04 \ -kernel

[Qemu-devel] [PATCH 4/4] apci: assign memory regions to ich9 lpc device

2013-01-04 Thread Gerd Hoffmann
Get rid of get_system_io() usage. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi_ich9.c |6 -- hw/acpi_ich9.h |4 +++- hw/lpc_ich9.c |2 +- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index 37a50e6..d2f9808 100644

[Qemu-devel] [PATCH 4/4] pc: remove bochs bios debug ports

2013-01-04 Thread Gerd Hoffmann
Prehistoric leftover, zap it. We poweroff via acpi these days. And having a port (0x501,0x502) where any random guest write will make qemu exit -- with no way to turn it off -- is a bad joke anyway. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/pc.c | 41

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 09:57, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 2:11 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori;

Re: [Qemu-devel] [PATCH] QEMU: PPC: set has-idle in guest device tree

2013-01-04 Thread Alexander Graf
On 03.01.2013, at 23:37, Stuart Yoder wrote: From: Stuart Yoder stuart.yo...@freescale.com Signed-off-by: Stuart Yoder stuart.yo...@freescale.com Thanks, adjusted the patch slightly (fix to apply, add patch description) and applied it to ppc-next. Alex

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 2:11 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori; qemu-devel@nongnu.org qemu-devel Subject: Re: [Qemu-devel]

[Qemu-devel] [PATCH] pixman: pass extra cflags and ldflags

2013-01-04 Thread Gerd Hoffmann
Store --extra-cflags and --extra-ldflags in config-host.mak, then pass them on to the pixman configure script. Cc: Scott Wood scottw...@freescale.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |2 +- configure |4 2 files changed, 5 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH] rtc: skip year-2038 overflow check in case time_t is 32bit only

2013-01-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- tests/rtc-test.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 02edbf5..548200a 100644 --- a/tests/rtc-test.c +++ b/tests/rtc-test.c @@ -201,6 +201,10 @@ static void

Re: [Qemu-devel] [RFC V4 00/30] QCOW2 deduplication

2013-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2013 at 01:51:02PM -0600, Troy Benjegerdes wrote: On Thu, Jan 03, 2013 at 01:39:48PM +0100, Stefan Hajnoczi wrote: On Wed, Jan 02, 2013 at 12:26:37PM -0600, Troy Benjegerdes wrote: The probability may be 'low' but it is not zero. Just because it's hard to calculate the

Re: [Qemu-devel] pthread_create failed: Resource temporarily unavailable

2013-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2013 at 01:53:20PM -0500, Christoffer Dall wrote: On Thu, Jan 3, 2013 at 6:50 AM, Andreas Färber afaer...@suse.de wrote: The culprit seems to be when the process runs out of virtual address space on 32-bit systems due to some subsystem (virtio?) creating a large number of

[Qemu-devel] Qemu x86 segfault

2013-01-04 Thread Adam Lackorzynski
Hi, I'm seeing the following segfault of qemu-system-i386 and qemu-system-x86_64 with master. git bisect points to 258711c6448c44b60b0fecef1d3b09c71e23e304. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xea930b70 (LWP 14297)] 0x in ?? () (gdb) bt #0

Re: [Qemu-devel] [PATCH] rtc: skip year-2038 overflow check in case time_t is 32bit only

2013-01-04 Thread Andreas Färber
Am 04.01.2013 10:43, schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- tests/rtc-test.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c index 02edbf5..548200a 100644 --- a/tests/rtc-test.c +++

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 2:11 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori; qemu-devel@nongnu.org qemu-devel Subject: Re: [Qemu-devel]

[Qemu-devel] [PATCH] PPC: Bring EPR support closer to reality

2013-01-04 Thread Alexander Graf
We already used to support the external proxy facility of FSL MPICs, but only implemented it halfway correctly. This patch adds support for * dynamic enablement of the EPR facility * interrupt acknowledgement only when the interrupt is delivered This way the implementation now is closer to

[Qemu-devel] QEMU CDROM tray-open and locked logic

2013-01-04 Thread Peter Lieven
Hi, i have observed the following with qemu-kvm-1.2.0 which I think is not right: a) if the CDROM is locked and I sent a eject command I get the error that the CDROM is locked, but its ejected nevertheless. b) if I eject the CDROM in the OS I see tray-open=1 and locked=1. In the tray-open=1

Re: [Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Andreas Färber
Am 04.01.2013 09:16, schrieb Gerd Hoffmann: Hi, This patch series improves the debug devices we have. isa-debugcon is switched over to the memory api. isa-debug-exit is added and replaces the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests) is added. Missing some CCs,

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 11:23, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 2:11 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori;

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 3:59 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori; qemu-devel@nongnu.org qemu-devel Subject: Re: [Qemu-devel]

Re: [Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2013-01-04 Thread Andreas Färber
Am 04.01.2013 09:35, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/503 Buildbot URL:

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 11:32, Bhushan Bharat-R65777 wrote: -Original Message- Int timer_func(CPUxxState env) { Struct timer_regs; read_regs_type((env, timer_regs,TIMER_REGS); //update env-timer_registers Write_regs_type(env, TIMER_REGS) } This will get one type of

Re: [Qemu-devel] Using QEMU guest agent to run programs from guest path]

2013-01-04 Thread Erlon Cruz
The parameter passing for guest commands was kludgy (list of json objects rather than a list of parameter strings), but I think we can handle that now with the gen: no option to the code parser indicating we'll handle it manually. I'm not sure about the guest-file-open-pipe stuff either. It

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Bhushan Bharat-R65777
-Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 4:07 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori; qemu-devel@nongnu.org qemu-devel Subject: Re: [Qemu-devel]

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 12:01, Bhushan Bharat-R65777 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, January 04, 2013 4:07 PM To: Bhushan Bharat-R65777 Cc: Marcelo Tosatti; jjhe...@linux.vnet.ibm.com; Christian Borntraeger; Anthony Liguori;

Re: [Qemu-devel] [PATCH] rtc: skip year-2038 overflow check in case time_t is 32bit only

2013-01-04 Thread Gerd Hoffmann
Hi, +if (sizeof(time_t) == 32) { You sure that shouldn't be 4 then? Oops, yes. Should have waited for buildbot results ... cheers, Gerd

Re: [Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Gerd Hoffmann
Hi, This patch series improves the debug devices we have. isa-debugcon is switched over to the memory api. isa-debug-exit is added and replaces the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests) is added. Missing some CCs, and I was actually expecting another PATCH

Re: [Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Andreas Färber
Hi Gerd, Am 04.01.2013 13:57, schrieb Gerd Hoffmann: This patch series improves the debug devices we have. isa-debugcon is switched over to the memory api. isa-debug-exit is added and replaces the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests) is added. Missing some

Re: [Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2013-01-04 Thread Andreas Färber
Am 31.12.2012 20:55, schrieb Lucas Meneghel Rodrigues: Hmmm, about this one, I'm worried about making things more complex... The way I see the problem at hand, I'd say if people want to customize things, they'd be better of creating their own, specialized config files rather than adding

[Qemu-devel] buildbot failure in qemu on default_ppc

2013-01-04 Thread qemu
The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/517 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: qemu-ppc.opensuse.org Build

Re: [Qemu-devel] buildbot failure in qemu on default_arm_devs_next

2013-01-04 Thread Stefan Hajnoczi
On Fri, Jan 4, 2013 at 6:35 AM, q...@buildbot.b1-systems.de wrote: The Buildbot has detected a new failure on builder default_arm_devs_next while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_arm_devs_next/builds/0 Buildbot URL:

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2013-01-04 Thread Andreas Färber
Am 04.01.2013 14:21, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/517 Buildbot URL: http://buildbot.b1-systems.de/qemu/

Re: [Qemu-devel] [PULL 0/4] test and debug devices

2013-01-04 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, This patch series improves the debug devices we have. isa-debugcon is switched over to the memory api. isa-debug-exit is added and replaces the hard-coded bochs debug port. pc-testdev (used by kvm-unit-tests) is added. Missing some CCs,

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 14:37, Andreas Färber wrote: Am 04.01.2013 14:21, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_ppc while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_ppc/builds/517

Re: [Qemu-devel] buildbot failure in qemu on default_arm_devs_next

2013-01-04 Thread Peter Maydell
On 4 January 2013 13:32, Stefan Hajnoczi stefa...@gmail.com wrote: pm215: Please rebase onto a more recent qemu.git tree to eliminate this build failure. Done. (At the moment the branch is empty of queued patches so it's the same as git master.) -- PMM

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Jens Freimann
On Thu, Jan 03, 2013 at 01:50:22PM +0100, Alexander Graf wrote: On 18.12.2012, at 18:50, Jens Freimann wrote: Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com --- v2 - v3: * remove FIXME * separate

[Qemu-devel] [PULL 0/6] Trivial patches for 18 December 2012 to 4 January 2013

2013-01-04 Thread Stefan Hajnoczi
The following changes since commit 25bbf61e4bacd1e4fa4115ffcf151051b9d6608e: pty: unbreak libvirt (2013-01-03 12:53:41 -0600) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to bfb82a28752d29291adf932c3a9941e8383203af:

[Qemu-devel] [PATCH 2/6] pseries: Remove unneeded include statement (fixes MinGW builds)

2013-01-04 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de sys/mman.h is not needed (tested on Linux) and unavailable for MinGW, so remove it. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/spapr_nvram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 4/6] hw/mcf5206: Reduce size of lookup table

2013-01-04 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de This typically reduces the size from 512 bytes to 128 bytes. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/mcf5206.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mcf5206.c

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-04 Thread Eric Blake
On 01/03/2013 11:02 PM, Wenchao Xia wrote: +# case, it is the internal snapshot record's name and if it is +# 'blank' name will be generated according to time. Ugg. Passing an empty string for snapshot-file as a special case seems awkward; it might be

Re: [Qemu-devel] [RFC V9 09/12] virtio-blk-pci : switch to new API.

2013-01-04 Thread KONRAD Frédéric
On 03/01/2013 15:52, fred.kon...@greensocs.com wrote: + +static int virtio_blk_pci_init(VirtIOPCIProxy *vpci_dev) +{ +VirtIOBlkPCI *dev = VIRTIO_BLK_PCI(vpci_dev); +virtio_blk_set_conf(dev-vdev, (dev-blk)); +qdev_set_parent_bus(dev-vdev, BUS(vpci_dev-bus)); +if

[Qemu-devel] [PATCH 6/6] spice: drop incorrect vm_change_state_handler() opaque

2013-01-04 Thread Stefan Hajnoczi
The spice_server pointer is a global variable and vm_change_state_handler() therefore does not use its opaque parameter. The vm change state handler is added with a pointer to the spice_server pointer. This is useless and we probably would not want 2 levels of pointers. Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Jens Freimann
On Thu, Jan 03, 2013 at 01:55:19PM +0100, Alexander Graf wrote: On 18.12.2012, at 18:50, Jens Freimann wrote: Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com --- v2 - v3: * remove FIXME * separate

Re: [Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 15:09, Jens Freimann wrote: On Thu, Jan 03, 2013 at 01:55:19PM +0100, Alexander Graf wrote: On 18.12.2012, at 18:50, Jens Freimann wrote: Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com ---

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2013-01-04 Thread Gerd Hoffmann
CCqemu-timer.o cc1: warnings being treated as errors In file included from /home/build/qemu/default_ppc/build/include/ui/qemu-pixman.h:9, from /home/build/qemu/default_ppc/build/include/ui/console.h:4, from qemu-timer.c:27:

[Qemu-devel] [PATCH 5/6] linux-user/syscall.c: remove forward declarations

2013-01-04 Thread Stefan Hajnoczi
From: John Spencer maillist-q...@barfooze.de instead use the correct headers that define these functions. Requested-by: Stefan Weil s...@weilnetz.de Signed-off-by: John Spencer maillist-q...@barfooze.de Reviewed-by: Amos Kong kongjian...@gmail.com Reviewed-by: Stefan Weil s...@weilnetz.de

Re: [Qemu-devel] buildbot failure in qemu on default_ppc

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 15:12, Gerd Hoffmann wrote: CCqemu-timer.o cc1: warnings being treated as errors In file included from /home/build/qemu/default_ppc/build/include/ui/qemu-pixman.h:9, from /home/build/qemu/default_ppc/build/include/ui/console.h:4, from

Re: [Qemu-devel] [Autotest] [Autotest PATCH 2/2] virt run: add three logical case filters

2013-01-04 Thread Lucas Meneghel Rodrigues
On 01/04/2013 11:13 AM, Andreas Färber wrote: Am 31.12.2012 20:55, schrieb Lucas Meneghel Rodrigues: Hmmm, about this one, I'm worried about making things more complex... The way I see the problem at hand, I'd say if people want to customize things, they'd be better of creating their own,

[Qemu-devel] [PATCH 3/6] Remove --sparc_cpu option from the configure list

2013-01-04 Thread Stefan Hajnoczi
From: 陳韋任 (Wei-Ren Chen) che...@iis.sinica.edu.tw commit 9b9c37c36439ee0452632253dac7a31897f27f70 always assume sparcv9, the others are no longer supported. Remove --sparc_cpu option from the configure list. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 09/20 v2] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Igor Mammedov
Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: place x86cpu_vendor_words2str() a bit earlier, before feature arrays to avoid compile error when vendor property is converted into static property. --- target-i386/cpu.c | 21

Re: [Qemu-devel] [RFC V4 01/30] qcow2: Add deduplication to the qcow2 specification.

2013-01-04 Thread Benoît Canet
+L2 tables size 64KB is different from +cluster size 4KB. Umm, doesn't the cluster_bits (bytes 20-23 of the header) determine the size of a cluster, rather than assuming a cluster is always 4KB? And later on, the spec says

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:25:04PM +0800, Wenchao Xia wrote: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. I suggest naming the patch block: export bdrv_snapshot_find() because it is more specific than snapshot: export function

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-04 Thread Stefano Stabellini
On Thu, 3 Jan 2013, Ian Campbell wrote: On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, if first call to bdrv_open fails with errno = EINVAL, try a second call without BDRV_O_NOCACHE. Doesn't that risk

Re: [Qemu-devel] [PATCH 2/6] snapshot: add error set function

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:25:05PM +0800, Wenchao Xia wrote: This patch has nothing to do with snapshots, so snapshot: add error set function is not a useful commit message. error: add error_set_replace() would be okay. Please use git log filename on the file you are modifying to find good

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-04 Thread Roger Pau Monné
On 04/01/13 15:54, Stefano Stabellini wrote: On Thu, 3 Jan 2013, Ian Campbell wrote: On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, if first call to bdrv_open fails with errno = EINVAL, try a second call without

Re: [Qemu-devel] [PATCH RFC 2/3] xen_disk: fix memory leak

2013-01-04 Thread Stefano Stabellini
On Mon, 31 Dec 2012, Roger Pau Monne wrote: On ioreq_release the full ioreq was memset to 0, loosing all the data and memory allocations inside the QEMUIOVector, which leads to a memory leak. Create a new function to specifically reset ioreq. Reported-by: Maik Wessler maik.wess...@yahoo.com

Re: [Qemu-devel] [Autotest PATCH 2/2] virt run: add three logical case filters

2013-01-04 Thread Gerd Hoffmann
Hi, So while I am impartial to this specific patch, some easy way to run a comprehensive test coverage without having to manually name each test using --tests= would be very handy! Something like --all-tests maybe? Hint from the dirty tricks department: --tests=JeOS will do (for

[Qemu-devel] [PATCH 0/2] Disable kvm_mmu_op by default on pc-1.4

2013-01-04 Thread Eduardo Habkost
The kvm_mmu_op feature was removed from the kernel since v3.3 (released in March 2012), it was marked for removal since January 2011 and it's slower than shadow or hardware assisted paging (see kernel commit fb92045843). It doesn't make sense to keep it enabled by default. Also, keeping it

Re: [Qemu-devel] [PATCH] pixman: fix warning

2013-01-04 Thread Peter Maydell
On 4 January 2013 14:59, Gerd Hoffmann kra...@redhat.com wrote: Cc: afaer...@suse.de Cc: ag...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-pixman.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/ui/qemu-pixman.h

[Qemu-devel] [PATCH] pixman: fix warning

2013-01-04 Thread Gerd Hoffmann
Cc: afaer...@suse.de Cc: ag...@suse.de Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/qemu-pixman.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/include/ui/qemu-pixman.h b/include/ui/qemu-pixman.h index 3c05c83..63b8ccc 100644 ---

[Qemu-devel] [PATCH 2/2] target-i386: Disable kvm_mmu_op by default on pc-1.4

2013-01-04 Thread Eduardo Habkost
The kvm_mmu_op feature was removed from the kernel since v3.3 (released in March 2012), it was marked for removal since January 2011 and it's slower than shadow or hardware assisted paging (see kernel commit fb92045843). It doesn't make sense to keep it enabled by default. Also, keeping it

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Jason J. Herne
If I've followed the conversation correctly this is what needs to be done: 1. Remove the level parameters from kvm_arch_get_registers and kvm_arch_put_registers. 2. Add a new bitmap parameter to kvm_arch_get_registers and kvm_arch_put_registers. 3. Define a bit that correlates to our

[Qemu-devel] [PATCH 1/2] target-i386: Don't set any KVM flag by default if KVM is disabled

2013-01-04 Thread Eduardo Habkost
This is a cleanup that tries to solve two small issues: - We don't need a separate kvm_pv_eoi_features variable just to keep a constant calculated at compile-time, and this style would require adding a separate variable (that's declared twice because of the CONFIG_KVM ifdef) for each

Re: [Qemu-devel] [Xen-devel] [PATCH RFC 1/3] xen_disk: handle disk files on ramfs/tmpfs

2013-01-04 Thread Stefano Stabellini
On Fri, 4 Jan 2013, Roger Pau Monne wrote: On 04/01/13 15:54, Stefano Stabellini wrote: On Thu, 3 Jan 2013, Ian Campbell wrote: On Mon, 2012-12-31 at 12:16 +, Roger Pau Monne wrote: Files that reside on ramfs or tmpfs cannot be opened with O_DIRECT, if first call to bdrv_open fails

[Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Onkar N Mahajan
Running qemu-img commit on QED image emits the below message even if the image is never committed. This patch fixes this. Do we need to do any L1, L2 table cleanup here ? I see that cleanup code is commented out in the case of qcow2 (qcow2_make_empty). before patching - # qemu-img commit -f qed

[Qemu-devel] [PATCH 7/9] target-i386: check/enforce: Eliminate check_feat field

2013-01-04 Thread Eduardo Habkost
Now that all entries have check_feat=~0 on kvm_check_features_against_host(), we can eliminate check_feat entirely and make the code check all bits. This patch shouldn't introduce any behavior change, as check_feat is set to ~0 on all entries. Signed-off-by: Eduardo Habkost ehabk...@redhat.com

[Qemu-devel] [PATCH 9/9] target-i386: check/enforce: Check all feature words

2013-01-04 Thread Eduardo Habkost
This adds the following feature words to the list of flags to be checked by kvm_check_features_against_host(): - cpuid_7_0_ebx_features - ext4_features - kvm_features - svm_features This will ensure the enforce flag works as it should: it won't allow QEMU to be started unless every flag that

[Qemu-devel] [PATCH 3/9] target-i386: check/enforce: Fix CPUID leaf numbers on error messages

2013-01-04 Thread Eduardo Habkost
The -cpu check/enforce warnings are printing incorrect information about the missing flags. There are no feature flags on CPUID leaves 0 and 0x8000, but there were references to 0 and 0x8000 in the table at kvm_check_features_against_host(). This changes the model_features_t struct to

Re: [Qemu-devel] [PATCH 6/6] snapshot: human monitor interface

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:25:09PM +0800, Wenchao Xia wrote: @@ -983,17 +983,22 @@ ETEXI { .name = snapshot_blkdev, -.args_type = reuse:-n,device:B,snapshot-file:s?,format:s?, -.params = [-n] device [new-image-file] [format], -.help =

Re: [Qemu-devel] [PATCH] pixman: fix warning

2013-01-04 Thread Gerd Hoffmann
Hi, +/* pixman-0.16.0 headers have a redundant declaration */ +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored -Wredundant-decls #include pixman.h +#pragma GCC diagnostic pop IIRC we can't rely on gcc knowing about 'diagnostic push/pop' -- eg in coroutine-ucontext.c we

Re: [Qemu-devel] [PATCH 09/20 v2] target-i386: add x86cpu_vendor_words2str()

2013-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2013 at 03:25:36PM +0100, Igor Mammedov wrote: Make for() cycle reusable for the next patch Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: place x86cpu_vendor_words2str() a bit earlier, before feature arrays to avoid compile error when vendor property is

[Qemu-devel] [PATCH 1/9] target-i386: kvm: -cpu host: Use GET_SUPPORTED_CPUID for SVM features

2013-01-04 Thread Eduardo Habkost
The existing -cpu host code simply set every bit inside svm_features (initializing it to -1), and that makes it impossible to make the enforce/check options work properly when the user asks for SVM features explicitly in the command-line. So, instead of initializing svm_features to -1, use

[Qemu-devel] [PATCH 0/9] target-i386: make enforce flag work as it should

2013-01-04 Thread Eduardo Habkost
This changes the -cpu check/enforce code to work as it should: it will check every single CPUID bit to make sure it is supported by the host. The changes are a bit intrusive, but: - The longer we take to make enforce strict as it should (and make libvirt finally use it), more users will have

[Qemu-devel] [PATCH 8/9] target-i386: Call kvm_check_features_against_host() only if CONFIG_KVM is set

2013-01-04 Thread Eduardo Habkost
This will be necessary once kvm_check_features_against_host() starts using KVM-specific definitions (so it won't compile anymore if CONFIG_KVM is not set). Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- target-i386/cpu.c | 4 1 file changed, 4 insertions(+) diff --git

[Qemu-devel] [PATCH 6/9] target-i386: check/enforce: Check SVM flag support as well

2013-01-04 Thread Eduardo Habkost
When nested SVM is supported, the kernel returns the SVM flag on GET_SUPPORTED_CPUID[1], so we can check the SVM flag safely on kvm_check_features_against_host(). I don't know why the original code ignored the SVM flag. Maybe it was because kvm_cpu_fill_host() used the CPUID instruction directly

[Qemu-devel] [PATCH 4/9] target-i386: check/enforce: Do not ignore hypervisor flag

2013-01-04 Thread Eduardo Habkost
We don't need any hack to ignore CPUID_EXT_HYPERVISOR anymore, because kvm_arch_get_supported_cpuid() now set CPUID_EXT_HYPERVISOR properly. So, this shouldn't introduce any behavior change, but it makes the code simpler. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- My goal is to

[Qemu-devel] [PATCH 2/9] target-i386: kvm: Enable all supported KVM features for -cpu host

2013-01-04 Thread Eduardo Habkost
When using -cpu host, we don't need to use the kvm_default_features variable, as the user is explicitly asking QEMU to enable all feature supported by the host. This changes the kvm_cpu_fill_host() code to use GET_SUPPORTED_CPUID to initialize the kvm_features field, so we get all host KVM

[Qemu-devel] [PATCH 5/9] target-i386: check/enforce: Check all CPUID.80000001H.EDX bits

2013-01-04 Thread Eduardo Habkost
I have no idea why PPRO_FEATURES was being ignored on the check of the CPUID.8001H.EDX bits. I believe it was a mistake, and it was supposed to be ~(PPRO_FEATURES CPUID_EXT2_AMD_ALIASES) or just ~CPUID_EXT2_AMD_ALIASES, because some time ago kvm_cpu_fill_host() used the CPUID instruction

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/3 v2] Reset qemu timers when guest reset

2013-01-04 Thread Scott Wood
On 01/03/2013 07:28:49 PM, Bhushan Bharat-R65777 wrote: -Original Message- From: Wood Scott-B07421 Sent: Friday, January 04, 2013 1:51 AM To: Bhushan Bharat-R65777 Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; ag...@suse.de; Bhushan Bharat- R65777 Subject: Re: [Qemu-ppc]

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2013-01-04 Thread Stefan Hajnoczi
On Fri, Dec 21, 2012 at 06:20:40AM +, Dietmar Maurer wrote: If libvirt could integrate external tool using code, that would be great. For qemu, My understanding is just to take internal snapshot and stop vm, You just need to save VM state, flush all IO requests, then stop.

Re: [Qemu-devel] [RFC PATCH v4 19/30] Implement info memory-total and query-memory-total

2013-01-04 Thread Eric Blake
On 12/18/2012 05:41 AM, Vasilis Liaskovitis wrote: Returns total physical memory available to guest in bytes, including hotplugged memory. Note that the number reported here may be different from what the guest sees e.g. if the guest has not logically onlined hotplugged memory. This

Re: [Qemu-devel] [PATCH 5/6] snapshot: qmp interface

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 17, 2012 at 02:25:08PM +0800, Wenchao Xia wrote: @@ -1478,16 +1497,39 @@ # # @device: the name of the device to generate the snapshot from. # -# @snapshot-file: the target of the new image. A new file will be created. +# @snapshot-file: the target name of the snapshot. In

Re: [Qemu-devel] [PATCH 7/7] KVM regsync: Fix do_kvm_cpu_synchronize_state data integrity issue

2013-01-04 Thread Alexander Graf
On 04.01.2013, at 16:25, Jason J. Herne wrote: If I've followed the conversation correctly this is what needs to be done: 1. Remove the level parameters from kvm_arch_get_registers and kvm_arch_put_registers. 2. Add a new bitmap parameter to kvm_arch_get_registers and

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-04 Thread Stefan Hajnoczi
On Thu, Jan 03, 2013 at 09:43:53PM +0800, Liu Yuan wrote: On 12/25/2012 04:45 PM, Liu Yuan wrote: Well, I found setting cache=directsync will contain 'BDRV_O_CACHE_WB'. Is this a bug for current master? If no, my current scheme will be the only way to bypass cache of sheepdog. Ping. Can

Re: [Qemu-devel] [PATCH RFC 3/3] xen_disk: add persistent grant support to xen_disk backend

2013-01-04 Thread Stefano Stabellini
On Mon, 31 Dec 2012, Roger Pau Monne wrote: This protocol extension reuses the same set of grant pages for all transactions between the front/back drivers, avoiding expensive tlb flushes, grant table lock contention and switches between userspace and kernel space. The full description of the

Re: [Qemu-devel] [Bug 1094950] [NEW] crash at qemu_iohandler_poll (iohandler.c:124) on macos 10.8.2

2013-01-04 Thread Stefan Hajnoczi
On Mon, Dec 31, 2012 at 08:46:45PM -, Christopher Mason wrote: Public bug reported: I'm seeing consistent hangs / crashes on MacOS 10.8.2 with 1.3.0. I've tried both gcc-4.2 and clang. I've tried a half a dozen different images/kernels. Which QEMU version are you building? Have you

Re: [Qemu-devel] [FYI] Testing new patch management scripts...

2013-01-04 Thread Stefan Hajnoczi
On Wed, Jan 02, 2013 at 12:07:57PM -0600, Anthony Liguori wrote: Over the holiday, I spent some time overhauling my patch tracking scripts. One new feature is automated responses so you will start seeing some additional mail on the list. Notably: 1) My 'Thanks, applied.' mails are now

Re: [Qemu-devel] [PATCH 04/11] qemu-img: move image retrieving function to block layer

2013-01-04 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: This patch moves collect_image_info() and collect_snapshot() to general block layer and encapsulate them as bdrv_query_image_info() and bdrv_query_snapshot_infolist(), as mirror function to brdv_query_info(). The called function in qemu-img.c is

[Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Onkar N Mahajan
Running qemu-img commit on QED image gives this message even if the image is never committed. This patch fixes this. Do we need to do any L1, L2 table cleanup here ? I see that cleanup code is commented out in the case of qcow2 (qcow2_make_empty). before patching - # qemu-img commit -f qed

Re: [Qemu-devel] [PATCH] Fix : Enable qemu-img QED image commit support.

2013-01-04 Thread Stefan Hajnoczi
On Fri, Jan 04, 2013 at 09:02:28PM +0530, Onkar N Mahajan wrote: @@ -695,7 +695,7 @@ static int coroutine_fn bdrv_qed_co_is_allocated(BlockDriverState *bs, static int bdrv_qed_make_empty(BlockDriverState *bs) { -return -ENOTSUP; +return 0; } The only .bdrv_make_empty() caller

  1   2   3   >