Il 12/01/2013 00:42, Richard Henderson ha scritto:
> This patch set is extracted from Paolo's target-i386 eflags2
> optimization branch:
>
> git://github.com/bonzini/qemu.git eflags2
>
> I've cherry-picked 3 patches and rebased them vs master. I've
> made a few trivial changes to the patches:
Am 11.01.2013 17:41, schrieb Julien Grall:
The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
for i386. ULL need to be specify for uint64_t value.
Signed-off-by: Julien Grall
---
hw/pc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c
What's the best way to debug the qemu user space emulation? I read this:
http://wiki.qemu.org/Documentation/Debugging
but that seems to mainly refer to the qemu machine emulation.
I added -ggdb to QEMU_CFLAGS in config-host.mak so it builds with debug
symbols but gdb still doesn't provide an
Begining to think this is memory corruption because of the number of
different failure modes. In addition to the crashes in the initial
report I have also seen the following:
qemu: uncaught target signal 4 (Illegal instruction) - core dumped
More temporaries freed than allocated!
TCG
I can also comple a purely static version of the test program in the
armhf chroot using:
gcc -Wall -static -pthread dotprod_mutex.c -o dotprod-mutex-static
and then run it simply using:
qemu-arm-static dotprod-mutex-static
which fails just like it does in the chroot.
--
You received t
Public bug reported:
Currently running QEMU from git (fedf2de31023) and running the armhf version of
qemu-user-static which I have renamed qemu-armhf-static to follow the naming
convention used in Debian.
The host systems is a Debian testing x86_64-linux and I have an Debian
testing armhf chro
I sent a patch on the mailing-list one hour ago.
http://www.mail-archive.com/qemu-devel@nongnu.org/msg148708.html
On Fri, Jan 11, 2013 at 11:47 PM, Andreas Färber wrote:
> Am 11.01.2013 23:06, schrieb q...@buildbot.b1-systems.de:
>> The Buildbot has detected a new failure on builder default_i386
From: Paolo Bonzini
Add a "mask" field to the tcg_temp_info struct. A bit that is zero
in "mask" will always be zero in the corresponding temporary.
Zero bits in the mask can be produced from moves of immediates,
zero-extensions, ANDs with constants, shifts; they can then be
be propagated by log
From: Paolo Bonzini
The next patch will add to the TCG optimizer a field that should be
non-zero in the default case. Thus, replace the memset of the
temps array with a loop. Only the state field has to be up-to-date,
because others are not used except if the state is TCG_TEMP_COPY
or TCG_TEMP_
Am 11.01.2013 23:06, schrieb q...@buildbot.b1-systems.de:
> The Buildbot has detected a new failure on builder default_i386_rhel61 while
> building qemu.
> Full details are available at:
> http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/483
>
> Buildbot URL: http://buildbo
From: Paolo Bonzini
This adds two optimizations using the non-zero bit mask. In some cases
involving shifts or ANDs the value can become zero, and can thus be
optimized to a move of zero. Second, useless zero-extension or an
AND with constant can be detected that would only zero bits that are
a
This patch set is extracted from Paolo's target-i386 eflags2
optimization branch:
git://github.com/bonzini/qemu.git eflags2
I've cherry-picked 3 patches and rebased them vs master. I've
made a few trivial changes to the patches:
* Extracting reset_all_temps as a function,
* Fixing a few t
Hi,
I was making some changes to qemu and for a particular change I needed to
stop the host_alarm_handler being called because of SIGALRM.
To disable any SIGALRM being generated, I changed
ev.sigev_notify = SIGEV_NONE;
in *dynticks_start_timer *from ev.sigev_notify = SIGEV_SIGNAL. Yet
I see th
From: Paolo Bonzini
Signed-off-by: Paolo Bonzini
Signed-off-by: Richard Henderson
---
tcg/i386/tcg-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
index e083874..7aec304 100644
--- a/tcg/i386/tcg-target.c
+++ b/tcg/i386
The commit c02e1eac887b1b0aee7361b1fcf889e7d47fed9d broke the compilation
for i386. ULL need to be specify for uint64_t value.
Signed-off-by: Julien Grall
---
hw/pc.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index dfa3144..ba1f19d 100644
--- a/
The Buildbot has detected a new failure on builder default_i386_rhel61 while
building qemu.
Full details are available at:
http://buildbot.b1-systems.de/qemu/builders/default_i386_rhel61/builds/483
Buildbot URL: http://buildbot.b1-systems.de/qemu/
Buildslave for this Build: kraxel_rhel61_32bit
Could anybody review it?
On 12/21/2012 05:46 PM, Satoru Moriya wrote:
> Changelog
> v1 -> v2
> - add RFC tag again
> - change semantics as follows
>- set event threads' priority to maxprio
>- set vcpu threads' priority to maxprio - 1
> - isolate all the posix stuff and put them into os_
On 01/11/2013 11:15 AM, Eduardo Habkost wrote:
> Add checks for the following cases:
>
> * Empty string: will be ignored and won't set any CPU bitmap,
> parser won't abort.
> * Missing end value after "-": parser will abort.
> * Extra characters after a valid CPU range: parser will abort.
> * "N
On Fri, Jan 11, 2013 at 02:06:05PM -0700, Eric Blake wrote:
> On 01/11/2013 11:15 AM, Eduardo Habkost wrote:
> > Extract the code that's specific for the "node" -numa option type (the
> > only one, today) to a separate function.
> >
> > The extracted code will eventually become a function specific
On 01/11/2013 11:15 AM, Eduardo Habkost wrote:
> Extract the code that's specific for the "node" -numa option type (the
> only one, today) to a separate function.
>
> The extracted code will eventually become a function specific for a
> "numa-node" config section, independent from the numa_add() c
Am 11.01.2013 14:40, schrieb Wolfgang Mauerer:
For slow targets and fast hosts, the emulation may be faster
than the actual hardware, which can be undesirable for various
reasons. Add a run-time option to slow down the emulation
by sleeping in the CPU emulation.
Signed-off-by: Wolfgang Mauerer
-
Prepare an instance_init function for the MemoryRegion init.
Signed-off-by: Andreas Färber
Cc: Hervé Poussineau
---
hw/pc87312.c | 26 ++
hw/pc87312.h |2 ++
2 Dateien geändert, 24 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-)
diff --git a/hw/pc87312.c b/hw/pc87312.
Hi Luiz,
On (Tue) 18 Dec 2012 [18:16:55], Luiz Capitulino wrote:
> The auto-ballooning feature automatically performs balloon inflate
> or deflate based on host and guest memory pressure. This can help to
> avoid swapping or worse in both, host and guest.
>
> Auto-ballooning has a host and a gues
12.01.2013 00:12, Michael Tokarev wrote:
Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too
What these *.aml things are needed for? How they're being used?
Um, found them, n/m:
hw/pc_q35.c:pc_acpi_init("q35-acpi-dsdt.aml");
hw/pc_piix.c:pc_acpi_init("acpi
Am 11.01.2013 18:25, schrieb Alberto Garcia:
> The TPCI200 is a PCI board that supports up to 4 IndustryPack modules.
>
> A new bus type called 'IndustryPack' has been created so any
> compatible module can be attached to this board.
>
> Signed-off-by: Alberto Garcia
Reviewed-by: Andreas Färber
On Fri, 11 Jan 2013 16:44:49 +0100
Wolfgang Mauerer wrote:
> On 11/01/13 16:23, Andreas Färber wrote:
> > Am 11.01.2013 16:00, schrieb Peter Maydell:
> >> On 11 January 2013 13:42, Wolfgang Mauerer
> >> wrote:
> >>> The configuration register for the onboard LEDs is
> >>> emulated, but the stat
11.01.2013 12:52, Gerd Hoffmann wrote:
Hi,
The biggest change is the machine type renaming patch.
Laszlo Ersek (1):
Makefile: install the "acpi-dsdt.aml" and "q35-acpi-dsdt.aml" blobs too
What these *.aml things are needed for? How they're being used?
Thanks,
/mjt
On Fri, 11 Jan 2013 17:14:03 +0800
Wenchao Xia wrote:
> This fix the case when user input "@command ". Original
> it will return NULL for monitor_parse_command(), now
> it will return the @command related instance.
>
> Signed-off-by: Wenchao Xia
> ---
> monitor.c |3 +++
> 1 files change
On Fri, Jan 11, 2013 at 08:46:35AM -0700, Alex Williamson wrote:
> On Fri, 2013-01-11 at 08:45 +, Pandarathil, Vijaymohan R wrote:
> >
> > > -Original Message-
> > > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > > Sent: Wednesday, January 09, 2013 11:05 AM
> > > To: Pan
Without this check, qemu-kvm will corrupt memory if a too-large nodeid
is provided in the command-line. e.g.:
-numa node,mem=...,cpus=...,nodeid=65
Signed-off-by: Eduardo Habkost
---
vl.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/vl.c b/vl.c
index 19010fa..31175f6 100644
--- a/
This will make it easier to refactor that code later.
Signed-off-by: Eduardo Habkost
---
vl.c | 40 ++--
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/vl.c b/vl.c
index 2c3bbb9..03a826e 100644
--- a/vl.c
+++ b/vl.c
@@ -1052,15 +1052,33 @@ cha
As libvirt already uses this format and expects it to work, add a small
hack to the legacy -numa option parsing code to make the "cpus=A,B,C,D"
format work.
Signed-off-by: Eduardo Habkost
---
vl.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/vl.c b/vl.c
index 14bf9b6..cf30d44
Add checks for the following cases:
* Empty string: will be ignored and won't set any CPU bitmap,
parser won't abort.
* Missing end value after "-": parser will abort.
* Extra characters after a valid CPU range: parser will abort.
* "N-M" string where M < N: parser will abort.
Signed-off-by: Ed
This allows "," or ";" to be used a separator between each CPU range.
Note that commas inside key=value command-line options have to be
escaped using ",,", so the command-line will look like:
-numa node,cpus=A,,B,,C,,D
or:
-numa node,cpus=A;B;C;D
Note that the following format, currently us
The numa_add() code was unconditionally adding 1 to the get_opt_name()
return value, making it point after the end of the string if no ','
separator is present.
Example of weird behavior caused by the bug:
$ qemu-img create -f qcow2
this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2 5G
Fo
This series contains the following:
* Patches 1-7 are multiple bug fixes to the current code
* Patch 8 introduce a feature that libvirt requires since a long time,
and even tries to use it today (in a way that doesn't work,
using the "-numa node,cpus=1,2,3,4" format): having non-contiguous
On Wed, Dec 12, 2012 at 02:46:21PM +0100, Paolo Bonzini wrote:
> diff --git a/hbitmap.c b/hbitmap.c
> new file mode 100644
> index 000..ae59f39
> --- /dev/null
> +++ b/hbitmap.c
> @@ -0,0 +1,400 @@
> +/*
> + * Hierarchical Bitmap Data Type
> + *
> + * Copyright Red Hat, Inc., 2012
> + *
> + * A
Am 11.01.2013 19:11, schrieb Paolo Bonzini:
> Brad and Peter,
>
> as far as I know OpenBSD and Linux/ARM were the main users of
> coroutine-gthread. Do you think we could dump it and rely on
> coroutine-sigaltstack only? The differences in signal handling of the
> gthread implementation always w
Instead of silently ignoring them, abort in case an invalid -numa option
is provided.
Signed-off-by: Eduardo Habkost
---
vl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vl.c b/vl.c
index 93fde36..042cc7f 100644
--- a/vl.c
+++ b/vl.c
@@ -1101,6 +1101,9 @@ static void numa_add(const ch
Instead of checking the limit before calling numa_add(), check the limit
only when we already know we're going to add a new node.
Signed-off-by: Eduardo Habkost
---
vl.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 94cc6fd..2c3bbb9 100644
--- a/v
Extract the code that's specific for the "node" -numa option type (the
only one, today) to a separate function.
The extracted code will eventually become a function specific for a
"numa-node" config section, independent from the numa_add() code.
Signed-off-by: Eduardo Habkost
---
vl.c | 75
This introduces both a "-numa-node" command-line option that is parsed
using a pure qemu_opts_parse() call, and a "numa-node" config file
section.
As the -numa option has a non-standard syntax, parse it manually and
translate it "numa-node" config options.
Signed-off-by: Eduardo Habkost
---
qem
Brad and Peter,
as far as I know OpenBSD and Linux/ARM were the main users of
coroutine-gthread. Do you think we could dump it and rely on
coroutine-sigaltstack only? The differences in signal handling of the
gthread implementation always worried me.
What versions of OpenBSD would we have to dr
On Fri, Jan 11, 2013 at 11:25:02AM +0100, Markus Armbruster wrote:
> We detect errors in seven places. One reports with g_error(), which
Do you mean "in several places"? I can fix this in tree.
> calls abort(), the others report with g_critical(). Three of them
> exit(), three return false.
>
On Fri, Jan 11, 2013 at 11:25:01AM +0100, Markus Armbruster wrote:
> Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Michael Roth
> ---
> qga/channel-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index 5579
On Fri, Jan 11, 2013 at 11:24:57AM +0100, Markus Armbruster wrote:
> For clarity, and to hush up Coverity.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Michael Roth
> ---
> qga/main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/main.c b/qga/main.c
> index a9b968c..47a6b
On Fri, Jan 11, 2013 at 11:24:59AM +0100, Markus Armbruster wrote:
> Spotted by Coverity. Also document why we keep it open on success.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Michael Roth
> ---
> qga/main.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qga/main.c b/q
On Fri, Jan 11, 2013 at 11:25:00AM +0100, Markus Armbruster wrote:
> Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Michael Roth
> ---
> qga/channel-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/channel-posix.c b/qga/channel-posix.c
> index d4fd
On Fri, Jan 11, 2013 at 11:24:58AM +0100, Markus Armbruster wrote:
> After open(), the file offset is already zero, and neither lockf() nor
> ftruncate() change it.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Michael Roth
> ---
> qga/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 de
Thanks, applied.
Regards,
Anthony Liguori
On 1/10/2013 11:46 PM, Michael S. Tsirkin wrote:
On Fri, Jan 11, 2013 at 12:53:07PM +1030, Rusty Russell wrote:
"Michael S. Tsirkin" writes:
On Thu, Jan 10, 2013 at 10:45:39PM +0800, ak...@redhat.com wrote:
From: Amos Kong
Currenly mac is programmed byte by byte. This means that we
have an
Pulled, thanks.
Regards,
Anthony Liguori
On 01/11/2013 04:20 AM, Gerd Hoffmann wrote:
> Hi,
>
> Next chardev hotplug round. Minor API tweak (s/delay/nodelay/ for
> ChardevSocket). More documentation improvements. Added sanity checks.
For 1-8 and 10,
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Lib
On 01/11/2013 04:20 AM, Gerd Hoffmann wrote:
> qemu_chr_open_socket is splitted into two functions. All initialization
> after creating the socket file handler is splitted away into the new
You still haven't incorporated my fix of s/splitted/split/g that I
raised against both v1 and v2.
> @@ -24
Am 10.01.2013 19:34, schrieb Andreas Färber:
> Am 10.01.2013 15:49, schrieb Paolo Bonzini:
>> Signed-off-by: Paolo Bonzini
>> ---
>> hw/qdev-core.h | 12
>> hw/qdev.c | 7 ++-
>> 2 files changed, 18 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/qdev-core.h b/hw/qdev-co
Hi,
here is a reworked version.
V1 -> V2:
* removed useless code movements
* corrected terminology into logical and physical CHS and structured/layered
functions accordingly
Einar Lueck (1):
hd-geometry.c: Integrate HDIO_GETGEO in guessing
hw/hd-geometry.c | 45 +
This patch extends the function hd_geometry_guess. If no geo could
be guessed via guess_disk_lchs, a new function called guess_disk_pchs is
called. The latter utilizes HDIO_GET_GEO ioctl to ask the underlying disk
for geometry.
If this is not successful (e.g. image files) geometry is derived
from t
On Fri, Jan 11, 2013 at 03:37:26PM +0800, Lei Li wrote:
> On 01/08/2013 06:04 AM, Eric Blake wrote:
> >On 01/06/2013 03:06 AM, Lei Li wrote:
> >>Signed-off-by: Lei Li
> >>---
> >> qga/commands-posix.c | 12
> >> qga/qapi-schema.json | 17 +
> >> 2 files changed, 2
The GE IP-Octal 232 is an IndustryPack module that implements eight
RS-232 serial ports, each one of which can be redirected to a
character device in the host.
Signed-off-by: Alberto Garcia
---
hw/Makefile.objs |2 +-
hw/ipoctal232.c | 619 ++
The TPCI200 is a PCI board that supports up to 4 IndustryPack modules.
A new bus type called 'IndustryPack' has been created so any
compatible module can be attached to this board.
Signed-off-by: Alberto Garcia
---
default-configs/pci.mak |1 +
hw/Makefile.objs|3 +
hw/ipack.c
I updated the patches again, here are the changes from v4:
* Replaced DO_UPCAST() with checked casts.
* Added ipack_bus_new_inplace(). The fields of IPackBus are now private.
* Renamed ipoctal.c to ipoctal232.c (*).
* Replaced qdev->parent_bus with qdev_get_parent_bus(qdev).
* Replaced bus->qbus w
Eliminate dependencies between one test and the others.
Signed-off-by: Paolo Bonzini
---
tests/rtc-test.c | 36 +---
1 file changed, 9 insertions(+), 27 deletions(-)
diff --git a/tests/rtc-test.c b/tests/rtc-test.c
index 02edbf5..7b39831 100644
--- a/tests/rtc-te
Trying (unsuccessfully) to break the device model as mentioned in
https://bugs.launchpad.net/qemu/+bug/1090558.
At least if someone tries to fix that, it won't break what works...
Signed-off-by: Paolo Bonzini
---
tests/rtc-test.c | 202 ++-
1
Trying (unsuccessfully) to break the code and reproduce the effects
of https://bugs.launchpad.net/qemu/+bug/1090558... Well, more
tests never hurt...
Paolo Bonzini (2):
rtc-test: always set register B in its entirety
rtc-test: add testcases for alarms in 12hour mode
tests/rtc-test.c | 238 +
Il 11/01/2013 17:10, Ramesh G ha scritto:
>
> Hi,
>
> I got a couple of below compilation errors while compiling with glib >
> 2.32.
>
> $ make
> CC../trace/simple.o
> ../trace/simple.c: In function ‘trace_thread_create’:
> ../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated
On 11 January 2013 16:10, Ramesh G wrote:
> I got a couple of below compilation errors while compiling with glib > 2.32.
Stefan: see also commit d1b719e98 which fixed these warnings in
coroutine-gthread.c.
-- PMM
Thanks, applied.
Regards,
Anthony Liguori
Am 11.01.2013 16:41, schrieb Stefan Hajnoczi:
> Windows guests do not work with x-data-plane=on because misaligned request
> support is missing in hw/dataplane/virtio-blk.c. This series adds a bounce
> buffer when the request is misaligned. Windows guests now work with
> x-data-plane=on.
>
> v3:
Pulled, thanks.
N.B. This note may be extraneous because the pull request was sent by a
version of git older than 1.7.9 making the pull request ambigious. Please
consider upgrading to a newer version of git.
Regards,
Anthony Liguori
Pulled, thanks.
Regards,
Anthony Liguori
The problem is obviously there, but I tried pretty hard to make it fail
and couldn't so it seems latent. If you can, please provide a patch to
tests/rtc-test.c that shows the bug.
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member
This is lacking a proper description of the slight refactoring.
Am 10.12.2012 03:22, schrieb liguang:
> Signed-off-by: liguang
> ---
> target-i386/helper.c | 74 +---
> target-i386/machine.c |5 ++-
> target-i386/misc_helper.c |4 +-
> t
Il 11/01/2013 16:44, Andreas Färber ha scritto:
>>> >> Makes me wonder if qtest cases might be doable...
>> >
>> > Anthony, what's going on with libqos? :)
> I posted a rebased version of I2C libqos support after Anthony approved
> the pre-header-reorg version and am hoping it will get applied now
Extract code for read/write command processing into do_rdwr_cmd(). This
brings together pieces that are spread across process_request().
The real motivation is to set the stage for handling misaligned
requests, which the next patch tackles.
Signed-off-by: Stefan Hajnoczi
---
hw/dataplane/virti
Am 10.12.2012 03:22, schrieb liguang:
> Signed-off-by: liguang
> ---
> target-i386/cpu.h | 15 +--
> 1 files changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/target-i386/cpu.h b/target-i386/cpu.h
> index 29245d1..c69f81f 100644
> --- a/target-i386/cpu.h
> +++ b/target-i38
The qiov_is_aligned() function checks whether a QEMUIOVector meets a
BlockDriverState's alignment requirements. This is needed by
virtio-blk-data-plane so:
1. Move the function from block/raw-posix.c to block/block.c.
2. Make it public in block/block.h.
3. Rename to bdrv_qiov_is_aligned().
4. Cha
Windows guests do not work with x-data-plane=on because misaligned request
support is missing in hw/dataplane/virtio-blk.c. This series adds a bounce
buffer when the request is misaligned. Windows guests now work with
x-data-plane=on.
v3:
* Use iov/iov_cnt before modifying them in do_rdwr_cmd()
From: "alex_rozen...@mentor.com"
When do_interrupt_v7m is called with EXCP_SWI, the PC already
points to the next instruction. Don't modify it here.
Signed-off-by: Alex Rozenman
Signed-off-by: Peter Maydell
---
target-arm/helper.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
O_DIRECT on Linux has alignment requirements on I/O buffers and
misaligned requests result in -EINVAL. The Linux virtio_blk guest
driver usually submits aligned requests so I forgot to handle misaligned
requests.
It turns out that virtio-win guest drivers submit misaligned requests.
Handle them u
Hi,
I got a couple of below compilation errors while compiling with glib >
2.32.
$ make
CC../trace/simple.o
../trace/simple.c: In function ‘trace_thread_create’:
../trace/simple.c:407:5: error: ‘g_thread_create’ is deprecated (declared
at /usr/include/glib-2.0/glib/deprecated/gthread.h:100)
Am 10.12.2012 03:22, schrieb liguang:
> Signed-off-by: liguang
For a patch series consisting of more than 1 patch, please use a cover
letter (e.g., --cover-letter) that details the change history of the
versions. That also facilitates commenting on the series vs. a single patch.
> ---
> target-
On 01/11/2013 03:24 AM, Markus Armbruster wrote:
> Markus Armbruster (6):
> qemu-ga: Document intentional fall through in channel_event_cb()
> qemu-ga: Drop pointless lseek() from ga_open_pidfile()
> qemu-ga: Plug file descriptor leak on ga_open_pidfile() error path
> qemu-ga: Plug fd leak
Hi Guang,
Am 11.01.2013 02:47, schrieb li guang:
> can these patches get an ack from you?
I'm waiting on feedback from the previous reviewers... CC'ing.
> or they were obsoleted?
No, I don't spot any need to rebase. However, patch 3/3 is tab-damaged,
please run scripts/checkpatch.pl. That can b
Am 11.01.2013 15:40, schrieb Stefan Hajnoczi:
> On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote:
>> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
>>> +iov = &bounce_iov;
>>> +iov_cnt = 1;
>>> +
>>> +if (read) {
>>> +/* Need to copy back from boun
On Fri, 2013-01-11 at 08:53 +, Pandarathil, Vijaymohan R wrote:
>
> > -Original Message-
> > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > Sent: Wednesday, January 09, 2013 10:08 AM
> > To: Pandarathil, Vijaymohan R
> > Cc: Bjorn Helgaas; Gleb Natapov; k...@vger.kernel.
On Fri, 2013-01-11 at 08:45 +, Pandarathil, Vijaymohan R wrote:
>
> > -Original Message-
> > From: Alex Williamson [mailto:alex.william...@redhat.com]
> > Sent: Wednesday, January 09, 2013 11:05 AM
> > To: Pandarathil, Vijaymohan R
> > Cc: Bjorn Helgaas; Gleb Natapov; k...@vger.kernel.
On Thu, Jan 10, 2013 at 11:40:07PM -0700, Matthew Ogilvie wrote:
> On Tue, Jan 08, 2013 at 09:31:19AM +0200, Gleb Natapov wrote:
> > On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote:
> > > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote:
> > > > On Wed, Dec 26, 2012 at 1
Am 11.01.2013 14:27, schrieb Paolo Bonzini:
> Il 11/01/2013 13:39, Kevin Wolf ha scritto:
>> Makes me wonder if qtest cases might be doable...
>
> Anthony, what's going on with libqos? :)
I posted a rebased version of I2C libqos support after Anthony approved
the pre-header-reorg version and am h
On Fri, Jan 11, 2013 at 03:35:29PM +0200, Dmitry Fleytman wrote:
> Stefan,
>
> We have vmxnet2 implementation ready for submission as well,
> so this code is not dead :)
Please add it when it's needed.
Stefan
Hello,
On 11/01/13 15:58, Andreas Färber wrote:
>> @@ -386,6 +406,10 @@ static int arm_sysctl_init(SysBusDevice *dev)
>> > {
>> > arm_sysctl_state *s = FROM_SYSBUS(arm_sysctl_state, dev);
>> >
>> > +s->display = qemu_chr_new("leds0", "chardev:leds", NULL);
>> > +if (s->display) {
>
On 11/01/13 16:23, Andreas Färber wrote:
> Am 11.01.2013 16:00, schrieb Peter Maydell:
>> On 11 January 2013 13:42, Wolfgang Mauerer
>> wrote:
>>> The configuration register for the onboard LEDs is
>>> emulated, but the state is not exported, which makes
>>> the feature not particularly useful. C
On 01/11/2013 12:18 AM, Lei Li wrote:
>
> For this version, it's a one-hour offset represented as:±[hh].
> Negative values are west, andpositive values are east of UTC.
Won't work. There are timezones with a half-hour offset. You need to
express offset at least in terms of minutes, not just hou
From: Eduardo Habkost
The type_register_static() interface is documented as:
type_register_static:
@info: The #TypeInfo of the new type.
@info and all of the strings it points to should exist for the life
time that the type is registered.
But cpu_register() uses a stack variable for th
Small patchqueue, just flushing the target-arm queue before softfreeze.
Please pull.
-- PMM
The following changes since commit a6308bc2224db238e72c570482717b68246a7ce0:
Merge remote-tracking branch 'kraxel/build.1' into staging (2013-01-10
13:26:31 -0600)
are available in the git repository
On Fri, Jan 11, 2013 at 02:28:17PM +0100, Paolo Bonzini wrote:
> Il 11/01/2013 13:34, Stefan Hajnoczi ha scritto:
> > +iov = &bounce_iov;
> > +iov_cnt = 1;
> > +
> > +if (read) {
> > +/* Need to copy back from bounce buffer on completion */
> > +read_
Am 11.01.2013 16:00, schrieb Peter Maydell:
> On 11 January 2013 13:42, Wolfgang Mauerer
> wrote:
>> The configuration register for the onboard LEDs is
>> emulated, but the state is not exported, which makes
>> the feature not particularly useful. Create a character
>> device to make status chang
Am 11.01.2013 15:53, schrieb Julien Grall:
> On 01/11/2013 11:50 AM, Andreas Färber wrote:
>> Am 11.01.2013 10:18, schrieb Stefan Hajnoczi:
>>> @@ -103,6 +103,11 @@ static void ioport80_write(void *opaque, hwaddr addr,
>>> uint64_t data,
>>> {
>>> }
>>>
>>> +static uint64_t ioport80_read(void
From: Julien Grall
The commit 258711 introduced MemoryRegion to replace ioport_region*
for ioport 80h and F0h.
A MemoryRegion needs to have both read and write callback otherwise a segfault
will occur when an access is made.
The previous behaviour of this both ioport is to return 0xf
On 11 January 2013 13:42, Wolfgang Mauerer wrote:
> The configuration register for the onboard LEDs is
> emulated, but the state is not exported, which makes
> the feature not particularly useful. Create a character
> device to make status changes accessible to the host.
>
> For example, use the c
Hello,
Am 11.01.2013 14:42, schrieb Wolfgang Mauerer:
> The configuration register for the onboard LEDs is
> emulated, but the state is not exported, which makes
> the feature not particularly useful. Create a character
> device to make status changes accessible to the host.
>
> For example, use
1 - 100 of 210 matches
Mail list logo
