[Qemu-devel] [Trivial PATCH] acpitable: open the data file in binary mode

2013-01-17 Thread Michael Tokarev
-acpitable {file|data}=file reads the content of file, but it is in binary form, so the file should be opened usin O_BINARY flag. On *nix it is a no-op, but on windows and other weird platform it is really needed. Signed-off-by: Michael Tokarev --- hw/acpi.c |2 +- 1 file changed, 1 insertio

Re: [Qemu-devel] [PATCH v2 03/11] hw/9pfs: Fix unchecked strdup() by converting to g_strdup()

2013-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 06:32:12PM +0100, Markus Armbruster wrote: > diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c > index 6eab7f7..74155fb 100644 > --- a/hw/9pfs/virtio-9p-device.c > +++ b/hw/9pfs/virtio-9p-device.c > @@ -94,7 +94,7 @@ VirtIODevice *virtio_9p_init(DeviceStat

Re: [Qemu-devel] [RFC V1 11/12] qmp: Add block-pause-dedup.

2013-01-17 Thread Benoît Canet
> > +# > > +# @device: the name of the device to pause the deduplication on > > +# > > +# Returns: nothing on success > > +# If @device is not a valid block device, DeviceNotFound > > +# If @device is not deduplicated, DeviceNotDeduplicated > > I don't think you need this secon

Re: [Qemu-devel] [RFC V1 12/14] qcow2: Add qcow2_dedup_update_metrics to compute dedup RAM usage.

2013-01-17 Thread Benoît Canet
Le Wednesday 16 Jan 2013 à 13:10:12 (-0700), Eric Blake a écrit : > On 01/16/2013 09:25 AM, Benoît Canet wrote: > > --- > > block/qcow2-dedup.c | 13 + > > block/qcow2.h |1 + > > 2 files changed, 14 insertions(+) > > > > diff --git a/block/qcow2-dedup.c b/block/qcow2-dedu

Re: [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 11:33:03AM +0100, Stefan Hajnoczi wrote: > On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote: > > libcacard lacks a clean target. Need to fix it, > > meanwhile mark this target phony so it does not > > stop parallel make clean. > > > > Signed-off-by: Michae

Re: [Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard

2013-01-17 Thread Stefan Hajnoczi
On Tue, Jan 15, 2013 at 06:36:50PM +0200, Michael S. Tsirkin wrote: > libcacard lacks a clean target. Need to fix it, > meanwhile mark this target phony so it does not > stop parallel make clean. > > Signed-off-by: Michael S. Tsirkin > --- > libcacard/Makefile | 2 +- > 1 file changed, 1 inserti

Re: [Qemu-devel] [PATCH v9 4/5] Adding packet abstraction for VMWARE network devices

2013-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 04:33:48PM +0100, Paolo Bonzini wrote: > Il 16/01/2013 15:48, Stefan Hajnoczi ha scritto: > >> > hw/vmxnet_rx_pkt.c | 187 ++ > >> > hw/vmxnet_rx_pkt.h | 173 > >> > hw/vmxnet_tx_pkt.c | 567 > >> > ++

[Qemu-devel] [PATCH] PPC: e500: Change in-memory order of load blobs

2013-01-17 Thread Alexander Graf
Today, we load into memory in that order. However, Linux has a bug where it can only handle the dtb if it's within the first 64MB of where starts. So instead, let's change the order to making Linux happy. Signed-off-by: Alexander Graf --- hw/ppc/e500.c |7 ++- 1 files cha

Re: [Qemu-devel] [PATCH] fix unbounded qemu NetQueue

2013-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 07:07:11AM +0100, Luigi Rizzo wrote: > The comment at the beginning of net/queue.c says that packets that > cannot be sent by qemu_net_queue_send() should not be enqueued > unless a callback is set. > > This patch implements this behaviour, that prevents a queue to grow > u

Re: [Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

2013-01-17 Thread Michael S. Tsirkin
On Thu, Jan 17, 2013 at 09:39:54AM +0100, Stefan Hajnoczi wrote: > On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote: > > On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote: > > > ak...@redhat.com writes: > > > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n,

[Qemu-devel] [PATCH v4 3/3] ahci: Add migration support

2013-01-17 Thread Kevin Wolf
From: Jason Baron Jason tested these patches by migrating Windows 7 and Fedora 17 guests (while under I/O) on both piix with ahci attached and on q35 (which has a built-in AHCI controller). Signed-off-by: Andreas Färber Signed-off-by: Jason Baron Signed-off-by: Kevin Wolf --- Changes from v3:

[Qemu-devel] [PATCH v4 2/3] ahci: Change data types in preparation for migration

2013-01-17 Thread Kevin Wolf
The size of an int depends on the host, so in order to be able to migrate these fields, make them either int32_t or bool, depending on the use. Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |8 hw/ide/ahci.h |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git

[Qemu-devel] [PATCH v4 1/3] ahci: Remove unused AHCIDevice fields

2013-01-17 Thread Kevin Wolf
From: Jason Baron 'dma_status' and 'dma_cb' are written to, but never read. Remove these fields in preparation for AHCI migration bits. Signed-off-by: Jason Baron Reviewed-by: Juan Quintela Signed-off-by: Kevin Wolf --- hw/ide/ahci.c |8 ++-- hw/ide/ahci.h |2 -- 2 files changed,

[Qemu-devel] [PATCH v4 0/3] AHCI migration

2013-01-17 Thread Kevin Wolf
Let's get Jason's patches merged while they still apply. I addressed the review comments (mostly my own) that came up during the v3 review, otherwise this is unchanged. Please note that in my tests it didn't work entirely reliably and I saw guest lockups and kernel crashes in like one of ten cases

Re: [Qemu-devel] [PATCH 0/2] win32-aio fixes

2013-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 09:19:58PM +0100, Kevin Wolf wrote: > Paolo, especially the first one is worrying with respect to the test status of > this code. We should probably give it some additional testing. > > Kevin Wolf (2): > win32-aio: Fix vectored reads > win32-aio: Fix memory leak > > b

Re: [Qemu-devel] [PATCH] v6 revamp acpitable parsing and allow to specify complete (headerful) table

2013-01-17 Thread TeLeMan
On Thu, May 12, 2011 at 10:44 PM, Michael Tokarev wrote: > This patch almost rewrites acpi_table_add() function > (but still leaves it using old get_param_value() interface). > The result is that it's now possible to specify whole table > (together with a header) in an external file, instead of ju

Re: [Qemu-devel] [PATCH v2] aio-posix: Fix return value of aio_poll()

2013-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 07:25:51PM +0100, Kevin Wolf wrote: > aio_poll() must return true if any work is still pending, even if it > didn't make progress, so that bdrv_drain_all() doesn't stop waiting too > early. The possibility of stopping early occasionally lead to a failed > assertion in bdrv_d

[Qemu-devel] buildbot failure in qemu on s390-next_i386_debian_6_0

2013-01-17 Thread qemu
The Buildbot has detected a new failure on builder s390-next_i386_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_i386_debian_6_0/builds/517 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuzuki

Re: [Qemu-devel] [PATCH] win32-aio: use iov utility functions instead of open-coding them

2013-01-17 Thread Michael Tokarev
17.01.2013 12:57, Kevin Wolf wrote: I said on top of my patch for a reason: Now this looks like an innocent Kevin, that wasn't intentional. I'm sorry. Somehow I thought your bugfix is already applied to master, and these reverse memcpy args are difficult to spot (gah, that's why the bug is h

Re: [Qemu-devel] [PATCH] win32-aio: use iov utility functions instead of open-coding them

2013-01-17 Thread Kevin Wolf
Am 17.01.2013 09:48, schrieb Michael Tokarev: > We have iov_from_buf() and iov_to_buf(), use them instead of > open-coding these in block/win32-aio.c > > Signed-Off-By: Michael Tokarev > --- > block/win32-aio.c | 18 +++--- > 1 file changed, 3 insertions(+), 15 deletions(-) > > di

[Qemu-devel] [PATCH] win32-aio: use iov utility functions instead of open-coding them

2013-01-17 Thread Michael Tokarev
We have iov_from_buf() and iov_to_buf(), use them instead of open-coding these in block/win32-aio.c Signed-Off-By: Michael Tokarev --- block/win32-aio.c | 18 +++--- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index 0383370..

[Qemu-devel] buildbot failure in qemu on s390-next_x86_64_debian_6_0

2013-01-17 Thread qemu
The Buildbot has detected a new failure on builder s390-next_x86_64_debian_6_0 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/s390-next_x86_64_debian_6_0/builds/516 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: yuz

Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] win32-aio: Fix vectored reads

2013-01-17 Thread Kevin Wolf
Am 17.01.2013 09:33, schrieb Michael Tokarev: > 17.01.2013 00:19, Kevin Wolf пишет: >> Copying data in the right direction really helps a lot! >> >> Cc: qemu-sta...@nongnu.org >> Signed-off-by: Kevin Wolf >> --- >> block/win32-aio.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-)

[Qemu-devel] [PATCH V4 06/13] qemu-img: switch image retrieving function

2013-01-17 Thread Wenchao Xia
Now qemu-img call block layer function to get image info and check if error happens. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- qemu-img.c | 90 1 files changed, 6 insertions(+), 84 deletions(-) diff --git a/qemu-img.

Re: [Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

2013-01-17 Thread Stefan Hajnoczi
On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote: > On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote: > > ak...@redhat.com writes: > > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n, > > > uint8_t cmd, > > > { > > > struct virtio_net_ctrl_mac mac_d

Re: [Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

2013-01-17 Thread Amos Kong
On Thu, Jan 17, 2013 at 01:45:11PM +0800, Amos Kong wrote: > On Thu, Jan 17, 2013 at 11:49:20AM +1030, Rusty Russell wrote: > > ak...@redhat.com writes: > > > @@ -349,6 +351,14 @@ static int virtio_net_handle_mac(VirtIONet *n, > > > uint8_t cmd, > > > { > > > struct virtio_net_ctrl_mac mac_d

Re: [Qemu-devel] [RFC] Add serial number to usbdevice when passthrough to VM

2013-01-17 Thread Gerd Hoffmann
Hi, > But as the backinfo's request, should we extented the usbdevice parameter > like: > > --usbdevice host:[:[:]? -usbdevice is legacy syntax and isn't going to be extended. Adding an "serial" property to usb-host is an option though. Patches are welcome. cheers, Gerd

Re: [Qemu-devel] [Qemu-stable] [PATCH 1/2] win32-aio: Fix vectored reads

2013-01-17 Thread Michael Tokarev
17.01.2013 00:19, Kevin Wolf пишет: Copying data in the right direction really helps a lot! Cc: qemu-sta...@nongnu.org Signed-off-by: Kevin Wolf --- block/win32-aio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index 46a5db7

Re: [Qemu-devel] [PATCH 0/4] block: Fix error report for wrong file format

2013-01-17 Thread Stefan Hajnoczi
On Wed, Jan 16, 2013 at 07:53:35PM +0100, Stefan Weil wrote: > Am 15.12.2012 15:09, schrieb Stefan Weil: > >These patches improve the error report if the file format was > >specified explicitly (example: -drive file=myfile,format=qcow2) > >and the given format does not match the real format. > > >

[Qemu-devel] [PATCH V4 03/13] block: add bdrv_can_read_snapshot() function

2013-01-17 Thread Wenchao Xia
Compared to bdrv_can_snapshot(), this function return whether bs* is ready to read snapshot info from instead of write. If yes, caller can then query snapshot information, but taking snapshot is not always possible for that *bs may be read only. Signed-off-by: Wenchao Xia --- block.c

Re: [Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

2013-01-17 Thread Andreas Färber
Am 17.01.2013 00:43, schrieb Eduardo Habkost: > On Wed, Jan 16, 2013 at 11:52:47PM +0100, Andreas Färber wrote: >> Am 16.01.2013 17:04, schrieb Eduardo Habkost: >>> On Wed, Jan 16, 2013 at 06:32:48AM +0100, Andreas Färber wrote: >>> [...] @@ -2247,6 +2247,9 @@ static void x86_cpu_common_class_

[Qemu-devel] [PATCH V4 01/13] qemu-img: remove unused parameter in collect_image_info()

2013-01-17 Thread Wenchao Xia
Parameter *fmt was not used, so remove it. Reviewed-by: Eric Blake Signed-off-by: Wenchao Xia --- qemu-img.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 85d3740..9dab48f 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1186,8 +1186,7

<    1   2   3