> > If I reset/suspend/resume/ the VM during a backup job run I get:
> >
> > block.c:1221: bdrv_drain_all: Assertion `((&bs->tracked_requests)->lh_first
> == ((void *)0))' failed.
> > Aborted
> >
> > I am not 100% sure, but I think a simple qemu_aio_wait() is not enough
> > to ensure that a copy-on
Il 22/01/2013 08:02, Dietmar Maurer ha scritto:
>> aio_poll() must return true if any work is still pending, even if it didn't
>> make
>> > progress, so that qemu_aio_wait() doesn't return too early.
>> > The possibility of returning early occasionally lead to a failed assertion
>> > in
>> > bdrv
On 01/22/2013 03:52 AM, Anthony Liguori wrote:
Why don't you resubmit the series without this patch. I think this
needs a bit of work...
Sure, I will resubmit the series without this patch and try to implement
this console command as your suggestion in another thread later.
Thanks for your ti
On 01/22/2013 03:48 AM, Anthony Liguori wrote:
Lei Li writes:
Signed-off-by: Lei Li
---
qemu-char.c | 134 +++
qemu-options.hx | 10
2 files changed, 144 insertions(+), 0 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
i
reposting a version without changes that implement bounded
queues in net/queue.c
Hi,
the attached patch implements a qemu backend for the "netmap" API
thus allowing machines to attach to the VALE software switch as
well as netmap-supported cards (links below).
http://info.iet.unipi.it/~luigi/netm
> aio_poll() must return true if any work is still pending, even if it didn't
> make
> progress, so that qemu_aio_wait() doesn't return too early.
> The possibility of returning early occasionally lead to a failed assertion in
> bdrv_drain_all(), when some in-flight request was missed and the func
when frontend and backend are connected through a hub as below
(showing only one direction), and the frontend (or in general, all
output ports of the hub) cannot accept more traffic, the backend
queues packets in queue-A.
When the frontend (or in general, one output port) becomes ready again,
quem
On Mon, Jan 21, 2013 at 05:49:10PM +0100, Stefan Hajnoczi wrote:
> On Mon, Jan 21, 2013 at 12:59:07PM +0800, harryxiyou wrote:
> > We programmed a block storage(HLFS) patch for QEMU. Therefore,
> > when i patched this driver for QEMU, it happened to me some errors.
> > Could anyone give me some sug
This patch reorganizes qemu file operations to be in their own source file
instead of being lumped in savevm.c. Besides being more logical for maintenance
it also makes it easier for future users of the file functions to add tests.
Signed-off-by: Stefan Berger
Signed-off-by: Joel Schopp
---
Ma
Hi,
the attached patch implements a qemu backend for the "netmap" API
thus allowing machines to attach to the VALE software switch as
well as netmap-supported cards (links below).
http://info.iet.unipi.it/~luigi/netmap/
http://info.iet.unipi.it/~luigi/vale/
This is a cleaned up version of code wr
Commit c732a52d3e3b7ed42d7daa94ba40a83408cd6f22 from Richard Henderson
changed leul_to_cpu() in bswap.h from a macro to an inline function. Both
versions use HOST_LONG_BITS, but as an inline, HOST_LONG_BITS now needs to
be evaluated at the point of definition rather than only when the macro is
inv
18.01.2013 09:28, Michael Tokarev wrote:
As far as I remember, qemu-kvm had quite some differences compared
with qemu, at least:
-accel kvm,tcg
-cpu kvm64 (or kvm32?)
-kernel_irqchip (machine option)
The latter two aren't needed.
I'm not sure when, but apparently qemu-kvm switched to q
Am 22.01.2013 02:43, schrieb Marcelo Tosatti:
> On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote:
>> Signed-off-by: Eduardo Habkost
>> ---
>> Cc: k...@vger.kernel.org
>> Cc: Michael S. Tsirkin
>> Cc: Gleb Natapov
>> Cc: Marcelo Tosatti
>> ---
>> include/sysemu/kvm.h | 1 +
>> 1
http://forum.winehq.org/viewtopic.php?f=2&t=17701
Here is where I got... Read the whole thing..
-Original Message-
From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of James
Le Cuirot
Sent: Monday, January 21, 2013 4:16 PM
To: justinsha...@gmail.com
Subject: [Bug 7397
On Thu, Jan 17, 2013 at 06:59:30PM -0200, Eduardo Habkost wrote:
> This will allow each architecture to define how the VCPU ID is set on
> the KVM_CREATE_VCPU ioctl call.
>
> Signed-off-by: Eduardo Habkost
> ---
> Cc: k...@vger.kernel.org
> Cc: Michael S. Tsirkin
> Cc: Gleb Natapov
> Cc: Marcel
On Thu, Jan 17, 2013 at 06:59:28PM -0200, Eduardo Habkost wrote:
> This is a cleanup that tries to solve two small issues:
>
> - We don't need a separate kvm_pv_eoi_features variable just to keep a
>constant calculated at compile-time, and this style would require
>adding a separate varia
On Thu, Jan 17, 2013 at 06:59:31PM -0200, Eduardo Habkost wrote:
> The CPU ID in KVM is supposed to be the APIC ID, so change the
> KVM_CREATE_VCPU call to match it. The current behavior didn't break
> anything yet because today the APIC ID is assumed to be equal to the CPU
> index, but this won't
On Thu, Jan 17, 2013 at 06:59:29PM -0200, Eduardo Habkost wrote:
> Currently, the pc-1.4 machine init function enables PV EOI and then
> calls the pc-1.2 machine init function. The problem with this approach
> is that now we can't enable any additional compatibility code inside the
> pc-1.2 init fu
On Thu, Jan 17, 2013 at 06:59:27PM -0200, Eduardo Habkost wrote:
> Signed-off-by: Eduardo Habkost
> ---
> Cc: k...@vger.kernel.org
> Cc: Michael S. Tsirkin
> Cc: Gleb Natapov
> Cc: Marcelo Tosatti
> ---
> include/sysemu/kvm.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/sy
Besides the new value in the version register, this provides:
- ILR support, which includes:
- IDR becoming a pure CPU bitmap, allowing 32 CPUs
- machine check output support (though other parts of QEMU need to
be fixed for it to do something other than immediately reboot the
guest)
- d
The compatible string is changed to fsl,mpic on all e500 platforms, to
advertise the existence of BRR1. This matches what the device tree will
have on real hardware.
With MPIC v4.2 max_cpu can be increased from 15 to 32.
Signed-off-by: Scott Wood
---
hw/ppc/e500.c |4 ++--
hw/ppc/e500
The timer memory range begins at 0x10f0, so that address 0x1120 shows
up as 0x30, 0x1130 shows up as 0x40, etc. However, the address
decoding (other than TFRR) is not adjusted for this, causing the
wrong registers to be accessed.
Signed-off-by: Scott Wood
---
hw/openpic.c | 10 +++---
1 f
openpic_update_irq() was checking idr rather than destmask, treating
it as if it were a simple bitmap of cpus. Changed to use destmask.
IPI delivery was removing bits directly from .idr, without calling
write_IRQreg_idr so that the change could be conveyed to destmask.
Changed to use destmask dir
MPIC+0xa0 is IACK for the current CPU. MPIC+0x200a0 is IACK for CPU 0.
This fix allows EPR to work with an SMP target.
Signed-off-by: Scott Wood
---
hw/ppc/e500.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 9ccf4d1..530f929 100644
-
Fix some miscellaneous bugs, and enable basic MPIC v4.2 support.
Scott Wood (5):
openpic: fix remaining issues from idr-to-destmask conversion
openpic: fix timer address decoding
openpic: add basic support for MPIC v4.2
PPC: e500: fix mpic_iack address
PPC: e500: Select MPIC v4.2 on ppce
There seems to be something wrong with the dependencies
or makefile runes for some of the trace infrastructure.
For example:
pm215@canth:~/src/qemu/qemu$ less trace/generated-tracers.c
/* This file is autogenerated by tracetool, do not edit. */
pm215@canth:~/src/qemu/qemu$ git status trace/generat
Apologies, I missed part of the patch when trying to reapply it. Here it
is. It seems to work.
** Patch added: "add-usermode-NPTL-support-for-i386.patch"
https://bugs.launchpad.net/qemu/+bug/739785/+attachment/3493200/+files/add-usermode-NPTL-support-for-i386.patch
--
You received this bug n
Peter Maydell writes:
> On 21 January 2013 21:32, Richard Sandiford
> wrote:
>> Honour float_muladd_negate_c in the case where the product is zero and
>> c is nonzero. Previously we would fail to negate c.
>>
>> Seen in (and tested against) the gfortran testsuite on MIPS.
>>
>> Signed-off-by: R
When seabios programs PCI interrupt line registers it expects a
specific slot:pin to PIRQ mapping (see pci_slot_get_irq). If we
want to re-use this function between both PIIX and ICH9, then the
_PRT exposed to the guest needs to change. NB. slots 25-31 on ICH9
don't follow this routing pattern an
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
On 21 January 2013 21:32, Richard Sandiford wrote:
> Honour float_muladd_negate_c in the case where the product is zero and
> c is nonzero. Previously we would fail to negate c.
>
> Seen in (and tested against) the gfortran testsuite on MIPS.
>
> Signed-off-by: Richard Sandiford
> ---
> fpu/sof
Peter Maydell writes:
> On 21 January 2013 19:21, Anthony Liguori wrote:
>> Peter Maydell writes:
>>> On 21 January 2013 16:48, Anthony Liguori wrote:
This makes it easier to use checkpatch with a git hook or via patches.
>
>>> Any chance of a note in the comments about how to actually ho
Blue Swirl writes:
> On Mon, Jan 21, 2013 at 6:45 PM, Anthony Liguori wrote:
>> Hi,
>>
>> I activated a checkpatch and git-am bot using the patches framework
>> today. I decided to pick on Paolo and use him as an example:
>>
>> http://article.gmane.org/gmane.comp.emulators.qemu/190181
>>
>> The
Applied. Thanks.
Regards,
Anthony Liguori
Eric Blake writes:
> On 01/21/2013 12:20 PM, Anthony Liguori wrote:
>> This makes it easier to use checkpatch with a git hook or via patches.
>>
>> Signed-off-by: Anthony Liguori
>> ---
>> v1 -> v2
>> - Add the subject to the output to indicate which patch failed
>> - Only display output for
On Fri, Sep 28, 2012 at 10:05:09AM +0200, Jan Kiszka wrote:
> On 2012-09-28 01:21, Satoru Moriya wrote:
> > This is a first time for me to post a patch to qemu-devel.
> > If there is something missing/wrong, please let me know.
> >
> > We have some plans to migrate old enterprise systems which req
Hi,
Thank you for submitting your patch series. This note is to inform
you that this patch series no longer applies against the latest
qemu.git tree.
If it's been at least a few days since you submitted this series,
please resubmit a new version of your patch series so it can be
considered for i
BTW, I'm not sure it's right to be using *_muladd for MIPS. MADD.fmt &
co. were fused operations in the early MIPS IV processors, but they've
had an intermediate rounding step since then (i.e. they're equivalent
to a separate multiplication and addition). I'm not feeling brave
enough to tackle th
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Honour float_muladd_negate_c in the case where the product is zero and
c is nonzero. Previously we would fail to negate c.
Seen in (and tested against) the gfortran testsuite on MIPS.
Signed-off-by: Richard Sandiford
---
fpu/softfloat.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a
It's really not that arbitrary how we translate slot:pin to pirq
register. We not only need to match the ACPI table we provide
to the guest, but the BIOS has dependencies for programming PCI
interrupt line registers for boot ROMs that use interrupts. If
we don't match the slot:pin to pirq of PIIX
We're initializing the ICH9 PIRQn registers with the IRQEN bit set,
which actuall makes them operate in APIC mode rather than PIC mode
(see 13.1.17 & 13.1.9). AFAICT, the system boots up in PIC mode and
trying to make use of APIC IRQs in boot ROMs does not work. Fix this
to use the ISA compatible
I was trying to revive the patch to add Qemu INTx routing support for
Q35 and stumbled on some rather broken interrupt routing problems.
Sadly a seabios release claiming Q35 support snuck out already, but
I'd like to at least discuss these before Qemu 1.4 even though they
may not get fixed for that
On 01/21/2013 12:20 PM, Anthony Liguori wrote:
> This makes it easier to use checkpatch with a git hook or via patches.
>
> Signed-off-by: Anthony Liguori
> ---
> v1 -> v2
> - Add the subject to the output to indicate which patch failed
> - Only display output for patches that fail the check
>
On Mon, Jan 21, 2013 at 9:10 PM, Markus Armbruster wrote:
> Blue Swirl writes:
>
>> On Mon, Jan 21, 2013 at 10:36 AM, Markus Armbruster
>> wrote:
>>> Peter Maydell writes:
>>>
On 20 January 2013 15:54, Blue Swirl wrote:
>>> [...]
I don't think there's much point adding tons of "XXX"
On 21 January 2013 19:21, Anthony Liguori wrote:
> Peter Maydell writes:
>> On 21 January 2013 16:48, Anthony Liguori wrote:
>>> This makes it easier to use checkpatch with a git hook or via patches.
>> Any chance of a note in the comments about how to actually hook
>> it up to a git hook or pa
Blue Swirl writes:
> On Mon, Jan 21, 2013 at 10:36 AM, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> On 20 January 2013 15:54, Blue Swirl wrote:
>> [...]
>>> I don't think there's much point adding tons of "XXX" comments
>>> when a bunch of these aren't actually wrong code.
>>
>> Mo
On 21 January 2013 19:53, Michael Tokarev wrote:
> Note that, as far as I understand, upstream is moving towards a single
> binary which can emulate any target (sort of like busybox).
That is slightly overstating the case -- I think it's an aspiration,
but not one that anybody's currently activel
On 21 January 2013 20:03, Blue Swirl wrote:
> On Mon, Jan 21, 2013 at 12:50 PM, Peter Maydell
> wrote:
>> These patches either mark implicit fallthroughs in case statements
>> or (in a few cases) remove them by putting in an explicit 'break'
>> or 'return' rather than relying on the one in the fo
Add accumulator arguments to gen_HILO and gen_muldiv, rather than
extracting the accumulator directly from ctx->opcode. The extraction
was only right for the standard encoding: MIPS16 doesn't have access
to the DSP registers, while microMIPS encodes the accumulator register
in a different field (b
** Also affects: qemu
Importance: Undecided
Status: New
** No longer affects: qemu (Ubuntu)
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/855630
Title:
Cant Run Wine (posix not nptl) pas
On Mon, Jan 21, 2013 at 6:45 PM, Anthony Liguori wrote:
> Hi,
>
> I activated a checkpatch and git-am bot using the patches framework
> today. I decided to pick on Paolo and use him as an example:
>
> http://article.gmane.org/gmane.comp.emulators.qemu/190181
>
> There are quite a lot of patches o
On Mon, Jan 21, 2013 at 10:36 AM, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On 20 January 2013 15:54, Blue Swirl wrote:
> [...]
>> I don't think there's much point adding tons of "XXX" comments
>> when a bunch of these aren't actually wrong code.
>
> Moreover, such comments make them
Am 21.01.2013 12:03, schrieb Markus Armbruster:
Stefan Weil writes:
Am 18.01.2013 09:53, schrieb Markus Armbruster:
Stefan Weil writes:
This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk
when a file with the wrong format is selected.
Signed-off-by: Stefan Weil
---
block
On Mon, Jan 21, 2013 at 1:58 PM, Stefan Hajnoczi wrote:
> On Sat, Jan 19, 2013 at 09:04:57AM +, Blue Swirl wrote:
>> On Fri, Jan 18, 2013 at 11:04 AM, Stefan Hajnoczi wrote:
>> > On Thu, Jan 17, 2013 at 08:13:38PM +, Blue Swirl wrote:
>> >> On Mon, Jan 14, 2013 at 9:09 AM, Stefan Hajnoczi
Am 21.01.2013 20:21, schrieb Anthony Liguori:
> Peter Maydell writes:
>
>> On 21 January 2013 16:48, Anthony Liguori wrote:
>>> This makes it easier to use checkpatch with a git hook or via patches.
>>
>> Any chance of a note in the comments about how to actually hook
>> it up to a git hook or p
Hi,
Thank you for submitting your patch series. checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.
If you believe this message was sent in error, please ignore it
or respond here with an explanation.
Otherwise, please correct the coding styl
On Mon, Jan 21, 2013 at 12:50 PM, Peter Maydell
wrote:
> These patches either mark implicit fallthroughs in case statements
> or (in a few cases) remove them by putting in an explicit 'break'
> or 'return' rather than relying on the one in the following case.
> There is no behaviour change for any
On Sun, Jan 20, 2013 at 7:27 PM, Richard Sandiford
wrote:
> Add accumulator arguments to gen_HILO and gen_muldiv, rather than
> extracting the accumulator directly from ctx->opcode. The extraction
> was only right for the standard encoding: MIPS16 doesn't have access
> to the DSP registers, while
21.01.2013 23:43, Daniel P. Berrange wrote:
On Mon, Jan 21, 2013 at 10:58:48PM +0400, Michael Tokarev wrote:
We in debian talked about splitting qemu-system into
individual target packages for a long time, and there's
a patch (almost current) to support it, in qemu-system-split-mjt
branch of qem
Why don't you resubmit the series without this patch. I think this
needs a bit of work...
Lei Li writes:
> Signed-off-by: Lei Li
> ---
> hmp-commands.hx | 21 ++
> hmp.c | 52
> +
> hmp.h
On Mon, 21 Jan 2013 15:06:34 +0100
Igor Mammedov wrote:
[...]
>
> vendor related changes are tested with:
> https://github.com/imammedo/virt-test/tree/cpuid_features
> following command was used to run test:
>./run -t kvm --qemu-bin=$QEMU --tests="qemu_cpu.qemu13 cpuid.custom_vendor"
>
Lei Li writes:
> Signed-off-by: Lei Li
> ---
> qemu-char.c | 134
> +++
> qemu-options.hx | 10
> 2 files changed, 144 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index 9ba0573..950c543 100644
> ---
On Mon, Jan 21, 2013 at 10:58:48PM +0400, Michael Tokarev wrote:
> We in debian talked about splitting qemu-system into
> individual target packages for a long time, and there's
> a patch (almost current) to support it, in qemu-system-split-mjt
> branch of qemu debian git tree (I'll refresh it hope
Peter Maydell writes:
> On 21 January 2013 16:48, Anthony Liguori wrote:
>> This makes it easier to use checkpatch with a git hook or via patches.
>
> Any chance of a note in the comments about how to actually hook
> it up to a git hook or patches? ie something like
>
> # This script is intended
This makes it easier to use checkpatch with a git hook or via patches.
Signed-off-by: Anthony Liguori
---
v1 -> v2
- Add the subject to the output to indicate which patch failed
- Only display output for patches that fail the check
---
scripts/check-patches.sh | 35
Am 21.01.2013 17:09, schrieb Paolo Bonzini:
> The new testcase did not find Kevin's bug (which is actually not
> there), but I still did the change he asked to the logic; it is
> clearer that way.
>
> And the testcase *did* find a related problem. Here is the relevant
> diff from v2:
>
>
From: Amos Kong
Date: Mon, 21 Jan 2013 19:17:20 +0800
> Currenly mac is programmed byte by byte. This means that we
> have an intermediate step where mac is wrong.
>
> Third patch introduced a new vq control command to set mac
> address, it's atomic.
>
> V2: check return of sending command, de
Am 21.01.2013 17:09, schrieb Paolo Bonzini:
> This makes sense when the next commit starts using the extra buffer space
> to perform many I/O operations asynchronously.
>
> Reviewed-by: Eric Blake
> Signed-off-by: Paolo Bonzini
> diff --git a/roms/seabios b/roms/seabios
> index a810e4e..e8a76b0
On Tue, Jan 22, 2013 at 2:44 AM, Eric Blake wrote:
> On 01/21/2013 11:35 AM, Zhi Yong Wu wrote:
>> On Mon, Jan 21, 2013 at 10:25 PM, Benoît Canet
>> wrote:
I don't know if the following case can be handled correctly.
For example, quorum:2/3:image1.raw:image2.raw:image3.raw
Let us
Am 21.01.2013 17:09, schrieb Paolo Bonzini:
> There is really no change in the behavior of the job here, since
> there is still a maximum of one in-flight I/O operation between
> the source and the target. However, this patch already introduces
> the AIO callbacks (which are unmodified in the next
We in debian talked about splitting qemu-system into
individual target packages for a long time, and there's
a patch (almost current) to support it, in qemu-system-split-mjt
branch of qemu debian git tree (I'll refresh it hopefully
today).
I think it's time to decide whenever we want to do that
o
On 01/21/2013 11:35 AM, Zhi Yong Wu wrote:
> On Mon, Jan 21, 2013 at 10:25 PM, Benoît Canet
> wrote:
>>> I don't know if the following case can be handled correctly.
>>> For example, quorum:2/3:image1.raw:image2.raw:image3.raw
>>> Let us assume that some data in image2.raw and image3.raw get
>>>
On 01/21/2013 11:05 AM, Peter Maydell wrote:
> On 21 January 2013 17:56, Eric Blake wrote:
>> On 01/21/2013 08:48 AM, Peter Maydell wrote:
>>> On 14 January 2013 23:08, wrote:
+#define TYPE_VIRTIO_BUS "virtio-bus"
+#define VIRTIO_BUS_GET_CLASS(obj) \
+OBJECT_GET_CLASS(Virt
Hi,
I activated a checkpatch and git-am bot using the patches framework
today. I decided to pick on Paolo and use him as an example:
http://article.gmane.org/gmane.comp.emulators.qemu/190181
There are quite a lot of patches on list that fail checkpatch but the
bots will only notify on new patch
Hi,
Thank you for submitting your patch series. checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.
If you believe this message was sent in error, please ignore it
or respond here with an explanation.
Otherwise, please correct the coding styl
On Mon, Jan 21, 2013 at 10:25 PM, Benoît Canet wrote:
>> I don't know if the following case can be handled correctly.
>> For example, quorum:2/3:image1.raw:image2.raw:image3.raw
>> Let us assume that some data in image2.raw and image3.raw get
>> corrupted, and the two images are now completely ide
On 21 January 2013 17:56, Eric Blake wrote:
> On 01/21/2013 08:48 AM, Peter Maydell wrote:
>> On 14 January 2013 23:08, wrote:
>>> +#define TYPE_VIRTIO_BUS "virtio-bus"
>>> +#define VIRTIO_BUS_GET_CLASS(obj) \
>>> +OBJECT_GET_CLASS(VirtioBusClass, obj, TYPE_VIRTIO_BUS)
>>> +#define VIRTI
On 01/21/2013 08:48 AM, Peter Maydell wrote:
> On 14 January 2013 23:08, wrote:
>> +#define TYPE_VIRTIO_BUS "virtio-bus"
>> +#define VIRTIO_BUS_GET_CLASS(obj) \
>> +OBJECT_GET_CLASS(VirtioBusClass, obj, TYPE_VIRTIO_BUS)
>> +#define VIRTIO_BUS_CLASS(klass) \
>> +OBJECT_CLASS_CHECK(
On 01/21/2013 10:03 AM, Kevin Wolf wrote:
> Am 21.01.2013 17:27, schrieb Eric Blake:
>> On 01/21/2013 07:25 AM, Federico Simoncelli wrote:
>>> This patch adds the support for reporting the highest offset in use by
>>> an image. This is particularly useful after a conversion (or a rebase)
>>> where
On 21 January 2013 16:48, Anthony Liguori wrote:
> This makes it easier to use checkpatch with a git hook or via patches.
Any chance of a note in the comments about how to actually hook
it up to a git hook or patches? ie something like
# This script is intended to be used to allow checkpatch to
On 21 January 2013 15:53, Andreas Färber wrote:
> Am 21.01.2013 16:48, schrieb Peter Maydell:
>> 'obj' and 'klass' need brackets round them, because they're
>> macro arguments.
>
> BTW since these are macro arguments and not C code, I believe "class"
> should be perfectly valid here if you wanted.
Am 21.01.2013 15:25, schrieb Federico Simoncelli:
> This option --output=[human|json] make qemu-img check output an human
> or JSON representation at the choice of the user.
>
> Signed-off-by: Federico Simoncelli
Looks good to me, apart from Eric's spelling corrections.
Let's try to find a bett
On Tue, Jan 22, 2013 at 1:14 AM, harryxiyou wrote:
> On Tue, Jan 22, 2013 at 12:49 AM, Stefan Hajnoczi wrote:
> [...]
>> qemu-devel is not the appropriate place to ask for help with hlfs. The
>> hlfs patch is not part of qemu.git. Try emailing Kang Hua and Wang Sen
>> directly.
>
> Hmmm..., you
On 01/21/13 14:36, Alon Levy wrote:
> Adding Gerd.
>
>> Signed-off-by: Alon Levy
>> ---
>> hw/qxl.c | 11 +++
>> trace-events | 2 ++
Picked up the patches.
cheers,
Gerd
On 01/21/13 15:19, Gerd Hoffmann wrote:
>> Stefan: I've made the obvious change to fix the spice compile issue,
>> but none of my systems have a new enough spice-protocol/spice-server
>> to allow me to configure with spice enabled. I'd appreciate it if
>> you could check it does indeed compile OK n
On Tue, Jan 22, 2013 at 12:49 AM, Stefan Hajnoczi wrote:
[...]
> qemu-devel is not the appropriate place to ask for help with hlfs. The
> hlfs patch is not part of qemu.git. Try emailing Kang Hua and Wang Sen
> directly.
Hmmm..., you are right.
>
> The error message indicates that you are apply
Am 21.01.2013 17:27, schrieb Eric Blake:
> On 01/21/2013 07:25 AM, Federico Simoncelli wrote:
>> This patch adds the support for reporting the highest offset in use by
>> an image. This is particularly useful after a conversion (or a rebase)
>> where the destination is a block device in order to fi
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
---
v2->v3: Add "since 1.4" notes to qapi-schema.json [Eric].
block-migration.c | 5 +++--
block.c | 17 ++---
block/mirror.c| 14 --
include/block/block.h | 5 +
qapi-schema.jso
Reviewed-by: Laszlo Ersek
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
---
block-migration.c | 2 +-
block.c | 5 ++---
block/mirror.c| 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/block-migration.c b/block-migration.c
index 6acf3e1..9d0b037 100644
When mirroring runs, the backing files for the target may not yet be
ready. However, this means that a copy-on-write operation on the target
would fill the missing sectors with zeros. Copy-on-write only happens
if the granularity of the dirty bitmap is smaller than the cluster size
(and only for
On Mon, Jan 21, 2013 at 12:59:07PM +0800, harryxiyou wrote:
> We programmed a block storage(HLFS) patch for QEMU. Therefore,
> when i patched this driver for QEMU, it happened to me some errors.
> Could anyone give me some suggestions, thanks in advance ;-)
>
> You can see this issue i described i
This makes it easier to use checkpatch with a git hook or via patches.
Signed-off-by: Anthony Liguori
---
scripts/check-patches.sh | 24
1 file changed, 24 insertions(+)
create mode 100755 scripts/check-patches.sh
diff --git a/scripts/check-patches.sh b/scripts/check-p
Yet another optimization is to extend the mirroring iteration to include more
adjacent dirty blocks. This limits the number of I/O operations and makes
mirroring efficient even with a small granularity. Most of the infrastructure
is already in place; we only need to put a loop around the computat
On 01/21/2013 07:25 AM, Federico Simoncelli wrote:
> This option --output=[human|json] make qemu-img check output an human
s/make/makes/; s/an human/a human/
> or JSON representation at the choice of the user.
>
> Signed-off-by: Federico Simoncelli
> ---
> qapi-schema.json | 46 +++
>
With AIO support in place, we can start copying more than one chunk
in parallel. This patch introduces the required infrastructure for
this: the buffer is split into multiple granularity-sized chunks,
and there is a free list to access them.
Because of copy-on-write, a single operation may alread
This makes sense when the next commit starts using the extra buffer space
to perform many I/O operations asynchronously.
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
---
v2->v3: Add "since 1.4" notes to qapi-schema.json [Eric].
Add MAX when updating s->buf_size in the COW
1 - 100 of 261 matches
Mail list logo
