Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-04 Thread Michael S. Tsirkin
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > I'm not sure what issue the original commit was meant to fix, or if > the logic is actually wrong, but it causes e1000 to stop working > after a guest issues a reset. >

Re: [Qemu-devel] [PATCHv2] virtio-net: remove mq feature flag

2013-02-04 Thread Jason Wang
On 02/04/2013 03:41 PM, Michael S. Tsirkin wrote: > mq flag is not needed: we can look at the number of queues and set > the flag accordingly. > Removing this feature removes ambiguity (what does it mean to have > queues=2 with mq=off?), and simplifies compatibility hacks. > work-around for buggy w

Re: [Qemu-devel] [PATCHv2] virtio-net: remove mq feature flag

2013-02-04 Thread Michael Tokarev
04.02.2013 11:41, Michael S. Tsirkin wrote: mq flag is not needed: we can look at the number of queues and set the flag accordingly. Removing this feature removes ambiguity (what does it mean to have queues=2 with mq=off?), and simplifies compatibility hacks. work-around for buggy windows guests.

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Stefan Hajnoczi
On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > block.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) Hi Fabien, Please always CC qemu-devel@nongnu.org. All patches must be on qemu-devel so that the communit

Re: [Qemu-devel] [PATCHv2] virtio-net: remove mq feature flag

2013-02-04 Thread Stefan Hajnoczi
On Mon, Feb 04, 2013 at 09:41:47AM +0200, Michael S. Tsirkin wrote: > mq flag is not needed: we can look at the number of queues and set > the flag accordingly. > Removing this feature removes ambiguity (what does it mean to have > queues=2 with mq=off?), and simplifies compatibility hacks. > work-

Re: [Qemu-devel] [PATCH for 1.4] target-s390x: Fix wrong comparison in interrupt handling

2013-02-04 Thread Cornelia Huck
On Sun, 3 Feb 2013 21:33:16 +0100 Stefan Weil wrote: > gcc with -Wextra complains about an ordered pointer comparison: > > target-s390x/helper.c:660:27: warning: > ordered comparison of pointer with integer zero [-Wextra] > > Obviously the index was missing in the code. > > Signed-off-by: St

Re: [Qemu-devel] [PATCH v2 4/9] slirp: switch to GPollFD

2013-02-04 Thread Stefan Hajnoczi
On Sat, Feb 02, 2013 at 12:46:20PM +, Blue Swirl wrote: > On Fri, Feb 1, 2013 at 1:53 PM, Stefan Hajnoczi wrote: > > Slirp uses rfds/wfds/xfds more extensively than other QEMU components. > > > > The rarely-used out-of-band TCP data feature is used. That means we > > need the full table of se

Re: [Qemu-devel] [buildbot patch 4/6] use --disable-debug-info

2013-02-04 Thread Stefan Hajnoczi
On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > qemu-master.cfg |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) What is the rationale for these changes: --disable-debug-info to save buildslave disk space? Remove CFLAGS=-O2?

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-04 Thread Stefan Hajnoczi
On Sat, Feb 02, 2013 at 08:31:45AM +0100, Markus Armbruster wrote: > Seiji Aguchi writes: > > > [Issue] > > When we offer a customer support service and a problem happens > > in a customer's system, we try to understand the problem by > > comparing what the customer reports with message logs of

Re: [Qemu-devel] [PATCH for-1.4] Revert "e1000: no need auto-negotiation if link was down"

2013-02-04 Thread Stefan Hajnoczi
On Thu, Jan 31, 2013 at 05:43:51PM -0600, Michael Roth wrote: > This reverts commit 84dd2120247a7d25ff1bb337de21c0e76816ad2d. > > I'm not sure what issue the original commit was meant to fix, or if > the logic is actually wrong, but it causes e1000 to stop working > after a guest issues a reset. >

[Qemu-devel] Question about default floppy and stdvga memory

2013-02-04 Thread Fabio Fantoni
I tried to disable "default floppy" without use -nodefaults option that disable other things. I didn't found other parameters to do that in docs and code for now. Can someone tell me if there is another way to disable default floppy only? About stdvga, I found that memory is configurable from d

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-04 Thread Paolo Bonzini
Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto: >> > static Property virtio_serial_properties[] = { >> > DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, >> > VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true), >> > -DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, >> > DEV_NVECTORS

Re: [Qemu-devel] How many msi-x vectors should be allocated for the virtio-serial device?

2013-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2013 at 10:42:32AM +0100, Paolo Bonzini wrote: > Il 03/02/2013 13:11, Michael S. Tsirkin ha scritto: > >> > static Property virtio_serial_properties[] = { > >> > DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags, > >> > VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true), > >> > -D

[Qemu-devel] [PATCH v3] hw: add WM8731 codec support

2013-02-04 Thread Kuo-Jung Su
From: Kuo-Jung Su Wolfson WM8731 is a simple audio codec for embedded systems. It has 2 input and 1 output ports: ** Input ** 1. Linue-In 2. Microphone ** Output ** 1. Headphone out BTW it's based on hw/wm8750.c with 16bit I2S support by default. Signed-off-by: Kuo-Jung Su Cc: An

[Qemu-devel] [PATCH v3] hw/m25p80.c: add WRSR(0x01) support

2013-02-04 Thread Kuo-Jung Su
From: Kuo-Jung Su Atmel, SST and Intel/Numonyx serial flash tend to power up with the software protection bits set. And thus the new m25p80.c in linux kernel would always tries to use WREN(0x06) + WRSR(0x01) to turn-off the protection. The WEL(0x02) of status register is supposed to be cleared a

[Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2013-02-04 Thread LocutusOfBorg
** Changed in: qemu Status: New => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1042388 Title: qemu: Unsupported syscall: 257 (timer_create) Status in QEMU: Confirmed Bug desc

Re: [Qemu-devel] [buildbot patch 4/6] use --disable-debug-info

2013-02-04 Thread Gerd Hoffmann
On 02/04/13 10:26, Stefan Hajnoczi wrote: > On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann >> --- >> qemu-master.cfg |6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) > > What is the rationale for these changes: > > --disable-debug

[Qemu-devel] [PATCH v3] target-arm: add Faraday ARMv5TE processors support

2013-02-04 Thread Kuo-Jung Su
From: Kuo-Jung Su Faraday processors are a series of ARMv4/ARMv5TE clone. * ARMv4 series (FA526, FA626). All of them are now out-of-date, so I have no plan for them. * ARMv5TE series (FA606TE, FA626TE, FA616TE, FA726TE) All the single core RISC listed above are included in this patch.

Re: [Qemu-devel] [PATCH] vnc: recognize Hungarian doubleacutes

2013-02-04 Thread Laszlo Ersek
On 02/03/13 21:36, Michael Tokarev wrote: > { "Zabovedot",0x1af}, > { "zacute", 0x1bc}, > { "Zacute", 0x1ac}, > +{ "Odoubleacute", 0x1d5}, Ő > +{ "Udoubleacute", 0x1db}, Ű > { "cacute", 0x1e6}, > { "Cacute",

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: >> >> Signed-off-by: Fabien Chouteau >> --- >> block.c | 13 ++--- >> 1 file changed, 10 insertions(+), 3 deletions(-) > > Hi Fabien, > Please always CC qemu-devel@nongnu.org. All patches must

Re: [Qemu-devel] Question about default floppy and stdvga memory

2013-02-04 Thread Markus Armbruster
Fabio Fantoni writes: > I tried to disable "default floppy" without use -nodefaults option > that disable other things. > I didn't found other parameters to do that in docs and code for now. > Can someone tell me if there is another way to disable default floppy only? As far as I know, there is

[Qemu-devel] Patch queue for qemu-1.1.3 stable release

2013-02-04 Thread Michael Tokarev
Hello. This is my attempt at releasing a next stable/bugfix release of abandomed 1.1 series of qemu. I tried my best to colledt all fixes, and the last 1.1 has been out for quite a while now, so it think it is time to release 1.1.3 or not do it at all. Several distributions are using 1.1 in thei

[Qemu-devel] [PATCH 03/60] use --libexecdir instead of ignoring it first and reinventing it later

2013-02-04 Thread Michael Tokarev
Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version of bridge helper" put the bridge helper executable into a fixed ${prefix}/libexec/ location, instead of using ${libexecdir} for this. At the same time, --libexecdir is being happily ignored by ./configure. Even more, the same patc

[Qemu-devel] [PATCH 35/60] s390x: fix -initrd in virtio machine

2013-02-04 Thread Michael Tokarev
From: Alexander Graf When using -initrd in the virtio machine, we need to indicate the initrd start and size inside the kernel image. These parameters need to be stored in native endianness. Signed-off-by: Alexander Graf Acked-by: Richard Henderson Acked-by: Christian Borntraeger (cherry pick

[Qemu-devel] [PATCH 53/60] hw/qxl: qxl_send_events: nop if stopped

2013-02-04 Thread Michael Tokarev
From: Alon Levy Added a trace point for easy logging. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=870972 Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann (cherry picked from commit 511aefb0c60e3063ead76d4ba6aabf619eed18ef) Conflicts: hw/qxl.c trace-events Cc: Doug

[Qemu-devel] [PATCH 17/60] net: notify iothread after flushing queue

2013-02-04 Thread Michael Tokarev
From: Paolo Bonzini virtio-net has code to flush the queue and notify the iothread whenever new receive buffers are added by the guest. That is fine, and indeed we need to do the same in all other drivers. However, notifying the iothread should be work for the network subsystem. And since we ar

[Qemu-devel] [PATCH 52/60] uhci: Don't queue up packets after one with the SPD flag set

2013-02-04 Thread Michael Tokarev
From: Hans de Goede Don't queue up packets after a packet with the SPD (short packet detect) flag set. Since we won't know if the packet will actually be short until it has completed, and if it is short we should stop the queue. This fixes a miniature photoframe emulating a USB cdrom with the wi

[Qemu-devel] [PATCH 46/60] e1000: Discard oversized packets based on SBP|LPE

2013-02-04 Thread Michael Tokarev
From: Michael Contreras Discard packets longer than 16384 when !SBP to match the hardware behavior. Signed-off-by: Michael Contreras Signed-off-by: Stefan Hajnoczi (cherry picked from commit 2c0331f4f7d241995452b99afaf0aab00493334a) Signed-off-by: Michael Tokarev --- hw/e1000.c |7 +

[Qemu-devel] [PATCH 45/60] e1000: Discard packets that are too long if !SBP and !LPE

2013-02-04 Thread Michael Tokarev
From: Michael Contreras The e1000_receive function for the e1000 needs to discard packets longer than 1522 bytes if the SBP and LPE flags are disabled. The linux driver assumes this behavior and allocates memory based on this assumption. Signed-off-by: Michael Contreras Signed-off-by: Anthony L

Re: [Qemu-devel] [PATCH 10/60] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2013-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2013 at 02:40:20PM +0400, Michael Tokarev wrote: > From: Jason Baron > > The Advanced Error Interrupt Message Number (bits 31:27 of the Root > Error Status Register) is updated when the number of msi messages assigned to > a > device changes. Migration of windows 7 on q35 chipset

[Qemu-devel] [PATCH 38/60] xhci: fix usb name in caps

2013-02-04 Thread Michael Tokarev
From: Gerd Hoffmann Used to be "UTB" not "USB". Signed-off-by: Gerd Hoffmann (cherry picked from commit 0ebfb144e8ad3f2da436d630fdcc5aa9ab646341) --- hw/usb/hcd-xhci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index 5cf1a64

[Qemu-devel] [PATCH 58/60] qxl: save qemu_create_displaysurface_from result

2013-02-04 Thread Michael Tokarev
From: Gerd Hoffmann Spotted by Coverity. https://bugzilla.redhat.com/show_bug.cgi?id=885644 Cc: qemu-sta...@nongnu.org Reported-by: Markus Armbruster Signed-off-by: Gerd Hoffmann (cherry picked from commit 2f464b5a32b414adb545acc6d94b5c35c7d258ba) Signed-off-by: Michael Tokarev --- hw/qxl-

[Qemu-devel] [PATCH 27/60] x86: Fixed incorrect segment base address addition in 64-bits mode

2013-02-04 Thread Michael Tokarev
From: Vitaly Chipounov According to the Intel manual "Intel® 64 and IA-32 Architectures Software Developer’s Manual Volume 3", "3.4.4 Segment Loading Instructions in IA-32e Mode": "When in compatibility mode, FS and GS overrides operate as defined by 32-bit mode behavior regardless of the value

[Qemu-devel] [PATCH 50/60] slirp: Don't crash on packets from 0.0.0.0/8.

2013-02-04 Thread Michael Tokarev
From: Nickolai Zeldovich LWIP can generate packets with a source of 0.0.0.0, which triggers an assertion failure in arp_table_add(). Instead of crashing, simply return to avoid adding an invalid ARP table entry. Signed-off-by: Nickolai Zeldovich Signed-off-by: Jan Kiszka (cherry picked from c

[Qemu-devel] [PATCH 12/60] intel_hda: do not call msi_reset when only device state needs resetting

2013-02-04 Thread Michael Tokarev
Commit 8e729e3b521d9 "intel-hda: Fix reset of MSI function" (applied to 1.1.1 as 0ec39075710) added a call to msi_reset() into intel_hda_reset() function. But this function is called not only from PCI bus reset method, but also from device init method (intel_hda_set_g_ctl()), and there, we should

[Qemu-devel] [PATCH 43/60] qcow2: Fix avail_sectors in cluster allocation code

2013-02-04 Thread Michael Tokarev
From: Kevin Wolf avail_sectors should really be the number of sectors from the start of the allocation, not from the start of the write request. We're lucky enough that this mistake didn't cause any real bug. avail_sectors is only used in the intialiser of QCowL2Meta: .nb_available = MIN(re

[Qemu-devel] [PATCH 44/60] qcow2: Fix refcount table size calculation

2013-02-04 Thread Michael Tokarev
From: Kevin Wolf A missing factor for the refcount table entry size in the calculation could mean that too little memory was allocated for the in-memory representation of the table, resulting in a buffer overflow. Signed-off-by: Kevin Wolf Reviewed-by: Michael Tokarev Tested-by: Michael Tokare

[Qemu-devel] [PATCH 14/60] fpu/softfloat.c: Return correctly signed values from uint64_to_float32

2013-02-04 Thread Michael Tokarev
From: Peter Maydell The uint64_to_float32() conversion function was incorrectly always returning numbers with the sign bit set (ie negative numbers). Correct this so we return positive numbers instead. Signed-off-by: Peter Maydell Signed-off-by: Aurelien Jarno (cherry picked from commit e744c0

[Qemu-devel] [PATCH 39/60] m68k: Return semihosting errno values correctly

2013-02-04 Thread Michael Tokarev
From: Meador Inge Fixing a simple typo, s/errno/err/, that caused the error status from GDB semihosted system calls to be returned incorrectly. Signed-off-by: Meador Inge Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell Signed-off-by: Blue Swirl (cherry picked from commit aed91c1bff5

[Qemu-devel] [PATCH 59/60] target-xtensa: fix ITLB/DTLB page protection flags

2013-02-04 Thread Michael Tokarev
From: Max Filippov With MMU option xtensa architecture has two TLBs: ITLB and DTLB. ITLB is only used for code access, DTLB is only for data. However TLB entries in both TLBs have attribute field controlling write and exec access. These bits need to be properly masked off depending on TLB type be

Re: [Qemu-devel] [PATCH 10/60] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2013-02-04 Thread Michael Tokarev
04.02.2013 14:52, Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 02:40:20PM +0400, Michael Tokarev wrote: From: Jason Baron The Advanced Error Interrupt Message Number (bits 31:27 of the Root Error Status Register) is updated when the number of msi messages assigned to a device changes. Mig

Re: [Qemu-devel] [PATCH qom-cpu-next v3 2/4] target-i386: Split command line parsing out of cpu_x86_register()

2013-02-04 Thread Igor Mammedov
On Sat, 2 Feb 2013 01:37:06 +0100 Andreas Färber wrote: > In order to instantiate a CPU subtype we will need to know which type, > so move the cpu_model splitting into cpu_x86_init(). > > Parameters need to be set on the X86CPU instance, so move > cpu_x86_parse_featurestr() into cpu_x86_init()

[Qemu-devel] [PATCH 55/60] arm_boot: Change initrd load address to "halfway through RAM"

2013-02-04 Thread Michael Tokarev
From: Peter Maydell To avoid continually having to bump the initrd load address to account for larger kernel images, put the initrd halfway through RAM. This allows large kernels on new boards with lots of RAM to work OK, without breaking existing usecases for boards with only 32MB of RAM. Note

Re: [Qemu-devel] [PATCH 10/60] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2013-02-04 Thread Michael Tokarev
04.02.2013 14:56, Michael Tokarev wrote: 04.02.2013 14:52, Michael S. Tsirkin wrote: On Mon, Feb 04, 2013 at 02:40:20PM +0400, Michael Tokarev wrote: From: Jason Baron The Advanced Error Interrupt Message Number (bits 31:27 of the Root Error Status Register) is updated when the number of msi

Re: [Qemu-devel] [PATCH V20 1/8] Support for TPM command line options

2013-02-04 Thread Luiz Capitulino
On Fri, 01 Feb 2013 10:33:01 -0500 Corey Bryant wrote: > > +## > > +# @TPMInfo: > > +# > > +# Information about the TPM > > +# > > +# @model: The TPM frontend model, i.e., tpm-tis > > +# > > +# @id: The ID of the TPM > > +# > > +# @type: The type of TPM backend, i.e., passthrough > > +# > > +# @p

[Qemu-devel] [PATCH 06/60] fix doc of using raw values with sendkey

2013-02-04 Thread Michael Tokarev
From: Amos Kong (qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values, and the raw value in decimal format is not supported. Signed-off-by: Amos Kong Signed-off-by: Luiz Capitulino (cherry picked f

[Qemu-devel] [PATCH 23/60] hw/qxl: qxl_dirty_surfaces: use uintptr_t

2013-02-04 Thread Michael Tokarev
From: Alon Levy As suggested by Paolo Bonzini, to avoid possible integer overflow issues. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann (cherry picked from commit c5825ac6c861bfe1a4adfa27517931b56079e298) Signed-off-by: Michael Tokarev --- hw/qxl.c |4 ++-- 1 file changed, 2 ins

[Qemu-devel] [PATCH 28/60] Fixes related to processing of qemu's -numa option

2013-02-04 Thread Michael Tokarev
From: Chegu Vinod The -numa option to qemu is used to create [fake] numa nodes and expose them to the guest OS instance. There are a couple of issues with the -numa option: a) Max VCPU's that can be specified for a guest while using the qemu's -numa option is 64. Due to a typecasting issue

[Qemu-devel] [PATCH 08/60] eepro100: Fix network hang when rx buffers run out

2013-02-04 Thread Michael Tokarev
From: Bo Yang This is reported by QA. When installing os with pxe, after the initial kernel and initrd are loaded, the procedure tries to copy files from install server to local harddisk, the network becomes stall because of running out of receive descriptor. [Whitespace fixes and removed qemu_n

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Fabien Chouteau
On 02/04/2013 11:34 AM, Markus Armbruster wrote: > Stefan Hajnoczi writes: > >> On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: >>> >>> Signed-off-by: Fabien Chouteau >>> --- >>> block.c | 13 ++--- >>> 1 file changed, 10 insertions(+), 3 deletions(-) >> >> Hi Fabien,

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-04 Thread Yan Vugenfirer
On Feb 4, 2013, at 1:30 AM, Vadim Rozenfeld wrote: > On Sun, 2013-02-03 at 15:09 -0600, Anthony Liguori wrote: >> Michael Tokarev writes: >> >>> 03.02.2013 17:23, Yan Vugenfirer wrote: >>> > If it helps, mq changes the config size from 8 to 16 bytes. If the > driver was making an assu

[Qemu-devel] [PATCH 41/60] mips/malta: fix CBUS UART interrupt pin

2013-02-04 Thread Michael Tokarev
From: Aurelien Jarno According to the MIPS Malta Developement Platform User's Manual, the i8259 interrupt controller is supposed to be connected to the hardware IRQ0, and the CBUS UART to the hardware interrupt 2. In QEMU they are both connected to hardware interrupt 0, the CBUS UART interrupt b

[Qemu-devel] [PATCH 49/60] tap: reset vnet header size on open

2013-02-04 Thread Michael Tokarev
From: "Michael S. Tsirkin" For tap, we currently assume the vnet header size is 10 (the default value) but that might not be the case if tap is persistent and has been used by qemu previously. To fix, set host header size in tap device on open. Signed-off-by: Michael S. Tsirkin Tested-by: Alexa

Re: [Qemu-devel] [RFC][PATCH]Add timestamp to error message

2013-02-04 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Sat, Feb 02, 2013 at 08:31:45AM +0100, Markus Armbruster wrote: >> Seiji Aguchi writes: >> >> > [Issue] >> > When we offer a customer support service and a problem happens >> > in a customer's system, we try to understand the problem by >> > comparing what the cus

[Qemu-devel] [PATCH 31/60] linux-user: fix emulation of getdents

2013-02-04 Thread Michael Tokarev
From: "Dmitry V. Levin" In case when TARGET_ABI_BITS == 32 && HOST_LONG_BITS == 64, the last byte of the target dirent structure (aka d_type byte) was never copied from the host dirent structure, thus breaking everything that relies on valid d_type value, e.g. glob(3). Reviewed-by: Peter Maydell

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-04 Thread Michael S. Tsirkin
On Mon, Feb 04, 2013 at 02:00:46PM +0200, Yan Vugenfirer wrote: > > On Feb 4, 2013, at 1:30 AM, Vadim Rozenfeld wrote: > > > On Sun, 2013-02-03 at 15:09 -0600, Anthony Liguori wrote: > >> Michael Tokarev writes: > >> > >>> 03.02.2013 17:23, Yan Vugenfirer wrote: > >>> > > If it helps, mq c

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Markus Armbruster
Fabien Chouteau writes: > On 02/04/2013 11:34 AM, Markus Armbruster wrote: >> Stefan Hajnoczi writes: >> >>> On Fri, Feb 01, 2013 at 06:13:51PM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau --- block.c | 13 ++--- 1 file changed, 10 insertions

Re: [Qemu-devel] [PATCH qom-cpu-next v3 2/4] target-i386: Split command line parsing out of cpu_x86_register()

2013-02-04 Thread Andreas Färber
Am 04.02.2013 12:14, schrieb Igor Mammedov: > On Sat, 2 Feb 2013 01:37:06 +0100 > Andreas Färber wrote: > >> diff --git a/target-i386/cpu.c b/target-i386/cpu.c >> index e74802b..ee2fd6b 100644 >> --- a/target-i386/cpu.c >> +++ b/target-i386/cpu.c [..] >> @@ -1578,26 +1566,50 @@ out: >> >> X86

[Qemu-devel] [PATCH 18/60] e1000: flush queue whenever can_receive can go from false to true

2013-02-04 Thread Michael Tokarev
From: Paolo Bonzini When the guests replenish the receive ring buffer, the network device should flush its queue of pending packets. This is done with qemu_flush_queued_packets. e1000's can_receive can go from false to true when RCTL or RDT are modified. Reported-by: Luigi Rizzo Cc: Stefan Ha

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-04 Thread Vadim Rozenfeld
On Mon, 2013-02-04 at 14:22 +0200, Michael S. Tsirkin wrote: > On Mon, Feb 04, 2013 at 02:00:46PM +0200, Yan Vugenfirer wrote: > > > > On Feb 4, 2013, at 1:30 AM, Vadim Rozenfeld wrote: > > > > > On Sun, 2013-02-03 at 15:09 -0600, Anthony Liguori wrote: > > >> Michael Tokarev writes: > > >> > >

Re: [Qemu-devel] [PATCH v3 01/10] main-loop: fix select_ret uninitialized variable warning

2013-02-04 Thread Laszlo Ersek
On 02/04/13 13:12, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > main-loop.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/main-loop.c b/main-loop.c > index 6f52ac3..d0d8fe4 100644 > --- a/main-loop.c > +++ b/main-loop.c > @@ -330,7 +330,8 @@ void q

Re: [Qemu-devel] [PATCH 1/4] migration: change initial value of expected_downtime

2013-02-04 Thread Orit Wasserman
On 02/01/2013 02:32 PM, Juan Quintela wrote: > 0 is a very bad initial value, what we are trying to get is > max_downtime, so that is a much better estimation. > > Signed-off-by: Juan Quintela > --- > migration.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/migration.c b/migration

Re: [Qemu-devel] [PATCH 2/4] migration: calculate end time after we have sent the data

2013-02-04 Thread Orit Wasserman
On 02/01/2013 02:32 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > migration.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/migration.c b/migration.c > index d86946e..67abd12 100644 > --- a/migration.c > +++ b/migration.c > @@ -681,7 +681,7 @@ stati

[Qemu-devel] [PATCH 09/60] ahci: properly reset PxCMD on HBA reset

2013-02-04 Thread Michael Tokarev
From: Jason Baron While testing q35, I found that windows 7 (specifically, windows 7 ultimate with sp1 x64), wouldn't install because it can't find the cdrom or disk drive. The failure message is: 'A required cd/dvd device driver is missing. If you have a driver floppy disk, CD, DVD, or USB flash

Re: [Qemu-devel] [PATCH 3/4] migration: don't account sleep time for calculating bandwidth

2013-02-04 Thread Orit Wasserman
On 02/01/2013 02:32 PM, Juan Quintela wrote: > While we are sleeping we are not sending, so we should not use that > time to estimate our bandwidth. Juan, Maybe I missing something here but the sleep time is cause by the fact we limit the migration bandwidth. So the available bandwidth should take

[Qemu-devel] [PATCH 0/4] char: flow control: fixes, virtio-serial flow control

2013-02-04 Thread Amit Shah
Hi Anthony, This series is based on top of your char-flow.2 branch on github. Patches 1 and 2 fix return values, and make the series work properly. These small patches should ideally be folded in the patches that introduced the code. Patch 3 adds gio watch support for unix and tcp sockets. Patc

[Qemu-devel] [PATCH 05/60] fix CONFIG_QEMU_HELPERDIR generation again

2013-02-04 Thread Michael Tokarev
commit 38f419f35225 fixed a breakage with CONFIG_QEMU_HELPERDIR which has been introduced by 8bf188aa18ef7a8. But while techinically that fix has been correct, all other similar variables are handled differently. Make it consistent, and let scripts/create_config expand and capitalize the variable

[Qemu-devel] [PATCH 1/4] char: poll a frontend only if it's writable

2013-02-04 Thread Amit Shah
If the frontend reports it's not writable, don't start polling it for data yet. Signed-off-by: Amit Shah --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 2b714cf..5731d02 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -569,7 +569,

[Qemu-devel] [PATCH 2/4] char: fix return value of can_read functions on no input

2013-02-04 Thread Amit Shah
When the can_read functions report the frontend isn't ready to accept data yet, return 'FALSE' instead of 'TRUE'. Signed-off-by: Amit Shah --- qemu-char.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 5731d02..7fa9372 100644 --- a/qemu-

Re: [Qemu-devel] [PATCH 4/4] migration: calculate expected_downtime

2013-02-04 Thread Orit Wasserman
On 02/01/2013 02:32 PM, Juan Quintela wrote: > We removed the calculation in commit e4ed1541ac9413eac494a03532e34beaf8a7d1c5 > > Now we add it back. We need to create dirty_bytes_rate because we > can't include cpu-all.h from migration.c, and there is no other way to > include TARGET_PAGE_SIZE. >

Re: [Qemu-devel] [PATCH qom-cpu-next v3 3/4] target-i386: Slim conversion to X86CPU subclasses

2013-02-04 Thread Andreas Färber
Am 04.02.2013 12:08, schrieb Igor Mammedov: > On Sat, 2 Feb 2013 01:37:07 +0100 > Andreas Färber wrote: > >> Move x86_def_t definition to header and embed into X86CPUClass. >> Register types per built-in model definition. >> >> Move version initialization from x86_cpudef_setup() to class_init. >

[Qemu-devel] [PATCH 30/60] MIPS: Correct FCR0 initialization

2013-02-04 Thread Michael Tokarev
From: Nathan Froyd This change addresses a problem where QEMU incorrectly traps on floating-point MADD group instructions with SIGILL, at least while emulating MIPS32r2 processors. These instructions use the COP1X major opcode and include ones like: madd.d $f2,$f4,$f2,$f6 Here's Nat

[Qemu-devel] [PATCH 19/60] fix entry pointer for ELF kernels loaded with -kernel option

2013-02-04 Thread Michael Tokarev
From: Henning Schild Find a hopefully proper patch attached. Take it or leave it. Reviewed-by: Kevin Wolf Signed-off-by: Henning Schild Signed-off-by: Aurelien Jarno (cherry picked from commit 7e9c7ffe9fd9dfc3d0168dd584936db8144b230b) Signed-off-by: Michael Tokarev --- hw/elf_ops.h | 11

Re: [Qemu-devel] [buildbot patch 4/6] use --disable-debug-info

2013-02-04 Thread Stefan Hajnoczi
On Mon, Feb 04, 2013 at 10:59:33AM +0100, Gerd Hoffmann wrote: > On 02/04/13 10:26, Stefan Hajnoczi wrote: > > On Fri, Feb 01, 2013 at 03:02:23PM +0100, Gerd Hoffmann wrote: > >> Signed-off-by: Gerd Hoffmann > >> --- > >> qemu-master.cfg |6 -- > >> 1 file changed, 4 insertions(+), 2 dele

[Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Stefan Hajnoczi
Use g_poll(3) instead of select(2). Well, this is kind of a cheat. It's true that we're now using g_poll(3) on POSIX hosts but the *_fill() and *_poll() functions are still using rfds/wfds/xfds. We've set the scene to start converting *_fill() and *_poll() functions step-by-step until no more rfd

[Qemu-devel] [PATCH 11/60] net: add -netdev options to man page

2013-02-04 Thread Michael Tokarev
From: Stefan Hajnoczi Document the -netdev syntax which supercedes the older -net syntax. This patch is a first step to making -netdev prominent in the QEMU manual. Reported-by: Anatoly Techtonik Signed-off-by: Stefan Hajnoczi (cherry picked from commit 08d12022c7f1aba6a75150659c6e4c9dff23

[Qemu-devel] [PATCH 40/60] nbd: fixes to read-only handling

2013-02-04 Thread Michael Tokarev
From: Paolo Bonzini We do not need BLKROSET if the kernel supports setting flags. Also, always do BLKROSET even for a read-write export, otherwise the read-only state remains "sticky" after the invocation of "qemu-nbd -r". Signed-off-by: Paolo Bonzini (cherry picked from commit c8969eded252058e

[Qemu-devel] [PATCH 10/60] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2013-02-04 Thread Michael Tokarev
From: Jason Baron The Advanced Error Interrupt Message Number (bits 31:27 of the Root Error Status Register) is updated when the number of msi messages assigned to a device changes. Migration of windows 7 on q35 chipset failed because the check in get_pci_config_device() fails due to cmask being

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Fabien Chouteau
On 02/04/2013 01:24 PM, Markus Armbruster wrote: > Fabien Chouteau writes: > >> On 02/04/2013 11:34 AM, Markus Armbruster wrote: >> >> Why? The caller doesn't know the difference between Windows/Linux >> implementation. And the error handling would have to be duplicated. > > The function's (impl

[Qemu-devel] [PATCH v3 03/10] main-loop: switch POSIX glib integration to GPollFD

2013-02-04 Thread Stefan Hajnoczi
Convert glib file descriptor polling from rfds/wfds/xfds to GPollFD. The Windows code still needs poll_fds[] and n_poll_fds but they can now become local variables. Signed-off-by: Stefan Hajnoczi --- main-loop.c | 71 +++-- 1 file changed,

Re: [Qemu-devel] Question about default floppy and stdvga memory

2013-02-04 Thread Fabio Fantoni
Il 04/02/2013 11:36, Markus Armbruster ha scritto: Fabio Fantoni writes: I tried to disable "default floppy" without use -nodefaults option that disable other things. I didn't found other parameters to do that in docs and code for now. Can someone tell me if there is another way to disable def

[Qemu-devel] [PATCH 29/60] usb-storage: fix SYNCHRONIZE_CACHE

2013-02-04 Thread Michael Tokarev
From: Gerd Hoffmann Commit 59310659073d85745854f2f10c4292555c5a1c51 is incomplete, we'll arrive in the scsi command complete callback in CSW state and must handle that case correctly. Signed-off-by: Gerd Hoffmann (cherry picked from commit 54414218d78c9d043417b27bb29bd0334b4e3cb5) Signed-off-b

[Qemu-devel] [PATCH 36/60] PPC: Bamboo: Fix memory size DT property

2013-02-04 Thread Michael Tokarev
From: Alexander Graf Device tree properties need to be specified in big endian. Fix the bamboo memory size property accordingly. Signed-off-by: Alexander Graf CC: qemu-sta...@nongnu.org (cherry picked from commit 5232fa59b17b45c04bd24e0d38224964816bf391) Signed-off-by: Michael Tokarev --- hw

[Qemu-devel] [PATCH 24/60] qxl: always update displaysurface on resize

2013-02-04 Thread Michael Tokarev
From: Gerd Hoffmann Don't try to be clever and skip displaysurface reinitialization in case the size hasn't changed. Other parameters might have changed nevertheless, for example depth or stride, resulting in rendering being broken then. Trigger: boot linux guest with vesafb, start X11, make su

Re: [Qemu-devel] [PATCH qom-cpu-next v3 3/4] target-i386: Slim conversion to X86CPU subclasses

2013-02-04 Thread Igor Mammedov
On Sat, 2 Feb 2013 01:37:07 +0100 Andreas Färber wrote: > Move x86_def_t definition to header and embed into X86CPUClass. > Register types per built-in model definition. > > Move version initialization from x86_cpudef_setup() to class_init. > > Inline cpu_x86_register() into the X86CPU initfn.

Re: [Qemu-devel] [PATCH for-1.4] target-cris: Build fix for debug output

2013-02-04 Thread Andreas Färber
Am 27.01.2013 07:26, schrieb Andreas Färber: > Around r3361 (81fdc5f8d2d681da8d255baf0713144f8656bac9) env->debug1 used > to contain the address of an MMU fault. This is now written into > env->pregs[PR_EDA] instead. > > Signed-off-by: Andreas Färber > --- > target-cris/op_helper.c |2 +- >

Re: [Qemu-devel] [PATCH] get_tmp_filename: add explicit error message

2013-02-04 Thread Andreas Färber
Am 04.02.2013 14:33, schrieb Fabien Chouteau: > On 02/04/2013 01:24 PM, Markus Armbruster wrote: >> >> Good error reporting is hard. Knowledge about the error and its context >> gets lost as you move up the call chain. Knowledge about how to report >> errors gets lost as you move down. >> > > Yo

[Qemu-devel] [PATCH] block/raw-posix: detect readonly LVM volumes using BLKROGET

2013-02-04 Thread Stefan Hajnoczi
LVM volumes can be set read-only with "lvchange --permission r ". The device node permissions remain unchanged so the volume can still be opened O_RDWR. Actual writes will fail. This results in odd behavior for QEMU. bdrv_open() is supposed to fail if a read-only image is being opened with BDRV

[Qemu-devel] [PATCH 51/60] vmdk: Fix data corruption bug in WRITE and READ handling

2013-02-04 Thread Michael Tokarev
From: Gerhard Wiesinger Fixed a MAJOR BUG in VMDK files on file boundaries on reads and ALSO ON WRITES WHICH MIGHT CORRUPT THE IMAGE AND DATA!! Triggered for example with the following VMDK file (partly listed): RW 4193792 FLAT "XP-W1-f001.vmdk" 0 RW 2097664 FLAT "XP-W1-f002.vmdk" 0 RW 41937

[Qemu-devel] [PATCH 01/60] tcg/s390: fix ld/st with CONFIG_TCG_PASS_AREG0

2013-02-04 Thread Michael Tokarev
From: Aurelien Jarno The load/store slow path has been broken in e141ab52d: - We need to move 4 registers for store functions and 3 registers for load functions and not the reverse. - According to the s390x calling convention the arguments of a function should be zero extended. This means tha

[Qemu-devel] [PATCH 06/10] qdev: Implement (variable length) array properties

2013-02-04 Thread Peter Maydell
Add support for declaring array properties for qdev devices. These work by defining an initial static property 'len-arrayname' which the user of the device should set to the desired size of the array. When this property is set, memory is allocated for the array elements, and dynamic properties "arr

[Qemu-devel] [PATCH v3 05/10] slirp: switch to GPollFD

2013-02-04 Thread Stefan Hajnoczi
Slirp uses rfds/wfds/xfds more extensively than other QEMU components. The rarely-used out-of-band TCP data feature is used. That means we need the full table of select(2) to g_poll(3) events: rfds -> G_IO_IN | G_IO_HUP | G_IO_ERR wfds -> G_IO_OUT | G_IO_ERR xfds -> G_IO_PRI I came up wit

[Qemu-devel] [PATCH 37/60] target-sparc64: disable VGA cirrus

2013-02-04 Thread Michael Tokarev
From: Aurelien Jarno OpenBIOS on sparc64 only support Standard VGA and not Cirrus VGA. Don't build Cirrus VGA support so that it can't be selected. This fixes the breakage introduced by commit f2898771. Reported-by: Richard Henderson Cc: Blue Swirl Signed-off-by: Aurelien Jarno Tested-by: Ri

Re: [Qemu-devel] Headsup: windows virtio networking does not work on current git

2013-02-04 Thread Anthony Liguori
Rusty Russell writes: > Anthony Liguori writes: >> Michael Tokarev writes: >> >>> 03.02.2013 17:23, Yan Vugenfirer wrote: >>> > If it helps, mq changes the config size from 8 to 16 bytes. If the > driver was making an assumption about an 8-byte config size, that's > likely what the

Re: [Qemu-devel] [PATCH v3 02/10] main-loop: switch to g_poll() on POSIX hosts

2013-02-04 Thread Laszlo Ersek
Comments in-line. On 02/04/13 13:12, Stefan Hajnoczi wrote: > Use g_poll(3) instead of select(2). Well, this is kind of a cheat. > It's true that we're now using g_poll(3) on POSIX hosts but the *_fill() > and *_poll() functions are still using rfds/wfds/xfds. > > We've set the scene to start con

[Qemu-devel] [PATCH 32/60] qed: refuse unaligned zero writes with a backing file

2013-02-04 Thread Michael Tokarev
From: Stefan Hajnoczi Zero writes have cluster granularity in QED. Therefore they can only be used to zero entire clusters. If the zero write request leaves sectors untouched, zeroing the entire cluster would obscure the backing file. Instead return -ENOTSUP, which is handled by block.c:bdrv_c

[Qemu-devel] [PATCH 34/60] memory: fix rendering of a region obscured by another

2013-02-04 Thread Michael Tokarev
From: Avi Kivity The memory core drops regions that are hidden by another region (for example, during BAR sizing), but it doesn't do so correctly if the lower address of the existing range is below the lower address of the new range. Example (qemu-system-mips -M malta -kernel vmlinux-2.6.32-5-4k

Re: [Qemu-devel] [PATCH 0/4] migration stats fixes

2013-02-04 Thread Chegu Vinod
On 02/01/2013 02:32 PM, Juan Quintela wrote: Hi migration expected_downtime calculation was removed on commit e4ed1541ac9413eac494a03532e34beaf8a7d1c5. We add the calculation back. Before doing the calculation we do: - expected_downtime intial value is max_downtime. Much, much better int

Re: [Qemu-devel] Question about default floppy and stdvga memory

2013-02-04 Thread Markus Armbruster
Fabio Fantoni writes: > Il 04/02/2013 11:36, Markus Armbruster ha scritto: >> Fabio Fantoni writes: >> >>> I tried to disable "default floppy" without use -nodefaults option >>> that disable other things. >>> I didn't found other parameters to do that in docs and code for now. >>> Can someone te

[Qemu-devel] [PATCH 02/60] qemu-char: BUGFIX, don't call FD_ISSET with negative fd

2013-02-04 Thread Michael Tokarev
From: David Gibson tcp_chr_connect(), unlike for example udp_chr_update_read_handler() does not check if the fd it is using is valid (>= 0) before passing it to qemu_set_fd_handler2(). If using e.g. a TCP serial port, which is not initially connected, this can result in -1 being passed to FD_ISS

  1   2   3   >