Am 05.02.2013 01:21, schrieb Richard Henderson:
> The build is broken on ppc64-linux, possibly only with new binutils:
>
> ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree'
> ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \
> adding it to the linker command lin
Blue Swirl writes:
> On Mon, Feb 4, 2013 at 5:19 PM, Markus Armbruster wrote:
>> Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and
>> stress test at
>> http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt
>
> There's no license. Can we use that?
It's been used widely,
Il 04/02/2013 23:30, Peter Maydell ha scritto:
> On 4 February 2013 17:30, Paolo Bonzini wrote:
>> Some devices or headers are using poisoned identifiers.
>> For .c files, some are useless and we remove them.
>>
>> For headers, wrap the definitions in the headers with
>>
>
> Truncated sentence?
>
From: "Aneesh Kumar K.V"
Since these values can possibly be sent from guest (for hw/9pfs), do a sanity
check
on them. A 9p write request with 0 bytes caused qemu to abort without this patch
Signed-off-by: Aneesh Kumar K.V
---
util/iov.c |4
1 file changed, 4 insertions(+)
diff --git
Il 25/01/2013 15:04, Andreas Färber ha scritto:
> Am 25.01.2013 14:12, schrieb Paolo Bonzini:
>> Make it clear that no BUS() macro is needed in the callers (in fact it
>> wouldn't work because the object has not been initialized yet with the
>> right class).
>>
>> Suggested-by: Andreas Faerber
>>
Il 04/02/2013 22:23, Peter Maydell ha scritto:
> On 4 February 2013 20:51, Paolo Bonzini wrote:
>> Il 04/02/2013 21:33, Peter Maydell ha scritto:
The $FOO device models should all be in hw/$FOO. But there are some
parts that do not fit in a category
>>>
>>> Surely this is what hw/misc i
From: "Aneesh Kumar K.V"
We use the clunk request to do the actual xattr operation. So don't
ignore the error value for fid clunk.
Security model "none" don't support posix acl. Without this patch
guest won't get EOPNOTSUPP error on setxattr("system.posix_acl_access")
Signed-off-by: Aneesh Kuma
From: Kuo-Jung Su
Replace PORTSC macros with variables which could then be
configured in ehci__class_init(...) to support some
non-standard EHCI controllers.
Signed-off-by: Kuo-Jung Su
Cc: Gerd Hoffmann
Cc: Andreas
Cc: Peter Crosthwaite
---
Changes for V2:
- add missing port init to
2013/2/1 Andreas Färber :
> 嗨 國榮,
>
> Am 01.02.2013 09:57, schrieb Kuo-Jung Su:
>> Thanks for the information, and sorry for the mess I've done.
>
> You don't need to apologize for every review comment you get. It's
> meant for improvements of results, not personal. :)
>
Thanks. It's so kind of yo
OK, will fix.
Thanks!
在 2013-02-04一的 18:20 +，Blue Swirl写道：
> On Mon, Feb 4, 2013 at 2:27 AM, liguang wrote:
> > Signed-off-by: liguang
> > ---
> > hw/pc.c | 14 +++---
> > 1 files changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/hw/pc.c b/hw/pc.c
> > index 01d00f6..0
On 02/04/13 18:27, Luiz Capitulino wrote:
> On Fri, 1 Feb 2013 18:38:15 +0100
> Laszlo Ersek wrote:
>
>>
>> Signed-off-by: Laszlo Ersek
>
> I usually split this kind of patch the following way:
>
> 1. add an Error ** argument to the function reporting the error. Callers
> are changed to
The build is broken on ppc64-linux, possibly only with new binutils:
ld: hw/lm32/../milkymist-tmu2.o: undefined reference to symbol 'XFree'
ld: note: 'XFree' is defined in DSO /lib64/libX11.so.6 so try \
adding it to the linker command line
So let's follow the linker's advice.
Signed-off-by: R
The misnamed HOST_LONG_BITS is really HOST_POINTER_BITS. Here we're
explicitly using an unsigned long, rather than uintptr_t, so it is
more correct to select the swap size via ULONG_MAX.
Acked-by: Andreas Färber
Signed-off-by: Richard Henderson
---
include/qemu/bswap.h | 12 ++--
1 fil
On 02/04/13 19:01, Luiz Capitulino wrote:
> On Fri, 1 Feb 2013 18:38:12 +0100
> Laszlo Ersek wrote:
>
>> This series is the first in converting do_device_add() to qapi.
>
> I've reviewed this, although it doesn't apply on master anymore and
> then I was unable to try it.
Thanks for the review,
On 2013-02-04 16:07, Peter Maydell wrote:
On 4 February 2013 23:52, Richard Henderson wrote:
On 2013-02-04 15:30, David Gibson wrote:
Anthony, Richard, anyone?
Please apply - qemu has now been build-broken on all big endian
platforms for a month.
I know. See also my bswap.h patch which al
On 4 February 2013 23:52, Richard Henderson wrote:
> On 2013-02-04 15:30, David Gibson wrote:
>> Anthony, Richard, anyone?
>>
>> Please apply - qemu has now been build-broken on all big endian
>> platforms for a month.
>
>
> I know. See also my bswap.h patch which also fixes the width
> of long v
On 02/04/13 17:38, Luiz Capitulino wrote:
> On Fri, 1 Feb 2013 18:38:14 +0100
> Laszlo Ersek wrote:
>
>>
>> Signed-off-by: Laszlo Ersek
>> ---
>> hw/qdev-monitor.c |7 +--
>> 1 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>> in
On 2013-02-04 15:30, David Gibson wrote:
Anthony, Richard, anyone?
Please apply - qemu has now been build-broken on all big endian
platforms for a month.
I know. See also my bswap.h patch which also fixes the width
of long vs uintptr_t. No one seems willing to pick these up...
r~
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Anthony, Richard, anyone?
Please apply - qemu has now been build-broken on all big endian
platforms for a month.
On Tue, Jan 22, 2013 at 04:33:26PM +1100, David Gibson wrote:
> Commit c732a52d3e3b7ed42d7daa94ba40a83408cd6f22 from Richard Henderson
> changed leul_to_cpu() in bswap.h from a macro t
Applied. Thanks.
Regards,
Anthony Liguori
On Mon, Feb 4, 2013 at 4:40 AM, Michael Tokarev wrote:
> Hello.
>
> This is my attempt at releasing a next stable/bugfix release of
> abandomed 1.1 series of qemu. I tried my best to colledt all
> fixes, and the last 1.1 has been out for quite a while now, so
> it think it is time to release 1.1.
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
On 02/04/2013 05:06 PM, Corey Bryant wrote:
On 02/04/2013 01:48 PM, Stefan Berger wrote:
On 02/04/2013 11:02 AM, Corey Bryant wrote:
+/*
+ * As of Linux 3.7 the tpm_tis driver does not properly cancel
+ * commands for all TPMs.
Any idea what the plan is for this issue? Is it a
On 4 February 2013 17:30, Paolo Bonzini wrote:
> Some devices or headers are using poisoned identifiers.
> For .c files, some are useless and we remove them.
>
> For headers, wrap the definitions in the headers with
>
Truncated sentence?
> Signed-off-by: Paolo Bonzini
> --- a/hw/pci/host-apb.c
On 02/04/2013 01:48 PM, Stefan Berger wrote:
On 02/04/2013 11:02 AM, Corey Bryant wrote:
@@ -221,7 +243,24 @@ static void
tpm_passthrough_deliver_request(TPMBackend *tb)
static void tpm_passthrough_cancel_cmd(TPMBackend *tb)
{
-/* cancelling an ongoing command is known not to work wi
On Fri, Feb 01, 2013 at 10:51:31PM +0100, Stefan Weil wrote:
> * Always read the footer at the end of the image.
> The footer exists for all kinds of VHD images, so there is no need
> to read its copy at the start of dynamic VHD images.
>
> * Return error codes from bdrv_pread like in other bl
Am 04.02.2013 22:23, schrieb Anthony Liguori:
> As best I can tell, this is a false positive.
>
> [aliguori@ccnode4 qemu-s390]$ make
> CCs390x-softmmu/target-s390x/helper.o
> /home/aliguori/git/qemu/target-s390x/helper.c: In function ‘do_interrupt’:
> /home/aliguori/git/qemu/target-s3
On 02/04/2013 02:07 PM, Peter Maydell wrote:
> On 4 February 2013 18:38, Eric Blake wrote:
>> On 02/02/2013 04:04 PM, dill...@dillona.com wrote:
>>> -
>>> -grouplist = alloca(gidsetsize * sizeof(gid_t));
>>> -target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize *
>>>
As best I can tell, this is a false positive.
[aliguori@ccnode4 qemu-s390]$ make
CCs390x-softmmu/target-s390x/helper.o
/home/aliguori/git/qemu/target-s390x/helper.c: In function ‘do_interrupt’:
/home/aliguori/git/qemu/target-s390x/helper.c:673:17: error: ‘addr’ may be
used uninitial
On 4 February 2013 20:51, Paolo Bonzini wrote:
> Il 04/02/2013 21:33, Peter Maydell ha scritto:
>>> The $FOO device models should all be in hw/$FOO. But there are some
>>> parts that do not fit in a category
>>
>> Surely this is what hw/misc is for?
>
> It's mostly interrupt/GPIO/DMA/memory/cache
On 4 February 2013 18:38, Eric Blake wrote:
> On 02/02/2013 04:04 PM, dill...@dillona.com wrote:
>> -
>> -grouplist = alloca(gidsetsize * sizeof(gid_t));
>> -target_grouplist = lock_user(VERIFY_READ, arg2, gidsetsize * 2,
>> 1);
>> -if (!target_grouplist) {
>>
Le lundi 04 février 2013 à 15:16 +, Peter Maydell a écrit :
> On 31 January 2013 19:50, Laurent Vivier wrote:
> > The parameter "union semun" of semctl() is not a value
> > but a pointer to the value.
>
> Hi. For your next patch could you make sure you send it as
> a fresh email rather than a
Il 04/02/2013 21:33, Peter Maydell ha scritto:
> On 4 February 2013 18:59, Paolo Bonzini wrote:
>> Il 04/02/2013 19:13, Peter Maydell ha scritto:
>>> I think this is inconsistent. Either we should organise by category,
>>> or we should organise per-target, but we shouldn't try to do both.
>>> Othe
Peter Maydell writes:
> On 2 February 2013 18:26, Blue Swirl wrote:
>> On Sat, Feb 2, 2013 at 5:44 PM, Peter Maydell
>> wrote:
>>> On 2 February 2013 17:37, Andreas Färber wrote:
Am 02.02.2013 17:49, schrieb Peter Maydell:
libqtest.h has no generic endian-aware memread functions unl
On 4 February 2013 18:59, Paolo Bonzini wrote:
> Il 04/02/2013 19:13, Peter Maydell ha scritto:
>> I think this is inconsistent. Either we should organise by category,
>> or we should organise per-target, but we shouldn't try to do both.
>> Otherwise we're just going to wind up with half the $TARG
Hi Paolo,
On Thu, 2013-01-31 at 00:12 -0800, Nicholas A. Bellinger wrote:
> Hi Paolo,
>
> On Wed, 2013-01-30 at 17:41 +0100, Paolo Bonzini wrote:
> > As expected, using a separate device finds a snag: vhost-scsi is passing
> > force=false to vhost_dev_init, and the BIOS does not use MSI-X so i
On Mon, 4 Feb 2013 17:05:01 +0100
Igor Mammedov wrote:
> On Mon, 04 Feb 2013 13:52:32 +0100
> Andreas Färber wrote:
>
> > Am 04.02.2013 12:08, schrieb Igor Mammedov:
> > > On Sat, 2 Feb 2013 01:37:07 +0100
> > > Andreas Färber wrote:
> > >
[...]
>
> > >> @@ -2198,6 +2018,8 @@ static void x8
Ping: http://patchwork.ozlabs.org/patch/211162/.
On 01/10/2013 04:50 PM, Meador Inge wrote:
> GCC and GAS are capable of generating traps or breaks to check for
> division by zero. Additionally, GAS is capable of generating traps
> or breaks to check for overflow on certain division and multiplic
Amos Kong reported that file descriptors numbered higher
than 1024 could crash QEMU. This is due to the fixed size of the fd_set type
used for select(2) event polling.
This series converts the main-loop.c and aio-posix.c select(2) calls to
g_poll(3). This eliminates the fd_set type and allows Q
From: David Gibson
madvise(DONTNEED) will throw away the contents of the whole page at the
given address, even if the given length is less than the page size. One
can argue about whether that's the correct behaviour, but that's what it's
done for a long time in Linux at least.
That means that t
From: Jan Kiszka
We need to evaluate $libexecdir in configure, otherwise we literally end
up with "${prefix}/libexec" instead of the absolute path as
CONFIG_QEMU_HELPERDIR.
Signed-off-by: Jan Kiszka
Signed-off-by: Aurelien Jarno
(cherry picked from commit 38f419f35225decdbaea9fe1fd00218f8924ce
On Mon, 04 Feb 2013 19:23:15 +0100
Laszlo Ersek wrote:
> On 02/04/13 18:51, Luiz Capitulino wrote:
> > On Fri, 1 Feb 2013 18:38:18 +0100
> > Laszlo Ersek wrote:
> >
> >>
> >> Signed-off-by: Laszlo Ersek
> >
> > Splitting this as I suggested in the other patch would make review
> > easier. I
From: Stefan Weil
Those functions return -errno in case of an error.
The old code would typically only detect EPERM (1) errors.
Signed-off-by: Stefan Weil
Signed-off-by: Stefan Hajnoczi
(cherry picked from commit 7a608f562ebd91e811ed0b725e528c894e4f19c4)
Signed-off-by: Michael Tokarev
---
h
Signed-off-by: Stefan Hajnoczi
---
main-loop.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/main-loop.c b/main-loop.c
index 6f52ac3..d0d8fe4 100644
--- a/main-loop.c
+++ b/main-loop.c
@@ -330,7 +330,8 @@ void qemu_fd_register(int fd)
static int os_host_main_loop_wait(uin
qdev-monitor.c is the only "core qdev" file that is not used in
user-mode emulation, and it does not define anything that is used
by hardware models. Remove it from the hw/ directory and
remove hw/qdev-monitor.h from hw/qdev.h too; this requires
some files to have some new explicitly includes.
Si
SYS_CFG_DVIMODE allows the guest to select whether the
output DVI signal is VGA, SVGA, XGA, SGA or UXGA. Since
this makes no difference to QEMU, implement writes as a
no-op so Linux doesn't complain.
Signed-off-by: Peter Maydell
---
hw/arm_sysctl.c |8
1 file changed, 8 insertions(+
This should catch many kinds of errors that the current code wasn't
checking for:
- Values that can't be parsed as a number
- Negative values
- Overflow
- Empty string
Signed-off-by: Eduardo Habkost
Reviewed-by: Eric Blake
---
vl.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
Resending whole series after v6 was reviewed and got no objections.
Changes v6 -> v7:
- Refresh of patch 1/8 against qemu.git master (trivial conflicts on
tests/Makefile)
- Correction of typo on comment on util/cutils.c
Eduardo Habkost (8):
cutils: unsigned int parsing functions
vl.c: F
- Accept empty strings without aborting
- Use parse_uint*() to parse numbers
- Abort if anything except '-' or end-of-string is found after the first
number.
- Check for endvalue < value
Also change the MAX_CPUMASK_BITS warning message from "A max of %d CPUs
are supported in a guest" to "qemu: N
Some devices or headers are using poisoned identifiers.
For .c files, some are useless and we remove them.
For headers, wrap the definitions in the headers with
Signed-off-by: Paolo Bonzini
---
hw/char/etraxfs_ser.c|2 --
hw/char/sclpconsole.c|2 +-
hw/display/exynos4210
The virtio-serial-bus already has the logic to make flow control work
properly. Hook into the char layer's new ability to signal a backend is
writable again.
Signed-off-by: Amit Shah
---
hw/virtio-console.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/virtio-console.c b
From: David Gibson
cpu_physical_memory_write_rom(), despite the name, can also be used to
write images into RAM - and will often be used that way if the machine
uses load_image_targphys() into RAM addresses.
However, cpu_physical_memory_write_rom(), unlike cpu_physical_memory_rw()
doesn't invali
The slirp glue code uses tabs in some places. Since the next patch will
modify the file, convert tabs to spaces and fix checkpatch.pl issues.
Signed-off-by: Stefan Hajnoczi
---
slirp/slirp.c | 608 ++
1 file changed, 311 insertions(+), 297
ld*_raw and st*_raw is not available in common-obj-y, but it is also
useless in softmmu targets: what it does is this
#define laddr(x) (uint8_t *)(intptr_t)(x)
#define ldub_raw(p) ldub_p(laddr((p)))
#define ldsb_raw(p) ldsb_p(laddr((p)))
#define lduw_raw(p) lduw_p(laddr((p)))
On Mon, Feb 4, 2013 at 5:19 PM, Markus Armbruster wrote:
> Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and
> stress test at
> http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt
There's no license. Can we use that?
>
> Unfortunately, both JSON parser and formatter m
Il 04/02/2013 19:13, Peter Maydell ha scritto:
>> > This reorganizes the over 600 files in the hw/ directory to multiple
>> > subdirectories: acpi/, audio/, block/, bt/, char/, display/, i2c/, input/,
>> > isa/, misc/, net/, scsi/, sd/, ssi/, timer/, virtio/, watchdog/, xen/.
>> > These are in addi
Signed-off-by: Amit Shah
---
qemu-char.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index 7fa9372..01b0190 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2484,6 +2484,12 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char
*buf, size_t len)
}
#end
Am 04.02.2013 18:29, schrieb Paolo Bonzini:
> Other devices are now moved out of hw/ARCH, adding new CONFIG_*
> symbols that let them be included selectively in the emulators.
> The devices however are still compiled in target-specific
> directories.
>
> Signed-off-by: Paolo Bonzini
I don't thin
On 02/04/2013 11:02 AM, Corey Bryant wrote:
@@ -221,7 +243,24 @@ static void
tpm_passthrough_deliver_request(TPMBackend *tb)
static void tpm_passthrough_cancel_cmd(TPMBackend *tb)
{
-/* cancelling an ongoing command is known not to work with some
TPMs */
+TPMPassthruState *tpm_pt
Signed-off-by: Paolo Bonzini
---
hw/virtio-pci.h |2 +-
hw/virtio.h |4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h
index d24957c..e775525 100644
--- a/hw/virtio-pci.h
+++ b/hw/virtio-pci.h
@@ -75,7 +75,7 @@ struct VirtIOPCIPro
Am 04.02.2013 18:30, schrieb Paolo Bonzini:
> Some devices or headers are using poisoned identifiers.
> For .c files, some are useless and we remove them.
>
> For headers, wrap the definitions in the headers with
#if at start of line gets dropped by git. ;)
>
> Signed-off-by: Paolo Bonzini
> -
On 4 February 2013 18:26, Richard Henderson wrote:
> /**
> - * bitops_fls - find last (most-significant) set bit in a long word
> + * bitops_clzl - find last (most-significant) set bit in a long word
Should probably change the descriptive text to say "count leading
zeros"...
> * @word: the wo
On 2013-02-04 10:34, Peter Maydell wrote:
- }
+/* Both this function and the gcc builtin are undefined at 0, whereas
+ the host-utils functions return word-size at 0. Thus we prefer the
+ gcc builtin as the closer match. */
I think we should just fix the inconsistency ra
On 02/02/2013 04:04 PM, dill...@dillona.com wrote:
> From: Dillon Amburgey
>
> Signed-off-by: Dillon Amburgey
> ---
> linux-user/syscall.c | 22 --
> 1 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index a1
Convert iohandler_select_fill() and iohandler_select_poll() to use
GPollFD instead of rfds/wfds/xfds.
Signed-off-by: Stefan Hajnoczi
---
include/qemu/main-loop.h | 4 ++--
iohandler.c | 40 ++--
main-loop.c | 4 ++--
3 files changed
On Sun, 2013-02-03 at 14:10 +, Pandarathil, Vijaymohan R wrote:
> - Added vfio_device_get_from_dev() as wrapper to get
> reference to vfio_device from struct device.
>
> - Added vfio_device_data() as a wrapper to get device_data from
> vfio_device.
>
> Signed-o
On 02/04/13 19:27, Eduardo Habkost wrote:
> Changes on v7 are trivial:
> - Patch refresh after changes on test/Makefile on qemu.git master
> - Fix typo on comment on parse_uint() (missing whitespace)
>
> As the changes are really trivial, I am keeping the Reviewed-by lines
> from Eric and Laszl
On 02/04/2013 11:26 AM, Richard Henderson wrote:
> Similar to the bitops_ctz change just made.
>
> Signed-off-by: Richard Henderson
> ---
> include/qemu/bitops.h | 44 +++-
> target-i386/topology.h | 2 +-
> util/bitops.c | 2 +-
> 3 files chan
On Mon, Feb 4, 2013 at 7:41 AM, Michael S. Tsirkin wrote:
> mq flag is not needed: we can look at the number of queues and set
> the flag accordingly.
> Removing this feature removes ambiguity (what does it mean to have
> queues=2 with mq=off?), and simplifies compatibility hacks.
> work-around fo
On Mon, Feb 4, 2013 at 12:50 PM, Amit Shah wrote:
> The virtio-serial-bus already has the logic to make flow control work
> properly. Hook into the char layer's new ability to signal a backend is
> writable again.
>
> Signed-off-by: Amit Shah
> ---
> hw/virtio-console.c | 13 +
> 1
Most devices moved to hw/ subdirectories (other than hw/ARCH) can now be
compiled once only.
A notable exception is that many framebuffer devices have assumptions on
the target endianness. I have no idea what would happen with OMAP in
armeb mode, for example, so I'm leaving them aside.
The ARM m
Also move the 9p.h file to 9pfs/virtio-9p-device.h, for consistency
with the corresponding .c file.
Signed-off-by: Paolo Bonzini
---
hw/9pfs/virtio-9p-device.c | 53 +-
hw/{9p.h => 9pfs/virtio-9p-device.h} |4 +-
hw/9pfs/virtio-9p.c
Similar to the bitops_ctz change just made.
Signed-off-by: Richard Henderson
---
include/qemu/bitops.h | 44 +++-
target-i386/topology.h | 2 +-
util/bitops.c | 2 +-
3 files changed, 17 insertions(+), 31 deletions(-)
diff --git a/include/qemu
On Mon, Feb 4, 2013 at 2:27 AM, liguang wrote:
> it's not necessary to alloc 8K bytes for kernel
> header, 0.5K is enough.
>
> Signed-off-by: liguang
> ---
> hw/pc.c | 10 ++
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index 0ccd775..b6b236f
Instead of checking the limit before calling numa_add(), check the limit
only when we already know we're going to add a new node.
Signed-off-by: Eduardo Habkost
Reviewed-by: Eric Blake
---
vl.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/vl.c b/vl.c
index 586a
There are lots of duplicate parsing code using strto*() in QEMU, and
most of that code is broken in one way or another. Even the visitors
code have duplicate integer parsing code[1]. This introduces functions
to help parsing unsigned int values: parse_uint() and parse_uint_full().
Parsing function
Abort in case an invalid -numa option is provided, instead of silently
ignoring it.
Signed-off-by: Eduardo Habkost
Reviewed-by: Eric Blake
---
vl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vl.c b/vl.c
index 0dae44c..586aa9a 100644
--- a/vl.c
+++ b/vl.c
@@ -1293,6 +1293,9 @@ static
This will make it easier to refactor that code later.
Signed-off-by: Eduardo Habkost
Reviewed-by: Eric Blake
---
vl.c | 41 +++--
1 file changed, 23 insertions(+), 18 deletions(-)
diff --git a/vl.c b/vl.c
index d6f6422..de164f8 100644
--- a/vl.c
+++ b/vl.c
@
The numa_add() code was unconditionally adding 1 to the get_opt_name()
return value, making it point after the end of the string if no ','
separator is present.
Example of weird behavior caused by the bug:
$ qemu-img create -f qcow2
this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2 5G
Fo
Without this check, QEMU will corrupt memory if a too-large nodeid is
provided in the command-line. e.g.:
-numa node,mem=...,cpus=...,nodeid=65
This changes nodenr to unsigned long long, to avoid integer conversion
issues when converting the strtoull() result to int.
Signed-off-by: Eduardo Hab
1 - 100 of 277 matches
Mail list logo
