1) When I compile seabios 1.7.2 locally I end up with a 128KB binary.
So do I on Fedora 18. Unless someone has a reason why this is a bad
thing, I'll commit a 128kb binary and we can avoid this problem for 1.4.
Seems to be a toolchain issue. Building on RHEL-6 (which I did for all
seabios
Markus Armbruster arm...@redhat.com writes:
Eric Blake ebl...@redhat.com writes:
On 02/05/2013 09:22 AM, Markus Armbruster wrote:
Command memchar-write takes data and size parameter. Begs the
question what happens when data doesn't match size.
With format base64, qmp_memchar_write()
Eric Blake ebl...@redhat.com writes:
On 02/05/2013 09:22 AM, Markus Armbruster wrote:
In particular, document the impact of our crappy UTF-8 handling on
reading.
Now the QMP examples even work.
Signed-off-by: Markus Armbruster arm...@redhat.com
---
hmp-commands.hx | 20
This series adds tracepoints about state transition of VM to get
information of live migration.
We suggest that QEMU trace data will be able to be captured by users
all the time for investigation on production server not for
development. However, tracepoints in current QEMU are not enough to
On Tue, Feb 05, 2013 at 02:04:42PM -0700, Eric Blake wrote:
On 02/05/2013 11:54 AM, Stefan Hajnoczi wrote:
The check_refcounts_l1/l2() functions have a check_copied argument to
check that the QCOW_O_COPIED flag is consistent with refcount == 1.
This should be a bool, not an int.
On Tue, Feb 05, 2013 at 02:36:08PM -0700, Eric Blake wrote:
On 02/05/2013 11:54 AM, Stefan Hajnoczi wrote:
@@ -963,6 +965,17 @@ static int check_refcounts_l2(BlockDriverState *bs,
BdrvCheckResult *res,
l2_entry = s-cluster_offset_mask;
inc_refcounts(bs, res,
From: Kuo-Jung Su dant...@faraday-tech.com
These patches introduce Faraday A36x SoC platform support.
Faraday provides ARMv4/ARMv5TE compatible solutions,
and focus on ASIC design service.
Here are some public documents for your reference.
From: Kuo-Jung Su dant...@faraday-tech.com
The Faraday A369 EVB is a Faraday SoC platform evalution board used for
Faraday IP functional verification based on the well-known ARM AMBA 2.0
architecture.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
From: Kuo-Jung Su dant...@faraday-tech.com
The FTWDT010 is used to prevent system from infinite loop
while software gets trapped in the deadlock.
Under the normal operation, users should restart FTWDT010
at the regular intervals before counter counts down to 0.
If the counter does reach 0,
From: Kuo-Jung Su dant...@faraday-tech.com
The FTNANDC021 is an integrated NAND flash controller which
re-pack the NAND flash command set with a shorter built-in opcode.
It also provides a register base interface for user to easily
access the underlying NAND flash chips, and also supports HW ECC.
On Tue, 5 Feb 2013 19:20:04 -0200
Eduardo Habkost ehabk...@redhat.com wrote:
On Tue, Feb 05, 2013 at 08:47:29PM +0100, Igor Mammedov wrote:
On Tue, 5 Feb 2013 17:04:26 -0200
Eduardo Habkost ehabk...@redhat.com wrote:
On Tue, Feb 05, 2013 at 07:46:09PM +0100, Igor Mammedov wrote:
On
From: Kuo-Jung Su dant...@faraday-tech.com
The Faraday A360 EVB is a Faraday SoC platform evaluation board used for
Faraday IP functional verification based on the well-known ARM AMBA 2.0
architecture.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
From: Kuo-Jung Su dant...@faraday-tech.com
The FTSSP010 is a multi-function synchronous serial port interface
controller which supports SSP, SPI, I2S, AC97 and SPDIF.
However only I2S and SPI protocol have been implemented in this patch.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
From: Kuo-Jung Su dant...@faraday-tech.com
The FTINTC020 interrupt controller supports both FIQ and IRQ signals
to the microprocessor.
It can handle up to 64 configurable IRQ sources and 64 FIQ sources.
The output signals to the microprocessor can be configured as
level-high/low active or
From: Kuo-Jung Su dant...@faraday-tech.com
The FTLCDC200 Color LCD controller performs translation of
pixel-coded data into the required formats and timings to
drive a variety of single/dual mono and color LCDs.
Depending on the LCD type and mode, the unpacked data can represent:
1. an actual
From: Kuo-Jung Su dant...@faraday-tech.com
The FTGMAC100 Ethernet controller has a DMA engine which handles
all data transfers between the system memory and on-chip memories.
Its DMA engine supports both 16-bits and 32-bits alignment,
and thus make it possible to support zero-copy transfer at
From: Kuo-Jung Su dant...@faraday-tech.com
It provides separate second, minute, hour, and day counters. The second
counter is toggled each second, the minute counter is toggled each minute,
the hour counter is toggled each hour, and the day counter is toggled each day.
The FTRTC011 provides a
From: Kuo-Jung Su dant...@faraday-tech.com
The FTTSC010 provides two operation modes to sample
the analog input voltage.
1. The manual operation mode needs to program
and control the panel drivers by software
step-by-step for the x-y position measurement.
2. The auto-scan mode
From: Kuo-Jung Su dant...@faraday-tech.com
The FTI2C010 is an I2C master controller.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
hw/arm/faraday_a360.c |6 ++
hw/arm/faraday_a369.c |6 ++
hw/arm/fti2c010.c | 206
On Tue, Feb 05, 2013 at 03:27:10PM -0700, Eric Blake wrote:
On 02/05/2013 11:54 AM, Stefan Hajnoczi wrote:
Show how many clusters are compressed. This can be used to monitor how
many compressed clusters remain and whether to recompress the image.
Suggested-by: Cole Robinson
From: Kuo-Jung Su dant...@faraday-tech.com
It's used to perform AHB remap and also QEMU RAM initialization
when SDRAM is initialized before AHB remap process activated.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
hw/arm/faraday_a369.c |6 ++
From: Kuo-Jung Su dant...@faraday-tech.com
The FTDDRII030 is a DDRII SDRAM controller which is responsible for
SDRAM initialization.
In QEMU we simply emualte the SDRAM enable function, neither timing parameter
nor bank setup is handled.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
On Tue, 2013-02-05 at 13:58 +0200, Michael S. Tsirkin wrote:
On Tue, Feb 05, 2013 at 03:45:38PM +0400, Michael Tokarev wrote:
05.02.2013 15:31, Vadim Rozenfeld wrote:
On Mon, 2013-02-04 at 08:41 -0600, Anthony Liguori wrote:
Vadim Rozenfeld vroze...@redhat.com writes:
From: Kuo-Jung Su dant...@faraday-tech.com
The FTAPBBRG020 supports the DMA functions for the AHB-to-AHB,
AHB-to-APB, APB-to-AHB, and APB-to-APB transactions.
The DMA engine can support up to 4 DMA channels (A, B, C, and D)
and 15 handshaking channels. A DMA channel granted by the arbiter
block
Am 05.02.2013 16:12, schrieb Markus Armbruster:
Stefan Hajnoczi stefa...@redhat.com writes:
Linux block devices can be set read-only with blockdev --setro
device. The same thing can be done for LVM volumes using lvchange
--permission r volume. This read-only setting is independent of
On Wed, Feb 06, 2013 at 01:59:25AM +0100, Laszlo Ersek wrote:
comments in-line
On 02/04/13 13:12, Stefan Hajnoczi wrote:
@@ -475,15 +490,15 @@ void slirp_select_poll(fd_set *readfds, fd_set
*writefds, fd_set *xfds,
/*
* Check for URG data
From: Kuo-Jung Su dant...@faraday-tech.com
The FTTMR010 provides three independent sets of sub-timers.
Two match registers are provided for each sub-timer, whenever
the value of the match registers equals any one value of the
sub-timers, the timer interrupt will be immediately triggered.
And it
From: Kuo-Jung Su dant...@faraday-tech.com
The FTMAC110 is an Ethernet controller that provides AHB master capability
and is in full compliance with the IEEE 802.3 10/100 Mbps specifications.
Its DMA controller handles all data transfers between system memory
and on-chip memories.
It supports
This patch enables us to know RunState transition. We only added a
trace function in runstate_set().
Signed-off-by: Kazuya Saito saito.kaz...@jp.fujitsu.com
---
trace-events |1 +
vl.c |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/trace-events
From: Kuo-Jung Su dant...@faraday-tech.com
The FTPWMTMR010 is an APB device which provides up to 8 independent timers.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
hw/arm/faraday_a369.c | 11 +++
hw/arm/ftpwmtmr010.c | 246
From: Kuo-Jung Su dant...@faraday-tech.com
The Faraday FTDMAC020 provides eight configurable
channels for the memory-to-memory, memory-to-peripheral,
peripheral-to-peripheral, and peripheral-to-memory transfers.
Each DMA channel supports chain transfer and can be programmed
to one of the 16
From: Kuo-Jung Su dant...@faraday-tech.com
The FTSDC010 is a clone of Arm PrimeCell PL181.
While they share lots of design concept, the implementation
differ slightly.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
hw/arm/faraday_a360.c |7 +
Am 05.02.2013 17:39, schrieb Igor Mammedov:
From: Andreas Färber afaer...@suse.de
Consolidate CPU functions in cpu.c.
Allows to make cpu_x86_register() static.
No functional changes.
Signed-off-by: Andreas Färber afaer...@suse.de
Do we agree that this patch is okay? If you add a
This series adds fragmentation info support to qcow2 and then adds compression
info. Previously only QED supported fragmentation info. Note that
fragmentation info only covers the current image, internal snapshots are not
included.
The new BlockFragInfo.compressed field contains the number of
The check_refcounts_l1/l2() functions have a check_copied argument to
check that the QCOW_O_COPIED flag is consistent with refcount == 1.
This should be a bool, not an int.
However, the next patch introduces qcow2 fragmentation statistics and
also needs to pass an option to
The qemu-img check command can display fragmentation statistics:
* Total number of clusters in virtual disk
* Number of allocated clusters
* Number of fragmented clusters
This patch adds fragmentation statistics support to qcow2.
Compressed and normal clusters count as allocated. Zero
The qemu-img check printf() statement that shows BlockFragInfo results
is poorly formatted. Introduce a local variable to shorten the lines
and restore proper indentation.
The next patch adds a field to BlockFragInfo so it is beneficial to
straighten out this code before modifying it.
Show how many clusters are compressed. This can be used to monitor how
many compressed clusters remain and whether to recompress the image.
Suggested-by: Cole Robinson crobi...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
include/block/block.h| 1 +
qemu-img.c
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/qcow2-refcount.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 73690f8..aca7ea8 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -968,6 +968,7 @@ static int
On Tue, Feb 05, 2013 at 05:39:20PM +0100, Igor Mammedov wrote:
From: Andreas Färber afaer...@suse.de
Consolidate CPU functions in cpu.c.
Allows to make cpu_x86_register() static.
No functional changes.
Signed-off-by: Andreas Färber afaer...@suse.de
Reviewed-by: Eduardo Habkost
On 05.02.2013 15:28, Corey Bryant wrote:
On 02/05/2013 06:02 AM, Michal Privoznik wrote:
Currently, it we call a not white listed system call, we get killed
immediately without reporting any error. It would be far more useful,
if we can at least shout something on stderr just before dying,
Am 06.02.2013 12:07, schrieb Eduardo Habkost:
On Tue, Feb 05, 2013 at 05:39:20PM +0100, Igor Mammedov wrote:
From: Andreas Färber afaer...@suse.de
Consolidate CPU functions in cpu.c.
Allows to make cpu_x86_register() static.
No functional changes.
Signed-off-by: Andreas Färber
On Tue, Feb 05, 2013 at 09:28:51AM -0500, Corey Bryant wrote:
On 02/05/2013 06:02 AM, Michal Privoznik wrote:
Currently, it we call a not white listed system call, we get killed
immediately without reporting any error. It would be far more useful,
if we can at least shout something on stderr
Am 06.02.2013 11:58, schrieb Stefan Hajnoczi:
The qemu-img check printf() statement that shows BlockFragInfo results
is poorly formatted. Introduce a local variable to shorten the lines
and restore proper indentation.
The next patch adds a field to BlockFragInfo so it is beneficial to
On Wed, 06 Feb 2013 11:58:26 +0100
Andreas Färber afaer...@suse.de wrote:
Am 05.02.2013 17:39, schrieb Igor Mammedov:
From: Andreas Färber afaer...@suse.de
Consolidate CPU functions in cpu.c.
Allows to make cpu_x86_register() static.
No functional changes.
Signed-off-by:
Am 05.02.2013 19:54, schrieb Stefan Hajnoczi:
Show how many clusters are compressed. This can be used to monitor how
many compressed clusters remain and whether to recompress the image.
Suggested-by: Cole Robinson crobi...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
diff
From: Kuo-Jung Su dant...@faraday-tech.com
The FTSPI020 is an integrated SPI Flash controller
which supports upto 4 flash chips.
Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com
---
hw/arm/Makefile.objs |1 +
hw/arm/faraday_a369.c | 12 ++
hw/arm/ftspi020.c | 345
On Tue, 5 Feb 2013 20:44:23 +
Peter Maydell peter.mayd...@linaro.org wrote:
It's OK and expected for visitors to return errors when presented with
the fuzz test's random data. Since the fuzzer doesn't care about
errors, we pass in NULL rather than an Error**. This fixes a bug in
the
On Tue, 5 Feb 2013 09:30:55 +0100
Markus Armbruster arm...@redhat.com wrote:
Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and
stress test at
http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt
Unfortunately, both JSON parser and formatter misbehave right now.
This patchset create the core infrastructure for deduplication and enable it.
One can compile and install https://github.com/wernerd/Skein3Fish and use the
--enable-skein-dedup configure option in order to use the faster skein HASH.
Images must be created with -o dedup=[skein|sha256] in order to
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.h | 69 -
1 file changed, 68 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 718b52b..c7b6860 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@
---
qapi-schema.json | 18 ++
1 file changed, 18 insertions(+)
diff --git a/qapi-schema.json b/qapi-schema.json
index cdd8384..cf4e9d6 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -796,6 +796,24 @@
{ 'command': 'query-block', 'returns': ['BlockInfo'] }
##
+#
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.c | 43 +++
1 file changed, 43 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index ecbe352..7eeaeb9 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -53,9 +53,18 @@ typedef struct
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.c | 49 ++---
block/qcow2.h |4 ++--
2 files changed, 32 insertions(+), 21 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index e48f0b0..ad202fa 100644
--- a/block/qcow2.c
This is needed for next commit which handle the deduplication refcount overflow
case.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c|2 +-
block/qcow2-refcount.c | 20 +++-
block/qcow2.h |2 +-
3 files changed, 13 insertions(+), 11
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-refcount.c | 43 ++-
block/qcow2.h |5 +
2 files changed, 35 insertions(+), 13 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index
A new physical cluster with the same hash value will be used for further
occurrence of this hash.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c| 32
block/qcow2-refcount.c |3 +++
block/qcow2.h |4
3 files
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c | 97 +++
block/qcow2.h |2 ++
2 files changed, 99 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 9a44697..0679a68 100644
---
---
block/qcow2-dedup.c | 11 +++
block/qcow2.h | 18 ++
2 files changed, 29 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 308b4f6..72ce1d7 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -1311,3 +1311,14 @@ void
Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 06 Feb 2013 10:06:03 +0100
Markus Armbruster arm...@redhat.com wrote:
Markus Armbruster arm...@redhat.com writes:
Eric Blake ebl...@redhat.com writes:
On 02/05/2013 09:22 AM, Markus Armbruster wrote:
Command memchar-write takes
On Tue, 5 Feb 2013 17:22:04 +0100
Markus Armbruster arm...@redhat.com wrote:
Command memchar-write takes data and size parameter. Begs the
question what happens when data doesn't match size.
With format base64, qmp_memchar_write() copies the full data argument,
regardless of size
On Wed, 06 Feb 2013 14:11:10 +0100
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 06 Feb 2013 10:06:03 +0100
Markus Armbruster arm...@redhat.com wrote:
Markus Armbruster arm...@redhat.com writes:
Eric Blake ebl...@redhat.com
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c | 325 ++-
block/qcow2.h |5 +
2 files changed, 329 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 5901749..a424af8 100644
On 6 February 2013 09:06, Markus Armbruster arm...@redhat.com wrote:
As far as I can tell, it never fails, but silently ignores characters
outside the alphabet [A-Za-z0-9+/]
This bit at least is required behaviour: see RFC2045 section 6.8:
Any characters outside of the base64 alphabet are
This fix the sub cluster sized writes race conditions while waiting
for a more faster solution.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.c | 14 +-
block/qcow2.h |1 +
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.c
On 02/06/2013 04:30 AM, Kevin Wolf wrote:
-if (result.bfi.total_clusters != 0 result.bfi.allocated_clusters !=
0) {
-printf(% PRId64 /% PRId64 = %0.2f%% allocated, %0.2f%%
fragmented\n,
-result.bfi.allocated_clusters, result.bfi.total_clusters,
-
On 02/06/2013 03:58 AM, Stefan Hajnoczi wrote:
This series adds fragmentation info support to qcow2 and then adds compression
info. Previously only QED supported fragmentation info. Note that
fragmentation info only covers the current image, internal snapshots are not
included.
The new
Signed-off-by: Benoit Canet ben...@irqsave.net
---
docs/specs/qcow2.txt | 105 +-
1 file changed, 103 insertions(+), 2 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index 36a559d..8e52de1 100644
--- a/docs/specs/qcow2.txt
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.c | 188 +
block/qcow2.h |2 +
include/block/block_int.h |1 +
3 files changed, 178 insertions(+), 13 deletions(-)
diff --git a/block/qcow2.c
On 02/06/2013 04:43 AM, Kevin Wolf wrote:
Instead of getting a longer and longer output line for each new number
we add, maybe we could use the chance to introduce multiline output:
Total number of clusters: 1000
- allocated 427 (42.7%)
- fragmented 71
---
block/qcow2-dedup.c |1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index e96ab00..e159e77 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -991,6 +991,7 @@ void qcow2_dedup_refcount_zero_reached(BlockDriverState *bs,
/*
---
block/qcow2.h |3 ++-
include/block/block.h | 11 +++
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 18e2974..fc393d5 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -234,9 +234,10 @@ typedef struct BDRVQcowState {
---
block/qcow2-dedup.c |1 +
1 file changed, 1 insertion(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index e159e77..308b4f6 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -1024,6 +1024,7 @@ void
qcow2_dedup_refcount_half_max_reached(BlockDriverState *bs,
---
block/qcow2-dedup.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 868caec..708b62c 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -130,6 +130,7 @@ int
qcow2_dedup_read_missing_and_concatenate(BlockDriverState *bs,
---
block/qcow2-dedup.c | 180 +++
1 file changed, 180 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 0679a68..cd08594 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -34,6 +34,7 @@
#include skeinApi.h
On Tue, 5 Feb 2013 17:22:05 +0100
Markus Armbruster arm...@redhat.com wrote:
The data returned has a well-defined size, which makes the size
returned along with it redundant at best. Drop it.
It was me who asked Lei to add it and the reasons were: 1. qemu-ga
does it too, so it's good to be
---
block/qcow2-cluster.c |8 ++--
block/qcow2-dedup.c |7 +++
block/qcow2.h |3 +++
3 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index dbcb6d2..ef91216 100644
--- a/block/qcow2-cluster.c
+++
---
block/qcow2-dedup.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 31988b6..454a94f 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -524,6 +524,7 @@ static int
qcow2_count_next_non_dedupable_clusters(BlockDriverState
Am 06.02.2013 14:35, schrieb Eric Blake:
On 02/06/2013 04:30 AM, Kevin Wolf wrote:
-if (result.bfi.total_clusters != 0 result.bfi.allocated_clusters !=
0) {
-printf(% PRId64 /% PRId64 = %0.2f%% allocated, %0.2f%%
fragmented\n,
-result.bfi.allocated_clusters,
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-refcount.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index d7d9339..ee5de6b 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@
Am 06.02.2013 14:40, schrieb Eric Blake:
On 02/06/2013 04:43 AM, Kevin Wolf wrote:
Instead of getting a longer and longer output line for each new number
we add, maybe we could use the chance to introduce multiline output:
Total number of clusters: 1000
- allocated 427
---
block/qcow2.c |4
1 file changed, 4 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 514811a..0ee5f4b 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1864,6 +1864,10 @@ static int qcow2_get_info(BlockDriverState *bs,
BlockDriverInfo *bdi)
BDRVQcowState *s =
Luiz Capitulino lcapitul...@redhat.com writes:
On Tue, 5 Feb 2013 17:22:04 +0100
Markus Armbruster arm...@redhat.com wrote:
Command memchar-write takes data and size parameter. Begs the
question what happens when data doesn't match size.
With format base64, qmp_memchar_write() copies
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c| 26 ++
block/qcow2-refcount.c |3 +++
block/qcow2.h |2 ++
3 files changed, 31 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 4819eb3..1ed219d 100644
Peter Maydell peter.mayd...@linaro.org writes:
On 6 February 2013 09:06, Markus Armbruster arm...@redhat.com wrote:
As far as I can tell, it never fails, but silently ignores characters
outside the alphabet [A-Za-z0-9+/]
This bit at least is required behaviour: see RFC2045 section 6.8:
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c | 14 ++
block/qcow2.c |5 +
configure | 33 +
3 files changed, 52 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-refcount.c |4 ++--
block/qcow2.c |3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 337fb65..d173c18 100644
--- a/block/qcow2-refcount.c
+++
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c | 436 +++
block/qcow2.h |5 +
2 files changed, 441 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 4e99eb1..5901749 100644
---
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-cluster.c |8 ++--
block/qcow2.h |9 +
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index 56fccf9..63a7241 100644
--- a/block/qcow2-cluster.c
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-cluster.c | 11 +--
block/qcow2-dedup.c |8 +++-
block/qcow2.h |2 ++
3 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index ef91216..5b1d20d
---
block/qcow2.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index 9097e64..514811a 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -540,6 +540,13 @@ static int qcow2_open(BlockDriverState *bs, int flags)
}
}
+if
[Forgot to add Michael, re-sending]
On Tue, 5 Feb 2013 17:22:05 +0100
Markus Armbruster arm...@redhat.com wrote:
The data returned has a well-defined size, which makes the size
returned along with it redundant at best. Drop it.
It was me who asked Lei to add it and the reasons were: 1.
---
block/qcow2-dedup.c |7 +++
block/qcow2.c |6 +-
block/qcow2.h |1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 66fb415..165aae9 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@
On 02/06/2013 06:13 AM, Michal Privoznik wrote:
On 05.02.2013 15:28, Corey Bryant wrote:
On 02/05/2013 06:02 AM, Michal Privoznik wrote:
Currently, it we call a not white listed system call, we get killed
immediately without reporting any error. It would be far more useful,
if we can at
In the case of a race condition between two writes a l2 entry can be written
without QCOW_OFLAG_COPIED before the first write fill it.
This patch simply check if the l2 entry has the correct offset without
QCOW_OFLAG_COPIED and do nothing.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Signed-off-by: Fabien Chouteau chout...@adacore.com
---
block.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index ba67c0d..79fe01b 100644
--- a/block.c
+++ b/block.c
@@ -428,9 +428,16 @@ int get_tmp_filename(char *filename, int size)
---
block/qcow2-dedup.c | 126 +++
1 file changed, 126 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 72ce1d7..1ac 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -1166,6 +1166,130 @@ static int
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-dedup.c |6 ++
block/qcow2.h |1 +
2 files changed, 7 insertions(+)
diff --git a/block/qcow2-dedup.c b/block/qcow2-dedup.c
index 1ed219d..197d04d 100644
--- a/block/qcow2-dedup.c
+++ b/block/qcow2-dedup.c
@@ -999,3
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2-refcount.c |8
1 file changed, 8 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index f6a80db..d7d9339 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -1154,6 +1154,14 @@
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block/qcow2.c | 87 +++--
1 file changed, 85 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 9cbb2f0..f39b6d5 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@
1 - 100 of 249 matches
Mail list logo
