[Qemu-devel] [PATCH] arm/translate.c: Fix adc_CC/sbc_CC implementation

2013-02-25 Thread Peter Crosthwaite
commits 49b4c31efcce45ab714f286f14fa5d5173f9069d and 2de68a4900ef6eb67380b0c128abfe1976bc66e8 reworked the implementation of adc_CC and sub_CC. The new implementations (on the TCG_TARGET_HAS_add2_i32 code path) are incorrect. The new logic is: CF:NF = 0:A +/- 0:CF CF:NF = CF:A +/- 0:B The lower

Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test

2013-02-25 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 22.02.2013 18:20, schrieb Markus Armbruster: diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c new file mode 100644 index 000..60412ad --- /dev/null +++ b/tests/boot-order-test.c [...] +static void test_pc_with_args(const char

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Christian Borntraeger
On 25/02/13 08:55, Paolo Bonzini wrote: Another thing is, that qdev_free looks now different, some days ago it also did an unref. As far as I can see the object_unparent in virtio-ccw was always the wrong thing to do. object_unparent is almost idempotent, i.e. idempotent as long as it

[Qemu-devel] [PATCH] xilinx_axienet: pump events as appropriate

2013-02-25 Thread Peter Crosthwaite
When the conditions blocking receiving are cleared, check for buffered rx packets. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_axienet.c b/hw/xilinx_axienet.c index

Re: [Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Peter Lieven
On 18.02.2013 13:39, Peter Lieven wrote: On 15.02.2013 14:32, Stefan Hajnoczi wrote: On Fri, Feb 15, 2013 at 10:32:31AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of

Re: [Qemu-devel] [PATCHv2] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Christian Borntraeger
On 25/02/13 09:13, Peter Lieven wrote: Is IFF_ONE_QUEUE queryable with ioctl(fd, TUNGETFEATURES, features) ? Yes, that should work. The default tun/tap driver returns it, macvtap not.

Re: [Qemu-devel] [PATCH] boot-order-test: Add tests for PowerMacs

2013-02-25 Thread Markus Armbruster
This is on top of my [PATCH v2 0/8] -boot and -no-fd-bootchk fixes. Since I need to respin my series anyway, I can include your patch in the respin. Andreas Färber afaer...@suse.de writes: They set the boot device via fw_cfg, which is then translated to a boot path of hd or cd in OpenBIOS.

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Andreas Färber
Am 25.02.2013 08:55, schrieb Paolo Bonzini: Another thing is, that qdev_free looks now different, some days ago it also did an unref. As far as I can see the object_unparent in virtio-ccw was always the wrong thing to do. object_unparent is almost idempotent, i.e. idempotent as long as it

Re: [Qemu-devel] [RFC PATCH v2 0/4] kvm: Make ioeventfd usable on s390.

2013-02-25 Thread Cornelia Huck
On Sun, 24 Feb 2013 11:56:39 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 22, 2013 at 01:09:45PM +0100, Cornelia Huck wrote: Here's the second attempt at implementing ioeventfd for s390. The patchset looks fine overall. Minor comments and questions below. Cool, thanks for

Re: [Qemu-devel] [RFC PATCH v2 4/4] KVM: s390: Wire up ioeventfd.

2013-02-25 Thread Cornelia Huck
On Sun, 24 Feb 2013 11:45:22 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 22, 2013 at 01:09:49PM +0100, Cornelia Huck wrote: Enable ioeventfd support on s390 and hook up diagnose 500 virtio-ccw notifications. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-25 Thread Dietmar Maurer
So if I want to use the code from nbd.c, I need to write a specialized BlockDriver for the vma format (to pass that to nbd_export_new())? Yes. But I believe that would be a good thing to do anyway. For one thing, it gives you automatic coverage via qemu-iotests. But the only thing I

Re: [Qemu-devel] emulate powerpc(mpc8544ds) on x86 architecture

2013-02-25 Thread Shi Rong
thx, I get it :) 于 2013/02/21 9:12, Scott Wood 写道: On 02/20/2013 07:04:39 PM, Shi Rong wrote: 于 2013/02/21 2:30, Scott Wood 写道: On 02/20/2013 08:46:52 AM, Alexander Graf wrote: Also no need for enable-kvm, as you're running on x86. KVM only helps for compatible CPUs (ppc on ppc for example).

Re: [Qemu-devel] Block I/O optimizations

2013-02-25 Thread Abel Gordon
Stefan Hajnoczi stefa...@gmail.com wrote on 21/02/2013 10:11:12 AM: From: Stefan Hajnoczi stefa...@gmail.com To: Loic Dachary l...@dachary.org, Cc: qemu-devel qemu-devel@nongnu.org Date: 21/02/2013 10:11 AM Subject: Re: [Qemu-devel] Block I/O optimizations Sent by:

Re: [Qemu-devel] [PATCH 13/42] migration: add migrate_set_state tracepoint

2013-02-25 Thread Orit Wasserman
On 02/22/2013 06:36 PM, Paolo Bonzini wrote: From: Kazuya Saito saito.kaz...@jp.fujitsu.com Signed-off-by: Kazuya Saito saito.kaz...@jp.fujitsu.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- migration.c | 9 - trace-events | 3 +++ 2 files changed, 11 insertions(+), 1

Re: [Qemu-devel] [RFC PATCH v2 3/4] KVM: ioeventfd for s390 css devices.

2013-02-25 Thread Cornelia Huck
On Sun, 24 Feb 2013 11:47:50 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 22, 2013 at 01:09:48PM +0100, Cornelia Huck wrote: Enhance KVM_IOEVENTFD with a new flag that allows to attach to s390 css devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

Re: [Qemu-devel] [RFC PATCH v2 2/4] KVM: Introduce KVM_CSS_BUS.

2013-02-25 Thread Cornelia Huck
On Sun, 24 Feb 2013 11:57:25 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote: Add a new bus type for s390 css kvm io devices. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com --- include/linux/kvm_host.h | 1 + 1

[Qemu-devel] [PATCH v2 3/8] xilinx_axienet: Register reset properly

2013-02-25 Thread Peter Crosthwaite
Register the reset function and the Device::reset function rather than explicitly call it from the sysbus::init. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 4/8] xilinx_axienet: converted init-realize

2013-02-25 Thread Peter Crosthwaite
The prescribed transition from SysBusDevice::init to Device::realize. Im going with Andreas suggestion to move the sysbus foo to Object::init for early IRQ visibility. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c | 24 +++- 1 files

[Qemu-devel] [PATCH v2 5/8] petalogix_ml605_mmu: Fix machine node attachment

2013-02-25 Thread Peter Crosthwaite
Just attach devices straight to the root machine node, rather than the unattached node Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Suggested (indirectly) by Andreas if he wants to put his Suggested-by to it. hw/petalogix_ml605_mmu.c |4 ++-- 1 files changed, 2

[Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to machine

2013-02-25 Thread Peter Crosthwaite
Explicitily make the ethernet a child of the machine. This is needed to set and use links pre-realize. Also makes the ethernet initialization consistent with its peer DMA. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/petalogix_ml605_mmu.c |2 ++ 1 files changed, 2

[Qemu-devel] [PATCH v2 8/8] xilinx_axienet: stub out second stream connection

2013-02-25 Thread Peter Crosthwaite
Example patch adding a second proxy object for the second stream connection of axienet. This is a non-functional RFC, please see the cover letter for discussion. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- changed from v1: Rebased on series refactorings

[Qemu-devel] [PATCH v2 1/8] xilinx_axienet: typedef XilinxAXIEnet struct

2013-02-25 Thread Peter Crosthwaite
Typedef xilinx_axienets object state struct to shorten the repeated usages of struct XilinxAXIEnet. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c | 44 +++- 1 files changed, 23 insertions(+), 21 deletions(-) diff

[Qemu-devel] [PATCH 7/9] chardev: add stdio support to qapi

2013-02-25 Thread Gerd Hoffmann
This patch adds 'stdio' support to qapi and also switches over the stdio chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qapi-schema.json | 14 +- qemu-char.c | 26 -- 2 files changed, 33

[Qemu-devel] [PATCH 5/9] chardev: add braille support to qapi

2013-02-25 Thread Gerd Hoffmann
This patch adds 'braille' support to qapi and also switches over the braille chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/baum.c|2 +- hw/baum.h|2 +- qapi-schema.json |3 ++- qemu-char.c |7 ++-

[Qemu-devel] [PATCH 1/2] require gtk 2.20+

2013-02-25 Thread Gerd Hoffmann
The gtk code uses gtk_widget_get_realized which is available in 2.20+ only, so make this the minimum accepted versions. Fixes build failures on RHEL-6 (which ships 2.18) by not building gtk support there. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- configure |2 +- 1 file changed, 1

[Qemu-devel] [PATCH v2 7/8] xilinx_axienet: Create Proxy object for stream

2013-02-25 Thread Peter Crosthwaite
Create a separate child object to proxy the stream slave connection. This is setup for future work where a second stream slave connection is needed. The new child object is created at qdev init time and is linked back to the parent (the ethernet device itself) automatically. Stream slave masters

[Qemu-devel] [PATCHv3] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Peter Lieven
historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues overruns. setting IFF_ONE_QUEUE is the default in kernels = 3.8. the flag is ignored since then. see kernel commit

[Qemu-devel] [PATCH 2/9] chardev: add mux chardev support to qapi

2013-02-25 Thread Gerd Hoffmann
This adds mux chardev support to the qapi and also makes the qapi-based chardev creation path handle the mux=on option correctly. --- qapi-schema.json | 14 +- qemu-char.c | 35 --- 2 files changed, 45 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PATCH v2 2/8] xilinx_axienet: Defined and use type cast macro

2013-02-25 Thread Peter Crosthwaite
Standard QOM cast macro. Replaces usages of FROM_SYSBUS Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/xilinx_axienet.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/xilinx_axienet.c b/hw/xilinx_axienet.c index 4042e1a..7b50682

[Qemu-devel] [PATCH] qom/object.c: fix a typo in comment

2013-02-25 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index 3d638ff..a90b131 100644 --- a/qom/object.c +++ b/qom/object.c @@ -189,7 +189,7 @@ static bool type_is_ancestor(TypeImpl *type, TypeImpl

[Qemu-devel] [PATCH 8/9] chardev: switch serial/tty init to qapi

2013-02-25 Thread Gerd Hoffmann
This patch switches over the serial chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 0/9] chardev: qapi conversion continued

2013-02-25 Thread Gerd Hoffmann
Hi, This patch series starts to switch the chardev initialization to qapi, i.e. instead of passing the QemuOpts we'll get directly to a initialization function we'll create a ChardevBackend from the QemuOpts, then go create the chardev via qmp_chardev_add. Once finished all chardev

[Qemu-devel] [PATCH 3/9] chardev: switch null init to qapi

2013-02-25 Thread Gerd Hoffmann
This patch switches over the 'null' chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index fc908fa..ec49fb7 100644 ---

[Qemu-devel] [PATCH 4/9] chardev: add msmouse support to qapi

2013-02-25 Thread Gerd Hoffmann
This patch adds 'msmouse' support to qapi and also switches over the msmouse chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/msmouse.c |2 +- hw/msmouse.h |2 +- qapi-schema.json |3 ++- qemu-char.c |5 - 4

[Qemu-devel] [PATCH 2/2] unbreak hw/usb/redirect.c build

2013-02-25 Thread Gerd Hoffmann
Commit 8550a02d1239415342959f6a32d178bc05c557cc added a streams parameter to usb_wakeup and didn't update redirect.c. Fix it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/redirect.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/redirect.c

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-25 Thread Michael S. Tsirkin
On Sat, Feb 23, 2013 at 11:54:55PM +0200, Michael S. Tsirkin wrote: On Sat, Feb 23, 2013 at 10:49:29PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 22, 2013 at 11:33:53PM +0800, Jason Wang wrote: On 02/21/2013 07:23 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2013 at 05:57:04PM +0800,

[Qemu-devel] [PATCH v2 0/8] Stream - Multiple connections for the one device

2013-02-25 Thread Peter Crosthwaite
Hi all. The Xilinx AXIEnet and DMA devices have two AXI stream connections (control and data), only one of which is currently modelled (data). AXI stream is modelled using the stream QOM interface described in stream.h. Unfortunately, interfaces have no nice way of modelling multiple connections

[Qemu-devel] [PATCH 6/9] chardev: switch file init to qapi

2013-02-25 Thread Gerd Hoffmann
This patch switches over the 'file' chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 43 +++ 1 file changed, 15 insertions(+), 28 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 9/9] chardev: switch parallel init to qapi

2013-02-25 Thread Gerd Hoffmann
This patch switches over the parallel chardev initialization to the new qapi code path. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 37 + 1 file changed, 17 insertions(+), 20 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 1/9] chardev: add support for qapi-based chardev initialization

2013-02-25 Thread Gerd Hoffmann
This patch add support for a new way to initialize chardev devices. Instead of calling a initialization function with a QemuOpts we will now create a (qapi) ChardevBackend, optionally call a function to fill ChardevBackend from QemuOpts, then go create the chardev using the new qapi code path

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-25 Thread Michael S. Tsirkin
On Mon, Feb 25, 2013 at 02:11:44PM +0800, Jason Wang wrote: On 02/25/2013 01:57 PM, Jason Wang wrote: On 02/24/2013 05:54 AM, Michael S. Tsirkin wrote: On Sat, Feb 23, 2013 at 10:49:29PM +0200, Michael S. Tsirkin wrote: On Fri, Feb 22, 2013 at 11:33:53PM +0800, Jason Wang wrote: On

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-25 Thread Andreas Färber
Am 25.02.2013 08:49, schrieb Paolo Bonzini: +#include hw.h +#include i2c.h Please use hw/hw.h and hw/i2c.h since Paolo is planning to move I2C devices into hw/i2c/. No, I2C _masters_ move into hw/i2c. This would probably move into hw/nvram. OK, but my point of using hw/ is valid

Re: [Qemu-devel] [PATCHv3] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Michael S. Tsirkin
On Mon, Feb 25, 2013 at 10:17:08AM +0100, Peter Lieven wrote: historically the kernel queues packets two times. once at the device and second in qdisc. this is believed to cause interface stalls if one of these queues overruns. setting IFF_ONE_QUEUE is the default in kernels = 3.8. the flag

Re: [Qemu-devel] Moving BIOS tables from SeaBIOS to QEMU

2013-02-25 Thread Gleb Natapov
On Sun, Feb 24, 2013 at 01:00:28PM -0500, Kevin O'Connor wrote: On Sat, Feb 23, 2013 at 04:47:26PM +, David Woodhouse wrote: On Sat, 2013-02-23 at 11:38 -0500, Kevin O'Connor wrote: IMO, we need to move the ACPI table creation (and PIR/MPTABLE/SMBIOS) to QEMU and just have QEMU pass

Re: [Qemu-devel] [PATCHv3] tap: set IFF_ONE_QUEUE per default

2013-02-25 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 10:17:08AM +0100, Peter Lieven wrote: git-am(1) cannot apply this patch. There is whitespace damage, untouched lines have an extra space. I applied it manually, please use git-send-email(1) or fix your email client configuration for future patches. historically the

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Paolo Bonzini
Il 25/02/2013 09:09, Christian Borntraeger ha scritto: Hmm, the old sequence was object_unparent(OBJECT(dev)); qdev_free(dev) ---+ | V ... object_unparent(OBJECT(dev)); now the last reference is gone, object is freed

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-25 Thread Christian Borntraeger
On 25/02/13 11:44, Paolo Bonzini wrote: Il 25/02/2013 09:09, Christian Borntraeger ha scritto: Hmm, the old sequence was object_unparent(OBJECT(dev)); qdev_free(dev) ---+ | V ... object_unparent(OBJECT(dev)); now the last

Re: [Qemu-devel] [PATCHv4] iscsi: add iscsi_truncate support

2013-02-25 Thread Paolo Bonzini
Il 18/02/2013 14:50, Peter Lieven ha scritto: this patch adds iscsi_truncate which effectively allows for online resizing of iscsi volumes. for this to work you have to resize the volume on your storage and then call block_resize command in qemu which will issue a readcapacity16 to update the

Re: [Qemu-devel] [PATCHv2] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-02-25 Thread Paolo Bonzini
Il 21/02/2013 16:15, Peter Lieven ha scritto: the storage might return a check condition status for various reasons. (e.g. bus reset, capacity change, thin-provisioning info etc.) currently all these informative status responses lead to an I/O error which is populated to the guest. this

Re: [Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-25 Thread Alexander Graf
On 16.02.2013, at 12:59, Andreas Färber wrote: Am 15.02.2013 14:14, schrieb Alexander Graf: In parallel to the completely disastrous user experience when using trace points. Debug printfs are easy and understandable. Tracepoints are not. However, how about we take this one gradually?

Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix software reset

2013-02-25 Thread Alexander Graf
On 16.02.2013, at 16:08, Julio Guerra wrote: The software reset of a PReP machine should reset the entire system and not only the processor. It occurs when changing the 7th bit of port 0092 from 0 to 1. Adding a new variable in PReP's sysctrl_t to store the soft reset bit makes possible

Re: [Qemu-devel] [PATCH] pseries: Implements h_read hcall

2013-02-25 Thread Alexander Graf
On 18.02.2013, at 16:00, Erlon Cruz wrote: From: Erlon Cruz erlon.c...@br.flextronics.com This h_call is useful for DLPAR in future amongst other things. Given an index it fetches the corresponding PTE stored in the htab. Signed-off-by: Erlon Cruz erlon.c...@br.flextronics.com Thanks,

Re: [Qemu-devel] [PATCH v2 2/3] dtc: add submodule

2013-02-25 Thread Alexander Graf
On 19.02.2013, at 05:19, Peter Crosthwaite wrote: Add dtc submodule as a fallback for old distros. Picking version 1.3.0. as this is the most recently tagged stable version. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- .gitmodules |3 +++ dtc |1 + 2

[Qemu-devel] KVM call agenda for 2013-02-26

2013-02-25 Thread Juan Quintela
Hi Please send in any agenda topics you are interested in. Later, Juan.

[Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Peter Lieven
XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where a lot of collisions. Signed-off-by: Peter Lieven p...@kamp.de

Re: [Qemu-devel] [PATCH] Save memory allocation in the elf loader

2013-02-25 Thread Alexander Graf
On 19.02.2013, at 15:41, Fabien Chouteau wrote: The current elf loader uses too much memory. For example, I have a executable with a bss section of 400 MB and I set the ram size to 512 MB. Qemu uses about 780MB of RAM (which is fine), but there's a peak at 1.6 GB during initialization (this

[Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Lieven
The page cache frees all data on finish, on resize and if there is collision on insert. So it should be the caches responsibility to dup the data that is stored in the cache. Signed-off-by: Peter Lieven p...@kamp.de --- arch_init.c|3 +-- include/migration/page_cache.h |

Re: [Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Orit Wasserman
On 02/25/2013 01:42 PM, Peter Lieven wrote: XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where a lot of

Re: [Qemu-devel] [PATCH 00/38] Add double-word addition and widening multiply tcg ops

2013-02-25 Thread Alexander Graf
On 20.02.2013, at 08:51, Richard Henderson wrote: ... and use them where appropriate in the targets. As can be seen, most targets can make use of a widening multiply. And if one is sufficiently clever, one can use add2 to significantly improve carry generation for the target. This patch

Re: [Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 12:58 schrieb Orit Wasserman owass...@redhat.com: On 02/25/2013 01:42 PM, Peter Lieven wrote: XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory conditions during XBZRLE

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Maydell
On 25 February 2013 11:52, Peter Lieven p...@dlhnet.de wrote: The page cache frees all data on finish, on resize and if there is collision on insert. So it should be the caches responsibility to dup the data that is stored in the cache. diff --git a/page_cache.c b/page_cache.c index

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Orit Wasserman
Hi Peter, Now I get the previous patch, it should have been a patch series :). The reason we allocate from outside of the page cache is because of cache_resize that also uses cache_insert but doesn't duplicate the buffer. There is no memory leak because if the page is cached we don't call

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 13:15 schrieb Orit Wasserman owass...@redhat.com: Hi Peter, Now I get the previous patch, it should have been a patch series :). The reason we allocate from outside of the page cache is because of cache_resize that also uses cache_insert but doesn't duplicate the buffer.

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 13:13 schrieb Peter Maydell peter.mayd...@linaro.org: On 25 February 2013 11:52, Peter Lieven p...@dlhnet.de wrote: The page cache frees all data on finish, on resize and if there is collision on insert. So it should be the caches responsibility to dup the data that is

Re: [Qemu-devel] Moving BIOS tables from SeaBIOS to QEMU

2013-02-25 Thread Paolo Bonzini
Il 25/02/2013 09:51, Gleb Natapov ha scritto: Of these, the only thing I see that could be problematic is the PCI irq assignments (used in mptable) and the PCI region space (used in ACPI DSDT _SB.PCI.CRS). These are slightly problematic as they currently rely somewhat on the current

Re: [Qemu-devel] [0/3] Use ONE_REG interface to synchronize more state with KVM

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 03:41, David Gibson wrote: At the moment, there is a significant amount of state which both qemu and KVM track, which is not synchronized between the two. In a KVM setup, qemu never updates that information, so we mostly get away with it, but we'll need this data in qemu

Re: [Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Peter Maydell
On 25 February 2013 11:42, Peter Lieven p...@dlhnet.de wrote: XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where

Re: [Qemu-devel] [PATCH v2 2/3] dtc: add submodule

2013-02-25 Thread Gerd Hoffmann
Hi, diff --git a/dtc b/dtc new file mode 16 index 000..bc895d6 --- /dev/null +++ b/dtc I still don't think that we should have compat submodules in the top level directory. Don't think this is a big issue. We have only two now. If the number grows to 4-5 (which I don't

Re: [Qemu-devel] [Qemu-ppc] [PATCH] prep: Fix software reset

2013-02-25 Thread Andreas Färber
Am 25.02.2013 12:20, schrieb Alexander Graf: On 16.02.2013, at 16:08, Julio Guerra wrote: The software reset of a PReP machine should reset the entire system and not only the processor. It occurs when changing the 7th bit of port 0092 from 0 to 1. Adding a new variable in PReP's

Re: [Qemu-devel] [PATCH 3/3] target-ppc: Synchronize VPA state with KVM

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 03:41, David Gibson wrote: For PAPR guests, KVM tracks the various areas registered with the H_REGISTER_VPA hypercall. For full emulation, of course, these are tracked within qemu. At present these values are not synchronized. This is a problem for reset (qemu's reset of

Re: [Qemu-devel] [PATCH] page_cache: Fix memory leak

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 13:21 schrieb Peter Maydell peter.mayd...@linaro.org: On 25 February 2013 11:42, Peter Lieven p...@dlhnet.de wrote: XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed on a collision. This lead to out of memory

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Orit Wasserman
On 02/25/2013 02:17 PM, Peter Lieven wrote: Am 25.02.2013 um 13:15 schrieb Orit Wasserman owass...@redhat.com: Hi Peter, Now I get the previous patch, it should have been a patch series :). The reason we allocate from outside of the page cache is because of cache_resize that also uses

Re: [Qemu-devel] [PATCH v2 2/3] dtc: add submodule

2013-02-25 Thread Alexander Graf
On 25.02.2013, at 13:24, Gerd Hoffmann wrote: Hi, diff --git a/dtc b/dtc new file mode 16 index 000..bc895d6 --- /dev/null +++ b/dtc I still don't think that we should have compat submodules in the top level directory. Don't think this is a big issue. We have only two

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Maydell
On 25 February 2013 12:17, Peter Lieven p...@dlhnet.de wrote: Am 25.02.2013 um 13:13 schrieb Peter Maydell peter.mayd...@linaro.org: Doesn't this introduce a leak on cache resize in the case where the element being moved from the old cache to the new does not collide with any element we've

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 13:33 schrieb Orit Wasserman owass...@redhat.com: On 02/25/2013 02:17 PM, Peter Lieven wrote: Am 25.02.2013 um 13:15 schrieb Orit Wasserman owass...@redhat.com: Hi Peter, Now I get the previous patch, it should have been a patch series :). The reason we allocate from

Re: [Qemu-devel] [PATCH v2 4/8] xilinx_axienet: converted init-realize

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: The prescribed transition from SysBusDevice::init to Device::realize. Im going with Andreas suggestion to move the sysbus foo to Object::init for early IRQ visibility. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by:

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Orit Wasserman
On 02/25/2013 02:33 PM, Orit Wasserman wrote: On 02/25/2013 02:17 PM, Peter Lieven wrote: Am 25.02.2013 um 13:15 schrieb Orit Wasserman owass...@redhat.com: Hi Peter, Now I get the previous patch, it should have been a patch series :). The reason we allocate from outside of the page cache

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Orit Wasserman
On 02/25/2013 02:37 PM, Peter Lieven wrote: Am 25.02.2013 um 13:33 schrieb Orit Wasserman owass...@redhat.com: On 02/25/2013 02:17 PM, Peter Lieven wrote: Am 25.02.2013 um 13:15 schrieb Orit Wasserman owass...@redhat.com: Hi Peter, Now I get the previous patch, it should have been a

Re: [Qemu-devel] [PATCH v2 1/8] xilinx_axienet: typedef XilinxAXIEnet struct

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: Typedef xilinx_axienets object state struct to shorten the repeated usages of struct XilinxAXIEnet. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products

Re: [Qemu-devel] [PATCH v2 2/8] xilinx_axienet: Defined and use type cast macro

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: Standard QOM cast macro. Replaces usages of FROM_SYSBUS Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF:

[Qemu-devel] [PATCHv2] page_cache: fix memory leak

2013-02-25 Thread Peter Lieven
XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed in case of a collision in the page cache on cache_insert(). This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where a lot of collisions

Re: [Qemu-devel] [PATCH v2 3/8] xilinx_axienet: Register reset properly

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: Register the reset function and the Device::reset function rather than explicitly call it from the sysbus::init. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Andreas Färber afaer...@suse.de Seems like it might

Re: [Qemu-devel] [PATCH v2 5/8] petalogix_ml605_mmu: Fix machine node attachment

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: Just attach devices straight to the root machine node, rather than the unattached node Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Suggested (indirectly) by Andreas if he wants to put his Suggested-by to it. I don't

Re: [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 05:24, Andreas Färber wrote: There's an opcode handler field dependent on PPC_DUMP_CPU without which the build fails. Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate.c |1 + target-ppc/translate_init.c |1 - 2 Dateien geändert, 1

Re: [Qemu-devel] [PATCH v2 01/15] target-ppc: Fix PPC_DUMP_SPR_ACCESS build

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 05:24, Andreas Färber wrote: A victim of the d523dd00a7d73b28f2e99acf45a4b3f92e56e40a AREG0 conversion, insert the missing cpu_env arguments. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Andreas Färber afaer...@suse.de Thanks, applied to ppc-next. Alex ---

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Lieven
Am 25.02.2013 um 13:36 schrieb Peter Maydell peter.mayd...@linaro.org: On 25 February 2013 12:17, Peter Lieven p...@dlhnet.de wrote: Am 25.02.2013 um 13:13 schrieb Peter Maydell peter.mayd...@linaro.org: Doesn't this introduce a leak on cache resize in the case where the element being moved

Re: [Qemu-devel] [PATCH v2 6/8] petalogix_ml605_mmu: Attach ethernet to machine

2013-02-25 Thread Andreas Färber
Am 25.02.2013 09:50, schrieb Peter Crosthwaite: Explicitily make the ethernet a child of the machine. This is needed to set and use links pre-realize. Also makes the ethernet initialization consistent with its peer DMA. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com ---

Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 05:25, Andreas Färber wrote: Make debug output compile-testable even if disabled. Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with glibc. Inline DEBUG_OP check in excp_helper.c. Inline LOG_MMU_STATE() in mmu_helper.c. Inline

Re: [Qemu-devel] [PATCH v2 13/15] target-s390x: Refactor debug output macros

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 05:25, Andreas Färber wrote: Make debug output compile-testable even if disabled. Rename dprintf() in kvm.c to kvm_dprintf() due to a conflict with glibc. Drop unused DEBUG_HELPER and LOG_HELPER() in fpu_helper.c. Drop unused LOG_DISAS() in translate.c and inline

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-25 Thread Dietmar Maurer
unix sockets works with qemu nbd code? Sure. nbd+unix:///exportname?socket=path is the new URI syntax, I honestly forgot the old one. SCM_CREDENTIALS checks (qemu-nbd --pid or something like that) is not supported, but patches would be very welcome. Yes, this is better than my tcp

Re: [Qemu-devel] Block I/O optimizations

2013-02-25 Thread Stefan Hajnoczi
On Mon, Feb 25, 2013 at 10:48:47AM +0200, Abel Gordon wrote: Stefan Hajnoczi stefa...@gmail.com wrote on 21/02/2013 10:11:12 AM: From: Stefan Hajnoczi stefa...@gmail.com To: Loic Dachary l...@dachary.org, Cc: qemu-devel qemu-devel@nongnu.org Date: 21/02/2013 10:11 AM Subject: Re:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/2] Fix dma interrupt

2013-02-25 Thread Alexander Graf
On 21.02.2013, at 18:34, Amadeusz Sławiński wrote: In openbios (drivers/ide.c) they are set to 000d 0002 000e 0003 000f 0004 (The last one seems to be not implemented in qemu) It follows convention of how

Re: [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c

2013-02-25 Thread Andreas Färber
Am 25.02.2013 13:49, schrieb Alexander Graf: On 21.02.2013, at 05:24, Andreas Färber wrote: There's an opcode handler field dependent on PPC_DUMP_CPU without which the build fails. Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate.c |1 +

Re: [Qemu-devel] 'commit' error for 'all': No medium found

2013-02-25 Thread Jeff Cody
On Sun, Feb 24, 2013 at 07:29:31PM +0100, Jan Kiszka wrote: Hi, I'm seeing this with git head and 1.4. Apparently, commit on a non-populated medium now generates this error instead of ignoring it like in the past. As we stop iterating over the block devices while doing all, this may leaving

Re: [Qemu-devel] [PATCH v2 00/15] Debug output revamp

2013-02-25 Thread Alexander Graf
On 22.02.2013, at 18:41, Andreas Färber wrote: Am 22.02.2013 17:54, schrieb Richard Henderson: On 02/22/2013 08:16 AM, Andreas Färber wrote: I would be willing to do a macro-based v3 using do { ... } while (0) if maintainers can reach agreement on that and on how to do the if (0). FWIW,

Re: [Qemu-devel] [PATCH] page_cache: dup memory on insert

2013-02-25 Thread Peter Maydell
On 25 February 2013 12:50, Peter Lieven p...@dlhnet.de wrote: sth like this? diff --git a/page_cache.c b/page_cache.c index 376f1db..04205ee 100644 --- a/page_cache.c +++ b/page_cache.c @@ -196,21 +196,19 @@ int64_t cache_resize(PageCache *cache, int64_t new_num_pages) /*

Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros

2013-02-25 Thread Andreas Färber
Am 25.02.2013 13:54, schrieb Alexander Graf: On 21.02.2013, at 05:25, Andreas Färber wrote: Make debug output compile-testable even if disabled. Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with glibc. Inline DEBUG_OP check in excp_helper.c. Inline LOG_MMU_STATE() in

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-25 Thread Paolo Bonzini
Il 25/02/2013 13:59, Dietmar Maurer ha scritto: unix sockets works with qemu nbd code? Sure. nbd+unix:///exportname?socket=path is the new URI syntax, I honestly forgot the old one. SCM_CREDENTIALS checks (qemu-nbd --pid or something like that) is not supported, but patches would be very

Re: [Qemu-devel] Moving BIOS tables from SeaBIOS to QEMU

2013-02-25 Thread Laszlo Ersek
On 02/24/13 19:00, Kevin O'Connor wrote: On Sat, Feb 23, 2013 at 04:47:26PM +, David Woodhouse wrote: On Sat, 2013-02-23 at 11:38 -0500, Kevin O'Connor wrote: IMO, we need to move the ACPI table creation (and PIR/MPTABLE/SMBIOS) to QEMU and just have QEMU pass the tables to SeaBIOS for it

Re: [Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-25 Thread Stefan Hajnoczi
On Fri, Feb 22, 2013 at 10:03:50AM -, FredBezies wrote: Patch is ok, with this little warning when applied. Nothing really bad. patching file qemu-options.hx Hunk #1 succeeded at 2097 (offset 2 lines). git head is :

  1   2   3   4   >