Re: [Qemu-devel] [PATCH 0/2] Fix display resize bugs introduced after recent console revamp

2013-03-19 Thread Gerd Hoffmann
On 03/19/13 20:44, Igor Mitsyanko wrote: > Bad things were happening in display update functions every time a screen has > to > be resized. Good catch, added to the console patches. thanks, Gerd

[Qemu-devel] [PATCH] virtio-blk: Set default serial id

2013-03-19 Thread Asias He
If user does not specify a serial id, e.g. -device virtio-blk-pci,serial="serial_id" or -drive serial="serial_id" no serial id will be assigned. Add a default serial id in this case to help identifying the disk in guest. Signed-off-by: Asias He --- hw/virtio-blk.c | 7 +++ 1 file ch

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-19 Thread Alex Williamson
On Tue, 2013-03-19 at 22:52 -0600, Alex Williamson wrote: > On Tue, 2013-03-19 at 19:08 -0400, Kevin O'Connor wrote: > > On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote: > > > As QEMU gains PCI bridge and PCIe root port support, we won't always > > > find the VGA device on the root

[Qemu-devel] [Bug 1157368] Re: Desktop background messed up when running Raring in a QEMU-based virtual machine

2013-03-19 Thread Serge Hallyn
Also reproduced with git://git.qemu.org/qemu.git (using vga -cirrus) ** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1157368 Title:

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-19 Thread Alex Williamson
On Tue, 2013-03-19 at 19:08 -0400, Kevin O'Connor wrote: > On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote: > > As QEMU gains PCI bridge and PCIe root port support, we won't always > > find the VGA device on the root bus. We therefore need to add support > > to find and enable a VG

Re: [Qemu-devel] Is is a bug? (window scale)

2013-03-19 Thread Peter Cheung
Thank you MR Huang Thanksfrom Peter > Date: Wed, 20 Mar 2013 09:26:38 +0800 > From: riegama...@gmail.com > To: mcheun...@hotmail.com > CC: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] Is is a bug? (window scale) > > On Wed, Mar 20, 2013 at 1:12 AM, Peter Cheung wrote: > > Sorry about the a

[Qemu-devel] [PATCH v3] Use proper term in TCG README

2013-03-19 Thread Wei-Ren Chen
In TCG, "target" means the host architecture for which TCG generates the code. Using "guest" rather than "target" to make the document more consistent. Signed-off-by: Chen Wei-Ren --- v3: Adopt Peter's suggestion on sentence and typo. v2: Correct all wrong usage of the term "target" in this do

Re: [Qemu-devel] [RFC PATCH v4 01/30] [SeaBIOS] Add ACPI_EXTRACT_DEVICE* macros

2013-03-19 Thread li guang
seems these changes is in seebios now. 在 2012-12-18二的 13:41 +0100,Vasilis Liaskovitis写道: > This allows to extract the beginning, end and name of a Device object. > --- > tools/acpi_extract.py | 28 > 1 files changed, 28 insertions(+), 0 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 11/11] nbd: Use default port if only host is specified

2013-03-19 Thread Eric Blake
On 03/18/2013 11:24 AM, Kevin Wolf wrote: > The URL method already takes care to apply the default port when none is > specfied. Directly specifying driver-specific options required the port > number until now. Allow leaving it out and apply the default. > > Signed-off-by: Kevin Wolf > --- > blo

Re: [Qemu-devel] [PATCH 10/11] block: Allow omitting the file name when using driver-specific options

2013-03-19 Thread Eric Blake
On 03/18/2013 11:24 AM, Kevin Wolf wrote: > After this patch, using -drive with an empty file name continues to open > the file if driver-specific options are used. If no driver-specific > options are specified, the semantics stay as it was: It defines a drive > without an inserted medium. > > In

Re: [Qemu-devel] [PATCH 09/11] block: Make find_image_format safe with NULL filename

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > In order to achieve this, the .bdrv_probe callbacks of all drivers must > cope with this. The DMG driver is the only one that bases its decision > on the filename and it needs to be changed. > > Signed-off-by: Kevin Wolf > --- > block/dmg.c | 13 ++

Re: [Qemu-devel] [PATCH 08/11] block: Rename variable to avoid shadowing

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > bdrv_open() uses two different variables called options. Rename one of > them to avoid confusion and to allow the outer one to be accessed > everywhere. > > Signed-off-by: Kevin Wolf > --- > block.c | 16 +--- > 1 file changed, 9 insertions

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-03-19 Thread Nicholas A. Bellinger
On Tue, 2013-03-19 at 09:40 +0100, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2013 at 08:34:45AM +0800, Asias He wrote: > > --- > > hw/vhost.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/hw/vhost.c b/hw/vhost.c > > index 4d6aee3..0c52ec4 100644 > > --- a/hw/vhost.c > > +++ b/hw

Re: [Qemu-devel] Is is a bug? (window scale)

2013-03-19 Thread Dunrong Huang
On Wed, Mar 20, 2013 at 1:12 AM, Peter Cheung wrote: > Sorry about the attachment size, i didn't look out the file size. > Is here the right mailing list to report bug? or the team have something > like bugzilla? > Please report your bug here: https://bugs.launchpad.net/qemu It's QEMU's bug tracke

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-19 Thread li guang
在 2013-03-19二的 10:15 +,Peter Maydell写道: > On 19 March 2013 09:31, li guang wrote: > > 在 2013-03-19二的 09:05 +,Peter Maydell写道: > >> I suspect this should involve more modelling of actual > >> control signals between the power controller and > >> the devices, not methods on the base class. >

Re: [Qemu-devel] [PATCH v2 0/9] tcg-arm improvements

2013-03-19 Thread Richard Henderson
Ping. r~ On 2013-03-11 23:43, Richard Henderson wrote: Changes v1-v2: * Use more helper functions to handle K and N constraints. * Improve add2/sub2. * Improve epilogues, as suggested in the previous thread. * Fix a typo in the name of the deposit helper. * Implement division for

Re: [Qemu-devel] [PATCH v2 00/27] Modernize tcg/ppc64

2013-03-19 Thread Richard Henderson
Ping 2. On 2013-03-11 23:41, Richard Henderson wrote: Ping. On 2013-03-04 16:32, Richard Henderson wrote: Additional patches since V1: * Handle constant inputs for some compound logicals * Implement add2/sub2_i64 * Implement mulu2/muls2_i64 Otherwise unchanged, but rebased vs 26135ea

Re: [Qemu-devel] [PATCH] tcg-optimize: Fold sub r,0,x to neg r,x

2013-03-19 Thread Richard Henderson
On 2013-02-23 08:43, Blue Swirl wrote: Signed-off-by: Richard Henderson >--- > tcg/optimize.c | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) > >I noticed this while looking at other dumps. This seems like it >should be considered independently of the o

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-19 Thread Paolo Bonzini
Il 20/03/2013 00:44, Peter Maydell ha scritto: > On 19 March 2013 23:35, Paolo Bonzini wrote: >> > Il 19/03/2013 23:34, Peter Maydell ha scritto: >>> >> On 19 March 2013 22:23, Paolo Bonzini wrote: >>> So, okay to put these in hw/arm and then I'll work on patches moving >>> cpu_arm_init

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-19 Thread Peter Maydell
On 19 March 2013 23:35, Paolo Bonzini wrote: > Il 19/03/2013 23:34, Peter Maydell ha scritto: >> On 19 March 2013 22:23, Paolo Bonzini wrote: >>> So, okay to put these in hw/arm and then I'll work on patches moving >>> cpu_arm_init to a*mpcore.c? >> >> Wrong way round. If you can't put the cpu_ar

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 23:34, Peter Maydell ha scritto: > On 19 March 2013 22:23, Paolo Bonzini wrote: >> Il 19/03/2013 11:32, Peter Maydell ha scritto: >>> On 19 March 2013 10:27, Paolo Bonzini wrote: Il 19/03/2013 11:10, Peter Maydell ha scritto: > My point is that the QOM abstraction should en

[Qemu-devel] Requesting a wiki account.

2013-03-19 Thread Jeff .
I've been doing background reading on the wiki and have found multiple dead links / errors I'd like to fix. Could an admin email me off list regarding a wiki account under a different email address / name ? Thanks !

Re: [Qemu-devel] [RESEND PATCH v2] pciinit: Enable default VGA device

2013-03-19 Thread Kevin O'Connor
On Mon, Mar 18, 2013 at 09:07:21PM -0600, Alex Williamson wrote: > As QEMU gains PCI bridge and PCIe root port support, we won't always > find the VGA device on the root bus. We therefore need to add support > to find and enable a VGA device and the path to it through the VGA > Enable support in t

[Qemu-devel] Requesting a wiki account.

2013-03-19 Thread spectre
I've been doing background reading on the wiki and have found multiple dead links / errors I'd like to fix. Could an admin email me off list regarding a wiki account under a different email address / name ? Thanks ! N.B. Apologies if this message is delivered twice. Mailman does not seem to ha

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-19 Thread Peter Maydell
On 19 March 2013 22:23, Paolo Bonzini wrote: > Il 19/03/2013 11:32, Peter Maydell ha scritto: >> On 19 March 2013 10:27, Paolo Bonzini wrote: >>> Il 19/03/2013 11:10, Peter Maydell ha scritto: My point is that the QOM abstraction should encapsulate the CPU cores just like any other piec

[Qemu-devel] [PATCH] pcie: Enhance PCIe links

2013-03-19 Thread Alex Williamson
Enable PCIe devices to negotiate links. This upgrades our root ports and switches to advertising x16, 8.0GT/s and negotiates the current link status to the best available width and speed. Note that we also skip setting link fields for Root Complex Integrated Endpoints as indicated by the PCIe spe

Re: [Qemu-devel] [PATCH 00/35] hw/ reorganization, part 2

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 11:32, Peter Maydell ha scritto: > On 19 March 2013 10:27, Paolo Bonzini wrote: >> Il 19/03/2013 11:10, Peter Maydell ha scritto: >>> Well, for the CPU to be a proper QOM object it should be exposing >>> the IRQ/FIQ lines normally, not via the code in hw/arm/pic_cpu.c. >> >> That app

Re: [Qemu-devel] [PATCH 07/11] block: Introduce .bdrv_parse_filename callback

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > If a driver needs structured data and not just a string, it can provide > a .bdrv_parse_filename callback now that parses the command line string > into separate options. Keeping this separate from .bdrv_open_filename > ensures that the preferred way of d

Re: [Qemu-devel] [PATCH 06/11] nbd: Accept -drive options for the network connection

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > The existing parsers for the file name now parse everything into the > bdrv_open() options QDict. Instead of using these parsers, you can now > directly specify the options on the command line, like this: > > qemu-system-x86_64 -drive file=nbd:,file.

Re: [Qemu-devel] [PATCH 05/11] nbd: Remove unused functions

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > include/block/nbd.h | 2 -- > nbd.c | 19 --- > 2 files changed, 21 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization lib

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 20:37, Peter Lieven ha scritto: > > Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > >> Il 19/03/2013 16:54, Peter Lieven ha scritto: >>> On 19.03.2013 12:18, Paolo Bonzini wrote: Il 19/03/2013 09:51, Markus Armbruster ha scritto: > Paolo, please have a look. Why isn't

Re: [Qemu-devel] [PATCH 04/11] nbd: Keep hostname and port separate

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > The NBD block supports an URL syntax, for which a URL parser returns > separate hostname and port fields. It also supports the traditional qemu > syntax encoded in a filename. Until now, after parsing the URL to get > each piece of information, a new stri

Re: [Qemu-devel] [PATCH] qemu-sockets: Fix assertion failure

2013-03-19 Thread Luiz Capitulino
On Wed, 06 Mar 2013 15:46:45 +0100 Laszlo Ersek wrote: > On 03/06/13 12:11, Kevin Wolf wrote: > > Am 06.03.2013 um 12:04 hat Paolo Bonzini geschrieben: > >> Il 06/03/2013 11:48, Kevin Wolf ha scritto: > >>> inet_connect_opts() tries all possible addrinfos returned by > >>> getaddrinfo(). If one f

Re: [Qemu-devel] [PATCH 03/11] qemu-socket: Make socket_optslist public

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > Allow other users to create the QemuOpts needed for inet_connect_opts(). > > Signed-off-by: Kevin Wolf > --- > include/qemu/sockets.h | 2 ++ > util/qemu-sockets.c| 22 +++--- > 2 files changed, 13 insertions(+), 11 deletions(-) >

[Qemu-devel] [PATCH] pcie: Add endpoint capability initialization wrapper

2013-03-19 Thread Alex Williamson
Fix the awkward API of mangling the caller specified PCIe type and just provide an interface to initialize an endpoint device. This will pick either a regular endpoint or integrated endpoint based on the bus and return pcie_cap_init to doing exactly what is asked. Signed-off-by: Alex Williamson

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Alexander Graf
On 19.03.2013, at 19:32, Richard Henderson wrote: > On 03/19/2013 10:20 AM, Fabien Chouteau wrote: >> Cleaner solution indeed. I'll do the opposite, store_fpscr calls >> helper_store_fpscr. > > The declarations won't be in the right places for that to work right. > > Canonically, cpu_store_fps

[Qemu-devel] [PATCH 1/2] exynos4210_fimd.c: fix display resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
In exynos4210 display update function, we were acquiring DisplaySurface pointer before calling screen resize function, not paying attention that resize procedure can replace current DisplaySurface with newly allocated one. Right thing to do is to initialize DisplaySurface AFTER a call to resize fu

[Qemu-devel] [PATCH 2/2] hw/vmware_vga.c: fix screen resize bug introduced after console revamp

2013-03-19 Thread Igor Mitsyanko
In vmsvga display update function, a pointer to DisplaySurface must be acquired after a call to vmsvga_check_size since this function might replace current DisplaySurface with a new one. Signed-off-by: Igor Mitsyanko --- hw/vmware_vga.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-

[Qemu-devel] [PATCH 0/2] Fix display resize bugs introduced after recent console revamp

2013-03-19 Thread Igor Mitsyanko
Bad things were happening in display update functions every time a screen has to be resized. Igor Mitsyanko (2): exynos4210_fimd.c: fix display resize bug introduced after console revamp hw/vmware_vga.c: fix screen resize bug introduced after console revamp hw/exynos4210_fimd.c |

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:08 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> performance gain on SSE2 is approx. 20-25%. altivec >> is not tested. performance for unsigned long arithmetic >> is unchanged. >> >> Signed-off-by: Peter Lieven >> --- >> util/cutils.c |7 +++ >

[Qemu-devel] [PATCH v3] NVMe: Initial commit

2013-03-19 Thread Keith Busch
Initial commit for emulated nvme pci device. Implements the minimum from the specification to work with existing drivers. Cc: Keith Busch Signed-off-by: Keith Busch Just going for the simplest patch possible for this device. If this is okay, the remainining features implementing the full specif

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:43 schrieb Eric Blake : > On 03/19/2013 10:18 AM, Peter Lieven wrote: >> >> Am 19.03.2013 um 16:54 schrieb Eric Blake : >> >>> On 03/15/2013 09:50 AM, Peter Lieven wrote: Signed-off-by: Peter Lieven --- include/qemu-common.h |2 ++ util/cutils.c

Re: [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:49 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> this patch adds the usage of buffer_find_nonzero_offset() >> to skip large areas of zeroes. >> >> compared to loop unrolling presented in an earlier >> patch this adds another 50% performance benefit for

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Eric Blake
On 03/19/2013 12:05 PM, Kevin Wolf wrote: > Am 19.03.2013 um 18:48 hat Eric Blake geschrieben: >> On 03/18/2013 11:23 AM, Kevin Wolf wrote: >>> Specify -drive file.option=... on the command line to pass the option to >>> the protocol instead of the format driver. >>> >>> Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:07 schrieb Paolo Bonzini : > Il 19/03/2013 16:54, Peter Lieven ha scritto: >> On 19.03.2013 12:18, Paolo Bonzini wrote: >>> Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. >>> Why isn't it enough to call bdrv_init_with_whitelist earlier? >>>

Re: [Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:36 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> during bulk stage of ram migration if a page is a >> zero page do not send it at all. >> the memory at the destination reads as zero anyway. >> >> even if there is an madvise with QEMU_MADV_DONTNEED >> a

Re: [Qemu-devel] [PATCHv2 8/9] migration: do not search dirty pages in bulk stage

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 18:40 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> avoid searching for dirty pages just increment the >> page offset. all pages are dirty anyway. >> >> Signed-off-by: Peter Lieven >> --- >> arch_init.c | 12 +--- >> 1 file changed, 9 insertions

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Alex Bligh
Stefano, George, This patch only impacts the PV backend in QEMU, not the IDE interface. PV frontends and backends always disconnect and reconnect during save/restore. So we can be *certain* that bdrv_close at the sender side is called before the new connection is established at the receiver side

[Qemu-devel] [PATCH] target-i386: Don't modify env->eflags around cpu_dump_state

2013-03-19 Thread Richard Henderson
We can compute the value in cpu_dump_state anyway, and gratuitous modifications to eflags creates heisenbugs. Cc: Blue Swirl Signed-off-by: Richard Henderson --- cpu-exec.c | 3 --- target-i386/helper.c | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/cpu-exec.c b

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3] add a boot option to do strict boot

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Markus Armbruster writes: > Gerd Hoffmann writes: > >> chardev flow control broke monitor, fix it by adding watch support. >> >> Signed-off-by: Gerd Hoffmann >> --- >> v2: fix tyops >> --- > > Subject lacks v2. Anthony, holler if you want a respin to unconfuse > your tools. I already processe

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix compile failures introduced by recent console changes

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] char: Fix return type of qemu_chr_fe_add_watch()

2013-03-19 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH 0/2] Implement migration support for pflash_cfi01

2013-03-19 Thread Peter Maydell
These patches implement migration support for pflash_cfi01. The first patch just drops some useless state so we don't have to think about it for migration. NB that pflash_cfi01 is used in the x86 pc model. I think this means that migration while the BIOS is accessing the flash wouldn't have worked

[Qemu-devel] [PATCH 1/2] pflash_cfi01: Drop unused 'bypass' field

2013-03-19 Thread Peter Maydell
For pflash_cfi01 the 'bypass' field is set to zero and never changes, so remove it (it is a leftover from pflash_cfi02, where bypass is implemented). Signed-off-by: Peter Maydell --- hw/pflash_cfi01.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/hw/pflash_cfi0

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 19:27, Michael R. Hines ha scritto: >>> >> That however gives me an idea... Instead of the full drain at the end >> of an iteration, does it make sense to do a "partial" drain at every >> chunk full, so that you don't have > N bytes pending and the downtime is >> correspondingly limi

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Richard Henderson
On 03/19/2013 10:20 AM, Fabien Chouteau wrote: > Cleaner solution indeed. I'll do the opposite, store_fpscr calls > helper_store_fpscr. The declarations won't be in the right places for that to work right. Canonically, cpu_store_fpscr should be declared in cpu.h, have the leading "cpu_" prefix,

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 08/10] introduce QEMUFileRDMA

2013-03-19 Thread Michael R. Hines
On 03/19/2013 10:22 AM, Paolo Bonzini wrote: Il 19/03/2013 15:10, Michael R. Hines ha scritto: On 03/19/2013 09:45 AM, Paolo Bonzini wrote: This is because of downtime: You have to drain the queue anyway at the very end, and if you don't drain it in advance after each iteration, then the queue

Re: [Qemu-devel] [PATCH V2 0/3] ARM: Misc ARM big-endian bug fixes

2013-03-19 Thread Richard Henderson
On 03/19/2013 04:30 AM, Peter Maydell wrote: > (As an aside, perhaps we should generate the list in qapi-schema.json > automatically rather than hardcoding every target name? dunno) Definitely. It took me quite a while to find this when updating my spu target emulator a while back. r~

[Qemu-devel] [PATCH 2/2] pflash_cfi01: Implement migration support

2013-03-19 Thread Peter Maydell
Add a vmstate to pflash_cfi01, so that it can be live migrated. XXX this device is in pc, so does this break cross version migration??? Signed-off-by: Peter Maydell --- hw/pflash_cfi01.c | 20 +--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/hw/pflash_cfi01.

Re: [Qemu-devel] [Bug 1156313] [NEW] X86-64 flags handling broken

2013-03-19 Thread Richard Henderson
On 03/17/2013 12:34 PM, Torbjorn Granlund wrote: > Public bug reported: > > The current qemu sources cause improper handling of flags on x86-64. > This bug seems to have shown up a few weeks ago. > > A plain install of Debian GNU/Linux makes user processes catch > spurious signals. The kernel se

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Kevin Wolf
Am 19.03.2013 um 18:48 hat Eric Blake geschrieben: > On 03/18/2013 11:23 AM, Kevin Wolf wrote: > > Specify -drive file.option=... on the command line to pass the option to > > the protocol instead of the format driver. > > > > Signed-off-by: Kevin Wolf > > --- > > block.c | 63 > > +

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
On 03/19/2013 01:52 PM, Paolo Bonzini wrote: So, if I submit a separate patch to fix this, would you guys review it? (Using /dev/pagemap). Sorry about the ignorance, but what is /dev/pagemap? :) /dev/pagemap is a recent interface for eserland accesses to the pagetables. https://www.kernel.org/d

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-03-19 Thread Gleb Natapov
On Thu, Mar 14, 2013 at 04:15:10AM +, Matthew Anderson wrote: > Thanks for the suggestion but so far it hasn't made any difference. > > I thought I may be an issue with the mainline kernel I was using so I changed > over to Ubuntu 12.10 and QEMU 1.2.0. Stability is slightly better but I still

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 18:40, Michael R. Hines ha scritto: > registration scheme would not work with cgroups because we would be > attempting to pin zero pages (for no reason) that cgroups has already > kicked out, which would defeat the purpose of using cgroups. Yeah, pinning would be a problem. > So, i

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
I also did a test using RDMA + cgroup, and the kernel killed my QEMU :) So, infiniband is not smart enough to know how to avoid pinning a zero page, I guess. - Michael On 03/19/2013 01:14 PM, Paolo Bonzini wrote: Il 19/03/2013 18:09, Michael R. Hines ha scritto: Allowing QEMU to swap due to

Re: [Qemu-devel] [PATCH 02/11] block: Pass bdrv_file_open() options to block drivers

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > Specify -drive file.option=... on the command line to pass the option to > the protocol instead of the format driver. > > Signed-off-by: Kevin Wolf > --- > block.c | 63 --- > 1 file changed,

Re: [Qemu-devel] [PATCHv2 9/9] migration: use XBZRLE only after bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > at the beginning of migration all pages are marked dirty and > in the first round a bulk migration of all pages is performed. > > currently all these pages are copied to the page cache regardless > if there are frequently updated or not. this doesn't m

[Qemu-devel] [PATCH V2] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Fabien Chouteau
Although the support of this register may be uncomplete, there are no reason to prevent the debugger from reading or writing it. Signed-off-by: Fabien Chouteau --- gdbstub.c |3 ++- target-ppc/cpu.h|2 ++ target-ppc/fpu_helper.c |5 + target-ppc/

Re: [Qemu-devel] [PATCH] fix monitor

2013-03-19 Thread Markus Armbruster
Gerd Hoffmann writes: > chardev flow control broke monitor, fix it by adding watch support. > > Signed-off-by: Gerd Hoffmann > --- > v2: fix tyops > --- Subject lacks v2. Anthony, holler if you want a respin to unconfuse your tools.

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
OK, so I did a quick test and the cgroup does appear to be working correctly for zero pages. Nevertheless, this still doesn't solve the chunk registration problem for RDMA. Even with a cgroup on the sender *or* receiver side, there is no API that I know that would correctly indicate to the m

Re: [Qemu-devel] [PATCHv2 8/9] migration: do not search dirty pages in bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > avoid searching for dirty pages just increment the > page offset. all pages are dirty anyway. > > Signed-off-by: Peter Lieven > --- > arch_init.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/arch_init.c b/

Re: [Qemu-devel] [PATCHv2 7/9] migration: do not sent zero pages in bulk stage

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > during bulk stage of ram migration if a page is a > zero page do not send it at all. > the memory at the destination reads as zero anyway. > > even if there is an madvise with QEMU_MADV_DONTNEED > at the target upon receival of a zero page I have obser

Re: [Qemu-devel] [PATCHv2 6/9] migration: add an indicator for bulk state of ram migration

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > the first round of ram transfer is special since all pages > are dirty and thus all memory pages are transferred to > the target. this patch adds a boolean variable to track > this stage. > > Signed-off-by: Peter Lieven > --- > arch_init.c |3 +++

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 06:14:45PM +0100, Paolo Bonzini wrote: > Il 19/03/2013 18:09, Michael R. Hines ha scritto: > > Allowing QEMU to swap due to a cgroup limit during migration is a viable > > overcommit option? > > > > I'm trying to keep an open mind, but that would kill the migration > > time

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Peter Maydell
On 19 March 2013 17:20, Fabien Chouteau wrote: > On 03/19/2013 04:23 PM, Peter Maydell wrote: >> The way we do this on ARM for cpsr_read is: >> * cpsr_read() is defined in target-arm/cpu.h >> * gdbstub.c calls cpsr_read() >> * HELPER(cpsr_read) is mostly a wrapper calling cpsr_read() >> * help

Re: [Qemu-devel] [PATCH] PPC/GDB: handle read and write of fpscr

2013-03-19 Thread Fabien Chouteau
On 03/19/2013 04:23 PM, Peter Maydell wrote: > On 19 March 2013 15:14, Fabien Chouteau wrote: >> I can if I include helper.h, unfortunately this file is named helpers.h >> (note the 's') for m68k so I wont be able to include it for all >> platforms. > > The way we do this on ARM for cpsr_read is:

[Qemu-devel] OOM don't like qemu-kvm

2013-03-19 Thread Peter Cheung
Hi AllMy compuer is i7 with 32 GB ram without swap, i try to launch 28 vm with 1GB ram each, it runs smoothly.If I launch 64 VMs, after the VMs eat up all the memory, the linux hang. If the linux is lack of memory, the OOM will try to kill process, right? And the OOM should pick those qemu-k

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 18:09, Michael R. Hines ha scritto: > Allowing QEMU to swap due to a cgroup limit during migration is a viable > overcommit option? > > I'm trying to keep an open mind, but that would kill the migration > time. Would it swap? Doesn't the kernel back all zero pages with a single

Re: [Qemu-devel] Is is a bug? (window scale)

2013-03-19 Thread Peter Cheung
Sorry about the attachment size, i didn't look out the file size.Is here the right mailing list to report bug? or the team have something like bugzilla? Thanksfrom Peter > Date: Mon, 18 Mar 2013 17:36:15 -0600 > From: ebl...@redhat.com > To: mcheun...@hotmail.com > CC: qemu-devel@nongnu.org > Su

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael R. Hines
Allowing QEMU to swap due to a cgroup limit during migration is a viable overcommit option? I'm trying to keep an open mind, but that would kill the migration time. - Michael On 03/19/2013 11:36 AM, Michael S. Tsirkin wrote: On Tue, Mar 19, 2013 at 11:32:49AM -0400, Michael R. Hines wrote

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 16:54, Peter Lieven ha scritto: > On 19.03.2013 12:18, Paolo Bonzini wrote: >> Il 19/03/2013 09:51, Markus Armbruster ha scritto: >>> Paolo, please have a look. >> Why isn't it enough to call bdrv_init_with_whitelist earlier? >> >> There is no conditional logic in it, the whitelist is

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Stefano Stabellini
On Tue, 19 Mar 2013, Paolo Bonzini wrote: > Il 19/03/2013 16:13, Stefano Stabellini ha scritto: > > This patch only impacts the PV backend in QEMU, not the IDE interface. > > PV frontends and backends always disconnect and reconnect during > > save/restore. > > So we can be *certain* that bdrv_clos

[Qemu-devel] [PATCH 1/1] microblaze: Ignore non-cpu accesses to unmapped areas

2013-03-19 Thread edgar . iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-microblaze/op_helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-microblaze/op_helper.c b/target-microblaze/op_helper.c index 1c62f3c..f2cb88b 100644 --- a/target-microblaze/op_helper.c +++

Re: [Qemu-devel] [PATCHv2 5/9] migration: search for zero instead of dup pages

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > virtually all dup pages are zero pages. remove > the speical is_dup_page() function and use the s/speical/special/ > optimized buffer_is_zero() function instead. > > Signed-off-by: Peter Lieven > --- > arch_init.c | 17 + > 1 file

Re: [Qemu-devel] [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

2013-03-19 Thread Paolo Bonzini
Il 19/03/2013 16:13, Stefano Stabellini ha scritto: > This patch only impacts the PV backend in QEMU, not the IDE interface. > PV frontends and backends always disconnect and reconnect during > save/restore. > So we can be *certain* that bdrv_close at the sender side is called > before the new conn

Re: [Qemu-devel] [PATCHv2 4/9] bitops: use vector algorithm to optimize find_next_bit()

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > this patch adds the usage of buffer_find_nonzero_offset() > to skip large areas of zeroes. > > compared to loop unrolling presented in an earlier > patch this adds another 50% performance benefit for > skipping large areas of zeroes. loop unrolling alo

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Eric Blake
On 03/19/2013 10:18 AM, Peter Lieven wrote: > > Am 19.03.2013 um 16:54 schrieb Eric Blake : > >> On 03/15/2013 09:50 AM, Peter Lieven wrote: >>> Signed-off-by: Peter Lieven >>> --- >>> include/qemu-common.h |2 ++ >>> util/cutils.c | 40 >>> 2

[Qemu-devel] [PATCH] target-i386: Fix flags computation for ADOX

2013-03-19 Thread Richard Henderson
When starting from CC_OP_DYNAMIC, and issuing adox before adcx, a typo used the wrong value for the resulting CC_OP. Cc: Blue Swirl Reported-by: Torbjorn Granlund Signed-off-by: Richard Henderson --- target-i386/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ta

[Qemu-devel] kvm suspend performance

2013-03-19 Thread Thomas Knauth
Dear all, lately I've been playing around with qemu's/kvm's suspend (to disk) and resume. My initial expectation was that both operations are I/O bound. So it surprised me to see that suspend to disk seems to be CPU-bound. Suspending a VM with 1.5 GB memory takes 55 seconds. This works out to less

Re: [Qemu-devel] [PATCH 0/2] fix segfault in (iscsi) option parsing

2013-03-19 Thread Peter Lieven
On 19.03.2013 12:18, Paolo Bonzini wrote: Il 19/03/2013 09:51, Markus Armbruster ha scritto: Paolo, please have a look. Why isn't it enough to call bdrv_init_with_whitelist earlier? There is no conditional logic in it, the whitelist is checked at open time. Has anyone tested if -spice is wor

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 16:54 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> Signed-off-by: Peter Lieven >> --- >> include/qemu-common.h |2 ++ >> util/cutils.c | 40 >> 2 files changed, 42 insertions(+) >> > >> >> +#define

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Peter Lieven
Am 19.03.2013 um 17:08 schrieb Eric Blake : > On 03/15/2013 09:50 AM, Peter Lieven wrote: >> performance gain on SSE2 is approx. 20-25%. altivec >> is not tested. performance for unsigned long arithmetic >> is unchanged. >> >> Signed-off-by: Peter Lieven >> --- >> util/cutils.c |7 +++ >

Re: [Qemu-devel] [PATCHv2 3/9] buffer_is_zero: use vector optimizations if possible

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > performance gain on SSE2 is approx. 20-25%. altivec > is not tested. performance for unsigned long arithmetic > is unchanged. > > Signed-off-by: Peter Lieven > --- > util/cutils.c |7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/ut

Re: [Qemu-devel] [PATCH 03/35] configure: fix TPM logic

2013-03-19 Thread Andreas Färber
Am 18.03.2013 18:34, schrieb Paolo Bonzini: > A non-native i386 or x86_64 emulator should not have TPM passthrough > support, since the TPM is only present for those hosts. > > Signed-off-by: Paolo Bonzini Looks good, Reviewed-by: Andreas Färber Thanks, Andreas -- SUSE LINUX Products GmbH,

Re: [Qemu-devel] [PATCHv2 2/9] cutils: add a function to find non-zero content in a buffer

2013-03-19 Thread Eric Blake
On 03/15/2013 09:50 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > include/qemu-common.h |2 ++ > util/cutils.c | 40 > 2 files changed, 42 insertions(+) > > > +#define BUFFER_FIND_NONZERO_OFFSET_UNROLL_FACTOR 8 Good. > +

Re: [Qemu-devel] [PATCH 01/11] block: Add options QDict to bdrv_file_open() prototypes

2013-03-19 Thread Eric Blake
On 03/18/2013 11:23 AM, Kevin Wolf wrote: > The new parameter is unused yet. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org signature.asc Description: OpenPGP digital signatu

Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-19 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 11:32:49AM -0400, Michael R. Hines wrote: > On 03/19/2013 11:16 AM, Michael S. Tsirkin wrote: > >On Tue, Mar 19, 2013 at 11:08:24AM -0400, Michael R. Hines wrote: > >>This is actual a much bigger problem that I thought, not just for RDMA: > >> > >>Currently the *sender* side

  1   2   3   >