Re: [Qemu-devel] [PATCH] ui/gtk: Set QEMU window icon

2013-04-11 Thread Jan Kiszka
On 2013-04-11 21:46, Stefan Weil wrote: > Am 10.04.2013 13:48, schrieb Jan Kiszka: >> On 2013-03-30 15:21, Stefan Weil wrote: >>> The QEMU icon which is already used for SDL >>> is now also loaded by GTK. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> ui/gtk.c | 13 + >>> 1 file ch

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-11 Thread Kevin Wolf
Am 11.04.2013 um 19:19 hat Josh Durgin geschrieben: > On 04/11/2013 01:48 AM, Kevin Wolf wrote: > >Am 11.04.2013 um 10:02 hat Stefan Hajnoczi geschrieben: > >>On Wed, Apr 10, 2013 at 07:03:39AM -0700, Josh Durgin wrote: > >>>On 04/02/2013 07:10 AM, Kevin Wolf wrote: > Am 29.03.2013 um 21:03 hat

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-11 Thread liu ping fan
On Thu, Apr 11, 2013 at 6:09 PM, Paolo Bonzini wrote: > Il 01/04/2013 10:20, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> The hostmem listener will translate gpa to hva quickly. Make it >> global, so other component can use it. >> Also this patch adopt MemoryRegionOps's ref/unref interfac

[Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message

2013-04-11 Thread Wanlong Gao
While DEBUG() already includes the function name. Signed-off-by: Wanlong Gao --- hw/i386/kvm/pci-assign.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index c1e08ec..6afb82e 100644 --- a/hw/i386/kvm/pci-assig

Re: [Qemu-devel] [PATCH 0/3] Release SMP restriction on Windows host

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 20:57, Stefan Weil ha scritto: > On 09.04.2013 18:16, Paolo Bonzini wrote: >> Reviewed-by: Paolo Bonzini > > Do we need an additional Signed-off from the author (Olivier Hainque)? > Currently, only Fabien signed these patches. In theory yes, in practice they are colleagues so I thin

[Qemu-devel] [PATCH 8/8] rdma: add documentation

2013-04-11 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 338 + 1 file changed, 338 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PATCH 5/8] rdma: introduce capability for chunk registration

2013-04-11 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. Hines --- migration.c | 11 ++- qapi-schema.json |2 +- 2 files changed, 11 inserti

[Qemu-devel] [PATCH 4/8] rdma: implement new QEMUFileOps hooks

2013-04-11 Thread mrhines
From: "Michael R. Hines" These are the actual definitions of the accessor methods which call out to QEMUFileOps hooks during the RAM iteration faces. These hooks are accessed by arch_init.c, which comes later in the patch series. Signed-off-by: Michael R. Hines --- savevm.c | 81 +++

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/12/2013 01:26 AM, Paolo Bonzini wrote: Il 12/04/2013 07:10, Michael R. Hines ha scritto: On 04/11/2013 11:33 AM, Paolo Bonzini wrote: 2) rename the transport to "x-rdma" (just in migration.c) What does this mean? Use "migrate x-rdma:192.168.10.12" to migrate, to indicate it's experiment

[Qemu-devel] [PATCH 7/8] rdma: print out throughput while debugging

2013-04-11 Thread mrhines
From: "Michael R. Hines" It's very helpful when debugging to print out migration throughput after each iteration round to compare the different migration technologies. Signed-off-by: Michael R. Hines --- migration.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH 3/8] rdma: new QEMUFileOps hooks

2013-04-11 Thread mrhines
From: "Michael R. Hines" These are just the prototypes for optional new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are just the protytp

[Qemu-devel] [PATCH 6/8] rdma: send pc.ram

2013-04-11 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines --- arch_init.c | 35

[Qemu-devel] [PATCH 1/8] rdma: introduce qemu ram foreach block

2013-04-11 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |

[Qemu-devel] [PATCH 0/8] rdma: migration support

2013-04-11 Thread mrhines
From: "Michael R. Hines" Changes since v7: - Ran checkpatch.pl - Finished additional cleanup requests - Deleted zero scanning option - Cleaned up docs/rdma.txt Wiki: http://wiki.qemu.org/Features/RDMALiveMigration Github: g...@github.com:hinesmr/qemu.git Signed-off-by: Michael R. Hines

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Paolo Bonzini
Il 12/04/2013 07:10, Michael R. Hines ha scritto: > On 04/11/2013 11:33 AM, Paolo Bonzini wrote: >> 2) rename the transport to "x-rdma" (just in migration.c) > > What does this mean? Use "migrate x-rdma:192.168.10.12" to migrate, to indicate it's experimental and the protocol might change. It's

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 11:33 AM, Paolo Bonzini wrote: 2) rename the transport to "x-rdma" (just in migration.c) What does this mean?

Re: [Qemu-devel] [PATCH V11 13/17] block: dump to buffer for bdrv_snapshot_dump() and bdrv_image_info_dump()

2013-04-11 Thread Wenchao Xia
于 2013-4-11 20:05, Markus Armbruster 写道: > Wenchao Xia writes: > -void bdrv_image_info_dump(ImageInfo *info) +void bdrv_image_info_dump(GString *buf, ImageInfo *info) { char size_buf[128], dsize_buf[128]; if (!info->has_actual_size) { @@ -37

Re: [Qemu-devel] [PATCH 3/5] vring: use hostmem's RAM safe api

2013-04-11 Thread liu ping fan
On Thu, Apr 11, 2013 at 6:15 PM, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2013 at 04:20:32PM +0800, Liu Ping Fan wrote: >> @@ -51,7 +50,7 @@ bool vring_setup(Vring *vring, VirtIODevice *vdev, int n) >> >> void vring_teardown(Vring *vring) >> { >> -hostmem_finalize(&vring->hostmem); >> +m

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-11 Thread liu ping fan
On Thu, Apr 11, 2013 at 6:20 PM, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2013 at 04:20:33PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> virtio-blk will reference to RAM's memoryRegion when the req has been >> done. So we can avoid to call bdrv_drain_all() when RAM hot unplug. > > How

Re: [Qemu-devel] [PATCH 4/5] virtio-blk: release reference to RAM's memoryRegion

2013-04-11 Thread liu ping fan
On Tue, Apr 2, 2013 at 1:58 PM, li guang wrote: > 在 2013-04-01一的 16:20 +0800,Liu Ping Fan写道: >> From: Liu Ping Fan >> >> virtio-blk will reference to RAM's memoryRegion when the req has been >> done. > > do you mean unreference after req completed? > Yes, should s/reference/unreference/ >> So

[Qemu-devel] [PATCH 3/3] debugcon: fix compiler warning when open DEBUG_DEBUGCON

2013-04-11 Thread liguang
compiler warnings: CChw/char/debugcon.o hw/char/debugcon.c: In function ‘debugcon_ioport_write’: hw/char/debugcon.c:58: warning: format ‘%02x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’ hw/char/debugcon.c: In function ‘debugcon_ioport_read’: hw/char/debugcon.c:70: warnin

[Qemu-devel] [PATCH 1/3] debugcon: fix always print "addr=0x0, val=0x0" bug

2013-04-11 Thread liguang
when use DEBUG_DEBUGCON, screen spits: debugcon: write addr=0x val=0x00 Rdebugcon: write addr=0x val=0x00 udebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=0x00 idebugcon: write addr=0x val=0x00 ndebugcon: write addr=0x val=

[Qemu-devel] [PATCH 2/3] debugcon: make debug message more readable

2013-04-11 Thread liguang
before change: Bdebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x6f odebugcon: write addr=0x val=0x74 tdebugcon: write addr=0x val=0x69 idebugcon: write addr=0x val=0x6e ndebugcon: write addr=0x val=0x67 gdebugcon: write addr=0x val=0x20 debugcon: write a

Re: [Qemu-devel] [PATCH 1/5] memory: add ref/unref interface for MemroyRegionOps

2013-04-11 Thread liu ping fan
On Thu, Apr 11, 2013 at 5:49 PM, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2013 at 04:20:30PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> This pair of interface are optinal, except for those device which is >> used outside the biglock's protection for hot unplug. > > Not sure if this co

Re: [Qemu-devel] [PATCH 2/5] hostmem: make hostmem global and RAM hotunplg safe

2013-04-11 Thread liu ping fan
On Thu, Apr 11, 2013 at 6:11 PM, Stefan Hajnoczi wrote: > On Mon, Apr 01, 2013 at 04:20:31PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> The hostmem listener will translate gpa to hva quickly. Make it >> global, so other component can use it. >> Also this patch adopt MemoryRegionOps's

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc (v3)

2013-04-11 Thread Joerg Roedel
On Tue, Apr 09, 2013 at 01:22:15AM +, Yoder Stuart-B08248 wrote: > > What happens if a normal unmap call is done on the MSI iova? Do we > > need a separate unmap? > > I was thinking a normal unmap on an MSI windows would be an error...but > I'm not set on that. I put the msi unmap there to

Re: [Qemu-devel] [PATCH V11 11/17] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-04-11 Thread Wenchao Xia
于 2013-4-11 17:31, Markus Armbruster 写道: Wenchao Xia writes: 于 2013-4-11 2:57, Luiz Capitulino 写道: On Wed, 10 Apr 2013 18:17:04 +0200 Markus Armbruster wrote: Stefan Hajnoczi writes: On Tue, Apr 02, 2013 at 07:47:24PM +0800, Wenchao Xia wrote: diff --git a/qmp-commands.hx b/qmp-command

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Eric Blake
On 04/11/2013 09:17 PM, Wenchao Xia wrote: >> >>> Hmm, as I typed that, I did another search of qemu-schema.json - we have >>> the type 'ImageInfo' defined, but none of the existing 'command's ever >>> call out the use of that type. Is it a type we are only using >>> internally to date, and where

Re: [Qemu-devel] [PATCH V11 09/17] qmp: add interface query-snapshots

2013-04-11 Thread Wenchao Xia
于 2013-4-11 21:39, Luiz Capitulino 写道: On Thu, 11 Apr 2013 07:08:41 -0600 Eric Blake wrote: On 04/11/2013 06:44 AM, Luiz Capitulino wrote: +-> { "execute": "query-snapshots" } +<- { + "return":[ + { +"id": "1", +"name": "snapshot1", +"vm-state

[Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-11 Thread Alexey Kardashevskiy
The bswap functions use memcpy but the bswap.h header itself does not seem to include it in some configuration such as cross compiling for powerpc64 on x86_64 machine (gcc 4.6.3 from ftp.kernel.org, headers/libs from FC18/ppc64), the example warning is below. The patch explicitly includes string.h

Re: [Qemu-devel] [RFC PATCH] net: introduce monitor command to query mactables

2013-04-11 Thread Amos Kong
Hi Eric, On Thu, Apr 11, 2013 at 09:36:40AM -0600, Eric Blake wrote: > On 04/11/2013 09:11 AM, Amos Kong wrote: > > We want to do macvtap programming by libvirt, this patch added > > a monitor command to query rx mode information. I will also > > work on another patch to add QMP event notification

[Qemu-devel] [PATCH] virtio-balloon: fix dynamic properties.

2013-04-11 Thread fred . konrad
From: KONRAD Frederic To keep compatibility with the old virtio-balloon-x, add the dynamic properties to virtio-balloon-pci and virtio-balloon-ccw. Cc: Luiz Capitulino Signed-off-by: KONRAD Frederic --- hw/s390x/virtio-ccw.c | 8 hw/virtio/virtio-balloon.c | 16

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 03:15 PM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzini wrote: Il 11/04/2013 16:37, Michael S. Tsirkin ha scritto: pg1 -> pin

Re: [Qemu-devel] [PATCH] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-11 Thread Edgar E. Iglesias
On Thu, Apr 11, 2013 at 09:21:46PM +0100, Peter Maydell wrote: > The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() > call, which is a pretty trivial cost even for something in the main > cpu_exec() loop. Having this be conditionally defined means that > '-d exec' on a non-debug bu

[Qemu-devel] [PATCH] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-11 Thread Peter Maydell
The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() call, which is a pretty trivial cost even for something in the main cpu_exec() loop. Having this be conditionally defined means that '-d exec' on a non-debug build will silently do nothing. Drop the define and the configure machin

Re: [Qemu-devel] Question to prefered

2013-04-11 Thread Sander Eikelenboom
Thursday, April 11, 2013, 9:50:09 PM, you wrote: > On 11 April 2013 20:32, Sander Eikelenboom wrote: >> Hi Paolo / Anthony, >> 2) Qemu seems to have the possibility to make a debug enabled build by >> specifing --enable-debug option to ./configure, >>that sets CONFIG_DEBUG_EXEC=y, but a gre

[Qemu-devel] [PATCH qom-cpu-next 2/2] target-i386: Replace cpuid_*features fields with a feature word array

2013-04-11 Thread Eduardo Habkost
This replaces the feature-bit fields on both X86CPU and x86_def_t structs with an array. With this, we will be able to simplify code that simply does the same operation on all feature words (e.g. kvm_check_features_against_host(), filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU feature-b

[Qemu-devel] [PATCH qom-cpu-next 1/2] target-i386/cpu.c: Coding style fixes

2013-04-11 Thread Eduardo Habkost
* Add braces to 'if' statements; * Remove last TAB character from the source. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f1ccc72..c2e02fe 100644 --- a/target-i386/cp

[Qemu-devel] [PATCH qom-cpu-next 0/2] replace cpuid_*features fields with a featue word array (v7)

2013-04-11 Thread Eduardo Habkost
Yet Another rebase. Changes v7: - Rebase on top qom-cpu-next (commit 3755f0a9d48da07258f4a0ef5e883272799e47b9) Changes v6: - Rebase on top of Andreas' qom-cpu tree (commit 9260944307077b93a66bf861a467107af986fe47) - Break lines on kvm_check_features_against_host() - Break the lines on b

Re: [Qemu-devel] [qom-cpu PATCH 0/2] replace cpuid_*features fields with a featue word array (v6)

2013-04-11 Thread Eduardo Habkost
It looks like I will need to rebase and resubmit this again. Is there any hope we can get it included before soft freeze? On Tue, Apr 02, 2013 at 04:04:43PM -0300, Eduardo Habkost wrote: > Changes v6: > - Rebase on top of Andreas' qom-cpu tree (commit >9260944307077b93a66bf861a467107af986fe4

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc (v3)

2013-04-11 Thread Scott Wood
On 04/11/2013 07:56:59 AM, Joerg Roedel wrote: On Tue, Apr 09, 2013 at 01:22:15AM +, Yoder Stuart-B08248 wrote: > > What happens if a normal unmap call is done on the MSI iova? Do we > > need a separate unmap? > > I was thinking a normal unmap on an MSI windows would be an error...but >

Re: [Qemu-devel] Question to prefered

2013-04-11 Thread Peter Maydell
On 11 April 2013 20:32, Sander Eikelenboom wrote: > Hi Paolo / Anthony, > 2) Qemu seems to have the possibility to make a debug enabled build by > specifing --enable-debug option to ./configure, >that sets CONFIG_DEBUG_EXEC=y, but a grep on CONFIG_DEBUG_EXEC seems to > indicate it's not in w

Re: [Qemu-devel] [PATCH] ui/gtk: Set QEMU window icon

2013-04-11 Thread Stefan Weil
Am 10.04.2013 13:48, schrieb Jan Kiszka: On 2013-03-30 15:21, Stefan Weil wrote: The QEMU icon which is already used for SDL is now also loaded by GTK. Signed-off-by: Stefan Weil --- ui/gtk.c | 13 + 1 file changed, 13 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index a5a81

[Qemu-devel] Question to prefered

2013-04-11 Thread Sander Eikelenboom
Hi Paolo / Anthony, I have 2 questions: 1) Since Paolo has cleaned up the qemu tree by splitting out the /hw dir. I was considering to make the Xen file naming a bit more consistent. At the moment it's a mismatch with the xen prefix and the rest of the filename, separated by a hyphen, unde

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: > On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzini wrote: > >>Il 11/04/2013 16:37, Michael S. Tsirkin ha scritto: > >>>pg1 -> pin -> req -> res -> rdma -> done > >>>

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > ... and use it from board level to set APIC ID for CPUs > it creates. > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini > --- > Note: > * pc_new_cpu() function will be reused later in CPU hot-plug hook. > > v3: > *

Re: [Qemu-devel] [PATCH 09/19] cpu: add helper cpu_exists(), to check if CPU with specified id exists

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:48PM +0200, Igor Mammedov wrote: > ... it should be used only on slow path since it does recursive search > on /machine QOM tree for objects of TYPE_CPU > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini Why not implement this only after patch 21/22,

Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:47PM +0200, Igor Mammedov wrote: > get_arch_id() adds possibility for generic code to get guest visible > CPI id without accessing CPUArchState. If target doesn't override it, > it will return cpu_index. > > Override it on target-i386 to return APIC ID. The code impl

[Qemu-devel] [PATCH 3/5] tci: Avoid code before declarations

2013-04-11 Thread Stefan Weil
From: Richard Henderson This only valid with c99 extensions enabled, and easy to avoid. Signed-off-by: Richard Henderson Signed-off by: Stefan Weil --- tci.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tci.c b/tci.c index 77e0980..70f8308 100644 --- a/tci.c +

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 08:18:52PM +0200, Paolo Bonzini wrote: > Il 11/04/2013 19:14, Peter Maydell ha scritto: > > On 11 April 2013 18:09, Paolo Bonzini wrote: > >> Il 11/04/2013 18:28, Peter Maydell ha scritto: > >>> On 11 April 2013 17:10, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonz

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > ... so that on reboot BIOS could read current available CPU count > > Signed-off-by: Igor Mammedov > v2: > * s/qemu_register_cpu_add_notifier()/qemu_register_cpu_added_notifier()/ > --- > hw/timer/mc146818rtc.c | 12

Re: [Qemu-devel] [PATCH 0/3] Release SMP restriction on Windows host

2013-04-11 Thread Stefan Weil
On 09.04.2013 18:16, Paolo Bonzini wrote: Reviewed-by: Paolo Bonzini Do we need an additional Signed-off from the author (Olivier Hainque)? Currently, only Fabien signed these patches. I'm preparing a pull request and was not sure about this point. Regards, Stefan W.

[Qemu-devel] [PATCH 5/5] tci: Make tcg temporaries local to tcg_qemu_tb_exec

2013-04-11 Thread Stefan Weil
From: Richard Henderson We're moving away from the temporaries stored in env. Make sure we can differentiate between temp stores and possibly bogus stores for extra call arguments. Move TCG_AREG0 and TCG_REG_CALL_STACK out of the way of the parameter passing registers. Signed-off-by: Richard H

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 11:44 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 11:18:56AM -0400, Michael R. Hines wrote: First of all, I know it's a hard habit to break but could you please stop stop top-posting? Acknowledged. this whole argument should not even exist for the following reason:

Re: [Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:45PM +0200, Igor Mammedov wrote: > hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini Have you considered making a generic device creation/realization notification mechanism, that c

[Qemu-devel] [PATCH 2/5] tci: Use a local variable for env

2013-04-11 Thread Stefan Weil
From: Richard Henderson Since we have total conversion away from global AREG0, we do not need a global variable named "env". Retain that name as the function parameter inside the interpreter. Signed-off-by: Richard Henderson Signed-off by: Stefan Weil --- tci.c |8 +--- 1 file change

Re: [Qemu-devel] [PATCH 05/19] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:44PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > cpus.c| 11 --- > include/sysemu/cpus.h | 3 +++ > qom/cpu.c | 2 ++ > stubs/Makefile.objs | 1 + > stubs/resume_vcpu.c | 6 ++ > 5 files changed,

Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > ... to synchronize CPU state to KVM > > Signed-off-by: Igor Mammedov > --- > v2: > * linking kvm-stub.o to *-user target moved in separate patch > --- > include/sysemu/kvm.h | 18 ++ > kvm-all.c| 1 +

[Qemu-devel] listing "bus" option in output of "qemu -device $devname, ?"

2013-04-11 Thread Laine Stump
I was just talking to Michael Tsirkin on IRC about determining which devices accepted a "bus" option, and asked why this option doesn't show up in the output of "qemu -device $devname,?" (as happens for addr, etc). He said this is an old bug, and asked that I send mail to the list as a reminder tha

[Qemu-devel] [RFC 02/13] dataplane/virtio-blk: check exit conditions before aio_poll()

2013-04-11 Thread Stefan Hajnoczi
Check exit conditions before entering blocking aio_poll(). This is mainly for consistency since it's unlikely that we are stopping in the first event loop iteration. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) dif

[Qemu-devel] [RFC 10/13] block/sheepdog: drop have_co_req() and aio_flush_request()

2013-04-11 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop have_co_req() and aio_flush_request(). Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 25 + 1 file changed, 5 insertions(+), 20 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 987018e..44973b3 100644 ---

[Qemu-devel] [RFC 03/13] aio: stop using .io_flush()

2013-04-11 Thread Stefan Hajnoczi
Now that bdrv_drain_all() checks that requests are pending before calling qemu_aio_wait(), it is no longer necessary to call .io_flush() handlers. Behavior of aio_poll() changes as follows: .io_flush() is no longer invoked and file descriptors are *always* monitored. Previously returning 0 from

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 19:14, Peter Maydell ha scritto: > On 11 April 2013 18:09, Paolo Bonzini wrote: >> Il 11/04/2013 18:28, Peter Maydell ha scritto: >>> On 11 April 2013 17:10, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini >>> This doesn't look right. The MemoryRegion system isn't >>> hw-sp

[Qemu-devel] [PATCH 1/5] tci: Use 32-bit signed offsets to loads/stores

2013-04-11 Thread Stefan Weil
From: Richard Henderson Since the change to tcg_exit_req, the first insn of every TB is a load with a negative offset from env. Signed-off-by: Richard Henderson Signed-off by: Stefan Weil --- tcg/tci/tcg-target.c |4 ++-- tci.c| 36 ++-- 2

[Qemu-devel] [PATCH 4/5] tci: Delete unused tb_ret_addr

2013-04-11 Thread Stefan Weil
From: Richard Henderson Signed-off-by: Richard Henderson Signed-off by: Stefan Weil --- tcg/tci/tcg-target.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tcg/tci/tcg-target.c b/tcg/tci/tcg-target.c index a85095c..b096a84 100644 --- a/tcg/tci/tcg-target.c +++ b/tc

[Qemu-devel] [PULL] Fixes and minor improvements to TCI

2013-04-11 Thread Stefan Weil
Hello Anthony, please pull these five patches for TCI. They fix a regression caused by commit 378df4b23753a11be650af7664ca76bc75cb9f01 and include some improvements. Thanks, Stefan Weil The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no

[Qemu-devel] [RFC 05/13] block/gluster: drop qemu_gluster_aio_flush_cb()

2013-04-11 Thread Stefan Hajnoczi
Since .io_flush() is no longer called we do not need qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count is unused now and can be dropped. Signed-off-by: Stefan Hajnoczi --- block/gluster.c | 16 +--- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/bl

[Qemu-devel] [PATCH 04/12] Fix failure to create q35 machine

2013-04-11 Thread Paolo Bonzini
From: Hu Tao This is a regression introduced by c0907c9e6417c. How to reproduce: $ qemu-system-x86_64 -nodefaults -vnc :0 -M q35 qemu-system-x86_64: Unknown device 'q35-pcihost' for default sysbus Aborted (core dumped) Tested-by: Markus Armbruster Signed-off-by: Hu Tao --- default-configs/i3

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 17:35, Michael R. Hines ha scritto: > Nevertheless, the initial "burst" of the bulk phase round is still > important to optimize, and I would like to know if the maintainer > would accept this API for disabling the scan or not I'm not a maintainer, but every opinion counts... and my

Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter

2013-04-11 Thread Markus Armbruster
Rats, forgot --subject-prefix="PATCH v2". My apologies!

[Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-11 Thread Igor Mammedov
... to synchronize CPU state to KVM Signed-off-by: Igor Mammedov --- v2: * linking kvm-stub.o to *-user target moved in separate patch --- include/sysemu/kvm.h | 18 ++ kvm-all.c| 1 + kvm-stub.c | 1 + qom/cpu.c| 4 vl.c

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 11:44 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 11:18:56AM -0400, Michael R. Hines wrote: First of all, I know it's a hard habit to break but could you please stop stop top-posting? this whole argument should not even exist for the following reason: Page registratio

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 16:35, Michael R. Hines ha scritto: > Can I at least get a firm yes or no whether the maintainer will > accept this capability or not? > > What you ask would require defining what a "real world scenario" is, A TPC benchmark would be a real world scenario. > and I don't think that's

Re: [Qemu-devel] VFIO-VGA Issue

2013-04-11 Thread deniv
> On Wed, 2013-04-10 at 16:32 -0400, de...@lavabit.com wrote: >> >> However, turning gfx_passthru off did >> >> the trick. Win7 started loading with cirrus and switched to HD7750 >> >> halfway >> >> through boot proccess. I didn't do any testing just let Windows >> >> calculate >> >> its score. The

[Qemu-devel] [PATCH 06/12] tpm: reorganize headers and split hardware part

2013-04-11 Thread Paolo Bonzini
The TPM subsystem does not have a full front-end/back-end separation. The sole available backend, tpm_passthrough, depends on the data structures of the sole available frontend, tpm_tis. However, we can at least try to split the user interface (tpm.c) from the implementation (hw/tpm). The patches

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Michael R. Hines
On 04/11/2013 08:36 AM, Orit Wasserman wrote: On 04/11/2013 03:30 PM, Eric Blake wrote: On 04/11/2013 01:52 AM, Orit Wasserman wrote: On 04/11/2013 05:39 AM, Michael R. Hines wrote: On 04/10/2013 10:26 PM, Eric Blake wrote: New QMP commands should be named with '-' rather than '_', as in 'mig

Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter

2013-04-11 Thread Markus Armbruster
Blue Swirl writes: > On Thu, Mar 14, 2013 at 5:49 PM, Markus Armbruster wrote: >> This should unbreak "make check" on machines where char is unsigned. >> Blue, please give it a whirl. > > Patches no longer apply, please rebase. Sent.

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 04:50:21PM +0200, Paolo Bonzini wrote: Il 11/04/2013 16:37, Michael S. Tsirkin ha scritto: pg1 -> pin -> req -> res -> rdma -> done pg2 -> pin -> req -> res -> rdma -> done pg3 -> pin -> req ->

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 11:58 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 05:47:53PM +0200, Paolo Bonzini wrote: Il 11/04/2013 17:46, Michael S. Tsirkin ha scritto: Ok, let's keep it simple. The only two things we need are: 1) remove the patch to disable is_dup_page 2) rename the transport t

[Qemu-devel] [PATCH 14/19] target-i386: replace MSI_SPACE_SIZE with APIC_SPACE_SIZE

2013-04-11 Thread Igor Mammedov
... and put APIC_SPACE_SIZE in public header so that it could be reused later elsewhere. Signed-off-by: Igor Mammedov --- hw/i386/kvm/apic.c | 2 +- hw/intc/apic.c | 2 +- hw/xen/xen_apic.c | 2 +- include/hw/i386/apic_internal.h | 2 -- target-i386/cp

[Qemu-devel] [RFC 08/13] block/nbd: drop nbd_have_request()

2013-04-11 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop nbd_have_request(). We cannot drop in_flight since it is still used by other block/nbd.c code. Signed-off-by: Stefan Hajnoczi --- block/nbd.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/block/nbd.c b/block/nbd.c inde

Re: [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:42PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > Makefile.target | 13 +++-- > include/hw/pci/msi.h | 2 ++ > include/sysemu/kvm.h | 4 ++-- > kvm-stub.c | 2 ++ > 4 files changed, 13 insertions(+), 8 deletions(-) > >

[Qemu-devel] [PATCH 06/19] introduce CPU hot-plug notifier

2013-04-11 Thread Igor Mammedov
hot-added CPU will be distributed to acpi_piix4, rtc_cmos and icc_bridge Signed-off-by: Igor Mammedov Reviewed-by: Paolo Bonzini --- v2: * move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug * remove get_firmware_id() since it belong to other patch --- include/sysemu/s

[Qemu-devel] [PATCH 09/12] memory: move core typedefs to qemu/typedefs.h

2013-04-11 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- include/exec/memory.h | 5 - include/qemu/typedefs.h | 4 target-ppc/kvm_ppc.h| 2 -- 3 files changed, 4 insertions(+), 7 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 2322732..9e88320 100644 --- a/include/exec/memor

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael R. Hines
On 04/11/2013 01:04 PM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 12:09:44PM -0400, Michael R. Hines wrote: Yes, that's correct. The agony is just delayed. The right thing to do in a future patch would be to pin as much as possible in advance before the bulk phase round even begins (usi

Re: [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:57PM +0200, Igor Mammedov wrote: > ... and leave links for not present CPUs empty. > > It will allow users to query for possible APIC IDs and use them > with cpu-add QMP command. > > Signed-off-by: Igor Mammedov I don't see anything wrong with having icc-bridge lin

Re: [Qemu-devel] [PATCH v2] rbd: add an asynchronous flush

2013-04-11 Thread Josh Durgin
On 04/11/2013 01:48 AM, Kevin Wolf wrote: Am 11.04.2013 um 10:02 hat Stefan Hajnoczi geschrieben: On Wed, Apr 10, 2013 at 07:03:39AM -0700, Josh Durgin wrote: On 04/02/2013 07:10 AM, Kevin Wolf wrote: Am 29.03.2013 um 21:03 hat Josh Durgin geschrieben: The existing bdrv_co_flush_to_disk imple

Re: [Qemu-devel] [RFC PATCH RDMA support v1: 10/13] introduce new command migrate_check_for_zero

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 18:02, Michael R. Hines ha scritto: > Alright, so here's a slightly different management decision > which tries to accomplish all the requests, > tell me if you like it: > > 1. QEMU starts up > 2. *if and only if* chunk registration is disabled > and *if and only* RDMA is enabled

[Qemu-devel] [PATCH 01/12] arm: fix location of some include files

2013-04-11 Thread Paolo Bonzini
From: Peter Maydell The recent rearrangement of include files had some minor errors: devices.h is not ARM specific and should not be in arm/ arm.h should be in arm/ Move these two headers to correct this. Signed-off-by: Peter Maydell --- hw/alpha/typhoon.c | 2 +- hw/a

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Peter Maydell
On 11 April 2013 18:09, Paolo Bonzini wrote: > Il 11/04/2013 18:28, Peter Maydell ha scritto: >> On 11 April 2013 17:10, Paolo Bonzini wrote: >>> > Signed-off-by: Paolo Bonzini >> This doesn't look right. The MemoryRegion system isn't >> hw-specific, it's a part of the basic QEMU emulation >> sy

[Qemu-devel] [RFC 04/13] block/curl: drop curl_aio_flush()

2013-04-11 Thread Stefan Hajnoczi
.io_flush() is no longer called so drop curl_aio_flush(). The acb[] array that the function checks is still used in other parts of block/curl.c. Therefore we cannot remove acb[], it is needed. Signed-off-by: Stefan Hajnoczi --- block/curl.c | 22 +++--- 1 file changed, 3 insert

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 18:28, Peter Maydell ha scritto: > On 11 April 2013 17:10, Paolo Bonzini wrote: >> > Signed-off-by: Paolo Bonzini > This doesn't look right. The MemoryRegion system isn't > hw-specific, it's a part of the basic QEMU emulation > system which provides functionality to hw/ and other >

Re: [Qemu-devel] [PATCH 12/12] hw: move memory API to hw/core

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 05:28:35PM +0100, Peter Maydell wrote: > On 11 April 2013 17:10, Paolo Bonzini wrote: > > Signed-off-by: Paolo Bonzini > > This doesn't look right. The MemoryRegion system isn't > hw-specific, it's a part of the basic QEMU emulation > system which provides functionality t

[Qemu-devel] [PATCH 07/12] sysemu: avoid proliferation of include/ subdirectories

2013-04-11 Thread Paolo Bonzini
Move all "simple" header files to include/sysemu. There is no need for separate directories. Plus, some were in include/qemu and some in include/backends. Signed-off-by: Paolo Bonzini --- backends/baum.c | 2 +- backends/msmouse.c

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Michael S. Tsirkin
On Thu, Apr 11, 2013 at 12:09:44PM -0400, Michael R. Hines wrote: > On 04/11/2013 11:44 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 11, 2013 at 11:18:56AM -0400, Michael R. Hines wrote: > >>First of all, > >I know it's a hard habit to break but could you > >please stop stop top-posting? > Acknowle

Re: [Qemu-devel] [PATCH 01/19] target-i386: split out CPU creation and features parsing into cpu_x86_create()

2013-04-11 Thread Eduardo Habkost
On Thu, Apr 11, 2013 at 04:51:40PM +0200, Igor Mammedov wrote: > Move CPU creation and features parsing into a separate cpu_x86_create() > function, so that board would be able to set board specific CPU > properties before CPU is realized. > > Keep cpu_x86_init() for compatibility with the code th

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-11 Thread Paolo Bonzini
Il 11/04/2013 17:46, Michael S. Tsirkin ha scritto: > > Ok, let's keep it simple. The only two things we need are: > > > > 1) remove the patch to disable is_dup_page > > > > 2) rename the transport to "x-rdma" (just in migration.c) > > > > Both things together let us keep it safe for a release

[Qemu-devel] [RFC 01/13] block: stop relying on io_flush() in bdrv_drain_all()

2013-04-11 Thread Stefan Hajnoczi
If a block driver has no file descriptors to monitor but there are still active requests, it can return 1 from .io_flush(). This is used to spin during synchronous I/O. Stop relying on .io_flush() and instead check QLIST_EMPTY(&bs->tracked_requests) to decide whether there are active requests. T

[Qemu-devel] [PATCH 4/4] qjson: to_json() case QTYPE_QSTRING is buggy, rewrite

2013-04-11 Thread Markus Armbruster
Known bugs in to_json(): * A start byte for a three-byte sequence followed by less than two continuation bytes is split into one-byte sequences. * Start bytes for sequences longer than three bytes get misinterpreted as start bytes for three-byte sequences. Continuation bytes beyond byte th

Re: [Qemu-devel] [PATCH 0/4] Fix JSON string formatter

2013-04-11 Thread Laszlo Ersek
On 04/11/13 18:07, Markus Armbruster wrote: > This should unbreak "make check" on machines where char is unsigned. > Blue, please give it a whirl. > > The JSON parser is still as broken as ever. Left for another day. > > v2: > - Rebased, trivial conflicts in PATCH 1/4. > - Make mod_utf8_codepoin

  1   2   3   >