[Qemu-devel] [Bug 778032] Re: qemu spinning on serial port writes

2013-04-12 Thread Michael R. Hines
I have a similar problem, and the problem goes away if I remove the "-serial pty" device from my command line: /home/mrhines/qemu/x86_64-softmmu/qemu-system-x86_64 /kvm_repo/cb/vmbase -serial pty Such a simple command line, but QEMU seizes up and slows to a crawl and the host CPU is spinning at 1

Re: [Qemu-devel] latest master: major slowdown (something spinning?)

2013-04-12 Thread Michael R. Hines
OK, I pinned down the spinning to a specific device: A serial PTY device. Here's a very easy way to reproduce: qemu-system-x86_64 disk.qed -serial pty (VM is running RHEL 6.1) If I add '-serial pty' to my command line, it spins until it prints: main-loop: WARNING: I/O thread spun for 1000 iter

Re: [Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level

2013-04-12 Thread Eric Blake
On 04/12/2013 02:47 PM, Kevin Wolf wrote: > Specifying the wrong driver could fail an assertion: > > $ qemu-system-x86_64 -drive file.driver=qcow2,file=x > qemu-system-x86_64: block.c:721: bdrv_open_common: Assertion `file != > ((void *)0)' failed. > > Signed-off-by: Kevin Wolf > --- > block.c

[Qemu-devel] [RFC PATCH v2 11/11] QMP/qmp.py: set locale for exceptions to display non-ascii messages correctly

2013-04-12 Thread Tomoki Sekiyama
qemu-ga in Windows might return error message with multibyte characters when the guest OS language is set to other than English. To display such messages correctly, this decodes the message based on locale settings. Signed-off-by: Tomoki Sekiyama --- QMP/qmp.py |4 +++- 1 file changed, 3 ins

[Qemu-devel] [RFC PATCH v2 10/11] QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze command

2013-04-12 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 30 seconds. Signed-off-by: Tomoki Sekiyama --- QMP/qemu-ga-client |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/QMP/qe

[Qemu-devel] [RFC PATCH v2 05/11] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-04-12 Thread Tomoki Sekiyama
Implements a basic stub of software VSS provider. Currently, this modules only provides a relay function of events between qemu-guest-agent and Windows VSS when VSS finished filesystem freeze and when qemu snapshot is done. In the future, this module could be extended to support the other VSS func

[Qemu-devel] lsi_soft_reset: Assertion `!s->current' failed with Windows XP setup

2013-04-12 Thread Claudio Bley
Hi. I'm using the latest qemu release 1.4.0 and libvirt 1.0.4. The host system is a Ubuntu 12.04 LTS system, Intel Xeon processor, 4GB RAM. When trying to install Windows XP I constantly receive this error (usually right before the graphical Setup is started). Once, I've seen this error too: hw

[Qemu-devel] [RFC PATCH v2 08/11] qemu-ga: install Windows VSS provider on `qemu-ga -s install'

2013-04-12 Thread Tomoki Sekiyama
Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama --- qga/main.c |8 1 file changed, 8 insertions(+) diff --gi

[Qemu-devel] qemu-img: error while compressing, Input/output error

2013-04-12 Thread Ilkka Tengvall
I run into an issue where qemu-img convert fails repeatedly on compressing a raw disk image. It's not all broken, since it many times also works. When it fails, it fails always to the same sector. I run into problem using f18 qemu-img-1.2.2-6.fc18.x86_64, and repeated it with the latest qemu-i

[Qemu-devel] [RFC PATCH v2 06/11] qemu-ga: Add Windows VSS requester to quisce applications and filesystems

2013-04-12 Thread Tomoki Sekiyama
This adds VSS requester functions for to qemu-ga. This provides facility to request VSS service in Windows guest to quisce applications and filesystems. This function is only supported in Windows 2003 or later. In older guests, this function does nothing. Signed-off-by: Tomoki Sekiyama --- qga/M

Re: [Qemu-devel] [PATCH 0/3] Release SMP restriction on Windows host

2013-04-12 Thread Olivier Hainque
On Apr 12, 2013, at 08:40 , Paolo Bonzini wrote: >> Do we need an additional Signed-off from the author (Olivier Hainque)? >> Currently, only Fabien signed these patches. > > In theory yes, in practice they are colleagues so I think it's fine. We are colleagues indeed and there's no problem h

[Qemu-devel] [RFC PATCH v2 04/11] qemu-ga: Add an configure option to specify path to Windows VSS SDK

2013-04-12 Thread Tomoki Sekiyama
To enable VSS support in qemu-ga for Windows, header files included in VSS SDK is required. The VSS support is enabled when the option like below: ./configure --with-vss-sdk="/pass/to/VSS SDK" VSS SDK is available from: http://www.microsoft.com/en-us/download/details.aspx?id=23490 To cross-co

[Qemu-devel] [RFC PATCH v2 07/11] qemu-ga: call Windows VSS requester in fsfreeze command handler

2013-04-12 Thread Tomoki Sekiyama
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows guests. When fsfreeze command is issued, it calls the VSS requester to freeze filesystems and applications. On thaw command, it again tells the VSS requester to thaw them. This also adds calling of initialize functions for

[Qemu-devel] [RFC PATCH v2 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-04-12 Thread Tomoki Sekiyama
Hi, This patch series is attempts to add fsfreeze support for Windows qemu-guest-agent. changes from v1: - Fix out-tree build by stop using recursive Makefile - Added script to extract VSS SDK headers on POSIX systems using msitools (thanks Paolo) - Remove some unnecessary header files v1

[Qemu-devel] [RFC PATCH v2 03/11] Add a script to extract VSS SDK headers on POSIX system

2013-04-12 Thread Tomoki Sekiyama
VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Tomoki Sekiyama --- scripts/extract-vsssdk-headers | 25 ++

[Qemu-devel] [RFC PATCH v2 09/11] qemu-ga: Add VSS provider .tlb file in the repository

2013-04-12 Thread Tomoki Sekiyama
To build type library (.tlb) for qga-provider.dll from COM IDL (.idl), MIDL in VisualC++ and stdole2.tlb in Windows SDK are required. This patch adds pre-compiled .tlb file in the repository in order to enable cross-compile qemu-ga.exe for Windows with VSS support. Signed-off-by: Tomoki Sekiyama

[Qemu-devel] [RFC PATCH v2 02/11] Fix errors and warnings while compiling with c++ compilier

2013-04-12 Thread Tomoki Sekiyama
Add C++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama --- hmp.c |2 +- hw/pci/pci.c|2 +- scripts/qapi.py |9 - 3 files changed, 10 insertions(+), 3 deletions(-

[Qemu-devel] [RFC PATCH v2 01/11] configure: Support configuring c++ compiler

2013-04-12 Thread Tomoki Sekiyama
Add configuration for c++ compiler (${corss_prefix}g++ as default) in configure and Makefiles. Currently, usage of c++ language is only for access to Windows VSS using COM+ services in qemu-guest-agent for Windows. Signed-off-by: Tomoki Sekiyama --- configure |6 ++ rules.mak |9 +++

[Qemu-devel] QEMU Exception Handling

2013-04-12 Thread Anand Brooks
Hello All, I ran into an error when testing some code that would generate protection faults. I had my exception handler setup so that it expected the EIP and Stack not to change, standard behavior on native CPU. But on QEMU both the ESP and EIP are changed at fault generation time. The OS is 32-b

[Qemu-devel] [PATCH v2] tpm: Move TPM passthrough specific command line options to backend structure

2013-04-12 Thread Stefan Berger
Move the TPM passthrough specific command line options to the passthrough backend implementation and attach them to the backend's interface structure. Add code to tpm.c for validating the TPM command line options. Signed-off-by: Stefan Berger --- tpm/tpm.c |8 tpm/tpm_

[Qemu-devel] [PATCH v2 7/8] rdma: print out throughput while debugging

2013-04-12 Thread mrhines
From: "Michael R. Hines" It's very helpful when debugging to print out migration throughput after each iteration round to compare the different migration technologies. Signed-off-by: Michael R. Hines --- migration.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 4/8] rdma: introduce capability for chunk registration

2013-04-12 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. Hines --- include/migration/migration.h |2 ++ migration.c | 11 ++- q

[Qemu-devel] [PATCH v2 6/8] rdma: send pc.ram

2013-04-12 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Signed-off-by: Michael R. Hines --- arch_init.c | 35 +++

[Qemu-devel] [PATCH v2 2/8] rdma: new QEMUFileOps hooks

2013-04-12 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v2 8/8] rdma: add documentation

2013-04-12 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Signed-off-by: Michael R. Hines --- docs/rdma.txt | 336 + 1 file changed, 336 insertions(+) create mode 100644 docs/rdm

[Qemu-devel] [PATCH v2 3/8] rdma: export ram_handle_compressed()

2013-04-12 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Signed-off-by: Michael R. Hines --- arch_init.c | 24 include/migration/migration.h |1 + 2 files changed, 17 i

[Qemu-devel] [PATCH v2 1/8] rdma: introduce qemu_ram_foreach_block

2013-04-12 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Signed-off-by: Michael R. Hines --- exec.c|9 + include/exec/cpu-common.h |5

[Qemu-devel] [PATCH v2 0/8] rdma: migration support

2013-04-12 Thread mrhines
From: "Michael R. Hines" Changes since v1: - Finished additional cleanup requests - Introduced COMPRESS command to zap zeros Wiki: http://wiki.qemu.org/Features/RDMALiveMigration Github: g...@github.com:hinesmr/qemu.git Michael R. Hines (10): rdma: introduce qemu_ram_foreach_block rdma: ne

[Qemu-devel] [PATCH 13/15] vvfat: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/vvfat.c | 210 +++--- 1 file changed, 158 insertions(+), 52 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index ef74c30..ac56421 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -28,6 +28,8 @@ #in

[Qemu-devel] [PATCH 11/15] rbd: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the "filename" to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf --- block/rbd.c | 31 ++- 1 file changed,

[Qemu-devel] [PATCH 10/15] iscsi: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the "filename" to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf --- block/iscsi.c | 39 +-- 1 file

[Qemu-devel] [PATCH 07/15] blkverify: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/blkverify.c | 94 --- 1 file changed, 76 insertions(+), 18 deletions(-) diff --git a/block/blkverify.c b/block/blkverify.c index 59e3b05..37806e3 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -69,

[Qemu-devel] [PATCH 06/15] blkdebug: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/blkdebug.c | 103 +-- 1 file changed, 77 insertions(+), 26 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 37cfbc7..da11de2 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -273,11

[Qemu-devel] [PATCH 04/15] raw-posix: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/raw-posix.c | 57 +++ 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 99ac869..9b7bc9c 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -262

[Qemu-devel] [PATCH 14/15] block: Remove filename parameter from .bdrv_file_open()

2013-04-12 Thread Kevin Wolf
It is unused now in all block drivers. Signed-off-by: Kevin Wolf --- block.c | 8 ++-- block/blkdebug.c | 3 +-- block/blkverify.c | 3 +-- block/curl.c | 3 +-- block/gluster.c | 4 ++-- block/iscsi.c | 5 ++--- blo

[Qemu-devel] [PATCH 03/15] block: Enable filename option

2013-04-12 Thread Kevin Wolf
This allows using the file.filename option instead of the string that comes from -drive file=... and is passed around as a separate parameter. The goal is to get rid of this parameter and use the options QDict more consistently. With this option you can access not only the top-level image, but spe

[Qemu-devel] [PATCH 15/15] block: Allow overriding backing.file.filename

2013-04-12 Thread Kevin Wolf
If a filename is passed in the driver-specific options from the command line, the backing file path from the image is ignored now. Signed-off-by: Kevin Wolf --- block.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index c2d1d2d..3a45c2a 100644 --- a/bl

[Qemu-devel] [PATCH 09/15] gluster: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the "filename" to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf --- block/gluster.c | 32 +++- 1 file chan

[Qemu-devel] [PATCH 05/15] raw-win32: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/raw-win32.c | 57 +-- 1 file changed, 47 insertions(+), 10 deletions(-) diff --git a/block/raw-win32.c b/block/raw-win32.c index ece2f1a..49d9234 100644 --- a/block/raw-win32.c +++ b/block/raw-win32.c @@ -221

[Qemu-devel] [PATCH 01/15] block: Fail gracefully when using a format driver on protocol level

2013-04-12 Thread Kevin Wolf
Specifying the wrong driver could fail an assertion: $ qemu-system-x86_64 -drive file.driver=qcow2,file=x qemu-system-x86_64: block.c:721: bdrv_open_common: Assertion `file != ((void *)0)' failed. Signed-off-by: Kevin Wolf --- block.c| 7 +++ tests/qemu-iotests/051

[Qemu-devel] [PATCH 08/15] curl: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/curl.c | 153 +++ 1 file changed, 102 insertions(+), 51 deletions(-) diff --git a/block/curl.c b/block/curl.c index 186e3b0..61bc3db 100644 --- a/block/curl.c +++ b/block/curl.c @@ -335,12 +335,9 @@ stati

[Qemu-devel] [PATCH 12/15] sheepdog: Use bdrv_open options instead of filename

2013-04-12 Thread Kevin Wolf
This is only to convert the internal interface that is used for passing the "filename" to be parsed, but converting to actual fine grained options is left for another day, as it doesn't look trivial. Signed-off-by: Kevin Wolf --- block/sheepdog.c | 32 +++- 1 file cha

[Qemu-devel] [PATCH 02/15] block: Add driver-specific options for backing files

2013-04-12 Thread Kevin Wolf
Options starting in "backing." are passed to the backing file now. If you don't need to specify the filename for the backing file, you can add it on the command line instead of in the image file: $ qemu-nbd -t /tmp/test.img $ qemu-img create -f qcow2 empty.qcow2 1G $ qemu-system-x86_64 -drive file

[Qemu-devel] [PATCH 00/15] block: Overriding the backing file with -drive

2013-04-12 Thread Kevin Wolf
This is the next part of the driver-specific options. Looks like we're getting closer to pass file descriptors for the whole backing file chain. In fact, I hope we're now only lacking QMP support before we can actually use it. :-) This series adds support for the backing.* options namespace, and a

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Stefan Weil
Am 12.04.2013 22:23, schrieb Alexey Kardashevskiy: > On 04/13/2013 03:36 AM, Stefan Weil wrote: >> Am 12.04.2013 18:47, schrieb David Gibson: >>> On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote: Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: > The bswap functions use mem

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Alexey Kardashevskiy
On 04/13/2013 03:36 AM, Stefan Weil wrote: Am 12.04.2013 18:47, schrieb David Gibson: On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote: Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: The bswap functions use memcpy but the bswap.h header itself does not seem to include it in s

Re: [Qemu-devel] [PATCH] qemu-img: refuse to compress files with invalid size

2013-04-12 Thread Eric Blake
On 04/12/2013 01:55 PM, Benoît Canet wrote: > Le Friday 12 Apr 2013 à 19:37:48 (+0200), Stefan Hajnoczi a écrit : >> Image file compression works at cluster granularity. It is not possible >> to compress less than a cluster of data at a time. Shouldn't it be possible to treat a file that is not r

Re: [Qemu-devel] [PATCH] qemu-img: refuse to compress files with invalid size

2013-04-12 Thread Benoît Canet
Le Friday 12 Apr 2013 à 19:37:48 (+0200), Stefan Hajnoczi a écrit : > Image file compression works at cluster granularity. It is not possible > to compress less than a cluster of data at a time. > > Print an error when attempting qemu-img convert -c with an input file > that is not a multiple of

Re: [Qemu-devel] [PATCH 03/19] cpu: make kvm-stub.o a part of CPU library

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 01:17:32PM +0200, Igor Mammedov wrote: [...] > > > > > #include "qemu-common.h" > > > #include "hw/pci/pci.h" > > > > > > @@ -47,4 +48,5 @@ static inline bool msi_present(const PCIDevice *dev) > > > return dev->cap_present & QEMU_PCI_CAP_MSI; > > > } > > > > > >

[Qemu-devel] [PATCH] Remove unneeded type casts

2013-04-12 Thread Stefan Weil
cpu_physical_memory_read, cpu_physical_memory_write take any pointer as 2nd argument without needing a type cast. Signed-off-by: Stefan Weil --- hw/arm/armv7m.c| 12 ++-- hw/arm/boot.c |4 ++-- hw/arm/musicpal.c |8 hw/arm/nseries.c

[Qemu-devel] [PATCH] qemu-img: refuse to compress files with invalid size

2013-04-12 Thread Stefan Hajnoczi
Image file compression works at cluster granularity. It is not possible to compress less than a cluster of data at a time. Print an error when attempting qemu-img convert -c with an input file that is not a multiple of the cluster size. I considered automatically adjusting the output file size b

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Stefan Weil
Am 12.04.2013 18:47, schrieb David Gibson: > On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote: >> Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: >>> The bswap functions use memcpy but the bswap.h header itself does not seem >>> to >>> include it in some configuration such as cros

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread David Gibson
On Fri, Apr 12, 2013 at 12:51:51PM +0200, Andreas Färber wrote: > Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: > > The bswap functions use memcpy but the bswap.h header itself does not seem > > to > > include it in some configuration such as cross compiling for powerpc64 > > on x86_64 machin

[Qemu-devel] [PATCH 4/4] qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32

2013-04-12 Thread Stefan Weil
From: Paolo Bonzini These are needed for any of the Win32 alarm timer implementations. They are not tied to mmtimer exclusively. Jacob tested this patch with both mmtimer and Win32 timers. Cc: qemu-sta...@nongnu.org Tested-by: Jacob Kroon Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Wei

[Qemu-devel] [PATCH 2/4] Ensure good ordering of memory instruction in cpu_exec

2013-04-12 Thread Stefan Weil
From: Olivier Hainque The IO thread, when it senses cpu_single_env == 0, expects exit_request to be checked later on. A compiler scheduling constraint is not strong enough to ensure this on modern architecture. A memory fence is needed as well. Signed-off-by: Olivier Hainque Signed-off-by: Fabi

[Qemu-devel] [PATCH 3/4] Release SMP restriction on Windows

2013-04-12 Thread Stefan Weil
From: Fabien Chouteau The previous patches make QEMU SMP safe on Windows, we can now release the restriction. Signed-off-by: Fabien Chouteau Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Weil --- os-win32.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/os-win32.

[Qemu-devel] [PULL 0/4] MinGW patches for QEMU

2013-04-12 Thread Stefan Weil
Hello Anthony, please pull these patches for QEMU git master. All of them were reviewed on qemu-devel. Thanks, Stefan W. The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge (2013-04-09 07:47:00 -0

[Qemu-devel] [PATCH 1/4] Check effective suspension of TCG thread

2013-04-12 Thread Stefan Weil
From: Olivier Hainque On multi-core systems, SuspendThread does not guaranty immediate thread suspension. We add busy loop to wait for effective thread suspension after call to ThreadSuspend(). Signed-off-by: Fabien Chouteau Reviewed-by: Paolo Bonzini Signed-off-by: Stefan Weil --- cpus.c |

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 05:46:42PM +0200, Igor Mammedov wrote: > On Fri, 12 Apr 2013 10:13:13 -0300 > Eduardo Habkost wrote: [...] > > > > > +static void x86_cpuid_set_apic_id(Object *obj, Visitor *v, void > > > > > *opaque, > > > > > + const char *name, Error **e

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2013 12:35:14 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 05:16:20PM +0200, Igor Mammedov wrote: > > On Fri, 12 Apr 2013 10:35:53 -0300 > > Eduardo Habkost wrote: > > > > > On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > > > > On Thu, 11 Apr 2013 15:59

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2013 10:13:13 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 12:20:45PM +0200, Igor Mammedov wrote: > > On Thu, 11 Apr 2013 16:12:33 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > > > ... and use it from board

[Qemu-devel] [PATCH] fpu: Correct edgecase in float64_muladd

2013-04-12 Thread Peter Maydell
In handling float64_muladd, if we end up doing a subtraction of the product and c, and the 128 bit result of this subtraction happens to have its most significant bit in bit 63, we weren't handling this correctly when attempting to normalize to put the most significant bit into bit 126. We would e

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 05:16:20PM +0200, Igor Mammedov wrote: > On Fri, 12 Apr 2013 10:35:53 -0300 > Eduardo Habkost wrote: > > > On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > > > On Thu, 11 Apr 2013 15:59:40 -0300 > > > Eduardo Habkost wrote: > > > > > > > On Thu, Apr 11, 2

Re: [Qemu-devel] Use of flash for x86 BIOS

2013-04-12 Thread Markus Armbruster
Jordan Justen writes: > On Fri, Mar 22, 2013 at 12:48 PM, Markus Armbruster wrote: >> Jordan Justen writes: >> >>> On Thu, Mar 21, 2013 at 12:45 AM, Markus Armbruster >>> wrote: x86 maintainers may wish to *switch it off* until it's done fully and properly, by setting "pc-sysfw" prop

[Qemu-devel] [PATCH 3/3] pc: Kill the "use flash device for BIOS unless KVM" misfeature

2013-04-12 Thread Markus Armbruster
Use of a flash memory device for the BIOS was added in series "[PATCH v10 0/8] PC system flash support", commit 4732dca..1b89faf, v1.1. Flash vs. ROM is a guest-visible difference. Thus, flash use had to be suppressed for machine types pc-1.0 and older. This was accomplished by adding a dummy de

[Qemu-devel] [PATCH 1/3] pc: Inline pc_init_pci_1_3() into pc_init_pci_1_2()

2013-04-12 Thread Markus Armbruster
Just to make the commit after next easier to review. Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cff8013..da34d3b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@

[Qemu-devel] [PATCH 2/3] pc: Split pc_init_pci_1_0() off pc_init_pci_1_2()

2013-04-12 Thread Markus Armbruster
Just to make the next commit easier to review. Signed-off-by: Markus Armbruster --- hw/i386/pc_piix.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index da34d3b..f2d3d27 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc

[Qemu-devel] [PATCH 0/3] Kill the "use flash device for BIOS unless KVM" misfeature

2013-04-12 Thread Markus Armbruster
See PATCH 3/3 for description, the other two are trivial preliminaries to simplify review. Markus Armbruster (3): pc: Inline pc_init_pci_1_3() into pc_init_pci_1_2() pc: Split pc_init_pci_1_0() off pc_init_pci_1_2() pc: Kill the "use flash device for BIOS unless KVM" misfeature hw/block/pc

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Igor Mammedov
On Fri, 12 Apr 2013 10:35:53 -0300 Eduardo Habkost wrote: > On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > > On Thu, 11 Apr 2013 15:59:40 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > > > > ... so that on reboot BIO

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 13:25, Michael S. Tsirkin ha scritto: > On Fri, Apr 12, 2013 at 12:53:11PM +0200, Paolo Bonzini wrote: >> Il 12/04/2013 12:48, Michael S. Tsirkin ha scritto: >>> 1. You have two protocols already and this does not make sense in >>> version 1 of the patch. >> >> It makes sense if we c

[Qemu-devel] [PATCH 3/4] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Minor fixes to documentation and code comments. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- docs/bootindex.txt | 10 +- docs/ccid.txt | 2 +- hw/block/virtio-blk.c | 4 ++-- hw/intc/armv7m_nvic.c | 2 +- hw/s390

[Qemu-devel] [PATCH 4/4] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() call, which is a pretty trivial cost even for something in the main cpu_exec() loop. Having this be conditionally defined means that '-d exec' on a non-debug build will silently do nothing. Drop the define an

[Qemu-devel] [PATCH 2/4] linux-user: pass correct host flags to eventfd2 call

2013-04-12 Thread Stefan Hajnoczi
From: Petar Jovanovic This change makes conversion of TARGET_O_NONBLOCK and TARGET_O_CLOEXEC flags to host flags before calling eventfd for TARGET_NR_eventfd2. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/syscall.c | 11 ++-

[Qemu-devel] [PATCH 1/4] target-moxie: Fix VMState registration

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), rather than doing it in two different wrong ways (once by providing cpu_save and cpu_load functions, and once by setting the vmsd field in DeviceClass). Signed-off-by: Peter Maydell Reviewed-by: Andreas F

[Qemu-devel] [PULL v2 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
v2: * Andreas Färber noticed my patch scripts aren't unicode safe, fix his name The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge (2013-04-09 07:47:00 -0500) are available in the git repository

Re: [Qemu-devel] [PATCH 04/19] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 01:34:09PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 15:33:01 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:43PM +0200, Igor Mammedov wrote: > > > ... to synchronize CPU state to KVM > > > > > > Signed-off-by: Igor Mammedov > > > --- > > > v2

[Qemu-devel] [PULL 3/3] qapi: use valid JSON in schema

2013-04-12 Thread Luiz Capitulino
From: Eric Blake * qapi-schema.json: JSON doesn't allow trailing commas. Signed-off-by: Eric Blake Signed-off-by: Luiz Capitulino --- qapi-schema.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index a184ce6..751d3c2 100644 --- a/qa

[Qemu-devel] [PULL 2/3] Revert "New QMP command query-cpu-max and HMP command cpu_max"

2013-04-12 Thread Luiz Capitulino
From: Michal Novotny This reverts commit 4d700430a20b3d53b7b15bc5ff7e570e3f2c as asked by Luiz. The patch has been obsoleted by extending MachineInfo structure by cpu-max field. Signed-off-by: Michal Novotny Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 2

[Qemu-devel] [PULL 1/3] New cpu-max field in query-machines QMP command output

2013-04-12 Thread Luiz Capitulino
From: Michal Novotny Alter the query-machines QMP command to output information about maximum number of CPUs for each machine type with default value set to 1 in case the number of max_cpus is not set. Signed-off-by: Michal Novotny Reviewed-by: Eric Blake Signed-off-by: Luiz Capitulino --- q

[Qemu-devel] [PULL 0/3] QMP queue

2013-04-12 Thread Luiz Capitulino
The changes (since 93b48c201eb6c0404d15550a0eaa3c0f7937e35e) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Eric Blake (1): qapi: use valid JSON in schema Michal Novotny (2): New cpu-max field in query-machines QMP command output Revert "New

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Michael R. Hines
On 04/12/2013 09:41 AM, Paolo Bonzini wrote: Il 12/04/2013 15:29, Michael R. Hines ha scritto: Oh, thank you. Huge bug - I need to introduce a "COMPRESS" message for this page into the protocol just like we already have for TCP and bypass the current chunk. It's okay to send the page uncompres

Re: [Qemu-devel] [PATCH 08/19] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:31:22PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 16:04:26 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:47PM +0200, Igor Mammedov wrote: > > > get_arch_id() adds possibility for generic code to get guest visible > > > CPI id without accessi

Re: [Qemu-devel] [RFC PATCH RDMA support v5: 03/12] comprehensive protocol documentation

2013-04-12 Thread Michael R. Hines
On 04/12/2013 06:48 AM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 04:33:03PM -0400, Michael R. Hines wrote: On 04/11/2013 03:15 PM, Michael S. Tsirkin wrote: On Thu, Apr 11, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: On 04/11/2013 10:56 AM, Michael S. Tsirkin wrote: On Thu, Apr

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Paolo Bonzini
Il 12/04/2013 15:29, Michael R. Hines ha scritto: > > Oh, thank you. Huge bug - I need to introduce a "COMPRESS" > message for this page into the protocol just like we already have > for TCP and bypass the current chunk. It's okay to send the page uncompressed if it's been registered already. T

Re: [Qemu-devel] [RFC 00/13] aio: drop io_flush()

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 2:22 PM, Kevin Wolf wrote: > Am 12.04.2013 um 14:06 hat Stefan Hajnoczi geschrieben: >> On Fri, Apr 12, 2013 at 12:27 PM, Paolo Bonzini wrote: >> > Il 12/04/2013 12:04, Kevin Wolf ha scritto: >> >> Or actually, if you want to avoid .bdrv_drain for now, the patch that I >>

Re: [Qemu-devel] [PATCH 07/19] rtc: update rtc_cmos on CPU hot-plug

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:53:51PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 15:59:40 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:46PM +0200, Igor Mammedov wrote: > > > ... so that on reboot BIOS could read current available CPU count > > > > > > Signed-off-by: Igo

Re: [Qemu-devel] [PATCH 3/8] rdma: new QEMUFileOps hooks

2013-04-12 Thread Michael R. Hines
All good catches, acknowledged. On 04/12/2013 07:02 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: From: "Michael R. Hines" These are just the prototypes for optional new hooks that RDMA takes advantage of to perform dynamic page registration. An o

Re: [Qemu-devel] [PATCH 2/8] rdma: core rdma logic

2013-04-12 Thread Michael R. Hines
On 04/12/2013 07:10 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: + * + * If we're using dynamic registration on the server-side, we have to + * send a registration command first. + */ +static int __qemu_rdma_write(QEMUFile *f, RDMAContext *rdma, +i

Re: [Qemu-devel] [PATCH 11/19] target-i386: introduce apic-id property

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:20:45PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 16:12:33 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:50PM +0200, Igor Mammedov wrote: > > > ... and use it from board level to set APIC ID for CPUs > > > it creates. > > > > > > Signed-off

[Qemu-devel] [PATCH] virtio.h: drop unused function prototypes

2013-04-12 Thread Luiz Capitulino
They are unused since commit 5c7d0962f60498c3f11d402e1c857cb9d5d8568d. Signed-off-by: Luiz Capitulino --- include/hw/virtio/virtio.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 7e24b2b..2c57c47 100644 --- a/include/hw/virtio/

Re: [Qemu-devel] [PATCH] bswap: fix compiler warning

2013-04-12 Thread Alexey Kardashevskiy
On 04/12/2013 08:51 PM, Andreas Färber wrote: Am 12.04.2013 03:41, schrieb Alexey Kardashevskiy: The bswap functions use memcpy but the bswap.h header itself does not seem to include it in some configuration such as cross compiling for powerpc64 on x86_64 machine (gcc 4.6.3 from ftp.kernel.org,

Re: [Qemu-devel] [PATCH 4/8] rdma: implement new QEMUFileOps hooks

2013-04-12 Thread Michael R. Hines
On 04/12/2013 07:05 AM, Paolo Bonzini wrote: Il 12/04/2013 07:52, mrhi...@linux.vnet.ibm.com ha scritto: +void ram_control_load_hook(QEMUFile *f, uint32_t flags) +{ +int ret = 0; + +if (f->ops->hook_ram_load) { +qemu_fflush(f); +ret = f->ops->hook_ram_load(f, f->opaque, f

Re: [Qemu-devel] [PATCH 18/19] target-i386: expose all possible CPUs as /machine/icc-bridge/cpu[0..N] links

2013-04-12 Thread Eduardo Habkost
On Fri, Apr 12, 2013 at 12:01:03PM +0200, Igor Mammedov wrote: > On Thu, 11 Apr 2013 14:19:37 -0300 > Eduardo Habkost wrote: > > > On Thu, Apr 11, 2013 at 04:51:57PM +0200, Igor Mammedov wrote: > > > ... and leave links for not present CPUs empty. > > > > > > It will allow users to query for pos

Re: [Qemu-devel] [PULL 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
On Fri, Apr 12, 2013 at 2:23 PM, Stefan Hajnoczi wrote: > The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: > > virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge > (2013-04-09 07:47:00 -0500) > > are available in the git repository at: > > git:/

[Qemu-devel] Is FW_CFG_PPC_CPUFREQ deprecated?

2013-04-12 Thread Mark Cave-Ayland
Hi everyone, Has FW_CFG_PPC_CPUFREQ been removed from QEMU for some reason? I noticed that the value always comes back as 0 in OpenBIOS, and it looks as if the FW_CFG_PPC_CPUFREQ constant (FW_CFG_ARCH_LOCAL + 0x4) has been removed from hw/ppc.h? ATB, Mark.

[Qemu-devel] [PATCH 4/4] cpu-exec: Allow "-d exec" in non-debug builds (drop CONFIG_DEBUG_EXEC)

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell The CONFIG_DEBUG_EXEC define compiles out a single qemu_log_mask() call, which is a pretty trivial cost even for something in the main cpu_exec() loop. Having this be conditionally defined means that '-d exec' on a non-debug build will silently do nothing. Drop the define an

[Qemu-devel] [PATCH 2/4] linux-user: pass correct host flags to eventfd2 call

2013-04-12 Thread Stefan Hajnoczi
From: Petar Jovanovic This change makes conversion of TARGET_O_NONBLOCK and TARGET_O_CLOEXEC flags to host flags before calling eventfd for TARGET_NR_eventfd2. Signed-off-by: Petar Jovanovic Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- linux-user/syscall.c | 11 ++-

[Qemu-devel] [PATCH 3/4] Typo, spelling and grammatical fixes

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Minor fixes to documentation and code comments. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- docs/bootindex.txt | 10 +- docs/ccid.txt | 2 +- hw/block/virtio-blk.c | 4 ++-- hw/intc/armv7m_nvic.c | 2 +- hw/s390

[Qemu-devel] [PATCH 1/4] target-moxie: Fix VMState registration

2013-04-12 Thread Stefan Hajnoczi
From: Peter Maydell Register the CPU VMState in the correct way, via cpu_class_set_vmsd(), rather than doing it in two different wrong ways (once by providing cpu_save and cpu_load functions, and once by setting the vmsd field in DeviceClass). Signed-off-by: Peter Maydell Reviewed-by: Andreas F

[Qemu-devel] [PULL 0/4] Trivial patches for 6 to 12 April 2013

2013-04-12 Thread Stefan Hajnoczi
The following changes since commit 93b48c201eb6c0404d15550a0eaa3c0f7937e35e: virtio-9p: Fix virtio-9p no longer building after hw-dirs branch merge (2013-04-09 07:47:00 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch change

  1   2   >