Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-23 Thread Paolo Bonzini
Il 24/04/2013 01:53, Michael R. Hines ha scritto: > > So, I started investigating the problem, and I noticed that whenever > I disabled the limits of max_size, the throughput went back to > the normal throughput (peak of 26 gbps). > > So, rather than change the default max_size calculation for TC

Re: [Qemu-devel] [PATCH 1/2] cpu-exec: rid cs_base of TranslationBlock

2013-04-23 Thread Paolo Bonzini
Il 24/04/2013 03:48, liguang ha scritto: > cs_base is only meaningful for target-i386/sparc, > so, get rid of cs_base for other target This is really ugly, we're trying to get less target-dependent code outside target-*, not more. Also, please limit the number of people that you CC. Paolo > Sig

Re: [Qemu-devel] seabios for qemu 1.5

2013-04-23 Thread Amos Kong
On Wed, Apr 24, 2013 at 07:59:36AM +0200, Gerd Hoffmann wrote: > Hi, > > > b44a7be17bdd270ea029a8e2ec0c2e80c6cd0444 virtio-scsi: Pack struct > > virtio_scsi_{req_cmd,resp_cmd} > > 5a7730db57ab0715223421e65b54fb50d6fefe5c virtio-scsi: Set _DRIVER_OK flag > > before scsi target scanning > > > A

[Qemu-devel] seabios for qemu 1.5

2013-04-23 Thread Gerd Hoffmann
Hi, > b44a7be17bdd270ea029a8e2ec0c2e80c6cd0444 virtio-scsi: Pack struct > virtio_scsi_{req_cmd,resp_cmd} > 5a7730db57ab0715223421e65b54fb50d6fefe5c virtio-scsi: Set _DRIVER_OK flag > before scsi target scanning > Anthony + Gerd, can we expect an rev to pc-bios/bios.bin soon to pick up > these

Re: [Qemu-devel] [PULL 0/9] SCSI updates for 2013-04-13

2013-04-23 Thread Stefan Weil
Am 19.04.2013 16:24, schrieb Paolo Bonzini: > The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: > > configure: remove duplicate test (2013-04-18 14:12:31 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git scsi-next > > for you to

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-23 Thread Wenchao Xia
I think that my whole series is almost done and it would be quickly accepted and applied upstream. I'll send today the v2 and we will see. Pavel OK, I'll review v2 too to make it faster. Hi, Pavel Sorry for query your progress, I hope to catch up qemu 1.5, so wonder whether V2 is read

[Qemu-devel] [PATCH 2/2] target-*/cpu.h: remove cs_base for other targets

2013-04-23 Thread liguang
Signed-off-by: liguang --- target-alpha/cpu.h |3 +-- target-arm/cpu.h|3 +-- target-cris/cpu.h |3 +-- target-lm32/cpu.h |3 +-- target-m68k/cpu.h |3 +-- target-microblaze/cpu.h |3 +-- target-mips/cpu.h |3 +-- target-moxie/cpu.h

[Qemu-devel] [PATCH 1/2] cpu-exec: rid cs_base of TranslationBlock

2013-04-23 Thread liguang
cs_base is only meaningful for target-i386/sparc, so, get rid of cs_base for other target Signed-off-by: liguang --- cpu-exec.c | 26 ++ exec.c |6 +++--- hw/i386/kvmvapic.c |6 ++ include/exec/exec-all.h |5 +++-- targ

Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-23 Thread Michael R. Hines
On 04/23/2013 05:10 PM, Paolo Bonzini wrote: Il 23/04/2013 03:55, mrhi...@linux.vnet.ibm.com ha scritto: +chunk_start = ram_chunk_start(block, rdma->current_chunk); + +if (host_addr < chunk_start) { +return 0; +} Useless if remaining from previous submissions. Paolo Ooo

Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-23 Thread Michael R. Hines
On 04/23/2013 04:59 PM, Paolo Bonzini wrote: Il 23/04/2013 03:55, mrhi...@linux.vnet.ibm.com ha scritto: +static size_t qemu_rdma_get_max_size(QEMUFile *f, void *opaque, + uint64_t transferred_bytes, + uint64_t time_spent, +

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 05:44 PM, Anthony Liguori wrote: Eric Blake writes: On 04/23/2013 02:15 PM, Michael R. Hines wrote: Would be helpful for new people (like myself) to have a summary of these procedures on the wiki so we don't have to bother you guys when we get to the end of the reviews. http://

Re: [Qemu-devel] contribution process [was: [PATCH v5 00/12] rdma: migration support]

2013-04-23 Thread Michael R. Hines
On 04/23/2013 06:40 PM, Eric Blake wrote: On 04/23/2013 03:44 PM, Anthony Liguori wrote: Eric Blake writes: On 04/23/2013 02:15 PM, Michael R. Hines wrote: Would be helpful for new people (like myself) to have a summary of these procedures on the wiki so we don't have to bother you guys when

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 05:11 PM, Paolo Bonzini wrote: Il 23/04/2013 22:15, Michael R. Hines ha scritto: Also, don't be surprised if not everyone reviews the entire series; sometimes reviewers like myself focus only on the portion of the series that interacts with my current interests (I tend to review an

Re: [Qemu-devel] [PULL 0/9] SCSI updates for 2013-04-13

2013-04-23 Thread Nicholas A. Bellinger
On Fri, 2013-04-19 at 16:24 +0200, Paolo Bonzini wrote: > The following changes since commit 09dada400328d75daf79e3eca1e48e024fec148d: > > configure: remove duplicate test (2013-04-18 14:12:31 +0200) > > are available in the git repository at: > > git://github.com/bonzini/qemu.git scsi-next

[Qemu-devel] contribution process [was: [PATCH v5 00/12] rdma: migration support]

2013-04-23 Thread Eric Blake
On 04/23/2013 03:44 PM, Anthony Liguori wrote: > Eric Blake writes: > >> On 04/23/2013 02:15 PM, Michael R. Hines wrote: >>> >>> Would be helpful for new people (like myself) to have a summary >>> of these procedures on the wiki so we don't have to bother you >>> guys when we get to the end of th

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Peter Maydell
On 23 April 2013 22:46, Paolo Bonzini wrote: > Il 23/04/2013 23:39, Peter Maydell ha scritto: >> and our new function is >> MemoryRegionSection address_space_find_region(AddressSpace *as, >>MemoryRegion *mr); >> >> ? >> >> (we don't have to do the

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 23:39, Peter Maydell ha scritto: >> > >> > Hmm, good point. address_space_get_region_addr()? > Maybe we should make this parallel-ish to memory_region_find() > (which finds an MR within an AS by addr/size)? > > Actually, I think I'd favour cleaning up some of the existing > API whic

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Anthony Liguori
Eric Blake writes: > On 04/23/2013 02:15 PM, Michael R. Hines wrote: >> >> Would be helpful for new people (like myself) to have a summary >> of these procedures on the wiki so we don't have to bother you >> guys when we get to the end of the reviews. > > http://wiki.qemu.org/Contribute/SubmitAP

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Peter Maydell
On 23 April 2013 22:02, Paolo Bonzini wrote: > Il 23/04/2013 20:00, Peter Maydell ha scritto: >> NB: I don't think we should call it memory_region_get_address() >> though -- that implies a non-existent parallel to the current >> memory_region_set_address(). > > Hmm, good point. address_space_get_

[Qemu-devel] [PATCH v6 19/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-04-23 Thread Richard Henderson
Move the slow path out of line, as the TODO's mention. This allows the fast path to be unconditional, which can speed up the fast path as well, depending on the core. Signed-off-by: Richard Henderson --- configure | 2 +- include/exec/exec-all.h | 17 +++ tcg/arm/tcg-target.c

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Wolfgang Richter
-- Wolf On Apr 23, 2013, at 1:22 PM, Eric Blake wrote: > On 04/23/2013 11:12 AM, Wolfgang Richter wrote: >> I'm interested in adding introspection of disk writes to QEMU for various >> applications and research potential. >> >> What I mean by introspection of disk writes is that, when enabled,

[Qemu-devel] [PATCH] Fix block_resize command for ide disks.

2013-04-23 Thread Eduardo Warszawski
Add ide disk resize callback in order to update disk's nb_sectors after resize. rhbz #852348 Signed-off-by: Eduardo Warszawski --- hw/ide/core.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index c7a8041..023abb1 100644 --- a/hw/ide/core.

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 22:15, Michael R. Hines ha scritto: >> >> Also, don't be surprised if not everyone reviews the entire series; >> sometimes reviewers like myself focus only on the portion of the series >> that interacts with my current interests (I tend to review anything QMP, >> because I want to mak

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Eric Blake
On 04/23/2013 02:15 PM, Michael R. Hines wrote: > > Would be helpful for new people (like myself) to have a summary > of these procedures on the wiki so we don't have to bother you > guys when we get to the end of the reviews. http://wiki.qemu.org/Contribute/SubmitAPatch is supposed to be such a

Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 03:55, mrhi...@linux.vnet.ibm.com ha scritto: > +chunk_start = ram_chunk_start(block, rdma->current_chunk); > + > +if (host_addr < chunk_start) { > +return 0; > +} Useless if remaining from previous submissions. Paolo

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 20:00, Peter Maydell ha scritto: > For ARM we defer the mechanics of "tell the kernel where this memory > region is" from the device implementation (hw/intc/arm_gic_kvm.c) to > generic code in target-arm/kvm.c, which I personally think is a > neat way to solve this problem. Yes, it i

Re: [Qemu-devel] [PATCH v5 11/12] rdma: core logic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 03:55, mrhi...@linux.vnet.ibm.com ha scritto: > +static size_t qemu_rdma_get_max_size(QEMUFile *f, void *opaque, > + uint64_t transferred_bytes, > + uint64_t time_spent, > + uin

[Qemu-devel] [PATCH v6 16/20] tcg-arm: Improve scheduling of tcg_out_tlb_read

2013-04-23 Thread Richard Henderson
The schedule was fully serial, with no possibility for dual issue. The old schedule had a minimal issue of 7 cycles; the new schedule has a minimal issue of 5 cycles. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 110 ++- 1 file chang

[Qemu-devel] [PATCH v6 17/20] tcg-arm: Delete the 'S' constraint

2013-04-23 Thread Richard Henderson
After the previous patch, 's' and 'S' are the same. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 375c1e1..5fa3cb1 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/a

[Qemu-devel] [PATCH v6 14/20] tcg-arm: Cleanup most primitive load store subroutines

2013-04-23 Thread Richard Henderson
Use even more primitive helper functions to avoid lots of duplicated code. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 235 --- 1 file changed, 111 insertions(+), 124 deletions(-) diff --git a/tcg/arm/t

[Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from tcg_out_goto_label

2013-04-23 Thread Richard Henderson
Branches within a TB will always be within 16MB. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index d6afa2f..7216f7a 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/

[Qemu-devel] [PATCH v6 13/20] tcg-arm: Cleanup multiply subroutines

2013-04-23 Thread Richard Henderson
Make the code more readable by only having one copy of the magic numbers, swapping registers as needed prior to that. Speed the compiler by not applying the rd == rn avoidance for v6 or later. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 85 ++

[Qemu-devel] [PATCH v6 18/20] tcg-arm: Use movi32 + blx for calls on v7

2013-04-23 Thread Richard Henderson
Work better with branch predition when we have movw+movt, as the size of the code is the same. Perhaps re-evaluate when we have a proper constant pool. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/t

[Qemu-devel] [PATCH v6 12/20] tcg-arm: Use R12 for the tcg temporary

2013-04-23 Thread Richard Henderson
R12 is call clobbered, while R8 is call saved. This change gives tcg one more call saved register for real data. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/arm/tcg-target.c b/tcg/

[Qemu-devel] [PATCH v6 15/20] tcg-arm: Split out tcg_out_tlb_read

2013-04-23 Thread Richard Henderson
Share code between qemu_ld and qemu_st to process the tlb. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 169 +-- 1 file changed, 70 insertions(+), 99 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/

[Qemu-devel] [PATCH v6 05/20] tcg-arm: Allow constant first argument to sub

2013-04-23 Thread Richard Henderson
This allows the generation of RSB instructions. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index de8465b..6c7113b 100644 --

[Qemu-devel] [PATCH v6 11/20] tcg-arm: Use TCG_REG_TMP name for the tcg temporary

2013-04-23 Thread Richard Henderson
Don't hard-code R8. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 118 ++- 1 file changed, 60 insertions(+), 58 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index b0e73d2..cc442b6

[Qemu-devel] [PATCH v6 09/20] tcg-arm: Implement deposit for armv7

2013-04-23 Thread Richard Henderson
We have BFI and BFC available for implementing it. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 41 ++--- tcg/arm/tcg-target.h | 5 - 2 files changed, 42 insertions(+), 4 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.

[Qemu-devel] [PATCH v6 03/20] tcg-arm: Use bic to implement and with constant

2013-04-23 Thread Richard Henderson
This greatly improves the code we can produce for deposit without armv7 support. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 56 +--- tcg/arm/tcg-target.h | 2 -- 2 files changed, 44 insertions(+), 14 d

[Qemu-devel] [PATCH v6 08/20] tcg-arm: Improve constant generation

2013-04-23 Thread Richard Henderson
Try fully rotated arguments to mov and mvn before trying movt or full decomposition. Begin decomposition with mvn when it looks like it'll help. Examples include -:mov r9, #0x0fa0 -:orr r9, r9, #0x000ee000 -:orr r9, r9, #0x0ff0 -:orr r9, r9, #0xf00

[Qemu-devel] [PATCH v6 10/20] tcg-arm: Implement division instructions

2013-04-23 Thread Richard Henderson
An armv7 extension implements division, present on Cortex A15. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- disas/arm.c | 4 tcg/arm/tcg-target.c | 36 tcg/arm/tcg-target.h | 7 ++- 3 files changed, 46 insertions(+), 1

[Qemu-devel] [PATCH v6 07/20] tcg-arm: Handle constant arguments to add2/sub2

2013-04-23 Thread Richard Henderson
We get to re-use the _rIN and _rIK subroutines to handle the various combinations of add vs sub. Fold the << 21 into the opcode enum values so that we can explicitly add TO_CPSR as desired. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 106

[Qemu-devel] [PATCH v6 01/20] tcg-arm: Fix local stack frame

2013-04-23 Thread Richard Henderson
We were not allocating TCG_STATIC_CALL_ARGS_SIZE, so this meant that any helper with more than 4 arguments would clobber the saved regs. Realizing that we're supposed to have this memory pre-allocated means we can clean up the tcg_out_arg functions, which were trying to do more stack allocation. A

[Qemu-devel] [PATCH v6 06/20] tcg-arm: Use tcg_out_dat_rIN for compares

2013-04-23 Thread Richard Henderson
This allows us to emit CMN instructions. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 6c7113b

[Qemu-devel] [PATCH v6 04/20] tcg-arm: Handle negated constant arguments to and/sub

2013-04-23 Thread Richard Henderson
This greatly improves code generation for addition of small negative constants. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 41 +++-- 1 file changed, 35 insertions(+), 6 deletions(-) diff --git a/tcg/arm/tcg-target

[Qemu-devel] [PATCH v6 02/20] tcg: Log the contents of the prologue with -d out_asm

2013-04-23 Thread Richard Henderson
This makes it easier to verify changes to the code generating the prologue. Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/tcg.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1d8265e..de68c16 100644 --- a/tcg/tcg.c +++ b/tcg/tc

[Qemu-devel] [PATCH v6 00/20] tcg-arm improvments

2013-04-23 Thread Richard Henderson
Changes v5-v6, feedback from Aurelien: * Drop tcg_out_goto changes. * Add Z constraint for deposit. * Small comment cleanups. * Rebase vs master. The following changes since commit 456736710df19c2275192269fe67a3f0b2583835: block: Fix build with tracing enabled (2013-04-22 11:31:41 -0500

Re: [Qemu-devel] [PATCH] s390x: use CONFIG_INT128 to detect __uint128_t

2013-04-23 Thread Richard Henderson
On 2013-04-23 18:15, Gabriel Kerneis wrote: Target s390x uses ad-hoc macro magic to guess if the compiler supports the GCC extension __uint128_t. This patch uses the the dedicated macro CONFIG_INT128 defined by configure instead. This fixes compilation with the CIL source code analyzer, which u

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 02:26 PM, Anthony Liguori wrote: "Michael R. Hines" writes: On 04/23/2013 01:50 PM, Anthony Liguori wrote: mrhi...@linux.vnet.ibm.com writes: From: "Michael R. Hines" Juan, Please pull. I assume this is actually v6, not v5? I don't see collected Reviewed-bys... That said,

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 03:24 PM, Eric Blake wrote: On 04/23/2013 12:26 PM, Anthony Liguori wrote: There are no instructions/procedures documented on the qemu.org website on how to automatically generate "Reviewed-by" signatures. I suspect there's some confusion here. Addressed review comments != Review

Re: [Qemu-devel] [libvirt] [PATCH qom-cpu 6/9] target-i386: Add "feature-words" property

2013-04-23 Thread Eduardo Habkost
On Mon, Apr 22, 2013 at 02:37:06PM -0600, Eric Blake wrote: > On 04/22/2013 01:00 PM, Eduardo Habkost wrote: > > This property will be useful for libvirt, as libvirt already has logic > > based on low-level feature bits (not feature names), so it will be > > really easy to convert the current libvi

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Eric Blake
On 04/23/2013 12:26 PM, Anthony Liguori wrote: >> There are no instructions/procedures documented on the qemu.org >> website on how to automatically generate "Reviewed-by" signatures. > > I suspect there's some confusion here. Addressed review comments != > Reviewed-by. There can always be addit

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Wolfgang Richter
On Tue, Apr 23, 2013 at 2:31 PM, Wolfgang Richter wrote: > On Tue, Apr 23, 2013 at 2:21 PM, Stefan Hajnoczi wrote: > >> Eric's suggestion to use NBD makes sense to me. The block-backup code >> can be extended fairly easier using sync mode=none (do not perform a >> background copy of the entire d

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Anthony Liguori
"Michael R. Hines" writes: > On 04/23/2013 02:26 PM, Anthony Liguori wrote: >> "Michael R. Hines" writes: >> >>> On 04/23/2013 01:50 PM, Anthony Liguori wrote: mrhi...@linux.vnet.ibm.com writes: > From: "Michael R. Hines" > > Juan, Please pull. I assume this is actual

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 02:26 PM, Anthony Liguori wrote: "Michael R. Hines" writes: On 04/23/2013 01:50 PM, Anthony Liguori wrote: mrhi...@linux.vnet.ibm.com writes: From: "Michael R. Hines" Juan, Please pull. I assume this is actually v6, not v5? I don't see collected Reviewed-bys... That said,

Re: [Qemu-devel] should qemu-palcode git submodule be hosted on git.qemu.org?

2013-04-23 Thread Anthony Liguori
Peter Maydell writes: > I thought that our git submodules were all supposed to be hosted > on git.qemu.org, or does that only apply to the ones which have > sources we use to generate binary blobs we ship in our tarballs? Why is it even a submodule? If it's only used by QEMU, why not just make

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Wolfgang Richter
On Tue, Apr 23, 2013 at 2:21 PM, Stefan Hajnoczi wrote: > The tracing subsystem is geared towards tracepoint instrumentation > rather than binary dumps. > > Can you share some specific applications? > Well, my main application is in exposing a "cloud-inotify" service by interpreting sector write

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Anthony Liguori
"Michael R. Hines" writes: > On 04/23/2013 01:50 PM, Anthony Liguori wrote: >> mrhi...@linux.vnet.ibm.com writes: >> >>> From: "Michael R. Hines" >>> >>> Juan, Please pull. >> I assume this is actually v6, not v5? >> >> I don't see collected Reviewed-bys... >> >> That said, we're pretty close to

Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation

2013-04-23 Thread Paolo Bonzini
> Hi Paolo, > > your patch looks good, but maybe you could modify the signatures > of readv, writev to match the Linux originals (missing const, use int): > > ssize_t readv(int fd, const struct iovec *iov, int iovcnt); > ssize_t writev(int fd, const struct iovec *iov, int iovcnt); > > In

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 7:12 PM, Wolfgang Richter wrote: > I'm interested in adding introspection of disk writes to QEMU for various > applications and research potential. > > What I mean by introspection of disk writes is that, when enabled, each > write > passing through QEMU to backing storage

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Stefan Hajnoczi
On Tue, Apr 23, 2013 at 7:22 PM, Eric Blake wrote: > On 04/23/2013 11:12 AM, Wolfgang Richter wrote: >> I'm interested in adding introspection of disk writes to QEMU for various >> applications and research potential. >> >> What I mean by introspection of disk writes is that, when enabled, each >>

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Peter Maydell
On 23 April 2013 18:39, Jan Kiszka wrote: > On 2013-04-23 19:26, Peter Maydell wrote: >> That would be an improvement, but it still requires this >> device to know what address space it's mapped into, which >> is a bit ugly. > > Unfortunately the KVM API mandates this knowledge (IOAPIC state conta

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Michael R. Hines
On 04/23/2013 01:50 PM, Anthony Liguori wrote: mrhi...@linux.vnet.ibm.com writes: From: "Michael R. Hines" Juan, Please pull. I assume this is actually v6, not v5? I don't see collected Reviewed-bys... That said, we're pretty close to hard freeze. I think this should wait until 1.6 opens

Re: [Qemu-devel] [PATCH v5 00/12] rdma: migration support

2013-04-23 Thread Anthony Liguori
mrhi...@linux.vnet.ibm.com writes: > From: "Michael R. Hines" > > Juan, Please pull. I assume this is actually v6, not v5? I don't see collected Reviewed-bys... That said, we're pretty close to hard freeze. I think this should wait until 1.6 opens up although I'm open to suggestion if people

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Jan Kiszka
On 2013-04-23 19:26, Peter Maydell wrote: > On 23 April 2013 18:14, Paolo Bonzini wrote: >> Il 23/04/2013 19:06, Peter Maydell ha scritto: > /* > + * memory_region_get_address: get current the address of a region > + * > + * Returns the absolute address of a region. > + * May

Re: [Qemu-devel] [PATCH 2/2] win32: add readv/writev emulation

2013-04-23 Thread Stefan Weil
Am 22.04.2013 20:53, schrieb Paolo Bonzini: > Commit e9d8fbf (qemu-file: do not use stdio for qemu_fdopen, 2013-03-27) > introduced a usage of writev, which mingw32 does not have. Even though > qemu_fdopen itself is not used on mingw32, the future-proof solution is > to add an implementation of it

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Peter Maydell
On 23 April 2013 18:14, Paolo Bonzini wrote: > Il 23/04/2013 19:06, Peter Maydell ha scritto: >>> > /* >>> > + * memory_region_get_address: get current the address of a region >>> > + * >>> > + * Returns the absolute address of a region. >>> > + * May be used on regions that are currently part of

Re: [Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Eric Blake
On 04/23/2013 11:12 AM, Wolfgang Richter wrote: > I'm interested in adding introspection of disk writes to QEMU for various > applications and research potential. > > What I mean by introspection of disk writes is that, when enabled, each > write > passing through QEMU to backing storage would als

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 19:06, Peter Maydell ha scritto: >> > /* >> > + * memory_region_get_address: get current the address of a region >> > + * >> > + * Returns the absolute address of a region. >> > + * May be used on regions that are currently part of a memory hierarchy. >> > + * >> > + * @mr: the regio

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Undefine _FORTIFY_SOURCE prior using it

2013-04-23 Thread Michal Privoznik
On 06.02.2013 16:09, Paolo Bonzini wrote: > Il 06/02/2013 15:49, Stefan Hajnoczi ha scritto: I don't think that's necessary. The 2nd level is the highest one [1] or [2]. It seems like in my case it's compiler who's defining the macro: $ echo "int main() {return 0;}" | gcc

[Qemu-devel] [PATCH] s390x: use CONFIG_INT128 to detect __uint128_t

2013-04-23 Thread Gabriel Kerneis
Target s390x uses ad-hoc macro magic to guess if the compiler supports the GCC extension __uint128_t. This patch uses the the dedicated macro CONFIG_INT128 defined by configure instead. This fixes compilation with the CIL source code analyzer, which uses GCC as a preprocessor but does not support

[Qemu-devel] Adding Disk-Level Introspection to QEMU

2013-04-23 Thread Wolfgang Richter
I'm interested in adding introspection of disk writes to QEMU for various applications and research potential. What I mean by introspection of disk writes is that, when enabled, each write passing through QEMU to backing storage would also be copied to an introspection channel for further analysis

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Peter Maydell
On 23 April 2013 09:29, Igor Mammedov wrote: > /* > + * memory_region_get_address: get current the address of a region > + * > + * Returns the absolute address of a region. > + * May be used on regions that are currently part of a memory hierarchy. > + * > + * @mr: the region being queried > + */

Re: [Qemu-devel] [PATCH 17/21] introduce memory_region_get_address() and use it in kvm/ioapic

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 10:29, Igor Mammedov ha scritto: > kvm/ioapic is relying on the fact that SysBus device > maps mmio regions with offset counted from start of system memory. > But if ioapic's region is moved to another sub-region which doesn't > start at the beginning of system memory then using offse

Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command

2013-04-23 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 23/04/2013 18:49, Eric Blake ha scritto: > Based on today's phone call, it sounds like this would mean adding > optional parameters to the QMP command. We already did that for > drive-mirror (1.4 has more parameters than 1.3), but without a way >

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-23 Thread Luiz Capitulino
On Tue, 23 Apr 2013 09:32:31 -0600 Eric Blake wrote: > On 04/23/2013 07:20 AM, Luiz Capitulino wrote: > > On Mon, 22 Apr 2013 09:00:05 -0600 > > Eric Blake wrote: > > > >> At any rate, we really DO want introspection, and having it in 1.5 is a > >> worthwhile goal. Even if the introspection tu

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Jan Kiszka
On 2013-04-23 18:43, Paolo Bonzini wrote: > Il 23/04/2013 18:13, Paolo Bonzini ha scritto: >> Il 23/04/2013 10:47, Jan Kiszka ha scritto: > if (val & LSI_ISTAT0_SRST) { > -lsi_soft_reset(s); > +qdev_reset_all(&s->dev.qdev); >>> What should ensure that al

Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command

2013-04-23 Thread Eric Blake
On 04/23/2013 10:25 AM, Stefan Hajnoczi wrote: > This series adds a new QMP command, block-backup, which takes a point-in-time > snapshot of a block device. The snapshot is copied out to a target block > device. A simple example is: > > block-backup device=virtio0 format=qcow2 target=backup-20

Re: [Qemu-devel] [RFC PATCH v2 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-04-23 Thread Tomoki Sekiyama
Hi Baiqing, Thank you for your testing. >1 Extcuting the command "net start qemu-ga" failed,but the command >"qemu-qa.exe -m virtio-serial -p \\.\Global\org.qemu.guest_agent.1" is ok. `qemu-ga.exe -s install -p \\.\Global\org.qemu.guest_agent.1' may help to use virtio-serial ".1" in qemu-ga

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 18:13, Paolo Bonzini ha scritto: > Il 23/04/2013 10:47, Jan Kiszka ha scritto: if (val & LSI_ISTAT0_SRST) { -lsi_soft_reset(s); +qdev_reset_all(&s->dev.qdev); >> What should ensure that all device resets are performed before the host >>

Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images

2013-04-23 Thread Jeff Cody
On Tue, Apr 23, 2013 at 05:10:18PM +0200, Kevin Wolf wrote: > Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > > This is based on Microsoft's VHDX specification: > > "VHDX Format Specification v0.95", published 4/12/2012 > > https://www.microsoft.com/en-us/download/details.aspx?id=29681

[Qemu-devel] [PATCH 10/21 DISGISED v6] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Igor Mammedov
* introduce processor status bitmask visible to guest at 0xaf00 addr, where ACPI asl code expects it * set bit corresponding to APIC ID in processor status bitmask on receiving CPU hot-plug notification * trigger CPU hot-plug SCI, to notify guest about CPU hot-plug event Signed-off-by: Igor Ma

[Qemu-devel] [PATCH] virtio-ccw: Indicators fix.

2013-04-23 Thread Cornelia Huck
Hi, here's another fix for virtio-ccw: We need to check whether an indicator location is actually valid before trying to write to it. Cornelia Huck (1): virtio-ccw: Check indicators location. hw/s390x/virtio-ccw.c |6 ++ 1 file changed, 6 insertions(+) -- 1.7.9.5

[Qemu-devel] [PATCH] virtio-ccw: Check indicators location.

2013-04-23 Thread Cornelia Huck
If a guest neglected to register (secondary) indicators but still runs with notifications enabled, we might end up writing to guest zero; avoid this by checking for valid indicators and only writing to the guest and generating an interrupt if indicators have been setup. Cc: qemu-sta...@nongnu.org

[Qemu-devel] [PATCH 0/3] block: block-backup live backup command

2013-04-23 Thread Stefan Hajnoczi
This series adds a new QMP command, block-backup, which takes a point-in-time snapshot of a block device. The snapshot is copied out to a target block device. A simple example is: block-backup device=virtio0 format=qcow2 target=backup-20130401.qcow2 The original block-backup blockjob was writ

[Qemu-devel] [PATCH 3/3] qemu-iotests: add 054 block-backup test case

2013-04-23 Thread Stefan Hajnoczi
Testing block-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/054 | 230 + tests/qemu-iotests/054.out | 5 + tests/qemu-iotests/group | 1 + 3 fil

[Qemu-devel] [PATCH 2/3] block: add block_backup QMP command

2013-04-23 Thread Stefan Hajnoczi
@block-backup Start a point-in-time copy of a block device to a new destination. @device: the name of the device whose writes should be mirrored. @target: the target of the new image. If the file exists, or if it is a device, the existing file/device will be used as the new de

[Qemu-devel] [PATCH 1/3] block: add basic backup support to block driver

2013-04-23 Thread Stefan Hajnoczi
From: Dietmar Maurer backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads the original data from the block device before it gets overwritten. The data is then

Re: [Qemu-devel] [PATCH 16/16] add cpu-add qmp command and implement CPU hot-add for target-i386

2013-04-23 Thread Eric Blake
On 04/16/2013 02:04 PM, Igor Mammedov wrote: >>> +# >>> +# Returns: Nothing on success >>> +## >>> +{ 'command': 'cpu-add', 'data': {'id': 'int'} } >>> + >> >> Should be usable from libvirt's perspective, even if hot-plugging more >> than one cpu requires more than one QMP call. Do we have a coun

Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe

2013-04-23 Thread Kevin Wolf
Am 23.04.2013 um 18:11 hat Jeff Cody geschrieben: > On Tue, Apr 23, 2013 at 05:46:28PM +0200, Kevin Wolf wrote: > > Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > > > +/* > > > + * Per the MS VHDX Specification, for every VHDX file: > > > + * - The header section is fixed size - 1 MB > >

Re: [Qemu-devel] [PATCH 03/32] lsi: use qdev_reset_all

2013-04-23 Thread Paolo Bonzini
Il 23/04/2013 10:47, Jan Kiszka ha scritto: >> > if (val & LSI_ISTAT0_SRST) { >> > -lsi_soft_reset(s); >> > +qdev_reset_all(&s->dev.qdev); > What should ensure that all device resets are performed before the host > reset? I'm asking as we just ran into the assert(!s

Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe

2013-04-23 Thread Jeff Cody
On Tue, Apr 23, 2013 at 05:46:28PM +0200, Kevin Wolf wrote: > Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > > This is the initial block driver framework for VHDX image support ( > > i.e. Hyper-V image file formats), that supports opening VHDX files, and > > parsing the headers. > > > > This

Re: [Qemu-devel] KVM call minutes for 2013-04-23

2013-04-23 Thread Eric Blake
On 04/23/2013 08:45 AM, Juan Quintela wrote: > > * 1.5 pending patches (paolo) > anthony thinks nothing big is outstanding > rdma: not probably for this release, too big change on migration > cpu-hotplug: andreas expect to get it for 1.5 > > > * What can libvirt expect in 1.5 for introspe

Re: [Qemu-devel] [PATCH 02/21] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-23 Thread Andreas Färber
Am 23.04.2013 10:29, schrieb Igor Mammedov: > ... to synchronize CPU state to KVM > > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > --- > v2: > * linking kvm-stub.o to *-user target moved in separate patch Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commit

[Qemu-devel] [PATCH] target-arm: Fix incorrect check of kvm_vcpu_ioctl return value

2013-04-23 Thread Peter Maydell
kvm_vcpu_ioctl() returns -ETHING on error, not ETHING -- correct an incorrect check in kvm_arch_init_vcpu(). This would not have had any significant ill-effects -- we would just have propagated the less useful ENOENT up to the caller rather than the more accurate EINVAL in the unlikely case that th

Re: [Qemu-devel] [PATCH 1/2] Split out dump-guest-memory memory mapping code

2013-04-23 Thread Jens Freimann
On Tue, Apr 23, 2013 at 09:41:43AM -0600, Eric Blake wrote: > On 04/23/2013 09:30 AM, Jens Freimann wrote: > > Split out dump-guest-memory memory mapping code to allow dumping without > > memory mapping > > > > The qemu dump.c code currently requires CONFIG_HAVE_CORE_DUMP as well as > > CONFIG_HAV

Re: [Qemu-devel] [PATCH 10/21] acpi_piix4: add infrastructure to send CPU hot-plug GPE to guest

2013-04-23 Thread Igor Mammedov
On Tue, 23 Apr 2013 17:25:50 +0200 Juan Quintela wrote: > Igor Mammedov wrote: > > On Tue, 23 Apr 2013 13:38:10 +0200 > > Juan Quintela wrote: > > Something like this (on top of your series) should work. > > It implements an optional subsection and is sent depending if we have > used (or not)

Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support framework - supports open and probe

2013-04-23 Thread Kevin Wolf
Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > This is the initial block driver framework for VHDX image support ( > i.e. Hyper-V image file formats), that supports opening VHDX files, and > parsing the headers. > > This commit does not yet enable: > - reading > - writing > - upda

[Qemu-devel] [PATCH] microblaze: Add internal base vectors reg

2013-04-23 Thread edgar . iglesias
From: "Edgar E. Iglesias" Configurable at CPU synthesis/instantiation. Signed-off-by: Edgar E. Iglesias --- target-microblaze/cpu.h|1 + target-microblaze/helper.c |8 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target-microblaze/cpu.h b/target-microblaz

Re: [Qemu-devel] [PATCH] monitor: introduce query-config-schema

2013-04-23 Thread Eric Blake
On 04/23/2013 07:20 AM, Luiz Capitulino wrote: > On Mon, 22 Apr 2013 09:00:05 -0600 > Eric Blake wrote: > >> At any rate, we really DO want introspection, and having it in 1.5 is a >> worthwhile goal. Even if the introspection turns up empty on legacy >> options, having it for the sake of new op

  1   2   3   >