Signed-off-by: Igor Mitsyanko
---
hw/sd/sd.c | 145 -
1 file changed, 133 insertions(+), 12 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 659ec56..615ab61 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -958,6 +958,11 @@ static sd
It will only be used if start bit and databusy callbacks were initialized
by user of SD card model.
Signed-off-by: Igor Mitsyanko
---
hw/sd/sd.c | 85 --
1 file changed, 77 insertions(+), 8 deletions(-)
diff --git a/hw/sd/sd.c b/hw/sd/
Signed-off-by: Igor Mitsyanko
---
hw/sd/pl181.c | 302 +-
1 file changed, 192 insertions(+), 110 deletions(-)
diff --git a/hw/sd/pl181.c b/hw/sd/pl181.c
index 2caacc2..a8a3510 100644
--- a/hw/sd/pl181.c
+++ b/hw/sd/pl181.c
@@ -20,7 +20,7 @@
Am 10.05.2013 17:32, schrieb Alexander Graf:
>
> On 10.05.2013, at 17:23, Andreas Färber wrote:
>
>> Am 10.05.2013 17:06, schrieb Anthony Liguori:
>>> Andreas Färber writes:
>>>
A transition from CPUPPCState to PowerPCCPU can be considered safe,
just like PowerPCCPU::env access in the
Am 10.05.2013 17:56, schrieb Aurelien Jarno:
> To improve the performance a bit more, and come back to the same kind of
> code as before, we should move simple accessors from qom/*.c to
> include/qom/*.h and mark them as inline, so that they can be removed by
> the compiler. Currently, even if the
On 10 May 2013 17:14, Andreas Färber wrote:
> Personally I wouldn't oppose dropping these checks for release builds as
> proposed by Paolo in his series; for me, the value of POWERPC_CPU() is
> being closer to an OO cast than any container_of()-style expressions.
>
> But I can also see Anthony's p
On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote:
> On Thu, 9 May 2013 21:20:56 -0500
> Michael Roth wrote:
>
> > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs
> > qapi-types.c/qapi-visit.c
> >
> > Signed-off-by: Michael Roth
> > ---
> > Makefile |6 ++
Am 10.05.2013 18:20, schrieb Peter Maydell:
> On 10 May 2013 17:14, Andreas Färber wrote:
>> Personally I wouldn't oppose dropping these checks for release builds as
>> proposed by Paolo in his series; for me, the value of POWERPC_CPU() is
>> being closer to an OO cast than any container_of()-styl
Il 10/05/2013 18:18, Andreas Färber ha scritto:
> Am 10.05.2013 17:56, schrieb Aurelien Jarno:
>> To improve the performance a bit more, and come back to the same kind of
>> code as before, we should move simple accessors from qom/*.c to
>> include/qom/*.h and mark them as inline, so that they can
Paolo Bonzini writes:
> Il 10/05/2013 16:39, Anthony Liguori ha scritto:
>> I just oppose the notion of disabling casts and *especially* only
>> disabling casts for official builds.
>
> This actually happens all the time. Exactly this kind of type-safe cast
> is disabled in releases of GCC, but
Paolo Bonzini writes:
> Access everything from the class.
>
> Signed-off-by: Paolo Bonzini
> ---
> qom/object.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/qom/object.c b/qom/object.c
> index f5f416b..f82f12c 100644
> --- a/qom/object.c
> +++ b/qom/object.c
9P optionally uses the FS_IOC_GETVERSION ioctl to get information about
a file's version (sometimes called generation number).
The code checks for supported filesystems at mount time, but some paths
may come from other mounted filesystems.
Change it to treat unsupported paths the same as unsuppor
Most QOM types use type_register_static but we still strdup the
passed data. However, the original pointers are useful because
GCC is pretty good about collapsing strings so its very likely any
use of the pointer will end up being that same address.
IOW, with a little trickery, we can compare typ
Aurelien Jarno writes:
> On Fri, May 10, 2013 at 02:16:34PM +0200, Paolo Bonzini wrote:
>> Cast debugging can have a substantial cost (20% or more, measured by
>> Aurelien on qemu-system-ppc64). Instead of adding special-cased "fast
>> casts" in the hot paths, we can just disable it in releases.
On Fri, May 10, 2013 at 12:41:07PM -0500, Anthony Liguori wrote:
> Paolo Bonzini writes:
>
> > Il 10/05/2013 16:39, Anthony Liguori ha scritto:
> >> I just oppose the notion of disabling casts and *especially* only
> >> disabling casts for official builds.
> >
> > This actually happens all the ti
On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote:
> I should have paid more attention to portability and error path cleanup
> in the CVE-2013-2007 fix.
>
> (We continue to assume, like the rest of qemu code, that
> qemu_set_cloexec() never fails internally. This should be a reasonable
Aurelien Jarno writes:
> On Fri, May 10, 2013 at 12:41:07PM -0500, Anthony Liguori wrote:
>> Paolo Bonzini writes:
>>
>> > Il 10/05/2013 16:39, Anthony Liguori ha scritto:
>> >> I just oppose the notion of disabling casts and *especially* only
>> >> disabling casts for official builds.
>> >
>>
On 05/10/13 21:30, mdroth wrote:
> On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote:
>> I should have paid more attention to portability and error path cleanup
>> in the CVE-2013-2007 fix.
>>
>> (We continue to assume, like the rest of qemu code, that
>> qemu_set_cloexec() never fails i
sys/types.h is taken out from "ifdef __OpenBSD__" guard. It should be
safe for other systems, according to following survey:
http://hacks.owlfolio.org/header-survey/
This fixes build for CONFIG_IOVEC-less systems (mingw).
Signed-off-by: Igor Mitsyanko
---
include/qemu/osdep.h | 2 +-
1 file cha
On Fri, May 10, 2013 at 09:53:27PM +0200, Laszlo Ersek wrote:
> On 05/10/13 21:30, mdroth wrote:
> > On Wed, May 08, 2013 at 05:31:34PM +0200, Laszlo Ersek wrote:
> >> I should have paid more attention to portability and error path cleanup
> >> in the CVE-2013-2007 fix.
> >>
> >> (We continue to as
On 29.03.2013 21:20, Stefan Weil wrote:
The cross i586-mingw32msvc-gcc 4.4.4 from Debian Squeeze does not support
__sync_val_compare_and_swap by default.
Using -march=i686 fixes that and should also result in better code.
Signed-off-by: Stefan Weil
---
Maybe this modification is also needed f
Il 10/05/2013 19:41, Anthony Liguori ha scritto:
> Paolo Bonzini writes:
>
>> Il 10/05/2013 16:39, Anthony Liguori ha scritto:
>>> I just oppose the notion of disabling casts and *especially* only
>>> disabling casts for official builds.
>>
>> This actually happens all the time. Exactly this kin
On Fri, 2013-05-10 at 14:31 -0700, Justin Gottula wrote:
> Hi,
>
> The kernel won't compile with CONFIG_HOTPLUG_PCI=m:
>
> drivers/pci/hotplug/pci_hotplug_core.c:548:5: error: redefinition of
> ‘pci_hp_reset_slot’
> int pci_hp_reset_slot(struct hotplug_slot *hotplug, int probe)
> ^
> In fil
The isapc machine with seabios currently requires the BIOS region
to be read/write memory rather than read-only memory.
KVM currently cannot support the BIOS as a ROM region, but qemu
in non-KVM mode can. Based on this, isapc machine currently only
works with KVM.
To work-around this isapc issue,
On Fri, May 10, 2013 at 01:47:55PM -0500, Anthony Liguori wrote:
> Most QOM types use type_register_static but we still strdup the
> passed data. However, the original pointers are useful because
> GCC is pretty good about collapsing strings so its very likely any
> use of the pointer will end up
On Fri, May 10, 2013 at 11:32:48AM -0500, mdroth wrote:
> On Fri, May 10, 2013 at 10:10:03AM -0400, Luiz Capitulino wrote:
> > On Thu, 9 May 2013 21:20:56 -0500
> > Michael Roth wrote:
> >
> > > Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs
> > > qapi-types.c/qapi-visit.c
>
These patches apply on top of qemu.git master, and can also be obtained from:
git://github.com/mdroth/qemu.git qapi-native-lists
Sending this now since a number of series have popped up in the past that
wanted this, and Amos has some pending patches (query-mac-tables) that rely
on this as well.
T
Teach type generators about native types so they can generate the
appropriate linked list types.
Signed-off-by: Michael Roth
---
scripts/qapi-types.py | 45 ++---
scripts/qapi.py | 23 +++
2 files changed, 65 insertions(+), 3
Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.
We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as well.
Signed-off-by:
Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs
qapi-types.c/qapi-visit.c
Signed-off-by: Michael Roth
---
Makefile |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Makefile b/Makefile
index 7dc0204..9695c9d 100644
--- a/Makefile
+++ b/Makefile
@@ -
qmp_output_get_qobject() increments the qobject's reference count. Since
we currently pass this straight into qobject_to_json() so we can feed
the data into a QMP input visitor, we never actually free the underlying
qobject when qmp_output_visitor_cleanup() is called. This causes leaks
on all of th
Teach visitor generators about native types so they can generate the
appropriate visitor routines.
Signed-off-by: Michael Roth
---
scripts/qapi-visit.py | 34 +-
1 file changed, 29 insertions(+), 5 deletions(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-
Large integers previously got capped to LLONG_MAX/LLONG_MIN so we could
store them as int64_t. This could lead to silent errors occuring.
Now, we use a double to handle these cases.
Add a test to confirm that QMPInputVisitor handles this as expected if
we're expected an integer value: errors for
Currently our JSON parser assumes that numbers lacking a fractional
value are integers and attempts to store them as QInt/int64 values. This
breaks in the case where the number overflows/underflows int64 values (which
is still valid JSON)
Fix this by detecting such cases and using a QFloat to stor
We never actually stored the stringified double values into the strings
before we did the comparisons. This left number/double values completely
uncovered in test-visitor-serialization tests.
Fixing this exposed a bug in our handling of large whole number values
in QEMU's JSON parser which is now
This exercises schema-generated visitors for native list types and does
some sanity checking on validity of serialized data.
Signed-off-by: Michael Roth
---
qapi-schema-test.json | 15 ++
tests/test-qmp-output-visitor.c | 332 +++
2 files changed,
Signed-off-by: Michael Roth
---
tests/test-visitor-serialization.c | 451 ++--
1 file changed, 433 insertions(+), 18 deletions(-)
diff --git a/tests/test-visitor-serialization.c
b/tests/test-visitor-serialization.c
index fed6810..ee7916b 100644
--- a/tests/test-
This exercises schema-generated visitors for native list types and does
some sanity checking on validity of deserialized data.
Signed-off-by: Michael Roth
---
tests/test-qmp-input-visitor.c | 338
1 file changed, 338 insertions(+)
diff --git a/tests/tes
Aurelien Jarno writes:
> On Fri, May 10, 2013 at 01:47:55PM -0500, Anthony Liguori wrote:
>> Most QOM types use type_register_static but we still strdup the
>> passed data. However, the original pointers are useful because
>> GCC is pretty good about collapsing strings so its very likely any
>>
Paolo Bonzini writes:
> Il 10/05/2013 19:41, Anthony Liguori ha scritto:
>> Paolo Bonzini writes:
>>
>>> Il 10/05/2013 16:39, Anthony Liguori ha scritto:
I just oppose the notion of disabling casts and *especially* only
disabling casts for official builds.
>>>
>>> This actually happen
On 05/07/2013 04:39 PM, John Baboval wrote:
> From: "John V. Baboval"
>
> This parameter will cause writes to tty backed chardevs to return
> -EAGAIN if the backing tty has buffered more than the specified
> number of characters. When data is sent, the TIOCOUTQ ioctl is invoked
> to determine the
On 05/08/2013 06:49 AM, Kevin Wolf wrote:
> Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben:
>> @block-backup
>>
> drive-backup would probably be a more consistent naming. We would then
> still have block-backup for a future low-level command that doesn't
> create everything by itself but t
On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote:
> @block-backup
>
> +++ b/qapi-schema.json
> @@ -1715,6 +1715,37 @@
> '*speed': 'int' } }
>
> ##
> +# @block-backup
> +#
> +# Start a point-in-time copy of a block device to a new destination. The
> +# status of ongoing block backup o
On Wed, May 8, 2013 at 2:30 AM, Peter Maydell wrote:
> On 7 May 2013 15:16, Paolo Bonzini wrote:
>> From: Avi Kivity
>>
>> Use the new iommu support in the memory core for iommu support. The only
>> user, spapr, is also converted, but it still provides a DMAContext
>> interface until the non-PC
Am 10.05.2013 22:14, schrieb Igor Mitsyanko:
> On 29.03.2013 21:20, Stefan Weil wrote:
>> The cross i586-mingw32msvc-gcc 4.4.4 from Debian Squeeze does not
>> support
>> __sync_val_compare_and_swap by default.
>>
>> Using -march=i686 fixes that and should also result in better code.
>>
>> Signed-of
101 - 145 of 145 matches
Mail list logo
