Re: [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror()

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 14:34, Stefan Hajnoczi ha scritto: > Use bdrv_getlength() for its byte units and error return instead of > bdrv_get_geometry(). > > Reported-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- > blockdev.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > d

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 15:16:18 +0200 Laszlo Ersek wrote: > On 05/30/13 14:59, Luiz Capitulino wrote: > > On Tue, 28 May 2013 14:19:22 -0400 > > Luiz Capitulino wrote: > > > >> The code used to walk IA-32e page-tables, and possibly PAE page-tables, > >> uses the bit mask ~0xfff to get the next PML

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Laszlo Ersek
On 05/30/13 14:59, Luiz Capitulino wrote: > On Tue, 28 May 2013 14:19:22 -0400 > Luiz Capitulino wrote: > >> The code used to walk IA-32e page-tables, and possibly PAE page-tables, >> uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. >> >> However, as we use a uint64_t to stor

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-30 Thread Amos Kong
On Thu, May 30, 2013 at 02:09:25PM +0200, Stefan Priebe - Profihost AG wrote: > Am 29.05.2013 09:56, schrieb Amos Kong: > > Recent virtio refactoring in QEMU made virtio-bus become the parent bus > > of scsi-bus, and virtio-bus doesn't have get_fw_dev_path implementation, > > typename will be added

Re: [Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction

2013-05-30 Thread Eric Blake
On 05/30/2013 06:34 AM, Stefan Hajnoczi wrote: > The Abort action can be used to test QMP 'transaction' failure. Add it > as the last action to exercise the .abort() and .cleanup() code paths > for all previous actions. Another thread questioned whether we should name this action __org.qemu-debug

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 09:15, Peter Crosthwaite ha scritto: >>> >> Hi Peter, Should we be putting r->access->name here instead of >>> >> "devcfg-regs"? >> > >> > Yes, that's why I preferred to wrap the memory_region_init_io into an >> > API that takes a RegisterInfo. :) > ACK, > > You've convinced me :).

Re: [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 03:04:39PM +0200, Paolo Bonzini wrote: > Il 30/05/2013 11:30, Michael S. Tsirkin ha scritto: > > Here are some patches fixing up minor issues > > in the tree reorganization. > > > > Michael S. Tsirkin (2): > > dec.c - move to pci-bridge > > firmware_abi: move to include

Re: [Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 11:30, Michael S. Tsirkin ha scritto: > Here are some patches fixing up minor issues > in the tree reorganization. > > Michael S. Tsirkin (2): > dec.c - move to pci-bridge > firmware_abi: move to include/hw/nvram/ > > hw/pci-bridge/Makefile.objs | 2 + > hw/pci-b

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 11:08, Peter Lieven ha scritto: > Am 30.05.2013 10:18, schrieb Alexey Kardashevskiy: >> On 05/30/2013 05:49 PM, Paolo Bonzini wrote: >>> Il 30/05/2013 09:44, Alexey Kardashevskiy ha scritto: Hi! I found the migration broken on pseries platform, specifically, this patch

Re: [Qemu-devel] [PATCH v19 4/7] pvpanic: pass configurable ioport to seabios

2013-05-30 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 10:14:43AM +0800, Hu Tao wrote: > This lets seabios patch the corresponding SSDT entry. > > Signed-off-by: Hu Tao > --- > hw/misc/pvpanic.c | 14 ++ > hw/nvram/fw_cfg.c | 8 +++- > include/hw/nvram/fw_cfg.h | 2 ++ > 3 files changed, 23 i

Re: [Qemu-devel] [PATCH] walk_pml4e(): fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-30 Thread Luiz Capitulino
On Tue, 28 May 2013 14:19:22 -0400 Luiz Capitulino wrote: > The code used to walk IA-32e page-tables, and possibly PAE page-tables, > uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. > > However, as we use a uint64_t to store the resulting address, that mask > gets expanded

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 02:32:01PM +0200, Gerd Hoffmann wrote: > On 05/30/13 14:19, Michael S. Tsirkin wrote: > > On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote: > >> Hi, > >> > >>> +} else { > >>> +guest_info->pci_info.w64.begin = 0x1ULL + > >>> above_4g_mem_s

Re: [Qemu-devel] [RFC] Check backing_file chain's loop

2013-05-30 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 06:12:00AM -0600, Eric Blake wrote: > On 05/30/2013 04:14 AM, Dongxu Wang wrote: > > Hi, > > > > Now block layer does not check whether backing_file chain can be a > > circle, do you think it is necessary to do a check? > > > > For example, 1.qcow2's backing_file is 2.qco

Re: [Qemu-devel] [Xen-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu, just like unplug the ide disk?

2013-05-30 Thread Pasi Kärkkäinen
On Thu, May 30, 2013 at 11:23:44AM +, Gonglei (Arei) wrote: > Hi all, > My environment is xen-4.1.2 + qemu-1.2.2 > I made a pvscsi driver for Redhat guest, but I encountered a problem > that I could see two scsi disks, one was simulated by QEMU, another was > passthrough. > Actu

[Qemu-devel] [PATCH v5 00/11] block: drive-backup live backup command

2013-05-30 Thread Stefan Hajnoczi
Note: These patches apply to kevin/block. You can also grab the code from git here: git://github.com/stefanha/qemu.git block-backup-core This series adds a new QMP command, drive-backup, which takes a point-in-time snapshot of a block device. The snapshot is copied out to a target block device.

[Qemu-devel] [PATCH v5 01/11] notify: add NotiferWithReturn so notifier list can abort

2013-05-30 Thread Stefan Hajnoczi
notifier_list_notify() has no return value. This is fine when we just want to invoke side-effects. Sometimes it's useful for notifiers to produce a return value. This allows notifiers to "veto" an operation and will be used by the block layer before-write notifier. Signed-off-by: Stefan Hajnocz

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 02:25:41PM +0200, Laszlo Ersek wrote: > I can't offer any opinion about the values you put into w32 and w64, but I > have some remarks. > > First, please consider passing -O/path/to/some/order_file to > git-format-patch, so that .h files show up at the top of each patch.

[Qemu-devel] [PATCH v5 06/11] block: add drive-backup QMP command

2013-05-30 Thread Stefan Hajnoczi
@drive-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing drive-backup operations can be checked with query-block-jobs where the BlockJobInfo.type field has the value 'backup'. The operation can be stopped before it has completed using the block-job-ca

[Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-05-30 Thread Stefan Hajnoczi
From: Dietmar Maurer backup_start() creates a block job that copies a point-in-time snapshot of a block device to a target block device. We call backup_do_cow() for each write during backup. That function reads the original data from the block device before it gets overwritten. The data is then

[Qemu-devel] [PATCH v5 11/11] qemu-iotests: add 055 drive-backup test case

2013-05-30 Thread Stefan Hajnoczi
Testing drive-backup is similar to image streaming and drive mirroring. This test case is based on 041. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/055 | 256 + tests/qemu-iotests/055.out | 5 + tests/qemu-iotests/group | 1 + 3 fil

Re: [Qemu-devel] [PATCH] gdbstub: do not restart crashed guest

2013-05-30 Thread Luiz Capitulino
On Thu, 30 May 2013 13:55:50 +0200 Laszlo Ersek wrote: > On 05/30/13 13:20, Paolo Bonzini wrote: > > If a guest has crashed with an internal error or similar, detaching > > gdb (or any other debugger action) should not restart it. > > > > Cc: Jan Kiszka > > Signed-off-by: Paolo Bonzini > > ---

[Qemu-devel] [PATCH v5 02/11] block: add bdrv_add_before_write_notifier()

2013-05-30 Thread Stefan Hajnoczi
The bdrv_add_before_write_notifier() function installs a callback that is invoked before a write request is processed. This will be used to implement copy-on-write point-in-time snapshots where we need to copy out old data before overwriting it. Note that BdrvTrackedRequest is moved to block_int.

[Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror()

2013-05-30 Thread Stefan Hajnoczi
Use bdrv_getlength() for its byte units and error return instead of bdrv_get_geometry(). Reported-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- blockdev.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 01db519..73b175b 100644 ---

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Laszlo Ersek
On 05/30/13 14:19, David Woodhouse wrote: > Yeah, but if we're shoving a lot of hardware-specific ACPI table > generation into the guest's firmware, instead of just doing it on the > qemu side where a number of us seem to think it belongs, then there *is* > a benefit to using Coreboot. When stuff

[Qemu-devel] [PATCH v5 07/11] blockdev: rename BlkTransactionStates to singular

2013-05-30 Thread Stefan Hajnoczi
The QMP 'transaction' command keeps a list of in-flight transactions. The transaction state structure is called BlkTransactionStates even though it only deals with a single transaction. The only plural thing is the linked list of transaction states. I find it confusing to call the single structur

[Qemu-devel] [PATCH v5 09/11] blockdev: add DriveBackup transaction

2013-05-30 Thread Stefan Hajnoczi
This patch adds a transactional version of the drive-backup QMP command. It allows atomic snapshots of multiple drives along with automatic cleanup if there is a failure to start one of the backup jobs. Note that QMP events are emitted for block job completion/cancellation and the block job will b

[Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-05-30 Thread Stefan Hajnoczi
It is not necessary to check that we can find a protocol block driver since we create or open the image file. This produces the error that we need anyway. Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the protocol is incorrect rather than the format. Also drop an empty line betwe

[Qemu-devel] [PATCH v5 08/11] blockdev: allow BdrvActionOps->commit() to be NULL

2013-05-30 Thread Stefan Hajnoczi
Some QMP 'transaction' types don't need to do anything on .commit(). Make .commit() optional just like .abort(). The "drive-backup" action will take advantage of this, it only needs to cancel the block job on .abort(). Other block job actions will probably follow the same pattern, so allow .commi

[Qemu-devel] [PATCH v5 10/11] blockdev: add Abort transaction

2013-05-30 Thread Stefan Hajnoczi
The Abort action can be used to test QMP 'transaction' failure. Add it as the last action to exercise the .abort() and .cleanup() code paths for all previous actions. Signed-off-by: Stefan Hajnoczi --- blockdev.c | 15 +++ qapi-schema.json | 13 - 2 files changed,

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Gerd Hoffmann
On 05/30/13 14:19, Michael S. Tsirkin wrote: > On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote: >> Hi, >> >>> +} else { >>> +guest_info->pci_info.w64.begin = 0x1ULL + >>> above_4g_mem_size; >>> +guest_info->pci_info.w64.end = guest_info->pci_info.w64.be

Re: [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver

2013-05-30 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 5:37 AM, Fam Zheng wrote: > On Mon, 04/29 09:42, Stefan Hajnoczi wrote: >> + >> +static void coroutine_fn backup_run(void *opaque) >> +{ >> +BackupBlockJob *job = opaque; >> +BlockDriverState *bs = job->common.bs; >> +assert(bs); >> + >> +int64_t start, end;

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 01:19:18PM +0100, David Woodhouse wrote: > Yeah, but if we're shoving a lot of hardware-specific ACPI table > generation into the guest's firmware, instead of just doing it on the > qemu side where a number of us seem to think it belongs, Hopefully this is not yet set in st

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Laszlo Ersek
I can't offer any opinion about the values you put into w32 and w64, but I have some remarks. First, please consider passing -O/path/to/some/order_file to git-format-patch, so that .h files show up at the top of each patch. On 05/30/13 13:07, Michael S. Tsirkin wrote: > Will be used to pass hol

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread David Woodhouse
On Thu, 2013-05-30 at 13:13 +0200, Laszlo Ersek wrote: > Where is CorebootPkg available from? https://github.com/pgeorgi/edk2/tree/coreboot-pkg > > And it helps to dispel the stupid misconception in some quarters that > > Coreboot *competes* with UEFI and thus cannot possibly be supported > > bec

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 02:16:13PM +0200, Gerd Hoffmann wrote: > Hi, > > > +} else { > > +guest_info->pci_info.w64.begin = 0x1ULL + > > above_4g_mem_size; > > +guest_info->pci_info.w64.end = guest_info->pci_info.w64.begin + > > +(0x1ULL << 62); > > Does

Re: [Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Gerd Hoffmann
Hi, > +} else { > +guest_info->pci_info.w64.begin = 0x1ULL + above_4g_mem_size; > +guest_info->pci_info.w64.end = guest_info->pci_info.w64.begin + > +(0x1ULL << 62); Doesn't this give unaligned windows? > +/* Set PCI window size the way seabios has

Re: [Qemu-devel] [RFC] Check backing_file chain's loop

2013-05-30 Thread Eric Blake
On 05/30/2013 04:14 AM, Dongxu Wang wrote: > Hi, > > Now block layer does not check whether backing_file chain can be a > circle, do you think it is necessary to do a check? > > For example, 1.qcow2's backing_file is 2.qcow2 and 2.qcow2's > backing_file is 1.qcow2, then any IO operation will be

Re: [Qemu-devel] [Qemu-stable] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-30 Thread Stefan Priebe - Profihost AG
Am 29.05.2013 09:56, schrieb Amos Kong: > Recent virtio refactoring in QEMU made virtio-bus become the parent bus > of scsi-bus, and virtio-bus doesn't have get_fw_dev_path implementation, > typename will be added to fw_dev_path by default, the new fw_dev_path > could not be identified by seabios.

Re: [Qemu-devel] Unable to parse -device drivers containing commas?

2013-05-30 Thread Eric Blake
On 05/30/2013 04:00 AM, Mark Cave-Ayland wrote: > Hi all, > > I found that the QEMU -device command line parser doesn't seem to like > driver names containing a comma such as "SUNW,tcx" for the video driver > on qemu-system-sparc: > > $ ./qemu-system-sparc -device SUNW,tcx,help > Is there a way

Re: [Qemu-devel] [PATCH] gdbstub: do not restart crashed guest

2013-05-30 Thread Laszlo Ersek
On 05/30/13 13:20, Paolo Bonzini wrote: > If a guest has crashed with an internal error or similar, detaching > gdb (or any other debugger action) should not restart it. > > Cc: Jan Kiszka > Signed-off-by: Paolo Bonzini > --- > gdbstub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-

Re: [Qemu-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu, just like unplug the ide disk?

2013-05-30 Thread Laszlo Ersek
On 05/30/13 13:23, Gonglei (Arei) wrote: > Hi all, > My environment is xen-4.1.2 + qemu-1.2.2 > I made a pvscsi driver for Redhat guest, but I encountered a problem > that I could see two scsi disks, one was simulated by QEMU, another was > passthrough. > Actually I want to unplug t

[Qemu-devel] [PVSCSI]How to unplug scsi disk simulated by Qemu, just like unplug the ide disk?

2013-05-30 Thread Gonglei (Arei)
Hi all, My environment is xen-4.1.2 + qemu-1.2.2 I made a pvscsi driver for Redhat guest, but I encountered a problem that I could see two scsi disks, one was simulated by QEMU, another was passthrough. Actually I want to unplug the scsi disk simulated. Any methods can solve the

[Qemu-devel] [PATCH] gdbstub: do not restart crashed guest

2013-05-30 Thread Paolo Bonzini
If a guest has crashed with an internal error or similar, detaching gdb (or any other debugger action) should not restart it. Cc: Jan Kiszka Signed-off-by: Paolo Bonzini --- gdbstub.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index e80e1d3..90e

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread Laszlo Ersek
On 05/30/13 11:23, David Woodhouse wrote: > On Wed, 2013-05-29 at 11:18 -0500, Anthony Liguori wrote: >> >>> Certainly an option, but that is a long-term project. >> >> Out of curiousity, are there other benefits to using coreboot as a core >> firmware in QEMU? >> >> Is there a payload we would eve

[Qemu-devel] [PATCH v2 3/5] pc: pass PCI hole ranges to Guests

2013-05-30 Thread Michael S. Tsirkin
Guest currently has to jump through lots of hoops to guess the PCI hole ranges. It's fragile, and makes us change BIOS each time we add a new chipset. Let's report the window in a ROM file, to make BIOS do exactly what QEMU intends. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 21 +

Re: [Qemu-devel] [PATCH v4 0/3] ARM aarch64 TCG target

2013-05-30 Thread Peter Maydell
On 29 May 2013 10:04, Claudio Fontana wrote: > > This series implements preliminary support for the ARM aarch64 TCG target. Reviewed-by: Peter Maydell Cc'd some people who might like to commit the patchset. thanks -- PMM

[Qemu-devel] [PATCH v2 4/5] pc: add 1.6 compat type

2013-05-30 Thread Michael S. Tsirkin
Identical to 1.5 ATM, but changes will accumulate. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index eaff0b6..2717d83 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/p

[Qemu-devel] [PATCH v2 5/5] pc: pci-info add compat support

2013-05-30 Thread Michael S. Tsirkin
We can't change fw cfg entries or add new ones without breaking cross version migration. Add a flag to skip adding new entry when running with 1.5 compat machine type. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 7 ++- hw/i386/pc_piix.c| 12 ++-- include/hw/i386

[Qemu-devel] [PATCH v2 0/5] pc: pass pci window data to guests

2013-05-30 Thread Michael S. Tsirkin
This makes it possible for bios to load pci window data from host. This makes it possible for host to make sure setup matches hardware exactly. This will also make it easier to add more chipsets down the road. Ranges are passed within a generic GuestInfo structure, can add more fields of interest

[Qemu-devel] [PATCH v2 1/5] range: add Range structure

2013-05-30 Thread Michael S. Tsirkin
Sometimes we need to pass ranges around, add a handy structure for this purpose. Note: memory.c defines its own concept of AddrRange structure for working with 128 addresses. It's necessary there for doing range math. This is not needed for most users: struct Range is much simpler, and is only us

[Qemu-devel] [PATCH v2 2/5] pci: store PCI hole ranges in guestinfo structure

2013-05-30 Thread Michael S. Tsirkin
Will be used to pass hole ranges to guests. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 39 ++- hw/i386/pc_piix.c | 14 +- hw/i386/pc_q35.c | 6 +- hw/pci-host/q35.c | 4 include/hw/i386/pc.

[Qemu-devel] Why some test suite in kvm-unit-tests designed for 64bit only?

2013-05-30 Thread 李春奇
Hi there, I'm now reading codes of kvm-unit-tests and I found that some of the test cases for x86 is only designed for x86_64 (including access.flat, apic.flat, emulator.flat, idt_test.flat and so on). I wonder why these cases are not designed for i386? Or is there any other concerns? Thanks, Arth

[Qemu-devel] [PATCH V19 6/8] add debug event for add-cow

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang Signed-off-by: Dong Xu Wang Signed-off-by: Dongxu Wang --- block/blkdebug.c | 3 +++ block/block-cache.c | 4 ++-- include/block/block.h | 3 +++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 71f99e4..2bd6a53

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Peter Maydell
On 30 May 2013 08:44, Alexey Kardashevskiy wrote: > I found the migration broken on pseries platform, specifically, this patch > broke it: > > f1c72795af573b24a7da5eb52375c9aba8a37972 > migration: do not sent zero pages in bulk stage > > The idea is not to send zero pages to the destination guest

[Qemu-devel] [RFC] Check backing_file chain's loop

2013-05-30 Thread Dongxu Wang
Hi, Now block layer does not check whether backing_file chain can be a circle, do you think it is necessary to do a check? For example, 1.qcow2's backing_file is 2.qcow2 and 2.qcow2's backing_file is 1.qcow2, then any IO operation will be a fault. If necessary, I will post a patch to fix.

Re: [Qemu-devel] [PATCH 5/5] memory: able to pin guest node memory to host node manually

2013-05-30 Thread Wanlong Gao
Any comments? > Use mbind to pin guest numa node memory to host nodes manually. > > If we are not able to pin memory to host node, we may meet the > cross node memory access performance regression. > > With this patch, we can add manual pinning host node like this: > -m 1024 -numa node,cpus=0,n

[Qemu-devel] [PATCH V19 5/8] Make block-cache.c be common interface

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang To use block-cache.c be common cache interface, we need to add some parameter to identify cache's type. Define a struct named BlockTableType, pass BlockTableType and table size parameters to block cache initialization function. v17-v18: 1) move struct to source file. 2) clust

[Qemu-devel] [PATCH V19 7/8] add-cow file format core code.

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. v18->v19: 1) add aio parallel write support. 2) fix flush method. v17-v18: 1) use error_report, not fprintf. 2) remove version field from header. 3) header_size is MAX(clus

[Qemu-devel] [PATCH V19 8/8] qemu-iotests: add add-cow iotests support

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang This patch will use qemu-iotests to test add-cow file format. v17-v18: 1) add 037 and 038 tests. Signed-off-by: Dong Xu Wang Signed-off-by: Dongxu Wang --- tests/qemu-iotests/017 | 2 +- tests/qemu-iotests/020 | 2 +- tests/qemu-iotests/037 | 2 +- tes

[Qemu-devel] [PATCH V19 3/8] qed_read_string to bdrv_read_string

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang Make qed_read_string function to a common interface, so move it to block.c. Signed-off-by: Dong Xu Wang Signed-off-by: Dongxu Wang --- block.c | 27 +++ block/qed.c | 34 -- include/block/block.

[Qemu-devel] [PATCH V19 2/8] make path_has_protocol non static

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang We will use path_has_protocol outside block.c, so just make it public. Reviewed-by: Michael Roth Signed-off-by: Dong Xu Wang Signed-off-by: Dongxu Wang --- block.c | 2 +- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH V19 4/8] rename qcow2-cache.c to block-cache.c

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang Block layer will use qcow2-cache as common cache code, so rename it to block-cache.c. v18->v19: 1) only rename, did not touch other code. Signed-off-by: Dongxu Wang --- block/Makefile.objs| 3 +- block/block-cache.c| 323 +++

[Qemu-devel] [PATCH V19 1/8] V18: docs: document for add-cow file format

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang Document for add-cow format, the usage and spec of add-cow are introduced. v18-v19: 1) backing_fmt and image_fmt NUL-terminated. 2) other fix. V17->V18: 1) remove version field. 2) header size is maximum value and cluster size value. 3) fix type. Signed-off-by: Dong Xu Wang

[Qemu-devel] [PATCH V19 0/8] add-cow file format

2013-05-30 Thread Dongxu Wang
It will introduce a new file format: add-cow. The add-cow file format makes it possible to perform copy-on-write on top of a raw disk image. When we know that no backing file clusters remain visible (e.g. we have streamed the entire image and copied all data from the backing file), then it is pos

[Qemu-devel] Unable to parse -device drivers containing commas?

2013-05-30 Thread Mark Cave-Ayland
Hi all, I found that the QEMU -device command line parser doesn't seem to like driver names containing a comma such as "SUNW,tcx" for the video driver on qemu-system-sparc: $ ./qemu-system-sparc -device SUNW,tcx,help qemu-system-sparc: -device SUNW,tcx,help: Parameter 'driver' expects device

[Qemu-devel] [PATCH V15 6/6] remove QEMUOptionParameter related functions and struct

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang Signed-off-by: Dongxu Wang --- include/qemu/option.h | 39 --- util/qemu-option.c| 285 -- 2 files changed, 324 deletions(-) diff --git a/include/qemu/option.h b/include/qemu/option.h index d63e447..d2d3f16 100644 ---

[Qemu-devel] [PATCH V15 3/6] Create four QemuOptsList related functions

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang This patch will create 4 functions, count_opts_list, qemu_opts_append, qemu_opts_free and qemu_opts_print_help, they will be used in following commits. v12->v13: 1) simply assert that neither argument has merge_lists set. 2) drop superfluous paranthesesis around p == first. v

[Qemu-devel] [PATCH V15 4/6] Create some QemuOpts functons

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang These functions will be used in next commit. qemu_opt_get_(*)_del functions are used to make sure we have the same behaviors as before: in block layer, after parsing a parameter value, parameter list will delete it to avoid parsing it twice. Signed-off-by: Dong Xu Wang v13-

[Qemu-devel] [PATCH V15 2/6] avoid duplication of default value in QemuOpts

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang This patch will move the default value entirely to QemuOptDesc. When getting the value of an option that hasn't been set, and QemuOptDesc has a default value, return that. Else, behave as before. Example: qemu_opt_get_number(opts, "foo", 42) If "foo" has been set in opts

[Qemu-devel] [PATCH V15 1/6] add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print

2013-05-30 Thread Dongxu Wang
From: Dong Xu Wang qemu_opts_print has no user now, so can re-write the function safely. qemu_opts_print will be used while using "qemu-img create", it will produce the same output as previous code. The behavior of this function has changed: 1. Print every possible option, whether a value has

[Qemu-devel] [PATCH V15 0/6] replace QEMUOptionParameter with QemuOpts parser

2013-05-30 Thread Dongxu Wang
These patches will replace QEMUOptionParameter with QemuOpts. Change logs please go to each patch's commit message. V14->V15: 1) Only delete enum QEMUOptionParType. Dong Xu Wang (6): add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print avoid duplication of default value in Qemu

[Qemu-devel] [PATCH 2/2] firmware_abi: move to include/hw/nvram/

2013-05-30 Thread Michael S. Tsirkin
firmware_abi.h with structs for OpenBIOS landed in hw/sparc/ by mistake - move it to hw/nvram/ alongside fw_cfg.h. In addition to sparc it's included from ppc mac_nvram.c and will need to include it from prep.c in the future. Cc: Andreas Färber Signed-off-by: Michael S. Tsirkin --- hw/sparc/su

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Alexey Kardashevskiy
On 05/30/2013 07:08 PM, Peter Lieven wrote: > Am 30.05.2013 10:18, schrieb Alexey Kardashevskiy: >> On 05/30/2013 05:49 PM, Paolo Bonzini wrote: >>> Il 30/05/2013 09:44, Alexey Kardashevskiy ha scritto: Hi! I found the migration broken on pseries platform, specifically, this patch >>

[Qemu-devel] [PATCH 1/2] dec.c - move to pci-bridge

2013-05-30 Thread Michael S. Tsirkin
Looks like dec.c is in pci-host by mistake. Moving it over to pci-bridge. Cc: Andreas Färber Signed-off-by: Michael S. Tsirkin --- hw/pci-bridge/Makefile.objs | 2 + hw/pci-bridge/dec.c | 156 hw/pci-bridge/dec.h | 10 +++ hw/pci-h

[Qemu-devel] [PATCH 0/2] fixup some fallback from tree reorg

2013-05-30 Thread Michael S. Tsirkin
Here are some patches fixing up minor issues in the tree reorganization. Michael S. Tsirkin (2): dec.c - move to pci-bridge firmware_abi: move to include/hw/nvram/ hw/pci-bridge/Makefile.objs | 2 + hw/pci-bridge/dec.c | 156 +++

[Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro

2013-05-30 Thread Michael S. Tsirkin
The implementation is wrong for kvm, and it's unused anyway. Drop it. Signed-off-by: Michael S. Tsirkin Message-id: 20130528102023.ga30...@redhat.com Signed-off-by: Anthony Liguori --- hw/virtio/virtio-pci.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/vi

[Qemu-devel] [PATCH] target-ppc kvm: save cr register

2013-05-30 Thread Alexey Kardashevskiy
This adds a missing code to save CR (condition register) via kvm_arch_put_registers(). kvm_arch_get_registers() already has it. Signed-off-by: Alexey Kardashevskiy --- target-ppc/kvm.c |5 + 1 file changed, 5 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 2bbc3b8..

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-30 Thread David Woodhouse
On Wed, 2013-05-29 at 11:18 -0500, Anthony Liguori wrote: > > > Certainly an option, but that is a long-term project. > > Out of curiousity, are there other benefits to using coreboot as a core > firmware in QEMU? > > Is there a payload we would ever plausibly use besides OVMF and SeaBIOS? I li

[Qemu-devel] [PATCH] target-ppc kvm: missing kvm_arch_init_irq_routing

2013-05-30 Thread Alexey Kardashevskiy
This adds an empty stub to make the compiler happy. Signed-off-by: Alexey Kardashevskiy --- target-ppc/kvm.c |4 1 file changed, 4 insertions(+) diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c index 3ab2946..2bbc3b8 100644 --- a/target-ppc/kvm.c +++ b/target-ppc/kvm.c @@ -1797,3 +1797

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Peter Lieven
Am 30.05.2013 10:18, schrieb Alexey Kardashevskiy: > On 05/30/2013 05:49 PM, Paolo Bonzini wrote: >> Il 30/05/2013 09:44, Alexey Kardashevskiy ha scritto: >>> Hi! >>> >>> I found the migration broken on pseries platform, specifically, this patch >>> broke it: >>> >>> f1c72795af573b24a7da5eb52375c9a

Re: [Qemu-devel] Fwd: [Qemu-discuss] pci-assign error

2013-05-30 Thread Jean Parpaillon
Dear Alex, Thank you for your answer. Unfortunately, I had not yet the opportunity to test it as I don't have a Kepler arch (I suppose it depends on it ?). I will keep you informed of the results. Regards, Jean Le 03/04/2013 20:16, Alex Williamson a écrit : > On Wed, 2013-04-03 at 16:26 +0200,

Re: [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 03:25:17PM +0800, Amos Kong wrote: > In QEMU, we set the firmware name of pc-i440fx to 'pci', and the > typename 'q35-pcihost' is set to the firmware name of q35 by default. > > The seabios matches pci devices by "/pci/@i0cf8", so q35 device > could not be identified, seabi

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Alexey Kardashevskiy
On 05/30/2013 05:49 PM, Paolo Bonzini wrote: > Il 30/05/2013 09:44, Alexey Kardashevskiy ha scritto: >> Hi! >> >> I found the migration broken on pseries platform, specifically, this patch >> broke it: >> >> f1c72795af573b24a7da5eb52375c9aba8a37972 >> migration: do not sent zero pages in bulk stage

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-30 Thread Julian Stecklina
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/30/2013 08:46 AM, Stefan Hajnoczi wrote: > On Wed, May 29, 2013 at 6:02 PM, Julian Stecklina > wrote: >> On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: >>> The fact that a single switch process has shared memory access >>> to all guests' RAM is

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Paolo Bonzini
Il 30/05/2013 09:44, Alexey Kardashevskiy ha scritto: > Hi! > > I found the migration broken on pseries platform, specifically, this patch > broke it: > > f1c72795af573b24a7da5eb52375c9aba8a37972 > migration: do not sent zero pages in bulk stage > > The idea is not to send zero pages to the dest

Re: [Qemu-devel] broken incoming migration

2013-05-30 Thread Alexey Kardashevskiy
Forgot some cc:. On 05/30/2013 05:44 PM, Alexey Kardashevskiy wrote: > Hi! > > I found the migration broken on pseries platform, specifically, this patch > broke it: > > f1c72795af573b24a7da5eb52375c9aba8a37972 > migration: do not sent zero pages in bulk stage > > The idea is not to send zero p

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-30 Thread Rusty Russell
Stefan Hajnoczi writes: > On Thu, May 30, 2013 at 7:23 AM, Rusty Russell wrote: >> On the receive side, what can we do better than readv? If we need to >> return to userspace to tell the guest that we've got a new packet, we >> don't win on latency. We might reduce syscall overhead with a >> mu

[Qemu-devel] broken incoming migration

2013-05-30 Thread Alexey Kardashevskiy
Hi! I found the migration broken on pseries platform, specifically, this patch broke it: f1c72795af573b24a7da5eb52375c9aba8a37972 migration: do not sent zero pages in bulk stage The idea is not to send zero pages to the destination guest which is expected to have 100% empty RAM. However on pser

Re: [Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci

2013-05-30 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 03:25:17PM +0800, Amos Kong wrote: > In QEMU, we set the firmware name of pc-i440fx to 'pci', and the > typename 'q35-pcihost' is set to the firmware name of q35 by default. > > The seabios matches pci devices by "/pci/@i0cf8", so q35 device > could not be identified, seabi

[Qemu-devel] [PATCH v3 2/2] i.MX: Rework functions/types name and use new styme initialization

2013-05-30 Thread Jean-Christophe DUBOIS
* use dynamic cast whenever possible. * Change function names to some more meanigfull prefix * Change type names to a more meanigfull one * use new style device intialization. Signed-off-by: Jean-Christophe DUBOIS --- Change since v1: * The patch has been divided in 2 sub-patches. One that deals

[Qemu-devel] [PATCH v3 1/2] i.MX: Implement a more complete version of the GPT timer.

2013-05-30 Thread Jean-Christophe DUBOIS
* implement compare 1 2 and 3 registers * simplify Debug printf Signed-off-by: Jean-Christophe DUBOIS --- Change since v1: * The patch has been divided in 2 sub-patches. One that deals with the added features (this one) and one dealing with the renaming. Change since v2: * move new style init

[Qemu-devel] [PATCH v3 0/2] i.MX: Improve GPT driver implementation

2013-05-30 Thread Jean-Christophe DUBOIS
This patch is improving the completness of the GPT timer implementation. It adds compare 2 and 3 register support to the already exiting compare 1 register. This patch is also moving to a more modern/robust/abstract implementation Last a global more meaningfull naming is applied. Note: We still d

Re: [Qemu-devel] [PATCH] pci: change typename of q35 to pci-q35

2013-05-30 Thread Amos Kong
On Thu, May 30, 2013 at 09:09:05AM +0300, Michael S. Tsirkin wrote: > On Thu, May 30, 2013 at 10:47:48AM +0800, Amos Kong wrote: > > In QEMU, we set the firmware name of pc-i440fx is 'pci', and set the > > firmware name of q35 is 'q35-pcihost'. > > > > The seabios pattern matching code isn't sophi

Re: [Qemu-devel] [PATCH 0/3] ide: Set BSY bit during FLUSH

2013-05-30 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 01:34:03PM +0200, Kevin Wolf wrote: > The test case depends on the qemu-io series I sent yesterday. > ("[PATCH 00/16] Make qemu-io commands available in the monitor") > > Andreas Färber (1): > ide: Set BSY bit during FLUSH > > Kevin Wolf (2): > blkdebug: Add BLKDBG_FLU

[Qemu-devel] [QEMU PATCH v2] pci: set firmware name of q35 to pci

2013-05-30 Thread Amos Kong
In QEMU, we set the firmware name of pc-i440fx to 'pci', and the typename 'q35-pcihost' is set to the firmware name of q35 by default. The seabios matches pci devices by "/pci/@i0cf8", so q35 device could not be identified, seabios fails to adjust the boot priority of q35 devices. This patch sets

Re: [Qemu-devel] [PATCH 3/3] ide-test: Add FLUSH CACHE test case

2013-05-30 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 01:34:06PM +0200, Kevin Wolf wrote: > +/* Check registers */ > +data = inb(IDE_BASE + reg_device); > +g_assert_cmpint(data & 0x10, ==, 0); assert_bit_clear() with a constant instead of the 0x10 magic number?

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-30 Thread Peter Crosthwaite
On Thu, May 30, 2013 at 3:08 AM, Paolo Bonzini wrote: > Il 29/05/2013 19:04, Edgar E. Iglesias ha scritto: >>> > +for (i = 0; i < R_MAX; ++i) { >>> > +RegisterInfo *r = &s->regs_info[i]; >>> > + >>> > +*r = (RegisterInfo) { >>> > +.data = &s->regs[i], >>> > +

Re: [Qemu-devel] [snabb-devel:308] Re: snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-30 Thread Luke Gorrie
On 30 May 2013 08:46, Stefan Hajnoczi wrote: > No, it's still security critical. If there were equivalent solutions > with better security then I'm sure people would accept them. It's > just that there isn't an equivalent solution yet :). > Security-wise this is where I would like to be in the

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-30 Thread Stefan Priebe - Profihost AG
Am 30.05.2013 00:29, schrieb mdroth: > On Wed, May 29, 2013 at 01:27:33PM -0400, Luiz Capitulino wrote: >> On Mon, 27 May 2013 12:59:25 -0500 >> mdroth wrote: >> >>> On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: Luiz Capitulino writes: > On Sun, 26 May 2013 10:33:

<    1   2   3